Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

[Sanket Mehta]

Hi,

PFA the revised patch for fts template node which includes dependency and
dependent route handling code.
Please do review it and if found proper please do commit it.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, Jan 28, 2016 at 7:21 PM, Sanket Mehta  wrote:

> Hi,
>
> I have created patch for "FTS Template" node in pgadmin4.
> Please do review it and let me know in case anything is missing.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_templates/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_templates/__init__.py
new file mode 100644
index 000..0535040
--- /dev/null
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_templates/__init__.py
@@ -0,0 +1,700 @@
+##
+#
+# pgAdmin 4 - PostgreSQL Tools
+#
+# Copyright (C) 2016, The pgAdmin Development Team
+# This software is released under the PostgreSQL Licence
+#
+##
+
+"""Defines views for management of Fts Template node"""
+
+import json
+from flask import render_template, make_response, current_app, request, jsonify
+from flask.ext.babel import gettext
+from pgadmin.utils.ajax import make_json_response, \
+make_response as ajax_response, internal_server_error
+from pgadmin.browser.utils import PGChildNodeView
+from pgadmin.browser.collection import CollectionNodeModule
+import pgadmin.browser.server_groups.servers.databases.schemas as schemas
+from pgadmin.utils.ajax import precondition_required
+from pgadmin.utils.driver import get_driver
+from config import PG_DEFAULT_DRIVER
+from functools import wraps
+
+
+class FtsTemplateModule(CollectionNodeModule):
+"""
+ class FtsTemplateModule(CollectionNodeModule)
+
+A module class for FTS Template node derived from CollectionNodeModule.
+
+Methods:
+---
+* __init__(*args, **kwargs)
+  - Method is used to initialize the FtsTemplateModule and it's base module.
+
+* get_nodes(gid, sid, did, scid)
+  - Method is used to generate the browser collection node.
+
+* node_inode()
+  - Method is overridden from its base class to make the node as leaf node.
+
+* script_load()
+  - Load the module script for FTS Template, when any of the schema node is
+initialized.
+"""
+NODE_TYPE = 'fts_template'
+COLLECTION_LABEL = gettext('Fts Templates')
+
+def __init__(self, *args, **kwargs):
+self.min_ver = None
+self.max_ver = None
+super(FtsTemplateModule, self).__init__(*args, **kwargs)
+
+def get_nodes(self, gid, sid, did, scid):
+"""
+Generate the collection node
+:param gid: group id
+:param sid: server id
+:param did: database id
+:param scid: schema id
+"""
+yield self.generate_browser_collection_node(scid)
+
+@property
+def node_inode(self):
+"""
+Override the property to make the node as leaf node
+"""
+return False
+
+@property
+def script_load(self):
+"""
+Load the module script for fts template, when any of the schema node is
+initialized.
+"""
+return schemas.SchemaModule.NODE_TYPE
+
+
+blueprint = FtsTemplateModule(__name__)
+
+
+class FtsTemplateView(PGChildNodeView):
+"""
+class FtsTemplateView(PGChildNodeView)
+
+A view class for FTS Tempalte node derived from PGChildNodeView. This class is
+responsible for all the stuff related to view like create/update/delete
+FTS template, showing properties of node, showing sql in sql pane.
+
+Methods:
+---
+* __init__(**kwargs)
+  - Method is used to initialize the FtsTemplateView and it's base view.
+
+* module_js()
+  - This property defines (if javascript) exists for this node.
+Override this property for your own logic
+
+* check_precondition()
+  - This function will behave as a decorator which will checks
+database connection before running view, it will also attaches
+manager,conn & template_path properties to self
+
+* list()
+  - This function is used to list all the  nodes within that collection.
+
+* nodes()
+  - This function will used to create all the child node within that collection.
+Here it will create all the FTS Template nodes.
+
+* properties(gid, sid, did, rg_id)
+  - This function will show the properties of the selected FTS Template node
+
+* create(gid, sid, did, rg_id)
+  - This function will create the new FTS Template object
+
+* update(gid, sid, did, rg_id)
+  - This function will update the data for the selected FTS Template node
+
+* delete(self, gid, sid, rg_id):
+  - This function will drop 

Re: [pgadmin-hackers] patch for cast module

[Sanket Mehta]

Hi,

PFA the revised patch as per your comments.
Please review it and let me know the feedback.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Tue, Feb 23, 2016 at 4:10 PM, Dave Page  wrote:

> Hi
>
> I've attached an update to this patch, in which I've done some
> word-smithing on various comments, and adjusted the SQL templates to
> improve the formatting.
>
> However, it looks like it's bit-rotted, as the dependents/dependencies
> display is throwing Python errors. Please fix and then I think it's just
> about ready to commit.
>
> Thanks.
>
>
> On Fri, Feb 19, 2016 at 11:03 AM, Sanket Mehta <
> sanket.me...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> PFA the revise patch.
>>
>> It includes changes according to your review comments as well as
>> dependency/dependent part also.
>>
>> Let me know in case anything is missing.
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Mon, Feb 15, 2016 at 10:25 PM, Dave Page  wrote:
>>
>>> And this time with the attachment...
>>>
>>> On Mon, Feb 15, 2016 at 4:53 PM, Dave Page  wrote:
>>>
 That's much better. Just a couple of comments now, partly based on an
 email I wrote earlier:

 - There is still inconsistency in comment style. Please see the
 attachment for an example. Note that there is *always* a space between the
 comment marker and text.

 - If I try to edit a cast, I can change the description - but no SQL is
 shown on the SQL tab, despite the comment being correctly applied when I
 hit save. The properties pane of the main window is also not updated.

 Otherwise, it looks fine.

 Thanks.

 On Mon, Feb 15, 2016 at 1:28 PM, Sanket Mehta <
 sanket.me...@enterprisedb.com> wrote:

> Hi,
>
> PFA the revised patch with all the required comments.
>
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Mon, Feb 15, 2016 at 4:18 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta <
>> sanket.me...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Regarding your suggestion of putting some comments in javascript, I
>>> think I have already put some comments regarding model data and their
>>> controls if any extended.
>>>
>>> Can you please let me know where exactly you think more comments are
>>> required?
>>>
>>
>> Hi
>>
>> The issue for me is that jQuery code isn't the easiest to read at the
>> best of times, with nested/anonymous functions and inline JSON etc. As I
>> look through the code for the various nodes in isolation, it's extremely
>> difficult to get a sense of what exactly each part of the code is doing. 
>> In
>> this example, what I see by reading the code is:
>>
>> - Define the required libraries (require.js stuff)
>> - Extend the collection class
>> - Extend the node class
>>   - Define an init function inline
>>   - Add the menu options
>>
>> That part is fairly easy to figure out (easier because there are
>> blank lines between the logical sections). From there though, it becomes
>> much harder;
>>
>> - There are no blank lines to separate logical code sections at all
>> between line 48 and 235 (there is one blank line, but it doesn't separate
>> code sections).
>> - There are 4 comments that I can see. The first two are identical,
>> and appear to have identical code blocks following them for reasons that
>> are not even remotely obvious.
>> - As a newcomer to this code, I'm wondering if it's purpose is to
>> define the backform model. If so, why is it not broken up into sections
>> with a comment to tell me what field each block handles, and any other
>> useful information I may need to know? If it's not, then what is it for?
>>
>> So... I'm not going to tell you exactly where to put comments,
>> because the point is that without spending a couple of hours 
>> understanding
>> this, I simply don't know. The point of the comments (and separation of
>> logical sections of code with blank lines) is to make it easy for another
>> developer (especially one as rusty as me) to read and understand, then 
>> fix
>> and improve. Be generous with comments, but don't use them unnecessarily
>> (e.g. "a = 1 // Set a to one").
>>
>> Of course, this is not just directed at you Sanket - it's something
>> all of us working on pgAdmin need to keep in mind.
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


 --
 Dave Page
 Blog: 

[pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

[Khushboo Vashi]

Hi,

Please find attached patch for the Foreign Table Module.

The patch will be modified after Types module implementation as we need to
populate Base Type  and some Type related validations from the Types module.

Please review it and let me know the feedback.

Thanks,
Khushboo
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
new file mode 100644
index 000..8d6727b
--- /dev/null
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
@@ -0,0 +1,1002 @@
+##
+#
+# pgAdmin 4 - PostgreSQL Tools
+#
+# Copyright (C) 2013 - 2016, The pgAdmin Development Team
+# This software is released under the PostgreSQL Licence
+#
+##
+
+"""The Foreign Table Module."""
+
+import json
+from flask import render_template, make_response, request, jsonify, \
+current_app
+from flask.ext.babel import gettext
+from pgadmin.utils.ajax import make_json_response, \
+make_response as ajax_response, internal_server_error
+from pgadmin.browser.utils import PGChildNodeView
+from pgadmin.browser.collection import CollectionNodeModule
+import pgadmin.browser.server_groups.servers.databases.schemas as schemas
+from pgadmin.utils.ajax import precondition_required
+from pgadmin.utils.driver import get_driver
+from config import PG_DEFAULT_DRIVER
+from functools import wraps
+import sys
+import traceback
+
+
+class ForeignTableModule(CollectionNodeModule):
+"""
+class ForeignTableModule(CollectionNodeModule):
+
+This class represents The Foreign Table Module.
+
+Methods:
+---
+* __init__(*args, **kwargs)
+  - Initialize the Foreign Table Module.
+
+* get_nodes(gid, sid, did, scid)
+  - Generate the Foreign Table collection node.
+
+* node_inode():
+  - Override this property to make the Foreign Table node as leaf node.
+
+* script_load()
+  - Load the module script for Foreign Table, when schema node is
+initialized.
+"""
+NODE_TYPE = 'foreign-table'
+COLLECTION_LABEL = gettext("Foreign Tables")
+
+def __init__(self, *args, **kwargs):
+super(ForeignTableModule, self).__init__(*args, **kwargs)
+self.min_ver = None
+self.max_ver = None
+
+def get_nodes(self, gid, sid, did, scid):
+"""
+Generate the Foreign Table collection node.
+"""
+yield self.generate_browser_collection_node(scid)
+
+@property
+def node_inode(self):
+"""
+Override this property to make the node as leaf node.
+"""
+return False
+
+@property
+def script_load(self):
+"""
+Load the module script for foreign table, when the
+schema node is initialized.
+"""
+return schemas.SchemaModule.NODE_TYPE
+
+
+blueprint = ForeignTableModule(__name__)
+
+
+class ForeignTableView(PGChildNodeView):
+"""
+class ForeignTableView(PGChildNodeView)
+
+This class inherits PGChildNodeView to get the different routes for
+the module.
+
+The class is responsible to Create, Read, Update and Delete operations for
+the Foreign Table.
+
+Methods:
+---
+* validate_request(f):
+  - Works as a decorator.
+Validating request on the request of create, update and modified SQL.
+
+* module_js():
+  - Overrides this property to define javascript for Foreign Table node.
+
+* check_precondition(f):
+  - Works as a decorator.
+  - Checks database connection status.
+  - Attach connection object and template path.
+
+* list(gid, sid, did, scid):
+  - List the Foreign Table.
+
+* nodes(gid, sid, did, scid):
+  - Returns all the Foreign Table to generate Nodes in the browser.
+
+* properties(gid, sid, did, scid, foid):
+  - Returns the Foreign Table properties.
+
+* get_schemas(gid, sid, did, scid, foid=None):
+  - Returns Schemas for the particular database.
+
+* get_collations(gid, sid, did, scid, foid=None):
+  - Returns Collations.
+
+* get_types(gid, sid, did, scid, foid=None):
+  - Returns Data Types.
+
+* get_foreign_servers(gid, sid, did, scid, foid=None):
+  - Returns the Foreign Servers.
+
+* get_tables(gid, sid, did, scid, foid=None):
+  - Returns the Foreign Tables as well as Plain Tables.
+
+* get_columns(gid, sid, did, scid, foid=None):
+  - Returns the Table Columns.
+
+* create(gid, sid, did, scid):
+  - Creates a new Foreign Table object.
+
+* update(gid, sid, did, scid, foid):
+  - Updates the Foreign Table object.
+
+* delete(gid, sid, did, scid, foid):
+  - Drops the Foreign Table object.
+
+* sql(gid, sid, did, scid, foid):
+  - Returns the SQL for the Foreign Table 

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

[Surinder Kumar]

Hi,

PFA patch with changes suggested by Dave

Please review the patch and let me know for any comments.

On Mon, Feb 15, 2016 at 4:37 PM, Dave Page  wrote:

> Hi
>
> On Mon, Feb 15, 2016 at 9:55 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch with following changes:
>>
>>1. Added "Create Extension" menu item in context menu of Database
>>node.
>>2. Added a new method "node_node" in ExtensionModule class. If a node
>>has child, returns True, otherwise False.
>>3. Fixed an issue in which icon won't display in create extension
>>link in context menu.
>>4. Added Docstring for the class and methods in python file and
>>proper commenting in js file.
>>5. Followed PEP-08 coding conventions.
>>
>>
> I haven't tested this, but a few initial comments:
>
> - The commenting of the JS code is better than I've seen in other patches
> \o/, but the commenting style is inconsistent. We should use /* */ for
> multi-line comments, and // for single line.
> -  The JS code could use some carefully introduced blank lines to help
> make it more readable.
>
Done

> - s/}else{/} else {/
>
Done

> - Dependency/depends display is missing (see previous email to Akshay).
> This is essential for this node!
>
Implemented dependency and depends

> - There's no pydoc comment introducing __init__.py
>
Added pydoc

> - Shouldn't "data='-- Modified SQL --'," be "data=gettext('-- Modified SQL
> --'),"?
>
Yes, it should be. Fixed.

>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


extension_v6.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] patch for cast module

[Dave Page]

Hi

I've attached an update to this patch, in which I've done some
word-smithing on various comments, and adjusted the SQL templates to
improve the formatting.

However, it looks like it's bit-rotted, as the dependents/dependencies
display is throwing Python errors. Please fix and then I think it's just
about ready to commit.

Thanks.

On Fri, Feb 19, 2016 at 11:03 AM, Sanket Mehta <
sanket.me...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA the revise patch.
>
> It includes changes according to your review comments as well as
> dependency/dependent part also.
>
> Let me know in case anything is missing.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Mon, Feb 15, 2016 at 10:25 PM, Dave Page  wrote:
>
>> And this time with the attachment...
>>
>> On Mon, Feb 15, 2016 at 4:53 PM, Dave Page  wrote:
>>
>>> That's much better. Just a couple of comments now, partly based on an
>>> email I wrote earlier:
>>>
>>> - There is still inconsistency in comment style. Please see the
>>> attachment for an example. Note that there is *always* a space between the
>>> comment marker and text.
>>>
>>> - If I try to edit a cast, I can change the description - but no SQL is
>>> shown on the SQL tab, despite the comment being correctly applied when I
>>> hit save. The properties pane of the main window is also not updated.
>>>
>>> Otherwise, it looks fine.
>>>
>>> Thanks.
>>>
>>> On Mon, Feb 15, 2016 at 1:28 PM, Sanket Mehta <
>>> sanket.me...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA the revised patch with all the required comments.



 Regards,
 Sanket Mehta
 Sr Software engineer
 Enterprisedb

 On Mon, Feb 15, 2016 at 4:18 PM, Dave Page  wrote:

>
>
> On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta <
> sanket.me...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Regarding your suggestion of putting some comments in javascript, I
>> think I have already put some comments regarding model data and their
>> controls if any extended.
>>
>> Can you please let me know where exactly you think more comments are
>> required?
>>
>
> Hi
>
> The issue for me is that jQuery code isn't the easiest to read at the
> best of times, with nested/anonymous functions and inline JSON etc. As I
> look through the code for the various nodes in isolation, it's extremely
> difficult to get a sense of what exactly each part of the code is doing. 
> In
> this example, what I see by reading the code is:
>
> - Define the required libraries (require.js stuff)
> - Extend the collection class
> - Extend the node class
>   - Define an init function inline
>   - Add the menu options
>
> That part is fairly easy to figure out (easier because there are blank
> lines between the logical sections). From there though, it becomes much
> harder;
>
> - There are no blank lines to separate logical code sections at all
> between line 48 and 235 (there is one blank line, but it doesn't separate
> code sections).
> - There are 4 comments that I can see. The first two are identical,
> and appear to have identical code blocks following them for reasons that
> are not even remotely obvious.
> - As a newcomer to this code, I'm wondering if it's purpose is to
> define the backform model. If so, why is it not broken up into sections
> with a comment to tell me what field each block handles, and any other
> useful information I may need to know? If it's not, then what is it for?
>
> So... I'm not going to tell you exactly where to put comments, because
> the point is that without spending a couple of hours understanding this, I
> simply don't know. The point of the comments (and separation of logical
> sections of code with blank lines) is to make it easy for another 
> developer
> (especially one as rusty as me) to read and understand, then fix and
> improve. Be generous with comments, but don't use them unnecessarily (e.g.
> "a = 1 // Set a to one").
>
> Of course, this is not just directed at you Sanket - it's something
> all of us working on pgAdmin need to keep in mind.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

[Dave Page]

Thanks - committed.

On Mon, Feb 22, 2016 at 1:23 PM, Akshay Joshi  wrote:

> Hi All
>
> Attached is the modified patch with support of Dependents and Dependencies
> tabs. Please review it.
>
> On Mon, Feb 22, 2016 at 5:29 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Feb 22, 2016 at 10:53 AM, Dave Page  wrote:
>>
>>>
>>>
>>> On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi All

 On Mon, Feb 15, 2016 at 3:47 PM, Dave Page  wrote:

>
>
> On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> Attached is the new patch after fixing review comments given by Dave.
>>
>> On Fri, Feb 12, 2016 at 10:04 PM, Dave Page 
>> wrote:
>>
>>>
>>>
>>> On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi,

 New language patch is working fine.
 Ashesh - Can you please review it ?
 If it looks good then can you please commit ?

 Thank you,
 Harshal

>>>
>>> A few comments:
>>>
>>> - We omitted CREATE LANGUAGE, as most are now extensions. Shouldn't
>>> we also therefore omit DROP LANGUAGE?
>>>
>> Fixed.
>>
>>> - Please leave a blank line between the file header and python code
>>> in python files.
>>>
>> Fixed.
>>
>>> - The pydoc module description is missing from __init__.py
>>>
>> Fixed.
>>
>>> - What about the Dependents and Dependencies tabs?
>>>
>>  Infrastructure is not ready, so not implemented yet.
>>
>
> The first person that needs it should be working on it! I don't want
> to be committing partially completed features, otherwise we'll have to 
> come
> back and revisit them all when the infrastructure is done.
>
> Having done it before for pgAdmin 3, I don't imagine it's hard. It's
> really just the same as the Statistics view. Please take a look at it
> (assuming noone else is already).
>

Fixed. Attached is the modified patch with support of Dependents and
 Dependencies tabs. Please review it.

>>>
>>> Committed, with a couple of additional minor changes:
>>>
>>> - s/resourcegroups/resource_groups (for consistency with server_groups)
>>>
>>> - Added a PyDoc module description to __init__.py
>>>
>>
>> Oops, wrong thread. Please ignore.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Add support for viewing/editing procedural languages.

[Dave Page]

Add support for viewing/editing procedural languages.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7ffbb8c0396ffe444ab4d70ebdb1841e1f947488
Author: Akshay Joshi 

Modified Files
--
.../servers/databases/languages/__init__.py| 520 +
.../languages/static/img/coll-language.png | Bin 0 -> 477 bytes
.../databases/languages/static/img/language.png| Bin 0 -> 465 bytes
.../languages/templates/languages/js/languages.js  | 192 
.../templates/languages/sql/9.1_plus/acl.sql   |  23 +
.../templates/languages/sql/9.1_plus/functions.sql |  15 +
.../languages/sql/9.1_plus/properties.sql  |  12 +
.../templates/languages/sql/9.1_plus/sqlpane.sql   |  19 +
.../templates/languages/sql/9.1_plus/update.sql|  38 ++
.../templates/languages/sql/9.3_plus/acl.sql   |  19 +
.../templates/languages/sql/9.3_plus/functions.sql |  15 +
.../languages/sql/9.3_plus/properties.sql  |  12 +
.../templates/languages/sql/9.3_plus/sqlpane.sql   |  19 +
.../templates/languages/sql/9.3_plus/update.sql|  38 ++
14 files changed, 922 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Fixed runtime compilation error for Qt4

[Dave Page]

Thanks, committed.

On Tue, Feb 23, 2016 at 7:51 AM, Neel Patel 
wrote:

> Hi All,
>
> As sandeep from EDB was doing the setup for pgAdmin4 runtimes in CentOS 7
> with Qt4 and found that there were some compilation errors.
>
> Please find the attached patch file which will fix the below compilation
> errors for Qt4.
>
>- QtWebKitWidgets should only be included in Qt5. There is no such
>header in Qt4.
>- QUrl class does not have "url()" function in Qt4 so when we compile
>the code in Qt4 it gives error saying "no such function url()". This is
>fixed by adding common method ( "host()" ) available in both the version of
>Qt.
>- In QTcpSocket class, there is no "bind" method available in Qt4 so
>it gives error during the compilation.
>- "QThread::sleep(1)" is the public method in Qt5 while it is
>protected in Qt4 so we can not use the same method in Qt4. We have written
>delay function to replace this method.
>- Removed "cache()" from Qt project file. Cache file is required by
>qmake to read special setting specified other then project and qmake.conf
>file, as we have not specified any special configuration other then project
>file so we have removed this function.
>
> We have tested in both the versions Qt4 and Qt5 and now it is compiling
> without any errors.
>
> Do review it and let us know in case of any comments/queries.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Runtime fixes for QT4 support.

[Dave Page]

Runtime fixes for QT4 support.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b7886e61edaad0dfaa242247b46982ee7a541f5
Author: Neel Patel 

Modified Files
--
runtime/BrowserWindow.cpp |  4 ++--
runtime/TabWindow.cpp |  1 +
runtime/WebViewWindow.h   |  4 
runtime/pgAdmin4.cpp  | 19 +++
runtime/pgAdmin4.h|  1 +
runtime/pgAdmin4.pro  |  2 --
6 files changed, 23 insertions(+), 8 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Improve Resource Group labels per discussion with Jas

[Dave Page]

Improve Resource Group labels per discussion with Jason.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2de7b4c0a087069185c4c438ce597725da4efb39

Modified Files
--
.../resource_groups/templates/resource_groups/js/resource_groups.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers