Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

[Murtuza Zabuawala]

Hi Dave,

Please test the patch with query provided by user,

SELECT
ARRAY[48994717597666517,48968053424532376,76561198004879311,76561198078757065,76561198086825618]::text
as good,
ARRAY[48994717597666520,48968053424532376,76561198004879311,76561198078757065,76561198086825618]
as bad

I was doing regression with some large arbitrary numbers due to which it
was converting it to numeric[] and numeric[] is already handled in our code.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Apr 20, 2017 at 7:18 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> That is strange.
>
> I tested on PG9.6 and it was working properly, What is the your PG
> version?
>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Apr 20, 2017 at 7:06 PM, Dave Page  wrote:
>
>>
>>
>> On Fri, Apr 14, 2017 at 2:28 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,

 PFA minor patch to fix the the issue with bigint[] array values as JS
 truncates long numbers from array object.
 RM#2272

>>>
>> Hi
>>
>> As far as I can see, this doesn't work as expected. The "bad" column is
>> interpreted as numeric[] on my machine, which I assume needs to be added to
>> the list as well?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Re: [pgadmin-hackers][patch] Move to Alembic migration system

[Ashesh Vashi]

Hi Joao & Oliver,

On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Hackers,
>
> @Ashesh thanks for the feedback
>
> Here is the reviewed patch with the suggestions of Ashesh.
>
> Disclaimer: We added a new patch file with the changes
>

I have made some more changes to the patch.
- 'with app.app_context(..)' statement was not required in the
'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade
function.
- We also need to create other directories (i.e. sessions, storage,
directory containing the log-file) during the setup/running the application
(if not exists).
- Added proper check in the pgAdmin4.wsgi file (if configuration file
exists, or not)

Please review it.

-- Thanks, Ashesh


alembic_migration_system.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview

[Khushboo Vashi]

Hi,

Please find the attached updated patch.
I have tested this patch on Ubuntu (Chrome & Firefox) and Mac (Chrome).

Thanks,
Khushboo

On Tue, Apr 18, 2017 at 7:25 PM, Dave Page  wrote:

> Unfortunately I had to revert this, as I found it was preventing
> treeview nodes from being collapsed again. I'm running in Google
> Chrome on Mac, if that helps narrow down the problem.
>
> On Tue, Apr 18, 2017 at 2:01 PM, Dave Page  wrote:
> > Thanks, patch applied.
> >
> > On Fri, Apr 14, 2017 at 5:02 AM, Khushboo Vashi
> >  wrote:
> >> Hi,
> >>
> >> Please find the attached patch to fix the RM #2339: Horizontal
> scrolling in
> >> the treeview.
> >>
> >> I wanted to change the pgadmin.css file to fix this issue but the
> aciTree
> >> library is located at browser/static/vendor/, so I have included this
> change
> >> in the browser/static/css/browser.css file.
> >>
> >>
> >> Thanks,
> >> Khushboo
> >>
> >>
> >>
> >> --
> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> >> To make changes to your subscription:
> >> http://www.postgresql.org/mailpref/pgadmin-hackers
> >>
> >
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/browser/static/css/browser.css b/web/pgadmin/browser/static/css/browser.css
index 3ad1dcd..b164860 100644
--- a/web/pgadmin/browser/static/css/browser.css
+++ b/web/pgadmin/browser/static/css/browser.css
@@ -45,3 +45,7 @@
 .pgadmin-node-select option {
   padding-left: 20px;
 }
+
+.aciTree .aciTreeLi div.aciTreeLine {
+  display: table !important;
+}

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Move to Alembic migration system

[Joao Pedro De Almeida Pereira]

Hello Hackers,

@Ashesh thanks for the feedback

Here is the reviewed patch with the suggestions of Ashesh.

Disclaimer: We added a new patch file with the changes


Thanks
Joao & Oliver

On Thu, Apr 20, 2017 at 10:56 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Thu, Apr 20, 2017 at 8:15 PM, Joao Pedro De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Ashesh,
>>
>> Did you had time to review this patch?
>>
> Yes - I did.
>
> Please my review comments:
> Everytime I start pgAdmin 4, I am getting now the following message:
> "pgAdmin 4 - Application Initialisation"
>
> Can we avoid that message?
> We are not providing any information during upgrade process.
> i.e. older version was so, and so, it will be upgraded to so, and so.
>
> It helps sometimes to while debugging the application.
>
> Rest looks fine to me.
>
> -- Thanks, Ashesh
>
>>
>> Thanks
>> Joao & Oliver
>>
>> On Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear 
>> wrote:
>>
>>> Great, thank you so much!
>>>
>>> On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>

 On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear 
 wrote:

> Hi Hackers!
>
 Hi Sarah,

>
> Is there an update on this?
>
 We will look in to it end of this week.
 I was not rushing to it, because - Dave was preparing for the 1.4
 release.

 -- Thanks, Ashesh

>
> Thanks,
> Sarah & Joao
>
> On Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear 
> wrote:
>
>> Hi Ashesh!
>>
>> Good catch. Looks like there was an override of the input function
>> that didn't get moved to the new file, causing the input with the @ to
>> fail. We also added headers to the files that were missing them. This new
>> patch should work.
>>
>> Thanks!
>> Joao & Sarah
>>
>>
>>
>> On Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 Hi Jaoao, Sarah,

 I've tried to run on fresh machine, it failed with the below error:

>>> And - I have noticed - the headers are missing in new files.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> 
>>>

 *$ python setup.py*
 *NOTE: Configuring authentication for SERVER mode.*

 *Enter the email address and password to use for the initial
 pgAdmin user account:*

 *Email address: ashesh.va...@enterprisedb.com
 *
 *Traceback (most recent call last):*
 *  File "setup.py", line 52, in *
 *db_upgrade(app)*
 *  File
 "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/db_upgrade.py",
 line 25, in db_upgrade*
 *flask_migrate.upgrade(migration_folder)*
 *  File
 "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/flask_migrate/__init__.py",
 line 244, in upgrade*
 *command.upgrade(config, revision, sql=sql, tag=tag)*
 *  File
 "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/command.py",
 line 254, in upgrade*
 *script.run_env()*
 *  File
 "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/script/base.py",
 line 416, in run_env*
 *util.load_python_file(self.dir, 'env.py')*
 *  File
 "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/pyfiles.py",
 line 93, in load_python_file*
 *module = load_module_py(module_id, path)*
 *  File
 "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/compat.py",
 line 75, in load_module_py*
 *mod = imp.load_source(module_id, path, fp)*
 *  File
 "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py",
 line 85, in *
 *run_migrations_online()*
 *  File
 "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py",
 line 78, in run_migrations_online*
 *context.run_migrations()*
 *  File "", line 8, in run_migrations*
 *  File
 "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/environment.py",
 line 

[pgadmin-hackers][patch] Update chrome driver to support chrome version 58 in tests

[Joao Pedro De Almeida Pereira]

Hi Hackers,

With the update to version 58 of chrome the version of the chrome driver of
Selenium need to be updated to version 2.29.

This patch does that change.

Note:
If you had previously installed the old driver you need to uninstall and
install again it.

$ pip uninstall chromedriver_installer
$ pip install -r regression/requirements.txt

​

Thanks
Joao & Oliver


0001-Change-chrome-driver-version-to-2.29-to-make-it-work.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Some questions about configuration and the pgadmin4-v1-web package

[Josh Berkus]

pgAdmin team, Devrim:

If I install the pgadmin4-v1-web package from Yum, it's a bit unclear on
what actual configuration needs to be done after that. Things I know
need to be done:

* running setup.py
* copying the httpd/conf.d/pgadmin4-web.conf.example file to a .conf file

Things I don't know if they need to be done:

1. creating data and log directories and assigning permissions on them
2. changing the permissions on the sqlite db
3. creating a config_local.py file and setting the five settings in it

Can you clarify?  I'm working on a container, and I'll also be happy to
contribute a doc if you can clarify via email.  Thanks.

-- 
Josh Berkus
Containers & Databases Oh My!


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

[Dave Page]

Hi

On Thu, Apr 20, 2017 at 7:39 PM, Shirley Wang  wrote:

> Hi!
>
> On Thu, Apr 20, 2017 at 4:18 AM Dave Page  wrote:
>
>> Hi
>>
>> On Tue, Apr 18, 2017 at 5:11 PM, Shirley Wang  wrote:
>>
>>> Hello Hackers,
>>>
>>> We've started to work on creating a style guide for pgAdmin4.
>>>
>>> Our goals with the style guide are to:
>>> - have a single source of truth for visual design and workflows
>>> - make it easier when adding or updating a section to the app to
>>> maintain consistency
>>>
>>
>> :-)
>>
>>
>>>
>>> How we'll know we're successful:
>>> - conversations about design are more high level, driven by user needs
>>> and pains
>>> - decreasing (or at least not adding to) current css bloat due to
>>> templating and overwrites
>>>
>>
>> Sounds good.
>>
>>
>>>
>>> Process for creating a style guide
>>> We're going to start from the smallest building blocks of the site and
>>> use that to define larger and larger components. Currently, we're taking
>>> inventory of current styles in the app, including colors, typography,
>>> buttons, dialogs etc.
>>>
>>> Given how the front end is currently structured, we were thinking that
>>> static documentation of styles would be a good MVP, at least until we
>>> determine what the best documentation for developers on the community would
>>> be. Attached is the inventory of styles as of now, including a Sketch file
>>> (a tool for creating design mockups, also where I've been keeping track of
>>> styles). You can also access files here on Google drive here:
>>> https://drive.google.com/drive/folders/0B7jMyxF3NH5lb2JxREUxclp1Unc?
>>> usp=sharing
>>>
>>
>> Also sounds good.
>>
>>
>>>
>>> Please feel free to edit the Sketch file- my only ask is new versions
>>> hare named accordingly.
>>>
>>
>> Is this the app you used? https://www.sketchapp.com/
>>
>
> Yes. Also, I recognize it's probably not the best tool, given that there's
> a 30 day free trial and then you need to purchase a license. I'm looking
> into other programs that are free.
>

FYI, we use LucidCharts internally. It's a pretty good Google Apps
integrated version of Microsoft Visio.


>
>
>
>> Some initial thoughts on the inventory:
>>
>> - Wow, that's a lot of colours. I didn't realise we had so many. I think
>> we need to work that down to a set of a dozen or less primary colours.
>>
>
> Me neither! I'm not so concerned with the number of different colors, but
> with the number of similar shades of each color.
>
> I can distill those down and send another email shortly.
>
>
>>
>>
> - I wouldn't worry about the button colour borders and gradients too much.
>> Those are standard bootstrap colours, so we should document them in terms
>> of bootstrap styles, not colour components.
>>
>
> Ok. But are they appropriate for this app?
>

Personally I think they're fine.


>
>
>> - We should change the browser list font and standardise on Helvetica
>> Neue.
>>
>
> Ok
>
>> - Is Helvetica Neue the best font for us? Our previous designer wanted to
>> use Droid Sans, which I wasn't so keen on, but is there a better option to
>> standardise on?
>>
>
> By standardize, do you mean only Helvetica throughout the app? I like
> Helvetica because it's a very readable typeface, but I'm not sure it's
> appropriate as the only typeface to use throughout the app.
>

Maybe, maybe not - what I do believe though is that the treeview doesn't
warrant an exception.


>
> The only other place I've noticed that uses a different typeface, ignoring
> query editor panel, is the data output panel (uses Verdana). I feel like in
> this case though, a distinction is useful since output data is different
> from body copy.
>

That's a good point.


>
>
>
>>
>> Oh, and an ironic side note: the one style that we have had for 20 years
>> now is the formatting/capitalisation of the "pgAdmin" name. You might want
>> to stop using pg_Admin :-p
>>
>>
> Ha ok will do
>
>
> Your other questions, copied and pasted here:
>
> - Should icons have a dividing line between them? I think so.
> I agree too. Makes it clear what the click area is. Or do you mean when
> there's a light blue shading and there should be a light blue line between
> icons?
>

With or without the shading, I think the light vertical line between those
buttons in the grid adds useful definition. They don't have a border like
the other various buttons, so it helps frame them (and I don't think they
should have a true border, as that would use too much space).


>
> - What determines the light blue shading of a row? I believe it should
> always be the one with focus (assuming there is one with focus)
> Yes, the one that's in focus.
>
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

[Shirley Wang]

Hi!

On Thu, Apr 20, 2017 at 4:18 AM Dave Page  wrote:

> Hi
>
> On Tue, Apr 18, 2017 at 5:11 PM, Shirley Wang  wrote:
>
>> Hello Hackers,
>>
>> We've started to work on creating a style guide for pgAdmin4.
>>
>> Our goals with the style guide are to:
>> - have a single source of truth for visual design and workflows
>> - make it easier when adding or updating a section to the app to maintain
>> consistency
>>
>
> :-)
>
>
>>
>> How we'll know we're successful:
>> - conversations about design are more high level, driven by user needs
>> and pains
>> - decreasing (or at least not adding to) current css bloat due to
>> templating and overwrites
>>
>
> Sounds good.
>
>
>>
>> Process for creating a style guide
>> We're going to start from the smallest building blocks of the site and
>> use that to define larger and larger components. Currently, we're taking
>> inventory of current styles in the app, including colors, typography,
>> buttons, dialogs etc.
>>
>> Given how the front end is currently structured, we were thinking that
>> static documentation of styles would be a good MVP, at least until we
>> determine what the best documentation for developers on the community would
>> be. Attached is the inventory of styles as of now, including a Sketch file
>> (a tool for creating design mockups, also where I've been keeping track of
>> styles). You can also access files here on Google drive here:
>> https://drive.google.com/drive/folders/0B7jMyxF3NH5lb2JxREUxclp1Unc?usp=sharing
>>
>
> Also sounds good.
>
>
>>
>> Please feel free to edit the Sketch file- my only ask is new versions
>> hare named accordingly.
>>
>
> Is this the app you used? https://www.sketchapp.com/
>

Yes. Also, I recognize it's probably not the best tool, given that there's
a 30 day free trial and then you need to purchase a license. I'm looking
into other programs that are free.


> Some initial thoughts on the inventory:
>
> - Wow, that's a lot of colours. I didn't realise we had so many. I think
> we need to work that down to a set of a dozen or less primary colours.
>

Me neither! I'm not so concerned with the number of different colors, but
with the number of similar shades of each color.

I can distill those down and send another email shortly.


>
>
- I wouldn't worry about the button colour borders and gradients too much.
> Those are standard bootstrap colours, so we should document them in terms
> of bootstrap styles, not colour components.
>

Ok. But are they appropriate for this app?


> - We should change the browser list font and standardise on Helvetica Neue.
>

Ok

> - Is Helvetica Neue the best font for us? Our previous designer wanted to
> use Droid Sans, which I wasn't so keen on, but is there a better option to
> standardise on?
>

By standardize, do you mean only Helvetica throughout the app? I like
Helvetica because it's a very readable typeface, but I'm not sure it's
appropriate as the only typeface to use throughout the app.

The only other place I've noticed that uses a different typeface, ignoring
query editor panel, is the data output panel (uses Verdana). I feel like in
this case though, a distinction is useful since output data is different
from body copy.



>
> Oh, and an ironic side note: the one style that we have had for 20 years
> now is the formatting/capitalisation of the "pgAdmin" name. You might want
> to stop using pg_Admin :-p
>
>
Ha ok will do


Your other questions, copied and pasted here:

- Should icons have a dividing line between them? I think so.
I agree too. Makes it clear what the click area is. Or do you mean when
there's a light blue shading and there should be a light blue line between
icons?

- What determines the light blue shading of a row? I believe it should
always be the one with focus (assuming there is one with focus)
Yes, the one that's in focus.

Re: [pgadmin-hackers] [patch] Query Output Header Width

[Dave Page]

On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili 
wrote:

> Hello Hackers,
>
> We found that having the column header extend all the way across the query
> output frame made it seem like there were more columns. This was confusing
> to some users.
>
> We made a change to the column header styling so it ends with the
> rightmost column.
>
> Happy Friday!
> Matt & Shirley & George
>

Hi Matt & Shirley & George!

I agree with the basic premise of this patch, however it has the
side-effect of removing the bottom border from the entire header row, which
makes the transition from the header ro to the first data row look very odd
(especially in the first row header, which essentially merges into the
top-left "select all" cell). Screenshot attached.

Can you get the line back in place, but so it only shows up under the
actual header cells?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Move to Alembic migration system

[Ashesh Vashi]

On Thu, Apr 20, 2017 at 8:15 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Ashesh,
>
> Did you had time to review this patch?
>
Yes - I did.

Please my review comments:
Everytime I start pgAdmin 4, I am getting now the following message:
"pgAdmin 4 - Application Initialisation"

Can we avoid that message?
We are not providing any information during upgrade process.
i.e. older version was so, and so, it will be upgraded to so, and so.

It helps sometimes to while debugging the application.

Rest looks fine to me.

-- Thanks, Ashesh

>
> Thanks
> Joao & Oliver
>
> On Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear 
> wrote:
>
>> Great, thank you so much!
>>
>> On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>>
>>> On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear 
>>> wrote:
>>>
 Hi Hackers!

>>> Hi Sarah,
>>>

 Is there an update on this?

>>> We will look in to it end of this week.
>>> I was not rushing to it, because - Dave was preparing for the 1.4
>>> release.
>>>
>>> -- Thanks, Ashesh
>>>

 Thanks,
 Sarah & Joao

 On Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear 
 wrote:

> Hi Ashesh!
>
> Good catch. Looks like there was an override of the input function
> that didn't get moved to the new file, causing the input with the @ to
> fail. We also added headers to the files that were missing them. This new
> patch should work.
>
> Thanks!
> Joao & Sarah
>
>
>
> On Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Hi Jaoao, Sarah,
>>>
>>> I've tried to run on fresh machine, it failed with the below error:
>>>
>> And - I have noticed - the headers are missing in new files.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
>>> *$ python setup.py*
>>> *NOTE: Configuring authentication for SERVER mode.*
>>>
>>> *Enter the email address and password to use for the initial pgAdmin
>>> user account:*
>>>
>>> *Email address: ashesh.va...@enterprisedb.com
>>> *
>>> *Traceback (most recent call last):*
>>> *  File "setup.py", line 52, in *
>>> *db_upgrade(app)*
>>> *  File
>>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/db_upgrade.py",
>>> line 25, in db_upgrade*
>>> *flask_migrate.upgrade(migration_folder)*
>>> *  File
>>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/flask_migrate/__init__.py",
>>> line 244, in upgrade*
>>> *command.upgrade(config, revision, sql=sql, tag=tag)*
>>> *  File
>>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/command.py",
>>> line 254, in upgrade*
>>> *script.run_env()*
>>> *  File
>>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/script/base.py",
>>> line 416, in run_env*
>>> *util.load_python_file(self.dir, 'env.py')*
>>> *  File
>>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/pyfiles.py",
>>> line 93, in load_python_file*
>>> *module = load_module_py(module_id, path)*
>>> *  File
>>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/compat.py",
>>> line 75, in load_module_py*
>>> *mod = imp.load_source(module_id, path, fp)*
>>> *  File
>>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py",
>>> line 85, in *
>>> *run_migrations_online()*
>>> *  File
>>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py",
>>> line 78, in run_migrations_online*
>>> *context.run_migrations()*
>>> *  File "", line 8, in run_migrations*
>>> *  File
>>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/environment.py",
>>> line 817, in run_migrations*
>>> *self.get_context().run_migrations(**kw)*
>>> *  File
>>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/migration.py",
>>> line 323, in run_migrations*
>>> *step.migration_fn(**kw)*
>>> *  File
>>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migrations/versions/fdc58d9bd449_.py",
>>> line 84, in upgrade*

Re: [pgadmin-hackers][patch] Move to Alembic migration system

[Joao Pedro De Almeida Pereira]

Hello Ashesh,

Did you had time to review this patch?

Thanks
Joao & Oliver

On Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear  wrote:

> Great, thank you so much!
>
> On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>>
>> On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear 
>> wrote:
>>
>>> Hi Hackers!
>>>
>> Hi Sarah,
>>
>>>
>>> Is there an update on this?
>>>
>> We will look in to it end of this week.
>> I was not rushing to it, because - Dave was preparing for the 1.4 release.
>>
>> -- Thanks, Ashesh
>>
>>>
>>> Thanks,
>>> Sarah & Joao
>>>
>>> On Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear 
>>> wrote:
>>>
 Hi Ashesh!

 Good catch. Looks like there was an override of the input function that
 didn't get moved to the new file, causing the input with the @ to fail. We
 also added headers to the files that were missing them. This new patch
 should work.

 Thanks!
 Joao & Sarah



 On Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Jaoao, Sarah,
>>
>> I've tried to run on fresh machine, it failed with the below error:
>>
> And - I have noticed - the headers are missing in new files.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> *$ python setup.py*
>> *NOTE: Configuring authentication for SERVER mode.*
>>
>> *Enter the email address and password to use for the initial pgAdmin
>> user account:*
>>
>> *Email address: ashesh.va...@enterprisedb.com
>> *
>> *Traceback (most recent call last):*
>> *  File "setup.py", line 52, in *
>> *db_upgrade(app)*
>> *  File
>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/db_upgrade.py",
>> line 25, in db_upgrade*
>> *flask_migrate.upgrade(migration_folder)*
>> *  File
>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/flask_migrate/__init__.py",
>> line 244, in upgrade*
>> *command.upgrade(config, revision, sql=sql, tag=tag)*
>> *  File
>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/command.py",
>> line 254, in upgrade*
>> *script.run_env()*
>> *  File
>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/script/base.py",
>> line 416, in run_env*
>> *util.load_python_file(self.dir, 'env.py')*
>> *  File
>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/pyfiles.py",
>> line 93, in load_python_file*
>> *module = load_module_py(module_id, path)*
>> *  File
>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/compat.py",
>> line 75, in load_module_py*
>> *mod = imp.load_source(module_id, path, fp)*
>> *  File
>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py",
>> line 85, in *
>> *run_migrations_online()*
>> *  File
>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py",
>> line 78, in run_migrations_online*
>> *context.run_migrations()*
>> *  File "", line 8, in run_migrations*
>> *  File
>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/environment.py",
>> line 817, in run_migrations*
>> *self.get_context().run_migrations(**kw)*
>> *  File
>> "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/migration.py",
>> line 323, in run_migrations*
>> *step.migration_fn(**kw)*
>> *  File
>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migrations/versions/fdc58d9bd449_.py",
>> line 84, in upgrade*
>> *email, password = user_info()*
>> *  File
>> "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/user_info.py",
>> line 50, in user_info*
>> *email = input("Email address: ")*
>> *  File "", line 1*
>> *ashesh.va...@enterprisedb.com *
>> *^*
>> *SyntaxError: invalid syntax*
>>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

[Murtuza Zabuawala]

That is strange.

I tested on PG9.6 and it was working properly, What is the your PG version?



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Apr 20, 2017 at 7:06 PM, Dave Page  wrote:

>
>
> On Fri, Apr 14, 2017 at 2:28 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi,
>>>
>>> PFA minor patch to fix the the issue with bigint[] array values as JS
>>> truncates long numbers from array object.
>>> RM#2272
>>>
>>
> Hi
>
> As far as I can see, this doesn't work as expected. The "bad" column is
> interpreted as numeric[] on my machine, which I assume needs to be added to
> the list as well?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool

[Dave Page]

On Fri, Apr 14, 2017 at 2:28 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>>
>> PFA minor patch to fix the the issue with bigint[] array values as JS
>> truncates long numbers from array object.
>> RM#2272
>>
>
Hi

As far as I can see, this doesn't work as expected. The "bad" column is
interpreted as numeric[] on my machine, which I assume needs to be added to
the list as well?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

[Dave Page]

Hi

On Tue, Apr 18, 2017 at 5:11 PM, Shirley Wang  wrote:

> Hello Hackers,
>
> We've started to work on creating a style guide for pgAdmin4.
>
> Our goals with the style guide are to:
> - have a single source of truth for visual design and workflows
> - make it easier when adding or updating a section to the app to maintain
> consistency
>

:-)


>
> How we'll know we're successful:
> - conversations about design are more high level, driven by user needs and
> pains
> - decreasing (or at least not adding to) current css bloat due to
> templating and overwrites
>

Sounds good.


>
> Process for creating a style guide
> We're going to start from the smallest building blocks of the site and use
> that to define larger and larger components. Currently, we're taking
> inventory of current styles in the app, including colors, typography,
> buttons, dialogs etc.
>
> Given how the front end is currently structured, we were thinking that
> static documentation of styles would be a good MVP, at least until we
> determine what the best documentation for developers on the community would
> be. Attached is the inventory of styles as of now, including a Sketch file
> (a tool for creating design mockups, also where I've been keeping track of
> styles). You can also access files here on Google drive here:
> https://drive.google.com/drive/folders/0B7jMyxF3NH5lb2
> JxREUxclp1Unc?usp=sharing
>

Also sounds good.


>
> Please feel free to edit the Sketch file- my only ask is new versions hare
> named accordingly.
>

Is this the app you used? https://www.sketchapp.com/

Some initial thoughts on the inventory:

- Wow, that's a lot of colours. I didn't realise we had so many. I think we
need to work that down to a set of a dozen or less primary colours.

- I wouldn't worry about the button colour borders and gradients too much.
Those are standard bootstrap colours, so we should document them in terms
of bootstrap styles, not colour components.

- We should change the browser list font and standardise on Helvetica Neue.

- Is Helvetica Neue the best font for us? Our previous designer wanted to
use Droid Sans, which I wasn't so keen on, but is there a better option to
standardise on?

Oh, and an ironic side note: the one style that we have had for 20 years
now is the formatting/capitalisation of the "pgAdmin" name. You might want
to stop using pg_Admin :-p

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company