[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ea8480a2493e396715e2fa0709c137b513a680aa Modified Files -- src/tools/msvc/gendef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/351d9b7d4e2539de6dd6b948a5ba128f07032b0b Modified Files -- src/tools/msvc/gendef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/562c50a4bf551f972384ceab135ea53969299641 Modified Files -- src/tools/msvc/gendef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a9d4625f485abd458f8fcc263f0003235430401e Modified Files -- src/tools/msvc/gendef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d5fb450aab740b52601b4bfb354c4be2662a940b Modified Files -- src/tools/msvc/gendef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0cf721244a819cbd67b2bc0a8c8a97adcb53944e Modified Files -- src/tools/msvc/gendef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/74d2c0dbfd94aa5512be3828a793b4c2d43df2d0 Modified Files -- src/tools/msvc/gendef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Undo inadvertent change in capitalization in commit 18fc4ec.
Undo inadvertent change in capitalization in commit 18fc4ec. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/adee9e4e317169463816d005e8bf901333271917 Modified Files -- src/backend/utils/adt/jsonb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Undo inadvertent change in capitalization in commit 18fc4ec.
Undo inadvertent change in capitalization in commit 18fc4ec. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa828819aa59a84b486837b4cc3d7afc739332f5 Modified Files -- src/backend/utils/adt/jsonb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Process variadic arguments consistently in json functions
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call method. Michael Paquier, reviewed by Tom Lane and Dmitry Dolgov. Backpatch to 9.5 for the jsonb fixes and 9.4 for the json fixes, as that's where they originated. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/06d5ba0d49d2ad756c14cad1d1281e8f8092d0b1 Modified Files -- src/backend/utils/adt/json.c| 84 src/backend/utils/adt/jsonb.c | 99 ++--- src/test/regress/expected/json.out | 107 src/test/regress/expected/jsonb.out | 105 +++ src/test/regress/sql/json.sql | 21 +++ src/test/regress/sql/jsonb.sql | 22 +++- 6 files changed, 306 insertions(+), 132 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to convert arguments on type "unknown" to to "text". Michael Paquier and me, reviewed by Tom Lane. Backpatch to 9.4 in order to support the following json bug fix. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5c3a1bbb4778c9a4db6982e1f54add3164c81488 Modified Files -- src/backend/utils/fmgr/funcapi.c | 115 ++- src/include/funcapi.h| 23 2 files changed, 137 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to convert arguments on type "unknown" to to "text". Michael Paquier and me, reviewed by Tom Lane. Backpatch to 9.4 in order to support the following json bug fix. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fb17082d787ec6fbd8fe850f19a58c4a0fae72b9 Modified Files -- src/backend/utils/fmgr/funcapi.c | 115 ++- src/include/funcapi.h| 23 2 files changed, 137 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to convert arguments on type "unknown" to to "text". Michael Paquier and me, reviewed by Tom Lane. Backpatch to 9.4 in order to support the following json bug fix. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f3c6e8a27a8f8436cada9a42e4f57338ed38c785 Modified Files -- src/backend/utils/fmgr/funcapi.c | 115 ++- src/include/funcapi.h| 23 2 files changed, 137 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Process variadic arguments consistently in json functions
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call method. Michael Paquier, reviewed by Tom Lane and Dmitry Dolgov. Backpatch to 9.5 for the jsonb fixes and 9.4 for the json fixes, as that's where they originated. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/18fc4ecf4afafe40bd7e7577bd611e5caf74c9fd Modified Files -- src/backend/utils/adt/json.c| 84 src/backend/utils/adt/jsonb.c | 99 ++--- src/test/regress/expected/json.out | 107 src/test/regress/expected/jsonb.out | 105 +++ src/test/regress/sql/json.sql | 21 +++ src/test/regress/sql/jsonb.sql | 22 +++- 6 files changed, 306 insertions(+), 132 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Process variadic arguments consistently in json functions
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call method. Michael Paquier, reviewed by Tom Lane and Dmitry Dolgov. Backpatch to 9.5 for the jsonb fixes and 9.4 for the json fixes, as that's where they originated. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/98efa5ebf0b44d9b5ac7ba0dccff3e4870b4d3c9 Modified Files -- src/backend/utils/adt/json.c| 84 src/backend/utils/adt/jsonb.c | 97 +--- src/test/regress/expected/json.out | 107 src/test/regress/expected/jsonb.out | 105 +++ src/test/regress/sql/json.sql | 21 +++ src/test/regress/sql/jsonb.sql | 22 +++- 6 files changed, 305 insertions(+), 131 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Process variadic arguments consistently in json functions
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call method. Michael Paquier, reviewed by Tom Lane and Dmitry Dolgov. Backpatch to 9.5 for the jsonb fixes and 9.4 for the json fixes, as that's where they originated. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9cb28e98b818288b70f165d08ddd295b799466c2 Modified Files -- src/backend/utils/adt/json.c | 84 + src/test/regress/expected/json.out | 107 + src/test/regress/sql/json.sql | 21 3 files changed, 152 insertions(+), 60 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to convert arguments on type "unknown" to to "text". Michael Paquier and me, reviewed by Tom Lane. Backpatch to 9.4 in order to support the following json bug fix. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7f89fc418223d7bfe5cafd5b781a84332954f82a Modified Files -- src/backend/utils/fmgr/funcapi.c | 115 ++- src/include/funcapi.h| 23 2 files changed, 137 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Process variadic arguments consistently in json functions
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call method. Michael Paquier, reviewed by Tom Lane and Dmitry Dolgov. Backpatch to 9.5 for the jsonb fixes and 9.4 for the json fixes, as that's where they originated. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3cc5f0550538e72de5245fa464a18d979278839e Modified Files -- src/backend/utils/adt/json.c| 84 src/backend/utils/adt/jsonb.c | 97 +--- src/test/regress/expected/json.out | 107 src/test/regress/expected/jsonb.out | 105 +++ src/test/regress/sql/json.sql | 21 +++ src/test/regress/sql/jsonb.sql | 22 +++- 6 files changed, 305 insertions(+), 131 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to convert arguments on type "unknown" to to "text". Michael Paquier and me, reviewed by Tom Lane. Backpatch to 9.4 in order to support the following json bug fix. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5c8dcd322c0ef38c257c80813de9afb0107ccc98 Modified Files -- src/backend/utils/fmgr/funcapi.c | 115 ++- src/include/funcapi.h| 23 2 files changed, 137 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.
On 10/10/2017 03:48 PM, Andres Freund wrote: > On 2017-10-09 23:33:36 -0400, Andrew Dunstan wrote: >> >> On 10/09/2017 07:15 PM, Andres Freund wrote: >>> Hi Andrew, >>> >>> On 2017-10-09 22:22:04 +, Andres Freund wrote: >>>> Add pg_strnlen() a portable implementation of strlen. >>>> >>>> As the OS version is likely going to be more optimized, fall back to >>>> it if available, as detected by configure. >>> I'm a bit confused, frogmouth >>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouth=2017-10-09%2022%3A30%3A41 >>> shows that it compiled the new code, but the configure output doesn't >>> show it ran through the new configure test. Additionally, without the >>> the config define, this should result in the replacement being >>> used. Which doesn't seem to be the case either. >>> >>> Kinda sounds like this used some halfway outdated build or such? >>> >> >> >> frogmouth is using some code not yet released that makes the config >> cache persistent. I just identified and fixed a stupid bug in the code >> that obsoletes the cache, and I have removed frogmouth's cache file and >> set it running again, so we'll see if that fixes things. > As far as I can tell it's still somehow using a configure from before > the last commits: > https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=frogmouth=2017-10-10%2018%3A35%3A06=configure > > Note that it's not running the new test. > > (there's definitely fixes to be made to where strnlen's replacement is > located, but regardless, this needs to be fixed too) > This test is governed by the test at line 946 of configure.in. You need to move it somewhere else. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.
On 10/09/2017 07:15 PM, Andres Freund wrote: > Hi Andrew, > > On 2017-10-09 22:22:04 +, Andres Freund wrote: >> Add pg_strnlen() a portable implementation of strlen. >> >> As the OS version is likely going to be more optimized, fall back to >> it if available, as detected by configure. > I'm a bit confused, frogmouth > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouth=2017-10-09%2022%3A30%3A41 > shows that it compiled the new code, but the configure output doesn't > show it ran through the new configure test. Additionally, without the > the config define, this should result in the replacement being > used. Which doesn't seem to be the case either. > > Kinda sounds like this used some halfway outdated build or such? > frogmouth is using some code not yet released that makes the config cache persistent. I just identified and fixed a stupid bug in the code that obsoletes the cache, and I have removed frogmouth's cache file and set it running again, so we'll see if that fixes things. cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.
On 09/30/2017 10:32 PM, Andres Freund wrote: >> Haven't tested on MSVC but with this patch it passes on jacana (mingw). > Yay! Thanks for testing. > I have now tested on bowerbird (MSVC) and it passes. This suggests that we can run tests there in cases where we can use IPC::Run's finish() instead of kill_kill(). Perhaps someone would like to look at the the two other cases where we do that (recovery/t/011_crash_recovery.pl and recovery/t/006_logical_decoding.pl) and see if they are amenable to this treatment. It woould be nice to be able to run all the tests on all platforms. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.
On 09/30/2017 06:44 PM, Andres Freund wrote:
> On 2017-09-30 15:27:12 -0700, Andres Freund wrote:
>> On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote:
>>> [re-adding commiters which I inadvertently left off]
>>>
>>>
>>> On 09/30/2017 06:10 PM, Andres Freund wrote:
>>>>
>>>>> I was just looking at this. Why aren't we using "pg_ctl kill" to
>>>>> terminate the backend? That's supposed to be portable.
>>>> Because pg_ctl can't do that for any process but postmaster, no? The
>>>> test is supposed to find issues with backend death (and has
>>>> defficiencies in error reporting already, and would have caught a bug
>>>> I'd introduced previously).
>>> No, I don't think so. That's not what the docs say. That's why you give
>>> it a pid argument" "pg_ctl kill signal_name process_id"
>> Oh, cool. Didn't know that one. So the answer is:
>> "Because Andres doesn't know squat.".
>>
>> But even after fixing that, there unfortunately is:
>>
>> static void
>> set_sig(char *signame)
>> {
>> …
>> #if 0
>> /* probably should NOT provide SIGKILL */
>> else if (strcmp(signame, "KILL") == 0)
>> sig = SIGKILL;
>> #endif
>>
>> I'm unclear on what that provision is achieving? If you can kill with
>> pg_ctl you can do other nasty stuff too (like just use kill instead of
>> pg_ctl)?
I put it in when we rewrote pg_ctl in C many years ago, possibly out of
a superabundance of caution. I agree it's worth revisiting. I think the
idea was that there's a difference between an ordinary footgun and an
officially sanctioned footgun :-)
> Could you perhaps test whether windows likes things after the following
> patch? I don't think the kill_kill guarantees are really needed here,
> so we might even be able to allow this on msvc.
>
Haven't tested on MSVC but with this patch it passes on jacana (mingw).
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.
[re-adding commiters which I inadvertently left off] On 09/30/2017 06:10 PM, Andres Freund wrote: > > >> I was just looking at this. Why aren't we using "pg_ctl kill" to >> terminate the backend? That's supposed to be portable. > Because pg_ctl can't do that for any process but postmaster, no? The > test is supposed to find issues with backend death (and has > defficiencies in error reporting already, and would have caught a bug > I'd introduced previously). > No, I don't think so. That's not what the docs say. That's why you give it a pid argument" "pg_ctl kill signal_name process_id" cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Support arrays over domains.
On 09/30/2017 03:32 PM, Tom Lane wrote: > Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >> We seem to have caused a problem with pg_upgrade :-( >> pg_restore: [archiver (db)] could not execute query: ERROR: pg_type >> array OID value not set when in binary upgrade mode >> Here we're upgrading from 9.2 to HEAD. Of course, there isn't an array >> oid for the domain in 9.2. > Hmm. That's pretty annoying. We could certainly go ahead and assign > some unused type OID to the new array type, but the receiving backend > can't really do that, since it doesn't know which type OIDs will be > assigned later in the dump file. > > Maybe we could put the burden on pg_upgrade (pg_dump --binary-upgrade) > to select an OID that's not in use in the source database. > > Yes, I think we'll have to do something like that. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Support arrays over domains.
On 09/30/2017 01:41 PM, Tom Lane wrote:
> Support arrays over domains.
We seem to have caused a problem with pg_upgrade :-(
The failing log file is:
command: "/home/bf/bfr/root/upgrade/HEAD/inst/bin/pg_restore" --host
/home/bf/bfr/root/upgrade/HEAD/inst --port 5648 --username buildfarm
--exit-on-error --verbose --dbname
'dbname=contrib_regression_hstore' "pg_upgrade_dump_51236.custom" >>
"pg_upgrade_dump_51236.log" 2>&1
pg_restore: connecting to database for restore
pg_restore: creating pg_largeobject "pg_largeobject"
pg_restore: creating pg_largeobject_metadata "pg_largeobject_metadata"
pg_restore: creating SCHEMA "public"
pg_restore: creating COMMENT "SCHEMA "public""
pg_restore: creating EXTENSION "hstore"
pg_restore: creating COMMENT "EXTENSION "hstore""
pg_restore: creating SHELL TYPE "public.ghstore"
pg_restore: creating FUNCTION "public.ghstore_in("cstring")"
pg_restore: creating FUNCTION "public.ghstore_out("ghstore")"
pg_restore: creating TYPE "public.ghstore"
pg_restore: creating DOMAIN "public.hstestdom1"
pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 579; 1247 51354
DOMAIN hstestdom1 buildfarm
pg_restore: [archiver (db)] could not execute query: ERROR: pg_type
array OID value not set when in binary upgrade mode
Command was:
-- For binary upgrade, must preserve pg_type oid
SELECT
pg_catalog.binary_upgrade_set_next_pg_type_oid('51354'::pg_catalog.oid);
CREATE DOMAIN "hstestdom1" AS integer NOT NULL DEFAULT 0;
Here we're upgrading from 9.2 to HEAD. Of course, there isn't an array
oid for the domain in 9.2.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Support building with Visual Studio 2017
Support building with Visual Studio 2017 Haribabu Kommi, reviewed by Takeshi Ideriha and Christian Ullrich Backpatch to 9.6 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/99e90bac4f9f3bd8d7b285a6f4095c2089e09efe Modified Files -- doc/src/sgml/install-windows.sgml | 16 +--- src/tools/msvc/MSBuildProject.pm | 23 +++ src/tools/msvc/README | 13 +++-- src/tools/msvc/Solution.pm| 26 ++ src/tools/msvc/VSObjectFactory.pm | 13 + 5 files changed, 78 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Support building with Visual Studio 2017
Support building with Visual Studio 2017 Haribabu Kommi, reviewed by Takeshi Ideriha and Christian Ullrich Backpatch to 9.6 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/10aafbdbe4224846095198644a1169807ab9b391 Modified Files -- doc/src/sgml/install-windows.sgml | 16 +--- src/tools/msvc/MSBuildProject.pm | 23 +++ src/tools/msvc/README | 13 +++-- src/tools/msvc/Solution.pm| 26 ++ src/tools/msvc/VSObjectFactory.pm | 13 + 5 files changed, 78 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Support building with Visual Studio 2017
Support building with Visual Studio 2017 Haribabu Kommi, reviewed by Takeshi Ideriha and Christian Ullrich Backpatch to 9.6 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f2ab3898f3a25ef431db4ea90a8d128b974dbffe Modified Files -- doc/src/sgml/install-windows.sgml | 16 +--- src/tools/msvc/MSBuildProject.pm | 23 +++ src/tools/msvc/README | 13 +++-- src/tools/msvc/Solution.pm| 26 ++ src/tools/msvc/VSObjectFactory.pm | 13 + 5 files changed, 78 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Provide a test for variable existence in psql
Provide a test for variable existence in psql
"\if :{?variable_name}" will be translated to "\if TRUE" if the variable
exists and "\if FALSE" otherwise. Thus it will be possible to execute code
conditionally on the existence of the variable, regardless of its value.
Fabien Coelho, with some review by Robins Tharakan and some light text
editing by me.
Discussion: https://postgr.es/m/alpine.DEB.2.20.1708260835520.3627@lancre
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/d57c7a7c506276597af619bdb8c62fa5b592745a
Modified Files
--
doc/src/sgml/ref/psql-ref.sgml | 10 +
src/bin/psql/psqlscanslash.l| 18
src/fe_utils/psqlscan.l | 42 -
src/include/fe_utils/psqlscan_int.h | 2 ++
src/test/regress/expected/psql.out | 26 +++
src/test/regress/sql/psql.sql | 18
6 files changed, 115 insertions(+), 1 deletion(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Quieten warnings about unused variables
Quieten warnings about unused variables These variables are only ever written to in assertion-enabled builds, and the latest Microsoft compilers complain about such variables in non-assertion-enabled builds. Apparently they don't worry so much about variables that are written to but not read from, so most of our PG_USED_FOR_ASSERTS_ONLY variables don't cause the problem. Discussion: https://postgr.es/m/7800.1505950...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/28ae524bbf865d23eb10f6ae1b996d59dcc30e4e Modified Files -- src/backend/optimizer/path/costsize.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Disable multi-byte citext tests
Disable multi-byte citext tests This reverts commit 890faaf1 which attempted unsuccessfully to deal with the problem, and instead just comments out these tests like other similar tests elsewhere in the script. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d1687c6926819f023c78b353458950a303796aba Modified Files -- contrib/citext/expected/citext.out | 32 ++-- contrib/citext/expected/citext_1.out | 32 ++-- contrib/citext/sql/citext.sql| 14 +++--- 3 files changed, 19 insertions(+), 59 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Set client encoding to UTF8 for the citext regression script
Set client encoding to UTF8 for the citext regression script Problem introduced with non-ascii characters in commit f2464997644c and discovered on various buildfarm animals. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/890faaf1957759c6e17fbcbfd16f7cabc4a59d07 Modified Files -- contrib/citext/expected/citext.out | 2 ++ contrib/citext/expected/citext_1.out | 2 ++ contrib/citext/sql/citext.sql| 3 +++ 3 files changed, 7 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module
Add citext_pattern_ops for citext contrib module This is similar to text_pattern_ops. Alexey Chernyshov, reviewed by Jacob Champion. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f2464997644c64b5dec93ab3c08305f48bfe14f1 Modified Files -- contrib/citext/citext--1.4--1.5.sql | 74 +++ contrib/citext/citext.c | 121 contrib/citext/expected/citext.out | 370 +++ contrib/citext/expected/citext_1.out | 370 +++ contrib/citext/sql/citext.sql| 78 5 files changed, 1013 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
On 08/07/2017 04:20 PM, Tom Lane wrote: > Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >> On 08/07/2017 04:07 PM, Tom Lane wrote: >>> Sorry, I was imprecise. What I'm suggesting is that you drop the >>> runtime PATH-foolery and instead put this in configure's environment: >>> >>> PROVE=$perlpathdir/prove >>> >>> Otherwise you're basically lying to configure about what you're going >>> to use, and that's always going to break eventually. >> Hmm, you're saying this should work now? OK, I'll try it when I get a >> minute to spare. > I'm pretty sure it's always worked, at least in the sense that you could > override what configure would put into Makefile.global that way. I'm not > quite clear on whether providing an exact path to "prove" there is enough > to fix your problem. If we have any places where we need to invoke the > corresponding version of "perl", then we have more things to fix. I'm pretty sure that's all we need. But we can find out ;-) > >>> Hm, yeah, the IPC::Run test would need to deal with this as well. >>> A PROVE_PERL environment variable is one way. Or maybe simpler, >>> just skip the probe for IPC::Run if PROVE has been specified >>> externally; assume the user knows what he's doing in that case. >> WFM > OK, I'll go make that happen. > > OK, thanks. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
On 08/07/2017 04:07 PM, Tom Lane wrote: > Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >> On 08/07/2017 03:36 PM, Tom Lane wrote: >>> My goodness, that's ugly. Is it really better than injecting >>> "PROVE=prove"? (I'd suggest saying that to configure, not make, >>> so that the configure log bears some resemblance to what you >>> want done.) >> This is what we had to do BEFORE the change in this commit. Now it's no >> longer sufficient. > Sorry, I was imprecise. What I'm suggesting is that you drop the > runtime PATH-foolery and instead put this in configure's environment: > > PROVE=$perlpathdir/prove > > Otherwise you're basically lying to configure about what you're going > to use, and that's always going to break eventually. Hmm, you're saying this should work now? OK, I'll try it when I get a minute to spare. > >> It would certainly be better if we could tell configure a path to prove >> and a path to the perl we need to test IPC::Run against. > Hm, yeah, the IPC::Run test would need to deal with this as well. > A PROVE_PERL environment variable is one way. Or maybe simpler, > just skip the probe for IPC::Run if PROVE has been specified > externally; assume the user knows what he's doing in that case. WFM > Are there any other gotchas in the build sequence? > Not that I can think of. > Do we have/need any explicit references to the test version of "perl", > or is "prove" a sufficient API? > > Probably sufficient. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
On 08/07/2017 03:36 PM, Tom Lane wrote: > Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >> On 08/07/2017 03:21 PM, Tom Lane wrote: >>> I'm confused. AFAIK, that commit did not change which "prove" would >>> be used --- at least not unless you change PATH between configure and >>> make. It only changed how specifically that program would be named in >>> Makefile.global. Please clarify how that broke anything. >> That's exactly what we do. See >> <https://github.com/PGBuildFarm/client-code/blob/master/run_build.pl> at >> line 1649. > My goodness, that's ugly. Is it really better than injecting > "PROVE=prove"? (I'd suggest saying that to configure, not make, > so that the configure log bears some resemblance to what you > want done.) > > This is what we had to do BEFORE the change in this commit. Now it's no longer sufficient. It would certainly be better if we could tell configure a path to prove and a path to the perl we need to test IPC::Run against. e.g. PROVE=/usr/bin/prove PROVE_PERL=/usr/bin/perl configure ... The problem in all this is that we're assuming incorrectly that the perl we use to build against is the same as the perl we need to run the build with. On Msys that's emphatically not true. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
On 08/07/2017 03:21 PM, Tom Lane wrote: > Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >> On 07/31/2017 01:02 PM, Tom Lane wrote: >>> Record full paths of programs sought by "configure". >> The problem with this commit, as jacana is demonstrating, is that on >> Msys it finds the wrong prove. configure needs to run against the perl >> we build against, i.e. a native Windows perl, but prove needs to run >> with the perl from the MSys DTK that understands MSys virtualized >> paths. I have a hack that will allow the buildfarm to overcome the >> difficulty, (essentially it passes 'PROVE=prove' to make) but that's >> fairly ugly and certainly non-intuitive for someone running an MSys >> build and TAP tests without the buildfarm client. > I'm confused. AFAIK, that commit did not change which "prove" would > be used --- at least not unless you change PATH between configure and > make. It only changed how specifically that program would be named in > Makefile.global. Please clarify how that broke anything. > > That's exactly what we do. See <https://github.com/PGBuildFarm/client-code/blob/master/run_build.pl> at line 1649. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
On 07/31/2017 01:02 PM, Tom Lane wrote: > Record full paths of programs sought by "configure". > > Previously we had a mix of uses of AC_CHECK_PROG[S] and AC_PATH_PROG[S]. > The only difference between those macros is that the latter emits the > full path to the program it finds, eg "/usr/bin/prove", whereas the > former emits just "prove". Let's standardize on always emitting the > full path; this is better for documentation of the build, and it might > prevent some types of failures if later build steps are done with > a different PATH setting. > > I did not touch the AC_CHECK_PROG[S] calls in ax_pthread.m4 and > ax_prog_perl_modules.m4. There seems no need to make those diverge from > upstream, since we do not record the programs sought by the former, while > the latter's call to AC_CHECK_PROG(PERL,...) will never be reached. > > Discussion: https://postgr.es/m/25937.1501433...@sss.pgh.pa.us The problem with this commit, as jacana is demonstrating, is that on Msys it finds the wrong prove. configure needs to run against the perl we build against, i.e. a native Windows perl, but prove needs to run with the perl from the MSys DTK that understands MSys virtualized paths. I have a hack that will allow the buildfarm to overcome the difficulty, (essentially it passes 'PROVE=prove' to make) but that's fairly ugly and certainly non-intuitive for someone running an MSys build and TAP tests without the buildfarm client. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Work around Msys weakness in Testlib.pm's command_like()
Work around Msys weakness in Testlib.pm's command_like() When output of IPC::Run::run () is redirected to scalar references, in certain circumstances the Msys perl does not correctly detect that the end of file has been seen, making the test hang indefinitely. One such circumstance is when the command is 'pg_ctl start', and such a change was made in commit f13ea95f9e. The workaround, which only applies on MSys, is to redirect the output to temporary files and then read them in when the process has finished. Patch by me, reviewed and tweaked by Tom Lane. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/efd7f8e36553cd32e445061cbbc80d32028f4248 Modified Files -- src/bin/pg_ctl/t/001_start_stop.pl | 14 +++--- src/test/perl/TestLib.pm | 19 +++ 2 files changed, 30 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Improve legibility of numeric literal
On 07/17/2017 10:22 PM, Robert Haas wrote: > On Mon, Jul 17, 2017 at 3:36 PM, Andrew Dunstan <and...@dunslane.net> wrote: >> Improve legibility of numeric literal > Ugh. Are we going to start doing this all the time? Some of the > time? At the whim of whoever was committing? I didn't even know this > was legal syntax. > I was just adjusting a commit I had made a very shortly before. It is legal syntax, but I'd been unable to find the documentation for it until it was pointed out to me. I'm sorry of you dislike it, I find it makes the literal much more readable. cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve legibility of numeric literal
Improve legibility of numeric literal Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cde11fa3c003407fc6c4ddc427d57e588ea17d1c Modified Files -- src/test/perl/PostgresNode.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Use usleep instead of select for timeouts in PostgresNode.pm
Use usleep instead of select for timeouts in PostgresNode.pm select() for pure timeouts is not portable, and in particular doesn't work on Windows. Discussion: https://postgr.es/m/186943e0-3405-978d-b19d-9d3335427...@2ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6c6970a280a50434c28ccd461ba864798f5d2a04 Modified Files -- src/test/perl/PostgresNode.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: fix typo
fix typo Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f5b2f270849395b39bdd87a6459bd0a05f78249d Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: fix typo
fix typo Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f13e48bd54b2a1e9357da775d4ac263a98cab97d Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: fix typo
fix typo Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/220a9b5e55070c9c37017914f456a9a4c6f46145 Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: fix typo
fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/deb0129a222ec6b189d5d198cf77012591f300d8 Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f
Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f This change didn't adjust the publicly visible taptest function, causing buildfarm failures on bowerbird. Backpatch to 9.4 like previous change. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9c3f502b45a9f6c7bf7505ac84f13712fff1ee71 Modified Files -- src/tools/msvc/vcregress.pl | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f
Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f This change didn't adjust the publicly visible taptest function, causing buildfarm failures on bowerbird. Backpatch to 9.4 like previous change. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b4a1d69ed4da83d25639f5bdb129ee83aa19c242 Modified Files -- src/tools/msvc/vcregress.pl | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f
Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f This change didn't adjust the publicly visible taptest function, causing buildfarm failures on bowerbird. Backpatch to 9.4 like previous change. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fd2487e49f406471c11fc337b3e06dcb8579c809 Modified Files -- src/tools/msvc/vcregress.pl | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f
Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f This change didn't adjust the publicly visible taptest function, causing buildfarm failures on bowerbird. Backpatch to 9.4 like previous change. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7eb4124da5ba5d905d911a8f786f78df7703c089 Modified Files -- src/tools/msvc/vcregress.pl | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.
On 06/28/2017 06:00 PM, Tom Lane wrote: > Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer. > > Per buildfarm. > Looks to me like we need to put back the Makefile line for WIN32 for pg_ctl, too. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Take PROVE_FLAGS from the command line but not the environment
Take PROVE_FLAGS from the command line but not the environment This reverts commit 56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c and instead makes vcregress.pl parse out PROVE_FLAGS from a command line argument when doing a TAP test, thus making it consistent with the makefile treatment. Discussion: https://postgr.es/m/c26a7416-2fb9-34ab-7991-618c922f896e%402ndquadrant.com Backpatch to 9.4 like previous patch. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6b2a0b4757331612f379d497c377b58f9a0ca24f Modified Files -- src/Makefile.global.in | 2 +- src/tools/msvc/vcregress.pl | 12 +--- 2 files changed, 10 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Take PROVE_FLAGS from the command line but not the environment
Take PROVE_FLAGS from the command line but not the environment This reverts commit 56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c and instead makes vcregress.pl parse out PROVE_FLAGS from a command line argument when doing a TAP test, thus making it consistent with the makefile treatment. Discussion: https://postgr.es/m/c26a7416-2fb9-34ab-7991-618c922f896e%402ndquadrant.com Backpatch to 9.4 like previous patch. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3c017a545f9c6e658e59baab636315c386b09d0b Modified Files -- src/Makefile.global.in | 2 +- src/tools/msvc/vcregress.pl | 12 +--- 2 files changed, 10 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Take PROVE_FLAGS from the command line but not the environment
Take PROVE_FLAGS from the command line but not the environment This reverts commit 56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c and instead makes vcregress.pl parse out PROVE_FLAGS from a command line argument when doing a TAP test, thus making it consistent with the makefile treatment. Discussion: https://postgr.es/m/c26a7416-2fb9-34ab-7991-618c922f896e%402ndquadrant.com Backpatch to 9.4 like previous patch. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/11aa362c89360aa5a044bd0b949b60ed4a5176bd Modified Files -- src/Makefile.global.in | 2 +- src/tools/msvc/vcregress.pl | 12 +--- 2 files changed, 10 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Take PROVE_FLAGS from the command line but not the environment
Take PROVE_FLAGS from the command line but not the environment This reverts commit 56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c and instead makes vcregress.pl parse out PROVE_FLAGS from a command line argument when doing a TAP test, thus making it consistent with the makefile treatment. Discussion: https://postgr.es/m/c26a7416-2fb9-34ab-7991-618c922f896e%402ndquadrant.com Backpatch to 9.4 like previous patch. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/93b7d9731f184e764c642266ecd74be24db73a6e Modified Files -- src/Makefile.global.in | 2 +- src/tools/msvc/vcregress.pl | 12 +--- 2 files changed, 10 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Mark to_tsvector(regconfig,json[b]) functions immutable
Mark to_tsvector(regconfig,json[b]) functions immutable This make them consistent with the text function and means they can be used in functional indexes. Catalog version bumped. Per gripe from Josh Berkus. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f7e6853e1a2ee2badd988f5e49e4ceb6a2b15b7f Modified Files -- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.h| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix thinko in previous openssl change
Fix thinko in previous openssl change Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b2482ab83242d895e0e0eaa362b5a918d15ce408 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix thinko in previous openssl change
Fix thinko in previous openssl change Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f964a7c5ab9f8af5cf496f650ce162f7e3d34714 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix thinko in previous openssl change
Fix thinko in previous openssl change Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ec504aff740993560d8d1ca16f70cbf8147cc622 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix thinko in previous openssl change
Fix thinko in previous openssl change Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6da9996358989b86744febd0eab24f0b5dc2f7d0 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix thinko in previous openssl change
Fix thinko in previous openssl change Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e02136fe688046cd3b3c0bbcdd6ba970932ec8e Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix thinko in previous openssl change
Fix thinko in previous openssl change Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/da30fa603aeb3b406931543b1ff4427bdf051ec5 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fe39a086d457c044dc22706b7f505430c0768363 Modified Files -- src/tools/msvc/Solution.pm | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0fde390f64fef6cf2dbbec18eba57fd804e172cf Modified Files -- src/tools/msvc/Solution.pm | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/545dc4d2166b5043db3dd013ead877d1ed6d2796 Modified Files -- src/tools/msvc/Solution.pm | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/614350a3ab73992f48c86e26552a2cbf030180e2 Modified Files -- src/tools/msvc/Solution.pm | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/307fc49d5c02ee895f7da1ca442e6ecf53deeac6 Modified Files -- src/tools/msvc/Solution.pm | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b64ff9c5af1e7e8c665f6fd76cecb0e3e82b0921 Modified Files -- src/tools/msvc/Solution.pm | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix signal handling in logical replication workers
On 06/02/2017 09:13 PM, Petr Jelinek wrote: > On 03/06/17 02:59, Tom Lane wrote: >> I wrote: >>> Peter Eisentraut <pete...@gmx.net> writes: >>>> Fix signal handling in logical replication workers >>> It looks like this broke buildfarm member nightjar. >>> Not clear why - I don't see anything especially platform-specific >>> in the patch. >> To muddy the waters further, I tried to duplicate the failure on >> FreeBSD 11.0/x86_64, and it seems to pass just fine. Maybe Andrew >> can look into why nightjar is failing. >> > There is still one locking patch pending (well pending to be written), I > would not be surprised if there is race condition in shutdown somewhere > before that's done. > nightjar has been having intermittent failures on the subscription tests for some time. See <https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=nightjar=HEAD>. It's only been running the tests for about 53 days. I'm prepared to give any help needed, including access to nightjar if required. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA1 was created
On 05/16/2017 10:37 PM, Tom Lane wrote: > Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: >> On 5/16/17 18:14, pg...@postgresql.org wrote: >>> Tag refs/tags/REL_10_BETA1 was created. >> Was this change in naming pattern intentional? > Yes, it was. Andrew Dunstan suggested[1] during the > two-part-version-number discussion that we should start including a "_" > after REL in tag and branch names for v10 and later, so that those names > would sort correctly compared to the tag/branch names for earlier branches > (at least when using C locale). I believe his main concern was some logic > in the buildfarm, but it seems like a good idea in general. > > When we get to v100, we'll need some other hack to make it work ... > but I plan to be safely dead by then. > Me too. Since posterity will be deprived of both of us let's note that the same hack will work, we'll just need two underscores. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 where this feature was introduced. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/69db3b0cfccc0687dfbdf56afcfb2f8e536053c6 Modified Files -- contrib/hstore_plperl/expected/hstore_plperlu.out | 44 ++- contrib/hstore_plperl/sql/hstore_plperlu.sql | 6 2 files changed, 17 insertions(+), 33 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 where this feature was introduced. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/12ad38b3b4b5004001a525e0a0eda2ec45329e8e Modified Files -- contrib/hstore_plperl/expected/hstore_plperlu.out | 44 ++- contrib/hstore_plperl/sql/hstore_plperlu.sql | 6 2 files changed, 17 insertions(+), 33 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 where this feature was introduced. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b3c8630f11445692fd149d3c9bdab65ffd586a3a Modified Files -- contrib/hstore_plperl/expected/hstore_plperlu.out | 44 ++- contrib/hstore_plperl/sql/hstore_plperlu.sql | 6 2 files changed, 17 insertions(+), 33 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Use a better way of skipping all subscription tests on Windows
On 05/13/2017 02:50 AM, Andrew Dunstan wrote: > Use a better way of skipping all subscription tests on Windows Of course, this should read "authentication", not "subscription". cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Use a better way of skipping all subscription tests on Windows
Use a better way of skipping all subscription tests on Windows This way we only need to specify the number of tests in one place, and the output is also less verbose. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8d9f06097714ce1f4243329172f73c2d20b896a6 Modified Files -- src/test/authentication/t/001_password.pl | 68 ++- src/test/authentication/t/002_saslprep.pl | 105 +++--- 2 files changed, 90 insertions(+), 83 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments. Backpatch to 9.4 where we introduced TAP tests Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/054a897c40c683b27cefaacbb85d536fcd8eedd1 Modified Files -- src/Makefile.global.in | 3 ++- src/tools/msvc/vcregress.pl | 5 - 2 files changed, 6 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments. Backpatch to 9.4 where we introduced TAP tests Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d39d968f548fa035c50a05004f4779d615ea8903 Modified Files -- src/Makefile.global.in | 3 ++- src/tools/msvc/vcregress.pl | 5 - 2 files changed, 6 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments. Backpatch to 9.4 where we introduced TAP tests Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c Modified Files -- src/Makefile.global.in | 4 ++-- src/tools/msvc/vcregress.pl | 5 - 2 files changed, 6 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments. Backpatch to 9.4 where we introduced TAP tests Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cb701af784556e7417bb0d9daa822e913f43b1fa Modified Files -- src/Makefile.global.in | 3 ++- src/test/perl/README| 5 + src/tools/msvc/vcregress.pl | 5 - 3 files changed, 11 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all live branches. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2c7d2114bb883b07816c2171830edd654696c856 Modified Files -- src/tools/msvc/Solution.pm | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all live branches. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/616dd9978ceca85acb5a31973ac31408c62435f6 Modified Files -- src/tools/msvc/Solution.pm | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all live branches. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8ec82ee6ae7a302ab696f696a5eb2f45ae3c5910 Modified Files -- src/tools/msvc/Solution.pm | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all live branches. Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/614f83c122b029edb13b01fbc62a518f2ffd1254 Modified Files -- src/tools/msvc/Solution.pm | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all live branches. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/69ce3ead1ebe64989c43be1db12d00cc9341d36a Modified Files -- src/tools/msvc/Solution.pm | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all live branches. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b757e01f62e44b4f425f78e3dc4e247ca9f1e983 Modified Files -- src/tools/msvc/Solution.pm | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Avoid tests which crash the calling process on Windows
Avoid tests which crash the calling process on Windows Certain recovery tests use the Perl IPC::Run module's start/kill_kill method of processing. On at least some versions of perl this causes the whole process and its caller to crash. If we ever find a better way of doing these tests they can be re-enabled on this platform. This does not affect Mingw or Cygwin builds, which use a different perl and a different shell and so are not affected. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/734cb4c2e7de92972c01b6339a3e15ac4bc605dd Modified Files -- src/test/recovery/t/006_logical_decoding.pl | 21 ++--- src/test/recovery/t/011_crash_recovery.pl | 12 +++- 2 files changed, 25 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix perl thinko in commit fed6df486dca
Fix perl thinko in commit fed6df486dca Report and fix from Vaishnavi Prabakaran Backpatch to 9.4 like original. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/df53413ba524a01cced9c12131606d84d52a0fc9 Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix perl thinko in commit fed6df486dca
Fix perl thinko in commit fed6df486dca Report and fix from Vaishnavi Prabakaran Backpatch to 9.4 like original. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b2ed1c8a467c2f8f91323a13696a900f31a3239d Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix perl thinko in commit fed6df486dca
Fix perl thinko in commit fed6df486dca Report and fix from Vaishnavi Prabakaran Backpatch to 9.4 like original. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f06caa09d9c539a2336434e6b521b6541c3da624 Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix perl thinko in commit fed6df486dca
Fix perl thinko in commit fed6df486dca Report and fix from Vaishnavi Prabakaran Backpatch to 9.4 like original. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9a0d2008c3fe82c9d62a81e87cd0c4de1be09e0f Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Allow vcregress.pl to run an arbitrary TAP test set
Allow vcregress.pl to run an arbitrary TAP test set Currently only provision for running the bin checks in a single step is provided for. Now these tests can be run individually, as well as tests in other locations (e.g. src.test/recover). Also provide for suppressing unnecessary temp installs by setting the NO_TEMP_INSTALL environment variable just as the Makefiles do. Backpatch to 9.4. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fed6df486dca1b9e53d3f560031b9a236c99f4bb Modified Files -- src/tools/msvc/vcregress.pl | 50 - 1 file changed, 31 insertions(+), 19 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Allow vcregress.pl to run an arbitrary TAP test set
Allow vcregress.pl to run an arbitrary TAP test set Currently only provision for running the bin checks in a single step is provided for. Now these tests can be run individually, as well as tests in other locations (e.g. src.test/recover). Also provide for suppressing unnecessary temp installs by setting the NO_TEMP_INSTALL environment variable just as the Makefiles do. Backpatch to 9.4. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/66510630d8621a638b487fa5ae685bdc60240440 Modified Files -- src/tools/msvc/vcregress.pl | 48 - 1 file changed, 30 insertions(+), 18 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Allow vcregress.pl to run an arbitrary TAP test set
Allow vcregress.pl to run an arbitrary TAP test set Currently only provision for running the bin checks in a single step is provided for. Now these tests can be run individually, as well as tests in other locations (e.g. src.test/recover). Also provide for suppressing unnecessary temp installs by setting the NO_TEMP_INSTALL environment variable just as the Makefiles do. Backpatch to 9.4. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/263e33d979fc19d889f914977978f9326cc8a3e4 Modified Files -- src/tools/msvc/vcregress.pl | 58 - 1 file changed, 41 insertions(+), 17 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Allow vcregress.pl to run an arbitrary TAP test set
Allow vcregress.pl to run an arbitrary TAP test set Currently only provision for running the bin checks in a single step is provided for. Now these tests can be run individually, as well as tests in other locations (e.g. src.test/recover). Also provide for suppressing unnecessary temp installs by setting the NO_TEMP_INSTALL environment variable just as the Makefiles do. Backpatch to 9.4. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3c1e14af8692d48548adac9b8a0cbabaa8a92b78 Modified Files -- src/tools/msvc/vcregress.pl | 58 - 1 file changed, 41 insertions(+), 17 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Downcase "Wincrypt.h"
Downcase "Wincrypt.h" This is consistent with how we refer to other Windows include files, and prevents a failure when cross-compiling on a system with case sensitive file names. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0eba6be1b8d37fa368a45795ba350d46cc86df54 Modified Files -- src/port/pg_strong_random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make json_populate_record and friends operate recursively
Make json_populate_record and friends operate recursively With this change array fields are populated from json(b) arrays, and composite fields are populated from json(b) objects. Along the way, some significant code refactoring is done to remove redundancy in the way to populate_record[_set] and to_record[_set] functions operate, and some significant efficiency gains are made by caching tuple descriptors. Nikita Glukhov, edited some by me. Reviewed by Aleksander Alekseev and Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cf35346e813e5a1373f308d397bb0a8f3f21d530 Modified Files -- doc/src/sgml/func.sgml | 16 +- src/backend/utils/adt/jsonfuncs.c | 1700 --- src/test/regress/expected/json.out | 466 +- src/test/regress/expected/jsonb.out | 478 +- src/test/regress/sql/json.sql | 156 +++- src/test/regress/sql/jsonb.sql | 156 +++- 6 files changed, 2412 insertions(+), 560 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Clarify documentation of to_tsvector(json(b))
Clarify documentation of to_tsvector(json(b)) Per gripe from Sven R. Kunze Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e75a78656bcaa3faff6b85891ca69d45dd21023f Modified Files -- doc/src/sgml/func.sgml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Full Text Search support for json and jsonb
On 03/31/2017 02:38 PM, Tom Lane wrote: > Andrew Dunstan <and...@dunslane.net> writes: >> Full Text Search support for json and jsonb >> The new functions are ts_headline() and to_tsvector. > Should this not have included a catversion bump? > > Oops, you're right. I see there have been several since then, so no further action required at this stage. Thanks also for fixing the regression tests. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Transform or iterate over json(b) string values
Transform or iterate over json(b) string values Dmitry Dolgov, reviewed and lightly edited by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c80b9920fcbcbf75e3d7e8fe092bf6e15d9d40b8 Modified Files -- src/backend/utils/adt/jsonfuncs.c | 236 ++ src/include/utils/jsonapi.h | 16 +++ 2 files changed, 252 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
