[COMMITTERS] npgsql - Npgsql2: Fixed line endings.
Log Message: --- Fixed line endings. Modified Files: -- Npgsql2/testsuite/noninteractive/NUnit20: TypesTests.cs (r1.12 -> r1.13) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/testsuite/noninteractive/NUnit20/TypesTests.cs?r1=1.12&r2=1.13) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Don't forget to de-escape the password field in .pgpass.
Don't forget to de-escape the password field in .pgpass. This has been broken just about forever (or more specifically, commit 7f4981f4af1700456f98ac3f2b2d84959919ec81) and nobody noticed until Richard Huxton reported it recently. Analysis and fix by Ross Reedstrom, although I didn't use his patch. This doesn't seem important enough to back-patch and is mildly backward incompatible, so I'm just doing this in master. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8d15e3ec4fcb735875a8a70a09ec0c62153c3329 Modified Files -- src/interfaces/libpq/fe-connect.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add ALTER DOMAIN ... RENAME
Add ALTER DOMAIN ... RENAME You could already rename domains using ALTER TYPE, but with this new command it is more consistent with how other commands treat domains as a subcategory of types. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f90dd28062db2128a340fbe02f55829f15ab5561 Modified Files -- doc/src/sgml/ref/alter_domain.sgml | 22 +- src/backend/commands/alter.c |3 ++- src/backend/commands/typecmds.c | 11 ++- src/backend/parser/gram.y|8 src/include/commands/typecmds.h |2 +- src/test/regress/expected/domain.out |7 +++ src/test/regress/sql/domain.sql | 10 ++ 7 files changed, 59 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add a security_barrier option for views.
Add a security_barrier option for views. When a view is marked as a security barrier, it will not be pulled up into the containing query, and no quals will be pushed down into it, so that no function or operator chosen by the user can be applied to rows not exposed by the view. Views not configured with this option cannot provide robust row-level security, but will perform far better. Patch by KaiGai Kohei; original problem report by Heikki Linnakangas (in October 2009!). Review (in earlier versions) by Noah Misch and others. Design advice by Tom Lane and myself. Further review and cleanup by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0e4611c0234d89e288a53351f775c59522baed7c Modified Files -- doc/src/sgml/ref/alter_view.sgml | 20 + doc/src/sgml/ref/create_view.sgml | 13 ++ doc/src/sgml/rules.sgml | 39 - src/backend/access/common/reloptions.c| 17 +++- src/backend/commands/tablecmds.c | 66 ++--- src/backend/commands/view.c | 26 --- src/backend/nodes/copyfuncs.c |1 + src/backend/nodes/equalfuncs.c|1 + src/backend/nodes/outfuncs.c |1 + src/backend/nodes/readfuncs.c |1 + src/backend/optimizer/path/allpaths.c | 14 ++ src/backend/optimizer/prep/prepjointree.c |2 + src/backend/parser/gram.y | 10 +++-- src/backend/rewrite/rewriteHandler.c |1 + src/backend/utils/adt/selfuncs.c | 13 ++ src/backend/utils/cache/relcache.c|1 + src/bin/pg_dump/pg_dump.c |6 ++- src/include/access/reloptions.h |3 +- src/include/nodes/parsenodes.h|3 + src/include/utils/rel.h |9 src/test/regress/expected/create_view.out | 55 +++- src/test/regress/sql/create_view.sql | 33 ++ 22 files changed, 300 insertions(+), 35 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add a security_barrier option for views.
Robert Haas writes: > Add a security_barrier option for views. Where's the catversion bump for having broken stored rules/views? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add a security_barrier option for views.
Excerpts from Tom Lane's message of jue dic 22 18:39:18 -0300 2011: > Robert Haas writes: > > Add a security_barrier option for views. > > Where's the catversion bump for having broken stored rules/views? I'm starting to wonder if we should have a git hook of some sort to check for this ... -- Álvaro Herrera The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add a security_barrier option for views.
On Thu, Dec 22, 2011 at 4:17 PM, Robert Haas wrote: > Add a security_barrier option for views. > you have some docs typos here, for the rest: cool. doc/src/sgml/ref/create_view.sgml """ + This clause specifies optional parameters for a view; currently, the + only suppored parameter name is security_barrier, """ should say "supported parameter" doc/src/sgml/rules.sgml """ +the view. This prevents maliciously-chosen functions and operators from +being invoked on rows until afterthe view has done its work. For """ should say "until after the view"? """ +in the limited sense that the contents of the invisible tuples will not +passed to possibly-insecure functions. The user may well have other means """ should say "will not be passed"? -- Jaime Casanova www.2ndQuadrant.com Professional PostgreSQL: Soporte 24x7 y capacitación -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add a security_barrier option for views.
Alvaro Herrera writes: > Excerpts from Tom Lane's message of jue dic 22 18:39:18 -0300 2011: >> Robert Haas writes: >>> Add a security_barrier option for views. >> Where's the catversion bump for having broken stored rules/views? > I'm starting to wonder if we should have a git hook of some sort to > check for this ... Dunno, how would you automate that? My rule of thumb is that touching either src/include/catalog/* or readfuncs.c probably means you need a catversion bump. It's the "probably" that's a problem for automated enforcement. I don't want unnecessary catversion bumps happening just because some tool is preventing a commit. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Catversion bump for commit 0e4611c0234d89e288a53351f775c59522bae
Catversion bump for commit 0e4611c0234d89e288a53351f775c59522baed7c. It changed the format of stored rules. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/99b60fc04e53c09ca630d2798acb3768a778dc47 Modified Files -- src/include/catalog/catversion.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add a security_barrier option for views.
Excerpts from Tom Lane's message of jue dic 22 19:09:54 -0300 2011: > > Alvaro Herrera writes: > > Excerpts from Tom Lane's message of jue dic 22 18:39:18 -0300 2011: > >> Robert Haas writes: > >>> Add a security_barrier option for views. > > >> Where's the catversion bump for having broken stored rules/views? > > > I'm starting to wonder if we should have a git hook of some sort to > > check for this ... > > Dunno, how would you automate that? > > My rule of thumb is that touching either src/include/catalog/* or > readfuncs.c probably means you need a catversion bump. It's the > "probably" that's a problem for automated enforcement. I don't > want unnecessary catversion bumps happening just because some tool > is preventing a commit. Yeah, maybe this belongs in a tool local to each developer. I run a script here "git-safe-push" (yes, from Magnus) that, currently, displays the commits I have for pushing, so that I can double check that I'm not pushing something improper. I guess I could integrate something that if there's a hunk touching src/include/catalog, it raises a warning and nothing more, so I can easily ignore it if it's wrong. -- Álvaro Herrera The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Typo fixes.
Typo fixes. All noted by Jaime Casanova. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0510b62d91151b9d8c1fe1aa15c9cf3ffe9bf25b Modified Files -- doc/src/sgml/ref/create_view.sgml |2 +- doc/src/sgml/rules.sgml |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
