[COMMITTERS] pgsql: Add support for logging the current role.

2011-01-12 Thread Robert Haas
Add support for logging the current role.

Stephen Frost, with some editorialization by me.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a8a8867912c46a68c9ac14903b3dba2fab8f7097

Modified Files
--
doc/src/sgml/config.sgml   |7 ++-
src/backend/utils/error/elog.c |   10 ++
2 files changed, 16 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Revert patch adding support for logging the current role.

2011-01-12 Thread Robert Haas
Revert patch adding support for logging the current role.

This reverts commit a8a8867912c46a68c9ac14903b3dba2fab8f7097, committed
by me earlier today (2011-01-12).  This isn't safe inside an aborted
transaction.

Noted by Tom Lane.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=7a32ff97321408afa0ddfcae1a4a060062956d24

Modified Files
--
doc/src/sgml/config.sgml   |7 +--
src/backend/utils/error/elog.c |   10 --
2 files changed, 1 insertions(+), 16 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Document that WITH queries are also called Common Table Expressi

2011-01-19 Thread Robert Haas
Document that WITH queries are also called Common Table Expressions.

Peter Geoghegan, reviewed by Stephen Frost

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=92f7eebbbd6554f0414ab869abd8733cef751249

Modified Files
--
doc/src/sgml/acronyms.sgml |9 +
doc/src/sgml/queries.sgml  |5 +++--
2 files changed, 12 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Document that WITH queries are also called Common Table Expressi

2011-01-19 Thread Robert Haas
Document that WITH queries are also called Common Table Expressions.

Peter Geoghegan, reviewed by Stephen Frost

Branch
--
REL9_0_STABLE

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=ba3afc88d2b81fc609cda8504ee7b54c54b379d7

Modified Files
--
doc/src/sgml/acronyms.sgml |9 +
doc/src/sgml/queries.sgml  |5 +++--
2 files changed, 12 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Document that WITH queries are also called Common Table Expressi

2011-01-19 Thread Robert Haas
Document that WITH queries are also called Common Table Expressions.

Peter Geoghegan, reviewed by Stephen Frost

Branch
--
REL8_4_STABLE

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=9de3f2843c4cf695a37d04d268df350b6118a232

Modified Files
--
doc/src/sgml/acronyms.sgml |9 +
doc/src/sgml/queries.sgml  |5 +++--
2 files changed, 12 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add new psql command \dL to list languages.

2011-01-19 Thread Robert Haas
Add new psql command \dL to list languages.

Original patch by Fernando Ike, revived by Josh Kuperschmidt, reviewed by 
Andreas
Karlsson, and in earlier versions by Tom Lane and Peter Eisentraut.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=9c5e2c120be42fbd1a743ddf539ff451e1cce23b

Modified Files
--
doc/src/sgml/ref/psql-ref.sgml |   15 +
src/bin/psql/command.c |3 ++
src/bin/psql/describe.c|   68 
src/bin/psql/describe.h|2 +
src/bin/psql/help.c|1 +
src/bin/psql/tab-complete.c|4 ++-
6 files changed, 92 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make ALTER TABLE revalidate uniqueness and exclusion constraints

2011-01-20 Thread Robert Haas
Make ALTER TABLE revalidate uniqueness and exclusion constraints.

Failure to do so can lead to constraint violations.  This was broken by
commit 1ddc2703a936d03953657f43345460b9242bbed1 on 2010-02-07, so
back-patch to 9.0.

Noah Misch.  Regression test by me.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=8ceb24568054232696dddc1166a8563bc78c900a

Modified Files
--
src/backend/catalog/index.c   |   43 -
src/backend/commands/cluster.c|9 +-
src/backend/commands/indexcmds.c  |4 +-
src/backend/commands/tablecmds.c  |7 +++--
src/include/catalog/index.h   |5 +++-
src/include/commands/cluster.h|1 +
src/test/regress/expected/alter_table.out |4 +++
src/test/regress/sql/alter_table.sql  |2 +
8 files changed, 48 insertions(+), 27 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make ALTER TABLE revalidate uniqueness and exclusion constraints

2011-01-20 Thread Robert Haas
Make ALTER TABLE revalidate uniqueness and exclusion constraints.

Failure to do so can lead to constraint violations.  This was broken by
commit 1ddc2703a936d03953657f43345460b9242bbed1 on 2010-02-07, so
back-patch to 9.0.

Noah Misch.  Regression test by me.

Branch
--
REL9_0_STABLE

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=39b5e5f3370258cae843e8cc83eccd59ddb532dd

Modified Files
--
src/backend/catalog/index.c   |   43 -
src/backend/commands/cluster.c|9 +-
src/backend/commands/indexcmds.c  |4 +-
src/backend/commands/tablecmds.c  |7 +++--
src/include/catalog/index.h   |5 +++-
src/include/commands/cluster.h|1 +
src/test/regress/expected/alter_table.out |4 +++
src/test/regress/sql/alter_table.sql  |2 +
8 files changed, 48 insertions(+), 27 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Emphasize where OVER needs to be when using a window function.

2011-01-21 Thread Robert Haas
Emphasize where OVER needs to be when using a window function.

Jeff Turner

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=d3b372e92d4efdd6f63da35996f04ff009c932b5

Modified Files
--
doc/src/sgml/advanced.sgml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Code cleanup for assign_XactIsoLevel.

2011-01-21 Thread Robert Haas
Code cleanup for assign_XactIsoLevel.

The new coding avoids a spurious debug message when a transaction
that has changed the isolation level has been rolled back.  It also
allows the property to be freely changed to the current value within
a subtransaction.

Kevin Grittner, with one small change by me.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=fb4c5d2798730f60b102d775f22fb53c26a6445d

Modified Files
--
src/backend/commands/variable.c |   30 +++---
src/backend/utils/misc/guc.c|2 +-
src/include/utils/guc.h |1 +
3 files changed, 17 insertions(+), 16 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid treating WAL senders as normal backends.

2011-01-21 Thread Robert Haas
Avoid treating WAL senders as normal backends.

The previous coding treated anything that wasn't an autovacuum launcher
as a normal backend, which is wrong now that we also have WAL senders.

Fujii Masao, reviewed by Robert Haas, Alvaro Herrera, Tom Lane,
and Bernd Helmle.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a0c75f55394fe904e09f7caee9a8195e3a09c801

Modified Files
--
src/backend/postmaster/postmaster.c |   52 +-
1 files changed, 38 insertions(+), 14 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Code cleanup for assign_transaction_read_only.

2011-01-22 Thread Robert Haas
Code cleanup for assign_transaction_read_only.

As in commit fb4c5d2798730f60b102d775f22fb53c26a6445d on 2011-01-21,
this avoids spurious debug messages and allows idempotent changes at
any time.  Along the way, make assign_XactIsoLevel allow idempotent
changes even when not within a subtransaction, to be consistent with
the new coding of assign_transaction_read_only and because there's
no compelling reason to do otherwise.

Kevin Grittner, with some adjustments.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6f59777c65d557485e933a383ebc4c3fdfc1a2b7

Modified Files
--
src/backend/commands/variable.c|   53 +++-
src/backend/utils/misc/guc.c   |   29 ---
src/include/commands/variable.h|2 +
src/test/regress/expected/transactions.out |   75 
src/test/regress/sql/transactions.sql  |   42 +++
5 files changed, 170 insertions(+), 31 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-23 Thread Robert Haas
sepgsql, an SE-Linux integration for PostgreSQL

This is still pretty rough - among other things, the documentation
needs work, and the messages need a visit from the style police -
but this gets the basic framework in place.

KaiGai Kohei

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=968bc6fac91d6aaca594488ab85c179b686cbbdd

Modified Files
--
configure  |  122 +++
configure.in   |   13 +
contrib/Makefile   |4 +
contrib/README |4 +
contrib/sepgsql/.gitignore |1 +
contrib/sepgsql/Makefile   |   25 ++
contrib/sepgsql/dml.c  |  353 ++
contrib/sepgsql/expected/dml.out   |  182 ++
contrib/sepgsql/expected/label.out |  109 ++
contrib/sepgsql/expected/misc.out  |5 +
contrib/sepgsql/hooks.c|  446 +++
contrib/sepgsql/label.c|  477 
contrib/sepgsql/launcher   |   52 +++
contrib/sepgsql/proc.c |  158 
contrib/sepgsql/relation.c |  267 ++
contrib/sepgsql/schema.c   |   98 +
contrib/sepgsql/selinux.c  |  631 
contrib/sepgsql/sepgsql-regtest.te |   59 +++
contrib/sepgsql/sepgsql.h  |  288 +++
contrib/sepgsql/sepgsql.sql.in |   36 ++
contrib/sepgsql/sql/dml.sql|  118 ++
contrib/sepgsql/sql/label.sql  |   73 
contrib/sepgsql/sql/misc.sql   |5 +
doc/src/sgml/contrib.sgml  |1 +
doc/src/sgml/filelist.sgml |1 +
doc/src/sgml/sepgsql.sgml  |  704 
src/Makefile.global.in |1 +
src/test/regress/pg_regress.c  |6 +
src/test/regress/pg_regress.h  |1 +
src/test/regress/pg_regress_main.c |7 +-
30 files changed, 4246 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: First round of cleanup of sepgsql code and documentation.

2011-01-23 Thread Robert Haas
First round of cleanup of sepgsql code and documentation.

Robert Haas, with a few suggestions from Thom Brown

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=194c8f713aa62a528afa4ce4274b80aaff9eb264

Modified Files
--
contrib/sepgsql/.gitignore |4 +
contrib/sepgsql/dml.c  |4 +-
contrib/sepgsql/hooks.c|   10 +-
contrib/sepgsql/label.c|   41 ++---
doc/src/sgml/sepgsql.sgml  |  439 
5 files changed, 227 insertions(+), 271 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-23 Thread Robert Haas
On Sun, Jan 23, 2011 at 9:39 PM, Thom Brown  wrote:
> There are quite a few sentences which I'm not sure how to correct as I
> don't know how they're supposed to read.  But I've put together a
> patch to correct some of the typos and grammar.  There's a lot I
> haven't yet gone through though.

Thanks.  I just committed a bunch of cleanup, including whatever of
your patch I didn't rewrite along the way.  If you want to take
another crack at it now I'd be most grateful...

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Blind attempt to exclude sepgsql from MSVC build system.

2011-01-23 Thread Robert Haas
Blind attempt to exclude sepgsql from MSVC build system.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c26ac226e45fbf84cd63588498c00da9417aebc1

Modified Files
--
src/tools/msvc/Install.pm   |1 +
src/tools/msvc/Mkvcbuild.pm |3 +++
2 files changed, 4 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: PGXS support for contrib/hstore

2011-01-23 Thread Robert Haas
PGXS support for contrib/hstore

Joey Adams

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=41611f16e933dafa9c3ae0477f89537ea1459eb6

Modified Files
--
contrib/hstore/Makefile |   13 +
1 files changed, 9 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: More documentation cleanup for sepgsql.

2011-01-24 Thread Robert Haas
More documentation cleanup for sepgsql.

Thom Brown and Robert Haas

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=ea2c2641f908cde198a100d847078a05385b

Modified Files
--
doc/src/sgml/sepgsql.sgml |   96 +---
1 files changed, 46 insertions(+), 50 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-24 Thread Robert Haas
On Mon, Jan 24, 2011 at 8:18 AM, Thom Brown  wrote:
> On 24 January 2011 03:52, Robert Haas  wrote:
>> On Sun, Jan 23, 2011 at 9:39 PM, Thom Brown  wrote:
>>> There are quite a few sentences which I'm not sure how to correct as I
>>> don't know how they're supposed to read.  But I've put together a
>>> patch to correct some of the typos and grammar.  There's a lot I
>>> haven't yet gone through though.
>>
>> Thanks.  I just committed a bunch of cleanup, including whatever of
>> your patch I didn't rewrite along the way.  If you want to take
>> another crack at it now I'd be most grateful...
>
> Okay, an additional patch is attached.

Committed with a bit of further hacking.  Probably still needs more
work - in particular, I think there are probably some bits in here
that should use  or , and there's still some awkward
phrasing.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix thinko in ALTER FOREIGN TABLE documentation.

2011-01-25 Thread Robert Haas
Fix thinko in ALTER FOREIGN TABLE documentation.

Noah Misch

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=558d1c95ae6afb8728f70a150c593f7e7aa5fac1

Modified Files
--
doc/src/sgml/ref/alter_foreign_table.sgml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation

2011-01-25 Thread Robert Haas
Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation.

The latter is the correct name of the operation to change the data type
of a column.

Noah Misch

Branch
--
REL9_0_STABLE

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=2c3e29299842f6de74ff96d35ecaa1cc98fbcd5d

Modified Files
--
doc/src/sgml/ref/alter_table.sgml |8 
1 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation

2011-01-25 Thread Robert Haas
Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation.

The latter is the correct name of the operation to change the data type
of a column.

Noah Misch

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=2b2b2ae2aa4a7089aee729e67bb323154da3841a

Modified Files
--
doc/src/sgml/ref/alter_table.sgml |8 
1 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Update warning about synchronous-commit durability, per suggesti

2011-01-26 Thread Robert Haas
On Tue, Jan 25, 2011 at 8:32 PM, Bruce Momjian  wrote:
> Update warning about synchronous-commit durability, per suggestion from
> Robvert Haas.

The revised text is just as silly as the original text.  The point is
that with fsync turned off, the *entire database* is toast after a
crash.  You don't need to give any special warning for
synchronous_commit above and beyond what applies to the whole section.
 Just delete that part.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove arbitrary ALTER TABLE .. ADD COLUMN restriction.

2011-01-26 Thread Robert Haas
Remove arbitrary ALTER TABLE .. ADD COLUMN restriction.

The previous coding prevented ALTER TABLE .. ADD COLUMN from being used
with a non-NULL default in situations where the table's rowtype was being
used elsewhere.  But this is a completely arbitrary restriction since
you could do the same operation in multiple steps (add the column, add
the default, update the table).

Inspired by a patch from Noah Misch, though I didn't use his code.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a06e41deebdf74b8b5109329dc75b2e9d9057962

Modified Files
--
src/backend/commands/tablecmds.c   |8 +---
src/test/regress/expected/rowtypes.out |9 ++---
src/test/regress/sql/rowtypes.sql  |8 ++--
3 files changed, 17 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add a comment explaining why we force physical removal of OIDs.

2011-01-26 Thread Robert Haas
Add a comment explaining why we force physical removal of OIDs.

Noah Misch, slightly revised.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=5c2a7c6e97741564ab4ff336eac8d8227485dd4c

Modified Files
--
src/backend/commands/tablecmds.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Restore ALTER TABLE .. ADD COLUMN w/DEFAULT restriction.

2011-01-27 Thread Robert Haas
Restore ALTER TABLE .. ADD COLUMN w/DEFAULT restriction.

This reverts commit a06e41deebdf74b8b5109329dc75b2e9d9057962 of 2011-01-26.
Per discussion, this behavior is not wanted, as it would need to change if
we ever made composite types support DEFAULT.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a40b1e0bf32b1da46c1baa9bc7da87f207cd37d8

Modified Files
--
src/backend/commands/tablecmds.c   |8 +++-
src/test/regress/expected/rowtypes.out |9 +++--
src/test/regress/sql/rowtypes.sql  |8 ++--
3 files changed, 8 insertions(+), 17 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Try to avoid running with a full fsync request queue.

2011-01-29 Thread Robert Haas
Try to avoid running with a full fsync request queue.

When we need to insert a new entry and the queue is full, compact the
entire queue in the hopes of making room for the new entry.  Doing this
on every insertion might worsen contention on BgWriterCommLock, but
when the queue it's full, it's far better than allowing the backend to
perform its own fsync, per testing by Greg Smith as reported in
http://archives.postgresql.org/pgsql-hackers/2011-01/msg02665.php

Original idea from Greg Smith.  Patch by me.  Review by Chris Browne
and Greg Smith

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=7f242d880b5b5d9642675517466d31373961cf98

Modified Files
--
src/backend/postmaster/bgwriter.c |  134 ++---
src/backend/storage/smgr/md.c |8 ++-
2 files changed, 131 insertions(+), 11 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Log restartpoints in the same fashion as checkpoints.

2011-02-02 Thread Robert Haas
Log restartpoints in the same fashion as checkpoints.

Prior to 9.0, restartpoints never created, deleted, or recycled WAL
files, but now they can.  This code makes log_checkpoints treat
checkpoints and restartpoints symmetrically.  It also adjusts up
the documentation of the parameter to mention restartpoints.

Fujii Masao.  Docs by me, as suggested by Itagaki Takahiro.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=0af695fd43b6889613a4035e3cdfcc0fc1b7936a

Modified Files
--
doc/src/sgml/config.sgml  |7 +++
src/backend/access/transam/xlog.c |   22 ++
2 files changed, 17 insertions(+), 12 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Various sepgsql corrections.

2011-02-02 Thread Robert Haas
Various sepgsql corrections.

KaiGai Kohei

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c7689ee73346d198177dee538501bb1148c8cebb

Modified Files
--
contrib/sepgsql/dml.c  |   37 ++
contrib/sepgsql/expected/dml.out   |6 +-
contrib/sepgsql/expected/label.out |4 +-
contrib/sepgsql/expected/misc.out  |2 +-
contrib/sepgsql/hooks.c|4 +-
contrib/sepgsql/label.c|   89 ---
contrib/sepgsql/proc.c |3 +-
contrib/sepgsql/relation.c |   20 ++--
contrib/sepgsql/schema.c   |3 +-
contrib/sepgsql/selinux.c  |6 +-
contrib/sepgsql/sql/label.sql  |2 +-
11 files changed, 127 insertions(+), 49 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Minor sepgsql regression test fixes.

2011-02-02 Thread Robert Haas
Minor sepgsql regression test fixes.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=87d967f70f4866c17404f6a9b8062f892ed31e08

Modified Files
--
contrib/sepgsql/.gitignore   |2 ++
contrib/sepgsql/expected/dml.out |3 ++-
contrib/sepgsql/sql/dml.sql  |3 ++-
3 files changed, 6 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: sepgsql doc fix

2011-02-02 Thread Robert Haas
sepgsql doc fix

KaiGai Kohei

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=4ff9dec1386b714f6c26a52ca6880b14e94dd1db

Modified Files
--
doc/src/sgml/sepgsql.sgml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Further sepgsql documentation cleanup.

2011-02-02 Thread Robert Haas
Further sepgsql documentation cleanup.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=4c4daf671074cc64290e9255c14365b55bf7a47b

Modified Files
--
doc/src/sgml/sepgsql.sgml |  180 +
1 files changed, 36 insertions(+), 144 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: ALTER TABLE sometimes takes only ShareUpdateExclusiveLock.

2011-02-03 Thread Robert Haas
ALTER TABLE sometimes takes only ShareUpdateExclusiveLock.

Along the way, be more consistent about the wording we use here.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=7212c77d0cabcc468fec0b9cd7f2413b64b77050

Modified Files
--
doc/src/sgml/mvcc.sgml |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid maintaining three separate copies of the error codes list.

2011-02-03 Thread Robert Haas
Avoid maintaining three separate copies of the error codes list.

src/pl/plpgsql/src/plerrcodes.h, src/include/utils/errcodes.h, and a
big chunk of errcodes.sgml are now automatically generated from a single
file, src/backend/utils/errcodes.txt.

Jan Urbański, reviewed by Tom Lane.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=ddfe26f6441c24660595c5efe5fd0bd3974cdc5c

Modified Files
--
doc/src/sgml/.gitignore   |1 +
doc/src/sgml/Makefile |4 +-
doc/src/sgml/errcodes.sgml| 1559 +
doc/src/sgml/filelist.sgml|2 +
doc/src/sgml/generate-errcodes-table.pl   |   63 ++
src/Makefile  |   11 +
src/backend/Makefile  |1 +
src/backend/utils/.gitignore  |1 +
src/backend/utils/Makefile|7 +-
src/backend/utils/errcodes.txt|  452 +
src/backend/utils/generate-errcodes.pl|   41 +
src/include/Makefile  |2 +-
src/include/utils/.gitignore  |1 +
src/include/utils/errcodes.h  |  386 ---
src/pl/plpgsql/src/.gitignore |1 +
src/pl/plpgsql/src/Makefile   |   12 +-
src/pl/plpgsql/src/generate-plerrcodes.pl |   40 +
src/pl/plpgsql/src/plerrcodes.h   |  896 -
src/tools/msvc/Solution.pm|   13 +
src/tools/msvc/builddoc.bat   |1 +
20 files changed, 646 insertions(+), 2848 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Preserve copyright notice from old errcodes.h file.

2011-02-03 Thread Robert Haas
Preserve copyright notice from old errcodes.h file.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b8a0467e10a41d32ecf889d40de81223e0439c5b

Modified Files
--
src/backend/utils/errcodes.txt |1 +
1 files changed, 1 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Unbreak the VPATH build.

2011-02-03 Thread Robert Haas
Unbreak the VPATH build.

My commit ddfe26f6441c24660595c5efe5fd0bd3974cdc5c of 2010-02-03 broke it.

Per buildfarm.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=dde9684d65ed66656f765d3fd97f2e522a189132

Modified Files
--
src/backend/utils/Makefile  |2 +-
src/pl/plpgsql/src/Makefile |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Unbreak 'configure' followed immediately by 'make install'.

2011-02-04 Thread Robert Haas
Unbreak 'configure' followed immediately by 'make install'.

More fallout from ddfe26f6441c24660595c5efe5fd0bd3974cdc5c.

Report by Fujii Masao.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b87811ee273360c45d92b0e7bb7e67670312c221

Modified Files
--
src/Makefile |1 +
1 files changed, 1 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make handling of errcodes.h more consistent with other generated

2011-02-04 Thread Robert Haas
Make handling of errcodes.h more consistent with other generated headers.

This fixes make distprep, and seems more robust in other ways as well.
Some special handling is required because errcodes.txt is needed by
some stuff in src/port, but just by src/backend as is the case for the
other generated headers.

While I'm at it, fix a few other things that were overlooked in the
original patch.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=356f2cbbb42811596820c94aaec2e32ad1ec58d8

Modified Files
--
src/Makefile   |   12 
src/backend/Makefile   |   16 +---
src/backend/utils/Makefile |2 +-
src/include/Makefile   |1 +
src/port/Makefile  |7 +++
src/tools/msvc/clean.bat   |1 +
6 files changed, 23 insertions(+), 16 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Use $(MAKE) rather than make.

2011-02-04 Thread Robert Haas
Use $(MAKE) rather than make.

Per buildfarm.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6f59a5e5dd73ec2c448dd7038accf5aaba6dc04b

Modified Files
--
src/port/Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Update ALTER TABLE docs to mention using VACUUM FULL for rewrite

2011-02-04 Thread Robert Haas
Update ALTER TABLE docs to mention using VACUUM FULL for rewrites.

Remove the claim that ALTER TABLE .. SET DATA TYPE is the fastest way of
rewriting a table, since it no longer is.

Noah Misch and Robert Haas, based on a suggestion from Tom Lane.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=edad08ba545b43261b4d54d65122b45c9b5ee801

Modified Files
--
doc/src/sgml/ref/alter_table.sgml |   23 ---
1 files changed, 8 insertions(+), 15 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid including postgres.h in frontend compiles of src/port.

2011-02-04 Thread Robert Haas
Avoid including postgres.h in frontend compiles of src/port.

This isn't kosher, and doesn't play nicely with my recent changes to the
Makefile in this directory.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=8201aea90c2b171808c65836fcce4f29b22a9dbb

Modified Files
--
src/port/dirent.c |5 +
src/port/pipe.c   |4 
src/port/win32error.c |4 
3 files changed, 13 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Move pipe.c into the backend.

2011-02-04 Thread Robert Haas
Move pipe.c into the backend.

It's full of backend-specific error reporting, so it's neither possible
nor necessary for this to be used from frontend code.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b1e65c32168a2b64276a57be8c4dc5a63d33e12d

Modified Files
--
src/backend/port/Makefile |4 ++
src/backend/port/pipe.c   |   95 +++
src/port/Makefile |4 --
src/port/pipe.c   |   99 -
4 files changed, 99 insertions(+), 103 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Clarify comment in ATRewriteTable().

2011-02-04 Thread Robert Haas
Clarify comment in ATRewriteTable().

Make sure it's clear that the prohibition on adding a column with a default
when the rowtype is used elsewhere is intentional, and be a bit more
explicit about the other cases where we perform this check.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=9e7e1172a53054dc14574e42865ea8213bc06371

Modified Files
--
src/backend/commands/tablecmds.c |   14 +-
1 files changed, 9 insertions(+), 5 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Tighten ALTER FOREIGN TABLE .. SET DATA TYPE checks.

2011-02-05 Thread Robert Haas
Tighten ALTER FOREIGN TABLE .. SET DATA TYPE checks.

If the foreign table's rowtype is being used as the type of a column in
another table, we can't just up and change its data type.  This was
already checked for composite types and ordinary tables, but we
previously failed to enforce it for foreign tables.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=65377e0b9c0e0397b1598b38b6a7fb8b6f740d39

Modified Files
--
src/backend/commands/tablecmds.c   |   43 +--
src/backend/commands/typecmds.c|2 +-
src/include/commands/tablecmds.h   |3 +-
src/test/regress/expected/foreign_data.out |7 -
src/test/regress/sql/foreign_data.sql  |6 +++-
5 files changed, 34 insertions(+), 27 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: remove tags.

2011-02-06 Thread Robert Haas
On Sun, Feb 6, 2011 at 11:12 PM, Tom Lane  wrote:
> Bruce Momjian  writes:
>> Bruce Momjian wrote:
>>> remove tags.
>
>> Sorry, vague commit message (I forgot squash).
>
>> Can I will use git ammend to improve this message?

Absolutely not.

> How about git revert, instead?  It's not apparent to me that these
> changes were improvements.

I'll buy that one.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid having autovacuum workers wait for relation locks.

2011-02-07 Thread Robert Haas
Avoid having autovacuum workers wait for relation locks.

Waiting for relation locks can lead to starvation - it pins down an
autovacuum worker for as long as the lock is held.  But if we're doing
an anti-wraparound vacuum, then we still wait; maintenance can no longer
be put off.

To assist with troubleshooting, if log_autovacuum_min_duration >= 0,
we log whenever an autovacuum or autoanalyze is skipped for this reason.

Per a gripe by Josh Berkus, and ensuing discussion.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=32896c40ca766146312b28a5a0eb3f66ca0300ed

Modified Files
--
doc/src/sgml/config.sgml|5 +++-
src/backend/commands/analyze.c  |   15 -
src/backend/commands/vacuum.c   |   39 ++
src/backend/postmaster/autovacuum.c |   14 +--
src/include/nodes/parsenodes.h  |3 +-
5 files changed, 61 insertions(+), 15 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Tweak find_composite_type_dependencies API a bit more.

2011-02-11 Thread Robert Haas
Tweak find_composite_type_dependencies API a bit more.

Per discussion with Noah Misch, the previous coding, introduced by
my commit 65377e0b9c0e0397b1598b38b6a7fb8b6f740d39 on 2011-02-06,
was really an abuse of RELKIND_COMPOSITE_TYPE, since the caller in
typecmds.c is actually passing the name of a domain.  So go back
having a type name argument, but make the first argument a Relation
rather than just a string so we can tell whether it's a table or
a foreign table and emit the proper error message.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/2c20ba1fd284423e4652f2f6855d257339245e97

Modified Files
--
src/backend/commands/tablecmds.c |   25 +
src/backend/commands/typecmds.c  |2 +-
src/include/commands/tablecmds.h |3 ++-
3 files changed, 16 insertions(+), 14 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Typo fixes. receivedUpto should be capitalized consistently.

2011-02-11 Thread Robert Haas
Typo fixes.  receivedUpto should be capitalized consistently.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/d309acf201ab2c5bbd1f6a5d51e4a8060eb6a63c

Modified Files
--
src/backend/replication/README|4 ++--
src/backend/replication/walreceiver.c |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Allow tab-completion of :variable even as first word on a line.

2011-02-11 Thread Robert Haas
Allow tab-completion of :variable even as first word on a line.

Christoph Berg

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5917574539732a6e521a6dc260fcd7c9a258d89e

Modified Files
--
src/bin/psql/tab-complete.c |   22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Teach ALTER TABLE .. SET DATA TYPE to avoid some table rewrites.

2011-02-12 Thread Robert Haas
Teach ALTER TABLE .. SET DATA TYPE to avoid some table rewrites.

When the old type is binary coercible to the new type and the using
clause does not change the column contents, we can avoid a full table
rewrite, though any indexes on the affected columns will still need
to be rebuilt.  This applies, for example, when changing a varchar
column to be of type text.

The prior coding assumed that the set of operations that force a
rewrite is identical to the set of operations that must be propagated
to tables making use of the affected table's rowtype.  This is
no longer true: even though the tuples in those tables wouldn't
need to be modified, the data type change invalidate indexes built
using those composite type columns.  Indexes on the table we're
actually modifying can be invalidated too, of course, but the
existing machinery is sufficient to handle that case.

Along the way, add some debugging messages that make it possible
to understand what operations ALTER TABLE is actually performing
in these cases.

Noah Misch and Robert Haas

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/d31e2a495b6f2127afc31b4da2e5f4e89aa2cdfe

Modified Files
--
doc/src/sgml/ref/alter_table.sgml |   16 ---
src/backend/catalog/index.c   |5 ++
src/backend/commands/tablecmds.c  |   90 -
3 files changed, 83 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Delete stray word from comment.

2011-02-14 Thread Robert Haas
Delete stray word from comment.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/8e1124eeeb128ef87045debfeb8f24cd6dbab874

Modified Files
--
src/backend/commands/tablecmds.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid a few more SET DATA TYPE table rewrites.

2011-02-14 Thread Robert Haas
Avoid a few more SET DATA TYPE table rewrites.

When the new type is an unconstrained domain over the old type, we don't
need to rewrite the table.

Noah Misch and Robert Haas

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/0d90dc16f87bd991d7eb9f536ca46acef7586d95

Modified Files
--
doc/src/sgml/ref/alter_table.sgml |   15 ---
src/backend/commands/tablecmds.c  |   20 
2 files changed, 24 insertions(+), 11 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Rename max_predicate_locks_per_transaction.

2011-02-15 Thread Robert Haas
Rename max_predicate_locks_per_transaction.

The new name, max_pred_locks_per_transaction, is shorter.

Kevin Grittner, per discussion.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/6a77e9385eb46829ce80971bc655df9f3ef00d9a

Modified Files
--
doc/src/sgml/config.sgml  |8 
src/backend/storage/lmgr/predicate.c  |   10 +-
src/backend/utils/misc/guc.c  |4 ++--
src/backend/utils/misc/postgresql.conf.sample |2 +-
4 files changed, 12 insertions(+), 12 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Assorted corrections to the patch to add WAL receiver replies.

2011-02-15 Thread Robert Haas
Assorted corrections to the patch to add WAL receiver replies.

Per reports from Fujii Masao.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/883a9659faf6e49e314b264ca32ed7645068a409

Modified Files
--
doc/src/sgml/config.sgml|   46 +-
src/backend/replication/walsender.c |   25 ++
2 files changed, 42 insertions(+), 29 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: pg_ctl promote

2011-02-15 Thread Robert Haas
pg_ctl promote

Fujii Masao, reviewed by Robert Haas, Stephen Frost, and Magnus Hagander.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/4695da5ae97bbb58d274887fd68edbe88d03ebcb

Modified Files
--
doc/src/sgml/high-availability.sgml |   24 +--
doc/src/sgml/recovery-config.sgml   |4 +-
doc/src/sgml/ref/pg_ctl-ref.sgml|   13 ++
src/backend/access/transam/xlog.c   |   49 +--
src/backend/postmaster/postmaster.c |8 
src/bin/pg_ctl/pg_ctl.c |   74 ++-
src/include/access/xlog.h   |1 +
7 files changed, 152 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: WAL receiver shouldn't try to send a reply when dying.

2011-02-16 Thread Robert Haas
WAL receiver shouldn't try to send a reply when dying.

Per report from, and discussion with, Fujii Masao.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3a087369c0ea858e56c8af5072de91778a644383

Modified Files
--
src/backend/replication/walreceiver.c |   20 +---
1 files changed, 13 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove rule to build sepgsql-regtest.pp.

2011-02-17 Thread Robert Haas
Remove rule to build sepgsql-regtest.pp.

Instead, document how to build it manually.

Per discussion.  KaiGai Kohei, with some wordsmithing by me.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/24bc6b3db3579f4c480c6d0f81f7e50f1e6c0180

Modified Files
--
contrib/sepgsql/Makefile  |5 +
doc/src/sgml/sepgsql.sgml |   15 ++-
2 files changed, 11 insertions(+), 9 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Typo fixes.

2011-02-17 Thread Robert Haas
Typo fixes.

Thom Brown

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9408783aefee9d58dd9daf53c8d6b24ab226f05b

Modified Files
--
doc/src/sgml/sepgsql.sgml |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Remove rule to build sepgsql-regtest.pp.

2011-02-17 Thread Robert Haas
On Thu, Feb 17, 2011 at 6:44 AM, Thom Brown  wrote:
> Couple typos:
>
> s/source fire/source file/
> s/If this packages/If this package/

I don't know, I kind of like "source fire".  Sounds exciting.

Thanks as usual Thom.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add some words of caution to elog.c.

2011-02-17 Thread Robert Haas
Add some words of caution to elog.c.

Stephen Frost, somewhat rewritten by me

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f196738534baa95badd9d8f1debb5822240ebc6b

Modified Files
--
src/backend/utils/error/elog.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add client_hostname field to pg_stat_activity.

2011-02-17 Thread Robert Haas
Add client_hostname field to pg_stat_activity.

Peter Eisentraut, reviewed by Steve Singer, Alvaro Herrera, and me.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/4a25bc145ad5d05da6f01c00bae0f576e9e17115

Modified Files
--
doc/src/sgml/monitoring.sgml |   31 +++
src/backend/catalog/system_views.sql |2 ++
src/backend/postmaster/pgstat.c  |   28 +++-
src/backend/utils/adt/pgstatfuncs.c  |   22 --
src/include/catalog/catversion.h |2 +-
src/include/catalog/pg_proc.h|2 +-
src/include/pgstat.h |1 +
src/test/regress/expected/rules.out  |4 ++--
8 files changed, 69 insertions(+), 23 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Prevent possible compiler warnings.

2011-02-17 Thread Robert Haas
Prevent possible compiler warnings.

Simon Riggs reports that rnode.dbNode and rnode.spcNode were
generating unused variable warnings on gcc 4.4.3 with CFLAGS=-O1

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/a3e8486dffc413506b14eae9dc5d423f6ae8324a

Modified Files
--
src/backend/utils/adt/dbsize.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.

2011-02-18 Thread Robert Haas
On Fri, Feb 18, 2011 at 2:07 PM, Simon Riggs  wrote:
> On Fri, 2011-02-18 at 20:22 +0200, Heikki Linnakangas wrote:
>> On 18.02.2011 13:34, Simon Riggs wrote:
>> > Separate messages for standby replies and hot standby feedback.
>> > Allow messages to be sent at different times, and greatly reduce
>> > the frequency of hot standby feedback. Refactor to allow additional
>> > message types.
>>
>> Please update the docs too, these messages are briefly explained at
>> http://developer.postgresql.org/pgdocs/postgres/protocol-replication.html
>
> Hadn't forgotten, just working thru things in priority order.

Updating the documentation is surely not a low-priority item.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix a couple of unlogged tables goofs.

2011-02-22 Thread Robert Haas
Fix a couple of unlogged tables goofs.

"SELECT ... INTO UNLOGGED tabname" works, but wasn't documented; CREATE
UNLOGGED SEQUENCE and CREATE UNLOGGED VIEW failed an assertion, instead
of throwing a sensible error.

Latter issue reported by Itagaki Takahiro; patch review by Tom Lane.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3e6b305d9e2a4616bf69e31b0b21ebbb844ba50e

Modified Files
--
doc/src/sgml/ref/select_into.sgml |   12 +++-
src/backend/commands/sequence.c   |6 ++
src/backend/commands/view.c   |6 ++
3 files changed, 23 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Named restore point improvements.

2011-02-24 Thread Robert Haas
Named restore point improvements.

Emit a log message when creating a named restore point, and improve
documentation for pg_create_restore_point().

Euler Taveira de Oliveira,  per suggestions from Thom Brown, with some
additional wordsmithing by me.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/79ad8fc5f857ed38057f482fc022bf157175c4d8

Modified Files
--
doc/src/sgml/func.sgml|   10 ++
src/backend/access/transam/xlog.c |4 
2 files changed, 14 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Rename pg_stat_replication.apply_location to replay_location.

2011-02-28 Thread Robert Haas
Rename pg_stat_replication.apply_location to replay_location.

For consistency with pg_last_xlog_replay_location.  Per discussion.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/92c30fd2edee6da6e018f41a1d67b4ac2f8fcbdd

Modified Files
--
src/backend/catalog/system_views.sql |2 +-
src/include/catalog/catversion.h |2 +-
src/include/catalog/pg_proc.h|2 +-
src/test/regress/expected/rules.out  |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid excessive Hot Standby feedback messages.

2011-03-01 Thread Robert Haas
Avoid excessive Hot Standby feedback messages.

Without this patch, when wal_receiver_status_interval=0, indicating that no
status messages should be sent, Hot Standby feedback messages are instead sent
extremely frequently.

Fujii Masao, with documentation changes by me.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/59d6a7594288ebc909a24f3fc9e502f097bbe2ff

Modified Files
--
doc/src/sgml/config.sgml  |7 ---
src/backend/replication/walreceiver.c |2 +-
2 files changed, 5 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Refactor seclabel.c to use the new check_object_ownership functi

2011-03-04 Thread Robert Haas
Refactor seclabel.c to use the new check_object_ownership function.

This avoids duplicate (and not-quite-matching) code, and makes the logic
for SECURITY LABEL match COMMENT and ALTER EXTENSION ADD/DROP.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/efa415da8c0fb8c1c0bc50faebac430f8b917571

Modified Files
--
src/backend/commands/seclabel.c |   90 ---
1 files changed, 18 insertions(+), 72 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove emphasis from 9.1alpha3 items.

2011-03-05 Thread Robert Haas
Remove emphasis from 9.1alpha3 items.

In preparation for 9.1alpha4 release notes, where only the 9.1alpha4
features will be emphasized.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/a4406da967093a9793db0fbceb6e226e318932b6

Modified Files
--
doc/src/sgml/release-9.1.sgml |   66 -
1 files changed, 32 insertions(+), 34 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: First cut at 9.1alpha4 release notes.

2011-03-05 Thread Robert Haas
First cut at 9.1alpha4 release notes.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5c44f38d3b63c5a11f58fe558adfe4d3cf4dcc39

Modified Files
--
doc/src/sgml/release-9.1.sgml |  545 -
1 files changed, 539 insertions(+), 6 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add missing word.

2011-03-05 Thread Robert Haas
Add missing word.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f31e532492aa950c62c3ded32d07d1e42017e557

Modified Files
--
doc/src/sgml/release-9.1.sgml |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove one copy of duplicated alpha4 release note.

2011-03-05 Thread Robert Haas
Remove one copy of duplicated alpha4 release note.

Noted by Andy Colson

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c0f2b2e256a3e98c2a066cee8623b7ab156b7f9c

Modified Files
--
doc/src/sgml/release-9.1.sgml |   12 
1 files changed, 0 insertions(+), 12 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Synchronous replication doc corrections.

2011-03-07 Thread Robert Haas
Synchronous replication doc corrections.

Thom Brown

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c74d3aceb99ea6c6d102109349b514e76e497592

Modified Files
--
doc/src/sgml/config.sgml|2 +-
doc/src/sgml/high-availability.sgml |9 +++--
2 files changed, 4 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reword alpha release note item on SSI.

2011-03-07 Thread Robert Haas
Reword alpha release note item on SSI.

Per Josh Berkus; some additional explanatory text by me.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/bcf85e3f44a518eb7bb759541189efb6726fe9bc

Modified Files
--
doc/src/sgml/release-9.1.sgml |9 -
1 files changed, 8 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Create "replication and recovery" section in alpha release notes

2011-03-08 Thread Robert Haas
Create "replication and recovery" section in alpha release notes.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/51c0124481213eab45db193929614070da7b60d1

Modified Files
--
doc/src/sgml/release-9.1.sgml |  109 ++---
1 files changed, 59 insertions(+), 50 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Update alpha release notes for latest commits.

2011-03-08 Thread Robert Haas
Update alpha release notes for latest commits.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f14ae5f905282109c9a2571c2048c564004f24c5

Modified Files
--
doc/src/sgml/release-9.1.sgml |   49 ++--
1 files changed, 32 insertions(+), 17 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make alpha release notes more consistent as regards periods.

2011-03-08 Thread Robert Haas
Make alpha release notes more consistent as regards periods.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/26ed3fdb4553a0e52c8534292de0f39bfc2c5022

Modified Files
--
doc/src/sgml/release-9.1.sgml |   23 +++
1 files changed, 11 insertions(+), 12 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Replication README updates.

2011-03-10 Thread Robert Haas
Replication README updates.

Fujii Masao

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/fcb99609b60012bc2e828b8941d5db46f2625f4a

Modified Files
--
src/backend/replication/README |   31 ++-
1 files changed, 18 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add missing index terms for recovery control functions.

2011-03-10 Thread Robert Haas
Add missing index terms for recovery control functions.

Fujii Masao

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/1c3b434a0897a727127b7c4083f2bfa2c9b690c3

Modified Files
--
doc/src/sgml/func.sgml |   10 ++
1 files changed, 10 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Emit a LOG message when pausing at the recovery target.

2011-03-10 Thread Robert Haas
Emit a LOG message when pausing at the recovery target.

Fujii Masao

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/d16e290a8a52d76d01ef1d70f8c6942a0870

Modified Files
--
src/backend/access/transam/xlog.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Minor sync rep corrections.

2011-03-10 Thread Robert Haas
Minor sync rep corrections.

Fujii Masao, with a bit of additional wordsmithing by me.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/64360987953e450e53098e6b79d89c5b80dc7842

Modified Files
--
src/backend/replication/syncrep.c  |6 +++---
src/backend/storage/ipc/shmqueue.c |2 +-
src/include/replication/syncrep.h  |3 +--
3 files changed, 5 insertions(+), 6 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove obsolete comment.

2011-03-10 Thread Robert Haas
Remove obsolete comment.

In earlier versions of the sync rep patch, waiters removed themselves from
the queue, but now walsender removes them before doing the wakeup.

Report by Fujii Masao.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/e397d2ee6474865becb8f99ac28586736788f1f2

Modified Files
--
src/include/replication/walsender.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: More synchronous replication tweaks.

2011-03-10 Thread Robert Haas
More synchronous replication tweaks.

SyncRepRequested() must check not only the value of the
synchronous_replication GUC but also whether max_wal_senders > 0.
Otherwise, we might end up waiting for sync rep even when there's no
possibility of a standby ever managing to connect.  There are some
existing cross-checks to prevent this, but they're not quite sufficient:
the user can start the server with max_wal_senders=0,
synchronous_standby_names='', and synchronous_replication=off and then
subsequent make synchronous_standby_names not empty using pg_ctl reload,
and then SET synchronous_standby=on, leading to an indefinite hang.

Along the way, rename the global variable for the synchronous_replication
GUC to match the name of the GUC itself, for clarity.

Report by Fujii Masao, though I didn't use his patch.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/b8bb8dbf20e13087f8e57ff4c42e81776ae5e545

Modified Files
--
src/backend/replication/syncrep.c |2 +-
src/backend/utils/misc/guc.c  |2 +-
src/include/replication/syncrep.h |5 +++--
3 files changed, 5 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.

2011-03-10 Thread Robert Haas
On Mon, Mar 7, 2011 at 3:27 AM, Fujii Masao  wrote:
> On Mon, Mar 7, 2011 at 7:51 AM, Simon Riggs  wrote:
>> Efficient transaction-controlled synchronous replication.
>> If a standby is broadcasting reply messages and we have named
>> one or more standbys in synchronous_standby_names then allow
>> users who set synchronous_replication to wait for commit, which
>> then provides strict data integrity guarantees. Design avoids
>> sending and receiving transaction state information so minimises
>> bookkeeping overheads. We synchronize with the highest priority
>> standby that is connected and ready to synchronize. Other standbys
>> can be defined to takeover in case of standby failure.
>>
>> This version has very strict behaviour; more relaxed options
>> may be added at a later date.
>
> Pretty cool! I'd appreciate very much your efforts and contributions.
>
> And,, I found one bug ;) You seem to have wrongly removed the check
> of max_wal_senders in SyncRepWaitForLSN. This can make the
> backend wait for replication even if max_wal_senders = 0. I could produce
> this problematic situation in my machine. The attached patch fixes this 
> problem.

I committed a slightly different fix for this problem.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: More synchronous replication typo fixes.

2011-03-10 Thread Robert Haas
More synchronous replication typo fixes.

Fujii Masao

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/2e019c8611654175780db488d81cc2dc8311f22e

Modified Files
--
src/backend/replication/syncrep.c |2 +-
src/include/storage/proc.h|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make error handling of synchronous_standby_names consistent.

2011-03-10 Thread Robert Haas
Make error handling of synchronous_standby_names consistent.

It's not a good idea to kill the postmaster just because someone muffs
this, and it's not consistent with what we do for other, similar GUCs.

Fujii Masao, with a bit more hacking by me

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/551c07d84ae2f0d3b7dde68e52322edf9cb87ba5

Modified Files
--
src/backend/replication/syncrep.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove 13 keywords that are used only for ROLE options.

2011-03-15 Thread Robert Haas
Remove 13 keywords that are used only for ROLE options.

Review by Tom Lane.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5ca4dfc79f21828174de3a8bc7d29718d0c52c34

Modified Files
--
src/backend/parser/gram.y   |  132 +++
src/include/parser/kwlist.h |   13 
2 files changed, 58 insertions(+), 87 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Minor sync rep documentation improvements.

2011-03-15 Thread Robert Haas
Minor sync rep documentation improvements.

- Make the name of the ID tag for the GUC entry match the GUC name.
- Clarify that synchronous_replication waits for xlog flush, not receipt.
- Mention that synchronous_replication won't wait if max_wal_senders=0.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f0f3617135854281bdb79179a895c102d54cb95b

Modified Files
--
doc/src/sgml/config.sgml |   10 ++
1 files changed, 6 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Corrections to CREATE FOREIGN TABLE documentation.

2011-03-16 Thread Robert Haas
Corrections to CREATE FOREIGN TABLE documentation.

Omit incorrect = sign, and properly document server_name parameter.

Shigeru Hanada

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5f588e20051eb18333f6ea5b46bd779ba1eb8773

Modified Files
--
doc/src/sgml/ref/create_foreign_table.sgml |   11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Tab completion for \pset format and \pset linestyle.

2011-03-16 Thread Robert Haas
Tab completion for \pset format and \pset linestyle.

Pavel Stehule

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/ad3aff45f0d302b35d009e525de8a9d0ee9745a9

Modified Files
--
src/bin/psql/tab-complete.c |   18 ++
1 files changed, 18 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix various possible problems with synchronous replication.

2011-03-17 Thread Robert Haas
Fix various possible problems with synchronous replication.

1. Don't ignore query cancel interrupts.  Instead, if the user asks to
cancel the query after we've already committed it, but before it's on
the standby, just emit a warning and let the COMMIT finish.

2. Don't ignore die interrupts (pg_terminate_backend or fast shutdown).
Instead, emit a warning message and close the connection without
acknowledging the commit.  Other backends will still see the effect of
the commit, but there's no getting around that; it's too late to abort
at this point, and ignoring die interrupts altogether doesn't seem like
a good idea.

3. If synchronous_standby_names becomes empty, wake up all backends
waiting for synchronous replication to complete.  Without this, someone
attempting to shut synchronous replication off could easily wedge the
entire system instead.

4. Avoid depending on the assumption that if a walsender updates
MyProc->syncRepState, we'll see the change even if we read it without
holding the lock.  The window for this appears to be quite narrow (and
probably doesn't exist at all on machines with strong memory ordering)
but protecting against it is practically free, so do that.

5. Remove useless state SYNC_REP_MUST_DISCONNECT, which isn't needed and
doesn't actually do anything.

There's still some further work needed here to make the behavior of fast
shutdown plausible, but that looks complex, so I'm leaving it for a
separate commit.  Review by Fujii Masao.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9a56dc3389b9470031e9ef8e45c95a680982e01a

Modified Files
--
doc/src/sgml/config.sgml|3 +-
src/backend/postmaster/walwriter.c  |6 +
src/backend/replication/syncrep.c   |  302 ++-
src/backend/tcop/postgres.c |6 +
src/include/replication/syncrep.h   |4 +-
src/include/replication/walsender.h |7 +
6 files changed, 214 insertions(+), 114 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add pause_at_recovery_target to recovery.conf.sample; improve do

2011-03-17 Thread Robert Haas
Add pause_at_recovery_target to recovery.conf.sample; improve docs.

Fujii Masao, but with the proposed behavior change reverted, and the
rest adjusted accordingly.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/84abea76f60c5fd1c008b8ddf250b4bc89e288fc

Modified Files
--
doc/src/sgml/recovery-config.sgml   |6 +-
src/backend/access/transam/recovery.conf.sample |8 
2 files changed, 13 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove bogus comment.

2011-03-17 Thread Robert Haas
Remove bogus comment.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/02b1f84e7d2c8921d3ef291469cfd4b7235358f0

Modified Files
--
src/backend/replication/walsender.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Protocol documentation for Hot Standby feedback messages.

2011-03-17 Thread Robert Haas
Protocol documentation for Hot Standby feedback messages.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/76dbb4615389e1f44e48074b87be77262143021e

Modified Files
--
doc/src/sgml/protocol.sgml |   63 +--
1 files changed, 60 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Minor fixes for high availability documentation.

2011-03-17 Thread Robert Haas
Minor fixes for high availability documentation.

Erik Rijkers and me

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f94c6f9c0f05ff70b232e620eb9c420294e90cd3

Modified Files
--
doc/src/sgml/high-availability.sgml |   28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove bogus semicolons in recoveryPausesHere.

2011-03-18 Thread Robert Haas
Remove bogus semicolons in recoveryPausesHere.

Without this, the startup process goes into a tight loop, consuming
100% of one CPU and failing to respond to interrupts.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/777e8c0015743224cc46f3ce39243b05c6d882ef

Modified Files
--
src/backend/access/transam/xlog.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove ancient -X options to pg_dump, pg_dumpall, pg_restore.

2011-03-18 Thread Robert Haas
Remove ancient -X options to pg_dump, pg_dumpall, pg_restore.

The last version in which these options were documented is now EOL, so
it's time to get rid of them for real.  We now use GNU-style long
options instead.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c5eb835bbffb99518405a1e5bccb58c85e0ab30e

Modified Files
--
src/bin/pg_dump/pg_dump.c|   25 +
src/bin/pg_dump/pg_dumpall.c |   24 
src/bin/pg_dump/pg_restore.c |   25 +
3 files changed, 2 insertions(+), 72 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make synchronous replication query cancel/die messages more cons

2011-03-18 Thread Robert Haas
Make synchronous replication query cancel/die messages more consistent.

Per a gripe from Thom Brown about my previous commit in this area,
commit 9a56dc3389b9470031e9ef8e45c95a680982e01a.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/7a37900443b016e0e7c72f6b42327bc05f8b5003

Modified Files
--
src/backend/replication/syncrep.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Document the all-balls IPv6 address.

2011-03-18 Thread Robert Haas
On Fri, Mar 18, 2011 at 6:56 PM, Andrew Dunstan  wrote:
> + 0.0.0.0/0 (all balls) represents all
> +       IPv4 addresses, and :: represents
> +       all IPv6 addresses.
>
> Umm, isn't there a missing netmask there? The IPv6 analog of 0.0.0.0/0 is
> surely ::/0 (or I would usually write it ::0/0).

"all balls" seems like a colloquialism best avoided in our documentation.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Remove ancient -X options to pg_dump, pg_dumpall, pg_restore.

2011-03-18 Thread Robert Haas
On Fri, Mar 18, 2011 at 9:05 PM, Tom Lane  wrote:
> Robert Haas  writes:
>> Remove ancient -X options to pg_dump, pg_dumpall, pg_restore.
>> The last version in which these options were documented is now EOL, so
>> it's time to get rid of them for real.  We now use GNU-style long
>> options instead.
>
> It looks like you forgot to remove 'X:' from the getopt calls.

Good catch, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


  1   2   3   4   5   6   7   8   9   10   >