Re: pgbench - extend initialization phase control

[btendouan]

Hi,

When g is specified, null is inserted in the filler column of 
pgbentch_tellrs, acounts, branches.

But when G is specified, empty string is inserted.

Do you have any intention of this difference?

--
Anna

Re: pgbench - extend initialization phase control

[btendouan]

Here is rebase v3.


Hi,

Thanks for your new patch.

Failed regression test.
It's necessary to change the first a in “allowed step characters are” to 
uppercase A in the regression test of 002_pgbench_no_server.pl.


The behavior of "g" is different between v12 and the patche, and 
backward compatibility is lost.

In v12, BEGIN and COMMIT are specified only by choosing "g".
It's a problem that backward compatibility is lost.

When using ( and ) with the -I, the documentation should indicate that 
double quotes are required,

and  "v" not be able to enclose in ( and ).

Regards,

--
Anna

Re: pgbench - extend initialization phase control

[btendouan]

Hello Fabien,


-- Forwarded message -
From: Fabien COELHO 
Date: Tue, Jul 16, 2019 at 4:58 PM
Subject: Re: pgbench - extend initialization phase control
To: Ibrar Ahmed 
Cc: PostgreSQL Developers 



Hello Ibrar,

The following review has been posted through the commitfest 
application:

make installcheck-world:  tested, passed
Implements feature:   tested, passed
Spec compliant:   tested, passed
Documentation:not tested

Other than that, the patch looks good to me.

The new status of this patch is: Ready for Committer


Thanks for the review.

Attached v2 is a rebase after ce8f9467.


Thanks for your new patch.

But I failed to apply it. Please rebase it against HEAD.

Regards,

-
Anna