Re: 回复：回复：Fix missing initialization of delayChkptEnd
On Wed, Jun 07, 2023 at 10:25:25AM +0800, 蔡梦娟(玊于) wrote: > In my new patch for pg14, I add the assertion on delayChkptEnd in > ProcArrayClearTransaction, and also add patches for release branch > from 10 to 13, please check. Thanks for the patches. I finally got back to that, double-checked all the spots where these flags are used on all the branches, and that seems right to me. So applied across 11~14. -- Michael signature.asc Description: PGP signature
回复：回复：Fix missing initialization of delayChkptEnd
In my new patch for pg14, I add the assertion on delayChkptEnd in ProcArrayClearTransaction, and also add patches for release branch from 10 to 13, please check. Thanks & Best Regard -- 发件人：Kyotaro Horiguchi 发送时间：2023年6月6日(星期二) 14:13 收件人：蔡梦娟(玊于) 抄 送：pgsql-hackers ; robertmhaas 主 题：Re: 回复：Fix missing initialization of delayChkptEnd Good catch! At Tue, 06 Jun 2023 00:39:47 +0800, "蔡梦娟(玊于)" wrote in > Hi, all. I updated the patch for this bugfix, the previous one > missed the modification of function InitAuxiliaryProcess, please > check the new patch. After a quick check through the 14 tree, then compaing with the corresponding parts of 15, it hit me that ProcArrayClearTransaction() needs an assertion on the variable. Other than that, the patch looks good to me. regards. -- Kyotaro Horiguchi NTT Open Source Software Center v1-0001-Fix-missing-initialization-of-delayChkptEnd_10.patch Description: Binary data v1-0001-Fix-missing-initialization-of-delayChkptEnd_11.patch Description: Binary data v1-0001-Fix-missing-initialization-of-delayChkptEnd_12.patch Description: Binary data v1-0001-Fix-missing-initialization-of-delayChkptEnd_13.patch Description: Binary data v3-0001-Fix-missing-initialization-of-delayChkptEnd_14.patch Description: Binary data
Re: 回复：Fix missing initialization of delayChkptEnd
On Tue, Jun 06, 2023 at 03:13:14PM +0900, Kyotaro Horiguchi wrote: > After a quick check through the 14 tree, then compaing with the > corresponding parts of 15, it hit me that ProcArrayClearTransaction() > needs an assertion on the variable. Other than that, the patch looks > good to me. Yeah, it feels wrong to check only after delayChkpt in this code path. I'll look at that tomorrow. -- Michael signature.asc Description: PGP signature
Re: 回复：Fix missing initialization of delayChkptEnd
Good catch! At Tue, 06 Jun 2023 00:39:47 +0800, "蔡梦娟(玊于)" wrote in > Hi, all. I updated the patch for this bugfix, the previous one > missed the modification of function InitAuxiliaryProcess, please > check the new patch. After a quick check through the 14 tree, then compaing with the corresponding parts of 15, it hit me that ProcArrayClearTransaction() needs an assertion on the variable. Other than that, the patch looks good to me. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
