Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
"Daniel Verite" writes: > Also the use of "and/or" in the previous version conveys the fact > that operator class and ordering options are not mutually > exclusive. But when using "any of the following" in the new text, > doesn't it loose that meaning? Yeah; and/or is perfectly fine here and doesn't need to be improved on. There's a bigger problem though, which is that these bits are *also* missing any reference to opclass parameters. I fixed that and pushed it. regards, tom lane
Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
shihao zhong wrote:
> Thanks for your comments, a new version is attached.
In this hunk:
@@ -1097,8 +1097,8 @@ WITH ( MODULUS numeric_literal, REM
method index_method.
The operators are required to be commutative.
Each exclude_element
- can optionally specify an operator class and/or ordering options;
- these are described fully under
+ can optionally specify any of the following: a collation, a
+ operator class, or ordering options; these are described fully under
.
"a" should be "an" as it's followed by "operator class".
Also the use of "and/or" in the previous version conveys the fact
that operator class and ordering options are not mutually
exclusive. But when using "any of the following" in the new text,
doesn't it loose that meaning?
In case it does, I would suggest the attached diff.
Best regards,
--
Daniel Vérité
https://postgresql.verite.pro/
Twitter: @DanielVerite
diff --git a/doc/src/sgml/ref/alter_table.sgml
b/doc/src/sgml/ref/alter_table.sgml
index 2c4138e4e9..43f5f0873e 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -135,7 +135,7 @@ WITH ( MODULUS numeric_literal, REM
exclude_element in an
EXCLUDE constraint is:
-{ column_name | ( expression ) } [ opclass ] [ ASC | DESC ] [ NULLS { FIRST | LAST
} ]
+{ column_name | ( expression ) } [ COLLATE collation ] [ opclass ] [ ASC | DESC ] [ NULLS { FIRST | LAST
} ]
referential_action in a
FOREIGN KEY/REFERENCES constraint
is:
diff --git a/doc/src/sgml/ref/create_table.sgml
b/doc/src/sgml/ref/create_table.sgml
index e04a0692c4..277d292aac 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -105,7 +105,7 @@ WITH ( MODULUS numeric_literal, REM
exclude_element in an
EXCLUDE constraint is:
-{ column_name | ( expression ) } [ opclass ] [ ASC | DESC ] [ NULLS { FIRST | LAST
} ]
+{ column_name | ( expression ) } [ COLLATE collation ] [ opclass ] [ ASC | DESC ] [ NULLS { FIRST | LAST
} ]
referential_action in a
FOREIGN KEY/REFERENCES constraint
is:
@@ -1097,9 +1097,8 @@ WITH ( MODULUS numeric_literal, REM
method index_method.
The operators are required to be commutative.
Each exclude_element
- can optionally specify an operator class and/or ordering options;
- these are described fully under
- .
+ can optionally specify a collation, an operator class, and ordering
options;
+ these are described fully under .
Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
On Fri, Nov 17, 2023 at 4:55 AM shihao zhong wrote: > > Hi Jian, > > Thanks for your comments, a new version is attached. > > Thanks, > Shihao > > On Fri, Nov 10, 2023 at 9:59 AM jian he wrote: >> >> On Wed, Nov 1, 2023 at 10:30 AM shihao zhong wrote: >> > >> > Thank you for your feedback on my previous patch. I have fixed the issue >> > and attached a new patch for your review. Could you please take a look for >> > it if you have a sec? Thanks >> > >> >> Your patch works fine. you can see it here: >> https://cirrus-ci.com/task/6481922939944960 >> in an ideal world, since the doc is already built, we can probably >> view it as a plain html file just click the ci test result. >> >> in src/sgml/ref/create_table.sgml: >> "Each exclude_element can optionally specify an operator class and/or >> ordering options; these are described fully under CREATE INDEX." >> >> You may need to update this sentence to reflect that exclude_element >> can also optionally specify collation. I have reviewed the changes and it looks fine. Thanks and Regards, Shubham Khanna.
Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
Hi Jian, Thanks for your comments, a new version is attached. Thanks, Shihao On Fri, Nov 10, 2023 at 9:59 AM jian he wrote: > On Wed, Nov 1, 2023 at 10:30 AM shihao zhong > wrote: > > > > Thank you for your feedback on my previous patch. I have fixed the issue > and attached a new patch for your review. Could you please take a look for > it if you have a sec? Thanks > > > > Your patch works fine. you can see it here: > https://cirrus-ci.com/task/6481922939944960 > in an ideal world, since the doc is already built, we can probably > view it as a plain html file just click the ci test result. > > in src/sgml/ref/create_table.sgml: > "Each exclude_element can optionally specify an operator class and/or > ordering options; these are described fully under CREATE INDEX." > > You may need to update this sentence to reflect that exclude_element > can also optionally specify collation. > update_document_exclude_with_collate_v3.patch Description: Binary data
Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
On Wed, Nov 1, 2023 at 10:30 AM shihao zhong wrote: > > Thank you for your feedback on my previous patch. I have fixed the issue and > attached a new patch for your review. Could you please take a look for it if > you have a sec? Thanks > Your patch works fine. you can see it here: https://cirrus-ci.com/task/6481922939944960 in an ideal world, since the doc is already built, we can probably view it as a plain html file just click the ci test result. in src/sgml/ref/create_table.sgml: "Each exclude_element can optionally specify an operator class and/or ordering options; these are described fully under CREATE INDEX." You may need to update this sentence to reflect that exclude_element can also optionally specify collation.
Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
On Tue, Oct 31, 2023 at 9:07 PM Tom Lane wrote: > shihao zhong writes: > > I noticed that the CREATE/ALTER TABLE document does not mention that > > EXCLUDE can accept a collation. I created a documentation fix for this > > issue, and I have attached it to this email. > > > Hmm ... is this actually correct? I think that the collate > > option has to come before the opclass name etc, so you'd need > > to shove it into exclude_element to provide an accurate > > description of the syntax. > > > > regards, tom lane > Hi Tom, Thank you for your feedback on my previous patch. I have fixed the issue and attached a new patch for your review. Could you please take a look for it if you have a sec? Thanks Also, if I understand correctly, the changes to sql_help.c will be made by the committer, so I do not need to run create_help.pl in my patch. Can you please confirm? I appreciate your help and time. Thanks, Shihao update_document_exclude_with_collate_v2.patch Description: Binary data
Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
shihao zhong writes: > I noticed that the CREATE/ALTER TABLE document does not mention that > EXCLUDE can accept a collation. I created a documentation fix for this > issue, and I have attached it to this email. Hmm ... is this actually correct? I think that the collate option has to come before the opclass name etc, so you'd need to shove it into exclude_element to provide an accurate description of the syntax. regards, tom lane
EXCLUDE COLLATE in CREATE/ALTER TABLE document
Hi hackers, I hope this email finds you well. I noticed that the CREATE/ALTER TABLE document does not mention that EXCLUDE can accept a collation. I created a documentation fix for this issue, and I have attached it to this email. Please let me know if you have any questions or concerns. Thanks, Shihao update_document_exclude_with_collate.patch Description: Binary data
