Re: FW: [Todo item] Add entry creation timestamp column to pg_stat_replication

[Masahiko Sawada]

On Thu, Aug 2, 2018 at 6:34 PM MyungKyu LIM  wrote:
>
> I changed field name from 'reply_time' to 'last_msg_send_time'.
> Because 'last_msg_send_time' is used in 
> pg_stat_wal_receiver/pg_stat_subsctiption view.
> I think that field has the same meaning.

I got confused by the field name. If we have 'last_msg_send_time'
field in pg_stat_replciation which has information of wal senders
users would think it as a time when the wal sender sent a message last
time. However values of the fields actually shows a time when the wal
receiver sent a reply message last time. So perhaps
'last_reply_send_time' would be more clear.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

FW: [Todo item] Add entry creation timestamp column to pg_stat_replication

[MyungKyu LIM]

I changed field name from 'reply_time' to 'last_msg_send_time'.
Because 'last_msg_send_time' is used in 
pg_stat_wal_receiver/pg_stat_subsctiption view.
I think that field has the same meaning.

test example>
postgres=# select pid, last_msg_send_time from pg_stat_replication;
-[ RECORD 1 ]--+--
pid| 12015
last_msg_send_time | 2018-08-02 18:02:49.233049+09
-[ RECORD 2 ]--+--
pid| 12084
last_msg_send_time | 2018-08-02 18:02:48.583256+09

I Attached new patch file : 0001-Implement-following-TODO-list-item-v2.patch

Feedback and suggestion will be very welcome.
Thanks!
 
Best regards,
Myungkyu, Lim
 
- Original Message -
Date   : 2018-07-31 17:56 (GMT+9)
Title  : [Todo item] Add entry creation timestamp column to pg_stat_replication
 
Hello hackers,
 
I have worked on following todo list item.
 
  - Add entry creation timestamp column to pg_stat_replication
http://archives.postgresql.org/pgsql-hackers/2011-08/msg00694.php
 
This item looks like simple because necessary data was already exist.
So, I wrote a prototype patch.
 
test example>
postgres=# select pid, reply_time from pg_stat_replication;
-[ RECORD 1 ]-
pid| 4817
reply_time | 2018-07-31 12:00:53.911198+09
-[ RECORD 2 ]-
pid| 4819
reply_time | 2018-07-31 12:00:53.911154+09
 
 
Several candidates exist for the field name.
- reply_timestamp
- info_gen_timestamp
- stats_reset
- last_msg_send_time
 
Feedback and suggestion will be very welcome.
Thanks!
 
Best regards,
Myungkyu, Lim

0001-Implement-following-TODO-list-item-v1.patch
Description: Binary data


0001-Implement-following-TODO-list-item-v2.patch
Description: Binary data