Re: Incorrect grammar

[Etsuro Fujita]

(2018/02/23 0:09), Robert Haas wrote:

On Thu, Feb 22, 2018 at 6:54 AM, Etsuro Fujita
  wrote:

Here is a tiny patch to fix $SUBJECT in a comment in execPartition.c.


Committed.


Thanks!

Best regards,
Etsuro Fujita

Re: Incorrect grammar

[Robert Haas]

On Thu, Feb 22, 2018 at 6:54 AM, Etsuro Fujita
 wrote:
> Here is a tiny patch to fix $SUBJECT in a comment in execPartition.c.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Incorrect grammar

[Etsuro Fujita]

Here is a tiny patch to fix $SUBJECT in a comment in execPartition.c.

Best regards,
Etsuro Fujita
diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
index 4048c3e..882b538 100644
--- a/src/backend/executor/execPartition.c
+++ b/src/backend/executor/execPartition.c
@@ -140,10 +140,10 @@ ExecSetupPartitionTupleRouting(ModifyTableState *mtstate,
 partrel = leaf_part_rri->ri_RelationDesc;
 
 /*
- * This is required in order to we convert the partition's
- * tuple to be compatible with the root partitioned table's
- * tuple descriptor.  When generating the per-subplan result
- * rels, this was not set.
+ * This is required in order to convert the partition's tuple
+ * to be compatible with the root partitioned table's tuple
+ * descriptor.  When generating the per-subplan result rels,
+ * this was not set.
  */
 leaf_part_rri->ri_PartitionRoot = rel;
 

Re: Incorrect grammar

[Etsuro Fujita]

(2018/02/07 5:51), Robert Haas wrote:

On Tue, Feb 6, 2018 at 5:22 AM, Etsuro Fujita
  wrote:

While reviewing the
lazy-initialization-of-partition-info-for-tuple-routing patch, I ran
into a grammar mistake in a comment in ExecSetupChildParentMapForLeaf.
Attached is a patch for fixing that.


Committed.


Thank you.

Best regards,
Etsuro Fujita

Re: Incorrect grammar

[Robert Haas]

On Tue, Feb 6, 2018 at 5:22 AM, Etsuro Fujita
 wrote:
> While reviewing the
> lazy-initialization-of-partition-info-for-tuple-routing patch, I ran
> into a grammar mistake in a comment in ExecSetupChildParentMapForLeaf.
> Attached is a patch for fixing that.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Incorrect grammar

[Etsuro Fujita]

Hi,

While reviewing the
lazy-initialization-of-partition-info-for-tuple-routing patch, I ran
into a grammar mistake in a comment in ExecSetupChildParentMapForLeaf.
Attached is a patch for fixing that.

Best regards,
Etsuro Fujita
diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
index 106a96d..ba6b52c 100644
--- a/src/backend/executor/execPartition.c
+++ b/src/backend/executor/execPartition.c
@@ -360,7 +360,7 @@ ExecSetupChildParentMapForLeaf(PartitionTupleRouting *proute)
 	Assert(proute != NULL);
 
 	/*
-	 * These array elements gets filled up with maps on an on-demand basis.
+	 * These array elements get filled up with maps on an on-demand basis.
 	 * Initially just set all of them to NULL.
 	 */
 	proute->child_parent_tupconv_maps =