Re: Minor fix in reloptions.c comments
On Fri, Apr 12, 2019 at 12:01 AM Michael Paquier wrote: > On Fri, Apr 12, 2019 at 02:41:37AM +, Jamison, Kirk wrote: > > I found some minor grammar mistake while reading reloptions.c code comments. > > Attached is the fix. > > I just changed "affect" to "effect", for both n_distinct and > > vacuum_truncate. > > - * values has no affect until the ... > > + * values has no effect until the ... > > A lot of those parameter updates affect processing and still they have > many side effects, as per those paragraphs. Well, "has no affect" is clearly wrong here, and Kirk's fix is clearly right. I don't know what your point here is. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: Minor fix in reloptions.c comments
On Fri, Apr 12, 2019 at 02:41:37AM +, Jamison, Kirk wrote: > I found some minor grammar mistake while reading reloptions.c code comments. > Attached is the fix. > I just changed "affect" to "effect", for both n_distinct and vacuum_truncate. > - * values has no affect until the ... > + * values has no effect until the ... A lot of those parameter updates affect processing and still they have many side effects, as per those paragraphs. Fixed, thanks! -- Michael signature.asc Description: PGP signature
Minor fix in reloptions.c comments
Hi, I found some minor grammar mistake while reading reloptions.c code comments. Attached is the fix. I just changed "affect" to "effect", for both n_distinct and vacuum_truncate. - * values has no affect until the ... + * values has no effect until the ... Regards, Kirk Jamison reloptions-comment-fix.patch Description: reloptions-comment-fix.patch
