Re: Outdated comment for CreateStmt.inhRelations

2021-03-30 Thread Julien Rouhaud
On Wed, Mar 31, 2021 at 09:36:51AM +0900, Michael Paquier wrote:
> On Tue, Mar 30, 2021 at 08:30:15PM +0800, Julien Rouhaud wrote:
> > I just noticed that the comment for CreateStmt.inhRelations says that it's a
> > List of inhRelation, which hasn't been the case for a very long time.
> 
> Thanks, applied.

Thanks!




Re: Outdated comment for CreateStmt.inhRelations

2021-03-30 Thread Michael Paquier
On Tue, Mar 30, 2021 at 08:30:15PM +0800, Julien Rouhaud wrote:
> I just noticed that the comment for CreateStmt.inhRelations says that it's a
> List of inhRelation, which hasn't been the case for a very long time.

Thanks, applied.
--
Michael


signature.asc
Description: PGP signature


Outdated comment for CreateStmt.inhRelations

2021-03-30 Thread Julien Rouhaud
Hi,

I just noticed that the comment for CreateStmt.inhRelations says that it's a
List of inhRelation, which hasn't been the case for a very long time.

Trivial patch attached.
diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h
index 12e0e026dc..334262b1dd 100644
--- a/src/include/nodes/parsenodes.h
+++ b/src/include/nodes/parsenodes.h
@@ -2131,7 +2131,7 @@ typedef struct CreateStmt
RangeVar   *relation;   /* relation to create */
List   *tableElts;  /* column definitions (list of 
ColumnDef) */
List   *inhRelations;   /* relations to inherit from (list of
-* inhRelation) 
*/
+* RangeVar) */
PartitionBoundSpec *partbound;  /* FOR VALUES clause */
PartitionSpec *partspec;/* PARTITION BY clause */
TypeName   *ofTypename; /* OF typename */