Re: [PATCH] remove repetitive characters in fdwhandler.sgml
On 2019-03-12 23:19:23 -0700, Andres Freund wrote: > On 2019-03-13 14:55:59 +0900, Etsuro Fujita wrote: > > (2019/03/13 14:02), Michael Paquier wrote: > > > On Tue, Mar 12, 2019 at 01:37:04AM +, Zhang, Jie wrote: > > > > Here is a tiny patch removing repetitive characters [if] in > > > > fdwhandler.sgml. > > > > > > > > > - This function should store the tuple into the provided, or clear it > > > if if > > > + This function should store the tuple into the provided, or clear it > > > if > > >the row lock couldn't be obtained. The row lock type to acquire is > > > > > > The typo is clear, however the formulation of the full sentence is > > > confusing. This function should store the tuple into the provided > > > slot, no? > > > > Yeah, I think so too. > > Sorry for that, I'll fix the sentence tomorrow. Andres vs Grammar: 3 : > 3305. And pushed. Thanks for the report!
RE: [PATCH] remove repetitive characters in fdwhandler.sgml
> This function should store the tuple into the provided slot, no? Yes, this modification is easier to understand. -Original Message- From: Michael Paquier [mailto:mich...@paquier.xyz] Sent: Wednesday, March 13, 2019 1:02 PM To: Zhang, Jie/张 杰 Cc: pgsql-hack...@postgresql.org Subject: Re: [PATCH] remove repetitive characters in fdwhandler.sgml On Tue, Mar 12, 2019 at 01:37:04AM +, Zhang, Jie wrote: > Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml. - This function should store the tuple into the provided, or clear it if if + This function should store the tuple into the provided, or clear + it if the row lock couldn't be obtained. The row lock type to acquire is The typo is clear, however the formulation of the full sentence is confusing. This function should store the tuple into the provided slot, no? -- Michael
Re: [PATCH] remove repetitive characters in fdwhandler.sgml
On 2019-03-13 14:55:59 +0900, Etsuro Fujita wrote: > (2019/03/13 14:02), Michael Paquier wrote: > > On Tue, Mar 12, 2019 at 01:37:04AM +, Zhang, Jie wrote: > > > Here is a tiny patch removing repetitive characters [if] in > > > fdwhandler.sgml. > > > > > > - This function should store the tuple into the provided, or clear it > > if if > > + This function should store the tuple into the provided, or clear it if > >the row lock couldn't be obtained. The row lock type to acquire is > > > > The typo is clear, however the formulation of the full sentence is > > confusing. This function should store the tuple into the provided > > slot, no? > > Yeah, I think so too. Sorry for that, I'll fix the sentence tomorrow. Andres vs Grammar: 3 : 3305. Greetings, Andres Freund
Re: [PATCH] remove repetitive characters in fdwhandler.sgml
(2019/03/13 14:02), Michael Paquier wrote: On Tue, Mar 12, 2019 at 01:37:04AM +, Zhang, Jie wrote: Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml. - This function should store the tuple into the provided, or clear it if if + This function should store the tuple into the provided, or clear it if the row lock couldn't be obtained. The row lock type to acquire is The typo is clear, however the formulation of the full sentence is confusing. This function should store the tuple into the provided slot, no? Yeah, I think so too. Best regards, Etsuro Fujita
Re: [PATCH] remove repetitive characters in fdwhandler.sgml
On Tue, Mar 12, 2019 at 01:37:04AM +, Zhang, Jie wrote: > Here is a tiny patch removing repetitive characters [if] in fdwhandler.sgml. - This function should store the tuple into the provided, or clear it if if + This function should store the tuple into the provided, or clear it if the row lock couldn't be obtained. The row lock type to acquire is The typo is clear, however the formulation of the full sentence is confusing. This function should store the tuple into the provided slot, no? -- Michael signature.asc Description: PGP signature
