Re: Inconsistencies in error messages

2022-09-15 Thread John Naylor
On Wed, Sep 14, 2022 at 5:25 PM John Naylor
 wrote:
> Will commit this way unless there are objections.

I forgot to mention yesterday, but this is done.

-- 
John Naylor
EDB: http://www.enterprisedb.com




Re: Inconsistencies in error messages

2022-09-14 Thread Alvaro Herrera
On 2022-Sep-14, John Naylor wrote:

> This one
> 
> + errmsg("background worker \"%s\": background workers without shared
> memory access are not supported",
> 
> is a grammar error so worth backpatching, but the rest are cosmetic.
> 
> Will commit this way unless there are objections.

+1

-- 
Álvaro Herrera PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"I dream about dreams about dreams", sang the nightingale
under the pale moon (Sandman)




Re: Inconsistencies in error messages

2022-09-14 Thread John Naylor
On Wed, Sep 14, 2022 at 5:01 PM Ekaterina Kiryanova
 wrote:
>
> Hi,
>
> When translating error messages, Alexander Lakhin
> () noticed some inconsistencies so I prepared a
> small patch to fix those.

+1

This one

- errmsg("background worker \"%s\": background worker without shared
memory access are not supported",
+ errmsg("background worker \"%s\": background workers without shared
memory access are not supported",

is a grammar error so worth backpatching, but the rest are cosmetic.

Will commit this way unless there are objections.

-- 
John Naylor
EDB: http://www.enterprisedb.com