Re: Release notes wording about logical replication as table owner

2023-09-06 Thread Bruce Momjian
On Wed, Sep  6, 2023 at 09:29:25PM +0200, Magnus Hagander wrote:
> We have:
> 
> "This improves security and now requires subscription owners to be
> either superusers or to have SET ROLE permissions on all tables in the
> replication set. The previous behavior of performing all operations as
> the subscription owner can be enabled with the subscription
> run_as_owner option."
> 
> How does one have SET ROLE permissions on a table? I think that's
> supposed to be:
> 
> "subscription owners be either superusers or to have SET ROLE
> permissions on all roles owning tables in the replication set."
> 
> Or something like that? Or can someone suggest a better wording?

You are exactly corrected.  Patch attached and applied.

-- 
  Bruce Momjian  https://momjian.us
  EDB  https://enterprisedb.com

  Only you can decide what is important to you.
diff --git a/doc/src/sgml/release-16.sgml b/doc/src/sgml/release-16.sgml
index 0fa0d25fe1..5f174e99f6 100644
--- a/doc/src/sgml/release-16.sgml
+++ b/doc/src/sgml/release-16.sgml
@@ -1818,7 +1818,7 @@ Author: Robert Haas 
This improves security and now requires subscription
owners to be either superusers or to have SET ROLE
-   permissions on all tables in the replication set.
+   permission on all roles owning tables in the replication set.
The previous behavior of performing all operations as the
subscription owner can be enabled with the subscription run_as_owner


Release notes wording about logical replication as table owner

2023-09-06 Thread Magnus Hagander
We have:

"This improves security and now requires subscription owners to be
either superusers or to have SET ROLE permissions on all tables in the
replication set. The previous behavior of performing all operations as
the subscription owner can be enabled with the subscription
run_as_owner option."

How does one have SET ROLE permissions on a table? I think that's
supposed to be:

"subscription owners be either superusers or to have SET ROLE
permissions on all roles owning tables in the replication set."

Or something like that? Or can someone suggest a better wording?

//Magnus