Re: Unused struct member in pgcrypto pgp.c
On Tue, Jul 30, 2019 at 9:19 PM Daniel Gustafsson wrote: > > Hi, > > In contrib/pgcrypto/pgp.c we have a struct member int_name in digest_info > which > isn’t used, and seems to have never been used (a potential copy/pasteo from > the > cipher_info struct?). Is there a reason for keeping this, or can it be > removed > as per the attached? > Agreed. It seems the member is not being used anywhere, only code and name members are being used in digest lookup. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
Re: Unused struct member in pgcrypto pgp.c
On Tue, Jul 30, 2019 at 05:48:49PM +0200, Daniel Gustafsson wrote: > In contrib/pgcrypto/pgp.c we have a struct member int_name in digest_info > which > isn’t used, and seems to have never been used (a potential copy/pasteo from > the > cipher_info struct?). Is there a reason for keeping this, or can it be > removed > as per the attached? I don't see one as this is not used in any logic for the digest lookups. So agreed and applied. This originally comes from e94dd6a. -- Michael signature.asc Description: PGP signature
Unused struct member in pgcrypto pgp.c
Hi, In contrib/pgcrypto/pgp.c we have a struct member int_name in digest_info which isn’t used, and seems to have never been used (a potential copy/pasteo from the cipher_info struct?). Is there a reason for keeping this, or can it be removed as per the attached? cheers ./daniel pgcrypto_int_name.diff Description: Binary data
