Re: doc fix for pg_stat_activity.backend_type
On 11/15/18, Amit Kapila wrote: > Pushed, thanks for working on this. Thanks for your input. -John Naylor
Re: doc fix for pg_stat_activity.backend_type
On Tue, Nov 13, 2018 at 5:03 PM Amit Kapila wrote: > > On Tue, Nov 13, 2018 at 3:37 PM John Naylor wrote: > > > + In addition, extensions may have additional types. > > > > > > How about: "In addition, background workers registered by extensions > > > may have additional types."? > > > > Sounds good to me -- I've included this language. > > > > LGTM. I will wait for a day or so, if nobody has any comments, I will > push your patch. > Pushed, thanks for working on this. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Re: doc fix for pg_stat_activity.backend_type
On 11/13/18, Amit Kapila wrote: > On Tue, Nov 13, 2018 at 3:37 PM John Naylor wrote: >> >> On 11/13/18, Amit Kapila wrote: >> > >> > Don't you need to remove background worker? >> >> It's handled in pgstat_get_backend_desc(), so I assumed not. If that's >> just a place holder, then it's probably better left out, as in the >> attached. >> > > I don't think 'background worker' can be displayed as backend_type. I think you're right (pgstatfuncs.c, starting at line 826). -John Naylor
Re: doc fix for pg_stat_activity.backend_type
On Tue, Nov 13, 2018 at 3:37 PM John Naylor wrote: > > On 11/13/18, Amit Kapila wrote: > > > > Don't you need to remove background worker? > > It's handled in pgstat_get_backend_desc(), so I assumed not. If that's > just a place holder, then it's probably better left out, as in the > attached. > I don't think 'background worker' can be displayed as backend_type. Do you see any way it can be displayed as backend_type? > > + In addition, extensions may have additional types. > > > > How about: "In addition, background workers registered by extensions > > may have additional types."? > > Sounds good to me -- I've included this language. > LGTM. I will wait for a day or so, if nobody has any comments, I will push your patch. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Re: doc fix for pg_stat_activity.backend_type
On 11/13/18, Amit Kapila wrote: > On Tue, Nov 13, 2018 at 12:04 PM John Naylor wrote: >> >> On 11/13/18, Amit Kapila wrote: >> > On Tue, Nov 13, 2018 at 5:38 AM Michael Paquier >> > wrote: >> >> >> >> On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: >> >> > Looks like it. A quick search revealed "parallel worker" and >> >> > "logical >> >> > replication worker". src/test/modules/ also show "test_shm_mq" and >> >> > "worker_spi", but it seems those don't need to be publicly >> >> > documented. >> >> > If that sounds right I'll update the patch to include the first two. >> >> >> >> Just wondering: do we actually need to include in the docs this list >> >> at >> >> all? This is a recipe to forget its update each time a new backend >> >> type >> >> is added. >> >> >> > >> > Sure, but how will we justify documenting (autovacuum launcher and >> > autovacuum worker) and not (logical replication launcher and logical >> > replication worker)? I think we can document the type of workers that >> > are part of core-server functionality. We can make some generic >> > statement on the workers that can be launched by extensions. >> >> How about something like the attached? >> > > Don't you need to remove background worker? It's handled in pgstat_get_backend_desc(), so I assumed not. If that's just a place holder, then it's probably better left out, as in the attached. > + In addition, extensions may have additional types. > > How about: "In addition, background workers registered by extensions > may have additional types."? Sounds good to me -- I've included this language. -John Naylor diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index add71458e2..9600ef0d64 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -804,10 +804,13 @@ postgres 27093 0.0 0.0 30096 2752 ?Ss 11:34 0:00 postgres: ser text Type of current backend. Possible types are autovacuum launcher, autovacuum worker, - background worker, background writer, + logical replication launcher, + logical replication worker, + parallel worker, background writer, client backend, checkpointer, startup, walreceiver, walsender and walwriter. + In addition, background workers registered by extensions may have additional types.
Re: doc fix for pg_stat_activity.backend_type
On Tue, Nov 13, 2018 at 12:04 PM John Naylor wrote: > > On 11/13/18, Amit Kapila wrote: > > On Tue, Nov 13, 2018 at 5:38 AM Michael Paquier > > wrote: > >> > >> On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: > >> > Looks like it. A quick search revealed "parallel worker" and "logical > >> > replication worker". src/test/modules/ also show "test_shm_mq" and > >> > "worker_spi", but it seems those don't need to be publicly documented. > >> > If that sounds right I'll update the patch to include the first two. > >> > >> Just wondering: do we actually need to include in the docs this list at > >> all? This is a recipe to forget its update each time a new backend type > >> is added. > >> > > > > Sure, but how will we justify documenting (autovacuum launcher and > > autovacuum worker) and not (logical replication launcher and logical > > replication worker)? I think we can document the type of workers that > > are part of core-server functionality. We can make some generic > > statement on the workers that can be launched by extensions. > > How about something like the attached? > Don't you need to remove background worker? + In addition, extensions may have additional types. How about: "In addition, background workers registered by extensions may have additional types."? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Re: doc fix for pg_stat_activity.backend_type
On 11/13/18, Amit Kapila wrote: > On Tue, Nov 13, 2018 at 5:38 AM Michael Paquier > wrote: >> >> On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: >> > Looks like it. A quick search revealed "parallel worker" and "logical >> > replication worker". src/test/modules/ also show "test_shm_mq" and >> > "worker_spi", but it seems those don't need to be publicly documented. >> > If that sounds right I'll update the patch to include the first two. >> >> Just wondering: do we actually need to include in the docs this list at >> all? This is a recipe to forget its update each time a new backend type >> is added. >> > > Sure, but how will we justify documenting (autovacuum launcher and > autovacuum worker) and not (logical replication launcher and logical > replication worker)? I think we can document the type of workers that > are part of core-server functionality. We can make some generic > statement on the workers that can be launched by extensions. How about something like the attached? -John Naylor diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index add71458e2..886477cf09 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -804,10 +804,13 @@ postgres 27093 0.0 0.0 30096 2752 ?Ss 11:34 0:00 postgres: ser text Type of current backend. Possible types are autovacuum launcher, autovacuum worker, + logical replication launcher, + logical replication worker, parallel worker, background worker, background writer, client backend, checkpointer, startup, walreceiver, walsender and walwriter. + In addition, extensions may have additional types.
Re: doc fix for pg_stat_activity.backend_type
On Tue, Nov 13, 2018 at 5:38 AM Michael Paquier wrote: > > On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: > > Looks like it. A quick search revealed "parallel worker" and "logical > > replication worker". src/test/modules/ also show "test_shm_mq" and > > "worker_spi", but it seems those don't need to be publicly documented. > > If that sounds right I'll update the patch to include the first two. > > Just wondering: do we actually need to include in the docs this list at > all? This is a recipe to forget its update each time a new backend type > is added. > Sure, but how will we justify documenting (autovacuum launcher and autovacuum worker) and not (logical replication launcher and logical replication worker)? I think we can document the type of workers that are part of core-server functionality. We can make some generic statement on the workers that can be launched by extensions. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Re: doc fix for pg_stat_activity.backend_type
On Mon, Nov 12, 2018 at 09:42:45PM +0700, John Naylor wrote: > Looks like it. A quick search revealed "parallel worker" and "logical > replication worker". src/test/modules/ also show "test_shm_mq" and > "worker_spi", but it seems those don't need to be publicly documented. > If that sounds right I'll update the patch to include the first two. Just wondering: do we actually need to include in the docs this list at all? This is a recipe to forget its update each time a new backend type is added. -- Michael signature.asc Description: PGP signature
Re: doc fix for pg_stat_activity.backend_type
On 11/12/18, Amit Kapila wrote: > On Mon, Nov 12, 2018 at 1:20 PM John Naylor wrote: >> >> Hi all, >> >> Commit fc70a4b0df3 added backend_type to pg_stat_activity, but the >> documentation omitted "logical replication launcher". Patch attached. >> > > Isn't this the fallout of commit 5373bc2a08 which has added background > worker types? If so, I guess your patch needs modification. Looks like it. A quick search revealed "parallel worker" and "logical replication worker". src/test/modules/ also show "test_shm_mq" and "worker_spi", but it seems those don't need to be publicly documented. If that sounds right I'll update the patch to include the first two. -John Naylor
Re: doc fix for pg_stat_activity.backend_type
On Mon, Nov 12, 2018 at 1:20 PM John Naylor wrote: > > Hi all, > > Commit fc70a4b0df3 added backend_type to pg_stat_activity, but the > documentation omitted "logical replication launcher". Patch attached. > Isn't this the fallout of commit 5373bc2a08 which has added background worker types? If so, I guess your patch needs modification. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
doc fix for pg_stat_activity.backend_type
Hi all, Commit fc70a4b0df3 added backend_type to pg_stat_activity, but the documentation omitted "logical replication launcher". Patch attached. -John Naylor diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index add71458e2..ddf607bb17 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -807,7 +807,8 @@ postgres 27093 0.0 0.0 30096 2752 ?Ss 11:34 0:00 postgres: ser background worker, background writer, client backend, checkpointer, startup, walreceiver, - walsender and walwriter. + walsender, walwriter + and logical replication launcher.
