Re: psql tab completion for \h with IMPORT FOREIGN SCHEMA
On Thu, Mar 18, 2021 at 07:45:36AM +, gkokola...@pm.me wrote: > It seems helpful. Thank you. Thanks, applied then. -- Michael signature.asc Description: PGP signature
Re: psql tab completion for \h with IMPORT FOREIGN SCHEMA
‐‐‐ Original Message ‐‐‐ On Thursday, March 18, 2021 8:13 AM, Julien Rouhaud wrote: > On Thu, Mar 18, 2021 at 03:58:46PM +0900, Michael Paquier wrote: > > > Well, as $subject tells, I just found confusing that \h does not > > complete the so-said command, the only one using IMPORT as keyword, > > so I'd like to do the following: > > --- a/src/bin/psql/tab-complete.c > > +++ b/src/bin/psql/tab-complete.c > > @@ -1493,7 +1493,7 @@ psql_completion(const char *text, int start, int end) > > "ABORT", "ALTER", "ANALYZE", "BEGIN", "CALL", "CHECKPOINT", "CLOSE", > > "CLUSTER", > > "COMMENT", "COMMIT", "COPY", "CREATE", "DEALLOCATE", "DECLARE", > > "DELETE FROM", "DISCARD", "DO", "DROP", "END", "EXECUTE", "EXPLAIN", > > > > - "FETCH", "GRANT", "IMPORT", "INSERT", "LISTEN", "LOAD", "LOCK", > > > > > > > > - "FETCH", "GRANT", "IMPORT FOREIGN SCHEMA", "INSERT", "LISTEN", > > "LOAD", "LOCK", > >"MOVE", "NOTIFY", "PREPARE", > >"REASSIGN", "REFRESH MATERIALIZED VIEW", "REINDEX", "RELEASE", > >"RESET", "REVOKE", "ROLLBACK", > > > > > > Looks sensible to me. It seems helpful. Thank you.
Re: psql tab completion for \h with IMPORT FOREIGN SCHEMA
On Thu, Mar 18, 2021 at 03:58:46PM +0900, Michael Paquier wrote: > > Well, as $subject tells, I just found confusing that \h does not > complete the so-said command, the only one using IMPORT as keyword, > so I'd like to do the following: > --- a/src/bin/psql/tab-complete.c > +++ b/src/bin/psql/tab-complete.c > @@ -1493,7 +1493,7 @@ psql_completion(const char *text, int start, int end) > "ABORT", "ALTER", "ANALYZE", "BEGIN", "CALL", "CHECKPOINT", "CLOSE", > "CLUSTER", > "COMMENT", "COMMIT", "COPY", "CREATE", "DEALLOCATE", "DECLARE", > "DELETE FROM", "DISCARD", "DO", "DROP", "END", "EXECUTE", "EXPLAIN", > -"FETCH", "GRANT", "IMPORT", "INSERT", "LISTEN", "LOAD", "LOCK", > +"FETCH", "GRANT", "IMPORT FOREIGN SCHEMA", "INSERT", "LISTEN", > "LOAD", "LOCK", > "MOVE", "NOTIFY", "PREPARE", > "REASSIGN", "REFRESH MATERIALIZED VIEW", "REINDEX", "RELEASE", > "RESET", "REVOKE", "ROLLBACK", Looks sensible to me.
psql tab completion for \h with IMPORT FOREIGN SCHEMA
Hi all, Well, as $subject tells, I just found confusing that \h does not complete the so-said command, the only one using IMPORT as keyword, so I'd like to do the following: --- a/src/bin/psql/tab-complete.c +++ b/src/bin/psql/tab-complete.c @@ -1493,7 +1493,7 @@ psql_completion(const char *text, int start, int end) "ABORT", "ALTER", "ANALYZE", "BEGIN", "CALL", "CHECKPOINT", "CLOSE", "CLUSTER", "COMMENT", "COMMIT", "COPY", "CREATE", "DEALLOCATE", "DECLARE", "DELETE FROM", "DISCARD", "DO", "DROP", "END", "EXECUTE", "EXPLAIN", -"FETCH", "GRANT", "IMPORT", "INSERT", "LISTEN", "LOAD", "LOCK", +"FETCH", "GRANT", "IMPORT FOREIGN SCHEMA", "INSERT", "LISTEN", "LOAD", "LOCK", "MOVE", "NOTIFY", "PREPARE", "REASSIGN", "REFRESH MATERIALIZED VIEW", "REINDEX", "RELEASE", "RESET", "REVOKE", "ROLLBACK", That's not the patch of the year. Thanks, -- Michael diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index ecdb8d752b..a9743f5c63 100644 --- a/src/bin/psql/tab-complete.c +++ b/src/bin/psql/tab-complete.c @@ -1493,7 +1493,7 @@ psql_completion(const char *text, int start, int end) "ABORT", "ALTER", "ANALYZE", "BEGIN", "CALL", "CHECKPOINT", "CLOSE", "CLUSTER", "COMMENT", "COMMIT", "COPY", "CREATE", "DEALLOCATE", "DECLARE", "DELETE FROM", "DISCARD", "DO", "DROP", "END", "EXECUTE", "EXPLAIN", - "FETCH", "GRANT", "IMPORT", "INSERT", "LISTEN", "LOAD", "LOCK", + "FETCH", "GRANT", "IMPORT FOREIGN SCHEMA", "INSERT", "LISTEN", "LOAD", "LOCK", "MOVE", "NOTIFY", "PREPARE", "REASSIGN", "REFRESH MATERIALIZED VIEW", "REINDEX", "RELEASE", "RESET", "REVOKE", "ROLLBACK", signature.asc Description: PGP signature
