Re: remove deprecated @@@ operator ?
On Thu, Nov 9, 2023 at 06:40:55PM -0500, Bruce Momjian wrote: > On Sun, Oct 21, 2018 at 04:24:16PM -0400, Tom Lane wrote: > > Oleg Bartunov writes: > > > The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years > > > old, may be we could remove deprecated @@@ operator ? > > > > Is it actually causing any problem? AFAICS it's just a couple extra > > pg_operator entries, so why not leave it? > > > > I'd be +1 for removing it from the docs, though ... > > Done in the attached patch. Patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.
Re: remove deprecated @@@ operator ?
On Sun, Oct 21, 2018 at 04:24:16PM -0400, Tom Lane wrote: > Oleg Bartunov writes: > > The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years > > old, may be we could remove deprecated @@@ operator ? > > Is it actually causing any problem? AFAICS it's just a couple extra > pg_operator entries, so why not leave it? > > I'd be +1 for removing it from the docs, though ... Done in the attached patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index d963f0a0a0..e39c815532 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -13124,24 +13124,6 @@ CREATE TYPE rainbow AS ENUM ('red', 'orange', 'yellow', 'green', 'blue', 'purple - - -tsvector @@@ tsquery -boolean - - -tsquery @@@ tsvector -boolean - - -This is a deprecated synonym for @@. - - -to_tsvector('fat cats ate rats') @@@ to_tsquery('cat rat') -t - - - tsvector || tsvector diff --git a/doc/src/sgml/gin.sgml b/doc/src/sgml/gin.sgml index d68d12d515..be02966e77 100644 --- a/doc/src/sgml/gin.sgml +++ b/doc/src/sgml/gin.sgml @@ -129,9 +129,6 @@ tsvector_ops @@ (tsvector,tsquery) - - @@@ (tsvector,tsquery) -
Re: remove deprecated @@@ operator ?
On Sun, Oct 21, 2018 at 11:24 PM Tom Lane wrote: > > Oleg Bartunov writes: > > The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years > > old, may be we could remove deprecated @@@ operator ? > > Is it actually causing any problem? AFAICS it's just a couple extra > pg_operator entries, so why not leave it? > > I'd be +1 for removing it from the docs, though ... attached a tiny patch for docs > > regards, tom lane -- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company func.sgml.patch Description: Binary data
Re: remove deprecated @@@ operator ?
Oleg Bartunov writes: > The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years > old, may be we could remove deprecated @@@ operator ? Is it actually causing any problem? AFAICS it's just a couple extra pg_operator entries, so why not leave it? I'd be +1 for removing it from the docs, though ... regards, tom lane
remove deprecated @@@ operator ?
Hello, The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years old, may be we could remove deprecated @@@ operator ? Author: Tom Lane Date: Mon Apr 14 17:05:34 2008 + Push index operator lossiness determination down to GIST/GIN opclass "consistent" functions, and remove pg_amop.opreqcheck, as per recent discussion. The main immediate benefit of this is that we no longer need 8.3's ugly hack of requiring @@@ rather than @@ to test weight-using tsquery searches on GIN indexes. In future it should be possible to optimize some other queries better than is done now, by detecting at runtime whether the index match is exact or not. Tom Lane, after an idea of Heikki's, and with some help from Teodor. Best Regards, Oleg -- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company