Re: [HACKERS] psql should show disabled internal triggers

[fabriziomello]

On 2013-09-18 15:15:55 +0200, Bernd Helmle wrote: 
 On 2013-09-18 15:15:55 +0200, Bernd Helmle wrote:
  --On 18. September 2013 13:52:29 +0200 Andres Freund
  lt;andres@gt; wrote:
  
  If you do ALTER TABLE ... DISABLE TRIGGER ALL; and then individually
  re-enable the disabled triggers it's easy to miss internal triggers.
  A \d+ tablename will not show anything out of the ordinary for that
  situation since we don't show internal triggers. But foreign key checks
  won't work.
  So, how about displaying disabled internal triggers in psql?
  
  Hi had exactly the same concerns this morning while starting to look at
 the
  ENABLE/DISABLE constraint patch. However, i wouldn't display them as
  triggers, but maybe more generally as disabled constraints or such.
 
 Well, that will lead the user in the wrong direction, won't it? They
 haven't disabled the constraint but the trigger. Especially as we
 already have NOT VALID and might grow DISABLED for constraint
 themselves...
 

Hi,

The attached patch [1] enable PSQL to list internal disabled triggers in \d
only in 
versions = 9.0.

[1]  psql-display-all-triggers-v1.patch
http://postgresql.1045698.n5.nabble.com/file/n5775954/psql-display-all-triggers-v1.patch
  

Regards,

-- 
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
 Timbira: http://www.timbira.com.br
 Blog sobre TI: http://fabriziomello.blogspot.com
 Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
 Twitter: http://twitter.com/fabriziomello



-
-- 
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
 Blog sobre TI: http://fabriziomello.blogspot.com
 Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
 Twitter: http://twitter.com/fabriziomello
--
View this message in context: 
http://postgresql.1045698.n5.nabble.com/psql-should-show-disabled-internal-triggers-tp5771406p5775954.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

[fabriziomello]

 New submission which put long options in alphabetical order, which seems 
 more logical.

 This is for reference to the next commitfest.

When I applied your patch appeared the following messages:

$ patch -p1  /tmp/pgbench-longopts.patch 
patching file contrib/pgbench/pgbench.c
Hunk #1 succeeded at 2109 (offset 29 lines).
patching file doc/src/sgml/pgbench.sgml
Hunk #2 succeeded at 172 (offset 12 lines).
Hunk #3 FAILED at 170.
Hunk #4 succeeded at 193 (offset 11 lines).
Hunk #5 FAILED at 199.
Hunk #13 succeeded at 344 (offset -33 lines).
Hunk #14 succeeded at 367 (offset -33 lines).
Hunk #15 succeeded at 382 (offset -33 lines).
Hunk #16 succeeded at 395 (offset -33 lines).
Hunk #17 succeeded at 407 (offset -33 lines).
Hunk #18 succeeded at 422 (offset -33 lines).
Hunk #19 succeeded at 432 (offset -33 lines).
Hunk #20 succeeded at 442 (offset -33 lines).
Hunk #21 succeeded at 454 (offset -33 lines).
2 out of 24 hunks FAILED -- saving rejects to file
doc/src/sgml/pgbench.sgml.rej

Please fix that and re-send the patch.

Regards,




-
-- 
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
 Blog sobre TI: http://fabriziomello.blogspot.com
 Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
 Twitter: http://twitter.com/fabriziomello
--
View this message in context: 
http://postgresql.1045698.n5.nabble.com/PATCH-add-long-options-to-pgbench-submission-1-tp5754115p5760039.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers