Re: [HACKERS] [COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-08 Thread Simon Riggs 
On 7 September 2016 at 14:58, Tom Lane  wrote:

>> That may not be perceived as a "fix" by everybody, so we should not do
>> it without an explicit agreement by many.
>
> Agreed, but I vote with Fujii-san for back-patching.

No problem with backpatching, just wanted some +1s before I did it.

Will do that tomorrow.

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-07 Thread Tom Lane 
Simon Riggs  writes:
> On 7 September 2016 at 13:47, Fujii Masao  wrote:
>> On Tue, Sep 6, 2016 at 11:41 PM, Simon Riggs  wrote:
>>> lazy_truncate_heap() was waiting for
>>> VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
>>> not milliseconds as originally intended.

>> Don't we need to back-patch this?

> If we do then a database-wide VACUUM on a busy database will take
> substantially longer than it does now.

On the other hand, it's also more likely to successfully perform desired
truncations.

> That may not be perceived as a "fix" by everybody, so we should not do
> it without an explicit agreement by many.

Agreed, but I vote with Fujii-san for back-patching.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-07 Thread Simon Riggs 
On 7 September 2016 at 13:47, Fujii Masao  wrote:
> On Tue, Sep 6, 2016 at 11:41 PM, Simon Riggs  wrote:
>> Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL
>>
>> lazy_truncate_heap() was waiting for
>> VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
>> not milliseconds as originally intended.
>
> Don't we need to back-patch this?

If we do then a database-wide VACUUM on a busy database will take
substantially longer than it does now.

That may not be perceived as a "fix" by everybody, so we should not do
it without an explicit agreement by many.

Thoughts?

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-07 Thread Fujii Masao 
On Tue, Sep 6, 2016 at 11:41 PM, Simon Riggs  wrote:
> Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL
>
> lazy_truncate_heap() was waiting for
> VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
> not milliseconds as originally intended.

Don't we need to back-patch this?

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers