Patch applied. Thanks.
---
Dave Page wrote:
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Bruce Momjian
Sent: 27 November 2004 04:33
To: [EMAIL PROTECTED]
Cc: PostgreSQL Win32 port list; PostgreSQL-development
Subject: Re: [pgsql-hackers-win32] [BUGS] pg_autovacuum in
8beta-dev3 small bug
Can someone comment on this?
--
-
Leen Besselink wrote:
Hi folks,
8.0beta3 has pg_autovacuum included, when I want to run this as a
Windows service, it says you can use the -I and -R options.
When I do that and I specify a password with '-P'
(uppercase) then in
the registry it's saved as '-p' (lowercase) in the
service-commandline
(ImagePath).
This was fixed in v1.21 of pg_autovacuum.c, That rev is tagged for
beta3, so you should not be seeing this issue unless you actually have
an older version for some reason.
http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_autovacuum/p
g_autovacuum.c.diff?r1=1.20;r2=1.21;f=h
Also it removes the quotes I added and I'm not so sure it
would work
the way it's supposed to, without it.
It's not so much that it strips them (that happens automagically), more
that it doesn't re-add them when it writes the command line in the
registry. The attached patch fixes that by simply quoting all options
that may need it.
If you add DependOnService (a REG_MULTI_SZ an
array-like-thingie) and
have the name (in this case: pgsql-8.0-beta2-dev3) of a service it
depends on, it will not fail to start (it will not even try, as
PostgreSQL is not running), when PostgreSQL already failed.
Maybe it's an idea to specify it on the commandline (what
service to
depend on).
A -E service option is added in the attached patch.
Regards, Dave.
Content-Description: pg_autovacuum.diff
[ Attachment, skipping... ]
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
--
Bruce Momjian| http://candle.pha.pa.us
[EMAIL PROTECTED] | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup.| Newtown Square, Pennsylvania 19073
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
