Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

2016-01-28 Thread Craig Ringer 
On 28 January 2016 at 16:36, Shulgin, Oleksandr <
oleksandr.shul...@zalando.de> wrote:

> On Thu, Jan 28, 2016 at 5:55 AM, Fujii Masao 
> wrote:
>
>> On Wed, Jan 27, 2016 at 7:34 PM, Shulgin, Oleksandr
>>  wrote:
>> > Hi,
>> >
>> > Please find attached a simple copy-paste fix for CREATE_REPLICATION_SLOT
>> > syntax.
>>
>> We should change also START_REPLICATION SLOT syntax document as follows?
>>
>> -  START_REPLICATION SLOT
>> slot_name LOGICAL
>> options
>> +  START_REPLICATION SLOT
>> slot_name LOGICAL
>> XXX/XXX
>> (options)
>>
>
> If a committer would thinks so, I don't object.  Though this one is rather
> a detail for which the reader is already referred to protocol-replication,
> while my fix was about a factual error.
>
>
I think it should be changed. I've already had people confused by this.

Either that or remove the synopsis entirely, changing it to

START_REPLICATION SLOT 

and linking to the protocol docs. Which might be better.



-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

2016-01-28 Thread Shulgin, Oleksandr 
On Thu, Jan 28, 2016 at 5:55 AM, Fujii Masao  wrote:

> On Wed, Jan 27, 2016 at 7:34 PM, Shulgin, Oleksandr
>  wrote:
> > Hi,
> >
> > Please find attached a simple copy-paste fix for CREATE_REPLICATION_SLOT
> > syntax.
>
> We should change also START_REPLICATION SLOT syntax document as follows?
>
> -  START_REPLICATION SLOT
> slot_name LOGICAL
> options
> +  START_REPLICATION SLOT
> slot_name LOGICAL
> XXX/XXX
> (options)
>

If a committer would thinks so, I don't object.  Though this one is rather
a detail for which the reader is already referred to protocol-replication,
while my fix was about a factual error.

--
Alex

Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

2016-01-28 Thread Shulgin, Oleksandr 
On Thu, Jan 28, 2016 at 9:42 AM, Craig Ringer  wrote:
>
>
> On 28 January 2016 at 16:36, Shulgin, Oleksandr <
oleksandr.shul...@zalando.de> wrote:
>>
>> On Thu, Jan 28, 2016 at 5:55 AM, Fujii Masao 
wrote:
>>>
>>>
>>> We should change also START_REPLICATION SLOT syntax document as follows?
>>>
>>> -  START_REPLICATION SLOT
>>> slot_name LOGICAL
>>> options
>>> +  START_REPLICATION SLOT
>>> slot_name LOGICAL
>>> XXX/XXX
>>> (options)
>>
>>
>> If a committer would thinks so, I don't object.  Though this one is
rather a detail for which the reader is already referred to
protocol-replication, while my fix was about a factual error.
>>
>
> I think it should be changed. I've already had people confused by this.
>
> Either that or remove the synopsis entirely, changing it to
>
> START_REPLICATION SLOT 
>
> and linking to the protocol docs. Which might be better.

I think it still makes sense to keep the LOGICAL, but hide the rest of the
details behind that ellipsis, so:

  START_REPLICATION SLOT slot_name LOGICAL ...

Updated patch attached.

--
Alex
From 11b61d04cd16b9577759edff15e68f8ba9c4828e Mon Sep 17 00:00:00 2001
From: Oleksandr Shulgin 
Date: Wed, 27 Jan 2016 11:27:35 +0100
Subject: [PATCH] Fix protocol commands description in logicaldecoding.sgml

---
 doc/src/sgml/logicaldecoding.sgml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml
index 1ae5eb6..e841348 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml
@@ -280,7 +280,7 @@ $ pg_recvlogical -d postgres --slot test --drop-slot
 The commands
 
  
-  CREATE_REPLICATION_SLOT slot_name LOGICAL options
+  CREATE_REPLICATION_SLOT slot_name LOGICAL output_plugin
  
 
  
@@ -288,7 +288,7 @@ $ pg_recvlogical -d postgres --slot test --drop-slot
  
 
  
-  START_REPLICATION SLOT slot_name LOGICAL options
+  START_REPLICATION SLOT slot_name LOGICAL ...
  
 
 are used to create, drop, and stream changes from a replication
-- 
2.5.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

2016-01-28 Thread Fujii Masao 
On Thu, Jan 28, 2016 at 6:08 PM, Shulgin, Oleksandr
 wrote:
> On Thu, Jan 28, 2016 at 9:42 AM, Craig Ringer  wrote:
>>
>>
>> On 28 January 2016 at 16:36, Shulgin, Oleksandr
>>  wrote:
>>>
>>> On Thu, Jan 28, 2016 at 5:55 AM, Fujii Masao 
>>> wrote:


 We should change also START_REPLICATION SLOT syntax document as follows?

 -  START_REPLICATION SLOT
 slot_name LOGICAL
 options
 +  START_REPLICATION SLOT
 slot_name LOGICAL
 XXX/XXX
 (options)
>>>
>>>
>>> If a committer would thinks so, I don't object.  Though this one is
>>> rather a detail for which the reader is already referred to
>>> protocol-replication, while my fix was about a factual error.
>>>
>>
>> I think it should be changed. I've already had people confused by this.
>>
>> Either that or remove the synopsis entirely, changing it to
>>
>> START_REPLICATION SLOT 
>>
>> and linking to the protocol docs. Which might be better.
>
> I think it still makes sense to keep the LOGICAL, but hide the rest of the
> details behind that ellipsis, so:
>
>   START_REPLICATION SLOT slot_name LOGICAL ...
>
> Updated patch attached.

Okay, pushed. Thanks!

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

2016-01-27 Thread Fujii Masao 
On Wed, Jan 27, 2016 at 7:34 PM, Shulgin, Oleksandr
 wrote:
> Hi,
>
> Please find attached a simple copy-paste fix for CREATE_REPLICATION_SLOT
> syntax.

We should change also START_REPLICATION SLOT syntax document as follows?

-  START_REPLICATION SLOT
slot_name LOGICAL
options
+  START_REPLICATION SLOT
slot_name LOGICAL
XXX/XXX
(options)

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Trivial doc fix in logicaldecoding.sgml

2016-01-27 Thread Shulgin, Oleksandr 
Hi,

Please find attached a simple copy-paste fix for CREATE_REPLICATION_SLOT
syntax.

--
Alex
From 05119485a473febe8ffd95103fd7774bc31ee079 Mon Sep 17 00:00:00 2001
From: Oleksandr Shulgin 
Date: Wed, 27 Jan 2016 11:27:35 +0100
Subject: [PATCH] Fix CREATE_REPLICATION_SLOT syntax in logicaldecoding.sgml

---
 doc/src/sgml/logicaldecoding.sgml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml
index 1ae5eb6..926637b 100644
--- a/doc/src/sgml/logicaldecoding.sgml
+++ b/doc/src/sgml/logicaldecoding.sgml
@@ -280,7 +280,7 @@ $ pg_recvlogical -d postgres --slot test --drop-slot
 The commands
 
  
-  CREATE_REPLICATION_SLOT slot_name LOGICAL options
+  CREATE_REPLICATION_SLOT slot_name LOGICAL output_plugin
  
 
  
-- 
2.5.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers