Re: [HACKERS] alter table doc fix
On 2017/10/18 20:37, Alvaro Herrera wrote: > Amit Langote wrote: >> Hi. >> >> Noticed that a alter table sub-command's name in Description (where it's >> OWNER) differs from that in synopsis (where it's OWNER TO). Attached >> patch to make them match, if the difference is unintentional. > > I agree -- pushed. Thanks for committing. > This paragraph > > > The actions for identity columns (ADD > GENERATED, SET etc., DROP > IDENTITY), as well as the actions > TRIGGER, CLUSTER, > OWNER, > and TABLESPACE never recurse to descendant tables; > that is, they always act as though ONLY were specified. > Adding a constraint recurses only for CHECK constraints > that are not marked NO INHERIT. > > > is a bit annoying, though I think it'd be worse if we "fix" it to be > completely strict about the subcommands it refers to. I didn't notice it in this paragraph before you pointed out, but maybe as you say, there's not much point in trying to be strict here too. If we do fix it though, we might want to do something about TRIGGER, CLUSTER, too, because there are no sub-commands named just TRIGGER, CLUSTER. Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] alter table doc fix
Amit Langote wrote: > Hi. > > Noticed that a alter table sub-command's name in Description (where it's > OWNER) differs from that in synopsis (where it's OWNER TO). Attached > patch to make them match, if the difference is unintentional. I agree -- pushed. This paragraph The actions for identity columns (ADD GENERATED, SET etc., DROP IDENTITY), as well as the actions TRIGGER, CLUSTER, OWNER, and TABLESPACE never recurse to descendant tables; that is, they always act as though ONLY were specified. Adding a constraint recurses only for CHECK constraints that are not marked NO INHERIT. is a bit annoying, though I think it'd be worse if we "fix" it to be completely strict about the subcommands it refers to. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] alter table doc fix
Hi. Noticed that a alter table sub-command's name in Description (where it's OWNER) differs from that in synopsis (where it's OWNER TO). Attached patch to make them match, if the difference is unintentional. Thanks, Amit diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml index 68393d70b4..b4b8dab911 100644 --- a/doc/src/sgml/ref/alter_table.sgml +++ b/doc/src/sgml/ref/alter_table.sgml @@ -713,7 +713,7 @@ ALTER TABLE [ IF EXISTS ] name -OWNER +OWNER TO This form changes the owner of the table, sequence, view, materialized view, -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
