Re: [HACKERS] pg_restore --help

2004-12-03 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> Change it right now, and then we'll freeze. :)

Done.

regards, tom lane

---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster


Re: [HACKERS] pg_restore --help

2004-12-03 Thread Peter Eisentraut
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > Do we talk about "output commands" to do things, or directly about
> > restoration?  I think -O description should be
> >   -O, --no-owner   skip restoration of object ownership
>
> This seems reasonable, but I wonder whether we should hold it for
> 8.1. There hasn't been any official declaration that translatable
> strings are frozen for 8.0 --- but are we at that point yet?  Even if
> we're not at hard freeze, minor wording improvements might be out.
>
> Peter, I'll defer to your judgment on this ...

Change it right now, and then we'll freeze. :)

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [HACKERS] pg_restore --help

2004-12-03 Thread Alvaro Herrera
On Fri, Dec 03, 2004 at 12:20:51PM -0500, Tom Lane wrote:

> This seems reasonable, but I wonder whether we should hold it for 8.1.
> There hasn't been any official declaration that translatable strings
> are frozen for 8.0 --- but are we at that point yet?  Even if we're
> not at hard freeze, minor wording improvements might be out.

Not sure, I've been holding translations precisely because strings are
not frozen yet ...

-- 
Alvaro Herrera (<[EMAIL PROTECTED]>)
"La virtud es el justo medio entre dos defectos" (Aristóteles)

---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


Re: [HACKERS] pg_restore --help

2004-12-03 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> Do we talk about "output commands" to do things, or directly about
> restoration?  I think -O description should be
>   -O, --no-owner   skip restoration of object ownership

This seems reasonable, but I wonder whether we should hold it for 8.1.
There hasn't been any official declaration that translatable strings
are frozen for 8.0 --- but are we at that point yet?  Even if we're
not at hard freeze, minor wording improvements might be out.

Peter, I'll defer to your judgment on this ...

regards, tom lane

---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


[HACKERS] pg_restore --help

2004-12-03 Thread Alvaro Herrera
People,

In pg_restore --help I see this:

  -O, --no-owner   do not output commands to set object ownership
[...]
  -x, --no-privileges  skip restoration of access privileges (grant/revoke)


Do we talk about "output commands" to do things, or directly about
restoration?  I think -O description should be

  -O, --no-owner   skip restoration of object ownership

or something similar, to be consistent.  Patch for that attached, but
feel free to editorialize ...

-- 
Alvaro Herrera ()
"The ability to monopolize a planet is insignificant
next to the power of the source"
Index: src/bin/pg_dump/pg_restore.c
===
RCS file: /home/alvherre/cvs/pgsql/src/bin/pg_dump/pg_restore.c,v
retrieving revision 1.67
diff -c -r1.67 pg_restore.c
*** src/bin/pg_dump/pg_restore.c27 Nov 2004 18:51:06 -  1.67
--- src/bin/pg_dump/pg_restore.c3 Dec 2004 16:34:50 -
***
*** 376,382 
printf(_("  -I, --index=NAME restore named index\n"));
printf(_("  -L, --use-list=FILENAME  use specified table of contents 
for ordering\n"
 "   output from this file\n"));
!   printf(_("  -O, --no-owner   do not issue commands to set 
object ownership\n"));
printf(_("  -P, --function=NAME(args)\n"
 "   restore named 
function\n"));
printf(_("  -s, --schema-onlyrestore only the schema, no 
data\n"));
--- 376,382 
printf(_("  -I, --index=NAME restore named index\n"));
printf(_("  -L, --use-list=FILENAME  use specified table of contents 
for ordering\n"
 "   output from this file\n"));
!   printf(_("  -O, --no-owner   skip restoration of object 
ownership\n"));
printf(_("  -P, --function=NAME(args)\n"
 "   restore named 
function\n"));
printf(_("  -s, --schema-onlyrestore only the schema, no 
data\n"));

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


Re: [HACKERS] pg_restore --help

2004-12-03 Thread Alvaro Herrera
On Fri, Dec 03, 2004 at 01:35:55PM -0300, Alvaro Herrera wrote:

> In pg_restore --help I see this:
> 
>   -O, --no-owner   do not output commands to set object ownership
> [...]
>   -x, --no-privileges  skip restoration of access privileges 
> (grant/revoke)

Sorry, of course the problem is not only pg_restore --no-owner, but also
in pg_dump and pg_dumpall as well (albeit with a slightly different
wording and meaning).

-- 
Alvaro Herrera ()
"La espina, desde que nace, ya pincha" (Proverbio africano)


---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])