Re: [HACKERS] Incorrect documentation about pg_stat_activity

2017-06-23 Thread Simon Riggs 
On 21 June 2017 at 15:18, Simon Riggs  wrote:
> On 21 June 2017 at 16:15, Yugo Nagata  wrote:
>> On Wed, 21 Jun 2017 19:08:35 +0530
>> Kuntal Ghosh  wrote:
>>
>>> On Wed, Jun 21, 2017 at 6:05 PM, Yugo Nagata  wrote:
>>> >
>>> > Attached is a patch for the documentation fix.
>>> >
>>> Please attach the patch as well. :-)
>>
>> I'm sorry, I forgot it. I attahed this.
>
> Thanks, will apply.

Done, thanks

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Incorrect documentation about pg_stat_activity

2017-06-22 Thread Yugo Nagata 
On Thu, 22 Jun 2017 14:14:53 +0530
Ashutosh Bapat  wrote:

> On Wed, Jun 21, 2017 at 7:48 PM, Simon Riggs  wrote:
> > On 21 June 2017 at 16:15, Yugo Nagata  wrote:
> >> On Wed, 21 Jun 2017 19:08:35 +0530
> >> Kuntal Ghosh  wrote:
> >>
> >>> On Wed, Jun 21, 2017 at 6:05 PM, Yugo Nagata  wrote:
> >>> >
> >>> > Attached is a patch for the documentation fix.
> >>> >
> >>> Please attach the patch as well. :-)
> >>
> >> I'm sorry, I forgot it. I attahed this.
> >
> > Thanks, will apply.
> 
> The patch is adjusting documentation for the observed behaviour. But I
> don't see a justification as to why the observed behaviour is correct
> one? Was there a commit which allowed startup process to be part of
> pg_stat_activity but forgot to update the documentation or the current
> behaviour is unintentional and probably needs to be fixed?

I confirmed the pg_stat_activity documentation and this says "startup" 
can be backend_type column's value, so I believe the behaviour is intentional.

https://www.postgresql.org/docs/10/static/monitoring-stats.html#pg-stat-activity-view

> 
> -- 
> Best Wishes,
> Ashutosh Bapat
> EnterpriseDB Corporation
> The Postgres Database Company


-- 
Yugo Nagata 


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Incorrect documentation about pg_stat_activity

2017-06-22 Thread Ashutosh Bapat 
On Wed, Jun 21, 2017 at 7:48 PM, Simon Riggs  wrote:
> On 21 June 2017 at 16:15, Yugo Nagata  wrote:
>> On Wed, 21 Jun 2017 19:08:35 +0530
>> Kuntal Ghosh  wrote:
>>
>>> On Wed, Jun 21, 2017 at 6:05 PM, Yugo Nagata  wrote:
>>> >
>>> > Attached is a patch for the documentation fix.
>>> >
>>> Please attach the patch as well. :-)
>>
>> I'm sorry, I forgot it. I attahed this.
>
> Thanks, will apply.

The patch is adjusting documentation for the observed behaviour. But I
don't see a justification as to why the observed behaviour is correct
one? Was there a commit which allowed startup process to be part of
pg_stat_activity but forgot to update the documentation or the current
behaviour is unintentional and probably needs to be fixed?

-- 
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Incorrect documentation about pg_stat_activity

2017-06-21 Thread Yugo Nagata 
On Wed, 21 Jun 2017 16:18:50 +0200
Simon Riggs  wrote:

> On 21 June 2017 at 16:15, Yugo Nagata  wrote:
> > On Wed, 21 Jun 2017 19:08:35 +0530
> > Kuntal Ghosh  wrote:
> >
> >> On Wed, Jun 21, 2017 at 6:05 PM, Yugo Nagata  wrote:
> >> >
> >> > Attached is a patch for the documentation fix.
> >> >
> >> Please attach the patch as well. :-)
> >
> > I'm sorry, I forgot it. I attahed this.
> 
> Thanks, will apply.

Thanks, too.

> 
> -- 
> Simon Riggshttp://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Yugo Nagata 


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Incorrect documentation about pg_stat_activity

2017-06-21 Thread Simon Riggs 
On 21 June 2017 at 16:15, Yugo Nagata  wrote:
> On Wed, 21 Jun 2017 19:08:35 +0530
> Kuntal Ghosh  wrote:
>
>> On Wed, Jun 21, 2017 at 6:05 PM, Yugo Nagata  wrote:
>> >
>> > Attached is a patch for the documentation fix.
>> >
>> Please attach the patch as well. :-)
>
> I'm sorry, I forgot it. I attahed this.

Thanks, will apply.

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Incorrect documentation about pg_stat_activity

2017-06-21 Thread Yugo Nagata 
On Wed, 21 Jun 2017 19:08:35 +0530
Kuntal Ghosh  wrote:

> On Wed, Jun 21, 2017 at 6:05 PM, Yugo Nagata  wrote:
> >
> > Attached is a patch for the documentation fix.
> >
> Please attach the patch as well. :-)

I'm sorry, I forgot it. I attahed this.

> 
> 
> -- 
> Thanks & Regards,
> Kuntal Ghosh
> EnterpriseDB: http://www.enterprisedb.com
> 
> 
> -- 
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers


-- 
Yugo Nagata 
diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index 72eb073..1188f07 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -2203,12 +2203,12 @@ LOG:  database system is ready to accept read only connections
 pg_cancel_backend()
 and pg_terminate_backend() will work on user backends,
 but not the Startup process, which performs
-recovery. pg_stat_activity does not show an
-entry for the Startup process, nor do recovering transactions show
-as active. As a result, pg_prepared_xacts
-is always empty during recovery. If you wish to resolve in-doubt
-prepared transactions, view pg_prepared_xacts on the
-primary and issue commands to resolve transactions there.
+recovery. pg_stat_activity does not show
+recovering transactions as active. As a result,
+pg_prepared_xacts is always empty during
+recovery. If you wish to resolve in-doubt prepared transactions, view
+pg_prepared_xacts on the primary and issue commands to
+resolve transactions there.

 


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Incorrect documentation about pg_stat_activity

2017-06-21 Thread Kuntal Ghosh 
On Wed, Jun 21, 2017 at 6:05 PM, Yugo Nagata  wrote:
>
> Attached is a patch for the documentation fix.
>
Please attach the patch as well. :-)


-- 
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers