Re: [PATCHES] Uninstall scripts for contrib
Am Mittwoch, 22. Februar 2006 08:31 schrieb David Fetter: It applied just fine against the CVSup version. This one should apply against CVS TIP. Done. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] Uninstall scripts for contrib
On Sat, Feb 18, 2006 at 07:08:15PM +0100, Peter Eisentraut wrote: David Fetter wrote: This one should do it. This patch fails to apply all over the place. It applied just fine against the CVSup version. This one should apply against CVS TIP. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! diff -rNc pgsql/contrib/btree_gist/Makefile pgsql_scratch/contrib/btree_gist/Makefile *** pgsql/contrib/btree_gist/Makefile 2005-09-27 10:12:59.0 -0700 --- pgsql_scratch/contrib/btree_gist/Makefile 2006-02-21 23:15:32.0 -0800 *** *** 7,12 --- 7,13 btree_bytea.o btree_bit.o btree_numeric.o DATA_built = btree_gist.sql + DATA= uninstall_btree_gist.sql DOCS= README.btree_gist REGRESS = init int2 int4 int8 float4 float8 cash oid timestamp timestamptz time timetz \ diff -rNc pgsql/contrib/btree_gist/uninstall_btree_gist.sql pgsql_scratch/contrib/btree_gist/uninstall_btree_gist.sql *** pgsql/contrib/btree_gist/uninstall_btree_gist.sql 1969-12-31 16:00:00.0 -0800 --- pgsql_scratch/contrib/btree_gist/uninstall_btree_gist.sql 2006-02-21 23:15:32.0 -0800 *** *** 0 --- 1,301 + SET search_path = public; + + DROP OPERATOR CLASS gist_cidr_ops; + + DROP OPERATOR CLASS gist_inet_ops; + + DROP FUNCTION gbt_inet_same(internal, internal, internal); + + DROP FUNCTION gbt_inet_union(bytea, internal); + + DROP FUNCTION gbt_inet_picksplit(internal, internal); + + DROP FUNCTION gbt_inet_penalty(internal,internal,internal); + + DROP FUNCTION gbt_cidr_compress(internal); + + DROP FUNCTION gbt_inet_compress(internal); + + DROP FUNCTION gbt_cidr_consistent(internal,cidr,int2); + + DROP FUNCTION gbt_inet_consistent(internal,inet,int2); + + DROP OPERATOR CLASS gist_vbit_ops; + + DROP OPERATOR CLASS gist_bit_ops; + + DROP FUNCTION gbt_bit_same(internal, internal, internal); + + DROP FUNCTION gbt_bit_union(bytea, internal); + + DROP FUNCTION gbt_bit_picksplit(internal, internal); + + DROP FUNCTION gbt_bit_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bit_compress(internal); + + DROP FUNCTION gbt_bit_consistent(internal,bit,int2); + + DROP OPERATOR CLASS gist_numeric_ops; + + DROP FUNCTION gbt_numeric_same(internal, internal, internal); + + DROP FUNCTION gbt_numeric_union(bytea, internal); + + DROP FUNCTION gbt_numeric_picksplit(internal, internal); + + DROP FUNCTION gbt_numeric_penalty(internal,internal,internal); + + DROP FUNCTION gbt_numeric_compress(internal); + + DROP FUNCTION gbt_numeric_consistent(internal,numeric,int2); + + DROP OPERATOR CLASS gist_bytea_ops; + + DROP FUNCTION gbt_bytea_same(internal, internal, internal); + + DROP FUNCTION gbt_bytea_union(bytea, internal); + + DROP FUNCTION gbt_bytea_picksplit(internal, internal); + + DROP FUNCTION gbt_bytea_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bytea_compress(internal); + + DROP FUNCTION gbt_bytea_consistent(internal,bytea,int2); + + DROP OPERATOR CLASS gist_bpchar_ops; + + DROP OPERATOR CLASS gist_text_ops; + + DROP FUNCTION gbt_text_same(internal, internal, internal); + + DROP FUNCTION gbt_text_union(bytea, internal); + + DROP FUNCTION gbt_text_picksplit(internal, internal); + + DROP FUNCTION gbt_text_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bpchar_compress(internal); + + DROP FUNCTION gbt_text_compress(internal); + + DROP FUNCTION gbt_bpchar_consistent(internal,bpchar,int2); + + DROP FUNCTION gbt_text_consistent(internal,text,int2); + + DROP OPERATOR CLASS gist_macaddr_ops; + + DROP FUNCTION gbt_macad_same(internal, internal, internal); + + DROP FUNCTION gbt_macad_union(bytea, internal); + + DROP FUNCTION gbt_macad_picksplit(internal, internal); + + DROP FUNCTION gbt_macad_penalty(internal,internal,internal); + + DROP FUNCTION gbt_macad_compress(internal); + + DROP FUNCTION gbt_macad_consistent(internal,macaddr,int2); + + DROP OPERATOR CLASS gist_cash_ops; + + DROP FUNCTION gbt_cash_same(internal, internal, internal); + + DROP FUNCTION gbt_cash_union(bytea, internal); + + DROP FUNCTION gbt_cash_picksplit(internal, internal); + + DROP FUNCTION gbt_cash_penalty(internal,internal,internal); + + DROP FUNCTION gbt_cash_compress(internal); + + DROP FUNCTION gbt_cash_consistent(internal,money,int2); + + DROP OPERATOR CLASS gist_interval_ops; + + DROP FUNCTION gbt_intv_same(internal, internal, internal); + + DROP FUNCTION gbt_intv_union(bytea, internal); + + DROP FUNCTION gbt_intv_picksplit(internal, internal); + + DROP FUNCTION gbt_intv_penalty(internal,internal,internal); + + DROP FUNCTION gbt_intv_decompress(internal); + + DROP FUNCTION gbt_intv_compress(internal); + + DROP FUNCTION gbt_intv_consistent(internal,interval,int2); + + DROP OPERATOR CLASS gist_date_ops; + + DROP FUNCTION gbt_date_same(internal, internal, internal); + + DROP FUNCTION gbt_date_union(bytea,
Re: [PATCHES] Uninstall scripts for contrib
David Fetter wrote: This one should do it. This patch fails to apply all over the place. Please fix it so we don't have to sort out the chunks manually. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Uninstall scripts for contrib
On Sat, Feb 11, 2006 at 11:37:49PM -0500, Bruce Momjian wrote: David Fetter wrote: On Sun, Jan 15, 2006 at 09:55:39PM -0800, David Fetter wrote: On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: ifdef USE_PGXS The change to $PostgreSQL$ is bogus (perhaps due to the way you setup cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also, the patch doesn't actually add any files called uninstall.sql. Oops. My FM R'ing skills need some work. This patch includes the files. Next: naming files so they don't clobber each other. I have updated your patch to remove the $PostgreSQL$ tags, but I still do not see the uninstall files in the patch. This one should do it. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! Index: contrib/btree_gist/Makefile === RCS file: /oracle/CVSup/pgsql/contrib/btree_gist/Makefile,v retrieving revision 1.8 diff -c -r1.8 Makefile *** contrib/btree_gist/Makefile 27 Sep 2005 17:12:59 - 1.8 --- contrib/btree_gist/Makefile 14 Jan 2006 23:16:18 - *** *** 7,12 --- 7,13 btree_bytea.o btree_bit.o btree_numeric.o DATA_built = btree_gist.sql + DATA= uninstall_btree_gist.sql DOCS= README.btree_gist REGRESS = init int2 int4 int8 float4 float8 cash oid timestamp timestamptz time timetz \ Index: contrib/btree_gist/uninstall_btree_gist.sql === RCS file: contrib/btree_gist/uninstall_btree_gist.sql diff -N contrib/btree_gist/uninstall_btree_gist.sql *** /dev/null 1 Jan 1970 00:00:00 - --- contrib/btree_gist/uninstall_btree_gist.sql 14 Jan 2006 21:57:09 - *** *** 0 --- 1,301 + SET search_path = public; + + DROP OPERATOR CLASS gist_cidr_ops; + + DROP OPERATOR CLASS gist_inet_ops; + + DROP FUNCTION gbt_inet_same(internal, internal, internal); + + DROP FUNCTION gbt_inet_union(bytea, internal); + + DROP FUNCTION gbt_inet_picksplit(internal, internal); + + DROP FUNCTION gbt_inet_penalty(internal,internal,internal); + + DROP FUNCTION gbt_cidr_compress(internal); + + DROP FUNCTION gbt_inet_compress(internal); + + DROP FUNCTION gbt_cidr_consistent(internal,cidr,int2); + + DROP FUNCTION gbt_inet_consistent(internal,inet,int2); + + DROP OPERATOR CLASS gist_vbit_ops; + + DROP OPERATOR CLASS gist_bit_ops; + + DROP FUNCTION gbt_bit_same(internal, internal, internal); + + DROP FUNCTION gbt_bit_union(bytea, internal); + + DROP FUNCTION gbt_bit_picksplit(internal, internal); + + DROP FUNCTION gbt_bit_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bit_compress(internal); + + DROP FUNCTION gbt_bit_consistent(internal,bit,int2); + + DROP OPERATOR CLASS gist_numeric_ops; + + DROP FUNCTION gbt_numeric_same(internal, internal, internal); + + DROP FUNCTION gbt_numeric_union(bytea, internal); + + DROP FUNCTION gbt_numeric_picksplit(internal, internal); + + DROP FUNCTION gbt_numeric_penalty(internal,internal,internal); + + DROP FUNCTION gbt_numeric_compress(internal); + + DROP FUNCTION gbt_numeric_consistent(internal,numeric,int2); + + DROP OPERATOR CLASS gist_bytea_ops; + + DROP FUNCTION gbt_bytea_same(internal, internal, internal); + + DROP FUNCTION gbt_bytea_union(bytea, internal); + + DROP FUNCTION gbt_bytea_picksplit(internal, internal); + + DROP FUNCTION gbt_bytea_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bytea_compress(internal); + + DROP FUNCTION gbt_bytea_consistent(internal,bytea,int2); + + DROP OPERATOR CLASS gist_bpchar_ops; + + DROP OPERATOR CLASS gist_text_ops; + + DROP FUNCTION gbt_text_same(internal, internal, internal); + + DROP FUNCTION gbt_text_union(bytea, internal); + + DROP FUNCTION gbt_text_picksplit(internal, internal); + + DROP FUNCTION gbt_text_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bpchar_compress(internal); + + DROP FUNCTION gbt_text_compress(internal); + + DROP FUNCTION gbt_bpchar_consistent(internal,bpchar,int2); + + DROP FUNCTION gbt_text_consistent(internal,text,int2); + + DROP OPERATOR CLASS gist_macaddr_ops; + + DROP FUNCTION gbt_macad_same(internal, internal, internal); + + DROP FUNCTION gbt_macad_union(bytea, internal); + + DROP FUNCTION gbt_macad_picksplit(internal, internal); + + DROP FUNCTION gbt_macad_penalty(internal,internal,internal); + + DROP FUNCTION gbt_macad_compress(internal); + + DROP FUNCTION gbt_macad_consistent(internal,macaddr,int2); + + DROP OPERATOR CLASS gist_cash_ops; + + DROP FUNCTION gbt_cash_same(internal, internal, internal); + + DROP FUNCTION gbt_cash_union(bytea, internal); + + DROP FUNCTION gbt_cash_picksplit(internal, internal); + + DROP FUNCTION gbt_cash_penalty(internal,internal,internal); + + DROP FUNCTION
Re: [PATCHES] Uninstall scripts for contrib
David Fetter wrote: On Sun, Jan 15, 2006 at 09:55:39PM -0800, David Fetter wrote: On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: ifdef USE_PGXS The change to $PostgreSQL$ is bogus (perhaps due to the way you setup cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also, the patch doesn't actually add any files called uninstall.sql. Oops. My FM R'ing skills need some work. This patch includes the files. Next: naming files so they don't clobber each other. I have updated your patch to remove the $PostgreSQL$ tags, but I still do not see the uninstall files in the patch. -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 Index: contrib/btree_gist/Makefile === RCS file: /cvsroot/pgsql/contrib/btree_gist/Makefile,v retrieving revision 1.8 diff -c -c -r1.8 Makefile *** contrib/btree_gist/Makefile 27 Sep 2005 17:12:59 - 1.8 --- contrib/btree_gist/Makefile 12 Feb 2006 04:36:55 - *** *** 7,12 --- 7,13 btree_bytea.o btree_bit.o btree_numeric.o DATA_built = btree_gist.sql + DATA= uninstall_btree_gist.sql DOCS= README.btree_gist REGRESS = init int2 int4 int8 float4 float8 cash oid timestamp timestamptz time timetz \ Index: contrib/chkpass/Makefile === RCS file: /cvsroot/pgsql/contrib/chkpass/Makefile,v retrieving revision 1.7 diff -c -c -r1.7 Makefile *** contrib/chkpass/Makefile27 Sep 2005 17:13:00 - 1.7 --- contrib/chkpass/Makefile12 Feb 2006 04:36:55 - *** *** 4,9 --- 4,10 OBJS = chkpass.o SHLIB_LINK = $(filter -lcrypt, $(LIBS)) DATA_built = chkpass.sql + DATA = uninstall_chkpass.sql DOCS = README.chkpass ifdef USE_PGXS Index: contrib/cube/Makefile === RCS file: /cvsroot/pgsql/contrib/cube/Makefile,v retrieving revision 1.15 diff -c -c -r1.15 Makefile *** contrib/cube/Makefile 18 Oct 2005 01:30:48 - 1.15 --- contrib/cube/Makefile 12 Feb 2006 04:36:55 - *** *** 4,9 --- 4,10 OBJS= cube.o cubeparse.o DATA_built = cube.sql + DATA = uninstall_cube.sql DOCS = README.cube REGRESS = cube Index: contrib/dblink/Makefile === RCS file: /cvsroot/pgsql/contrib/dblink/Makefile,v retrieving revision 1.10 diff -c -c -r1.10 Makefile *** contrib/dblink/Makefile 27 Sep 2005 17:13:01 - 1.10 --- contrib/dblink/Makefile 12 Feb 2006 04:36:55 - *** *** 6,11 --- 6,12 SHLIB_LINK = $(libpq) DATA_built = dblink.sql + DATA = uninstall_dblink.sql DOCS = README.dblink REGRESS = dblink Index: contrib/earthdistance/Makefile === RCS file: /cvsroot/pgsql/contrib/earthdistance/Makefile,v retrieving revision 1.16 diff -c -c -r1.16 Makefile *** contrib/earthdistance/Makefile 27 Sep 2005 17:13:02 - 1.16 --- contrib/earthdistance/Makefile 12 Feb 2006 04:36:55 - *** *** 2,7 --- 2,8 MODULES = earthdistance DATA_built = earthdistance.sql + DATA = uninstall_earthdistance.sql DOCS = README.earthdistance REGRESS = earthdistance Index: contrib/fuzzystrmatch/Makefile === RCS file: /cvsroot/pgsql/contrib/fuzzystrmatch/Makefile,v retrieving revision 1.6 diff -c -c -r1.6 Makefile *** contrib/fuzzystrmatch/Makefile 27 Sep 2005 17:13:03 - 1.6 --- contrib/fuzzystrmatch/Makefile 12 Feb 2006 04:36:55 - *** *** 4,9 --- 4,10 SRCS += fuzzystrmatch.c dmetaphone.c OBJS = $(SRCS:.c=.o) DATA_built = fuzzystrmatch.sql + DATA = uninstall_fuzzystrmatch.sql DOCS = README.fuzzystrmatch README.soundex ifdef USE_PGXS Index: contrib/intagg/Makefile === RCS file: /cvsroot/pgsql/contrib/intagg/Makefile,v retrieving revision 1.6 diff -c -c -r1.6 Makefile *** contrib/intagg/Makefile 27 Sep 2005 17:13:03 - 1.6 --- contrib/intagg/Makefile 12 Feb 2006 04:36:55 - *** *** 6,11 --- 6,12 MODULES = int_aggregate DATA_built = int_aggregate.sql + DATA = uninstall_int_aggregate.sql DOCS = README.int_aggregate ifdef USE_PGXS Index: contrib/intarray/Makefile === RCS file: /cvsroot/pgsql/contrib/intarray/Makefile,v retrieving revision
Re: [PATCHES] Uninstall scripts for contrib
On Sun, Jan 15, 2006 at 09:55:39PM -0800, David Fetter wrote: On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: ifdef USE_PGXS The change to $PostgreSQL$ is bogus (perhaps due to the way you setup cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also, the patch doesn't actually add any files called uninstall.sql. Oops. My FM R'ing skills need some work. This patch includes the files. Next: naming files so they don't clobber each other. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! Index: contrib/btree_gist/Makefile === RCS file: /oracle/CVSup/pgsql/contrib/btree_gist/Makefile,v retrieving revision 1.8 diff -c -r1.8 Makefile *** contrib/btree_gist/Makefile 27 Sep 2005 17:12:59 - 1.8 --- contrib/btree_gist/Makefile 24 Jan 2006 23:09:24 - *** *** 7,12 --- 7,13 btree_bytea.o btree_bit.o btree_numeric.o DATA_built = btree_gist.sql + DATA= uninstall_btree_gist.sql DOCS= README.btree_gist REGRESS = init int2 int4 int8 float4 float8 cash oid timestamp timestamptz time timetz \ Index: contrib/chkpass/Makefile === RCS file: /oracle/CVSup/pgsql/contrib/chkpass/Makefile,v retrieving revision 1.7 diff -c -r1.7 Makefile *** contrib/chkpass/Makefile27 Sep 2005 17:13:00 - 1.7 --- contrib/chkpass/Makefile24 Jan 2006 23:09:24 - *** *** 1,9 ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.6 2004/08/20 20:13:02 momjian Exp $ MODULE_big = chkpass OBJS = chkpass.o SHLIB_LINK = $(filter -lcrypt, $(LIBS)) DATA_built = chkpass.sql DOCS = README.chkpass ifdef USE_PGXS --- 1,10 ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.7 2005/09/27 17:13:00 tgl Exp $ MODULE_big = chkpass OBJS = chkpass.o SHLIB_LINK = $(filter -lcrypt, $(LIBS)) DATA_built = chkpass.sql + DATA = uninstall_chkpass.sql DOCS = README.chkpass ifdef USE_PGXS Index: contrib/cube/Makefile === RCS file: /oracle/CVSup/pgsql/contrib/cube/Makefile,v retrieving revision 1.15 diff -c -r1.15 Makefile *** contrib/cube/Makefile 18 Oct 2005 01:30:48 - 1.15 --- contrib/cube/Makefile 24 Jan 2006 23:09:24 - *** *** 1,9 ! # $PostgreSQL: pgsql/contrib/cube/Makefile,v 1.14 2005/09/27 17:13:00 tgl Exp $ MODULE_big = cube OBJS= cube.o cubeparse.o DATA_built = cube.sql DOCS = README.cube REGRESS = cube --- 1,10 ! # $PostgreSQL: pgsql/contrib/cube/Makefile,v 1.15 2005/10/18 01:30:48 tgl Exp $ MODULE_big = cube OBJS= cube.o cubeparse.o DATA_built = cube.sql + DATA = uninstall_cube.sql DOCS = README.cube REGRESS = cube Index: contrib/dblink/Makefile === RCS file: /oracle/CVSup/pgsql/contrib/dblink/Makefile,v retrieving revision 1.10 diff -c -r1.10 Makefile *** contrib/dblink/Makefile 27 Sep 2005 17:13:01 - 1.10 --- contrib/dblink/Makefile 24 Jan 2006 23:09:24 - *** *** 1,4 ! # $PostgreSQL: pgsql/contrib/dblink/Makefile,v 1.9 2004/08/20 20:13:03 momjian Exp $ MODULE_big = dblink PG_CPPFLAGS = -I$(libpq_srcdir) --- 1,4 ! # $PostgreSQL: pgsql/contrib/dblink/Makefile,v 1.10 2005/09/27 17:13:01 tgl Exp $ MODULE_big = dblink PG_CPPFLAGS = -I$(libpq_srcdir) *** *** 6,11 --- 6,12 SHLIB_LINK = $(libpq) DATA_built = dblink.sql + DATA = uninstall_dblink.sql DOCS = README.dblink REGRESS = dblink Index: contrib/dbmirror/Makefile === RCS file: /oracle/CVSup/pgsql/contrib/dbmirror/Makefile,v retrieving revision 1.5 diff -c -r1.5 Makefile *** contrib/dbmirror/Makefile 27 Sep 2005 17:13:01 - 1.5 --- contrib/dbmirror/Makefile 24 Jan 2006 23:09:24 - *** *** 1,4 ! # $PostgreSQL: pgsql/contrib/dbmirror/Makefile,v 1.4 2004/11/04 06:09:19 neilc Exp $ MODULES = pending SCRIPTS = clean_pending.pl DBMirror.pl --- 1,4 ! # $PostgreSQL: pgsql/contrib/dbmirror/Makefile,v 1.5 2005/09/27 17:13:01 tgl Exp $ MODULES = pending SCRIPTS = clean_pending.pl DBMirror.pl Index: contrib/earthdistance/Makefile === RCS file: /oracle/CVSup/pgsql/contrib/earthdistance/Makefile,v retrieving revision 1.16 diff -c -r1.16 Makefile *** contrib/earthdistance/Makefile 27 Sep 2005 17:13:02 - 1.16 --- contrib/earthdistance/Makefile 24 Jan 2006 23:09:24 - *** *** 1,7 ! # $PostgreSQL: pgsql/contrib/earthdistance/Makefile,v 1.15 2005/07/24 23:30:09 tgl
Re: [PATCHES] Uninstall scripts for contrib
Am Montag, 16. Januar 2006 06:55 schrieb David Fetter: Oops. My FM R'ing skills need some work. This patch includes the files. This patch is rather useless because all the uninstall.sql files install on top of each other. I suggest naming them cube_uninstall.sql dblink_uninstall.sql etc. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Uninstall scripts for contrib
On Thu, Jan 19, 2006 at 02:22:17PM +0100, Peter Eisentraut wrote: Am Montag, 16. Januar 2006 06:55 schrieb David Fetter: Oops. My FM R'ing skills need some work. This patch includes the files. This patch is rather useless because all the uninstall.sql files install on top of each other. I suggest naming them cube_uninstall.sql dblink_uninstall.sql etc. It's paper bag time for me. How about a new patch which gives each contrib project its own directory and places them there? Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Uninstall scripts for contrib
David Fetter wrote: It's paper bag time for me. How about a new patch which gives each contrib project its own directory and places them there? This would presumably imply that the installation scripts would be renamed to install.sql. On a green field this might make sense but as it is maybe it would break too much without much benefit? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] Uninstall scripts for contrib
On Thu, Jan 19, 2006 at 07:08:28PM +0100, Peter Eisentraut wrote: David Fetter wrote: It's paper bag time for me. How about a new patch which gives each contrib project its own directory and places them there? This would presumably imply that the installation scripts would be renamed to install.sql. On a green field this might make sense but as it is maybe it would break too much without much benefit? You're right. I'll send a patch this evening my time that renames each to [module_name]_uninstall.sql. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Uninstall scripts for contrib
Peter Eisentraut [EMAIL PROTECTED] writes: David Fetter wrote: It's paper bag time for me. How about a new patch which gives each contrib project its own directory and places them there? This would presumably imply that the installation scripts would be renamed to install.sql. On a green field this might make sense but as it is maybe it would break too much without much benefit? I agree, the current setup is not broken and doesn't need to be fixed. What *is* broken is the contrib documentation install layout, though, because of the modules that have additional documentation in sub-directories. Any thoughts what to do about that? regards, tom lane ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] Uninstall scripts for contrib
Removed at submitter request. --- David Fetter wrote: On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: ifdef USE_PGXS The change to $PostgreSQL$ is bogus (perhaps due to the way you setup cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also, the patch doesn't actually add any files called uninstall.sql. Oops. My FM R'ing skills need some work. This patch includes the files. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! [ Attachment, skipping... ] ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Uninstall scripts for contrib
On Thu, Jan 19, 2006 at 11:48:54AM -0800, David Fetter wrote: On Thu, Jan 19, 2006 at 07:08:28PM +0100, Peter Eisentraut wrote: David Fetter wrote: It's paper bag time for me. How about a new patch which gives each contrib project its own directory and places them there? This would presumably imply that the installation scripts would be renamed to install.sql. On a green field this might make sense but as it is maybe it would break too much without much benefit? You're right. I'll send a patch this evening my time that renames each to [module_name]_uninstall.sql. ISTM there's a pretty good usecase for going per-directory down the road. IIRC we already decided to do that for doc directories, and now that we'd have 2 scripts (_install and _uninstall) it seems a good idea for that as well. For backwards compatability maybe an install option that also installed the old-style _install.sql script would be adequate? Perhaps this could default to on for 8.2, off for 8.3 and gone for 8.4... -- Jim C. Nasby, Sr. Engineering Consultant [EMAIL PROTECTED] Pervasive Software http://pervasive.comwork: 512-231-6117 vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461 ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Uninstall scripts for contrib
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- David Fetter wrote: On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: ifdef USE_PGXS The change to $PostgreSQL$ is bogus (perhaps due to the way you setup cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also, the patch doesn't actually add any files called uninstall.sql. Oops. My FM R'ing skills need some work. This patch includes the files. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! [ Attachment, skipping... ] ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Uninstall scripts for contrib
On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: *** contrib/chkpass/Makefile27 Sep 2005 17:13:00 - 1.7 --- contrib/chkpass/Makefile14 Jan 2006 23:16:03 - *** *** 1,9 ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.6 2004/08/20 20:13:02 momjian Exp $ MODULE_big = chkpass OBJS = chkpass.o SHLIB_LINK = $(filter -lcrypt, $(LIBS)) DATA_built = chkpass.sql DOCS = README.chkpass ifdef USE_PGXS --- 1,10 ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.7 2005/09/27 17:13:00 tgl Exp $ MODULE_big = chkpass OBJS = chkpass.o SHLIB_LINK = $(filter -lcrypt, $(LIBS)) DATA_built = chkpass.sql + DATA = uninstall.sql DOCS = README.chkpass ifdef USE_PGXS The change to $PostgreSQL$ is bogus (perhaps due to the way you setup cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also, the patch doesn't actually add any files called uninstall.sql. -Neil ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] Uninstall scripts for contrib
On Mon, Jan 16, 2006 at 12:13:11AM -0500, Neil Conway wrote: On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote: ifdef USE_PGXS The change to $PostgreSQL$ is bogus (perhaps due to the way you setup cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also, the patch doesn't actually add any files called uninstall.sql. Oops. My FM R'ing skills need some work. This patch includes the files. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! Index: contrib/btree_gist/Makefile === RCS file: /oracle/CVSup/pgsql/contrib/btree_gist/Makefile,v retrieving revision 1.8 diff -c -r1.8 Makefile *** contrib/btree_gist/Makefile 27 Sep 2005 17:12:59 - 1.8 --- contrib/btree_gist/Makefile 14 Jan 2006 23:16:18 - *** *** 7,12 --- 7,13 btree_bytea.o btree_bit.o btree_numeric.o DATA_built = btree_gist.sql + DATA= uninstall.sql DOCS= README.btree_gist REGRESS = init int2 int4 int8 float4 float8 cash oid timestamp timestamptz time timetz \ Index: contrib/btree_gist/uninstall.sql === RCS file: contrib/btree_gist/uninstall.sql diff -N contrib/btree_gist/uninstall.sql *** /dev/null 1 Jan 1970 00:00:00 - --- contrib/btree_gist/uninstall.sql14 Jan 2006 21:57:09 - *** *** 0 --- 1,301 + SET search_path = public; + + DROP OPERATOR CLASS gist_cidr_ops; + + DROP OPERATOR CLASS gist_inet_ops; + + DROP FUNCTION gbt_inet_same(internal, internal, internal); + + DROP FUNCTION gbt_inet_union(bytea, internal); + + DROP FUNCTION gbt_inet_picksplit(internal, internal); + + DROP FUNCTION gbt_inet_penalty(internal,internal,internal); + + DROP FUNCTION gbt_cidr_compress(internal); + + DROP FUNCTION gbt_inet_compress(internal); + + DROP FUNCTION gbt_cidr_consistent(internal,cidr,int2); + + DROP FUNCTION gbt_inet_consistent(internal,inet,int2); + + DROP OPERATOR CLASS gist_vbit_ops; + + DROP OPERATOR CLASS gist_bit_ops; + + DROP FUNCTION gbt_bit_same(internal, internal, internal); + + DROP FUNCTION gbt_bit_union(bytea, internal); + + DROP FUNCTION gbt_bit_picksplit(internal, internal); + + DROP FUNCTION gbt_bit_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bit_compress(internal); + + DROP FUNCTION gbt_bit_consistent(internal,bit,int2); + + DROP OPERATOR CLASS gist_numeric_ops; + + DROP FUNCTION gbt_numeric_same(internal, internal, internal); + + DROP FUNCTION gbt_numeric_union(bytea, internal); + + DROP FUNCTION gbt_numeric_picksplit(internal, internal); + + DROP FUNCTION gbt_numeric_penalty(internal,internal,internal); + + DROP FUNCTION gbt_numeric_compress(internal); + + DROP FUNCTION gbt_numeric_consistent(internal,numeric,int2); + + DROP OPERATOR CLASS gist_bytea_ops; + + DROP FUNCTION gbt_bytea_same(internal, internal, internal); + + DROP FUNCTION gbt_bytea_union(bytea, internal); + + DROP FUNCTION gbt_bytea_picksplit(internal, internal); + + DROP FUNCTION gbt_bytea_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bytea_compress(internal); + + DROP FUNCTION gbt_bytea_consistent(internal,bytea,int2); + + DROP OPERATOR CLASS gist_bpchar_ops; + + DROP OPERATOR CLASS gist_text_ops; + + DROP FUNCTION gbt_text_same(internal, internal, internal); + + DROP FUNCTION gbt_text_union(bytea, internal); + + DROP FUNCTION gbt_text_picksplit(internal, internal); + + DROP FUNCTION gbt_text_penalty(internal,internal,internal); + + DROP FUNCTION gbt_bpchar_compress(internal); + + DROP FUNCTION gbt_text_compress(internal); + + DROP FUNCTION gbt_bpchar_consistent(internal,bpchar,int2); + + DROP FUNCTION gbt_text_consistent(internal,text,int2); + + DROP OPERATOR CLASS gist_macaddr_ops; + + DROP FUNCTION gbt_macad_same(internal, internal, internal); + + DROP FUNCTION gbt_macad_union(bytea, internal); + + DROP FUNCTION gbt_macad_picksplit(internal, internal); + + DROP FUNCTION gbt_macad_penalty(internal,internal,internal); + + DROP FUNCTION gbt_macad_compress(internal); + + DROP FUNCTION gbt_macad_consistent(internal,macaddr,int2); + + DROP OPERATOR CLASS gist_cash_ops; + + DROP FUNCTION gbt_cash_same(internal, internal, internal); + + DROP FUNCTION gbt_cash_union(bytea, internal); + + DROP FUNCTION gbt_cash_picksplit(internal, internal); + + DROP FUNCTION gbt_cash_penalty(internal,internal,internal); + + DROP FUNCTION gbt_cash_compress(internal); + + DROP FUNCTION gbt_cash_consistent(internal,money,int2); + + DROP OPERATOR CLASS gist_interval_ops; + + DROP FUNCTION gbt_intv_same(internal, internal, internal); + + DROP FUNCTION gbt_intv_union(bytea, internal); + + DROP FUNCTION gbt_intv_picksplit(internal, internal); + + DROP FUNCTION gbt_intv_penalty(internal,internal,internal); + + DROP FUNCTION gbt_intv_decompress(internal); + + DROP
