Re: [Pharo-dev] Code colors with dark theme (out of box)

2017-04-27 Thread Henrik Nergaard 
>Looks like changing one color changes back to the default theme coloring ... 
>but I wonder why it
changes the theme when I manipulate only the comment color?
SHPreferences commentStyle class. "SHStyleElement"

Changing any attribue in a ShStyleElement object also sends `SHPreferences 
applyStyle`. This method creates a new styletable based on the SHStyleElement 
objects in the Group class variable in SHPreferences. These object get their 
initial color and emphasis from the the class variable CustomStyleTable also in 
SHPreferences, which is inited from #defaultStyleTable (blueTheme), and this is 
why the whole theme changes when you only change one color.

>Is this a bug?

Probably.


Best regards,

Henrik



Fra: Pharo-dev <pharo-dev-boun...@lists.pharo.org> på vegne av Torsten Bergmann 
<asta...@gmx.de>
Sendt: 27. april 2017 11:51:12
Til: pharo-dev@lists.pharo.org
Emne: Re: [Pharo-dev] Code colors with dark theme (out of box)

Thanks Henrik and Cyril. I now tried on a second machine and the default looks 
fine.

I checked and there was a setting left that changes the color for Smalltalk 
"comments" only:

   SHPreferences commentStyle color: (Color r: 0.06 g: 0.358 b: 0.06 alpha: 1.0)

from grey (Pharo light theme) to greenish (like VisualStudio comments). Because 
this looks
more professional and aligns with Eclipse/VisualStudio/... and others.

Looks like changing one color changes back to the default theme coloring ... 
but I wonder why it
changes the theme when I manipulate only the comment color?

Is this a bug?

Thanks
T.


Gesendet: Donnerstag, 27. April 2017 um 11:33 Uhr
Von: "Henrik Nergaard" <draag...@outlook.com>
An: "Pharo Development List" <pharo-dev@lists.pharo.org>
Betreff: Re: [Pharo-dev] Code colors with dark theme (out of box)

Tested  with a clean 60471  and the correct code theme is used for me (primary 
white text color).

What are these values for you:



--
Smalltalk ui theme. "a Pharo3DarkTheme"
SHTextStylerST80 styleTable = Smalltalk ui theme shStyleTable.  "true"
SHRBTextStyler styleTable = Smalltalk ui theme shStyleTable  "true"
--

My guess is that you have some theme setting that changed just the code color 
back to the default theme coloring.

Best regards,
Henrik





Fra: Pharo-dev <pharo-dev-boun...@lists.pharo.org> på vegne av Torsten Bergmann 
<asta...@gmx.de>
Sendt: 27. april 2017 10:07:42
Til: Pharo Development List
Emne: [Pharo-dev] Code colors with dark theme (out of box)

The damn deal might be done to switch Pharo 6 now to the dark theme - but my 
impression
is that the way we provide it now lets say is "not very comfortable".

When
 - opening Pharo 6.0 Latest update: #60471 (as of today)
 - opening a new Nautilus browser

the code color settings are unreadable (see screenshot).

I suggest to use black text on black background in the future to improve the 
situation
even further ;)

Are there already any bugs to have a better color code scheme for the dark 
theme?

Have fun
T.

Re: [Pharo-dev] Code colors with dark theme (out of box)

2017-04-27 Thread Torsten Bergmann 

Thanks Henrik and Cyril. I now tried on a second machine and the default looks fine.
 
I checked and there was a setting left that changes the color for Smalltalk "comments" only:

 

   SHPreferences commentStyle color: (Color r: 0.06 g: 0.358 b: 0.06 alpha: 1.0)

from grey (Pharo light theme) to greenish (like VisualStudio comments). Because this looks
more professional and aligns with Eclipse/VisualStudio/... and others.

Looks like changing one color changes back to the default theme coloring ... but I wonder why it
changes the theme when I manipulate only the comment color? 

Is this a bug?

Thanks

T.
 

 

Gesendet: Donnerstag, 27. April 2017 um 11:33 Uhr
Von: "Henrik Nergaard" <draag...@outlook.com>
An: "Pharo Development List" <pharo-dev@lists.pharo.org>
Betreff: Re: [Pharo-dev] Code colors with dark theme (out of box)





Tested  with a clean 60471  and the correct code theme is used for me (primary white text color).

What are these values for you:

 

-- 

Smalltalk ui theme. "a Pharo3DarkTheme" 

SHTextStylerST80 styleTable = Smalltalk ui theme shStyleTable.  "true" 

SHRBTextStyler styleTable = Smalltalk ui theme shStyleTable  "true"

--

 

My guess is that you have some theme setting that changed just the code color back to the default theme coloring.

 

Best regards,

Henrik
 

 



Fra: Pharo-dev <pharo-dev-boun...@lists.pharo.org> på vegne av Torsten Bergmann <asta...@gmx.de>
Sendt: 27. april 2017 10:07:42
Til: Pharo Development List
Emne: [Pharo-dev] Code colors with dark theme (out of box)

 



The damn deal might be done to switch Pharo 6 now to the dark theme - but my impression
is that the way we provide it now lets say is "not very comfortable".

When
 - opening Pharo 6.0 Latest update: #60471 (as of today)
 - opening a new Nautilus browser

the code color settings are unreadable (see screenshot).

I suggest to use black text on black background in the future to improve the situation
even further ;)

Are there already any bugs to have a better color code scheme for the dark theme?

Have fun
T.

Re: [Pharo-dev] Code colors with dark theme (out of box)

2017-04-27 Thread Henrik Nergaard 
Tested  with a clean 60471  and the correct code theme is used for me (primary 
white text color).

What are these values for you:

--
Smalltalk ui theme. "a Pharo3DarkTheme"
SHTextStylerST80 styleTable = Smalltalk ui theme shStyleTable.  "true"
SHRBTextStyler styleTable = Smalltalk ui theme shStyleTable  "true"
--

My guess is that you have some theme setting that changed just the code color 
back to the default theme coloring.

Best regards,
Henrik



Fra: Pharo-dev  på vegne av Torsten Bergmann 

Sendt: 27. april 2017 10:07:42
Til: Pharo Development List
Emne: [Pharo-dev] Code colors with dark theme (out of box)

The damn deal might be done to switch Pharo 6 now to the dark theme - but my 
impression
is that the way we provide it now lets say is "not very comfortable".

When
 - opening Pharo 6.0 Latest update: #60471 (as of today)
 - opening a new Nautilus browser

the code color settings are unreadable (see screenshot).

I suggest to use black text on black background in the future to improve the 
situation
even further ;)

Are there already any bugs to have a better color code scheme for the dark 
theme?

Have fun
T.

Re: [Pharo-dev] Code colors with dark theme (out of box)

2017-04-27 Thread Cyril Ferlicot D. 
On 27/04/2017 10:07, Torsten Bergmann wrote:
> The damn deal might be done to switch Pharo 6 now to the dark theme - but my 
> impression
> is that the way we provide it now lets say is "not very comfortable".
> 
> When 
>  - opening Pharo 6.0 Latest update: #60471 (as of today) 
>  - opening a new Nautilus browser
> 
> the code color settings are unreadable (see screenshot).
> 
> I suggest to use black text on black background in the future to improve the 
> situation 
> even further ;)
> 
> Are there already any bugs to have a better color code scheme for the dark 
> theme?
> 
> Have fun
> T. 
> 

Hum... I do not have this problem: https://puu.sh/vxH5r/e1d08b0639.png
I just opened a fresh image and Nautilus.

-- 
Cyril Ferlicot
https://ferlicot.fr

http://www.synectique.eu
2 rue Jacques Prévert 01,
59650 Villeneuve d'ascq France



signature.asc
Description: OpenPGP digital signature