date:20060826

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Andi Gutmans

I don't think it helps. It won't inline these functions in most cases
anyway, and having or not having a symbol shouldn't make a difference.
I'd prefer to stick to our standards and keep all extensions the same. Who
knows if/when we'll want to play around with the symbols also. It could come
in handly with dlls.

Andi 

> -Original Message-
> From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED] On Behalf Of 
> Ilia Alshanetsky
> Sent: Saturday, August 26, 2006 9:59 AM
> To: Andi Gutmans
> Cc: 'Nuno Lopes'; php-cvs@lists.php.net
> Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c 
> php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c 
> php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy 
> php_tidy.h tidy.c /ext/zlib php_zlib.h zlib.c zlib_fopen_wrapper.c 
> 
> Andi,
> 
> I think the idea here was to minimize memory utilization and 
> allow the compiler to optimize the code better, something 
> that having functions defined as statics appears to help with.
> 
> 
> On 26-Aug-06, at 11:30 AM, Andi Gutmans wrote:
> 
> > Why is this important? We never defined these as static. As long as 
> > you move them to the .c file (for whatever reason you have 
> that might 
> > be
> > justified)
> > you really don't have to define them as static IMO.
> 
> Ilia Alshanetsky
> 
> 
> 
> 

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Ilia Alshanetsky


Andi,

I think the idea here was to minimize memory utilization and allow  
the compiler to optimize the code better, something that having  
functions defined as statics appears to help with.



On 26-Aug-06, at 11:30 AM, Andi Gutmans wrote:

Why is this important? We never defined these as static. As long as  
you move
them to the .c file (for whatever reason you have that might be  
justified)

you really don't have to define them as static IMO.


Ilia Alshanetsky

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Andi Gutmans

Why is this important? We never defined these as static. As long as you move
them to the .c file (for whatever reason you have that might be justified)
you really don't have to define them as static IMO. 

> -Original Message-
> From: Nuno Lopes [mailto:[EMAIL PROTECTED] 
> Sent: Monday, August 14, 2006 1:08 PM
> To: php-cvs@lists.php.net
> Subject: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c 
> php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c 
> php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy 
> php_tidy.h tidy.c /ext/zlib php_zlib.h zlib.c zlib_fopen_wrapper.c 
> 
> nlopess   Mon Aug 14 20:08:18 2006 UTC
> 
>   Modified files:  (Branch: PHP_5_2)
> /php-src/ext/bz2  bz2.c php_bz2.h 
> /php-src/ext/ctypectype.c php_ctype.h 
> /php-src/ext/json json.c php_json.h 
> /php-src/ext/pspell   php_pspell.h pspell.c 
> /php-src/ext/tidy php_tidy.h tidy.c 
> /php-src/ext/zlib php_zlib.h zlib.c zlib_fopen_wrapper.c 
>   Log:
>   move static declaration to *.c files
>   mroe static/const keywording
>   

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

2006-08-26 Thread Andi Gutmans

I missed the discussion about this. Is there a bug in VCWD_REALPATH()? Can
you explain?

Thanks. 

> -Original Message-
> From: Pierre-Alain Joye [mailto:[EMAIL PROTECTED] 
> Sent: Saturday, August 26, 2006 5:24 AM
> To: php-cvs@lists.php.net
> Subject: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c 
> 
> pajoyeSat Aug 26 12:23:43 2006 UTC
> 
>   Modified files:  (Branch: PHP_5_2)
> /php-src/ext/zip  php_zip.c 
>   Log:
>   - don't rely/use VCWD_REALPATH, use expand_filepath instead
> NB: that'd to be true for all this VCWD mess
>   
>   
> http://cvs.php.net/viewvc.cgi/php-src/ext/zip/php_zip.c?r1=1.1
> .2.7&r2=1.1.2.8&diff_format=u
> Index: php-src/ext/zip/php_zip.c
> diff -u php-src/ext/zip/php_zip.c:1.1.2.7 
> php-src/ext/zip/php_zip.c:1.1.2.8
> --- php-src/ext/zip/php_zip.c:1.1.2.7 Fri Aug 25 16:03:00 2006
> +++ php-src/ext/zip/php_zip.c Sat Aug 26 12:23:43 2006
> @@ -16,7 +16,7 @@
>
> +-
> -+
>  */
>  
> -/* $Id: php_zip.c,v 1.1.2.7 2006/08/25 16:03:00 pajoye Exp $ */
> +/* $Id: php_zip.c,v 1.1.2.8 2006/08/26 12:23:43 pajoye Exp $ */
>  
>  #ifdef HAVE_CONFIG_H
>  #include "config.h"
> @@ -905,7 +905,7 @@
>   RETURN_FALSE;
>   }
>  
> - if (!VCWD_REALPATH(filename, resolved_path)) {
> + if (!expand_filepath(filename, resolved_path TSRMLS_CC)) {
>   RETURN_FALSE;
>   }
>  
> @@ -1982,7 +1982,7 @@
>   php_info_print_table_start();
>  
>   php_info_print_table_row(2, "Zip", "enabled");
> - php_info_print_table_row(2, "Extension Version","$Id: 
> php_zip.c,v 1.1.2.7 2006/08/25 16:03:00 pajoye Exp $");
> + php_info_print_table_row(2, "Extension Version","$Id: 
> php_zip.c,v 
> +1.1.2.8 2006/08/26 12:23:43 pajoye Exp $");
>   php_info_print_table_row(2, "Zip version", "1.7.1");
>   php_info_print_table_row(2, "Libzip version", "0.7.1");
>  
> 
> --
> PHP CVS Mailing List (http://www.php.net/) To unsubscribe, 
> visit: http://www.php.net/unsub.php
> 

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: php-src(PHP_4_4) / NEWS /ext/standard aggregation.c /ext/standard/tests/aggregation bug37812.phpt

2006-08-26 Thread Hannes Magnusson

bjori   Sat Aug 26 14:15:07 2006 UTC

  Added files: (Branch: PHP_4_4)
/php-src/ext/standard/tests/aggregation bug37812.phpt 

  Modified files:  
/php-src/ext/standard   aggregation.c 
/php-srcNEWS 
  Log:
  Fixed bug #37812 aggregate_methods_by_list fails to take certain methods
  Add test
  
  
  
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/aggregation.c?r1=1.11.4.7.4.1&r2=1.11.4.7.4.2&diff_format=u
Index: php-src/ext/standard/aggregation.c
diff -u php-src/ext/standard/aggregation.c:1.11.4.7.4.1 
php-src/ext/standard/aggregation.c:1.11.4.7.4.2
--- php-src/ext/standard/aggregation.c:1.11.4.7.4.1 Sun Jan  1 13:46:57 2006
+++ php-src/ext/standard/aggregation.c  Sat Aug 26 14:15:06 2006
@@ -16,7 +16,7 @@
+--+
 */
 
-/* $Id: aggregation.c,v 1.11.4.7.4.1 2006/01/01 13:46:57 sniper Exp $ */
+/* $Id: aggregation.c,v 1.11.4.7.4.2 2006/08/26 14:15:06 bjori Exp $ */
 
 #include "php.h"
 #include "basic_functions.h"
@@ -146,7 +146,7 @@
 */
zend_hash_internal_pointer_reset(Z_ARRVAL_P(list_hash));
while (zend_hash_get_current_key_ex(Z_ARRVAL_P(list_hash), 
&func_name, &func_name_len, &num_key, 0, NULL) == HASH_KEY_IS_STRING) {
-   if (!strncmp(func_name, from_ce->name, 
MIN(func_name_len-1, from_ce->name_length)) ||
+   if (!strncmp(func_name, from_ce->name, 
MAX(func_name_len-1, from_ce->name_length)) ||
func_name[0] == '_' ||
zend_hash_find(&from_ce->function_table, 
func_name, func_name_len, (void**)&function) == FAILURE) {
zend_hash_move_forward(Z_ARRVAL_P(list_hash));
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.1247.2.920.2.159&r2=1.1247.2.920.2.160&diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.1247.2.920.2.159 php-src/NEWS:1.1247.2.920.2.160
--- php-src/NEWS:1.1247.2.920.2.159 Thu Aug 24 08:42:16 2006
+++ php-src/NEWSSat Aug 26 14:15:07 2006
@@ -5,6 +5,8 @@
   stream wrappers). (Tony)
 - Fixed bug #38378 (wddx_serialize_value() generates no wellformed xml). 
   (sj at sjaensch dot org, grzegorz dot nosek at netart dot pl, Tony).
+- Fixed bug #37812 (aggregate_methods_by_list fails to take certain methods).
+  (Hannes)

 17 Aug 2006, Version 4.4.4
 - Fixed memory_limit on 64bit systems. (Stefan E.)

http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/aggregation/bug37812.phpt?view=markup&rev=1.1
Index: php-src/ext/standard/tests/aggregation/bug37812.phpt
+++ php-src/ext/standard/tests/aggregation/bug37812.phpt

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: php-src /ext/zip php_zip.c

2006-08-26 Thread Pierre-Alain Joye

pajoye  Sat Aug 26 12:29:59 2006 UTC

  Modified files:  
/php-src/ext/zipphp_zip.c 
  Log:
  - MFB: don't rely/use VCWD_REALPATH, use expand_filepath instead
NB: that'd to be true for all this VCWD mess
  
  
http://cvs.php.net/viewvc.cgi/php-src/ext/zip/php_zip.c?r1=1.9&r2=1.10&diff_format=u
Index: php-src/ext/zip/php_zip.c
diff -u php-src/ext/zip/php_zip.c:1.9 php-src/ext/zip/php_zip.c:1.10
--- php-src/ext/zip/php_zip.c:1.9   Fri Aug 25 16:03:50 2006
+++ php-src/ext/zip/php_zip.c   Sat Aug 26 12:29:59 2006
@@ -16,7 +16,7 @@
   +--+
 */
 
-/* $Id: php_zip.c,v 1.9 2006/08/25 16:03:50 pajoye Exp $ */
+/* $Id: php_zip.c,v 1.10 2006/08/26 12:29:59 pajoye Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -882,7 +882,7 @@
RETURN_FALSE;
}
 
-   if (!VCWD_REALPATH(filename, resolved_path)) {
+   if(!expand_filepath(filename, resolved_path TSRMLS_CC)) {
RETURN_FALSE;
}
 
@@ -1956,7 +1956,7 @@
php_info_print_table_start();
 
php_info_print_table_row(2, "Zip", "enabled");
-   php_info_print_table_row(2, "Extension Version","$Id: php_zip.c,v 1.9 
2006/08/25 16:03:50 pajoye Exp $");
+   php_info_print_table_row(2, "Extension Version","$Id: php_zip.c,v 1.10 
2006/08/26 12:29:59 pajoye Exp $");
php_info_print_table_row(2, "Zip version", "1.7.1");
php_info_print_table_row(2, "Libzip version", "0.7.1");
 

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

2006-08-26 Thread Pierre-Alain Joye

pajoye  Sat Aug 26 12:23:43 2006 UTC

  Modified files:  (Branch: PHP_5_2)
/php-src/ext/zipphp_zip.c 
  Log:
  - don't rely/use VCWD_REALPATH, use expand_filepath instead
NB: that'd to be true for all this VCWD mess
  
  
http://cvs.php.net/viewvc.cgi/php-src/ext/zip/php_zip.c?r1=1.1.2.7&r2=1.1.2.8&diff_format=u
Index: php-src/ext/zip/php_zip.c
diff -u php-src/ext/zip/php_zip.c:1.1.2.7 php-src/ext/zip/php_zip.c:1.1.2.8
--- php-src/ext/zip/php_zip.c:1.1.2.7   Fri Aug 25 16:03:00 2006
+++ php-src/ext/zip/php_zip.c   Sat Aug 26 12:23:43 2006
@@ -16,7 +16,7 @@
   +--+
 */
 
-/* $Id: php_zip.c,v 1.1.2.7 2006/08/25 16:03:00 pajoye Exp $ */
+/* $Id: php_zip.c,v 1.1.2.8 2006/08/26 12:23:43 pajoye Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -905,7 +905,7 @@
RETURN_FALSE;
}
 
-   if (!VCWD_REALPATH(filename, resolved_path)) {
+   if (!expand_filepath(filename, resolved_path TSRMLS_CC)) {
RETURN_FALSE;
}
 
@@ -1982,7 +1982,7 @@
php_info_print_table_start();
 
php_info_print_table_row(2, "Zip", "enabled");
-   php_info_print_table_row(2, "Extension Version","$Id: php_zip.c,v 
1.1.2.7 2006/08/25 16:03:00 pajoye Exp $");
+   php_info_print_table_row(2, "Extension Version","$Id: php_zip.c,v 
1.1.2.8 2006/08/26 12:23:43 pajoye Exp $");
php_info_print_table_row(2, "Zip version", "1.7.1");
php_info_print_table_row(2, "Libzip version", "0.7.1");
 

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: CVSROOT / avail

2006-08-26 Thread Pierre-Alain Joye

pajoye  Sat Aug 26 11:03:00 2006 UTC

  Modified files:  
/CVSROOTavail 
  Log:
  - Tom H. karma for pear Audio_CAPTCHA
  
  
http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1171&r2=1.1172&diff_format=u
Index: CVSROOT/avail
diff -u CVSROOT/avail:1.1171 CVSROOT/avail:1.1172
--- CVSROOT/avail:1.1171Wed Aug 23 17:57:14 2006
+++ CVSROOT/avail   Sat Aug 26 11:03:00 2006
@@ -346,6 +346,7 @@
 avail|ahayes|pear/Validate,peardoc
 avail|mahono|pear/LiveUser,pear/LiveUser_Admin
 avail|xolphin|pear/Validate
+avail|tommeh|pear/Audio_CAPTCHA
 
 # Curl modules
 
avail|bagder,sterling,crisb,linus_nielsen|curl,curl-cpp,curl-java,curl-perl,curl-php,curl-www

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

[PHP-CVS] cvs: php-src(PHP_4_4) / NEWS /ext/standard aggregation.c /ext/standard/tests/aggregation bug37812.phpt

[PHP-CVS] cvs: php-src /ext/zip php_zip.c

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

[PHP-CVS] cvs: CVSROOT / avail

8 matches

Site Navigation

Mail list logo

Footer information