Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/TSRM/acconfig.h branches/PHP_5_4/TSRM/build.mk branches/PHP_5_4/TSRM/configure.in branches/PHP_5_4/Zend/acconfig.h branches/PHP_5_4/Zend/build.mk bran
Hi, On Tue, 2011-05-17 at 13:24 -0700, Rasmus Lerdorf wrote: It doesn't seem likely that an autoconf change could have caused this. There were no code changes involved in that patch. Have you verified that this broke it by isolating this change? Indeed it wasn't autoconf. The commit also included the change of the version number in configure.in -#define PHP_VERSION 5.3.99-dev -#define PHP_VERSION_ID 50399 +#define PHP_VERSION 5.5.0-dev +#define PHP_VERSION_ID 50500 mysqli includes a version check #if PHP_VERSION_ID = 50400 which enabled broken code. We're working on a proper fix for this. johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/TSRM/acconfig.h branches/PHP_5_4/TSRM/build.mk branches/PHP_5_4/TSRM/configure.in branches/PHP_5_4/Zend/acconfig.h branches/PHP_5_4/Zend/build.mk bran
On 05/18/2011 02:25 AM, Johannes Schlüter wrote: Hi, On Tue, 2011-05-17 at 13:24 -0700, Rasmus Lerdorf wrote: It doesn't seem likely that an autoconf change could have caused this. There were no code changes involved in that patch. Have you verified that this broke it by isolating this change? Indeed it wasn't autoconf. The commit also included the change of the version number in configure.in -#define PHP_VERSION 5.3.99-dev -#define PHP_VERSION_ID 50399 +#define PHP_VERSION 5.5.0-dev +#define PHP_VERSION_ID 50500 mysqli includes a version check #if PHP_VERSION_ID= 50400 which enabled broken code. We're working on a proper fix for this. I thought you were testing the 5.4 branch. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/TSRM/acconfig.h branches/PHP_5_4/TSRM/build.mk branches/PHP_5_4/TSRM/configure.in branches/PHP_5_4/Zend/acconfig.h branches/PHP_5_4/Zend/build.mk bran
Hi,
On Mon, 2011-05-16 at 00:14 +, Rasmus Lerdorf wrote:
rasmus Mon, 16 May 2011 00:14:47 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=311067
Log:
Get rid of autoconf warnings
looks like this broke something. I'm not really sure what. mysqli tests
now fail massively. For ext/mysqli/tests/mysqli_warning_count.phpt
(randomly picked) gdb shows this:
Breakpoint 1, _zend_bailout (
filename=0xee4c28 php-src/trunk/main/main.c, lineno=1068) at
php-src/trunk/Zend/zend.c:847
847 if (!EG(bailout)) {
(gdb) bt
#0 _zend_bailout (
filename=0xee4c28 php-src/trunk/main/main.c, lineno=1068) at
php-src/trunk/Zend/zend.c:847
#1 0x009c7bce in php_error_cb (type=4096,
error_filename=0xf93fe0
php-src/trunk/ext/mysqli/tests/mysqli_warning_count.phpt, error_lineno=19,
format=0xf03aa0 Argument %d passed to %s%s%s() must %s%s, %s%s given,
args=0xfd7fffdfdc00)
at php-src/trunk/main/main.c:1068
#2 0x0080703f in soap_error_handler (error_num=4096,
error_filename=0xf93fe0
php-src/trunk/ext/mysqli/tests/mysqli_warning_count.phpt, error_lineno=19,
format=0xf03aa0 Argument %d passed to %s%s%s() must %s%s, %s%s given,
args=0xfd7fffdfdd80)
at php-src/trunk/ext/soap/soap.c:2098
#3 0x00a4df8f in zend_error (type=4096,
format=0xf03aa0 Argument %d passed to %s%s%s() must %s%s, %s%s given)
at php-src/trunk/Zend/zend.c:1038
#4 0x00a856d8 in zend_verify_arg_error (error_type=4096,
zf=0x1135d70, arg_num=1, need_msg=0xf03a26 be an instance of ,
need_kind=0xfc6220 mysqli, given_msg=0xefdc78 null,
given_kind=0xf03a3c )
at php-src/trunk/Zend/zend_execute.c:595
#5 0x00a8a4ec in zend_verify_arg_type (zf=0x1135d70, arg_num=1,
arg=0x13d54a0, fetch_type=0)
at php-src/trunk/Zend/zend_execute.c:627
[...]
While the current call is
@mysqli_warning_count()
which should complain about a wrong arg count but it tries to verify the
type of an (non existing) argument. valgrind shows two leaks but no
corruption or such. This worked with svn rev. 311066.
Any idea what part of the change might have caused this?
johannes
Changed paths:
D php/php-src/branches/PHP_5_4/TSRM/acconfig.h
U php/php-src/branches/PHP_5_4/TSRM/build.mk
U php/php-src/branches/PHP_5_4/TSRM/configure.in
D php/php-src/branches/PHP_5_4/Zend/acconfig.h
U php/php-src/branches/PHP_5_4/Zend/build.mk
U php/php-src/branches/PHP_5_4/Zend/configure.in
D php/php-src/branches/PHP_5_4/acconfig.h.in
U php/php-src/branches/PHP_5_4/build/build.mk
U php/php-src/branches/PHP_5_4/build/build2.mk
U php/php-src/branches/PHP_5_4/configure.in
D php/php-src/trunk/TSRM/acconfig.h
U php/php-src/trunk/TSRM/build.mk
U php/php-src/trunk/TSRM/configure.in
D php/php-src/trunk/Zend/acconfig.h
U php/php-src/trunk/Zend/build.mk
U php/php-src/trunk/Zend/configure.in
D php/php-src/trunk/acconfig.h.in
U php/php-src/trunk/build/build.mk
U php/php-src/trunk/build/build2.mk
U php/php-src/trunk/configure.in
U php/php-src/trunk/main/php_version.h
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/TSRM/acconfig.h branches/PHP_5_4/TSRM/build.mk branches/PHP_5_4/TSRM/configure.in branches/PHP_5_4/Zend/acconfig.h branches/PHP_5_4/Zend/build.mk bran
On 05/17/2011 01:18 PM, Johannes Schlüter wrote:
Hi,
On Mon, 2011-05-16 at 00:14 +, Rasmus Lerdorf wrote:
rasmus Mon, 16 May 2011 00:14:47 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=311067
Log:
Get rid of autoconf warnings
looks like this broke something. I'm not really sure what. mysqli tests
now fail massively. For ext/mysqli/tests/mysqli_warning_count.phpt
(randomly picked) gdb shows this:
Breakpoint 1, _zend_bailout (
filename=0xee4c28 php-src/trunk/main/main.c, lineno=1068) at
php-src/trunk/Zend/zend.c:847
847 if (!EG(bailout)) {
(gdb) bt
#0 _zend_bailout (
filename=0xee4c28 php-src/trunk/main/main.c, lineno=1068) at
php-src/trunk/Zend/zend.c:847
#1 0x009c7bce in php_error_cb (type=4096,
error_filename=0xf93fe0
php-src/trunk/ext/mysqli/tests/mysqli_warning_count.phpt, error_lineno=19,
format=0xf03aa0 Argument %d passed to %s%s%s() must %s%s, %s%s given,
args=0xfd7fffdfdc00)
at php-src/trunk/main/main.c:1068
It doesn't seem likely that an autoconf change could have caused this.
There were no code changes involved in that patch. Have you verified
that this broke it by isolating this change?
-Rasmus
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
