Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt
Hi Stas,
this bug was really mysqli@mysqlnd. No other tests test this, this is
why we were not able to catch this before. Therefore, it should be
enabled also for libmysql, because it checks right behavior. It's about
regression testing, and if libmysql fails someday on this, we should be
able to catch it.
Andrey
On 09/06/2011 07:13 AM, Stanislav Malyshev wrote:
stas Tue, 06 Sep 2011 05:13:47 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=316203
Log:
this tests looks mysqlnd only
Changed paths:
U php/php-src/branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt
U php/php-src/trunk/ext/mysqli/tests/bug55582.phpt
Modified: php/php-src/branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt
===
--- php/php-src/branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt 2011-09-06
05:04:37 UTC (rev 316202)
+++ php/php-src/branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt 2011-09-06
05:13:47 UTC (rev 316203)
@@ -5,6 +5,7 @@
require_once('skipif.inc');
require_once('skipifconnectfailure.inc');
require_once(connect.inc);
+if(!$IS_MYSQLND) die(skip This bug is for mysqlnd only);
?
--FILE--
?php
@@ -38,4 +39,4 @@
int(0)
NULL
int(1)
-done
\ No newline at end of file
+done
Modified: php/php-src/trunk/ext/mysqli/tests/bug55582.phpt
===
--- php/php-src/trunk/ext/mysqli/tests/bug55582.phpt2011-09-06 05:04:37 UTC
(rev 316202)
+++ php/php-src/trunk/ext/mysqli/tests/bug55582.phpt2011-09-06 05:13:47 UTC
(rev 316203)
@@ -5,6 +5,7 @@
require_once('skipif.inc');
require_once('skipifconnectfailure.inc');
require_once(connect.inc);
+if(!$IS_MYSQLND) die(skip This bug is for mysqlnd only);
?
--FILE--
?php
@@ -38,4 +39,4 @@
int(0)
NULL
int(1)
-done
\ No newline at end of file
+done
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt
Hi! On 9/6/11 12:28 AM, Andrey Hristov wrote: this bug was really mysqli@mysqlnd. No other tests test this, this is why we were not able to catch this before. Therefore, it should be enabled also for libmysql, because it checks right behavior. It's about regression testing, and if libmysql fails someday on this, we should be able to catch it. This behavior (specifically, returning number of rows after last fetch) was never part of libmysql, was never documented in mysql docs and is new and unique for mysqlnd. What exactly is the use to enable this test for libmysql - just generate yet another failure that never will be fixed to pollute our test results and make legitimate failures harder to spot? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt
On 09/06/2011 09:38 AM, Stas Malyshev wrote: Hi! On 9/6/11 12:28 AM, Andrey Hristov wrote: this bug was really mysqli@mysqlnd. No other tests test this, this is why we were not able to catch this before. Therefore, it should be enabled also for libmysql, because it checks right behavior. It's about regression testing, and if libmysql fails someday on this, we should be able to catch it. This behavior (specifically, returning number of rows after last fetch) was never part of libmysql, was never documented in mysql docs and is new and unique for mysqlnd. What exactly is the use to enable this test for libmysql - just generate yet another failure that never will be fixed to pollute our test results and make legitimate failures harder to spot? no, it's about consistency, which you want. mysqlnd should behave like libmysql, and it is a test that can test it. What libmysql returns in filtered in mysqli, mysqli_num_rows() is a direct wrapper around mysql_num_rows(), and this is what we test. Andrey -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt
Hi! On 9/6/11 1:24 AM, Andrey Hristov wrote: no, it's about consistency, which you want. mysqlnd should behave like libmysql, and it is a test that can test it. What libmysql returns in filtered in mysqli, mysqli_num_rows() is a direct wrapper around mysql_num_rows(), and this is what we test. Sorry, I don't understand. mysqlnd returns non-zero number of rows after last fetch, libmysql does not, and that's what you test for. Are you saying it's a bug in libmysql or mysqli driver that it doesn't return that number? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
