Re: [PHP] Re: why doesn't default values for this function work

[anders thoresson]

Change your logic here...

if($max_length == -1)

then you did not send a value for $max_length and act accordingly.

or

if(!($max_length == -1))

you did send a $max_length value and act accordingly.
But I want to make the same things, with some additions if $max_length is 
set. That's why I start with the check if($max_length  -1).

function secure_string($unsafe_string, $max_length = -1, $errormessage = 
Du har skrivit för många tecken.)
{
if($max_length  -1)
{
 do stuff that's have to be done when $max_length is set
}
do stuff that's have to be done wether $max_length is set or not
}

Is there really something wrong with this logic (since it doesn't work, it 
obvious is, but what)?

--
anders thoresson
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP] Re: why doesn't default values for this function work

[CPT John W. Holmes]

From: anders thoresson [EMAIL PROTECTED]
  I want the $max_length to be optional. With your solution it isn't? I
 thought I could make it optional by assigning a default value of -1, which
 would tell the function not to bother with max_length and continue the
 execution.

  All in all my function looks like this (crossing my fingers and hopes
that
 linewrap works this time):

 function secure_string($unsafe_string, $max_length = -1, $errormessage =
 Du har skrivit för många tecken.)
 {
  // verify that string isn't longer then $max_length, if $max_length is
set
  if ($max_length  -1)

Change your logic here...

if($max_length == -1)

then you did not send a value for $max_length and act accordingly.

or

if(!($max_length == -1))

you did send a $max_length value and act accordingly.

---John Holmes...


-- 
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP] Re: why doesn't default values for this function work

[anders thoresson]

function secure_string($unsafe_string, $max_length)
{
if(!is_int($max_length))
error(Variable max_length is not an integer. );
if (strlen($unsafe_string)  $max_length)
error(Too many characters.);
}
I want the $max_length to be optional. With your solution it isn't? I 
thought I could make it optional by assigning a default value of -1, which 
would tell the function not to bother with max_length and continue the 
execution.

All in all my function looks like this (crossing my fingers and hopes that 
linewrap works this time):

function secure_string($unsafe_string, $max_length = -1, $errormessage = 
Du har skrivit för många tecken.)
{
// verify that string isn't longer then $max_length, if $max_length is set
if ($max_length  -1)
{
 if (!is_int($max_length))
 {
  error(Variabeln max_length är inte en siffra.);
 }
 if (strlen($unsafe_string)  $max_length)
 {
  error($errormessage);
 }
}
// create array containing bad words
$badwords = array(;,--,select,drop,insert,xp_,delete);
$goodwords = array(:,-,choose,leave,add, ,remove);
// check for occurences of $badwords
for($i=0; $i7; $i++)
{
 $unsafe_string = str_replace($badwords[$i], 
$goodwords[$i],$unsafe_string);
}
$unsafe_string = AddSlashes($unsafe_string);
$unsafe_string = htmlentities($unsafe_string);
$unsafe_string = strip_tags($unsafe_string);
$unsafe_string = trim($unsafe_string);
Return $unsafe_string;
}

Are the last steps (AddSlashes through trim) overkill? I want to make it 
safe for mysql.

--
anders thoresson
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php