[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796316#action_12796316 ] Pradeep Kamath commented on PIG-1094: - +1 to PIG-1094_6.patch , patch committed - thanks Thejas! Here is the output of test-patch for the same: [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] [exec] Fix unit tests corresponding to source changes so far - Key: PIG-1094 URL: https://issues.apache.org/jira/browse/PIG-1094 Project: Pig Issue Type: Sub-task Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch, PIG-1094_5.patch, PIG-1094_6.patch The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793286#action_12793286 ] Pradeep Kamath commented on PIG-1094: - +1, PIG-1094_4.patch checked in, thanks Richard! Fix unit tests corresponding to source changes so far - Key: PIG-1094 URL: https://issues.apache.org/jira/browse/PIG-1094 Project: Pig Issue Type: Sub-task Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784343#action_12784343 ] Olga Natkovich commented on PIG-1094: - +1 Fix unit tests corresponding to source changes so far - Key: PIG-1094 URL: https://issues.apache.org/jira/browse/PIG-1094 Project: Pig Issue Type: Sub-task Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784355#action_12784355 ] Pradeep Kamath commented on PIG-1094: - PIG-1094_3.patch committed to load-store-redesign branch Fix unit tests corresponding to source changes so far - Key: PIG-1094 URL: https://issues.apache.org/jira/browse/PIG-1094 Project: Pig Issue Type: Sub-task Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782191#action_12782191 ] Pradeep Kamath commented on PIG-1094: - Thanks Richard - the incremental patch has been committed on load-store-redesign branch Fix unit tests corresponding to source changes so far - Key: PIG-1094 URL: https://issues.apache.org/jira/browse/PIG-1094 Project: Pig Issue Type: Sub-task Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-1094.patch, PIG-1094_2.patch The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12780312#action_12780312 ] Richard Ding commented on PIG-1094: --- The change of PIG-879 added the following failure cases: ||Testcase Class||Testcase Method||Cause|| |TestLoad|testLoadRemoteRel|local mode needs to be fixed| |TestLoad|testLoadRemoteRelScheme|local mode needs to be fixed| |TestLoad|testGlobChars|local mode needs to be fixed| Fix unit tests corresponding to source changes so far - Key: PIG-1094 URL: https://issues.apache.org/jira/browse/PIG-1094 Project: Pig Issue Type: Sub-task Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-1094.patch The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12780325#action_12780325 ] Olga Natkovich commented on PIG-1094: - We should fix the failures as part of the patch that caused them. Now that we have the baseline, we should make sure that we don't introduce any new failures. Fix unit tests corresponding to source changes so far - Key: PIG-1094 URL: https://issues.apache.org/jira/browse/PIG-1094 Project: Pig Issue Type: Sub-task Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-1094.patch The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779630#action_12779630 ] Pradeep Kamath commented on PIG-1094: - Patch committed - here is the list of test cases which still fail with the cause : ||Testcase Class||Testcase Method||Cause|| |TestAlgebraicEvalLocal|testGroupCountWithMultipleFields|local mode needs to be fixed| |TestAlgebraicEvalLocal|testSimpleCount|local mode needs to be fixed| |TestAlgebraicEvalLocal|testGroupCount|local mode needs to be fixed| |TestAlgebraicEvalLocal|testGroupReorderCount|local mode needs to be fixed| |TestAlgebraicEvalLocal|testGroupUniqueColumnCount|local mode needs to be fixed| |TestAlgebraicEvalLocal|testGroupDuplicateColumnCount|local mode needs to be fixed| |TestBinaryStorage|testBinaryStorageWithAsciiData|streaming needs to be fixed| |TestBinaryStorage|testBinaryStorageWithBinaryData|streaming needs to be fixed| |TestBZip|testBzipInPig|bzip support in PigStorage needs to be fixed| |TestBZip|testEmptyBzipInPig|bzip support in PigStorage needs to be fixed| |TestCombiner|testLocal|local mode needs to be fixed| |TestCommit|testCheckin1|order by needs to be fixed| |TestCommit|testCheckin2|order by needs to be fixed| |TestCounters|testMapOnly|Counter needs to be fixed (broken in hadoop 20.1 with new api?)| |TestCounters|testMapOnlyBinStorage|Counter needs to be fixed (broken in hadoop 20.1 with new api?)| |TestCounters|testMapReduceOnly|Counter needs to be fixed (broken in hadoop 20.1 with new api?)| |TestCounters|testMapReduceOnlyBinStorage|Counter needs to be fixed (broken in hadoop 20.1 with new api?)| |TestCounters|testMapCombineReduce|Counter needs to be fixed (broken in hadoop 20.1 with new api?)| |TestCounters|testMapCombineReduceBinStorage|Counter needs to be fixed (broken in hadoop 20.1 with new api?)| |TestCounters|testMultipleMRJobs|Counter needs to be fixed (broken in hadoop 20.1 with new api?)| |TestCounters|testLocal|Counter needs to be fixed (broken in hadoop 20.1 with new api?)| |TestEvalPipeline2|testLimitedSortWithDump|order by needs to be fixed| |TestEvalPipeline2|testLimitAfterSort|order by needs to be fixed| |TestEvalPipeline2|testLimitAfterSortDesc|order by needs to be fixed| |TestEvalPipeline2|testEmptySort|order by needs to be fixed| |TestEvalPipelineLocal|testFunctionInsideFunction|local mode needs to be fixed| |TestEvalPipelineLocal|testJoin|local mode needs to be fixed| |TestEvalPipelineLocal|testDriverMethod|local mode needs to be fixed| |TestEvalPipelineLocal|testMapLookup|local mode needs to be fixed| |TestEvalPipelineLocal|testBagFunctionWithFlattening|local mode needs to be fixed| |TestEvalPipelineLocal|testSortWithUDF|local mode needs to be fixed| |TestEvalPipelineLocal|testDistinct|local mode needs to be fixed| |TestEvalPipelineLocal|testNestedPlan|local mode needs to be fixed| |TestEvalPipelineLocal|testNestedPlanWithExpressionAssignment|local mode needs to be fixed| |TestEvalPipelineLocal|testLimit|local mode needs to be fixed| |TestEvalPipelineLocal|testComplexData|local mode needs to be fixed| |TestEvalPipelineLocal|testBinStorageDetermineSchema|local mode needs to be fixed| |TestEvalPipelineLocal|testProjectBag|local mode needs to be fixed| |TestEvalPipelineLocal|testBinStorageDetermineSchema2|local mode needs to be fixed| |TestEvalPipelineLocal|testCogroupWithInputFromGroup|local mode needs to be fixed| |TestEvalPipelineLocal|testUtf8Dump|local mode needs to be fixed| |TestEvalPipelineLocal|testMapUDF|local mode needs to be fixed| |TestEvalPipelineLocal|testLoadCtorArgs|local mode needs to be fixed| |TestEvalPipelineLocal|testNestedPlanForCloning|local mode needs to be fixed| |TestEvalPipelineLocal|testArithmeticCloning|local mode needs to be fixed| |TestEvalPipelineLocal|testExpressionReUse|local mode needs to be fixed| |TestEvalPipelineLocal|testIdentity|local mode needs to be fixed| |TestEvalPipeline|testSortWithUDF|order by needs to be fixed| |TestFinish|testFinishInMapLoc|local mode needs to be fixed| |TestFinish|testFinishInReduceLoc|local mode needs to be fixed| |TestForEachNestedPlanLocal|testInnerOrderBy|local node needs to be fixed| |TestForEachNestedPlanLocal|testInnerLimit|local node needs to be fixed| |TestFRJoin|testSortFRJoin|order by needs to be fixed| |TestGrunt|testKeepGoing|streaming needs to be fixed| |TestJoin|testDefaultJoin|local mode needs to be fixed| |TestJoin|testJoinSchema|local mode needs to be fixed| |TestJoin|testLeftOuterJoin|local mode needs to be fixed| |TestJoin|testRightOuterJoin|local mode needs to be fixed| |TestJoin|testFullOuterJoin|local mode needs to be fixed| |TestJoin|testJoinTupleFieldKey|local mode needs to be fixed| |TestJoin|testJoinNullTupleFieldKey|local mode needs to be fixed| |TestLocal2|testUnion1|local mode needs to be fixed| |TestLocal2|testUnion1WithNulls|local mode needs to be fixed| |TestLocal2|testUnion2|local mode needs to
[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far
[ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779235#action_12779235 ] Olga Natkovich commented on PIG-1094: - +1. Fix unit tests corresponding to source changes so far - Key: PIG-1094 URL: https://issues.apache.org/jira/browse/PIG-1094 Project: Pig Issue Type: Sub-task Reporter: Pradeep Kamath Assignee: Pradeep Kamath Attachments: PIG-1094.patch The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
