Re: [Pkg-javascript-devel] node-i18next-browser-languagedetector_6.1.8-2_sourceonly.changes ACCEPTED into unstable

2022-10-26 Thread Nicolas Mora

Hi,

Le 2022-10-26 à 11 h 09, Yadd a écrit :

Le Mercredi, Octobre 26, 2022 16:46 CEST, Nicolas Mora  
a écrit:

Hi,

mass-bug but manual fixes (even if I built some ephemeral tools here ;-))



Indeed,

but still, why are the patches marked as "Forwarded: not-needed"?

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] node-i18next-browser-languagedetector_6.1.8-2_sourceonly.changes ACCEPTED into unstable

2022-10-26 Thread Nicolas Mora

Hello,

Thanks for the mass fix Yadd,

Le 2022-10-26 à 08 h 50, Debian FTP Masters a écrit :



Accepted:

Format: 1.8
Date: Wed, 26 Oct 2022 14:28:39 +0200
Source: node-i18next-browser-languagedetector
Built-For-Profiles: nocheck
Architecture: source
Version: 6.1.8-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers 

Changed-By: Yadd 
Closes: 1022634
Changes:
  node-i18next-browser-languagedetector (6.1.8-2) unstable; urgency=medium
  .
* Team upload
[ Debian Janitor ]
* Apply multi-arch hints.
  + node-i18next-browser-languagedetector:
Add :any qualifier for nodejs dependency
  .
[ Yadd ]
* Add fix for rollup 3 (Closes: #1022634)


I had prepared a new package for rollup 3, but didn't push it, and your 
patch looks better.


I'm wondering though, why is the rollup 3 patch tagged as "Forwarded: 
not-needed"? Is the patch too specific for Debian?


/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] Rollup 3

2022-10-17 Thread Nicolas Mora

Le 2022-10-16 à 00 h 19, Yadd a écrit :
If I build using ollup --bundleConfigAsCjs -c, build fails with the 
following error:


[!] TypeError: nodeResolve is not a function


Hi, replace

   const nodeResolve = require('@rollup/plugin-node-resolve')

by

   const {nodeResolve} = require('@rollup/plugin-node-resolve')


Thanks, the build works now!

I'll upload my packages to experimental in the next days.

Also, you mentioned the package node-i18next-xhr-backend in the rollup-3 
build-dep list, this package has been removed from unstable last year 
since it is now replaced with node-i18next-http-backend, which does not 
uses rollup.


/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] Rollup 3

2022-10-15 Thread Nicolas Mora

Hello,

Le 2022-10-12 à 06 h 22, Yadd a écrit :

Hi all,

one of the main changes with rollup 3 is that it doesn't accept ES in 
rollup.config.js except if "type=module". Those package should rename 
their rollup.config.js into rollup.config.mjs.



I encounter several problems while migrating to rollup 3

# node-cross-fetch

If I rename rollup.config.js into rollup.config.mjs, I have build errors 
such as this:


[!] Error: Directory import '/usr/share/nodejs/rollup-plugin-terser' is 
not supported resolving ES modules imported from 
/share/node-cross-fetch/node-cross-fetch/rollup.config.mjs
Did you mean to import 
/usr/share/nodejs/rollup-plugin-terser/rollup-plugin-terser.js?


Although, if I keep rollup.config.js but use the command rollup 
--bundleConfigAsCjs -c, it builds succesfully


# node-i18next and node-i18next-browser-languagedetector

If I build using ollup --bundleConfigAsCjs -c, build fails with the 
following error:


[!] TypeError: nodeResolve is not a function
TypeError: nodeResolve is not a function
at Object. 
(/share/node-i18next-browser-languagedetector/node-i18next-browser-languagedetector/rollup.config-1665842115843.cjs:48:7)

at Module._compile (node:internal/modules/cjs/loader:1159:14)
at Object.Module._extensions..js 
(node:internal/modules/cjs/loader:1213:10)

at Module.load (node:internal/modules/cjs/loader:1037:32)
at Function.Module._load (node:internal/modules/cjs/loader:878:12)
at ModuleWrap. 
(node:internal/modules/esm/translators:169:29)

at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
at async Promise.all (index 0)
at ESMLoader.import (node:internal/modules/esm/loader:530:24)
at importModuleDynamicallyWrapper (node:internal/vm/module:438:15)

Does anyone know how to workaround these issues?

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


[Pkg-javascript-devel] Bug#1012212: node-react-audio-player: Intent to remove from Debian

2022-06-01 Thread Nicolas Mora
Package: node-react-audio-player
Version: 0.17.0-2
Severity: normal
X-Debbugs-Cc: pkg-javascript-de...@lists.alioth.debian.org

I intent to remove node-react-audio-player from the Debian archive, it has
originally been added to Debian to help build a bigger package.
But considering the amount of work to build this big package, I have cancelled
it. Therefore, node-react-audio-player has no real purpose in Debian, and
maintaining it with its dependencies upgrades is a waste of time.

/Nicolas

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


[Pkg-javascript-devel] Remove node-react-audio-player from Debian?

2022-05-28 Thread Nicolas Mora

Hello,

A few years ago, I packaged and uploaded node-react-audio-player because 
I needed it and some others to build another expected big package.


Then, after a long time of tries and failures, I realized the big 
package will most likely not be uploaded in Debian as is, there are too 
many javascript packages to create or upgrade, and it's probably not 
worth it.


Therefore, I think it's probably better to remove the package 
node-react-audio-player from Debian archive, since it has no purpose, 
except being downloaded itself, and its popcon score says no one cares, 
including me.


It has no reverse dependencies.

Unless someone wold like to keep this package, I'd start an ITR (Intent 
to remove) soon.


Any thoughts?

Thanks!

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] block request on js-team packages?

2022-01-27 Thread Nicolas Mora

Hello,

Le 2022-01-27 à 09 h 29, Andrius Merkys a écrit :


This is not limited to javascript packages. All my migrations seem to be
blocked as well no matter the team/language.


My bad, this makes it more even weird though...

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


[Pkg-javascript-devel] block request on js-team packages?

2022-01-27 Thread Nicolas Mora

Hello,

It seems that the last javascript packages uploaded to unstable can't 
migrate to testing due to a blocking request, for example:


https://tracker.debian.org/pkg/node-pbkdf2
https://tracker.debian.org/pkg/node-jose
https://tracker.debian.org/pkg/node-i18next

I don't see any information in the mailing lists, does anyone have 
information about that?


/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


[Pkg-javascript-devel] Bug#1002863: node-react-audio-player: FTBFS with webpack5: Error: Invalid webpack options

2021-12-31 Thread Nicolas Mora

Hello Ayoyimika,

I've updated the webpack patch for webpack 5. Now the build goes 
further, but it fails anyway:


make[1]: Entering directory '/<>'
webpack -p
internal/modules/cjs/loader.js:818
  throw err;
  ^

Error: Cannot find module 'import-local'
Require stack:
- /usr/share/nodejs/webpack-cli/bin/cli.js
- /usr/share/nodejs/webpack/bin/webpack.js
at Function.Module._resolveFilename 
(internal/modules/cjs/loader.js:815:15)

at Function.Module._load (internal/modules/cjs/loader.js:667:27)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object. (/usr/share/nodejs/webpack-cli/bin/cli.js:5:21)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js 
(internal/modules/cjs/loader.js:1027:10)

at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
'/usr/share/nodejs/webpack-cli/bin/cli.js',
'/usr/share/nodejs/webpack/bin/webpack.js'
  ]
}
make[1]: *** [debian/rules:11: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<>'
make: *** [debian/rules:8: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit 
status 2


I'll upload a new package to unstable with the new patch, let me know if 
you need further help.


/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


[Pkg-javascript-devel] Bug#1002863: node-react-audio-player: FTBFS with webpack5: Error: Invalid webpack options

2021-12-30 Thread Nicolas Mora

Hello,

Le 2021-12-30 à 06 h 22, Ayoyimika Ajibade a écrit :


We are starting to build against webpack5 in experimental and the 
package needed for local build is webpack and node-webpack-source from 
experimental.
During a test rebuild, node-react-audio-player was found to fail to 
build in that situation.



Thanks for reporting, I'll fix the package for experimental.

Do you have an expected date when webpack 5 will be uploaded in unstable?

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] node-i18next-http-backend, cross-fetch and bug #997718

2021-10-26 Thread Nicolas Mora

Hello again,

Le 2021-10-26 à 09 h 33, Nicolas Mora a écrit :


So if there's no objection, I would like to send a patched 
node-i18next-http-backend which uses node-fetch instead of cross-fetch 
like before. When cross-fetch will be packaged, I'll reupload 
node-i18next-http-backend without the patch.




Never mind, I've found my solution, I have to package whatwg-fetch 
required in cross-fetch first


/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


[Pkg-javascript-devel] node-i18next-http-backend, cross-fetch and bug #997718

2021-10-26 Thread Nicolas Mora

Hello team,

I updated the node-i18next* in unstable, but node-i18next-http-backend 
added cross-fetch [1] as a dependency, which isn't packaged in Debian 
yet. Which leads to ftbfs for Glewlwyd [2]


I'm working on packaging node-cross-fetch to definitely fix that, but 
it's not easy-peasy for me, their rollup config transpiles with 
ponyfill, polyfill, and uses weird hardcoded node_modules paths.


So if there's no objection, I would like to send a patched 
node-i18next-http-backend which uses node-fetch instead of cross-fetch 
like before. When cross-fetch will be packaged, I'll reupload 
node-i18next-http-backend without the patch.


I've tested this patched package to build glewlwyd and it works fine.

/Nicolas

[1] https://github.com/lquixada/cross-fetch
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=997718

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] autopkgtest fails on some packages

2021-09-23 Thread Nicolas Mora

Hello,

Le 2021-09-23 à 10 h 06, Yadd a écrit :


"pkg-js-autopkgtest-require" tries to use "require(foo)". If your
package isn't a node module, you can:

   echo "require" >debian/tests/pkg-js/SKIP

Be careful to upstream changes. Some updates declares "type: module" in
package.json which isn't compatible with our current nodejs


Thanks, I uploaded a new package which skips the tests

What is the issue when a package has "type: module"?
node-i18next-http-backend has it
Is it a concern somehow?

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


[Pkg-javascript-devel] autopkgtest fails on some packages

2021-09-23 Thread Nicolas Mora

Hello,

I have 2 js packages blocked in unstable because of autopkgtests fail:
- https://tracker.debian.org/pkg/node-i18next-http-backend
- https://tracker.debian.org/pkg/node-redux

For both of them, autopkgtest result says:
autopkgtest [19:12:52]: test pkg-js-autopkgtest: ---]
autopkgtest [19:12:52]: test pkg-js-autopkgtest:  - - - - - - - - - - 
results - - - - - - - - - -

pkg-js-autopkgtest   SKIP exit status 77 and marked as skippable
autopkgtest [19:12:52]:  summary
pkg-js-autopkgtest-require FAIL non-zero exit status 1
pkg-js-autopkgtest   SKIP exit status 77 and marked as skippable

My concern is that I didn't put tests in those, and I can't see what's 
not working with those packages tests, while packages with similar 
packaging have no issue.


See https://tracker.debian.org/pkg/node-i18next-browser-languagedetector 
for example


Does anyone have an idea on how to fix that?

Thanks in advance

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel


Re: [Pkg-javascript-devel] node-i18next-xhr-backend is holding node-babel7 migration

2021-01-26 Thread Nicolas Mora

Hello,

Le 2021-01-26 à 06 h 32, Xavier a écrit :

But node-i18next-xhr-backend has popcon = 1 and according to upstream:
https://github.com/i18next/i18next-xhr-backend
it is "[deprecated] can be replaced with i18next-http-backend"

The latter we already have in Debian:
https://tracker.debian.org/pkg/node-i18next-http-backend

So can we RM node-i18next-xhr-backend ? Any special things I missed ?


go ahead ;-)

I have no problem removing node-i18next-xhr-backend, I don't need it 
anymore since I replaced it with node-i18next-http-backend.


/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-redux_4.0.5-3_source.changes ACCEPTED into unstable

2020-12-31 Thread Nicolas Mora

Le 2020-12-31 à 09 h 53, Pirate Praveen a écrit :




Can someone from the team grant me admin for this repo? then I'll
reapply or cleanup my changes.


You have maintainer access now.


Thanks!


OpenPGP_0xFE82139440BD22B9.asc
Description: application/pgp-keys


OpenPGP_signature
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-redux_4.0.5-3_source.changes ACCEPTED into unstable

2020-12-31 Thread Nicolas Mora

Hello,

Thanks for the upload, although I remember I'm having problems with this 
package salsa repo, I don't have admin access to it, therefore I can't 
push to master branch. I made some changes I pushed in the branch 
merge-master a few days ago [1].


Can someone from the team grant me admin for this repo? then I'll 
reapply or cleanup my changes.


Thanks in advance

/Nicolas

[1] 
https://salsa.debian.org/js-team/node-redux/-/blob/merge-master/debian/changelog


OpenPGP_0xFE82139440BD22B9.asc
Description: application/pgp-keys


OpenPGP_signature
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Move npm to /usr/share/nodejs ?

2020-11-04 Thread Nicolas Mora

Le 2020-11-04 à 07 h 57, Xavier a écrit :


Let's try this in experimental!


Please JS Team, install npm from experimental and test it!


It took me 2 packages build to realize this is about npm and not nodejs :p

So no impact for my packages...

If someone needs a hand to test packages with npm dependencies, let me know.

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] node-fetch 2.6.1 in experimental

2020-10-08 Thread Nicolas Mora

Hello,

I've completed my node-fetch test in experimental and saw no issues on 
my side, nor the package node-isomorphic-fetch which is a reverse dep.


Unless someone has an objection, I'll move node-fetch 2.6.1 to unstable 
in the next days.


/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Embedded modules more than once

2020-09-03 Thread Nicolas Mora
Le 20-09-03 à 10 h 33, Xavier a écrit :
>> A second step would be to report all embedded code to the security team 
>> - see https://wiki.debian.org/EmbeddedCopies
> 
> Partially done
> 
Awesome!

>> A third step would be to ask the security team how we might better help 
>> them handle this¹ issue (because I highly doubt that reporting in the 
>> current form is enough for the security team to reliably track issues: 
>> the seem not efficiently machine-readable).
> 
> I'll try to automate some things around this future tool and `npm
> audit`. I need also to update lintian to get `nodejs-module` results for
> non JS Team packages.
> 
Do you need help on that part?

/Nicolas

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Embedded modules more than once

2020-09-03 Thread Nicolas Mora
Hello,

Concerning embedded modules, this raises me another question.

Le 20-09-03 à 08 h 54, Xavier a écrit :

> serialize-javascript:
>   - node-compression-webpack-plugin (1.9.1)
>   - node-copy-webpack-plugin (1.4.0)
>   - node-uglifyjs-webpack-plugin (1.7.0)

A CVE was recently published for serialize-javascript [1], to fix the
issue, it must be upgraded to 3.1.0.

Can it be possible to broadcast this kind of issue to all packages
embedding vulnerable modules?

/Nicolas

[1] - https://github.com/advisories/GHSA-hxcc-f52p-wc94

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#969295: ITP: node-i18next-http-backend -- Simple i18next backend to be used in Node.js

2020-08-30 Thread Nicolas Mora
Package: wnpp
Severity: wishlist
Owner: Nicolas Mora 
X-Debbugs-CC: pkg-javascript-de...@lists.alioth.debian.org

* Package name : node-i18next-http-backend
Version : 1.0.18
Upstream Author : i18next
* URL : https://github.com/i18next/i18next-http-backend
* License : Expat
Programming Lang: Javascript
Description : Simple i18next backend to be used in Node.js

 This is a simple i18next backend to be used in Node.js, in the browser and
 for Deno. It will load resources from a backend server using the
 XMLHttpRequest or the fetch API.
 .
 It's based on the deprecated i18next-xhr-backend
 and can mostly be used as a drop-in replacement.
 .
 Node.js is an event-based server-side JavaScript engine.

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Upgrading package node-fetch to 2.6.0

2020-08-28 Thread Nicolas Mora
Hello,

In order to package node-i18next-http-backend which replaces
node-i18next-xhr-backend, I need to upgrade package node-fetch to 2.6.0.

According to "build-rdeps node-fetch", this package has the following
build dependencies:

node-isomorphic-fetch
node-formidable
node-jsdom
node-solid-rest

According to "apt rdepends node-isomorphic-fetch", this package depends
on node-isomorphic-fetch only.

I've ran build tests for those 4 packages with node-fetch 2.6.0, they
still build correctly.

I'd like to move on and upgrade node-fetch to package
node-i18next-http-backend and upgrade the node-i18next-* packages. I'll
package in experimental at first to test if there's broken packages.

Does anyone have question or objection about this plan?

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined

2020-07-26 Thread Nicolas Mora
Le 20-07-26 à 18 h 01, Pirate Praveen a écrit :
> 
>>
>> File in node-lodash unstable package:
>> 4.17.19+dfsg-1 _baseOrderBy.js https://paste.debian.net/1157886/
>>
I made a dirty hack to check my theory and it looks like if I patch this
file by replacing 'isArray' with 'Array.IsArray' or if I append 'isArray
= require('./isArray')', I'm able to build broken packages like
node-babel7 or glewlwyd.

The only way I found to patch the package node-lodash is to manually
change the file lodash.js here:
https://salsa.debian.org/js-team/node-lodash/-/blob/master/lodash.js#L3724
and replacing 'isArray' with 'Array.IsArray'.

/Nicolas

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#965353: Bug#965353: Bug#965353: Bug#965353: node-babel7 FTBFS: babel-plugin-dynamic-import-node/src/index.js: isArray is not defined

2020-07-26 Thread Nicolas Mora
I'm not sure yet if this would fix the bug but in all the build log
errors, I see that the file /usr/share/nodejs/lodash/_baseOrderBy.js is
always the source of the error.

The file _baseOrderBy.js in the package seems buggy for an unresolved reson.

File in node-lodash unstable package:
4.17.19+dfsg-1 _baseOrderBy.js https://paste.debian.net/1157886/

File in node-lodash bullseye package
4.17.15+dfsg-2 _baseOrderBy.js https://paste.debian.net/1157887/

In the unstable version, the call to isArray line 24 is the root of errors.

Also, I see that the upstream version 4.17.19 isn't tagged as latest
release, 4.17.16 is, maybe it's worth a try to package 4.17.16 instead?

https://github.com/lodash/lodash/releases

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Fwd: RFS - node-react - d/nodejs/additional_components: install all modules

2020-06-24 Thread Nicolas Mora
Hello again team,

Since I'm not yet allowed to upload as a DD because the keyring hasn't
been updated, can a DD upload my updated package node-react?

Thanks in advance


 Message transféré 
Sujet : RFS - node-react - d/nodejs/additional_components: install all
modules
Date : Sat, 6 Jun 2020 19:47:42 -0400
De : Nicolas Mora 
Pour : Debian Javascript Maintainers


Hello tram,

I'm looking for a DD to upload the new package "node-react" in unstable
with my fix.

 * Package name: node-react
   Version : 16.13.1+dfsg+~cs16.9.34-2
   Upstream Author : Facebook, Inc.
 * URL : https://github.com/facebook/react/
 * License : Expat
 * Vcs : https://salsa.debian.org/js-team/node-react
   Section : javascript

The new package fixes d/nodejs/additional_components to install all
modules instead of only react-* ones from the build/node_modules/ directory.

Some submodules don't have react- prefix in their name but are part of
the react full package, like scheduler.

The new package is already available in the team salsa repository.

Thanks in advance

/Nicolas



-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Fwd: RFS - node-react - d/nodejs/additional_components: install all modules

2020-06-23 Thread Nicolas Mora
Hello again team,

Since I'm not yet allowed to upload as a DD because the keyring hasn't
been updated, can a DD upload my updated package node-react? The source
is updated in the salsa repo https://salsa.debian.org/js-team/node-react

Thanks in advance

/Nicolas

 Message transféré 
Sujet : RFS - node-react - d/nodejs/additional_components: install all
modules
Date : Sat, 6 Jun 2020 19:47:42 -0400
De : Nicolas Mora 
Pour : Debian Javascript Maintainers


Hello tram,

I'm looking for a DD to upload the new package "node-react" in unstable
with my fix.

 * Package name: node-react
   Version : 16.13.1+dfsg+~cs16.9.34-2
   Upstream Author : Facebook, Inc.
 * URL : https://github.com/facebook/react/
 * License : Expat
 * Vcs : https://salsa.debian.org/js-team/node-react
   Section : javascript

The new package fixes d/nodejs/additional_components to install all
modules instead of only react-* ones from the build/node_modules/ directory.

Some submodules don't have react- prefix in their name but are part of
the react full package, like scheduler.

The new package is already available in the team salsa repository.

Thanks in advance

/Nicolas



-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] RFS - node-react - d/nodejs/additional_components: install all modules

2020-06-06 Thread Nicolas Mora
Hello tram,

I'm looking for a DD to upload the new package "node-react" in unstable
with my fix.

 * Package name: node-react
   Version : 16.13.1+dfsg+~cs16.9.34-2
   Upstream Author : Facebook, Inc.
 * URL : https://github.com/facebook/react/
 * License : Expat
 * Vcs : https://salsa.debian.org/js-team/node-react
   Section : javascript

The new package fixes d/nodejs/additional_components to install all
modules instead of only react-* ones from the build/node_modules/ directory.

Some submodules don't have react- prefix in their name but are part of
the react full package, like scheduler.

The new package is already available in the team salsa repository.

Thanks in advance

/Nicolas



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] [RFS] node-redux

2020-05-17 Thread Nicolas Mora
Hello team,

The package node-redux has been updated thanks to yadd's feedbacks, I
also added a few updates and fixes to it.

Since the package node-symbol-observable 1.2 is now in testing,
node-redux is ready.
Can a DD push the package node-redux [1] to the NEW queue if my package
fits Debian's requirements?

Thanks in advance

/Nicolas

[1] - https://salsa.debian.org/js-team/node-redux

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] [RFS] node-redux

2020-05-13 Thread Nicolas Mora
Le 20-05-13 à 03 h 33, Xavier a écrit :
> 
> Push a few minutes ago
> 
Thanks all for your help!

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] [RFS] node-redux

2020-05-12 Thread Nicolas Mora
Hello,

Le 20-05-12 à 01 h 21, Nilesh Patra a écrit :
> 
> Can I upgrade the salsa package node-symbol-observable to 1.2.0? [2]
> 
> Yes, I guess.
> 
>  [~]$ reverse-depends node-symbol-observable
> No reverse dependencies found
> 
>  [~]$ reverse-depends -b node-symbol-observable
> No reverse dependencies found
> 
> I think we are good to go!
> 
I've prepared a new package for node-symbol-observable, right now it's a
fork I made for the current change [1], but I can push in the js-team
repo if that's OK.

[1] - https://salsa.debian.org/babelouest/node-symbol-observable

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] [RFS] node-redux

2020-05-11 Thread Nicolas Mora
Le 20-05-11 à 17 h 01, Nilesh Patra a écrit :
> 
> 
> It's still in NEW[3]. I _think_ if you really want to enable tests now,
My very bad, I forgot to check the NEW queue

> you can do the needful. Since when the packages are accepted, jest would
> (hopefully) be accepted before redux, and hence that should ideally not
> be a problem.
> 
I've ran the tests with the package node-jest in the NEW queue and I had
some issues with jest, some dependencies were not packaged, even by
packaging them I couldn't run the tests successfully. Also the package
node-jest is currently waiting for node-babel ≥ 7.8.3 [1]

Therefore I tried another approach and upgraded the package
node-symbol-observable to 1.2.0 instead, and upgrading
node-symbol-observable to 1.2.0 works fine with a minor change in
d/tests/pkg-js/test

Can I upgrade the salsa package node-symbol-observable to 1.2.0? [2]

> However do check the "distribution" that's experimental for jest.
> If you instead want to wait for jest to be accepted, and then add tests,
> that should be fine as well.
> 
I will wait for node-jest to be at least in experimental to run redux's
tests

> 
> Yep. And that's precisely why tests are a good tool to indicate such things.
> Maybe try to install redux in a chroot and test manually if things work?
> I think the better approach here is to upgrade node-symbol-observable
package to 1.2.0, it's the most reliable way to get a redux package
compatible with upstream requirements, even if I can't run the tests at
first.

> 
> I hope that helps?
> 
Very, thanks for the feedbacks!

/Nicolas

[1] -
https://salsa.debian.org/js-team/node-jest/-/blob/master/debian/changelog
[2] - https://salsa.debian.org/js-team/node-symbol-observable

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] [RFS] node-redux

2020-05-11 Thread Nicolas Mora
Thanks Nilesh for the help

>  
> Node-jest has been packaged for Debian, you can go ahead with running
> tests needing jest.
> 
Not yet, the package is in salsa [1] but the package isn't in unstable [2]

> 
> Skip tests if they don't look compatible due to version constraints.
> Or try upgrading the version ensuring that you don't break anything else.
> 
It's not he tests I'm worried about, it's packaging redux with an
incorrect dependency...

/Nicolas

[1] - https://salsa.debian.org/js-team/node-jest
[2] - https://packages.debian.org/search?searchon=names=node-jest

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] [RFS] node-redux

2020-05-11 Thread Nicolas Mora
Hello,

Le 20-05-11 à 01 h 14, Xavier a écrit :
> 
> at least you should:
>  * remove dependency to node-babel-preset-env
>  * update homepage to https://redux.js.org/ (reported by `duck`)
>  * Add "Testsuite: autopkgtest-pkg-nodejs" and remove
>debian/tests/control & debian/tests/require
> 
All done, thanks

But I've realized an issue with symbol-observable, the packages.json
requires symbol-observable 1.2, but the version packaged in debian sid
is 1.0.4.

I can't run redux tests because they use eslint and jest but the package
builds successfully with Debian package node-synbol-observable 1.0.4.

I wanted to check if redux 4.0.5 would build and tests succeed with
symbol-observable 1.0.4 and I have the following result.

If I untar the official package redux 4.0.5, replace the
symbol-observable version in package.json with 1.0.4, then run the build
or the tests, they fail with the following error message:
Error: 'default' is not exported by node_modules/symbol-observable/index.js

The good new is redux will drop symbol-observable in the next version.
The bad new is new unpackaged dependencies such as
rollup-plugin-typescript2 are introduced...

/Nicolas

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] [RFS] node-redux

2020-05-10 Thread Nicolas Mora
Hello,

I've complete packaging node-redux thanks to node-babel7 [1], this
package has been asked to me because I've started to package it a while
ago and it's required for the Covid biohackathon by the Debian Med team.

Can a DD review the package and, if it's clean, upload it to the NEW queue?

Thanks in advance

[1] - https://salsa.debian.org/babelouest/node-redux

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Packaging issue in node-redux: Unexpected token (three dots)

2020-04-26 Thread Nicolas Mora
Hello,

Le 20-04-26 à 21 h 22, Nilesh Patra a écrit :
> 
> It has been packaged. Please check node-babel7[1]
> 
> [1]: https://tracker.debian.org/pkg/node-babel7

My bad, thanks for the tip, I'll try it with node-babel7 then, thanks a
lot Nilesh!

/Nicolas

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Packaging issue in node-redux: Unexpected token (three dots)

2020-04-26 Thread Nicolas Mora
As I'm used to, right after sending an email to the list, I found a
beginning o an answer

Le 20-04-26 à 20 h 27, Nicolas Mora a écrit :
> SyntaxError: /opt/redux-4.0.1/src/applyMiddleware.js: Unexpected token
> (37:6)
>   35 |
>   36 | return {
>> 37 |   ...store,
>  |   ^

It looks like redux 4.0.1 requires babel 7 which isn't packaged yet. I
see the salsa repo has babel 7 but it doesn't seems to be ready yet. Can
I help in some way to package babel 7?

/Nicolas

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Packaging issue in node-redux: Unexpected token (three dots)

2020-04-26 Thread Nicolas Mora
Hello,

I'm helping the Covid biohackathon by the Debian Med team with the
package node-redux [1], but I have a problem in the package builder. The
command 'rollup -c' exits with the following error.

root@docker-sid:/opt/redux-4.0.1 # rollup -c
src/index.js → lib/redux.js...
[!] (babel plugin) SyntaxError: /opt/redux-4.0.1/src/applyMiddleware.js:
Unexpected token (37:6)
src/applyMiddleware.js (37:6)
SyntaxError: /opt/redux-4.0.1/src/applyMiddleware.js: Unexpected token
(37:6)
  35 |
  36 | return {
> 37 |   ...store,
 |   ^
  38 |   dispatch
  39 | }
  40 |   }
at Parser.pp.raise
(/usr/share/nodejs/babylon/lib/parser/location.js:22:13)
at Parser.pp.unexpected
(/usr/share/nodejs/babylon/lib/parser/util.js:97:8)
at Parser.pp.parseIdentifier
(/usr/share/nodejs/babylon/lib/parser/expression.js:1132:10)
at Parser.pp.parsePropertyName
(/usr/share/nodejs/babylon/lib/parser/expression.js:939:110)
at Parser.pp.parseObj
(/usr/share/nodejs/babylon/lib/parser/expression.js:828:12)
at Parser.pp.parseExprAtom
(/usr/share/nodejs/babylon/lib/parser/expression.js:494:19)
at Parser.pp.parseExprSubscripts
(/usr/share/nodejs/babylon/lib/parser/expression.js:269:19)
at Parser.pp.parseMaybeUnary
(/usr/share/nodejs/babylon/lib/parser/expression.js:249:19)
at Parser.pp.parseExprOps
(/usr/share/nodejs/babylon/lib/parser/expression.js:179:19)
at Parser.pp.parseMaybeConditional
(/usr/share/nodejs/babylon/lib/parser/expression.js:156:19)

Does anyone have a clue? I tried installing various kinds of node-rollup
and node-babel plugins and tried lots of different babelrc but I was
never able to fix it.

Be sure that the final package will have a lot of cleanup as well as
pkg-js-tools used, but so far I try to at least be able to build the
package.

Thanks in advance

/Nicolas

[1] - https://salsa.debian.org/babelouest/node-redux

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] RFS: node-i18next-xhr-backend and node-i18next-browser-languagedetector

2019-12-01 Thread Nicolas Mora
Le 19-12-01 à 11 h 32, Xavier a écrit :
> Le 01/12/2019 à 16:02, Nicolas Mora a écrit :

>> I'm looking for a DD to review my 2 i18next* packages, and upload them
>> to NEW if they meet Debian quality level:
>>
> 
> Not good:
>  * remove *.min.js from import (or if not used, at least update lintian
>overrides with a comment)
Fixed, added in lintian-overrides (although I still don't understand why
I didn't have the lintian warning...)

>  * dependency:
>- node-i18* depends on libjs-i18*, not the reverse 
>- libjs-i18next-xhr-backend must not depend on any node*
My very bad, fixed

>- libjs-i18* should "Recommends: javascript-common"
done

>  * switch to debhelper-compat
done

>  * debhelper-compat 12, not 11
done

>  * add "Rules-Requires-Root: no" in Debian control
done

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] RFS: node-i18next-xhr-backend and node-i18next-browser-languagedetector

2019-12-01 Thread Nicolas Mora
Hello Team,

I'm looking for a DD to review my 2 i18next* packages, and upload them
to NEW if they meet Debian quality level:

- node-i18next-xhr-backend: simple i18next backend to be used in the
browser - https://salsa.debian.org/js-team/node-i18next-xhr-backend

- node-i18next-browser-languagedetector: i18next language detection
plugin use to detect user language in the browser -
https://salsa.debian.org/js-team/node-i18next-browser-languagedetector

I applied the same changes that were made in the node-i18next package
which was recently uploaded to unstable, aka splitting the binary
package in 2: a node and a libjs package

Thanks in advance

/Nicolas

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-i18next_17.0.18-1_amd64.changes REJECTED

2019-11-17 Thread Nicolas Mora
Hello,

Le 19-11-17 à 16 h 20, Xavier a écrit :
> 
> Take a look at my changes. I think you should provide a browserified
> file in /usr/share/javascript (in a separate package).
> 
I added a separate package called libjs-i18next, but for some reason, if
I add a file debian/nodejs/libjs-i18next.install, the package
libjs-i18next_17.0.18-1_all.deb is empty.

I trid several combos, the only one that works is to remove
d/nodejs/install and make 2 new install files:
debian/libjs-i18next.install
debian/node-i18next.install

Is this a pkg-js-tools limitation or is it me not using it like it
should be?

I made the branch browserify-package where I put my changes [1]

/Nicolas

[1] -
https://salsa.debian.org/js-team/node-i18next/tree/browserify-package/debian

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-i18next_17.0.18-1_amd64.changes REJECTED

2019-11-17 Thread Nicolas Mora
Le 19-11-17 à 08 h 09, Xavier a écrit :
> 
> I fixed copyright years
> 
Thanks!

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-i18next_17.0.18-1_amd64.changes REJECTED

2019-11-17 Thread Nicolas Mora
Hello team,

Le 19-11-16 à 18 h 00, Thorsten Alteholz a écrit :
> 
> please also mention at least
>   i18next-17.0.18/test/backward/v1.11.1.compat.js
> in your debian/copyright.
> 

I've updated the file d/copyright in the salsa repository [1].
I've looked for other source files with a copyright notice, it seems
there's no other ones besides v1.11.1.compat.js.

Can a DD reupload the package to NEW?

Thanks in advance

/Nicolas

[1] - https://salsa.debian.org/js-team/node-i18next

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-qrcode-generator_1.4.4-1_sourceonly.changes REJECTED

2019-10-27 Thread Nicolas Mora

Le 19-10-27 à 15 h 37, Jonas Smedegaard a écrit :


Initial uploads to Debian, and a later upload that introduces a new
binary package, needs to visit the NEW queue, and that requires a full
upload with both source and binary.


Of course!

I didn't understand it wasn't uploaded to NEW at first

Thanks

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] node-qrcode-generator_1.4.4-1_sourceonly.changes REJECTED

2019-10-27 Thread Nicolas Mora

Le 19-10-27 à 15 h 18, Debian FTP Masters a écrit :



Source-only uploads to NEW are not allowed.

binary:node-qrcode-generator is NEW.
source:node-qrcode-generator is NEW.


I'm not sure I understand this rejection...

Can someone enlighten me?

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] [RFS] node-qrcode-generator

2019-10-27 Thread Nicolas Mora

Hi,

Le 19-10-26 à 14 h 24, Xavier a écrit :


  * debian-compat => 12


No problem, done


You use npm generated file (using fakeupstram instead of uscan
"searchmode=plain). This is bad here: qrcode_*.js are generated files.
Your lintian-overrides is not acceptable (it hides real problems).
In this case, this package is not compliant with DFSG. Ask upstream to
tag its repository instead and build then from source.



After talking to Xavier on irc, we found a way to package the library:
- the file qrcode.js looks generated by a set of source files but is 
readable enough to be able to update the source
- unused files are removed from the source package and marked as 
"Files-Excluded", those files raised lintian errors

- the d/watch file now uses https://registry.npmjs.org/
- a bug has been opened upstream to ask for a tag whenever a new js 
version is available


The salsa repo [1] has been updated.

/Nicolas

[1] - https://salsa.debian.org/js-team/node-qrcode-generator

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] [RFS] node-qrcode-generator

2019-10-26 Thread Nicolas Mora

Hello js team,

I need a sponsor to review the package node-qrcode-generator [1] and 
push it to NEW if possible.


node-qrcode-generator is a javascript library which generates QR codes 
as svg, images or tables to be inserted in the html DOM.


Thanks in advance

/Nicolas

[1] - https://salsa.debian.org/js-team/node-qrcode-generator

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Unable to push code to newly created repositories in salsa.d.o/js-team/

2019-10-25 Thread Nicolas Mora

Le 19-10-25 à 08 h 21, Pirate Praveen a écrit :



The repositories I have problem with are:
https://salsa.debian.org/js-team/node-qrcode-generator
https://salsa.debian.org/js-team/node-i18next-xhr-backend


https://salsa.debian.org/js-team/node-i18next-browser-languagedetector




You have maintainer access on these repos now and you should be able to push.



Thanks, source package pushed now!

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Unable to push code to newly created repositories in salsa.d.o/js-team/

2019-10-25 Thread Nicolas Mora

Hello,

Le 19-10-16 à 20 h 10, Nicolas Mora a écrit :


The problem is I don't have the settings menu in the new repositories,
yet I have maintainer credentials in the team. So I can't create a
default branch for the repositories...

For some reason, the left sidebar doesn't have all the entries.

The repositories I have problem with are:
https://salsa.debian.org/js-team/node-qrcode-generator
https://salsa.debian.org/js-team/node-i18next-xhr-backend
https://salsa.debian.org/js-team/node-i18next-browser-languagedetector


After checking with the salsa team it looks like a configuration issue.

As a developer member, I can create a project in the js team but I can't 
create a master branch in it because only a maintainer can.


Can a maintainer help me on those repositories?

I need to create a default master branch to be able to push in it.

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Unable to build a react web application using webpack

2019-10-24 Thread Nicolas Mora
I have a web application written in react built with weback during the 
packaging.


If I build the package with the command "debuild -b -uc -us", the 
packaging works.

But if I use sbuild to build the package, I have this weird error [1]:

Module parse failed: Unexpected token (38:22)
You may need an appropriate loader to handle this file type.

The coordinates (38:22) points to the jsx code.

I have tried several fixes like adding more presets, polyfill, etc. 
nothing works. What is weirder is that I have the problem when using 
sbuild but not when using debuild.


Does anyone have an idea on how to solve this?

[1] - https://salsa.debian.org/snippets/340


--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Unable to push code to newly created repositories in salsa.d.o/js-team/

2019-10-16 Thread Nicolas Mora
Hello,

I have 3 new javascript packages almost ready to be uploaded to NEW so
later today I created the repositories in salsa.d.o/js-team/ since I
have the maintainer role.

Lately, when I tried to push the code to salsa, I got the following
error message:

remote: A default branch (e.g. master) does not yet exist for
js-team/node-qrcode-generator
remote: Ask a project Owner or Maintainer to create a default branch:

The problem is I don't have the settings menu in the new repositories,
yet I have maintainer credentials in the team. So I can't create a
default branch for the repositories...

For some reason, the left sidebar doesn't have all the entries.

The repositories I have problem with are:
https://salsa.debian.org/js-team/node-qrcode-generator
https://salsa.debian.org/js-team/node-i18next-xhr-backend
https://salsa.debian.org/js-team/node-i18next-browser-languagedetector

Should I send a message to the salsa team?

/Nicolas


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] node-i18next and piuparts errors

2019-10-14 Thread Nicolas Mora
Hello,

As far as I can say, the package node-i18next [1] is ready to be pushed
in NEW but I'm not a DD yet so if I want to upload a new package I must
use mentors.d.n.

Except from the err below which seems not to be related to the package,
the rest of the QA tests are good: lintian and autpkgtest.

Also, I have an error when running piuparts, which is not node-i18next
specific because my piuparts install keeps telling the same kind of
error, mostly for javascript packages:
1m25.9s ERROR: FAIL: After purging files have disappeared:

/sys/kernel/slab/:A-064/cgroup/anon_vma_chain(6131:anacron.service)/
 not owned

/sys/kernel/slab/:A-064/cgroup/anon_vma_chain(6131:anacron.service)/aliases
 not owned

/sys/kernel/slab/:A-064/cgroup/anon_vma_chain(6131:anacron.service)/align
 not owned
[...]

Does anyone have a clue of what's wrong? Is it in my configuration or
the arguments I use?
My .sbuildrc has the following config:
$piuparts_opts = ['--schroot', 'unstable-amd64-sbuild',
'--distribution', 'unstable', '-m',
'http://cdn-fastly.deb.debian.org/debian main'];

/Nicolas

[1] - https://salsa.debian.org/js-team/node-i18next/


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-12 Thread Nicolas Mora
Le 19-10-12 à 14 h 12, Pirate Praveen a écrit :
> 
> 
> Now autopkgtest is failing,
> 
> autopkgtest [23:40:13]: test require: [---
> /usr/share/nodejs/i18next/i18next.js:124 _export(_export.S + _export.F *
> !_descriptors, 'Object', { defineProperty: _objectDp.f }); ^ TypeError:
> Cannot read property 'S' of undefined at
> /usr/share/nodejs/i18next/i18next.js:124:18 at
> /usr/share/nodejs/i18next/i18next.js:2:82 at Object.
> (/usr/share/nodejs/i18next/i18next.js:5:2) at Module._compile
> (internal/modules/cjs/loader.js:778:30) at Object.Module._extensions..js
> (internal/modules/cjs/loader.js:789:10) at Module.load
> (internal/modules/cjs/loader.js:653:32) at tryModuleLoad
> (internal/modules/cjs/loader.js:593:12) at Function.Module._load
> (internal/modules/cjs/loader.js:585:3) at Module.require
> (internal/modules/cjs/loader.js:692:17) at require
> (internal/modules/cjs/helpers.js:25:18)
> 
Indeed...

If I set the output format to cjs instead of umd, the build and
autopkgtest succeed. I don't know if it's an upstream bug or a config
issue from my side.

I've updated the salsa repo with cjs format [1]. Is it correct?

/Nicolas

[1] - https://salsa.debian.org/js-team/node-i18next


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#942218: node-sourcemap-codec: link file index.js incorrect

2019-10-12 Thread Nicolas Mora
Package: node-sourcemap-codec
Version: 1.4.5
Severity: normal
Tags: patch

The link usr/lib/nodejs/sourcemap-codec/index.js included in the package
points to the file usr/lib/nodejs/sourcemap-codec/sourcemap-codec.js
where it should link to 
usr/lib/nodejs/sourcemap-codec/dist/sourcemap-codec.umd.js

-- System Information:
Debian Release: 10.1
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'unstable'), 
(500, 'testing')
Architecture: armhf (armv7l)

Kernel: Linux 3.10.107 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages node-sourcemap-codec depends on:
pn  node-vlq  
pn  nodejs

node-sourcemap-codec recommends no packages.

node-sourcemap-codec suggests no packages.
diff --git a/debian/links b/debian/links
index e733015..1e2cc11 100644
--- a/debian/links
+++ b/debian/links
@@ -1,2 +1,2 @@
 # otherwise node-es6-module-transpiler isn't smart enough to find it
-usr/lib/nodejs/sourcemap-codec/index.js 
usr/lib/nodejs/sourcemap-codec/sourcemap-codec.js
+usr/lib/nodejs/sourcemap-codec/dist/sourcemap-codec.umd.js 
usr/lib/nodejs/sourcemap-codec/index.js
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#942216: node-rollup-plugin-commonjs: link file index.js incorrect

2019-10-12 Thread Nicolas Mora
Package: node-rollup-plugin-commonjs
Version: 10.0.1
Severity: normal
Tags: patch

The link usr/lib/nodejs/rollup-plugin-commonjs/index.js included in the package
points to the file 
usr/lib/nodejs/rollup-plugin-commonjs/rollup-plugin-commonjs.cjs.js
where it should link to 
usr/lib/nodejs/rollup-plugin-commonjs/dist/rollup-plugin-commonjs.cjs.js

-- System Information:
Debian Release: 10.1
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'unstable'), 
(500, 'testing')
Architecture: armhf (armv7l)

Kernel: Linux 3.10.107 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages node-rollup-plugin-commonjs depends on:
pn  node-acorn   
pn  node-estree-walker   
pn  node-is-reference
pn  node-magic-string
pn  node-resolve 
pn  node-rollup-pluginutils  
pn  nodejs   

node-rollup-plugin-commonjs recommends no packages.

node-rollup-plugin-commonjs suggests no packages.
diff --git a/debian/links b/debian/links
index 4815bc9..e4dab4d 100644
--- a/debian/links
+++ b/debian/links
@@ -1 +1 @@
-usr/lib/nodejs/rollup-plugin-commonjs/rollup-plugin-commonjs.cjs.js 
usr/lib/nodejs/rollup-plugin-commonjs/index.js
+usr/lib/nodejs/rollup-plugin-commonjs/dist/rollup-plugin-commonjs.cjs.js 
usr/lib/nodejs/rollup-plugin-commonjs/index.js
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Error in i18next-xhr-backend test

2019-10-10 Thread Nicolas Mora
Hello,

In the package node-i18next-xhr-backend [1] I'm working on, I have this
error during the dh_test phase:

   dh_auto_test --buildsystem=nodejs
/usr/bin/node -e require\(\"./.\"\)
internal/modules/cjs/loader.js:638
throw err;
^

Error: Cannot find module './_an-object'
at Function.Module._resolveFilename
(internal/modules/cjs/loader.js:636:15)
at Function.Module._load (internal/modules/cjs/loader.js:562:25)
at Module.require (internal/modules/cjs/loader.js:692:17)
at require (internal/modules/cjs/helpers.js:25:18)
at /<>/dist/umd/i18nextXHRBackend.js:88:17
at /<>/dist/umd/i18nextXHRBackend.js:2:82
at Object.
(/<>/dist/umd/i18nextXHRBackend.js:5:2)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)

After some search, I can see that node-core-js is involved in this issue
but I don't see how yet.
I tried several things to fix this, like using polyfill or modifying the
rollup.config.js file but so far no luck.

Does anyone had this kind of error before in a package?

[1] - https://salsa.debian.org/babelouest-guest/node-i18next-xhr-backend


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-09 Thread Nicolas Mora

Le 2019-10-09 13:02, Xavier a écrit :


No but it's a git-buildpackage bug. Commit the good file using:
  $ pristine-tar commit ../node-i18next-17.0.18.tar.gz upstream/17.0.18
Then push to salsa (using `salsa push` which pushes all what is needed)


Got it, thanks.

Also, I could push force in the salsa repo. I had to temporary change 
the protected branch configuration for the repo, push force, then reset 
the protected branch config as it was. Now the node-i18next commits are 
all squashed.


When node-i18next will be pushed and accepted, can we do the same to my 
2 other repos node-i18next-browser-languagedetector [1] and 
node-i18next-xhr-backend [2]?


/Nicolas

[1] - 
https://salsa.debian.org/babelouest-guest/node-i18next-browser-languagedetector

[2] - https://salsa.debian.org/babelouest-guest/node-i18next-xhr-backend

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-09 Thread Nicolas Mora

Le 2019-10-09 09:36, Pirate Praveen a écrit :


I guess one of the gitlab acl bugs/features as you have maintainer
access there, if you wish you can make master branch as unprotected
and force push. But I think lets leave it as it is.

I tried to find out how to change it but so far no luck, isthere's a 
level higher than 'maintainer' but lower than 'admin' in the gltlab 
group js-team?



For the next time, must the git commits be all squashed for an
upload in the js team?


That would be nice, we will have clean git histories.


Will do then, thanks


I'm trying to build your package, but it seems your pristine-tar
branch is not correct.

$ origtargz W: Unable to locate package node-i18next

I had to do the following steps,

$ pristine-tar checkout ../node-i18next-17.0.18.tar.gz pristine-tar:
successfully generated ../node-i18next-17.0.18.tar.gz $ mv
../node-i18next-17.0.18.tar.gz ../node-i18next_17.0.18.orig.tar.gz

Check the file names, you imported the wong tarball I think. Please
use pristine-tar commit to add correct orig.tar


I pushed changes in the pristine-tar branch. Then I tried to build from 
a fresh clone with no luck so far:


$ gbp clone g...@salsa.debian.org:js-team/node-i18next.git
$ gbp buildpackage --git-builder=sbuild -A
gbp:error: upstream/17.0.18 is not a valid treeish

I have to run pristine-tar checkout first, is it normal?

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-09 Thread Nicolas Mora
Le 19-10-09 à 02 h 47, Pirate Praveen a écrit :
> 
> 
> Well, if you had not pushed to js-team, squashing makes sense as it require 
> force push. It is not recommended to force push to team repo after it is 
> published. In this case since we have not uploaded it, you can squash and 
> force push if you like. But never force push once a package is uploaded.
> 
I can't push-force, gitlab won't allow me to:

remote: GitLab: You are not allowed to force push code to a protected
branch on this project.
To salsa.debian.org:js-team/node-i18next.git

For the next time, must the git commits be all squashed for an upload in
the js team?

/Nicolas


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-08 Thread Nicolas Mora
Hello,

Le 19-10-08 à 03 h 57, Pirate Praveen a écrit :
> 
> * You can change pkg-js-tools dependency to (>= 0.8.13~) and then remove
> debian/install file.
> 
done

> * You remove unnecessary comments like #override.. #export... in rules.
> 
done

> * It is better to remove debian/tests/pkg-js/test instead of creating a
> dummy script. You can ignore that lintian warning (it makes it easy to
> know if a package is not running tests). Since no tests are run
> node-tape could be removed from build dependencies.
> 
done

> * You can push to https://salsa.debian.org/js-team/node-i18next/ after
> squashing related commits.
> 
done
although I didn't squash the commits in the master branch, only pushed
as it is in my personnal repo. Should I rebase all the commits in the
master branch from the start?


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-07 Thread Nicolas Mora
Le 19-10-07 à 11 h 41, Pirate Praveen a écrit :
>> If I apply this change, I got a lot of errors like this:
>>
>> (!) Circular dependency:
>> ../../../usr/lib/nodejs/core-js/library/modules/_export.js ->
>> ../../../usr/lib/nodejs/core-js/library/modules/_hide.js ->
>> ../../../usr/lib/nodejs/core-js/library/modules/_object-dp.js ->
>> ../../../usr/lib/nodejs/babel-runtime/core-js/object/define-property.js
>> -> ../../../usr/lib/nodejs/core-js/library/fn/object/define-property.js
>> ->
>> ../../../usr/lib/nodejs/core-js/library/modules/es6.object.define-property.js
>> -> ../../../usr/lib/nodejs/core-js/library/modules/_export.js
>>
>> Aby idea how to fix it?
> 
> I have seen such warnings, though I'm not sure how serious it is. Did the 
> build fail?
> 
Indeed it's just warning messages, I've read the build log too fast, the
error was because of invalid tests.
The upstream package uses karma to run tests so I had to disable testing
in the package build. I let a note as a reminder for the future in
debian/tests/pkg-js/test

I've made other changes in the package to use pkg-js-tools features.

/Nicolas


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-07 Thread Nicolas Mora
Hi,

Le 19-10-07 à 04 h 02, Pirate Praveen a écrit :
> 
> See
> https://salsa.debian.org/ruby-team/rails/blob/master/debian/patches/0002-disable-uglify-in-activestorage-rollup-config-js.patch
> to pass system paths to rollup-plugin-node-resolve instead of copying
> whole /usr/lib/nodejs.
> 
> Pass /usr/lib/nodejs and /usr/share/nodejs both.
> 
If I apply this change, I got a lot of errors like this:

(!) Circular dependency:
../../../usr/lib/nodejs/core-js/library/modules/_export.js ->
../../../usr/lib/nodejs/core-js/library/modules/_hide.js ->
../../../usr/lib/nodejs/core-js/library/modules/_object-dp.js ->
../../../usr/lib/nodejs/babel-runtime/core-js/object/define-property.js
-> ../../../usr/lib/nodejs/core-js/library/fn/object/define-property.js
->
../../../usr/lib/nodejs/core-js/library/modules/es6.object.define-property.js
-> ../../../usr/lib/nodejs/core-js/library/modules/_export.js

Aby idea how to fix it?

> Also I think you have applied patches directly in master, we don't
> follow that scheme in js-team. Please unapply patches from master or
> otherwise quilt push -a was failing
> 
My mistake, bad habit, it's fixed in the next commit, thanks

> You can use debian/nodejs/build instead of override_dh_auto_build.
> 
Done

/Nicolas


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-06 Thread Nicolas Mora
Hello JS team,

I was able to make a package for i18next here:
https://salsa.debian.org/babelouest-guest/node-i18next

Thanks to Pirate's feedback, I now build the bundle with rollup, but the
minified bundle is created with uglifyjs.terser

For some reason, lintian seems to be failing right now, I have the
following error message: "sbuild-build-depends-lintian-dummy : Depends:
lintian but it is not going to be installed" but if I run it manually, I
see no errors.

Could a DD check my package and - if it's ok to be pushed in NEW - copy
it in the js-team? Or if the package is not ok, tell me what I should do
to improve it?

Thanks in advance



pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-06 Thread Nicolas Mora
Hello,

Le 19-10-06 à 09 h 21, Pirate Praveen a écrit :
> 
> 
> You can just patch out rollup-plugin-terser usage and use
> uglifyjs.terser command line.
> 
Thanks for the tip, I'm trying to use rollup to build the package but so
far no luck: I removed rollup-plugin-terser from the rollup.config.js,
and renamed the babel modules from "@babel/" to their equivalent Debian
packages "babel-plugin-" or "babel-preset-*" but I got stuck with the
error message "It looks like your Babel configuration specifies a module
transformer. Please disable it.", and I couldn't find out how to fix it
yet...

> 
> Using webpack is also fine, but if you can get rollup to work that is
> preferred. The actual requirement is, the generated files should have
> corresponding source. There are many cases where we already use
> different tools from what upstream uses for various resons.

I'd rather not to use webpack too, to be as close as possible as
upstream build.

Thanks for the help

/Nicolas


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

2019-10-06 Thread Nicolas Mora
Hello,

I'm trying to package i18next for Debian [1]. The upstream dev use
rollup to build the i18next.js file with rollup-plugin-terser.
Unfortunately, rollup-plugin-terser isn't in Debian yet and requires a
lot of unpackaged dependencies.

I can build i18next.js with webpack, all the required plugins are
already present.

I'm wondering if a i18next package built with another tool would be
accepted?

[1] - https://github.com/i18next/i18next


pEpkey.asc
Description: application/pgp-keys
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] New package for node-async 3.0.1 in salsa

2018-11-26 Thread Nicolas Mora

Hello,

Le 2018-11-26 03:01, Pirate Praveen a écrit :


You can try using node-neo-async instead for your package. It is
supposed to be a drop in replacement for node-async.

https://tracker.debian.org/pkg/node-neo-async


Thanks for pointing out node-neo-async!

I ran a manual test of the packages included in istanbuljs and most of 
the test pass, except for the package istanbul-lib-instrument which 
fails with the error:


Error: Options {"loose":true} passed to 
/usr/lib/nodejs/babel-preset-env/lib/index.js which does not accept 
options. (While processing preset: 
"/usr/lib/nodejs/babel-preset-env/lib/index.js") (While processing 
preset: "/usr/lib/nodejs/babel-preset-env/lib/index.js")


At first it looks like an incompatibility with some packages but I'll 
keep looking and try to fix that.


Meanwhile, since the initial goal is to validate node-neo-async instead 
of node-async, I'd say it's ok with neo-async according to istanbuljs' 
tests


Testing istanbuljs requires the new package node-memory-streams to be 
available.
Thanks to the Universe (and memory-streams dev), this package can be 
easily built using Debian's node packages.


Also, there are pretests scripts in istanbuljs packages:
jshint index.js lib/ test/

jshint is not present in Debian, but according to its documentation, 
jshint is a code quality tool that flags suspicious usage. In that case 
I would assume upstream released code has been validated, so running 
jshint during build process isn't necessary.


Also, neo-async package's documentation states that you can use it in 
standard mode:

var async = require('neo-async');

or in replacement mode:
$ ln -s ./node_modules/neo-async ./node_modules/async
var async = require('async');

I ran my tests in standard mode by replacing in the source files 
"require('async')" with "require('neo-async')".


In the Debian context, I'd patch the package source to use 
require('neo-async') when needed instead of building a soft link because 
otherwise, we couldn't have the packages node-async and node-neo-async 
at the same time.


I will add all the tests but the one that fails to the node-istanbuljs 
package and package node-memory-streams as well.


/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] New package for node-async 3.0.1 in salsa

2018-11-25 Thread Nicolas Mora
Hello,

Le 18-11-25 à 13 h 56, Jonas Smedegaard a écrit :
> Did you check that none of the 6 reverse dependencies and none of the 67 
> reverse build-dependencies break when doing such a major upgrade?  
> Beware of packages with no or inferior or skipped testsuites: Quite 
> likely manual inspection is needed!
> 
My very mistake.

I checked some of the packages which build depends on node-async and
they do break on build attempt, where they still succeed with the
current package node-async. So the problem comes from my package.
I'm sorry for not verifying that. I will keep that in mind next time I
want to upgrade an existing package.

> If not, I suggest to instead package as new separate package 
> node-async-2.
> 
I will propose a new package then.

Concerning the standard and debhelper bumps, the intention was mostly to
avoid lintian warnings, but as I said earlier, I will keep that in mind
too for future package upgrades.

Thanks for the feedback

/Nicolas



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] New package for node-async 3.0.1 in salsa

2018-11-25 Thread Nicolas Mora
Hello Jonas,

In order to package node-istanbuljs, I made a new package for node-async
based on the original node-async package. The new features for the
package are:
  * New upstream version
  * Add node-babel-plugin-add-module-exports as dependency
  * Bump Standards-Version to 4.2.1, no changes needed
  * Change Vcs-* urls to Salsa
  * Updated d/copyright, removed deps/nodeunit.js
  * Add lintian override source-is-missing for
+ support/jsdoc/theme/static/scripts/prettify/lang-css.js line length is
  390 characters (>256)
+ support/jsdoc/theme/static/scripts/prettify/prettify.js line length is
  563 characters (>512)
  * Bumb to debhelper 11

As the package maintainer, can you review the new package and send me
your feedbacks if you're interested? [1]

Thanks in advance for your help

/Nicolas

[1] https://salsa.debian.org/js-team/node-async/merge_requests/1

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] Review of istanbuljs packaging

2018-11-21 Thread Nicolas Mora

Hello,

Wow, thanks a lot for the very detailed review!

Most of the feedbacks are fixed or are going to be, but I have a couple 
of questions regarding some of them, and answers for your questions.


Le 2018-11-21 04:47, Per Andersson a écrit :


node-async:
* In the commit 1f1a73863e91c7101df3c114ed5e4c967391dd24 there is more
  happening than just changing the .gitignore
indeed, the problem was that the original gitignore told to ignore build 
and build-es, but there are source files in support/build that were 
ignored because of this, so in the same commit I changed the .gitinore 
and readded the missing files.

I changed the commit message to become more explicit


* In the commit 7ef4626a5b559c52d13ed5fa57110fe8bfd77027 why does the
  target path need changing?
Because the file webpack.config.js is in debian to avoid a useless 
patch, but the output files were generated under debian/dist instead of 
dist, so preferred changing the target path instead of the install file, 
but I can revert to the original version.



node-fileset:
* remove override_dh_auto_build target if unused
The problem I have is because of the Makefile present in the root dir. 
If I don't override dh_auto_build, then sbuild will run 'make' which 
leads to the command 'bake -h' which doesn't build anything, especially 
since there is nothing to build...


I couldn't find in the documentation another way to disable a dh_ 
command, so instead I overrode it with nothing, but if there's a better 
way, I'll change it asap!



node-path-parse:
* You could add an autopkgtest running node test.js,
Sorry for the rookie question but I couldn't find how to use autopkgtest 
properly for this case.
How can I add an autopkgtest running node test.js? Simply by setting the 
dh_auto_test command to 'autopkgtest node test.js'?



node-istanbuljs-1.x:
* Missing long descriptions in d/control
The problem with istanbuljs is that the author is not very talkative on 
the descriptions of his packages, that's why I didn't put any long 
description...


Also, as I asked on IRC, what version should I use for node-istanbuljs? 
The branch name is 1.x but the package.json files says 2.0.0 and it's 
probably a typo since 2.0 is the current release number. So how should I 
version this package? 1.x? 1? something else maybe?

I prefer asking first instead of having to change it afterwards.

Thanks again

/Nicolas

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] New version of coffeescript required

2018-11-19 Thread Nicolas Mora

Hello again,

Le 2018-11-19 13:14, Nicolas Mora a écrit :

In order to create the Debian package redux, I need the following
unresolved dependencies:
redux
├─ loose-envify (^1.4.0)  node-loose-envify
(1.3.1+dfsg1-1)
  └─ js-tokens (^3.0.0 || ^4.0.0)   node-js-tokens 
(2.0.0-1)

└─ coffeescript (^2.2.0)
└─ symbol-observable (^1.2.0)

Sorry for the noise, after checking with the upstream repository [1], I 
realized that there is no relevant change between 1.3.1 currently in 
testing ang current 1.4.0.


So there is no need to upgrade coffeescript right now

[1] - https://github.com/zertosh/loose-envify/compare/v1.3.1...master

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] New version of coffeescript required

2018-11-19 Thread Nicolas Mora

Hello,

Sorry if I ask a question that was already discussed before, I'm kinda 
new in Debian javascript team.


In order to create the Debian package redux, I need the following 
unresolved dependencies:

redux
├─ loose-envify (^1.4.0)  node-loose-envify 
(1.3.1+dfsg1-1)
  └─ js-tokens (^3.0.0 || ^4.0.0)   node-js-tokens 
(2.0.0-1)

└─ coffeescript (^2.2.0)
└─ symbol-observable (^1.2.0) node-symbol-observable 
(1.0.4-2)


I found out the debian package coffeescript but the version number made 
me wondered why is it still in the version 1.12, last upload on june 
2018, when the current upstream version was 2.3.1 at that time?


Is, in your knowledge, the version 1.12 specifically required, or can we 
upgrade to coffeescript 2.3.2?


If so, maybe it would be possible to have both versions in Debian 
repository.


The new upstream package was significally cleaned since 1.12 because 
there is no more build script.
I haven't figured out if the tests can pass with current Debian packages 
though. [1]


Thanks for your feedback.

/Nicolas

[1] - https://salsa.debian.org/babelouest-guest/node-coffeescript

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] New javascript packages for taliesin

2018-11-14 Thread Nicolas Mora

Le 2018-11-14 05:43, Pirate Praveen a écrit :


You can chmod +x it in override_dh_fixperms target in rules.


Yes, fixed it.
Also, I just realized that the script jest/bin/jest.js contains this 
simple code:


require('jest-cli/bin/jest');

So I think we should remove the file debian/links and add a file 
debian/node-jest-cli.links instead that will contain the following:


usr/lib/nodejs/jest-cli/bin/jest.js usr/bin/jest

What do you think?


I'm currently making a package for istanbuljs that is a meta package
like jest and some of its modules are required for node-jest-cli.


I think Istanbul is already in NEW.

Yes, I saw that, but that the package node-istanbul in NEW comes from 
github.com/gotwarlost/istanbul [1], and the one required by jest are 
node-istanbul-lib-coverage, node-istanbul-lib-instrument and 
node-istanbul-lib-source-maps, which are in 
github.com/istanbuljs/istanbul


I think they are not the same...

I shall call my new package node-istanbuljs to avoid confusion.


babel 7 needs a lot of work, it needs gulp 4 and probably more. If it
can work with babel 6, that would be best. If not we should complete
babel 7. Help is always welcome. Gulp 4 needs updating many of its
dependencies.


OK, so for starters, I'll ask upstream about it, thanks.

[1] - https://github.com/gotwarlost/istanbul
[2] - https://github.com/istanbuljs/istanbuljs

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] New javascript packages for taliesin

2018-11-13 Thread Nicolas Mora

Hello,

Le 2018-11-11 22:08, Pirate Praveen a écrit :


I don't think grouping unrelated packages is a good idea. If there is
a circular dependency or related projects, then its OK. It is making
things unnecessarily complex.


I don't think either that making a group package for such small 
dependencies is a good idea to build other javascript packages.


Concerning jest, I've created a merge request in the current salsa repo 
to complete the node-jest package. [1]
The package now builds with success with all jest packages included. 
Lintian complains about the script jest-cli/jest.js that is not 
executable and I haven't figured out why yet.


But the remaining problem in order to complete node-jest is to package 
some of its dependencies.


I'm currently making a package for istanbuljs that is a meta package 
like jest and some of its modules are required for node-jest-cli.


Another issue with jest is the package node-babel-code-frame which is 
required for node-jest-message-util. Currently the package node-babel in 
unstable is 6.26 but I see in salsa that node-babel 7 is in progress to 
be packaged. I also can ask upstream if babel 6.26 is enough for this 
module to work.


[1] - https://salsa.debian.org/js-team/node-jest/merge_requests/1

--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] New javascript packages for taliesin

2018-11-11 Thread Nicolas Mora
Hello,

I'm working on packaging Taliesin, an audio streaming server with a
front-end written in react [1].

To build the front-end, I need some new node packages. I've already
starting packaging some of them, but I prefer asking the javascript team
about it first, to make sure I'm making it right.

Among the required new packages, there are
i18next-browser-languagedetector and i18next-xhr-backend that require
the packages serialize-javascript [2] and jest-worker.
I've already packaged those last 2 and uploaded them to mentors.d.n. But
then I saw that a package node-jest is already in preparation so I can
offer my help to package node-jest instead.
I also made a new package for node-i18next. There's already a package
libjs-i18next but the version is quite old (1.7.1) when the current
version is 12.0.0.

Another package in mentors.d.n is react-audio-player [3], a wrapper for
the html  tag binded with react.

Among the other packages I need, there are some that are easy, like
react-i18next, but some others will probably be difficult to build,
considering their dependencies. I'm thinking about react-bootstrap and
redux especially. I've started to package them and their dependencies.

I'm also willing to help the javascript with other packages than the
ones I need if you want.

Thanks in advance for your help and advises.

/Nicolas

[1] - https://salsa.debian.org/babelouest-guest/taliesin
[2] - https://mentors.debian.net/package/node-serialize-javascript
[3] - https://mentors.debian.net/package/node-react-audio-player

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel