Re: [Pkg-javascript-devel] Please review jquery-coolfieldset
Hi François-Régis 2014-03-20 18:32 GMT+01:00 François-Régis frv-deb...@miradou.com: Hi everybody, Following Emilien and Marcelo reviews, I've restart the repo from scratch and included their remarks, so if someone could have a look at http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-coolfieldset.git and if ok upload it to unstable ? Thanks for processing Marcelo and my comments. Regarding the minifying, I pointed you towards building inside a temporary debian/build folder. Marcelo reviewed my jquery-lazyload package, and his comment was that it's not necessary. He recommends just building inside the root directory, and then clean up [0]. I still think it's best not to mess directly in the root directory, so I've changed my package with an intermediary solution: building inside the debian/directory. That makes it a bit simpler (no need to mkdir the debian/build directory), but still keeps the packaging operations out of the root directory. See my changes [1]. I'm not saying you need to change your package, this is just meant as informative. Regarding the removal of the minified files: that is done to comply with the DFSG, as minified files are assimilated to compiled objects, not source code. As Debian requires the source to be provided, not the compiled binaries, the minified files must be removed fromt the upstream tarball. But that also means you must repackage the tarball, and you need to indicate -dfsg in the package version. I don't think you've taken these steps yet (and I need to do it as well for jquery-lazyload). See Marcelo's example [2]. Let us know if this is unclear. +Emilien [0] http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/2014-March/007176.html [1] http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-lazyload.git;a=commitdiff;h=1c65e8ddbf865c4c675fcc92148a334e3811146b [2] http://tinyurl.com/okmsdkt ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] New jquery-lazyload version 1.9.3 - please upload
On Fri, Mar 21, 2014 at 07:28:35AM +0100, Emilien Klein wrote: Thanks Marcelo for reviewing. I still need to work on removing the minified files from the upstream tarball (DFSG-ing), but have one question: 2014-03-16 23:16 GMT+01:00 Marcelo Jorge Vieira me...@debian.org: 2) Rules: Please not remove copyright notice from minified files. Not sure I'm understanding. Do you mean in d/copyright? The minified file is included as part of Files: * I believe this is talking about the license header in the minifieid copy of the library. Most licenses have something that asserts the header stay intact if it's present. Take the MIT/Expat license, which jQuery is under: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. By removing the header, you breech the license, making it undistributable. Cheers, Paul -- .''`. Paul Tagliamonte paul...@debian.org | Proud Debian Developer : :' : 4096R / 8F04 9AD8 2C92 066C 7352 D28A 7B58 5B30 807C 2A87 `. `'` http://people.debian.org/~paultag `- http://people.debian.org/~paultag/conduct-statement.txt signature.asc Description: Digital signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Contact Us Via E-mail: frelot...@yahoo.co.uk
You have won 560,000:00 GBP in Free Lotto, without the sale of any tickets! Send. Full Name:. Mobile Number and Alternative Email Address. contact via e-mail: frelot...@yahoo.co.ukmailto:frelot...@yahoo.co.uk Thank you. Mrs. Laura borgotti FreeLotto Director of Information Copyright 2014© Free Lotto Inc. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Please review jquery-coolfieldset
Hi Emilien, Le 21/03/2014 07:45, Emilien Klein a écrit : 2014-03-20 18:32 GMT+01:00 François-Régis frv-deb...@miradou.com: Regarding the minifying, I pointed you towards building inside a temporary debian/build folder. Marcelo reviewed my jquery-lazyload package, and his comment was that it's not necessary. He recommends just building inside the root directory, and then clean up [0]. I still think it's best not to mess directly in the root directory, so I've changed my package with an intermediary solution: building inside the debian/directory. That makes it a bit simpler (no need to mkdir the debian/build directory), but still keeps the packaging operations out of the root directory. See my changes [1]. I've followed the thread, and followed the Marcelo's way for my next packages. I've found any policy about this. From my POV it's often simpler to build in root directory as cleanup is as simple as rm *.min.js, *and* (perhaps more important) debuild will fail on uncomplete cleanuo.This may reach (or not) your willing not to mess root directory (which I share). This point also on the fact that pkg-javascript has no suggested workflow and as I know no dh_helper (compared with pkg-ruby or pkg-php). So Marcelo's recommandation goes on the good way to have uniform workflow and should be written somwhere (as the recomand to provide minify and source version). We may have something like : * Origin tarball should not include any minify code. * Binary package should provide orginal js and minify version * Minify should be build inside source root tree * dh_auto_clean should remove any minified code in source tree This is just the POV of a new contributor of pkg-javascript. I'm not saying you need to change your package, this is just meant as informative. Seeing the time needed to have comments and upload on pkg-javascript, I prefer to keep it on... May be I'm wrong and it's better to make noise on the list to be heard ? Regarding the removal of the minified files: that is done to comply with the DFSG, as minified files are assimilated to compiled objects, not source code. As Debian requires the source to be provided, not the compiled binaries, the minified files must be removed fromt the upstream tarball. But that also means you must repackage the tarball, and you need to indicate -dfsg in the package version. I don't think you've taken these steps yet (and I need to do it as well for jquery-lazyload). See Marcelo's example [2]. This is now (and was not) definitely clear for me. In the case of jquery-coolfildsetn I have'nt seen any other way than taking over upstream so I've removed any mified code... Let us know if this is unclear. If anyone can clearify the above questions, you're welcome Thank's again Emilien and Marcelo for tour reviews -- François-Régis ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#740893: libjs-jquery-hotkeys regression (was: python-coverage regression)
On 21-Mar-2014, Thomi Richards wrote: I hope you don't mind my pinging you like this. No problem, you're doing so in my capacity as a Debian package maintainer, so this address is fine for that. I've discovered a regression in python-coverage packages in Ubuntu Trusty, and narrowed the problem down to a the jquery.hotkeys package in Debian. I filed a bug here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740893 Right, I think that bug report is correct. I'm replying onto that bug report to keep the discussion where it (IMO) belongs for now. ...and was hoping I could bring this to your attention, with the hopes of getting it fixed in time for the Trusty release. Isn't the problem best fixed by reverting the ‘libjs-jquery-hotkeys’ package to the working “0.8” version? The newer version breaks dependent packages, so the right place to apply pressure it seems to me is by rejecting that newer code from Debian until it works again. I'm not sure what the best solution is. I've identified the last revision of that package that worked well with coverage.py. One option is to revert the debian package, but presumably those changes were made for a reason, and I'd hate to break other projects. Another option is to use the vendorised libraries in upstart coverage.py. Sure. It's easy for me to identify the location for a solution in a package which I'm not really involved with, so my position is not the only one to consider. Please let me know if I can do anything to help out. Have you got any feedback from the Debian package maintainer of ‘libjs-jquery-hotkeys’ to find out whether rolling back to version “0.8” is feasible? Have you worked with that package maintainer to report the bug upstream (it is the package maintainer's responsibility)? Has the upstream developer -- \ “Too many pieces of music finish too long after the end.” —Igor | `\ Stravinskey | _o__) | Ben Finney b...@benfinney.id.au signature.asc Description: Digital signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
