[Pkg-javascript-devel] Bug#844137: node-groove: FTBFS: Tests failures

[Petter Reinholdtsen]

Control: reassign -1 libgrooveplayer4
Control: found -1 4.3.0-2
Control: tags -1 + patch

[Felipe Sateler]
> However as I cannot reproduce the error, I cannot test if this indeed
> fixes the issue...

I can confirm that this patch fixes the crash in node-groove.  The error
is in the player library, not the node implementation, so I reassign
this issue there.

-- 
Happy hacking
Petter Reinholdtsen

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#844137: node-groove: FTBFS: Tests failures

[Petter Reinholdtsen]

[Felipe Sateler]
> However as I cannot reproduce the error, I cannot test if this indeed
> fixes the issue...

I talked to lucas on #debian-js about such access, and he allowed me to
use one of his VMs.  Lets talk about this there.

-- 
Happy hacking
Petter Reinholdtsen

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#844137: node-groove: FTBFS: Tests failures

[Felipe Sateler]

Hi all,

On 26 December 2016 at 05:08, Petter Reinholdtsen  wrote:
>
> [Felipe Sateler]
> > This suggests there is some wrong thread usage. Andrew, any idea what
> > could this be?
>
> There are several bugs that can trigger this.  For example trying to unlock an
> non-locked lock.  Using 'valgrind --tool=helgrind' make it possible to see 
> incorrect
> lock usage.

Does anyone have hardware to test this fix? It appears the problem is
not on node-groove, but on libgrooveplayer. In particular, the dummy
device thread unlocks a mutex too early when an underrun occurs, and
then later on it is unlocked again. The following diff fixes the
helgrind error (but leaves plenty of other possible data race
warnings):

diff --git a/grooveplayer/player.c b/grooveplayer/player.c
index 5d2239c..ad4ad75 100644
--- a/grooveplayer/player.c
+++ b/grooveplayer/player.c
@@ -198,7 +198,7 @@ static void *dummy_thread(void *arg) {
 // track of time, we're going to pretend that we did *not*
 // just get a buffer underrun. Instead we'll wait patiently
 // for the next buffer to appear and handle it
appropriately.
-pthread_mutex_unlock(>play_head_mutex);
 break;
 }
 }

However as I cannot reproduce the error, I cannot test if this indeed
fixes the issue...


-- 

Saludos,
Felipe Sateler

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#844137: node-groove: FTBFS: Tests failures

[Petter Reinholdtsen]

[Felipe Sateler]
> This suggests there is some wrong thread usage. Andrew, any idea what
> could this be?

There are several bugs that can trigger this.  For example trying to unlock an
non-locked lock.  Using 'valgrind --tool=helgrind' make it possible to see 
incorrect
lock usage.

-- 
Happy hacking
Petter Reinholdtsen

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#844137: node-groove: FTBFS: Tests failures

[Felipe Sateler]

On Sat, 12 Nov 2016 21:09:12 +0100 Lucas Nussbaum  wrote:
> Source: node-groove
> Version: 2.5.0-1
> Severity: serious
> Tags: stretch sid
> User: debian...@lists.debian.org
> Usertags: qa-ftbfs-2016 qa-ftbfs
> Justification: FTBFS on amd64
>
> Hi,
>
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
>
> Relevant part (hopefully):
> > make[1]: Leaving directory '/<>'
> >debian/rules override_dh_auto_test
> > make[1]: Entering directory '/<>'
> > mocha --reporter spec
> >
> >  [0m [0m
> >
 [32m  ✓ [0m [90m version  [0m
> >
 [32m  ✓ [0m [90m logging  [0m
> >
 [32m  ✓ [0m [90m open fails for bogus file  [0m
> >
 [32m  ✓ [0m [90m open file and read metadata  [0m
> >
 [32m  ✓ [0m [90m update metadata  [0m
> >
 [32m  ✓ [0m [90m create empty playlist  [0m
> > Failed to create secure directory (/sbuild-nonexistent/.config/pulse): No 
> > such file or directory
> >
 [32m  ✓ [0m [90m create empty player  [0m
> >
 [32m  ✓ [0m [90m playlist item ids  [0m
> > debian/rules:20: recipe for target 'override_dh_auto_test' failed
>
> The full build log is available from:
>http://aws-logs.debian.net/2016/11/11/node-groove_2.5.0-1_unstable.log
>
> This failure happens on a CPU with TSX extensions available, but is not
> reproducible on a machine without them. For context, I recommend reading the
> thread starting at https://lists.debian.org/debian-devel/2016/11/msg00210.html


This suggests there is some wrong thread usage. Andrew, any idea what
could this be?

Saludos

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#844137: node-groove: FTBFS: Tests failures

[Lucas Nussbaum]

Source: node-groove
Version: 2.5.0-1
Severity: serious
Tags: stretch sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-2016 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> make[1]: Leaving directory '/<>'
>debian/rules override_dh_auto_test
> make[1]: Entering directory '/<>'
> mocha --reporter spec
> 
> 
> 
  ✓ version 
> 
  ✓ logging 
> 
  ✓ open fails for bogus file 
> 
  ✓ open file and read metadata 
> 
  ✓ update metadata 
> 
  ✓ create empty playlist 
> Failed to create secure directory (/sbuild-nonexistent/.config/pulse): No 
> such file or directory
> 
  ✓ create empty player 
> 
  ✓ playlist item ids 
> debian/rules:20: recipe for target 'override_dh_auto_test' failed

The full build log is available from:
   http://aws-logs.debian.net/2016/11/11/node-groove_2.5.0-1_unstable.log

This failure happens on a CPU with TSX extensions available, but is not
reproducible on a machine without them. For context, I recommend reading the
thread starting at https://lists.debian.org/debian-devel/2016/11/msg00210.html

The node used is an Amazon EC2 VM with 64 cores. /proc/cpuinfo says:
   model: 79
   model name : Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz
   stepping : 1

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel