Re: [Pkg-javascript-devel] Commit fixing node-waf
On 20/09/2012 16:49, David Paleino wrote: Hello everybody, I just made a commit to the nodejs package, fixing a bug I found in node-waf. This bug popped up while building node-mapnik (trying to fix its RC bug); in practice node-waf looks for /usr/bin/node instead of nodejs. Jonas, I looked through the patches that were already in the package, and I just added my fix to 2003_rename_node_to_nodejs.patch, since the name didn't specifically imply a change only to the manpage. Please feel free to split it in a separate patch, if you wish. The commit in question is: http://anonscm.debian.org/gitweb/?p=collab-maint/nodejs.git;a=commitdiff;h=25e0b0dbf0f8b8607c35a5e0ccceef11992c10db I won't upload a new version of nodejs until Jonas or Jérémy ACKs it. I'm okay with the patch and how you put it in 2003_rename_node_to_nodejs.patch. Before anything else, could you update nodejs Breaks relations to match the current status after your latest node-carto (al.) upload ? Jérémy. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Commit fixing node-waf
On Fri, 21 Sep 2012 09:52:49 +0200, Jérémy Lal wrote: I'm okay with the patch and how you put it in 2003_rename_node_to_nodejs.patch. Before anything else, could you update nodejs Breaks relations to match the current status after your latest node-carto (al.) upload ? What should I change? The versions look fine to me (apart from node-bones, which I already fixed). Can I upload nodejs? Thanks for your reply, David -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://deb.li/dapal `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] Commit fixing node-waf
On 12-09-21 at 11:15am, Jérémy Lal wrote: On 21/09/2012 10:59, David Paleino wrote: On Fri, 21 Sep 2012 09:52:49 +0200, Jérémy Lal wrote: I'm okay with the patch and how you put it in 2003_rename_node_to_nodejs.patch. Before anything else, could you update nodejs Breaks relations to match the current status after your latest node-carto (al.) upload ? What should I change? The versions look fine to me (apart from node-bones, which I already fixed). Nothing, i wasn't sure it was updated. Can I upload nodejs? I'm ok with that, but Jonas put a lot of work on it and we'd better wait for him to acknowledge latest changes. Me having put some work on this in the past shouldn't slow down further progress: Thanks for the concern, Jérémy but no need - I am more than happy that others contribute too, and am confident in the judgement of both of you guys. So if you feel it is better with more eyeballs (and you feel that my eyeballs count ;-) ) then nudge me about double-checking your changes. If you feel the package is ready for release, then do it - no need to ask me for permission or approval :-) - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
