Re: gwc - package review

[Jaromír Mikeš]

2017-07-19 22:17 GMT+02:00 IOhannes m zmölnig (Debian/GNU) <
umlae...@debian.org>:

> On 07/19/2017 02:37 PM, Jaromír Mikeš wrote:
> > 2017-07-19 13:11 GMT+02:00 IOhannes m zmölnig (Debian/GNU) <
> > umlae...@debian.org>:
> >
> >> On 2017-07-19 10:36, Jaromír Mikeš wrote:
> >>> 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
> >>> what leads to some issues
> >>
> >> just out of curiosity, why must the package be renamed?
> >> upstream's project name is still "gwc" [1], which happens to be an
> >> acronym of gtk-wave-cleaner as well.
> >> afaiu, the source code repository [2] uses 'gwc' as well.
> >>
> >> so i don't really see the point of introducing a package rename.
> >> instead i would just change the package description
> >
> >
> > Also binary is renamed
>
> hmm, before the "gwc" package had a "gnome-wave-cleaner" binary (so the
> package name differs from the binary name, but is an abbreviation), and
> now it would have a "gtk-wave-cleaner"  (so the package name still
> differs from the binary name, and is still an abbreviation).
> i honestly fail to see how this would warrant a package rename.
>
> > and install path with "package_name"  somehow
> > renaming package is solving many minor issues.
>
> at the expanse of creating a transition and confusing users :-(
>

Hmmm ... Ok I am going to revert renaming ...

mira
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: gwc - package review

[Debian/GNU]

On 07/19/2017 02:37 PM, Jaromír Mikeš wrote:
> 2017-07-19 13:11 GMT+02:00 IOhannes m zmölnig (Debian/GNU) <
> umlae...@debian.org>:
> 
>> On 2017-07-19 10:36, Jaromír Mikeš wrote:
>>> 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
>>> what leads to some issues
>>
>> just out of curiosity, why must the package be renamed?
>> upstream's project name is still "gwc" [1], which happens to be an
>> acronym of gtk-wave-cleaner as well.
>> afaiu, the source code repository [2] uses 'gwc' as well.
>>
>> so i don't really see the point of introducing a package rename.
>> instead i would just change the package description
> 
> 
> Also binary is renamed 

hmm, before the "gwc" package had a "gnome-wave-cleaner" binary (so the
package name differs from the binary name, but is an abbreviation), and
now it would have a "gtk-wave-cleaner"  (so the package name still
differs from the binary name, and is still an abbreviation).
i honestly fail to see how this would warrant a package rename.

> and install path with "package_name"  somehow
> renaming package is solving many minor issues.

at the expanse of creating a transition and confusing users :-(

gfmasdr
IOhannes



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: gwc - package review

[Jaromír Mikeš]

2017-07-19 14:37 GMT+02:00 Jaromír Mikeš :

> 2017-07-19 13:11 GMT+02:00 IOhannes m zmölnig (Debian/GNU) <
> umlae...@debian.org>:
>
>> On 2017-07-19 10:36, Jaromír Mikeš wrote:
>> > 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
>> > what leads to some issues
>>
>> just out of curiosity, why must the package be renamed?
>> upstream's project name is still "gwc" [1], which happens to be an
>> acronym of gtk-wave-cleaner as well.
>> afaiu, the source code repository [2] uses 'gwc' as well.
>>
>> so i don't really see the point of introducing a package rename.
>> instead i would just change the package description
>
>
> Also binary is renamed and install path with "package_name"  somehow
> renaming package is solving many minor issues.
>

Hi,

so in my opinion package is ready for upload now. Any objections?

best regards

mira
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: gwc - package review

[Jaromír Mikeš]

2017-07-19 13:11 GMT+02:00 IOhannes m zmölnig (Debian/GNU) <
umlae...@debian.org>:

> On 2017-07-19 10:36, Jaromír Mikeš wrote:
> > 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
> > what leads to some issues
>
> just out of curiosity, why must the package be renamed?
> upstream's project name is still "gwc" [1], which happens to be an
> acronym of gtk-wave-cleaner as well.
> afaiu, the source code repository [2] uses 'gwc' as well.
>
> so i don't really see the point of introducing a package rename.
> instead i would just change the package description


Also binary is renamed and install path with "package_name"  somehow
renaming package is solving many minor issues.

mira
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: gwc - package review

[Debian/GNU]

On 2017-07-19 10:36, Jaromír Mikeš wrote:
> 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
> what leads to some issues

just out of curiosity, why must the package be renamed?
upstream's project name is still "gwc" [1], which happens to be an
acronym of gtk-wave-cleaner as well.
afaiu, the source code repository [2] uses 'gwc' as well.

so i don't really see the point of introducing a package rename.
instead i would just change the package description.


fgamsr
IOhannes

[1] http://gwc.sf.net
[2] https://github.com/AlisterH/gwc

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: gwc - package review

[James Cowgill]

Hi,

On 19/07/17 11:34, Jaromír Mikeš wrote:
> 2017-07-19 11:04 GMT+02:00 James Cowgill :
> On 19/07/17 09:36, Jaromír Mikeš wrote:
>> 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
>>> what leads to some issues
>>> W: gwc: duplicate-changelog-files
>>> usr/share/doc/gtk-wave-cleaner/Changelog.gz
>> usr/share/doc/gwc/changelog.gz
>>> W: gwc: extra-license-file usr/share/doc/gtk-wave-cleaner/COPYING.gz
>>
>> Err you haven't renamed the package. You should be installing all
>> documentation into /usr/share/doc/
> 
> I renamed package now ... I guess there should some dummy gwc package for
> smooth transition to gtk-wave-cleaner package?

Yes you'll need to keep a dummy gwc package around until after buster is
released.

https://wiki.debian.org/RenamingPackages#Transition_package_method

Thanks,
James



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: gwc - package review

[Jaromír Mikeš]

2017-07-19 11:04 GMT+02:00 James Cowgill :

Hi James,

On 19/07/17 09:36, Jaromír Mikeš wrote:
> > I just updated gwc package - but there are still some minor issues.
> > Would be great if someone could review it and help to fix them.
>
> I assume you've seen #868841 (which is not a minor issue).
>

Not seen it in time of writing, but now fixed

> 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
> > what leads to some issues
> > W: gwc: duplicate-changelog-files
> > usr/share/doc/gtk-wave-cleaner/Changelog.gz
> usr/share/doc/gwc/changelog.gz
> > W: gwc: extra-license-file usr/share/doc/gtk-wave-cleaner/COPYING.gz
>
> Err you haven't renamed the package. You should be installing all
> documentation into /usr/share/doc/
>

I renamed package now ... I guess there should some dummy gwc package for
smooth transition to gtk-wave-cleaner package?

> 2) I guess some flags are not passed correctly and dbgsym package is not
> > build.
>
> The upstream install script strips the binary:
> > install -p -s gtk-wave-cleaner "/<>/debian/tmp"/usr/bin
>
> (remove the -s option)
>

 Done:)

mira
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: gwc - package review

[James Cowgill]

Hi,

On 19/07/17 09:36, Jaromír Mikeš wrote:
> I just updated gwc package - but there are still some minor issues.
> Would be great if someone could review it and help to fix them.

I assume you've seen #868841 (which is not a minor issue).

> 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
> what leads to some issues
> W: gwc: duplicate-changelog-files
> usr/share/doc/gtk-wave-cleaner/Changelog.gz usr/share/doc/gwc/changelog.gz
> W: gwc: extra-license-file usr/share/doc/gtk-wave-cleaner/COPYING.gz

Err you haven't renamed the package. You should be installing all
documentation into /usr/share/doc/

> 2) I guess some flags are not passed correctly and dbgsym package is not
> build.

The upstream install script strips the binary:
> install -p -s gtk-wave-cleaner "/<>/debian/tmp"/usr/bin

(remove the -s option)

James



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

gwc - package review

[Jaromír Mikeš]

Hi,

I just updated gwc package - but there are still some minor issues.
Would be great if someone could review it and help to fix them.

1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
what leads to some issues
W: gwc: duplicate-changelog-files
usr/share/doc/gtk-wave-cleaner/Changelog.gz usr/share/doc/gwc/changelog.gz
W: gwc: extra-license-file usr/share/doc/gtk-wave-cleaner/COPYING.gz

2) I guess some flags are not passed correctly and dbgsym package is not
build.

best regards

mira
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers