Re: Firefox Bookmark runner
On Mon, Nov 2, 2009 at 9:50 PM, Aaron J. Seigo ase...@kde.org wrote: On November 2, 2009, Eduardo Robles Elvira wrote: http://github.com/edulix/gsoc/blob/master/kdebase-bookmarks.patch, take a look only at the workspace/plasma part of it). In case this new bookmarks system ships in, I don't know if mixing the firefox and konqueror bookmarks in nepomuk runner would be a good idea? What could be the best way in that case? the nice thing about having the Bookmarks as a separate runner is that we can get those returns quicker or slower than other data sets as they get their own thread to run in AND people can turn off Bookmarks searching easier when it's a separate plugin. so my question is whether the Nepomuk search runner should really be confined to just files on disk and other queries for things like Bookmarks be added to separate runners (like the existing Bookmarks runner)? Hi people, Now, thinking about this again, I wonder: lets say that in the near future, konqueror bookmarks are directly stored in Nepomuk (which quite possible). If we put bookmarks in a separate runner.. then both the Nepomuk runner and the Bookmarks runner will return the same entries when searching for a given bookmark. How could we deal with these duplicated entries? Regards, Eduardo Robles Elvira. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Kubuntu patches to plasma in kdelibs
Kubuntu has a couple of patches to plasma in kdelibs, here's a quick review in the interests of distro/upstream hugs. kubuntu_19_no_indent_kickoff_subtext.diff Removes the text intentation from kickoff and elsewhere, it was added on Celeste's advice. I'm pretty sure it's been discussed here before so no need to start a long thread :) http://bazaar.launchpad.net/%7Ekubuntu-members/kdelibs/ubuntu/annotate/head%3A/debian/patches/kubuntu_19_no_indent_kickoff_subtext.diff kubuntu_71_netbook_add_plasmawindoweffects.diff is backported from 4.4 http://bazaar.launchpad.net/%7Ekubuntu-members/kdelibs/ubuntu/annotate/head%3A/debian/patches/kubuntu_71_netbook_add_plasmawindoweffects.diff kubuntu_68_remove_applet_confirmation.diff I'm not sure where it came from but it allows the option to need a confirmation before removing a plasma widget. We don't turn this on by default and it includes the word hack written in capital letters so I'm not terribly keen on keeping it, but it seems like a not unreasonable idea in general if a UI was added. http://bazaar.launchpad.net/%7Ekubuntu-members/kdelibs/ubuntu/annotate/head%3A/debian/patches/kubuntu_68_remove_applet_confirmation.diff Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: can qtscript plasmoids load C++ qtscript plugins
On Tue, Nov 10, 2009 at 2:56 PM, Aaron J. Seigo ase...@kde.org wrote: On November 10, 2009, Ian Monroe wrote: Ok from talking more in IRC, it sounds like the idea is to have GPG signing of qtscript plasmoids, and then allow them to use the features they ask for. Unlike with C++, it can really be enforced that they only use the features they declare they need. right; which is one of the big benefits imho of using scripting. Amarok just added GPG signing for its scripts, I don't think its a big deal to add this. is this something that could be put into Plasma::Package and used by Amarok from there? would be great to share this code. Amarok scripts don't have much to do with plasmoids, so no not really. If we wanted to share code it would have to be in the form of some sort of kdelibs package signing library. But I'm not sure it makes sense to abstract QCA, it doesn't take much code. Ian ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Moving mediawiki runner to kdereview
I've just moved a runner that searches in Mediawikis to kdereview, for inclusion in 4.4. The runner can search in arbitrary mediawikis, you need to specify which mediawiki to search in its .desktop file. (If you want to add search for another mediawiki, just add a .desktop file for it, and you'll be fine). A line such as X-Plasma-Args=http://techbase.kde.org/api.php tells the runner where to query, this differs per mediawiki instance and is the only needed configuration option (other than name, comment and icon, of course). I've currently added support for techbase and wikipedia, it's of course trivial to do more. There's also a .desktop file for userbase, which doesn't work (probably userbase's XML api is disabled). The mediawiki runner has been written by Richard Moore and me and is (hopefully) one of the first pieces of Project Silk going into KDE. Please let me know if there's anything wrong with it, or where you see room for improvement and I'll address it. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Firefox Bookmark runner
On November 12, 2009, Marco Martin wrote: -the nepomuk runner excludes bookmarks, or that really seems to me to be the most sensible thing to do. a nepomuk runner shouldn't return every imaginable thing stored in nepomuk, but should probably be focused by topic, much like every other runner currently is. this assumes that nepomuk itself can gracefully handle multiple concurrent queries. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kubuntu patches to plasma in kdelibs
On November 12, 2009, Jonathan Riddell wrote: Kubuntu has a couple of patches to plasma in kdelibs, here's a quick review in the interests of distro/upstream hugs. kubuntu_19_no_indent_kickoff_subtext.diff Removes the text intentation from kickoff and elsewhere, it was added on Celeste's advice. I'm pretty sure it's been discussed here before so no need to start a long thread :) probably hasn't been discussed since the threads about whether or not to paint all subtitles all the time or only on hover, actually. the indent could probably be done away with at this point now that that issue is firmly put to bed. kubuntu_68_remove_applet_confirmation.diff I'm not sure where it came from but it allows the option to need a confirmation before removing a plasma widget. We don't turn this on by default and it includes the word hack written in capital letters so I'm not terribly keen on keeping it, but it seems like a not unreasonable idea in general if a UI was added. it should also be checking for containment()-containmentType() != Containment::CustomPanelContainment personally, i'm not a fan of are you sure, yes, yes? dialogs everywhere. that it doesn't work everywhere is a deal breaker, but even then removing widgets by accident doesn't seem to be a huge problem in the wild. i'd prefer to see the ability save/restore specific layouts as a more interesting solution to these kinds of potential issues. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/#review3063 --- trunk/KDE/kdelibs/plasma/abstractrunner.h http://reviewboard.kde.org/r/2090/#comment2487 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the need to explain how it works in the apidox :) trunk/KDE/kdelibs/plasma/runnercontext.h http://reviewboard.kde.org/r/2090/#comment2488 sounds like something that should take a bool? also, some extra ws snuck in there :) trunk/KDE/kdelibs/plasma/runnermanager.h http://reviewboard.kde.org/r/2090/#comment2489 const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then replaceEmptyQuery should be implied? - Aaron On 2009-11-07 20:16:02, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-07 20:16:02) Review request for Plasma, Aaron Seigo and Ryan Bitanga. Summary --- This is the API needed by the new single Runner mode for krunner (more on usecases in part II:krunner) for kdelibs; A runner can now optionally define a Default syntax; if this is the case, the runner will be exposed as single-runner-mode capable. On request, the default syntax will be replaced to the empty query in RunnerManager::launchQuery. The context is aware of the fact that we are in single runner query mode in case the runners need to change their behaviour accordingly (e.g. to _not_ discard queries with less than 3 chars) Diffs - trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 Diff: http://reviewboard.kde.org/r/2090/diff Testing --- Thanks, Jacopo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/#review3064
---
the line edit for the single query mode should probably have a click text that
comes from the name or description of the runner being used; maybe it would
even be useful to put a label next to the icon with the name of the runner, so
it's really evident what's going on?
trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml
http://reviewboard.kde.org/r/2091/#comment2492
perhaps querySingleRunner?
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp
http://reviewboard.kde.org/r/2091/#comment2493
if (singleRunnerMode()) {
} else if (!term.isEmpty()) {
}
might be a bit clearer to read
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp
http://reviewboard.kde.org/r/2091/#comment2496
adjustInterface(bool) is redundant; may as well just have one method,
setStaticQueryMode(bool)
trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp
http://reviewboard.kde.org/r/2091/#comment2490
please watch the whitespace inside of ()s .. :)
trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp
http://reviewboard.kde.org/r/2091/#comment2491
isn't that a no-op due to:
void KRunnerApp::singleRunnerMode(const QString runnerName)
{
if ( runnerName.isEmpty() ) {
return;
- Aaron
On 2009-11-07 20:29:26, Jacopo De Simoi wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/
---
(Updated 2009-11-07 20:29:26)
Review request for Plasma, Aaron Seigo and Ryan Bitanga.
Summary
---
This patch adds single runner query support to krunner;
When loading the runners, if any runner supports a defaultSyntax, then this
is exposed via an action which shows up in the global shortcuts;
When this action is triggered, krunner starts in single-runner-query mode;
i.e. queries are processed by the selected runner only; the interfaces
changes slightly to reflect this fact (screenshot) and the query given by
the default syntax is automatically run.
Also a convenient dbus interface is added, in case we want to trigger this
internally;
The most obvious usecase is the windows runner; an upcoming devicerunner and
also the nepomuk search runner could make use of this feature.
Diffs
-
trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml 1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.h
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/krunnerapp.h 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1046190
Diff: http://reviewboard.kde.org/r/2091/diff
Testing
---
Screenshots
---
Window runner in single runner mode
http://reviewboard.kde.org/r/2091/s/255/
Thanks,
Jacopo
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406 http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the need to explain how it works in the apidox :) well, the correct name should indeed be addSyntaxAndSetAsDefault, but I guess it's a little bit too much :) On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/runnercontext.h, lines 180-181 http://reviewboard.kde.org/r/2090/diff/1/?file=13851#file13851line180 sounds like something that should take a bool? also, some extra ws snuck in there :) agreed On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/runnermanager.h, line 149 http://reviewboard.kde.org/r/2090/diff/1/?file=13853#file13853line149 const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then replaceEmptyQuery should be implied? In fact it should. I was worried of changing the default behaviour of this method. I was not sure to be able to check that this wouldn't affect any other app using runnermanager (kickoff?) - Jacopo --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/#review3063 --- On 2009-11-07 20:16:02, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-07 20:16:02) Review request for Plasma, Aaron Seigo and Ryan Bitanga. Summary --- This is the API needed by the new single Runner mode for krunner (more on usecases in part II:krunner) for kdelibs; A runner can now optionally define a Default syntax; if this is the case, the runner will be exposed as single-runner-mode capable. On request, the default syntax will be replaced to the empty query in RunnerManager::launchQuery. The context is aware of the fact that we are in single runner query mode in case the runners need to change their behaviour accordingly (e.g. to _not_ discard queries with less than 3 chars) Diffs - trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 Diff: http://reviewboard.kde.org/r/2090/diff Testing --- Thanks, Jacopo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)
On 2009-11-12 20:53:01, Aaron Seigo wrote:
the line edit for the single query mode should probably have a click text
that comes from the name or description of the runner being used; maybe it
would even be useful to put a label next to the icon with the name of the
runner, so it's really evident what's going on?
Clickmessage would be cool, however, since the lineedit immediately gets focus,
it is never shown so it is useless.
A label could be a solution indeed;
The issue is: what should the label read? just the name of the runner?
On 2009-11-12 20:53:01, Aaron Seigo wrote:
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp, lines
446-449
http://reviewboard.kde.org/r/2091/diff/1/?file=13857#file13857line446
adjustInterface(bool) is redundant; may as well just have one method,
setStaticQueryMode(bool)
my only concern was to give methods a meaningful name; adjustInterface does
more than setting the static query mode or not
On 2009-11-12 20:53:01, Aaron Seigo wrote:
trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp, line 305
http://reviewboard.kde.org/r/2091/diff/1/?file=13862#file13862line305
isn't that a no-op due to:
void KRunnerApp::singleRunnerMode(const QString runnerName)
{
if ( runnerName.isEmpty() ) {
return;
actually it's
void KRunnerDialog::setSingleRunnerMode(QString runnerName)
{
m_singleRunnerId = runnerName;
if (runnerName.isEmpty()) {
return;
}
...
KRunnerApp::singleRunnermode is the dbus method, whose name will be changed :)
- Jacopo
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/#review3064
---
On 2009-11-07 20:29:26, Jacopo De Simoi wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/
---
(Updated 2009-11-07 20:29:26)
Review request for Plasma, Aaron Seigo and Ryan Bitanga.
Summary
---
This patch adds single runner query support to krunner;
When loading the runners, if any runner supports a defaultSyntax, then this
is exposed via an action which shows up in the global shortcuts;
When this action is triggered, krunner starts in single-runner-query mode;
i.e. queries are processed by the selected runner only; the interfaces
changes slightly to reflect this fact (screenshot) and the query given by
the default syntax is automatically run.
Also a convenient dbus interface is added, in case we want to trigger this
internally;
The most obvious usecase is the windows runner; an upcoming devicerunner and
also the nepomuk search runner could make use of this feature.
Diffs
-
trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml 1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.h
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/krunnerapp.h 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1046190
Diff: http://reviewboard.kde.org/r/2091/diff
Testing
---
Screenshots
---
Window runner in single runner mode
http://reviewboard.kde.org/r/2091/s/255/
Thanks,
Jacopo
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406 http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the need to explain how it works in the apidox :) Jacopo De Simoi wrote: well, the correct name should indeed be addSyntaxAndSetAsDefault, but I guess it's a little bit too much :) i think setDefaultSyntax implies it will become part of the syntax bunch; perhaps a note in the apidox that it isn't necessary to to also call addSyntax and a check to ensure it isn't already in the collection might be in order. On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/runnermanager.h, line 149 http://reviewboard.kde.org/r/2090/diff/1/?file=13853#file13853line149 const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then replaceEmptyQuery should be implied? Jacopo De Simoi wrote: In fact it should. I was worried of changing the default behaviour of this method. I was not sure to be able to check that this wouldn't affect any other app using runnermanager (kickoff?) i don't see how it could affect any other users; if they don't call setSingleRunnerMode(true) it behaves exactly as it did before. so it would require purposefully changing the code in the other places it is used to cause problems :) - Aaron --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/#review3063 --- On 2009-11-07 20:16:02, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-07 20:16:02) Review request for Plasma, Aaron Seigo and Ryan Bitanga. Summary --- This is the API needed by the new single Runner mode for krunner (more on usecases in part II:krunner) for kdelibs; A runner can now optionally define a Default syntax; if this is the case, the runner will be exposed as single-runner-mode capable. On request, the default syntax will be replaced to the empty query in RunnerManager::launchQuery. The context is aware of the fact that we are in single runner query mode in case the runners need to change their behaviour accordingly (e.g. to _not_ discard queries with less than 3 chars) Diffs - trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 Diff: http://reviewboard.kde.org/r/2090/diff Testing --- Thanks, Jacopo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)
On 2009-11-12 20:53:01, Aaron Seigo wrote:
the line edit for the single query mode should probably have a click text
that comes from the name or description of the runner being used; maybe it
would even be useful to put a label next to the icon with the name of the
runner, so it's really evident what's going on?
Jacopo De Simoi wrote:
Clickmessage would be cool, however, since the lineedit immediately gets
focus, it is never shown so it is useless.
A label could be a solution indeed;
The issue is: what should the label read? just the name of the runner?
the name of the runner should be enough; hopefully it also looks good :)
On 2009-11-12 20:53:01, Aaron Seigo wrote:
trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp, line 305
http://reviewboard.kde.org/r/2091/diff/1/?file=13862#file13862line305
isn't that a no-op due to:
void KRunnerApp::singleRunnerMode(const QString runnerName)
{
if ( runnerName.isEmpty() ) {
return;
Jacopo De Simoi wrote:
actually it's
void KRunnerDialog::setSingleRunnerMode(QString runnerName)
{
m_singleRunnerId = runnerName;
if (runnerName.isEmpty()) {
return;
}
...
KRunnerApp::singleRunnermode is the dbus method, whose name will be
changed :)
ah, good. :)
- Aaron
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/#review3064
---
On 2009-11-07 20:29:26, Jacopo De Simoi wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2091/
---
(Updated 2009-11-07 20:29:26)
Review request for Plasma, Aaron Seigo and Ryan Bitanga.
Summary
---
This patch adds single runner query support to krunner;
When loading the runners, if any runner supports a defaultSyntax, then this
is exposed via an action which shows up in the global shortcuts;
When this action is triggered, krunner starts in single-runner-query mode;
i.e. queries are processed by the selected runner only; the interfaces
changes slightly to reflect this fact (screenshot) and the query given by
the default syntax is automatically run.
Also a convenient dbus interface is added, in case we want to trigger this
internally;
The most obvious usecase is the windows runner; an upcoming devicerunner and
also the nepomuk search runner could make use of this feature.
Diffs
-
trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml 1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.h
1046190
trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp
1046190
trunk/KDE/kdebase/workspace/krunner/krunnerapp.h 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1046190
trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1046190
Diff: http://reviewboard.kde.org/r/2091/diff
Testing
---
Screenshots
---
Window runner in single runner mode
http://reviewboard.kde.org/r/2091/s/255/
Thanks,
Jacopo
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kubuntu patches to plasma in kdelibs
On Thu, Nov 12, 2009 at 8:30 PM, Aaron J. Seigo ase...@kde.org wrote: personally, i'm not a fan of are you sure, yes, yes? dialogs everywhere. that it doesn't work everywhere is a deal breaker, but even then removing widgets by accident doesn't seem to be a huge problem in the wild. i'd prefer to see the ability save/restore specific layouts as a more interesting solution to these kinds of potential issues. Having an undo facility here would seem a nicer solution. Rich. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/runnermanager.h, line 149 http://reviewboard.kde.org/r/2090/diff/1/?file=13853#file13853line149 const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then replaceEmptyQuery should be implied? Jacopo De Simoi wrote: In fact it should. I was worried of changing the default behaviour of this method. I was not sure to be able to check that this wouldn't affect any other app using runnermanager (kickoff?) Aaron Seigo wrote: i don't see how it could affect any other users; if they don't call setSingleRunnerMode(true) it behaves exactly as it did before. so it would require purposefully changing the code in the other places it is used to cause problems :) aw, I should really read the whole comment before replying. In fact your comment makes perfect sense On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406 http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the need to explain how it works in the apidox :) Jacopo De Simoi wrote: well, the correct name should indeed be addSyntaxAndSetAsDefault, but I guess it's a little bit too much :) Aaron Seigo wrote: i think setDefaultSyntax implies it will become part of the syntax bunch; perhaps a note in the apidox that it isn't necessary to to also call addSyntax and a check to ensure it isn't already in the collection might be in order. agreed - Jacopo --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/#review3063 --- On 2009-11-07 20:16:02, Jacopo De Simoi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-07 20:16:02) Review request for Plasma, Aaron Seigo and Ryan Bitanga. Summary --- This is the API needed by the new single Runner mode for krunner (more on usecases in part II:krunner) for kdelibs; A runner can now optionally define a Default syntax; if this is the case, the runner will be exposed as single-runner-mode capable. On request, the default syntax will be replaced to the empty query in RunnerManager::launchQuery. The context is aware of the fact that we are in single runner query mode in case the runners need to change their behaviour accordingly (e.g. to _not_ discard queries with less than 3 chars) Diffs - trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 Diff: http://reviewboard.kde.org/r/2090/diff Testing --- Thanks, Jacopo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Webslice applet moved to kdereview
Hey, I've just moved the webslice plasmoid to kdereview, for inclusion in KDE 4.4. The webslice applet is there to put an interactive part of a webpage onto Plasma as an applet. You can specify an element with a CSS selector (a.k.a. the nice way) or by its geometry (the way that works for semantically-not-so-nice webpages, but can easily break). This can be handy if you want to monitor only the news box on a webpage, for example. The webslice widget uses Qt WebKit for rendering the element and is fully interactive. I'm planning to make use of the KDE integration soon that has just entered kdelibs, so we also share cookies and login information. There are two widgets coming along with this. First, a SliceGraphicsWidget which is used inside the plasmoid, and a QWidget, which basically wraps the SliceGraphicsWidget. Those are possible candidates for inclusion into kdelibs, if other developers want to use this as well. If you use the qmake-based build, you get a small binary you can play around with. The webslice plasmoid has been written by Richard Moore and me with the help of some of the qtwebkit guys and is another early part of Silk we'd like to see merged. Please let me know if there's anything wrong with it, or where you see room for improvement and I'll address it. Thanks, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
Hi there, Cool stuff. I don't know about the Plasma naming, but we are trying to not call anything but base classes for *Widget. Plasma widgets are by default GraphicsItems right? So what about Plasma::WebSlice? and then call the QWidget for KWebSlide? Just a suggestion :-) Kenneth On Thu, Nov 12, 2009 at 9:51 PM, Sebastian Kügler se...@kde.org wrote: Hey, I've just moved the webslice plasmoid to kdereview, for inclusion in KDE 4.4. The webslice applet is there to put an interactive part of a webpage onto Plasma as an applet. You can specify an element with a CSS selector (a.k.a. the nice way) or by its geometry (the way that works for semantically-not-so-nice webpages, but can easily break). This can be handy if you want to monitor only the news box on a webpage, for example. The webslice widget uses Qt WebKit for rendering the element and is fully interactive. I'm planning to make use of the KDE integration soon that has just entered kdelibs, so we also share cookies and login information. There are two widgets coming along with this. First, a SliceGraphicsWidget which is used inside the plasmoid, and a QWidget, which basically wraps the SliceGraphicsWidget. Those are possible candidates for inclusion into kdelibs, if other developers want to use this as well. If you use the qmake-based build, you get a small binary you can play around with. The webslice plasmoid has been written by Richard Moore and me with the help of some of the qtwebkit guys and is another early part of Silk we'd like to see merged. Please let me know if there's anything wrong with it, or where you see room for improvement and I'll address it. Thanks, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Kenneth Rohde Christiansen Technical Lead / Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
On November 12, 2009, Kenneth Christiansen wrote: Plasma widgets are by default GraphicsItems right? So what about Plasma::WebSlice? and then call the QWidget for KWebSlide? +1 on Plasma::WebSlice if it goes into libplasma; otherwise KGraphicsWebSliceWidget to go the route of the Qt naming of QGraphicsFoo[Item|Widget] -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
Qt 4.6 has QGraphicsWebView :-) which is a QGraphicsWidget. If we would make a QGraphics version of, lets say, QLineEdit, it would probably be called QGraphicsLineEdit and not QGraphicsLineEditWidget. That was more or less the consensus we had when naming the QGraphicsWebView (which was renamed some times along the way :-)) If you go with KGraphics, I would prefer KGraphicsWebSlide. Cheers! On Thu, Nov 12, 2009 at 11:05 PM, Aaron J. Seigo ase...@kde.org wrote: On November 12, 2009, Kenneth Christiansen wrote: Plasma widgets are by default GraphicsItems right? So what about Plasma::WebSlice? and then call the QWidget for KWebSlide? +1 on Plasma::WebSlice if it goes into libplasma; otherwise KGraphicsWebSliceWidget to go the route of the Qt naming of QGraphicsFoo[Item|Widget] -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Kenneth Rohde Christiansen Technical Lead / Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
kubuntu kdebase patches to plasma
The second in our series of periodical reviews of patches we include to Plasma. kubuntu_19_always_show_kickoff_subtext.diff, the subtexts in kickoff sometimes show always and sometimes on mouse over, this makes that consistent. It's been discussed here before. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_19_always_show_kickoff_subtext.diff kubuntu_71_default_plasma_layout.diff has our changes to the default layout. We used to do this with a config file override but that was unreliable. It adds the microblog applet to the desktop (social from the start, all the rage). It adds quickaccess, showdesktop, networkmanagement and our indicatordisplay applets to the panel. The clock shows the date by default, because I like to know what day it is. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_71_default_plasma_layout.diff kubuntu_91_plasma_autostart_condition.desktop is added so we can stop plasma-desktop being run for netbook edition. It would be good to find a better way to select between plasma-desktop and plasma-netbook, preferably as an X session at KDM. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_91_plasma_autostart_condition.desktop kubuntu_94_netbook_runner.diff comes from the netbook people, I believe it's in trunk. kubuntu_101_brightness_fn_keys_and_osd.diff adds a brightness on screen widget for brightness keys, it also needs patches to Qt and kdelibs to work http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_101_brightness_fn_keys_and_osd.diff c'est tout Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
On November 12, 2009, Kenneth Christiansen wrote: If you go with KGraphics, I would prefer KGraphicsWebSlide. fair enough :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kubuntu kdebase patches to plasma
On November 12, 2009, Jonathan Riddell wrote: kubuntu_19_always_show_kickoff_subtext.diff, the subtexts in kickoff sometimes show always and sometimes on mouse over, this makes that consistent. It's been discussed here before. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/ann otate/head%3A/debian/patches/kubuntu_19_always_show_kickoff_subtext.diff this patch is, usability-wise, wrong. the subtexts are shown when disambiguation is necessary. otherwise you need to mouse over them to figure out what's what. kubuntu_71_default_plasma_layout.diff has our changes to the default layout. We used to do this with a config file override but that was unreliable. It adds the microblog applet to the desktop (social from the start, all the rage). It adds quickaccess, showdesktop, networkmanagement and our indicatordisplay applets to the panel. The clock shows the date by default, because I like to know what day it is. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/ann otate/head%3A/debian/patches/kubuntu_71_default_plasma_layout.diff in 4.4 and beyond, you should use a plasma-desktop javascript for this. all the flexibility you could ever want and then some, and you won't need to carry a patch. see the docs in kdebase/workspace/plasma/design/plasma-desktop- scripting and the examples in kdeexamples. kubuntu_91_plasma_autostart_condition.desktop is added so we can stop plasma-desktop being run for netbook edition. It would be good to find a better way to select between plasma-desktop and plasma-netbook, preferably as an X session at KDM. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/ann otate/head%3A/debian/patches/kubuntu_91_plasma_autostart_condition.desktop marco recently implemented this for 4.4. marco can elaborate. kubuntu_101_brightness_fn_keys_and_osd.diff adds a brightness on screen widget for brightness keys, it also needs patches to Qt and kdelibs to work http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/ann otate/head%3A/debian/patches/kubuntu_101_brightness_fn_keys_and_osd.diff if the patch is upstreamed in Qt, we can take a look at this one more closely. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
can qtscript plasmoids load C++ qtscript plugins
On Monday 09 November 2009, Ian Monroe wrote: I suspect the answer to the subject is no since I haven't found a mention of a method to do it. But I also haven't found comprehensive QtScript API docs. :) QtScript apidocs are generated in Qt labs project qtscriptgenerator. My situation is that I want to write a full chat solution in a qtscript plasmoid using the QtScript Telepathy bindings I wrote. (I'm guessing a dataengine or service for buddy presence and chatting would be pretty crazy right?) We have created couple of soulutions where this kind of importing bindings is possible, so I'm more than a willing to start a discussion how to proceed with this kind of ideas in plasma. Our idea allows creation of plasmoids that have qtscript inside to your own plama desktop environment. We can extend plasma in a way that allows user to write own script with for example Kate or download it from http url. The basic idea is that only text is read and script is evaluated. All that you need for this is the qtscript-bindings that for example amarok uses. What this could offer, would be pretty much the same that the Qt-lively project offers in here: http://lively.cs.tut.fi/qt/videos.html All the widgets can be run also in our system. What do you deveopers think? Should plasma be able add these kind of widgets. Or should it be better to just create plasmoid that enables importing this kind of functionality inside. I could upload the plasmoid sources to kde, but I'm not yet a plasma developer. -- -- Pekka Reijula -- reij...@gmail.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
