Re: Review Request: Reset time format upon user request
On Sunday 18 December 2011 20:26:42 Lamarque V. Souza wrote: Em Sunday 18 December 2011, David Faure escreveu: On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote: Another problem with this approach is that we cannot prevent anybody else from listening to KGlobalSettings::self()-emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTING_LOCALE). What would be wrong with that? It would be the way to have a GUI that reacts to changes in the locale settings. Every app and in particular date/time widgets might want to listen to that and adapt. Or did I misunderstand what this was about? You misunderstood what I meant. You removed that paragraph from the context of the first paragraph of my last e-mail. What I meant is that if we use something like KLocale::commit() then we should not let others use KGlobalSettings::self()emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTING_LOCALE). Minor issue. It would be harmless to signal a change when nothing changed. The same is true for every other SETTING_* in there. Anyone can emit the desktop path has changed, but if it wasn't changed, then nothing will happen anyway. The problem with KGlobalSettings::SETTING_LOCALE is that is solves only half the problem. I am using a hack to force the local KLocale instance in the clock plasmoid to reload the configuration files. There is no API in kdelibs to reload KLocale's configuration files and that is why I suggested using something like KLocale::commit() when Aaron complained about my second review of this patch. Adding a commit() that is called after setFoo() calls, sounds good. If everyone only went for the minimal lines of code fix all the time, we would have one hell of a mess by now... I am not familiar with this part of kdelibs and it is very clear it is a very sensible part of kdelibs. Anything wrong here will be noticed by everybody, that is why I am trying to do the minimum in this case. This is what reviews are for. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Small QML related questions...
On Monday, December 19, 2011 06:32:17 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: On Sunday 18 December 2011 22:07:46 Aaron J. Seigo wrote: On Sunday, December 18, 2011 18:43:06 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: Hi all, three small QML/Plasma related questions that came up while working on Kickoff and no notmart on IRC to ping ;-). All are related to changing layout based on location. 1. How to get the enum values LeftEdge, TopEdge and so on. I get plasmoid.location but that's just a number. No matter what I tried QML gave me an undefined value for the edge values. should be just: LeftEdge. no, that did not work. hmm... that's in the JS bindings and i confirmed it existed before i replied; where in your QML are you trying to use it? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Small QML related questions...
Am 19.12.2011 11:02, schrieb Aaron J. Seigo: On Monday, December 19, 2011 06:32:17 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: On Sunday 18 December 2011 22:07:46 Aaron J. Seigo wrote: On Sunday, December 18, 2011 18:43:06 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: Hi all, three small QML/Plasma related questions that came up while working on Kickoff and no notmart on IRC to ping ;-). All are related to changing layout based on location. 1. How to get the enum values LeftEdge, TopEdge and so on. I get plasmoid.location but that's just a number. No matter what I tried QML gave me an undefined value for the edge values. should be just: LeftEdge. no, that did not work. hmm... that's in the JS bindings and i confirmed it existed before i replied; where in your QML are you trying to use it? I'll ping you this evening when I'm back home and give you my current patch on top of kickoff branch Cheers Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: plasmoid web slice - disable geometryEdit if not needed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103468/ --- Review request for Plasma. Description --- title says it all. this patch is related to https://bugs.kde.org/show_bug.cgi?id=284459#c2 but does not fix that bug. Diffs - applets/webslice/plasma/webslice.h fbe1242 applets/webslice/plasma/webslice.cpp a1740bf Diff: http://git.reviewboard.kde.org/r/103468/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: qtcomponents documentation
On Saturday 17 December 2011, Aaron J. Seigo wrote: On Saturday, December 17, 2011 13:39:05 Marco Martin wrote: Hi all, I think we should do a real documentation sprint for the plasma qtcomponents, to have a good api doc for the 4.8 release. and ideas / preferences on when and where? btw, this is the result of a very quick and dirty perl script on the button documentation: http://notmart.org/buttondocs.html so is possible to have something automated on the kde infra that has decent results Antonis is working on a prettier one in python, after the due tests i would like to have it run somewhere on a server Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/ --- Review request for kdelibs and Plasma. Description --- This is patch number 3 to fix bug #289094 (top bar time incorrectly displays in 24 hour format). The other patches are against plasma-mobile and kde-workspace (http://git.reviewboard.kde.org/r/103434), all three patches must be applied to fix the bug. I think this is a much simpler solution than the one I suggested in http://git.reviewboard.kde.org/r/103434. This addresses bug 289094. http://bugs.kde.org/show_bug.cgi?id=289094 Diffs - kdeui/kernel/kglobalsettings.h cb8f7e2 kdeui/kernel/kglobalsettings.cpp 819b314 Diff: http://git.reviewboard.kde.org/r/103469/diff/diff Testing --- Thanks, Lamarque Vieira Souza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Reset time format upon user request
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/ --- (Updated Dec. 19, 2011, 2:03 p.m.) Review request for kdelibs and Plasma. Changes --- Use patch http://git.reviewboard.kde.org/r/103469 (against kdelibs). This patch is trivial now, if review 103469 is approved I will commit this one as well since kde-workspace will not compile with this one applied and without patch 103469 applied against kdelibs. Description --- The patch resets time format in digital clock plasmoid when the user changes the 24h configuration in active-settings. The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering if I should add this change to kdelibs instead of kde-workspace to avoid duplicating code. Anyway, I wanted someone to review the code to see if there can be any side effect. This addresses bug 289094. http://bugs.kde.org/show_bug.cgi?id=289094 Diffs (updated) - plasma/generic/applets/digital-clock/clock.h 4aec3fd plasma/generic/applets/digital-clock/clock.cpp dd03692 Diff: http://git.reviewboard.kde.org/r/103434/diff/diff Testing --- Works in Plasma Active. In Plasma Desktop kcmlocale does not call KGlobalSettings::self()-emitChange(KGlobalSettings::SettingsChanged) so it does not take effect. Other kcm modules (e.g. keyboard), call emitChange. Thanks, Lamarque Vieira Souza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review9078 --- kdeui/kernel/kglobalsettings.cpp http://git.reviewboard.kde.org/r/103469/#comment7509 I like the idea (KGlobalSettings reparsing configuration), but not the implementation (setLanguage(langage)). Can't KLocale get a reparseConfiguration() (to reuse the KConfig naming) ? - David Faure On Dec. 19, 2011, 2:02 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/ --- (Updated Dec. 19, 2011, 2:02 p.m.) Review request for kdelibs and Plasma. Description --- This is patch number 3 to fix bug #289094 (top bar time incorrectly displays in 24 hour format). The other patches are against plasma-mobile and kde-workspace (http://git.reviewboard.kde.org/r/103434), all three patches must be applied to fix the bug. I think this is a much simpler solution than the one I suggested in http://git.reviewboard.kde.org/r/103434. This addresses bug 289094. http://bugs.kde.org/show_bug.cgi?id=289094 Diffs - kdeui/kernel/kglobalsettings.h cb8f7e2 kdeui/kernel/kglobalsettings.cpp 819b314 Diff: http://git.reviewboard.kde.org/r/103469/diff/diff Testing --- Thanks, Lamarque Vieira Souza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
On Dec. 19, 2011, 2:35 p.m., David Faure wrote: kdeui/kernel/kglobalsettings.cpp, line 886 http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867line886 I like the idea (KGlobalSettings reparsing configuration), but not the implementation (setLanguage(langage)). Can't KLocale get a reparseConfiguration() (to reuse the KConfig naming) ? KLocale::reparseConfiguration() would be just a call to KLocalePrivate::initFormat(), but initFormat is protected. I will have to make it public to use it in KLocale::reparseConfiguration, wouldn't that break binary compatibility? Another alternative is creating a public KLocalePrivate::reparseConfiguration() just to call KLocalePrivate::initFormat(). - Lamarque Vieira --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review9078 --- On Dec. 19, 2011, 2:02 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/ --- (Updated Dec. 19, 2011, 2:02 p.m.) Review request for kdelibs and Plasma. Description --- This is patch number 3 to fix bug #289094 (top bar time incorrectly displays in 24 hour format). The other patches are against plasma-mobile and kde-workspace (http://git.reviewboard.kde.org/r/103434), all three patches must be applied to fix the bug. I think this is a much simpler solution than the one I suggested in http://git.reviewboard.kde.org/r/103434. This addresses bug 289094. http://bugs.kde.org/show_bug.cgi?id=289094 Diffs - kdeui/kernel/kglobalsettings.h cb8f7e2 kdeui/kernel/kglobalsettings.cpp 819b314 Diff: http://git.reviewboard.kde.org/r/103469/diff/diff Testing --- Thanks, Lamarque Vieira Souza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: qtcomponents documentation
Giorgos, If so, is best to do before the sprint. Cheers, On Sunday, December 18, 2011 05:40:26 AM Giorgos Tsiapaliwkas wrote: I am in. When me and Daker were writing the doc we didn't pay any attention to the coding style. Those days the plan was to write the doc with mediawiki format. Is the plan the same?? If yes, I can reform the coding style. -- Daker Fernandes Pinheiro openBossa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: rssnow:Add a Drop a feed here
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103472/ --- Review request for Plasma. Description --- Hello, I added the Drop a feed here, but 1.I am still missing the title(look at the screenshot),how can I add one? 2.should i make config.ui as the c++ one? (look at the screenshot), and if i make them the same how I will connect the signals and slots without c++? I think that the Qt Designer can't do that. 3.The Drop a feed here doesn't have drag and drop effects. I added a DropArea but i don't know if it is correct. I didn't find any onDrop signal, so how I will inform the plasmoid about the drop event? 4.the ListItemEntry in the main.qml has 3 unknown properties to me link,icon,title, where these properties exist? Diffs - rssnow/package/contents/ui/DropRssEntry.qml e69de29 rssnow/package/contents/ui/ListItemEntry.qml 657b14b rssnow/package/contents/ui/main.qml a575c29 Diff: http://git.reviewboard.kde.org/r/103472/diff/diff Testing --- Screenshots --- http://git.reviewboard.kde.org/r/103472/s/378/ Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: qtcomponents documentation
On Monday 19 December 2011, Marco Martin wrote: On Saturday 17 December 2011, Aaron J. Seigo wrote: On Saturday, December 17, 2011 13:39:05 Marco Martin wrote: Hi all, I think we should do a real documentation sprint for the plasma qtcomponents, to have a good api doc for the 4.8 release. and ideas / preferences on when and where? this btw, is the documentation of symbian components: http://doc.qt.nokia.com/qt-components-symbian/symbian-components- functional.html it's *almost* the same api as ours (some minor differences) that can be also used as a base for ours (and basically, ignore the docs of meego/harmattan ones ;) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: On Dec. 19, 2011, 2:35 p.m., David Faure wrote: kdeui/kernel/kglobalsettings.cpp, line 886 http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867lin e886 I like the idea (KGlobalSettings reparsing configuration), but not the implementation (setLanguage(langage)). Can't KLocale get a reparseConfiguration() (to reuse the KConfig naming) ? KLocale::reparseConfiguration() would be just a call to KLocalePrivate::initFormat(), but initFormat is protected. I will have to make it public to use it in KLocale::reparseConfiguration, wouldn't that break binary compatibility? Aeh? If it's called KLocalePrivate it's a private class, you can do whatever you want with it. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: rssnow:Add a Drop a feed here
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103472/#review9086
---
on the right track, let's make the droparea actually work and then let's go for
it.
unfortunately right now the look at the left is not achievable with scripted
plasmoids, for this we'll have to find a new way to do config windows (possibly
in qml as well)
rssnow/package/contents/ui/DropRssEntry.qml
http://git.reviewboard.kde.org/r/103472/#comment7513
DropArea has the drop signal, so
onDrop: {
print(event.url)
}
should work
- Marco Martin
On Dec. 19, 2011, 4:28 p.m., Giorgos Tsiapaliwkas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103472/
---
(Updated Dec. 19, 2011, 4:28 p.m.)
Review request for Plasma.
Description
---
Hello,
I added the Drop a feed here, but
1.I am still missing the title(look at the screenshot),how can I add one?
2.should i make config.ui as the c++ one? (look at the screenshot), and if i
make them the same
how I will connect the signals and slots without c++? I think that the Qt
Designer can't do that.
3.The Drop a feed here doesn't have drag and drop effects.
I added a DropArea but i don't know if it is correct. I didn't find any
onDrop signal,
so how I will inform the plasmoid about the drop event?
4.the ListItemEntry in the main.qml has 3 unknown properties to me
link,icon,title, where
these properties exist?
Diffs
-
rssnow/package/contents/ui/DropRssEntry.qml e69de29
rssnow/package/contents/ui/ListItemEntry.qml 657b14b
rssnow/package/contents/ui/main.qml a575c29
Diff: http://git.reviewboard.kde.org/r/103472/diff/diff
Testing
---
Screenshots
---
http://git.reviewboard.kde.org/r/103472/s/378/
Thanks,
Giorgos Tsiapaliwkas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
Em Monday 19 December 2011, David Faure escreveu: On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: On Dec. 19, 2011, 2:35 p.m., David Faure wrote: kdeui/kernel/kglobalsettings.cpp, line 886 http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867 lin e886 I like the idea (KGlobalSettings reparsing configuration), but not the implementation (setLanguage(langage)). Can't KLocale get a reparseConfiguration() (to reuse the KConfig naming) ? KLocale::reparseConfiguration() would be just a call to KLocalePrivate::initFormat(), but initFormat is protected. I will have to make it public to use it in KLocale::reparseConfiguration, wouldn't that break binary compatibility? Aeh? If it's called KLocalePrivate it's a private class, you can do whatever you want with it. Well, it's called KLocalePrivate but it has a lot of protected methods that KLocale cannot access, initFormat is one of them: ../../kdecore/localization/klocale_p.h: In member function 'void KLocale::reparseConfiguration()': ../../kdecore/localization/klocale_p.h:81:18: error: 'virtual void KLocalePrivate::initFormat()' is protected ../../kdecore/localization/klocale.cpp:786:19: error: within this context -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid web slice - disable geometryEdit if not needed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103468/#review9088 --- This review has been submitted with commit 765fedcc38b7be559655dbf9d2cda7e5d75efaee by Gregor Tätzner to branch master. - Commit Hook On Dec. 19, 2011, 11:56 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103468/ --- (Updated Dec. 19, 2011, 11:56 a.m.) Review request for Plasma. Description --- title says it all. this patch is related to https://bugs.kde.org/show_bug.cgi?id=284459#c2 but does not fix that bug. Diffs - applets/webslice/plasma/webslice.h fbe1242 applets/webslice/plasma/webslice.cpp a1740bf Diff: http://git.reviewboard.kde.org/r/103468/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Small QML related questions...
On Monday 19 December 2011 11:46:41 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= wrote: hmm... that's in the JS bindings and i confirmed it existed before i replied; where in your QML are you trying to use it? I'll ping you this evening when I'm back home and give you my current patch on top of kickoff branch I just tried together with Marco and it works. Seems like I had a typo yesterday... Sorry for the noise Cheers Martin P.S.: A kingdom, a kingdom for type checking while editing signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Re: Re: Breadcrumbs in Kickoff
On 01/-10/-28163 11:59 AM, Martin Grlin wrote: Hey Rick, On Sunday 18 December 2011 09:29:36 Rick Stockton wrote: On 01/-10/-28163 11:59 AM, Aaron J. Seigo wrote: Aaron, my words were unclear. If you and Martin are willing to put this into the 4.8.x Series, it CAN be done, but we _must_ use the name which already exists. 'Xbutton1' == the Back Button, the other two names will be synonyms for 'XButton1' in Qt5. 'XButton1' will still be present, and we can stay Source-compatible across both Qt Versions by using THAT name. the earliest point in time to ship it is 4.9 which will be based on my new QML based implementation. And there seems to be a problem... MouseArea does not know anything except the three standard buttons[1]. With that 3-button limitation, it HAS to wait for 4.9 to get the buttons (in Qt5). And thanks, YIKES, for showing me the 'QML only has 3 buttons' problem! I'll go write the enhancement into Qt -- I've still got at least a couple of weeks before API freeze. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
On Monday 19 December 2011 15:01:51 Lamarque V. Souza wrote: Em Monday 19 December 2011, David Faure escreveu: On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: On Dec. 19, 2011, 2:35 p.m., David Faure wrote: kdeui/kernel/kglobalsettings.cpp, line 886 http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file4386 7 lin e886 I like the idea (KGlobalSettings reparsing configuration), but not the implementation (setLanguage(langage)). Can't KLocale get a reparseConfiguration() (to reuse the KConfig naming) ? KLocale::reparseConfiguration() would be just a call to KLocalePrivate::initFormat(), but initFormat is protected. I will have to make it public to use it in KLocale::reparseConfiguration, wouldn't that break binary compatibility? Aeh? If it's called KLocalePrivate it's a private class, you can do whatever you want with it. Well, it's called KLocalePrivate but it has a lot of protected methods that KLocale cannot access, initFormat is one of them: ../../kdecore/localization/klocale_p.h: In member function 'void KLocale::reparseConfiguration()': ../../kdecore/localization/klocale_p.h:81:18: error: 'virtual void KLocalePrivate::initFormat()' is protected ../../kdecore/localization/klocale.cpp:786:19: error: within this context So make it public. As I said, it's a Private class, there's no possible BIC issue with it. Of course I trust you that calling it directly is okay, I have no idea about that, John Layt would be able to confirm that, though. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
Em Monday 19 December 2011, David Faure escreveu: On Monday 19 December 2011 15:01:51 Lamarque V. Souza wrote: Em Monday 19 December 2011, David Faure escreveu: On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: On Dec. 19, 2011, 2:35 p.m., David Faure wrote: kdeui/kernel/kglobalsettings.cpp, line 886 http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file4 386 7 lin e886 I like the idea (KGlobalSettings reparsing configuration), but not the implementation (setLanguage(langage)). Can't KLocale get a reparseConfiguration() (to reuse the KConfig naming) ? KLocale::reparseConfiguration() would be just a call to KLocalePrivate::initFormat(), but initFormat is protected. I will have to make it public to use it in KLocale::reparseConfiguration, wouldn't that break binary compatibility? Aeh? If it's called KLocalePrivate it's a private class, you can do whatever you want with it. Well, it's called KLocalePrivate but it has a lot of protected methods that KLocale cannot access, initFormat is one of them: ../../kdecore/localization/klocale_p.h: In member function 'void KLocale::reparseConfiguration()': ../../kdecore/localization/klocale_p.h:81:18: error: 'virtual void KLocalePrivate::initFormat()' is protected ../../kdecore/localization/klocale.cpp:786:19: error: within this context So make it public. As I said, it's a Private class, there's no possible BIC issue with it. Of course I trust you that calling it directly is okay, I have no idea about that, John Layt would be able to confirm that, though. Well, it works here and nothing has crashed so far :-) By the number of public and protected sections in KLocalePrivate either everybody is scared to organize them or there must be a really nasty bug in there that nobody dares to talk about because there is no comment explaining why it is like that. PS: There are 14 public: sections, 10 protected: and 2 private: in KLocalePrivate. -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breadcrumbs in Kickoff
I'll answer to Martin Gräßlin to move discussion from the certain bug report (http://bugs.kde.org/show_bug.cgi?id=274489) here to keep the whole discussion in one place. Very interesting discussion in plasma-devel but I personally didn't find any arguments why the 'Back' button is bad but something like We decided to remove this button and would never revert it. Period. Being bluntly: The option to revert does not exist. We changed to breadcrumbs in 4.7, 4.8 is going to be tagged as RC tomorrow, so it is impossible to do any changes and reverting in 4.9 is clearly no option any more. Too many users got used to the new style, so what do we gain by breaking the workflow? Well, why then you came to decision to remove Back button after 4.6? :) Didn't it break the workflow? Or users who prefer to use Back button is somehow worse or less important than those who prefer breadcrumbs? So we do not need to discuss whether the back button is bad. The only thing which can be discussed is whether the back button is so important that it needs a config option and that it is worth the amount of work to add and more important to maintain it. OK, let's discuss the config option which is I think would satisfy most of us. For me there has not been any convincing argument that it needs an option which means that currently I will not add it and would not even accept a patch. You asked for usability studies to prove some arguments before in this thread and here you state as if it's you to decide what will be accepted and what won't be accepted. So it's unclear whether there was some usability research result that breadcrumbs are better than Back button or it was just decided by someone and implemented. But I personally don't see any danger in both elements together. I also can't see a reason to be so much against any suggestion on improve the situation with Back button itself. If it's a question of resources to implement e.g. a config option than, for example I can work at it. I think nobody wants to spoil new code or new navigation architecture or whatever so it would be done very carefully. It's unclear why you so against to approve such a work. Please keep discussions to one place and that's the mailing list thread. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/ --- (Updated Dec. 19, 2011, 10:15 p.m.) Review request for kdelibs and Plasma. Changes --- Add KLocale::reparseConfiguration() and make KLocalePrivate::initFormat() public. Description --- This is patch number 3 to fix bug #289094 (top bar time incorrectly displays in 24 hour format). The other patches are against plasma-mobile and kde-workspace (http://git.reviewboard.kde.org/r/103434), all three patches must be applied to fix the bug. I think this is a much simpler solution than the one I suggested in http://git.reviewboard.kde.org/r/103434. This addresses bug 289094. http://bugs.kde.org/show_bug.cgi?id=289094 Diffs (updated) - kdecore/localization/klocale.h 3495431 kdecore/localization/klocale.cpp 499bf11 kdecore/localization/klocale_p.h 4ed8e3f kdeui/kernel/kglobalsettings.h cb8f7e2 kdeui/kernel/kglobalsettings.cpp 819b314 Diff: http://git.reviewboard.kde.org/r/103469/diff/diff Testing --- Thanks, Lamarque Vieira Souza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
