Review Request: Integrate Plasma Scripting Console with KWin scripting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103518/ --- Review request for kwin and Plasma. Description --- * KWin scripting becomes partly controllable through D-Bus * Desktop Scripting Console can control KWin scripts. For that two new methods to PlasmaApp's D-Bus interface are added. If in KWin mode the script is passed to KWin through D-Bus * Plasma Desktop Runner gains new keyword wm console to start Desktop Scripting Console in KWin mode. Diffs - kwin/scripting/scripting.h b0d00f9 kwin/scripting/scripting.cpp 0a71849 plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.h 227748d plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.cpp 617bc69 plasma/desktop/shell/dbus/org.kde.plasma.App.xml e9b6482 plasma/desktop/shell/interactiveconsole.h f94b997 plasma/desktop/shell/interactiveconsole.cpp 6f2ff75 plasma/desktop/shell/plasmaapp.h 3c7289c plasma/desktop/shell/plasmaapp.cpp b630225 Diff: http://git.reviewboard.kde.org/r/103518/diff/diff Testing --- Screenshots --- Desktop Scripting console with KWin integration http://git.reviewboard.kde.org/r/103518/s/379/ Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Integrate Plasma Scripting Console with KWin scripting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103518/#review9210 --- Ship it! looks quite straightforward. i'm not overly fond of having wm console and desktop console and not being able to switch between them in the UI. it would be very cool to have the ability to switch modes from the toolbar. what would be FANTASTIC is to be able to put blocks of plasma-desktop and kwin code in the same editor and have it run the JS in the right place, but i think that faces a number of limitations due to the nature of controlling an out of process app (kwin). either the kwin API would need to implemented in plasmagenericshell's scripting and in there forward calls on via DBus (or whatever) or limit it rather unnaturally to blocks of code that would get executed in their own context (e.g. no variables available from both a desktop block and a kwin block) so that seems like something for another day, as it would be quite a bit of work :) imho, for now this can go in as-is with the addition of a drop down in the toolbar to switch between modes easily - Aaron J. Seigo On Dec. 23, 2011, 2:24 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103518/ --- (Updated Dec. 23, 2011, 2:24 p.m.) Review request for kwin and Plasma. Description --- * KWin scripting becomes partly controllable through D-Bus * Desktop Scripting Console can control KWin scripts. For that two new methods to PlasmaApp's D-Bus interface are added. If in KWin mode the script is passed to KWin through D-Bus * Plasma Desktop Runner gains new keyword wm console to start Desktop Scripting Console in KWin mode. Diffs - kwin/scripting/scripting.h b0d00f9 kwin/scripting/scripting.cpp 0a71849 plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.h 227748d plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.cpp 617bc69 plasma/desktop/shell/dbus/org.kde.plasma.App.xml e9b6482 plasma/desktop/shell/interactiveconsole.h f94b997 plasma/desktop/shell/interactiveconsole.cpp 6f2ff75 plasma/desktop/shell/plasmaapp.h 3c7289c plasma/desktop/shell/plasmaapp.cpp b630225 Diff: http://git.reviewboard.kde.org/r/103518/diff/diff Testing --- Screenshots --- Desktop Scripting console with KWin integration http://git.reviewboard.kde.org/r/103518/s/379/ Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Integrate Plasma Scripting Console with KWin scripting
On Dec. 23, 2011, 5:40 p.m., Aaron J. Seigo wrote: looks quite straightforward. i'm not overly fond of having wm console and desktop console and not being able to switch between them in the UI. it would be very cool to have the ability to switch modes from the toolbar. what would be FANTASTIC is to be able to put blocks of plasma-desktop and kwin code in the same editor and have it run the JS in the right place, but i think that faces a number of limitations due to the nature of controlling an out of process app (kwin). either the kwin API would need to implemented in plasmagenericshell's scripting and in there forward calls on via DBus (or whatever) or limit it rather unnaturally to blocks of code that would get executed in their own context (e.g. no variables available from both a desktop block and a kwin block) so that seems like something for another day, as it would be quite a bit of work :) imho, for now this can go in as-is with the addition of a drop down in the toolbar to switch between modes easily it would be very cool to have the ability to switch modes from the toolbar. Yes, that's something I want to add. I thought about to Toggle Buttons in the toolbar Plasma, KWin which are mutual exclusive. I just didn't want to work on it any more today and wanted to push out the review request :-) Will implement that after Christmas break :-) The other idea sounds complicated. Not sure whether that would be possible at all without exposing complete KWin internals to D-Bus. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103518/#review9210 --- On Dec. 23, 2011, 2:24 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103518/ --- (Updated Dec. 23, 2011, 2:24 p.m.) Review request for kwin and Plasma. Description --- * KWin scripting becomes partly controllable through D-Bus * Desktop Scripting Console can control KWin scripts. For that two new methods to PlasmaApp's D-Bus interface are added. If in KWin mode the script is passed to KWin through D-Bus * Plasma Desktop Runner gains new keyword wm console to start Desktop Scripting Console in KWin mode. Diffs - kwin/scripting/scripting.h b0d00f9 kwin/scripting/scripting.cpp 0a71849 plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.h 227748d plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.cpp 617bc69 plasma/desktop/shell/dbus/org.kde.plasma.App.xml e9b6482 plasma/desktop/shell/interactiveconsole.h f94b997 plasma/desktop/shell/interactiveconsole.cpp 6f2ff75 plasma/desktop/shell/plasmaapp.h 3c7289c plasma/desktop/shell/plasmaapp.cpp b630225 Diff: http://git.reviewboard.kde.org/r/103518/diff/diff Testing --- Screenshots --- Desktop Scripting console with KWin integration http://git.reviewboard.kde.org/r/103518/s/379/ Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kickoff w/Breadcrumbs in QML
Just to confirm, does the QML Kickoff still have keyboard navigation? I think that it would be a good idea to not only add support for a mouse's back button, but also the standard backspace key on keyboards. This would enable full navigation of Kickoff solely with the keyboard, a feature which, until now, has been limited by the lack of a back button shortcut. As for the UI back button, Novell's usability team did determine that it was needed. Who are we, as non-UX professionals, to argue against this decision? And, as for the terminology used for the classic, KDE3-style panel, I believe that classic would be the best term, NOT KDE3. As well, I don't see much of a use case for the classic panel being included in Plasma by default. Available from KDE-Look, certainly, but KDE3's days were long ago. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Kickoff w/Breadcrumbs in QML
On Friday 23 December 2011 13:15:22 Xavier Sythe wrote: Just to confirm, does the QML Kickoff still have keyboard navigation? I think that it would be a good idea to not only add support for a mouse's back button, but also the standard backspace key on keyboards. This would enable full navigation of Kickoff solely with the keyboard, a feature which, until now, has been limited by the lack of a back button shortcut. It's something I still have to work on. Primitive navigation (up/down) in the list is working, everything else not yet. If placed in the panel it's not working at all. Adding these things is rather simple once I figured out where I have to add the keyboard handling, so that QML plays nice :-) As for the UI back button, Novell's usability team did determine that it was needed. Who are we, as non-UX professionals, to argue against this decision? Do you have a link to the study? I tried to find it, but could only find the presentations at Akademy and FOSDEM which did not contain the reasons for the design, but just the results compared to other launchers. And, as for the terminology used for the classic, KDE3-style panel, I believe that classic would be the best term, NOT KDE3. As well, I don't see much of a use case for the classic panel being included in Plasma by default. Available from KDE-Look, certainly, but KDE3's days were long ago. Even classic I find sub-optimal. It's like next generation just the other way around. Imagine we have a new launcher next year. Then we would have to rename Kickoff to classic, but how to call the classic one. Really classic, old classic? Nevertheless: still better than KDE 3 ;-) Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kickoff-QML and classic launcher
Martin Graesslin wrote: * Would it be acceptable to drop the classic menu completely? This would be more consistent with the general concept of having only one applet per area. Optionally the classic menu could be re-added in Plasma-Addons just like Lancelot. You can pry my classic menu from my cold, dead hands! Kevin Kofler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kickoff-QML and classic launcher
Aaron J. Seigo wrote: it's really a horrible hack and i'd suggest getting rid of it. people can add the classic menu from the widget explorer like all the rest. This is just going to make it much harder to switch to a menu people like me can actually use. :-( Especially for people switching to Plasma from other environments still using old-school menus, this will make it harder for them to get started. And I'm not at all convinced that a UI which replaces the entire panel with a different template which happens to include a different menu is a good UI to replace that. I think it would be better to find a way to preserve the settings, such that switching and switching back doesn't lead to reset settings. Removing the UI is not a nice fix. Kevin Kofler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breadcrumbs in Kickoff
Rick Stockton wrote: Alexey, you have two of KDE's smartest people (Aaron and Martin) in agreement that we probably want to provide this via the Back Button on the Mouse. (Less new code, less confusion, less maintenance headache.) That assumes that the mouse has such a nonstandard button in the first place. Kevin Kofler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kickoff-QML and classic launcher
On Fri, Dec 23, 2011 at 9:29 PM, Kevin Kofler kevin.kof...@chello.at wrote: Aaron J. Seigo wrote: it's really a horrible hack and i'd suggest getting rid of it. people can add the classic menu from the widget explorer like all the rest. This is just going to make it much harder to switch to a menu people like me can actually use. :-( Especially for people switching to Plasma from other environments still using old-school menus, this will make it harder for them to get started. Seriously? Adding a classic application launcher menu (or however it shall be named) to the Add Widgets list is more difficult or confusing to users than right-clicking the application launcher and being aware that the obscure classic menu style actually exists? I don't see the connection. Right clicking is inherently an action which requires (a) the user to know he can right click it and (b) the user to know that an action that he/she may want could actually come from it. As opposed to a separate widget in the add widgets dialog. From what I see, it only makes it less confusing and more unified. Otherwise you're left with: Should I be right-clicking the Task Manager widget, hoping for a classic task manager option? How about the system tray? Folderview? News Widget? The list goes on and on ;) -- Shaun Reich, KDE Software Developer (kde.org) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
