Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)
On April 12, 2012, 8:37 a.m., Ivan Čukić wrote: Ship It! I just realized that i closed it by accident. - makis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12348 --- On April 12, 2012, 8:23 a.m., makis marimpis wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated April 12, 2012, 8:23 a.m.) Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić. Description --- (follows discarded review: 104391) The plugin adds global keyboard shortcuts for changing the activity. Defaults start from Qt::MetaModifier + Qt::Key_F1. Initially, this functionality was implemented (without correct results) using KActitivities::Controller. Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds delay - so it really needs modification/and i would like more guidance related to dbus :D. Other than that, feedback is needed. This addresses bugs 265069 and 273467. http://bugs.kde.org/show_bug.cgi?id=265069 http://bugs.kde.org/show_bug.cgi?id=273467 Diffs - service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop PRE-CREATION service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104428/diff/ Testing --- Logged in. Used the default shortcuts to switch activities. It works! Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104603/ --- Review request for Plasma. Description --- Closes: http://bugs.kde.org/show_bug.cgi?id=265456 Partialy closes: http://bugs.kde.org/show_bug.cgi?id=272768 On screen display notification when changing activities. Displays the user icon and the name. It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand. This could be as well implemented on KWin, but i did as a kamd plugin for fun :P. For the time being i think it is not correct to force such plugin (it would be cool is kamd's plugins were managed via systemsettings) without an option to enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed. This addresses bugs 265456 and 272768. http://bugs.kde.org/show_bug.cgi?id=265456 http://bugs.kde.org/show_bug.cgi?id=272768 Diffs - service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CREATION service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104603/diff/ Testing --- Changed activities and it works. Screenshots --- without kwin effects http://git.reviewboard.kde.org/r/104603/s/531/ with kwin effects http://git.reviewboard.kde.org/r/104603/s/532/ after kwin effects disabledd (possible bug) http://git.reviewboard.kde.org/r/104603/s/533/ Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104603/ --- (Updated April 15, 2012, 8:10 a.m.) Review request for Plasma. Changes --- Set correct bugs' ids. Description (updated) --- Closes: http://bugs.kde.org/show_bug.cgi?id=265456 Partialy closes: https://bugs.kde.org/show_bug.cgi?id=295410 On screen display notification when changing activities. Displays the user icon and the name. It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand. This could be as well implemented on KWin, but i did as a kamd plugin for fun :P. For the time being i think it is not correct to force such plugin (it would be cool is kamd's plugins were managed via systemsettings) without an option to enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed. This addresses bugs 265456 and 295410. http://bugs.kde.org/show_bug.cgi?id=265456 http://bugs.kde.org/show_bug.cgi?id=295410 Diffs - service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CREATION service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104603/diff/ Testing --- Changed activities and it works. Screenshots --- without kwin effects http://git.reviewboard.kde.org/r/104603/s/531/ with kwin effects http://git.reviewboard.kde.org/r/104603/s/532/ after kwin effects disabledd (possible bug) http://git.reviewboard.kde.org/r/104603/s/533/ Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Files, config, and welcome (again)
Hello, as far as I know it is very important to know where you tested it. If you only tested it in the plasmoidveiwer then this is probably the reason it doesn't work. Install the plasmoid on the system and try it there ... then I think it probably will work. Regards, Djuro Drljaca On Sun, Apr 15, 2012 at 2:03 AM, Michał 'rysiek' Woźniak rys...@fwioo.plwrote: Hello, I have already written to this list and some of you might know me from other channels (like IRC or StatusNet). Either way - hi and hello! Also, I hope I am writing in the right place. If not, do tell and point me in the right direction. Now, to the point! I am writing a Todo/tasks plasmoid, inspired by TaskTimer. Here's my braindump about it: http://rys.io/en/71 One thing I am missing at this moment, and am missing dearly, is a way to save the state of the tasks (text, elapsed time, etc) so that it gets restored upon plasmoid restart (not sure if this is the right word). This can be easily done with a simple JSON text file, or even an INI file for that matter. So basically what I need is either a config store or a way to read/write pure text files. I tried using the KConfig XT, but surprisingly the values did not get saved (yes, main.xml file is created and contains the right stuff); this happened even with the kdeexamples configuration example. Besides, I am wondering if the rigid structure of KConfig XT files is a good bet here; I am adding/removing todo items in the plasmoid, and as far as I understand config entries are defined beforehand - so I would have to store key-value pairs (in JSON?) within the config XML file. Doesn't seem right. So, three questions: - am I missing something about the KConfig XT approach? - maybe there is a better config API for QML/JS plasmoids? - is there a way to read/write files from a QML/JS plasmoid? I am running KDE SC 4.7.4 in Debian Sid. -- Pozdrawiam Michał rysiek Woźniak Fundacja Wolnego i Otwartego Oprogramowania ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104603/#review12459 --- FTR: KWin's desktop change OSD has been completely rewritten in QML and I would highly suggest that it should also this OSD should use QML. - Martin Gräßlin On April 15, 2012, 8:10 a.m., makis marimpis wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104603/ --- (Updated April 15, 2012, 8:10 a.m.) Review request for Plasma. Description --- Closes: http://bugs.kde.org/show_bug.cgi?id=265456 Partialy closes: https://bugs.kde.org/show_bug.cgi?id=295410 On screen display notification when changing activities. Displays the user icon and the name. It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand. This could be as well implemented on KWin, but i did as a kamd plugin for fun :P. For the time being i think it is not correct to force such plugin (it would be cool is kamd's plugins were managed via systemsettings) without an option to enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed. This addresses bugs 265456 and 295410. http://bugs.kde.org/show_bug.cgi?id=265456 http://bugs.kde.org/show_bug.cgi?id=295410 Diffs - service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREATION service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CREATION service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104603/diff/ Testing --- Changed activities and it works. Screenshots --- without kwin effects http://git.reviewboard.kde.org/r/104603/s/531/ with kwin effects http://git.reviewboard.kde.org/r/104603/s/532/ after kwin effects disabledd (possible bug) http://git.reviewboard.kde.org/r/104603/s/533/ Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: QML Lock/logout applet
On April 14, 2012, 10:11 p.m., Kai Uwe Broulik wrote:
Couldn’t we add a Hibernate dialog, similar to the confirmation on
shutdown, i.e that dialog that counts down Shutting down in 30 seconds
with the ability to cancel it? You press Hibernate, and a KSMserver dialog
(that we don’t have yet?) pops up and after 30 seconds, it will hibernate
anway. This way, if you miss the dialog, e.g. you are in a hurry, it will
proceed after the countdown runs out.
That seems like a good idea. Comments?
- Viranch
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/#review12448
---
On April 13, 2012, 6:18 p.m., Viranch Mehta wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104592/
---
(Updated April 13, 2012, 6:18 p.m.)
Review request for Plasma and Marco Martin.
Description
---
This patch essentially contains the new QML lock logout applet, along with
required changes to powermanagement engine.
The patch contains *some* irrelevant code too (in powermanagement data
engine) since the same branch has QML battery applet. So it'd be best to
checkout plasma/viranch/powermanagementservices branch and compile
plasma/generic/{applets/lockout,dataengines/powermanagement} instead of using
the attached patch.
Two pending issues with the applet:
- There is no shine on the icons on hover.
- Sleep/Hibernate actions do not ask for confirmation, as does the current
C++ version
Comments welcome on this thread :)
Diffs
-
plasma/generic/applets/lock_logout/CMakeLists.txt a19615b
plasma/generic/applets/lock_logout/contents/config/main.xml PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/config.ui PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/data.js PRE-CREATION
plasma/generic/applets/lock_logout/contents/ui/lockout.qml PRE-CREATION
plasma/generic/applets/lock_logout/lockout.h 94f33cf
plasma/generic/applets/lock_logout/lockout.cpp 830e64b
plasma/generic/applets/lock_logout/lockoutConfig.ui d9285c2
plasma/generic/applets/lock_logout/metadata.desktop PRE-CREATION
plasma/generic/applets/lock_logout/plasma-applet-lockout.desktop d8a4337
plasma/generic/dataengines/powermanagement/CMakeLists.txt 9f2a528
plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c2
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp
5572fcb
plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015
plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0
plasma/generic/dataengines/powermanagement/powermanagementservice.operations
ad1301f
Diff: http://git.reviewboard.kde.org/r/104592/diff/
Testing
---
- Tested inside horizontal/vertical panels and floating on desktop, sizing
works as expected.
- There may be some unexpected behavior if the panel containing the applet is
changed from being horizontal to vertical or vice-versa.
Screenshots
---
Screenshot of the applet on desktop
http://git.reviewboard.kde.org/r/104592/s/526/
Thanks,
Viranch Mehta
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Files, config, and welcome (again)
Op 15 apr. 2012 02:20 schreef Michał 'rysiek' Woźniak rys...@fwioo.pl het volgende: Hello, I have already written to this list and some of you might know me from other channels (like IRC or StatusNet). Either way - hi and hello! Also, I hope I am writing in the right place. If not, do tell and point me in the right direction. Now, to the point! I am writing a Todo/tasks plasmoid, inspired by TaskTimer. Here's my braindump about it: http://rys.io/en/71 One thing I am missing at this moment, and am missing dearly, is a way to save the state of the tasks (text, elapsed time, etc) so that it gets restored upon plasmoid restart (not sure if this is the right word). This can be easily done with a simple JSON text file, or even an INI file for that matter. So basically what I need is either a config store or a way to read/write pure text files. I tried using the KConfig XT, but surprisingly the values did not get saved (yes, main.xml file is created and contains the right stuff); this happened even with the kdeexamples configuration example. Besides, I am wondering if the rigid structure of KConfig XT files is a good bet here; I am adding/removing todo items in the plasmoid, and as far as I understand config entries are defined beforehand - so I would have to store key-value pairs (in JSON?) within the config XML file. Doesn't seem right. So, three questions: - am I missing something about the KConfig XT approach? - maybe there is a better config API for QML/JS plasmoids? - is there a way to read/write files from a QML/JS plasmoid? I am running KDE SC 4.7.4 in Debian Sid. -- Pozdrawiam Michał rysiek Woźniak Fundacja Wolnego i Otwartego Oprogramowania ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel Hi, I can't really answer your questions since I don't know the answer. However, I do would like to point you to perhaps some interesting ways to store your data. Once you start using Qt5 you can use qtjsondb to store your data. The option (and best option) you have right now is to use akanodi with the KCal class http://api.kde.org/4.x-api/kdepimlibs-apidocs/kcal/html/index.html . It implements the I calendar specification and also has support for todo items. Using the KCal classes will also make them show in any app that uses KCal. If you're making a qml only plasmoid then KCal is not possible since it doesn't have a qml binding (as far as I know...). Just letting you know :) Mark ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Files, config, and welcome (again)
On Sunday, 2012-04-15, Mark wrote: The option (and best option) you have right now is to use akanodi with the KCal class http://api.kde.org/4.x-api/kdepimlibs-apidocs/kcal/html/index.html . It implements the I calendar specification and also has support for todo items. Using the KCal classes will also make them show in any app that uses KCal. Very true, though it might be better to use the respective KCalCore equivalents, those are cleaned up implementations. In either case using KDE's todo classes is certainly the right way to go, since it will allow the applet to show/edit data created by other todo/task handling applications such as KOrganizer or Zanshin (http://zanshin.kde.org/) If you're making a qml only plasmoid then KCal is not possible since it doesn't have a qml binding (as far as I know...). The Kontact touch related directories in kdepim could be helpful here, i.e. those are QML based user interfaces for components that are traditionally part of the Kontact suite. Since Todos/Tasks are another subtype of calendar entry (like event) some of the calendar Plasma integration points might be a good start as well. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12476 --- This review has been submitted with commit f0983fa9a3a1f4466b7d4fa19cfa55914c0cea8a by Makis Marimpis to branch KDE/4.8. - Commit Hook On April 12, 2012, 8:23 a.m., makis marimpis wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated April 12, 2012, 8:23 a.m.) Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić. Description --- (follows discarded review: 104391) The plugin adds global keyboard shortcuts for changing the activity. Defaults start from Qt::MetaModifier + Qt::Key_F1. Initially, this functionality was implemented (without correct results) using KActitivities::Controller. Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds delay - so it really needs modification/and i would like more guidance related to dbus :D. Other than that, feedback is needed. This addresses bugs 265069 and 273467. http://bugs.kde.org/show_bug.cgi?id=265069 http://bugs.kde.org/show_bug.cgi?id=273467 Diffs - service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop PRE-CREATION service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104428/diff/ Testing --- Logged in. Used the default shortcuts to switch activities. It works! Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12477 --- This review has been submitted with commit 7e2ef3c7f0a6584a040b4fe70e1012de9b1511d8 by Makis Marimpis to branch master. - Commit Hook On April 12, 2012, 8:23 a.m., makis marimpis wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated April 12, 2012, 8:23 a.m.) Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić. Description --- (follows discarded review: 104391) The plugin adds global keyboard shortcuts for changing the activity. Defaults start from Qt::MetaModifier + Qt::Key_F1. Initially, this functionality was implemented (without correct results) using KActitivities::Controller. Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds delay - so it really needs modification/and i would like more guidance related to dbus :D. Other than that, feedback is needed. This addresses bugs 265069 and 273467. http://bugs.kde.org/show_bug.cgi?id=265069 http://bugs.kde.org/show_bug.cgi?id=273467 Diffs - service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop PRE-CREATION service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104428/diff/ Testing --- Logged in. Used the default shortcuts to switch activities. It works! Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Added feature in media center to switch to full screen mode from the default size and vice-versa.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104612/ --- Review request for Plasma. Description --- Added the feature to change the mode of media center from default to full screen and vice-versa. A button has been added at top left corner to enable the above said feature, clicking on which does the appropriate changes. Diffs - shells/newshell/mainwindow.h d6d4405 shells/newshell/mainwindow.cpp bfafc34 shells/newshell/package/contents/ui/mediacenter.qml 67106ff Diff: http://git.reviewboard.kde.org/r/104612/diff/ Testing --- Tested by running the added feature in trunk. It works fine. Thanks, nancy kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added feature in media center to switch to full screen mode from the default size and vice-versa.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104612/#review12497 --- Thanks for the patch! Little changes though, check the comments below. Once you're done, this can go in :) shells/newshell/mainwindow.h http://git.reviewboard.kde.org/r/104612/#comment9804 remove extra whitespace shells/newshell/mainwindow.cpp http://git.reviewboard.kde.org/r/104612/#comment9805 Its better to have a single method called toggleFullscreen which turns on and off the fullscreen, instead of having two separate functions shells/newshell/package/contents/ui/mediacenter.qml http://git.reviewboard.kde.org/r/104612/#comment9806 Once you have only one slot toggleFullscreen(), you don't need all this logic inside QML. This should just have a call to toggleFullscreen() - Shantanu Tushar Jha On April 16, 2012, 5:42 a.m., nancy kumari wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104612/ --- (Updated April 16, 2012, 5:42 a.m.) Review request for Plasma. Description --- Added the feature to change the mode of media center from default to full screen and vice-versa. A button has been added at top left corner to enable the above said feature, clicking on which does the appropriate changes. Diffs - shells/newshell/mainwindow.h d6d4405 shells/newshell/mainwindow.cpp bfafc34 shells/newshell/package/contents/ui/mediacenter.qml 67106ff Diff: http://git.reviewboard.kde.org/r/104612/diff/ Testing --- Tested by running the added feature in trunk. It works fine. Thanks, nancy kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
