Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- As systemsettingsview is unlikely to break BC any further in the 4.x series, could the bump be to SOVERSION 3 instead please? Otherwise, this looks fine to go in from my perspective. - Ben Cooksley On May 28, 2014, 7:26 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/ --- (Updated May 28, 2014, 7:26 p.m.) Review request for Plasma and Ben Cooksley. Repository: systemsettings Description --- otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version Diffs - core/CMakeLists.txt 9752ad7 Diff: https://git.reviewboard.kde.org/r/118387/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: statusNotifier hide behaviour inconsistent
On Sunday 15 June 2014 13:36:52 Damian Ivanov wrote: Thanks Martin for the answer. The long term plan for the strange parts like klipper and kmix is to transform them to a Plasmoid. I hope this won't happen any time soon, I use them in not plasma (their StatusNotifiers) :) For Klipper this will happen for 5.1. Whether it's worth to keep klipper as a standalone application I'm not yet convinced, especially given that klipper will most likely be bound to KWin in a Wayland world. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application
On June 14, 2014, 9:12 p.m., Hrvoje Senjan wrote: startkde/ksyncdbusenv/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/118730/diff/2/?file=281040#file281040line5 it was my understanding that KF5_LIBEXEC_INSTALL_DIR is 'reserved' for KF5, and rest of depending software would use libexec_install_dir. iow, this is only executable in kf5/ subdir, that doesn't come from a Framework thanks for noticing, I'll fix it later today. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60095 --- On June 14, 2014, 10:41 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/ --- (Updated June 14, 2014, 10:41 a.m.) Review request for Plasma and David Edmundson. Repository: plasma-workspace Description --- [startkde] Introduce a ksyncdbusenv helper application This application is invoked by startkde once all environment variables are set and syncs them to DBus for the activation environment. Diffs - startkde/startkde.cmake 0c1f5841eeefc1012dbdc71e1d1fde11e7511dd6 startkde/ksyncdbusenv/ksyncdbusenv.cpp PRE-CREATION startkde/ksyncdbusenv/CMakeLists.txt PRE-CREATION startkde/CMakeLists.txt 3360a1c59409588ecec49e63276914b69568164e Diff: https://git.reviewboard.kde.org/r/118730/diff/ Testing --- on log in kglobalacceld5 doesn't pick up the right environment yet, but on manual invocation of the tool + trigger restart of kglobalacceld5 it works. So the approach seems to work, just not yet from startkde (maybe it's too late?) Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118693: [ksmserver/screenlocker] Use ScreenSaver key as shortcut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118693/#review60166 --- This review has been submitted with commit 82f15720a8523031fa11de235d33e199b01a2bd1 by Martin Gräßlin to branch master. - Commit Hook On June 12, 2014, 11:11 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118693/ --- (Updated June 12, 2014, 11:11 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- [ksmserver/screenlocker] Use ScreenSaver key as shortcut As we support multiple global shortcuts nowadays we can use both: * ScreenSaver * Ctrl+Alt+L So if the user has a lock screen key it works as expected. If not the screen can still be locked using the well known shortcut. Diffs - ksmserver/screenlocker/ksldapp.cpp efc9bce5840fe0ac3bdb795954974f5c05596171 Diff: https://git.reviewboard.kde.org/r/118693/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118693: [ksmserver/screenlocker] Use ScreenSaver key as shortcut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118693/ --- (Updated June 16, 2014, 7:19 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- [ksmserver/screenlocker] Use ScreenSaver key as shortcut As we support multiple global shortcuts nowadays we can use both: * ScreenSaver * Ctrl+Alt+L So if the user has a lock screen key it works as expected. If not the screen can still be locked using the well known shortcut. Diffs - ksmserver/screenlocker/ksldapp.cpp efc9bce5840fe0ac3bdb795954974f5c05596171 Diff: https://git.reviewboard.kde.org/r/118693/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: statusNotifier hide behaviour inconsistent
For Klipper this will happen for 5.1. Whether it's worth to keep klipper as a standalone application I'm not yet convinced, especially given that klipper will most likely be bound to KWin in a Wayland world. Just ot of curiosity what part of Klipper would require kwin? If it's for grabbing the marked stuff, couldn't this be done inside of libkwindowsystem instead kwin? Doing them as plasmoid's will only lock them out of other desktop environments. Regards ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Re: statusNotifier hide behaviour inconsistent
On Monday 16 June 2014 10:23:30 Damian Ivanov wrote: For Klipper this will happen for 5.1. Whether it's worth to keep klipper as a standalone application I'm not yet convinced, especially given that klipper will most likely be bound to KWin in a Wayland world. Just ot of curiosity what part of Klipper would require kwin? If it's for grabbing the marked stuff, couldn't this be done inside of libkwindowsystem instead kwin? Doing them as plasmoid's will only lock them out of other desktop environments. I would need to re-read the Wayland protocol but AFAIR an application would not be able to globally listen to the copy/paste stack. Thus KWin would need to expose a special interface to trusted clients. Plasma will already be a trusted client and simplify a lot. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Re: Re: statusNotifier hide behaviour inconsistent
On Monday 16 June 2014 10:39:34 Damian Ivanov wrote: It's ok if that behavior is for all wayland window manager's. Every window manager supplies a list with known clients for the copy/paste stack. Maybe this is something that should be done as freedesktop standard before it's too late... There is no need to standardize everything, especially not if it may be security relevant (klipper is basically a keylogger, Wayland is not supposed to support keyloggers!). I'm not sure whether there is a need to standardize on clipboard managers. How many users are there which use Klipper outside Plasma or which use the GNOME clipboard manager in Plasma? Yes there are some (for example you), but is that a use case strong enough to limit ourselves with a standard? If it becomes valid it's still possible to standardize (at least we plan to document all of our custom specs). Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Re: Re: statusNotifier hide behaviour inconsistent
Hmm ok. If I come up with a better idea I'll let you know :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review60178 --- src/klocalizedstring.h https://git.reviewboard.kde.org/r/118678/#comment41928 The docstring should not at all mention application or refer to availableApplicationTranslations. The return set should always contain en_US, no matter whether setApplicationDomain was called or not. src/klocalizedstring.cpp https://git.reviewboard.kde.org/r/118678/#comment41930 Should not touch s-applicationDomain. Instead, the call to this method in availableApplicationTranslations should be placed only if the application domain was set, otherwise availableApplicationTranslations should return empty set. - Chusslove Illich On June 16, 2014, 2:01 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 16, 2014, 2:01 a.m.) Review request for Plasma, Chusslove Illich and John Layt. Repository: ki18n Description --- Allow querying for translations of a specific domain In the new translations KCM, we want to list available languages for the workspace. This might, or might not be the same application domain as the one set (current translation is different from installed translations). In order to list the installed translations, we need to specify that domain, independently from the one set in KLocalizedString's global static. With this patch, I can successfully list installed languages in the new KCM. I'm not super-familiar with how this stuff works, there might be a better way, in which case I'm sure you guys will enlighten me. :) Diffs - src/klocalizedstring.h 1a9fce8 src/klocalizedstring.cpp e12d6df Diff: https://git.reviewboard.kde.org/r/118678/diff/ Testing --- Tested new translations KCM, languages show up. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118696: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118696/#review60181 --- This review has been submitted with commit fab88696dde52f1e0d234f510339fd3b3b155ed6 by Michael Palimaka to branch frameworks. - Commit Hook On June 12, 2014, 2:45 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118696/ --- (Updated June 12, 2014, 2:45 p.m.) Review request for Plasma. Repository: plasmate Description --- Also disable tests if QtTest is not found. Diffs - CMakeLists.txt 63884d6063e5cee8dafa68ce7ccc37a445a8013b plasmate/CMakeLists.txt 17975dd6e8656f01b02926bca111cbbfa88b79f2 Diff: https://git.reviewboard.kde.org/r/118696/diff/ Testing --- Inspected sources, builds. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118696: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118696/ --- (Updated June 16, 2014, 10:14 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasmate Description --- Also disable tests if QtTest is not found. Diffs - CMakeLists.txt 63884d6063e5cee8dafa68ce7ccc37a445a8013b plasmate/CMakeLists.txt 17975dd6e8656f01b02926bca111cbbfa88b79f2 Diff: https://git.reviewboard.kde.org/r/118696/diff/ Testing --- Inspected sources, builds. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #425
See http://build.kde.org/job/plasma-workspace_master_qt5/425/changes
Changes:
[me] Move the Baloo search runner here
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson7654417364847995448.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
5a113b4..a991e1c master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 5a113b4 ServicesRunner: Implement categoryIcon
Removing build/
Removing local-inst/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision a991e1c1e11c372ae375b6ee77e1587405cf1e22
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f a991e1c1e11c372ae375b6ee77e1587405cf1e22
git rev-list 5a113b449f4396af4c4cfd274a52b9308db27230
git tag -a -f -m Jenkins Build #425 jenkins-plasma-workspace_master_qt5-425
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson4397533569417875226.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kguiaddons - Branch master
kactivities - Branch master
kf5umbrella - Branch master
khtml - Branch master
karchive - Branch master
kcodecs - Branch master
qt5 - Branch stable
kdesupport-svn - Branch master
kcompletion - Branch master
milou - Branch frameworks
kded - Branch master
kidletime - Branch master
kdoctools - Branch master
kjsembed - Branch master
kcrash - Branch master
plasma-framework - Branch master
kdbusaddons - Branch master
kwallet - Branch master
kunitconversion - Branch master
kdnssd - Branch master
kglobalaccel - Branch master
extra-cmake-modules - Branch master
kparts - Branch master
kservice - Branch master
kxmlgui - Branch master
libkscreen - Branch frameworks
libksysguard - Branch master
phonon - Branch master
krunner - Branch master
kconfigwidgets - Branch master
kwin - Branch master
knewstuff - Branch master
kfilemetadata - Branch frameworks
kjs - Branch master
kpty - Branch master
kde-cli-tools - Branch master
sonnet - Branch master
kross - Branch master
kdesu - Branch master
attica - Branch master
kwidgetsaddons - Branch master
kdewebkit - Branch master
frameworkintegration - Branch master
knotifications - Branch master
kdeclarative - Branch master
solid - Branch master
kauth - Branch master
baloo - Branch frameworks
kdelibs4support - Branch master
ktextwidgets - Branch master
ki18n - Branch master
kinit - Branch master
polkit-qt-1 - Branch qt5
threadweaver - Branch master
kconfig - Branch master
kio - Branch master
ktexteditor - Branch master
kcoreaddons - Branch master
kio-extras - Branch master
libdbusmenu-qt - Branch master
kiconthemes - Branch master
kitemviews - Branch master
khelpcenter - Branch master
breeze - Branch master
kdesignerplugin - Branch master
cmake - Branch master
dogtail - Branch master
kitemmodels - Branch master
kplotting - Branch master
kemoticons - Branch master
kcmutils - Branch master
kjobwidgets - Branch master
kbookmarks - Branch master
knotifyconfig - Branch master
kwindowsystem - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
--
Minutes Monday Plasma hangout
Monday Hangout 16.6.2013 Present: Marco, Martin Gräßlin, Jens, Sebastian, Vishesh, Aleix Jens: - Had a meeting within the VDG, will send results around - Trying to beat Firefox into compliance with QtCurve - Lots of design work of systemsettings going on - Things are moving nicely overall Aleix: - Attended Qt Contributor Summit in Berlin - Minutes of invidual sessions are on the Qt development mailinglist - Lars' keynote is also interesting https://www.youtube.com/watch?v=e7W3yMUCNuU Marco: - mindless bugfixing mode - Monochrome kickoff tabbar - Fixes in dialog (yes, more of those) Martin: - Merged warning for dangerous option in compositing kcm - kwin will be renamed to kwin_x11 - kwin/5 will be co-installable with kwin/4 - Added shortcuts - XCB and Qt bugfixes Vishesh: - Worked on Baloo bugfixes - Fixed some runners (applications, for example) - small bugfixes and baloo bugfixes lined up - runner KCM is work in progress Sebastian: - worked on translations KCM, nearing readiness (needs API addition in ki18n) - Will try to implement new categorization in systemsettings - Random bugfixing Next hangout == next monday, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma hangout
On Monday 16 June 2014, Sebastian Kügler wrote: Marco: - mindless bugfixing mode - Monochrome kickoff tabbar - Fixes in dialog (yes, more of those) - startup fixes: no random opening systray at startup - less animations, applets jumping around the panel at startup -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application
On June 14, 2014, 9:12 p.m., Hrvoje Senjan wrote: startkde/ksyncdbusenv/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/118730/diff/2/?file=281040#file281040line5 it was my understanding that KF5_LIBEXEC_INSTALL_DIR is 'reserved' for KF5, and rest of depending software would use libexec_install_dir. iow, this is only executable in kf5/ subdir, that doesn't come from a Framework Martin Gräßlin wrote: thanks for noticing, I'll fix it later today. addressed in http://commits.kde.org/plasma-workspace/2e4ec651a5a12e8d46d1afd17b614aa290306ee0 - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60095 --- On June 14, 2014, 10:41 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/ --- (Updated June 14, 2014, 10:41 a.m.) Review request for Plasma and David Edmundson. Repository: plasma-workspace Description --- [startkde] Introduce a ksyncdbusenv helper application This application is invoked by startkde once all environment variables are set and syncs them to DBus for the activation environment. Diffs - startkde/startkde.cmake 0c1f5841eeefc1012dbdc71e1d1fde11e7511dd6 startkde/ksyncdbusenv/ksyncdbusenv.cpp PRE-CREATION startkde/ksyncdbusenv/CMakeLists.txt PRE-CREATION startkde/CMakeLists.txt 3360a1c59409588ecec49e63276914b69568164e Diff: https://git.reviewboard.kde.org/r/118730/diff/ Testing --- on log in kglobalacceld5 doesn't pick up the right environment yet, but on manual invocation of the tool + trigger restart of kglobalacceld5 it works. So the approach seems to work, just not yet from startkde (maybe it's too late?) Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #426
See http://build.kde.org/job/plasma-workspace_master_qt5/426/changes
Changes:
[mgraesslin] Don't install ksyncdbusenv to /kf5 in libexecdir
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson2190228276376491735.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
a991e1c..2e4ec65 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at a991e1c Move the Baloo search runner here
Removing build/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision 2e4ec651a5a12e8d46d1afd17b614aa290306ee0
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f 2e4ec651a5a12e8d46d1afd17b614aa290306ee0
git rev-list a991e1c1e11c372ae375b6ee77e1587405cf1e22
git tag -a -f -m Jenkins Build #426 jenkins-plasma-workspace_master_qt5-426
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson1100502077683043128.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kdesignerplugin - Branch master
kf5umbrella - Branch master
kinit - Branch master
kglobalaccel - Branch master
qt5 - Branch stable
kdesupport-svn - Branch master
milou - Branch frameworks
ktextwidgets - Branch master
kunitconversion - Branch master
kidletime - Branch master
libksysguard - Branch master
kjsembed - Branch master
plasma-framework - Branch master
khtml - Branch master
kdbusaddons - Branch master
kwallet - Branch master
kio - Branch master
ktexteditor - Branch master
kcodecs - Branch master
extra-cmake-modules - Branch master
kcrash - Branch master
kxmlgui - Branch master
kiconthemes - Branch master
libkscreen - Branch frameworks
kdoctools - Branch master
attica - Branch master
krunner - Branch master
kwin - Branch master
knewstuff - Branch master
kitemmodels - Branch master
kplotting - Branch master
kfilemetadata - Branch frameworks
kjs - Branch master
kjobwidgets - Branch master
kde-cli-tools - Branch master
sonnet - Branch master
kguiaddons - Branch master
kdesu - Branch master
kdnssd - Branch master
knotifications - Branch master
kwidgetsaddons - Branch master
kdewebkit - Branch master
kdeclarative - Branch master
kconfig - Branch master
baloo - Branch frameworks
kded - Branch master
polkit-qt-1 - Branch qt5
kdelibs4support - Branch master
kauth - Branch master
ki18n - Branch master
kbookmarks - Branch master
kwindowsystem - Branch master
kcompletion - Branch master
threadweaver - Branch master
karchive - Branch master
kparts - Branch master
kcoreaddons - Branch master
kio-extras - Branch master
frameworkintegration - Branch master
kservice - Branch master
khelpcenter - Branch master
libdbusmenu-qt - Branch master
solid - Branch master
kitemviews - Branch master
cmake - Branch master
kemoticons - Branch master
phonon - Branch master
breeze - Branch master
kactivities - Branch master
dogtail - Branch master
kconfigwidgets - Branch master
kcmutils - Branch master
kpty - Branch master
kross - Branch master
knotifyconfig - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
--
Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/ --- Review request for Plasma and Vishesh Handa. Repository: plasma-workspace Description --- [krunner] Add Qt::Key_Search as a global shortcut Diffs - krunner/view.cpp f5b1884e60df76527747cf256d02f3ebb93825ca Diff: https://git.reviewboard.kde.org/r/118779/diff/ Testing --- * Alt+F2: works * Alt+Space: works * Search: works might require deleting the config of kglobalshortcutsrc and restarting kglobalacceld5 Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/#review60188 --- Ship it! Ship It! - Vishesh Handa On June 16, 2014, 11:45 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/ --- (Updated June 16, 2014, 11:45 a.m.) Review request for Plasma and Vishesh Handa. Repository: plasma-workspace Description --- [krunner] Add Qt::Key_Search as a global shortcut Diffs - krunner/view.cpp f5b1884e60df76527747cf256d02f3ebb93825ca Diff: https://git.reviewboard.kde.org/r/118779/diff/ Testing --- * Alt+F2: works * Alt+Space: works * Search: works might require deleting the config of kglobalshortcutsrc and restarting kglobalacceld5 Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/#review60191 --- This review has been submitted with commit a68bb91fef6190fca8b0d40d15c20991e8a5bd2d by Martin Gräßlin to branch master. - Commit Hook On June 16, 2014, 11:45 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/ --- (Updated June 16, 2014, 11:45 a.m.) Review request for Plasma and Vishesh Handa. Repository: plasma-workspace Description --- [krunner] Add Qt::Key_Search as a global shortcut Diffs - krunner/view.cpp f5b1884e60df76527747cf256d02f3ebb93825ca Diff: https://git.reviewboard.kde.org/r/118779/diff/ Testing --- * Alt+F2: works * Alt+Space: works * Search: works might require deleting the config of kglobalshortcutsrc and restarting kglobalacceld5 Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/ --- (Updated June 16, 2014, 12:44 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Vishesh Handa. Repository: plasma-workspace Description --- [krunner] Add Qt::Key_Search as a global shortcut Diffs - krunner/view.cpp f5b1884e60df76527747cf256d02f3ebb93825ca Diff: https://git.reviewboard.kde.org/r/118779/diff/ Testing --- * Alt+F2: works * Alt+Space: works * Search: works might require deleting the config of kglobalshortcutsrc and restarting kglobalacceld5 Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #427
See http://build.kde.org/job/plasma-workspace_master_qt5/427/changes
Changes:
[mgraesslin] [krunner] Add Qt::Key_Search as a global shortcut
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson6107222085619112607.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
2e4ec65..a68bb91 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 2e4ec65 Don't install ksyncdbusenv to /kf5 in libexecdir
Removing build/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision a68bb91fef6190fca8b0d40d15c20991e8a5bd2d
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f a68bb91fef6190fca8b0d40d15c20991e8a5bd2d
git rev-list 2e4ec651a5a12e8d46d1afd17b614aa290306ee0
git tag -a -f -m Jenkins Build #427 jenkins-plasma-workspace_master_qt5-427
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson7185333693421605228.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
knotifications - Branch master
kf5umbrella - Branch master
kinit - Branch master
kglobalaccel - Branch master
qt5 - Branch stable
kdesupport-svn - Branch master
milou - Branch frameworks
kemoticons - Branch master
kidletime - Branch master
libksysguard - Branch master
kjsembed - Branch master
plasma-framework - Branch master
kcoreaddons - Branch master
kdbusaddons - Branch master
kwallet - Branch master
kio - Branch master
kcodecs - Branch master
extra-cmake-modules - Branch master
kconfigwidgets - Branch master
kxmlgui - Branch master
kiconthemes - Branch master
kplotting - Branch master
libkscreen - Branch frameworks
kdoctools - Branch master
kauth - Branch master
krunner - Branch master
kwin - Branch master
knewstuff - Branch master
kitemmodels - Branch master
khtml - Branch master
kfilemetadata - Branch frameworks
kjs - Branch master
kunitconversion - Branch master
kjobwidgets - Branch master
kdeclarative - Branch master
kactivities - Branch master
kguiaddons - Branch master
kdesu - Branch master
kdnssd - Branch master
kcrash - Branch master
kwidgetsaddons - Branch master
kdewebkit - Branch master
kde-cli-tools - Branch master
kconfig - Branch master
baloo - Branch frameworks
kded - Branch master
polkit-qt-1 - Branch qt5
kdelibs4support - Branch master
ktextwidgets - Branch master
ki18n - Branch master
kcompletion - Branch master
attica - Branch master
kcmutils - Branch master
ktexteditor - Branch master
kparts - Branch master
karchive - Branch master
kio-extras - Branch master
frameworkintegration - Branch master
kservice - Branch master
khelpcenter - Branch master
libdbusmenu-qt - Branch master
solid - Branch master
kitemviews - Branch master
cmake - Branch master
phonon - Branch master
breeze - Branch master
kbookmarks - Branch master
sonnet - Branch master
dogtail - Branch master
kdesignerplugin - Branch master
kwindowsystem - Branch master
threadweaver - Branch master
kpty - Branch master
kross - Branch master
knotifyconfig - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile
Build failed in Jenkins: plasma-workspace_master_qt5 #428
See http://build.kde.org/job/plasma-workspace_master_qt5/428/changes
Changes:
[notmart] sensible default sizes
[notmart] friendlier window title
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson725467430847452018.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
a68bb91..a7f39bd master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at a68bb91 [krunner] Add Qt::Key_Search as a global shortcut
Removing build/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision a7f39bdef53fbb45e0d2cd3fa66a1eec4c827def
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f a7f39bdef53fbb45e0d2cd3fa66a1eec4c827def
git rev-list a68bb91fef6190fca8b0d40d15c20991e8a5bd2d
git tag -a -f -m Jenkins Build #428 jenkins-plasma-workspace_master_qt5-428
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson7401676945542302291.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kf5umbrella - Branch master
kinit - Branch master
kcodecs - Branch master
qt5 - Branch stable
kio - Branch master
kdesupport-svn - Branch master
kitemviews - Branch master
milou - Branch frameworks
ktextwidgets - Branch master
kidletime - Branch master
libksysguard - Branch master
kjsembed - Branch master
kunitconversion - Branch master
kross - Branch master
khelpcenter - Branch master
plasma-framework - Branch master
kdbusaddons - Branch master
kwin - Branch master
kauth - Branch master
phonon - Branch master
solid - Branch master
kglobalaccel - Branch master
extra-cmake-modules - Branch master
kplotting - Branch master
kxmlgui - Branch master
kjobwidgets - Branch master
libkscreen - Branch frameworks
kdoctools - Branch master
krunner - Branch master
kcrash - Branch master
kwallet - Branch master
knewstuff - Branch master
kfilemetadata - Branch frameworks
kjs - Branch master
kconfig - Branch master
kdeclarative - Branch master
kded - Branch master
kcompletion - Branch master
khtml - Branch master
kdesu - Branch master
kwidgetsaddons - Branch master
kdewebkit - Branch master
kde-cli-tools - Branch master
kcoreaddons - Branch master
baloo - Branch frameworks
karchive - Branch master
polkit-qt-1 - Branch qt5
kdelibs4support - Branch master
kemoticons - Branch master
ki18n - Branch master
kservice - Branch master
knotifications - Branch master
kiconthemes - Branch master
threadweaver - Branch master
ktexteditor - Branch master
kdesignerplugin - Branch master
kparts - Branch master
frameworkintegration - Branch master
kio-extras - Branch master
kitemmodels - Branch master
libdbusmenu-qt - Branch master
kpty - Branch master
kconfigwidgets - Branch master
cmake - Branch master
sonnet - Branch master
kguiaddons - Branch master
breeze - Branch master
kdnssd - Branch master
kactivities - Branch master
dogtail - Branch master
kcmutils - Branch master
kbookmarks - Branch master
attica - Branch master
kwindowsystem - Branch master
knotifyconfig - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile
Build failed in Jenkins: plasma-workspace_master_qt5 #429
See http://build.kde.org/job/plasma-workspace_master_qt5/429/changes
Changes:
[notmart] remove micro configure button
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson2867022091321591816.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
a7f39bd..5010e85 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at a7f39bd friendlier window title
Removing build/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision 5010e854f3f62e73c2525d013c35cc059ef25eeb
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f 5010e854f3f62e73c2525d013c35cc059ef25eeb
git rev-list a7f39bdef53fbb45e0d2cd3fa66a1eec4c827def
git tag -a -f -m Jenkins Build #429 jenkins-plasma-workspace_master_qt5-429
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson21682908248581397.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kf5umbrella - Branch master
kinit - Branch master
kglobalaccel - Branch master
qt5 - Branch stable
kdesupport-svn - Branch master
milou - Branch frameworks
ktextwidgets - Branch master
kidletime - Branch master
kdoctools - Branch master
kjsembed - Branch master
khelpcenter - Branch master
plasma-framework - Branch master
attica - Branch master
kdbusaddons - Branch master
kwallet - Branch master
phonon - Branch master
solid - Branch master
kwindowsystem - Branch master
kcodecs - Branch master
extra-cmake-modules - Branch master
kplotting - Branch master
kxmlgui - Branch master
kconfigwidgets - Branch master
kjobwidgets - Branch master
libkscreen - Branch frameworks
libksysguard - Branch master
krunner - Branch master
kcrash - Branch master
kwin - Branch master
knewstuff - Branch master
kbookmarks - Branch master
kfilemetadata - Branch frameworks
kjs - Branch master
kconfig - Branch master
kde-cli-tools - Branch master
kded - Branch master
kdesignerplugin - Branch master
kdesu - Branch master
kio - Branch master
kdewebkit - Branch master
kwidgetsaddons - Branch master
kdeclarative - Branch master
kcoreaddons - Branch master
baloo - Branch frameworks
karchive - Branch master
polkit-qt-1 - Branch qt5
kemoticons - Branch master
kdelibs4support - Branch master
kunitconversion - Branch master
kross - Branch master
kauth - Branch master
ki18n - Branch master
kservice - Branch master
kcompletion - Branch master
kiconthemes - Branch master
threadweaver - Branch master
ktexteditor - Branch master
knotifications - Branch master
frameworkintegration - Branch master
kio-extras - Branch master
kitemmodels - Branch master
libdbusmenu-qt - Branch master
kpty - Branch master
kitemviews - Branch master
cmake - Branch master
sonnet - Branch master
kguiaddons - Branch master
breeze - Branch master
kdnssd - Branch master
kactivities - Branch master
dogtail - Branch master
kcmutils - Branch master
khtml - Branch master
kparts - Branch master
knotifyconfig - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found KF5Plasma:
kwindowsystem high level functions
I think that Thomas Luebking agrred with me on this: http://osdir.com/ml/kde-devel/2014-02/msg00063.html except closeWindow I also see missing void setBlockingCompositing(bool active); void setShowingDesktop(bool showing); void setNumberOfDesktops(int numberOfDesktops); It would be only natural to have them in kwindowsystem.h as that's already the place where you check for their values, get notified about their changes etc. Kind regards. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kwindowsystem high level functions
On Monday 16 June 2014 15:14:08 Damian Ivanov wrote: I think that Thomas Luebking agrred with me on this: http://osdir.com/ml/kde-devel/2014-02/msg00063.html except closeWindow I also see missing void setBlockingCompositing(bool active); void setShowingDesktop(bool showing); void setNumberOfDesktops(int numberOfDesktops); It would be only natural to have them in kwindowsystem.h as that's already the place where you check for their values, get notified about their changes etc. what's the use case for having them in KWindowSystem? Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118512: Turn KFileMetaData into a Framework.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/#review60193 --- I just realized that there is another review about this who is not you - https://git.reviewboard.kde.org/r/118670/ Would you mind dropping this? His patch is ready to be shipped. - Vishesh Handa On June 14, 2014, 10:40 p.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/ --- (Updated June 14, 2014, 10:40 p.m.) Review request for Plasma, Jonathan Riddell and Vishesh Handa. Bugs: https://bugs.gentoo.org/show_bug.cgi?id=512334 http://bugs.kde.org/show_bug.cgi?id=https://bugs.gentoo.org/show_bug.cgi?id=512334 Repository: kfilemetadata Description --- Turn KFileMetaData into a Framework. Diffs - src/typeinfo.h 2675cbbd5751de9a7ac77cf9fdda4cb6d0a7806e src/propertyinfo.h bb54f58c750eff8c39685861a5346c025265949b src/extractors/CMakeLists.txt 0099c0878315a07f4d7b1369dc1471a8401f10a7 src/extractorpluginmanager.h d4a871e7d5952edb48c5836769741d7cf20bd29f src/extractorplugin.h 218ef207982e31f0142983d75b4846cd0f45f02a src/extractionresult.h 76dfe590aaf1f1fda265a4835fa1bcdbc81ba58a src/CMakeLists.txt 82dbd5c32050081642e9fff958d229f55893d40c autotests/CMakeLists.txt c657a7002d1d0644d6de4438a193bb63657b7ec0 KFileMetaDataConfig.cmake.in b4d1c93b7a23ffcbb03a89e9d4a11559d7e22037 KF5FileMetaDataConfig.cmake.in PRE-CREATION CMakeLists.txt 5a9eefa89b2fc7e6202347daf105baa867328ffc Diff: https://git.reviewboard.kde.org/r/118512/diff/ Testing --- Tested compiling Baloo against a system install with this patch applied. Baloo sucessfully linked against the KF5 version and all Baloo tests ran to completion. All KFileMetaData unit tests passed too ;) Thanks, Matthew Dawson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #430
See http://build.kde.org/job/plasma-workspace_master_qt5/430/changes
Changes:
[aleixpol] Fix some problems in the lock screen
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson1536865709796950575.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
5010e85..9d4b8e9 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 5010e85 remove micro configure button
Removing build/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision 9d4b8e9a71c5745c41819e435713436ce285b644
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f 9d4b8e9a71c5745c41819e435713436ce285b644
git rev-list 5010e854f3f62e73c2525d013c35cc059ef25eeb
git tag -a -f -m Jenkins Build #430 jenkins-plasma-workspace_master_qt5-430
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson4616038133278000153.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kwindowsystem - Branch master
kf5umbrella - Branch master
kiconthemes - Branch master
kinit - Branch master
kglobalaccel - Branch master
qt5 - Branch stable
kconfigwidgets - Branch master
kdesupport-svn - Branch master
milou - Branch frameworks
ktextwidgets - Branch master
kitemmodels - Branch master
kidletime - Branch master
kdoctools - Branch master
kjsembed - Branch master
kguiaddons - Branch master
plasma-framework - Branch master
ktexteditor - Branch master
kdbusaddons - Branch master
kwallet - Branch master
khelpcenter - Branch master
solid - Branch master
kcodecs - Branch master
extra-cmake-modules - Branch master
kxmlgui - Branch master
libkscreen - Branch frameworks
libksysguard - Branch master
kplotting - Branch master
krunner - Branch master
kcompletion - Branch master
kwin - Branch master
knewstuff - Branch master
kfilemetadata - Branch frameworks
kjs - Branch master
kdnssd - Branch master
kcrash - Branch master
kde-cli-tools - Branch master
sonnet - Branch master
khtml - Branch master
kbookmarks - Branch master
kdesu - Branch master
kwidgetsaddons - Branch master
kdewebkit - Branch master
kjobwidgets - Branch master
attica - Branch master
kdeclarative - Branch master
phonon - Branch master
baloo - Branch frameworks
kauth - Branch master
polkit-qt-1 - Branch qt5
kio - Branch master
kdelibs4support - Branch master
kemoticons - Branch master
ki18n - Branch master
knotifications - Branch master
threadweaver - Branch master
kconfig - Branch master
kservice - Branch master
kparts - Branch master
kcoreaddons - Branch master
kio-extras - Branch master
libdbusmenu-qt - Branch master
kitemviews - Branch master
cmake - Branch master
kded - Branch master
breeze - Branch master
kpty - Branch master
kactivities - Branch master
dogtail - Branch master
karchive - Branch master
kunitconversion - Branch master
frameworkintegration - Branch master
kcmutils - Branch master
kdesignerplugin - Branch master
kross - Branch master
knotifyconfig - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found KF5Plasma:
Build failed in Jenkins: plasma-workspace_master_qt5 #431
See http://build.kde.org/job/plasma-workspace_master_qt5/431/changes
Changes:
[lukas] add missing Messages.sh, fix catalog loading
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson355241360531798483.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
9d4b8e9..a3f8cfa master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 9d4b8e9 Fix some problems in the lock screen
Removing build/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision a3f8cfa159796ab2933392062a2eb0551961253d
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f a3f8cfa159796ab2933392062a2eb0551961253d
git rev-list 9d4b8e9a71c5745c41819e435713436ce285b644
git tag -a -f -m Jenkins Build #431 jenkins-plasma-workspace_master_qt5-431
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson3403369257456497121.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kf5umbrella - Branch master
kiconthemes - Branch master
kinit - Branch master
kglobalaccel - Branch master
qt5 - Branch stable
kdesupport-svn - Branch master
milou - Branch frameworks
ktextwidgets - Branch master
kitemmodels - Branch master
kjobwidgets - Branch master
kidletime - Branch master
kdoctools - Branch master
kjsembed - Branch master
kguiaddons - Branch master
plasma-framework - Branch master
khtml - Branch master
kwallet - Branch master
ki18n - Branch master
khelpcenter - Branch master
solid - Branch master
kconfig - Branch master
kcodecs - Branch master
extra-cmake-modules - Branch master
kxmlgui - Branch master
kactivities - Branch master
libkscreen - Branch frameworks
libksysguard - Branch master
kplotting - Branch master
kitemviews - Branch master
krunner - Branch master
kcompletion - Branch master
kwin - Branch master
knewstuff - Branch master
kfilemetadata - Branch frameworks
kjs - Branch master
kdnssd - Branch master
kcrash - Branch master
kdeclarative - Branch master
kdbusaddons - Branch master
kdesu - Branch master
karchive - Branch master
kwidgetsaddons - Branch master
kdewebkit - Branch master
kdesignerplugin - Branch master
phonon - Branch master
kde-cli-tools - Branch master
baloo - Branch frameworks
kauth - Branch master
polkit-qt-1 - Branch qt5
kdelibs4support - Branch master
kcoreaddons - Branch master
kwindowsystem - Branch master
kemoticons - Branch master
kded - Branch master
knotifications - Branch master
threadweaver - Branch master
ktexteditor - Branch master
kservice - Branch master
kparts - Branch master
frameworkintegration - Branch master
kio-extras - Branch master
libdbusmenu-qt - Branch master
kbookmarks - Branch master
kconfigwidgets - Branch master
cmake - Branch master
attica - Branch master
breeze - Branch master
kpty - Branch master
sonnet - Branch master
dogtail - Branch master
kunitconversion - Branch master
kcmutils - Branch master
kio - Branch master
kross - Branch master
knotifyconfig - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found
Re: Review Request 118482: Adjust ksmserver for renamed KWin binary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/#review60197 --- This review has been submitted with commit 6cbbe0a2faddf75fdf577f1e90ad3ec3e432fb23 by Martin Gräßlin on behalf of Hrvoje Senjan to branch master. - Commit Hook On June 3, 2014, 1:22 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/ --- (Updated June 3, 2014, 1:22 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- as per dependant review, adjust ksmserver usage of KWin name. (IOW make sure kwin_x11 is started) Diffs - ConfigureChecks.cmake 8e6a87a ksmserver/config-ksmserver.h.cmake 939632c ksmserver/server.cpp 644013b ksmserver/startup.cpp 6f5d502 Diff: https://git.reviewboard.kde.org/r/118482/diff/ Testing --- using it for some ~10 days, noticed no regression. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118482: Adjust ksmserver for renamed KWin binary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/ --- (Updated June 16, 2014, 1:39 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- as per dependant review, adjust ksmserver usage of KWin name. (IOW make sure kwin_x11 is started) Diffs - ConfigureChecks.cmake 8e6a87a ksmserver/config-ksmserver.h.cmake 939632c ksmserver/server.cpp 644013b ksmserver/startup.cpp 6f5d502 Diff: https://git.reviewboard.kde.org/r/118482/diff/ Testing --- using it for some ~10 days, noticed no regression. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118574: Adjust componentchooser for renamed KWin binary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118574/#review60198 --- This review has been submitted with commit ba346b6c2d17dff7f613aef84fef2cc73c34bc43 by Martin Gräßlin on behalf of Hrvoje Senjan to branch master. - Commit Hook On June 5, 2014, 7:17 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118574/ --- (Updated June 5, 2014, 7:17 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-desktop Description --- complementary to r118266 r118482 Diffs - ConfigureChecks.cmake f0a23bf config-workspace.h.cmake 66c1d63 kcms/componentchooser/componentchooserwm.cpp 22dfa31 Diff: https://git.reviewboard.kde.org/r/118574/diff/ Testing --- builds, reseting to default one writes in kwin_x11 in ksmserverrc, upon restarting kwin_x11 is invoked. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118574: Adjust componentchooser for renamed KWin binary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118574/ --- (Updated June 16, 2014, 1:39 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Repository: plasma-desktop Description --- complementary to r118266 r118482 Diffs - ConfigureChecks.cmake f0a23bf config-workspace.h.cmake 66c1d63 kcms/componentchooser/componentchooserwm.cpp 22dfa31 Diff: https://git.reviewboard.kde.org/r/118574/diff/ Testing --- builds, reseting to default one writes in kwin_x11 in ksmserverrc, upon restarting kwin_x11 is invoked. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-workspace_master_qt5 #432
See http://build.kde.org/job/plasma-workspace_master_qt5/432/changes
Changes:
[lukas] add missing and fix Messages.sh
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson5787715055183291349.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
a3f8cfa..3cac388 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at a3f8cfa add missing Messages.sh, fix catalog loading
Removing build/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision 3cac388d32b6ce788c855d9571ad30dc326a49dc
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f 3cac388d32b6ce788c855d9571ad30dc326a49dc
git rev-list a3f8cfa159796ab2933392062a2eb0551961253d
git tag -a -f -m Jenkins Build #432 jenkins-plasma-workspace_master_qt5-432
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson1448058153853614746.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kf5umbrella - Branch master
kiconthemes - Branch master
kinit - Branch master
kglobalaccel - Branch master
qt5 - Branch stable
kdesupport-svn - Branch master
attica - Branch master
milou - Branch frameworks
ktextwidgets - Branch master
kwidgetsaddons - Branch master
kidletime - Branch master
kitemmodels - Branch master
kdoctools - Branch master
kjsembed - Branch master
kguiaddons - Branch master
plasma-framework - Branch master
kded - Branch master
kwallet - Branch master
khelpcenter - Branch master
solid - Branch master
kconfig - Branch master
kcodecs - Branch master
extra-cmake-modules - Branch master
kxmlgui - Branch master
kactivities - Branch master
libkscreen - Branch frameworks
libksysguard - Branch master
kplotting - Branch master
krunner - Branch master
kjobwidgets - Branch master
kwin - Branch master
knewstuff - Branch master
kconfigwidgets - Branch master
kfilemetadata - Branch frameworks
kjs - Branch master
kdnssd - Branch master
kcrash - Branch master
kde-cli-tools - Branch master
kdbusaddons - Branch master
kdesu - Branch master
kwindowsystem - Branch master
kdewebkit - Branch master
phonon - Branch master
kdeclarative - Branch master
baloo - Branch frameworks
kauth - Branch master
polkit-qt-1 - Branch qt5
kdelibs4support - Branch master
kcoreaddons - Branch master
kbookmarks - Branch master
kemoticons - Branch master
ki18n - Branch master
knotifications - Branch master
kcompletion - Branch master
threadweaver - Branch master
ktexteditor - Branch master
kservice - Branch master
kparts - Branch master
kio - Branch master
frameworkintegration - Branch master
kio-extras - Branch master
libdbusmenu-qt - Branch master
khtml - Branch master
kitemviews - Branch master
cmake - Branch master
breeze - Branch master
karchive - Branch master
kpty - Branch master
sonnet - Branch master
dogtail - Branch master
kdesignerplugin - Branch master
kunitconversion - Branch master
kcmutils - Branch master
kross - Branch master
knotifyconfig - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found
Build failed in Jenkins: plasma-workspace_master_qt5 #433
See http://build.kde.org/job/plasma-workspace_master_qt5/433/changes
Changes:
[mgraesslin] Adjust KSMServer to renamed KWin binary
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/plasma-workspace_master_qt5/ws/
Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson8027881342358779104.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/plasma-workspace
3cac388..6cbbe0a master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 3cac388 add missing and fix Messages.sh
Removing build/
Success build forhudson.tasks.Shell@4968aa9c
git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
git --version
git fetch --tags --progress git://anongit.kde.org/plasma-workspace
+refs/heads/*:refs/remotes/origin/*
git rev-parse origin/refs/heads/jenkins^{commit}
git rev-parse refs/heads/jenkins^{commit}
Checking out Revision 6cbbe0a2faddf75fdf577f1e90ad3ec3e432fb23
(refs/heads/jenkins)
git config core.sparsecheckout
git checkout -f 6cbbe0a2faddf75fdf577f1e90ad3ec3e432fb23
git rev-list 3cac388d32b6ce788c855d9571ad30dc326a49dc
git tag -a -f -m Jenkins Build #433 jenkins-plasma-workspace_master_qt5-433
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson8880980401022108230.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
kjobwidgets - Branch master
kf5umbrella - Branch master
kross - Branch master
kinit - Branch master
kglobalaccel - Branch master
qt5 - Branch stable
kdesupport-svn - Branch master
milou - Branch frameworks
ktextwidgets - Branch master
kidletime - Branch master
libksysguard - Branch master
kjsembed - Branch master
plasma-framework - Branch master
kconfigwidgets - Branch master
karchive - Branch master
kdbusaddons - Branch master
kwallet - Branch master
kwidgetsaddons - Branch master
kdnssd - Branch master
kcompletion - Branch master
kguiaddons - Branch master
extra-cmake-modules - Branch master
kunitconversion - Branch master
kxmlgui - Branch master
khtml - Branch master
kcrash - Branch master
libkscreen - Branch frameworks
kdoctools - Branch master
krunner - Branch master
solid - Branch master
attica - Branch master
kwin - Branch master
knewstuff - Branch master
phonon - Branch master
kjs - Branch master
kde-cli-tools - Branch master
sonnet - Branch master
kdesu - Branch master
kconfig - Branch master
kiconthemes - Branch master
kdewebkit - Branch master
kdeclarative - Branch master
baloo - Branch frameworks
kauth - Branch master
polkit-qt-1 - Branch qt5
kservice - Branch master
kdelibs4support - Branch master
kcodecs - Branch master
kemoticons - Branch master
ki18n - Branch master
kfilemetadata - Branch frameworks
knotifications - Branch master
kdesignerplugin - Branch master
threadweaver - Branch master
ktexteditor - Branch master
kplotting - Branch master
kparts - Branch master
kpty - Branch master
kcoreaddons - Branch master
kio-extras - Branch master
kwindowsystem - Branch master
kded - Branch master
libdbusmenu-qt - Branch master
kbookmarks - Branch master
kitemviews - Branch master
khelpcenter - Branch master
frameworkintegration - Branch master
breeze - Branch master
kio - Branch master
kactivities - Branch master
dogtail - Branch master
kcmutils - Branch master
cmake - Branch master
knotifyconfig - Branch master
kitemmodels - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found
Re: Re: kwindowsystem high level functions
On Monday 16 June 2014 15:34:13 Damian Ivanov wrote: I mean you read a property from one class and write to it in a differen class? How can I use kwindowsystem to close a window in wayland (isn't QX11Info::dispay required in netwm) ? not at all as there is no Wayland backend in KWindowSystem :-) Let's care about Wayland when we have to care about it. NetWM is a class which is X11 only. It will never be possible to use it with Wayland and it's not intended to be used for it. We will have to see whether we need something low-level for Wayland, too. I don't know yet, but such code will not start to be written in KWindowSystem but most likely first somewhere like libkworkspace. It will need some time to get used to the new world and that's something where we need to experiment first before going for public API. Whether closing a window is something which will be needed for Wayland in KWindowSystem is quite questionable. If at all it's the taskmanager, no other client should be allowed to perform such a task. So most likely it will be an exposed interface between Plasma and KWin to allow Plasma to perform such an operation. Then I don't see much need to expose it in a high level API, if there is exactly one application which is allowed to use it. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117751: Improve dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117751/ --- (Updated June 16, 2014, 1:55 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- - Remove KF5Su as it is not used - Remove XCB components that are not used - Make KF5DocTools optional in the same fashion as kwin Diffs - CMakeLists.txt cb7466b344028e09d0f26f6117da64d694853372 kcms/kfontinst/kcmfontinst/CMakeLists.txt 90c96a06047ebf7522bd6a249b77a5d046cdcc8b Diff: https://git.reviewboard.kde.org/r/117751/diff/ Testing --- Inspected source. Builds. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118763/
---
(Updated June 16, 2014, 2:07 p.m.)
Review request for kde-workspace, Plasma and Hugo Pereira Da Costa.
Repository: oxygen
Description
---
No idea if kde-workspace is still the right group, if not, please change.
find_package(XCB) is called without specifying the required components. This
leads to linking to unused dependencies in case they are installed.
Since XCB is searched for in the top level cmake file in the repository, there
is no need to search for it again. The component required there (only base XCB)
is sufficient.
Although, this should be sufficient to fix the deps problem, it makes sense to
link to XCB::XCB instead of ${XCB_LIBRARIES}, since the former is what is
actually needed.
Diffs
-
kstyle/CMakeLists.txt 165b62a
liboxygen/CMakeLists.txt 0d1dd94
Diff: https://git.reviewboard.kde.org/r/118763/diff/
Testing
---
Thanks,
Bernd Steinhauser
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
On June 16, 2014, 8:54 a.m., Ben Cooksley wrote: As systemsettingsview is unlikely to break BC any further in the 4.x series, could the bump be to SOVERSION 3 instead please? Otherwise, this looks fine to go in from my perspective. off course, i've just used 5, as the rest of the Workspace 'umbrella' uses it. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- On May 28, 2014, 9:26 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/ --- (Updated May 28, 2014, 9:26 p.m.) Review request for Plasma and Ben Cooksley. Repository: systemsettings Description --- otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version Diffs - core/CMakeLists.txt 9752ad7 Diff: https://git.reviewboard.kde.org/r/118387/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 16, 2014, 2:43 p.m.) Review request for Plasma, Chusslove Illich and John Layt. Changes --- Implement Chusslove's suggestions. Repository: ki18n Description --- Allow querying for translations of a specific domain In the new translations KCM, we want to list available languages for the workspace. This might, or might not be the same application domain as the one set (current translation is different from installed translations). In order to list the installed translations, we need to specify that domain, independently from the one set in KLocalizedString's global static. With this patch, I can successfully list installed languages in the new KCM. I'm not super-familiar with how this stuff works, there might be a better way, in which case I'm sure you guys will enlighten me. :) Diffs (updated) - src/klocalizedstring.h 1a9fce8 src/klocalizedstring.cpp e12d6df Diff: https://git.reviewboard.kde.org/r/118678/diff/ Testing --- Tested new translations KCM, languages show up. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: kwindowsystem high level functions
Ok. Whether closing a window is something which will be needed for Wayland in KWindowSystem is quite questionable. If at all it's the taskmanager, no other client should be allowed to perform such a task. I hope you consider for the future non-plasma taskmanagers using kwindowsystem (my fingers crossed). I'm writing such :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: kwindowsystem high level functions
On Mon, Jun 16, 2014 at 4:45 PM, Damian Ivanov damianator...@gmail.com wrote: Ok. Whether closing a window is something which will be needed for Wayland in KWindowSystem is quite questionable. If at all it's the taskmanager, no other client should be allowed to perform such a task. I hope you consider for the future non-plasma taskmanagers using kwindowsystem (my fingers crossed). I'm writing such :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel Well, on the other hand, the development is open. If you're willing to help we'll be happy to accept meaningful patches. OpenSource is about walking together, by many definitions of together. I think that what Marting means here though, is that some of these things might not be that shareable, but you seem to have taken some steps there. Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: kwindowsystem high level functions
Yes, I absolutely will, I also have a wrapper that exposes kwindosystem and kwindowinfo (and few netwm ones) functions to qml https://github.com/damianatorrpm/qmltaskbar (used by https://github.com/damianatorrpm/qmlpanel - old revision there, uploading new one soon) It is a complete rewrite of my 1st version, I hope to have the 2nd version complete replacing my 1st one by tomorrow :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-workspace_master_qt5 #434
See http://build.kde.org/job/plasma-workspace_master_qt5/434/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review60206 --- Ship it! Ship It! - Chusslove Illich On June 16, 2014, 4:43 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 16, 2014, 4:43 p.m.) Review request for Plasma, Chusslove Illich and John Layt. Repository: ki18n Description --- Allow querying for translations of a specific domain In the new translations KCM, we want to list available languages for the workspace. This might, or might not be the same application domain as the one set (current translation is different from installed translations). In order to list the installed translations, we need to specify that domain, independently from the one set in KLocalizedString's global static. With this patch, I can successfully list installed languages in the new KCM. I'm not super-familiar with how this stuff works, there might be a better way, in which case I'm sure you guys will enlighten me. :) Diffs - src/klocalizedstring.h 1a9fce8 src/klocalizedstring.cpp e12d6df Diff: https://git.reviewboard.kde.org/r/118678/diff/ Testing --- Tested new translations KCM, languages show up. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118753/ --- (Updated June 16, 2014, 6:07 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- Now that we can handle mouse wheel events with QtQuick 2, we should. It mimics QSlider's behavior meaning scrolling vertically up (angleDelta.y 0) and scrolling horizontally right (angleDelta.x 0 - though WheelEvent documentation suggests otherwise) is treated the same. Anyone with a mousewheel that can actually scroll sideways is invited to test. Also WheelEvent behaves erratic when scrolling horizontally on my touchpad (reporting 1 digit y values instead of proper x values) Diffs - src/declarativeimports/plasmacomponents/qml/Slider.qml 142040a Diff: https://git.reviewboard.kde.org/r/118753/diff/ Testing --- Tested in a horizontal slider with both mouse and touchpad scrolling with either vertical or (by holding Alt) horizontal scrolling Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118753/#review60207 --- This review has been submitted with commit 76175fafa6d3a38d739c0ab016528010040068fc by Kai Uwe Broulik to branch master. - Commit Hook On June 15, 2014, 12:01 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118753/ --- (Updated June 15, 2014, 12:01 a.m.) Review request for Plasma. Repository: plasma-framework Description --- Now that we can handle mouse wheel events with QtQuick 2, we should. It mimics QSlider's behavior meaning scrolling vertically up (angleDelta.y 0) and scrolling horizontally right (angleDelta.x 0 - though WheelEvent documentation suggests otherwise) is treated the same. Anyone with a mousewheel that can actually scroll sideways is invited to test. Also WheelEvent behaves erratic when scrolling horizontally on my touchpad (reporting 1 digit y values instead of proper x values) Diffs - src/declarativeimports/plasmacomponents/qml/Slider.qml 142040a Diff: https://git.reviewboard.kde.org/r/118753/diff/ Testing --- Tested in a horizontal slider with both mouse and touchpad scrolling with either vertical or (by holding Alt) horizontal scrolling Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: kwindowsystem high level functions
And in case this was a hint I should contribute to a wayland kwindowsystem backend, my c is awful, but I'm learning and believe I will when I can. :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review60213 --- This review has been submitted with commit d09bfbd3949688c3eaf422cd785f77c96ff6e399 by Sebastian Kügler to branch master. - Commit Hook On June 16, 2014, 2:43 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 16, 2014, 2:43 p.m.) Review request for Plasma, Chusslove Illich and John Layt. Repository: ki18n Description --- Allow querying for translations of a specific domain In the new translations KCM, we want to list available languages for the workspace. This might, or might not be the same application domain as the one set (current translation is different from installed translations). In order to list the installed translations, we need to specify that domain, independently from the one set in KLocalizedString's global static. With this patch, I can successfully list installed languages in the new KCM. I'm not super-familiar with how this stuff works, there might be a better way, in which case I'm sure you guys will enlighten me. :) Diffs - src/klocalizedstring.h 1a9fce8 src/klocalizedstring.cpp e12d6df Diff: https://git.reviewboard.kde.org/r/118678/diff/ Testing --- Tested new translations KCM, languages show up. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 16, 2014, 9:32 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Chusslove Illich and John Layt. Repository: ki18n Description --- Allow querying for translations of a specific domain In the new translations KCM, we want to list available languages for the workspace. This might, or might not be the same application domain as the one set (current translation is different from installed translations). In order to list the installed translations, we need to specify that domain, independently from the one set in KLocalizedString's global static. With this patch, I can successfully list installed languages in the new KCM. I'm not super-familiar with how this stuff works, there might be a better way, in which case I'm sure you guys will enlighten me. :) Diffs - src/klocalizedstring.h 1a9fce8 src/klocalizedstring.cpp e12d6df Diff: https://git.reviewboard.kde.org/r/118678/diff/ Testing --- Tested new translations KCM, languages show up. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118512: Turn KFileMetaData into a Framework.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/ --- (Updated June 16, 2014, 5:44 p.m.) Status -- This change has been discarded. Review request for Plasma, Jonathan Riddell and Vishesh Handa. Bugs: https://bugs.gentoo.org/show_bug.cgi?id=512334 http://bugs.kde.org/show_bug.cgi?id=https://bugs.gentoo.org/show_bug.cgi?id=512334 Repository: kfilemetadata Description --- Turn KFileMetaData into a Framework. Diffs - src/typeinfo.h 2675cbbd5751de9a7ac77cf9fdda4cb6d0a7806e src/propertyinfo.h bb54f58c750eff8c39685861a5346c025265949b src/extractors/CMakeLists.txt 0099c0878315a07f4d7b1369dc1471a8401f10a7 src/extractorpluginmanager.h d4a871e7d5952edb48c5836769741d7cf20bd29f src/extractorplugin.h 218ef207982e31f0142983d75b4846cd0f45f02a src/extractionresult.h 76dfe590aaf1f1fda265a4835fa1bcdbc81ba58a src/CMakeLists.txt 82dbd5c32050081642e9fff958d229f55893d40c autotests/CMakeLists.txt c657a7002d1d0644d6de4438a193bb63657b7ec0 KFileMetaDataConfig.cmake.in b4d1c93b7a23ffcbb03a89e9d4a11559d7e22037 KF5FileMetaDataConfig.cmake.in PRE-CREATION CMakeLists.txt 5a9eefa89b2fc7e6202347daf105baa867328ffc Diff: https://git.reviewboard.kde.org/r/118512/diff/ Testing --- Tested compiling Baloo against a system install with this patch applied. Baloo sucessfully linked against the KF5 version and all Baloo tests ran to completion. All KFileMetaData unit tests passed too ;) Thanks, Matthew Dawson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
