Background for login, splash, and lockscreen
Hello all, With the sharpness of the default background image in the login, splash and lockscreen, both the foreground and background appear to be in focus - causing a slightly uncomfortable lack of depth. Things seem to look better with a defocused and slightly dimmed background - the foreground appears sharp and in-focus relative to the background and the fade-to-desktop effect with the default wallpaper has the pleasant visual side effect of appearing to bring the desktop into focus. Before I could get a screenshot my local neon install kinda flaked out. So I've provided a link to the defocused and dimmed background image. I'm hoping someone can try it out locally before I commit. It replaces the background.png file in lookandfeel/contents/components/artwork and lookandfeel/contents/splash/images. (Also I'd be fine if the same thing were accomplished programmatically instead.) New background file: http://wstaw.org/m/2014/06/21/background.png Could someone try this out when you get a chance? I'll commit if there are no objections. Thanks, Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/#review60640 --- This review has been submitted with commit 64e556652117408dcfe35cb03dc7e77d43a2eac2 by Shantanu Tushar on behalf of Sinny Kumari to branch vsrao-seriesbackend. - Commit Hook On June 11, 2014, 2:27 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/ --- (Updated June 11, 2014, 2:27 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- As of now, PMC only uses the MediaPlay button to give the user an option to play/pause media from the home screen. However, not all keyboards have the MediaPlay button AFAIK. This patch gives the user the option to play/pause the media from the home screen using the spacebar key as another alternative. Diffs - shells/newshell/package/contents/ui/mediacenter.qml e1bc0e6 Diff: https://git.reviewboard.kde.org/r/118468/diff/ Testing --- Play any media, navigate to homescreen. Press the spacebar to check if the media plays/pauses. Seems to work fine to me. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118688: Avoid crash when artist is invalid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/#review60641 --- This review has been submitted with commit d9bc355a07eb898b8b951efec27ccc8759d1a511 by Shantanu Tushar on behalf of Bhushan Shah to branch vsrao-seriesbackend. - Commit Hook On June 12, 2014, 1:07 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/ --- (Updated June 12, 2014, 1:07 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Artist can be invalid, dont fetch artist name if it is invalid. Diffs - libs/mediacenter/medialibrary.cpp c8b7ab1 Diff: https://git.reviewboard.kde.org/r/118688/diff/ Testing --- Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118767: Fix for Bug 328532 - Remember the playlist I was using when I closed PMC last time
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/#review60645 --- This review has been submitted with commit 312950ac1408cf421a48565126df07bf4f4e44fe by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend. - Commit Hook On June 19, 2014, 5:14 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/ --- (Updated June 19, 2014, 5:14 p.m.) Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 328532 http://bugs.kde.org/show_bug.cgi?id=328532 Repository: plasma-mediacenter Description --- PMC didn't used to remember the playlist I was on the last time, when restarting it. Now it saves the lastPlaylist while closing in the settings, and when starting it loads the value of lastPlaylist in settings Diffs - libs/mediacenter/playlistmodel.cpp dccaf52 Diff: https://git.reviewboard.kde.org/r/118767/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review60642 --- This review has been submitted with commit 1e05c24eadd0668345990713e8e9916339bfc30c by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend. - Commit Hook On June 12, 2014, 5:51 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/ --- (Updated June 12, 2014, 5:51 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Change the currentIndex of playlistModel to -1 when a media is played from somewhere other than playlist. Diffs - libs/mediacenter/playlistmodel.h 0de7c56 libs/mediacenter/playlistmodel.cpp c5ab1ab shells/newshell/package/contents/ui/mediacenter.qml a859225 Diff: https://git.reviewboard.kde.org/r/118691/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118824: Fix for Bug 336414 - Playlist switching doesnt move highlight
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118824/#review60644 --- This review has been submitted with commit f5118554d78a471c28afc1f6624909ba65ac6b31 by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend. - Commit Hook On June 19, 2014, 2:10 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118824/ --- (Updated June 19, 2014, 2:10 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 336414 http://bugs.kde.org/show_bug.cgi?id=336414 Repository: plasma-mediacenter Description --- Whenever we added / removed any playlist, the highlight was stuck at one point i.e changing the playlist after that was not changing the highlight. This was happening because we were directly assigning value to multiplePlaylistList.currentIndex in qml code, which removed its previous binding. Instead we should emit the currentIndexChanged() signal and let the ListView do the rest. Diffs - libs/mediacenter/multipleplaylistmodel.cpp 87601f5 mediaelements/playlist/MultiplePlaylists.qml 4b085fe Diff: https://git.reviewboard.kde.org/r/118824/diff/ Testing --- Changed playlist after adding / removing a playlist. Now highlight is working fine Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118759: Add a separator to the path where PMC stores playlist file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/#review60643 --- This review has been submitted with commit a9a575cdb76887751b60b4b76460e8406c5f by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend. - Commit Hook On June 15, 2014, 4:21 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/ --- (Updated June 15, 2014, 4:21 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Due to a lack of separator, PMC was storing the file in a different directory and reading playlists from a different directory. Diffs - libs/mediacenter/playlistmodel.cpp 4c52f00 Diff: https://git.reviewboard.kde.org/r/118759/diff/ Testing --- Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
On Saturday 21 June 2014 00:25:35 Andrew Lake wrote: Hello all, With the sharpness of the default background image in the login, splash and lockscreen, both the foreground and background appear to be in focus - causing a slightly uncomfortable lack of depth. Things seem to look better with a defocused and slightly dimmed background - the foreground appears sharp and in-focus relative to the background and the fade-to-desktop effect with the default wallpaper has the pleasant visual side effect of appearing to bring the desktop into focus. Before I could get a screenshot my local neon install kinda flaked out. So I've provided a link to the defocused and dimmed background image. I'm hoping someone can try it out locally before I commit. It replaces the background.png file in lookandfeel/contents/components/artwork and lookandfeel/contents/splash/images. (Also I'd be fine if the same thing were accomplished programmatically instead.) New background file: http://wstaw.org/m/2014/06/21/background.png Could someone try this out when you get a chance? I'll commit if there are no objections. ok, so this goes on login, splash and lockscreen, while the normal background is still in focus? sounds good to me btw just to be sure, this is going to be the final default background? (at some point i understood it could have been this one http://1.bp.blogspot.com/-pt8ssY4qgCQ/U3oNfW1csmI/MsA/LQvL-FvMiVQ/s1600/loving+it.png= since the desktop default icon seems to have a variant of it -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
I am +1 about blurring the login AND as for the wallpaper: I've talked to Nuno about it and there is some Mggrmmrl going on there since he has fallen out of love with it and we still need him to send us the proper SVG's off it so we can do several different resolutions of it. If Andrews wallpaper is the new default (assuming its homemade... Andrew?) or whatever it is we should get it sorted asap since we need to use it as the background for the login and it would be nice to put this issue to rest. If Andrews image isn't homebrewed I will hound Nuno some more to get it sent to me so we can just get that bit off our collective chests /Jens (post-midsummer, insanely tired) On Saturday 21 June 2014 12.45.59 Marco Martin wrote: On Saturday 21 June 2014 00:25:35 Andrew Lake wrote: Hello all, With the sharpness of the default background image in the login, splash and lockscreen, both the foreground and background appear to be in focus - causing a slightly uncomfortable lack of depth. Things seem to look better with a defocused and slightly dimmed background - the foreground appears sharp and in-focus relative to the background and the fade-to-desktop effect with the default wallpaper has the pleasant visual side effect of appearing to bring the desktop into focus. Before I could get a screenshot my local neon install kinda flaked out. So I've provided a link to the defocused and dimmed background image. I'm hoping someone can try it out locally before I commit. It replaces the background.png file in lookandfeel/contents/components/artwork and lookandfeel/contents/splash/images. (Also I'd be fine if the same thing were accomplished programmatically instead.) New background file: http://wstaw.org/m/2014/06/21/background.png Could someone try this out when you get a chance? I'll commit if there are no objections. ok, so this goes on login, splash and lockscreen, while the normal background is still in focus? sounds good to me btw just to be sure, this is going to be the final default background? (at some point i understood it could have been this one http://1.bp.blogspot.com/-pt8ssY4qgCQ/U3oNfW1csmI/MsA/LQvL-FvMiVQ/s1 600/loving+it.png= since the desktop default icon seems to have a variant of it ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60660 --- Ship it! Ship It! - Celeste Lyn Paul On June 20, 2014, 1:28 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/ --- (Updated June 20, 2014, 1:28 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This prevents some apps to spam lots of notifications when all it needs is actually just one single notification. Imagine you're switching songs in your playlist quickly and each song change sends new notification, but when you get to the tenth song, you still see the notification from the 3rd song (because timeouts) and you don't really care about all those songs changes still in the queue as you see it in the playlist anyway. So this patch limits certain apps to have only one single notification which is always updated. So far Clementine and Spotify is there. Switching songs or changing playback status creates only one single popup. Diffs - applets/notifications/package/contents/ui/NotificationPopup.qml d07ee32 applets/notifications/plugin/notificationshelper.cpp c5a1082 dataengines/notifications/notificationsengine.h df0d3ca dataengines/notifications/notificationsengine.cpp aaf6079 Diff: https://git.reviewboard.kde.org/r/118796/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only
On June 21, 2014, 1:13 p.m., Celeste Lyn Paul wrote: Ship It! This is great and follows one of the recommendations I made in my KDE Notifications research. - Celeste Lyn --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60660 --- On June 20, 2014, 1:28 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/ --- (Updated June 20, 2014, 1:28 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This prevents some apps to spam lots of notifications when all it needs is actually just one single notification. Imagine you're switching songs in your playlist quickly and each song change sends new notification, but when you get to the tenth song, you still see the notification from the 3rd song (because timeouts) and you don't really care about all those songs changes still in the queue as you see it in the playlist anyway. So this patch limits certain apps to have only one single notification which is always updated. So far Clementine and Spotify is there. Switching songs or changing playback status creates only one single popup. Diffs - applets/notifications/package/contents/ui/NotificationPopup.qml d07ee32 applets/notifications/plugin/notificationshelper.cpp c5a1082 dataengines/notifications/notificationsengine.h df0d3ca dataengines/notifications/notificationsengine.cpp aaf6079 Diff: https://git.reviewboard.kde.org/r/118796/diff/ Testing --- Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/#review60664 --- This review request should be marked as discarded now. Thanks :) - R.Harish Navnit On Feb. 27, 2014, 9:12 p.m., Maulik Kotadia wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- (Updated Feb. 27, 2014, 9:12 p.m.) Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116460/diff/ Testing --- I've tested the diff and its working correctly Thanks, Maulik Kotadia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60666 --- Looks good to me, just one suggestion mediaelements/mediacontroller/MediaController.qml https://git.reviewboard.kde.org/r/116874/#comment42305 runtimeData.playing || runtimeData.paused should work better, thats usually the case in other media players - Shantanu Tushar On June 19, 2014, 9:04 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 19, 2014, 9:04 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs - mediaelements/mediacontroller/MediaController.qml 2fce0a0 Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
Just for clarity I'm only proposing the blurred version for the login, splash and lockscreen. The normal, non-blurred version for actual desktop - nuno's wallpaper - is untouched and I assumed that one, or a finished version of it, would be default. Whatever ends up as the default, I'd propose a blurred version of that for the login, splash and lockscreen. I'd be totally fine if Nuno wanted to revamp it altogether, or if we pick something else as default. That screenshot I shared was just some nice wallpaper I took from deviantart. If we wanted to use that one we'd need to contact the author. I'll commit this for the login, splash and lockscreen for the time being and gen up a new one - a couple minutes of effort - if we pick a different default. Much respect, Andrew On Jun 21, 2014 3:52 AM, Jens j...@ohyran.se wrote: I am +1 about blurring the login AND as for the wallpaper: I've talked to Nuno about it and there is some Mggrmmrl going on there since he has fallen out of love with it and we still need him to send us the proper SVG's off it so we can do several different resolutions of it. If Andrews wallpaper is the new default (assuming its homemade... Andrew?) or whatever it is we should get it sorted asap since we need to use it as the background for the login and it would be nice to put this issue to rest. If Andrews image isn't homebrewed I will hound Nuno some more to get it sent to me so we can just get that bit off our collective chests /Jens (post-midsummer, insanely tired) On Saturday 21 June 2014 12.45.59 Marco Martin wrote: On Saturday 21 June 2014 00:25:35 Andrew Lake wrote: Hello all, With the sharpness of the default background image in the login, splash and lockscreen, both the foreground and background appear to be in focus - causing a slightly uncomfortable lack of depth. Things seem to look better with a defocused and slightly dimmed background - the foreground appears sharp and in-focus relative to the background and the fade-to-desktop effect with the default wallpaper has the pleasant visual side effect of appearing to bring the desktop into focus. Before I could get a screenshot my local neon install kinda flaked out. So I've provided a link to the defocused and dimmed background image. I'm hoping someone can try it out locally before I commit. It replaces the background.png file in lookandfeel/contents/components/artwork and lookandfeel/contents/splash/images. (Also I'd be fine if the same thing were accomplished programmatically instead.) New background file: http://wstaw.org/m/2014/06/21/background.png Could someone try this out when you get a chance? I'll commit if there are no objections. ok, so this goes on login, splash and lockscreen, while the normal background is still in focus? sounds good to me btw just to be sure, this is going to be the final default background? (at some point i understood it could have been this one http://1.bp.blogspot.com/-pt8ssY4qgCQ/U3oNfW1csmI/MsA/LQvL-FvMiVQ/s1 600/loving+it.png= since the desktop default icon seems to have a variant of it ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
Can't we just use QtGraphicalEffects and just blur (and/or desaturate and/or darken) whatever picture the user has chosen? The overall performance of these is great (at least on Android which is slow in any other QtQuick respect) but their instantiation takes ages, so might not be suitable for lockscreen which needs to start quickly or splash which shouldn't unnecessarily delay startup. So, umm, while writing this I figured it's not that good of an idea as I initially thought :-) Cheers, Kai Uwe Am 21.06.2014 12:45 schrieb Marco Martin notm...@gmail.com: On Saturday 21 June 2014 00:25:35 Andrew Lake wrote: Hello all, With the sharpness of the default background image in the login, splash and lockscreen, both the foreground and background appear to be in focus - causing a slightly uncomfortable lack of depth. Things seem to look better with a defocused and slightly dimmed background - the foreground appears sharp and in-focus relative to the background and the fade-to-desktop effect with the default wallpaper has the pleasant visual side effect of appearing to bring the desktop into focus. Before I could get a screenshot my local neon install kinda flaked out. So I've provided a link to the defocused and dimmed background image. I'm hoping someone can try it out locally before I commit. It replaces the background.png file in lookandfeel/contents/components/artwork and lookandfeel/contents/splash/images. (Also I'd be fine if the same thing were accomplished programmatically instead.) New background file: http://wstaw.org/m/2014/06/21/background.png Could someone try this out when you get a chance? I'll commit if there are no objections. ok, so this goes on login, splash and lockscreen, while the normal background is still in focus? sounds good to me btw just to be sure, this is going to be the final default background? (at some point i understood it could have been this one http://1.bp.blogspot.com/-pt8ssY4qgCQ/U3oNfW1csmI/MsA/LQvL-FvMiVQ/s1600/loving+it.png= since the desktop default icon seems to have a variant of it -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
On Saturday 21 June 2014, Kai Uwe Broulik wrote: Can't we just use QtGraphicalEffects and just blur (and/or desaturate and/or darken) whatever picture the user has chosen? The overall performance of these is great (at least on Android which is slow in any other QtQuick respect) but their instantiation takes ages, so might not be suitable for lockscreen which needs to start quickly or splash which shouldn't unnecessarily delay startup. I think that's something that we want to try *eventually* but so far, the status of the interaction of QtQuick and X11 drivers is so bad that I wouldn't dare attempt this for now. Maybe after few releases when everything has been debugged and hammered down enough on drivers and qt side, we can give it a try ;) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118865/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
Hi,
I have been working a bit in kubuntu's plasma packaging, when I started plasma
from a fresh new account I noticed I couldn't see most icons in the GUI's
except for a few ones.
So I checked the starkde output to try to find out what was wrong, I found a
line like this one:
static QPlatformTheme* QKdeTheme::createKdeTheme(): Unable to determine KDEHOME
Digging a bit more into the issue I also found out where this message comes
from.
File src/platformsupport/themes/genericunix/qgenericunixthemes.cpp (Qt 5.3.0)
lines 446-468:
QPlatformTheme *QKdeTheme::createKdeTheme()
{
// Check for version = 4 and determine home folder from environment,
// defaulting to ~/.kdeversion, ~/.kde
const QByteArray kdeVersionBA = qgetenv(KDE_SESSION_VERSION);
const int kdeVersion = kdeVersionBA.toInt();
if (kdeVersion 4)
return 0;
const QString kdeHomePathVar = QString::fromLocal8Bit(qgetenv(KDEHOME));
if (!kdeHomePathVar.isEmpty())
return new QKdeTheme(kdeHomePathVar, kdeVersion);
const QString kdeVersionHomePath = QDir::homePath() +
QStringLiteral(/.kde) + QLatin1String(kdeVersionBA);
if (QFileInfo(kdeVersionHomePath).isDir())
return new QKdeTheme(kdeVersionHomePath, kdeVersion);
const QString kdeHomePath = QDir::homePath() + QStringLiteral(/.kde);
if (QFileInfo(kdeHomePath).isDir())
return new QKdeTheme(kdeHomePath, kdeVersion);
qWarning(%s: Unable to determine KDEHOME, Q_FUNC_INFO);
return 0;
}
So I'm inclined to think the ~/.kde directory should be created if it doesn't
exist, thats what the patch does. What do you think?
Diffs
-
startkde/startkde.cmake ea0bdfe
Diff: https://git.reviewboard.kde.org/r/118865/diff/
Testing
---
Applied a similar patch in a customized kubuntu package. With the patch the
~/.kde directory is created and the icons can be seen.
Thanks,
José Manuel Santamaría Lema
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
Ok so then I propose we use two days or so creating a new default background unless Nuno replies today. I mean we base if off this one or something... On Saturday 21 June 2014 07.06.54 Andrew Lake wrote: Just for clarity I'm only proposing the blurred version for the login, splash and lockscreen. The normal, non-blurred version for actual desktop - nuno's wallpaper - is untouched and I assumed that one, or a finished version of it, would be default. Whatever ends up as the default, I'd propose a blurred version of that for the login, splash and lockscreen. I'd be totally fine if Nuno wanted to revamp it altogether, or if we pick something else as default. That screenshot I shared was just some nice wallpaper I took from deviantart. If we wanted to use that one we'd need to contact the author. I'll commit this for the login, splash and lockscreen for the time being and gen up a new one - a couple minutes of effort - if we pick a different default. Much respect, Andrew On Jun 21, 2014 3:52 AM, Jens j...@ohyran.se wrote: I am +1 about blurring the login AND as for the wallpaper: I've talked to Nuno about it and there is some Mggrmmrl going on there since he has fallen out of love with it and we still need him to send us the proper SVG's off it so we can do several different resolutions of it. If Andrews wallpaper is the new default (assuming its homemade... Andrew?) or whatever it is we should get it sorted asap since we need to use it as the background for the login and it would be nice to put this issue to rest. If Andrews image isn't homebrewed I will hound Nuno some more to get it sent to me so we can just get that bit off our collective chests /Jens (post-midsummer, insanely tired) On Saturday 21 June 2014 12.45.59 Marco Martin wrote: On Saturday 21 June 2014 00:25:35 Andrew Lake wrote: Hello all, With the sharpness of the default background image in the login, splash and lockscreen, both the foreground and background appear to be in focus - causing a slightly uncomfortable lack of depth. Things seem to look better with a defocused and slightly dimmed background - the foreground appears sharp and in-focus relative to the background and the fade-to-desktop effect with the default wallpaper has the pleasant visual side effect of appearing to bring the desktop into focus. Before I could get a screenshot my local neon install kinda flaked out. So I've provided a link to the defocused and dimmed background image. I'm hoping someone can try it out locally before I commit. It replaces the background.png file in lookandfeel/contents/components/artwork and lookandfeel/contents/splash/images. (Also I'd be fine if the same thing were accomplished programmatically instead.) New background file: http://wstaw.org/m/2014/06/21/background.png Could someone try this out when you get a chance? I'll commit if there are no objections. ok, so this goes on login, splash and lockscreen, while the normal background is still in focus? sounds good to me btw just to be sure, this is going to be the final default background? (at some point i understood it could have been this one http://1.bp.blogspot.com/-pt8ssY4qgCQ/U3oNfW1csmI/MsA/LQvL-FvMiVQ/ s1 600/loving+it.png= since the desktop default icon seems to have a variant of it ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-workspace_master_qt5 #515
See http://build.kde.org/job/plasma-workspace_master_qt5/515/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
On Sat, Jun 21, 2014 at 4:42 PM, Jens j...@ohyran.se wrote: Ok so then I propose we use two days or so creating a new default background unless Nuno replies today. I mean we base if off this one or something... On Saturday 21 June 2014 07.06.54 Andrew Lake wrote: Just for clarity I'm only proposing the blurred version for the login, splash and lockscreen. The normal, non-blurred version for actual desktop - nuno's wallpaper - is untouched and I assumed that one, or a finished version of it, would be default. Whatever ends up as the default, I'd propose a blurred version of that for the login, splash and lockscreen. I'd be totally fine if Nuno wanted to revamp it altogether, or if we pick something else as default. That screenshot I shared was just some nice wallpaper I took from deviantart. If we wanted to use that one we'd need to contact the author. I'll commit this for the login, splash and lockscreen for the time being and gen up a new one - a couple minutes of effort - if we pick a different default. Much respect, Andrew On Jun 21, 2014 3:52 AM, Jens j...@ohyran.se wrote: I am +1 about blurring the login AND as for the wallpaper: I've talked to Nuno about it and there is some Mggrmmrl going on there since he has fallen out of love with it and we still need him to send us the proper SVG's off it so we can do several different resolutions of it. If Andrews wallpaper is the new default (assuming its homemade... Andrew?) or whatever it is we should get it sorted asap since we need to use it as the background for the login and it would be nice to put this issue to rest. If Andrews image isn't homebrewed I will hound Nuno some more to get it sent to me so we can just get that bit off our collective chests /Jens (post-midsummer, insanely tired) On Saturday 21 June 2014 12.45.59 Marco Martin wrote: On Saturday 21 June 2014 00:25:35 Andrew Lake wrote: Hello all, With the sharpness of the default background image in the login, splash and lockscreen, both the foreground and background appear to be in focus - causing a slightly uncomfortable lack of depth. Things seem to look better with a defocused and slightly dimmed background - the foreground appears sharp and in-focus relative to the background and the fade-to-desktop effect with the default wallpaper has the pleasant visual side effect of appearing to bring the desktop into focus. Before I could get a screenshot my local neon install kinda flaked out. So I've provided a link to the defocused and dimmed background image. I'm hoping someone can try it out locally before I commit. It replaces the background.png file in lookandfeel/contents/components/artwork and lookandfeel/contents/splash/images. (Also I'd be fine if the same thing were accomplished programmatically instead.) New background file: http://wstaw.org/m/2014/06/21/background.png Could someone try this out when you get a chance? I'll commit if there are no objections. ok, so this goes on login, splash and lockscreen, while the normal background is still in focus? sounds good to me btw just to be sure, this is going to be the final default background? (at some point i understood it could have been this one http://1.bp.blogspot.com/-pt8ssY4qgCQ/U3oNfW1csmI/MsA/LQvL-FvMiVQ/ s1 600/loving+it.png= since the desktop default icon seems to have a variant of it ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel If i read this correctly: - Blurred version for login - Non blurred version when logged in That makes me think.. Would it be technically possible to just use a blur filter for the login part (it's in QML right? then you can use the QtGraphicalEffects to blur) and then decrease the blur to 0 when logging in? That would look really sweet i think :) On the other hand, this probably only works neatly when the background of the user is also used as login background... ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
On Sat, Jun 21, 2014 at 5:21 PM, Mark Gaiser mark...@gmail.com wrote: That makes me think.. Would it be technically possible to just use a blur filter for the login part (it's in QML right? then you can use the QtGraphicalEffects to blur) and then decrease the blur to 0 when logging in? That would look really sweet i think :) Quoting Marco from an hour ago: I think that's something that we want to try *eventually* but so far, the status of the interaction of QtQuick and X11 drivers is so bad that I wouldn't dare attempt this for now. Maybe after few releases when everything has been debugged and hammered down enough on drivers and qt side, we can give it a try ;) Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Background for login, splash, and lockscreen
On Sat, Jun 21, 2014 at 5:32 PM, Martin Klapetek martin.klape...@gmail.com wrote: On Sat, Jun 21, 2014 at 5:21 PM, Mark Gaiser mark...@gmail.com wrote: That makes me think.. Would it be technically possible to just use a blur filter for the login part (it's in QML right? then you can use the QtGraphicalEffects to blur) and then decrease the blur to 0 when logging in? That would look really sweet i think :) Quoting Marco from an hour ago: I think that's something that we want to try *eventually* but so far, the status of the interaction of QtQuick and X11 drivers is so bad that I wouldn't dare attempt this for now. Maybe after few releases when everything has been debugged and hammered down enough on drivers and qt side, we can give it a try ;) Cheers I completely missed that from Marco. Thank you :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
On June 21, 2014, 1:59 p.m., Shantanu Tushar wrote: mediaelements/mediacontroller/MediaController.qml, line 100 https://git.reviewboard.kde.org/r/116874/diff/9/?file=282642#file282642line100 runtimeData.playing || runtimeData.paused should work better, thats usually the case in other media players Yes, that was necessary. Thanks ! Updating the diff right away :) - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60666 --- On June 19, 2014, 9:04 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 19, 2014, 9:04 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs - mediaelements/mediacontroller/MediaController.qml 2fce0a0 Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 21, 2014, 3:55 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- added the runtimeData.paused condition also. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs (updated) - mediaelements/mediacontroller/MediaController.qml 2fce0a0 Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60669 --- Ship it! Ship It! - Shantanu Tushar On June 21, 2014, 3:55 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 21, 2014, 3:55 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs - mediaelements/mediacontroller/MediaController.qml 2fce0a0 Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60670 --- This review has been submitted with commit fec9938bcef6dd884720008d9577aea18c82cf99 by Shantanu Tushar on behalf of R. Harish Navnit to branch master. - Commit Hook On June 21, 2014, 3:55 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 21, 2014, 3:55 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs - mediaelements/mediacontroller/MediaController.qml 2fce0a0 Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 21, 2014, 3:58 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs - mediaelements/mediacontroller/MediaController.qml 2fce0a0 Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60674 --- This review has been submitted with commit 97e717aae08e03fa4fa7ada024b0f6dfa019c6d4 by Shantanu Tushar on behalf of R. Harish Navnit to branch vsrao-seriesbackend. - Commit Hook On June 21, 2014, 3:58 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 21, 2014, 3:58 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs - mediaelements/mediacontroller/MediaController.qml 2fce0a0 Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118866: Start playing after Play All is used
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ --- Review request for Plasma. Repository: plasma-mediacenter Description --- We should ask the model to start playing once we add all the songs to the playlist as a result of the user using Play All. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 68eecf3 Diff: https://git.reviewboard.kde.org/r/118866/diff/ Testing --- Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118866: Start playing after Play All is used
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ --- (Updated June 21, 2014, 5:43 p.m.) Review request for Plasma. Changes --- switch to and clear the default playlist only Repository: plasma-mediacenter Description --- We should ask the model to start playing once we add all the songs to the playlist as a result of the user using Play All. Diffs (updated) - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 68eecf3 libs/mediacenter/multipleplaylistmodel.h 1c7731b libs/mediacenter/multipleplaylistmodel.cpp 4b475c7 libs/mediacenter/playlistmodel.h 50157ff libs/mediacenter/playlistmodel.cpp 44abbc1 Diff: https://git.reviewboard.kde.org/r/118866/diff/ Testing --- Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
