Re: Review Request 122339: Add KWorkSpace::isShuttingDown()

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122339/#review75755
---

Ship it!


I'm not 100 % happy with the blocking dbus call, but I don't see another way.

- Martin Gräßlin


On Feb. 9, 2015, 8:10 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122339/
> ---
> 
> (Updated Feb. 9, 2015, 8:10 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 189456
> https://bugs.kde.org/show_bug.cgi?id=189456
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Since KSMServer does the session teardown, we can't just rely on Logind's 
> PreparingForShutdown property.
> 
> This patch will allow for instance PowerDevil to not suspend the session when 
> it's currently shutting down, otherwise you'll have your system suspend and 
> continue shutting down after resuming.
> 
> 
> Diffs
> -
> 
>   ksmserver/org.kde.KSMServerInterface.xml 9dad130 
>   ksmserver/server.h 20b5faa 
>   libkworkspace/kworkspace.h 816f8f1 
>   libkworkspace/kworkspace.cpp ac979bd 
> 
> Diff: https://git.reviewboard.kde.org/r/122339/diff/
> 
> 
> Testing
> ---
> 
> Works, adjusted PowerDevil and the system did not suspend during shutdown.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122392: Fix Klipper Performance issues

[Martin Gräßlin]

> On Feb. 3, 2015, 8:23 a.m., Martin Gräßlin wrote:
> > could you please split the review in a per-commit review? I find it hard to 
> > review as there are so many changes to different areas. Especially I think 
> > there are a few no-brainer which could go in quickly, while the threaded 
> > filtering is the part which needs most thought, so having that in a 
> > dedicated review would certainly help :-)
> 
> Filip Wieladek wrote:
> Yes, I can do that once I get home. If you really believe that the popup 
> is going away anyway, then I would however prefer to work on the new way, so 
> that the "legacy" way can be removed.
> 
> Martin Gräßlin wrote:
> we probably cannot completely remove the legacy way as we still want to 
> support the dedicated klipper mode without plasmoid. So improvements on that 
> are still fine.
> 
> Filip Wieladek wrote:
> I looked at splitting the change, but what hit me is that none of the 
> changes I have make much of a difference unless I have background filtering. 
> Unless background filtering is enabled, the UI still remains to be very 
> sluggish. I have attached a screencast with the current version vs the 
> version with my changes.
> 
> Note, that the UI is sluggish when there are a lot of entries (e.g. 2048) 
> which are also long. This happens quite frequently in my workflow where I 
> copy the contents of whole files
> 
> Filip Wieladek wrote:
> Hello Martin,
> 
> What do you think would be the best way to go forward with this review? I 
> really think that background processing of the filter makes sense as it makes 
> things a lot more responsive. Do you want another patch off the current git 
> commit? Could you check out the code and play with it? You would see that the 
> user experience is much better when dealing with large input sets.
> 
> I would also like to continue contributing to klipper, so I would like to 
> get this out of the way ;)

sorry for the delay - I have Internet connectivity problems at the moment. I'll 
look into the review as soon as my Internet works properly again.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122392/#review75260
---


On Feb. 8, 2015, 6:08 p.m., Filip Wieladek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122392/
> ---
> 
> (Updated Feb. 8, 2015, 6:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This patch fixes multiple klipper issues:
> 
> * Moves filtering logic into a background task. This makes Klipper responsive 
> while the clipboard is being filtered.
>   Previously, Klipper would "hang" while it was filtering the results. This 
> was worse when there were no matches as
>   Klipper had to go through the entire history. THe computation is immediate 
> on small history sets, but significant
>   on larger sets with larger strings in the clipboard
> * Provides a progress bar at the top to indicate the filtering process.
> * Simplifies the code significantly, by:
>* Moving filtering in a separate class file
>* Cleaning up Popup proxy to build the menu directly using a QList
>* Removing the "index" magic in KlipperPopup. Now we maintain a list of 
> history actions which can be easily cleared.
>* Removed explicit deletion of the "more" submenus, as these are owned by 
> the parent menus and should be removed
>  automatically
> * Avoids flickering of Klipper while removing and inserting actions by 
> forcing the height and width during the update.
> * Fixes a potential memory leak. The QActions for the KlipperPopup were only 
> removed, but never deleted. The API used
>   to add actions addAction(QAction*) was not taking ownership of the action. 
> This is fixed by deleting the actions
>   manually when clearing.
> * Fixes a performance issue during menu rendering when truncating large 
> strings. The method call elidedText() can be
>   slow on large pieces of text. This is worked around by creating a much 
> smaller string of the prefix and suffix of the
>   string. We use the average character width to compute the approximate 
> amount of characters which can be displayed
>   and use twice as much. (this is because in corner cases, such as  we 
> might end up with a string which is not
>   long enough).
>   
> This also fixes the bug https://bugs.kde.org/show_bug.cgi?id=238084
> 
> 
> Diffs
> -
> 
>   klipper/popupproxy.h f33f62c117a08ddbe6b761da4c2e28e51b985044 
>   klipper/popupproxy.cpp 12dd3dd637d0ff9d134fb71237d6f0d3bcc5bd77 
>   klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02 
>   klipper/filterresult.h PRE-C

Re: Merging new PMC design into master

[R.Harish Navnit]

On Tue, Feb 10, 2015 at 11:10 AM, Bhushan Shah  wrote:

> Hello!
>
> So, PMC team have developed whole new user interface based upon
> feedback from VDG [1] it is being developed in bshah/pmc2 branch of
> plasma-mediacenter repo.
>
> I am going to merge this branch to master (which is already KF5 based)
> today, this will allow users and VDG people to try out new user
> interface without any hassle, so if you have any objections please
> say.
>

Awesome ! Can't wait :)

Regards.
R.Harish Navnit
The Enigma 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122500: Don't delete widgets we don't own when changing styles

[Hugo Pereira Da Costa]

> On Feb. 9, 2015, 5:34 p.m., Hugo Pereira Da Costa wrote:
> > Although I have no objection against the change, I must admit I don't 
> > understand what's wrong with the current code, nor the actual description 
> > of the patch. 
> > "registerWidget may take an existing widget as a parameter. If so, we
> > don't want to delete it"
> > if I understand my own code right, _widget is not the argument passed as 
> > the registerWidget method. It is an internal member, created parentless, at 
> > first accepted call to registerWidget. So as such it is not 'explicitly' 
> > owned by anyone, and implicitly owned by us. 
> > And then, what is wrong with deleting it in our destructor ? 
> > is it because, though parentless it might get deleted elsewhere ? 
> > or because of a thread issue ? 
> > What do I miss ? 
> > (PS: the reason behind this interal _widget member, is that you can not 
> > track palettechanged events on a widget, via event filter, once you set it 
> > your own 'altered' palette: it won't recive these events anymore. 
> > So: eventFilter must be installed on either qApp (which is then getting the 
> > event for _every_ widget, for which we did not alter the palette, which is 
> > quite a lot), or on a widget for which we are sure the pallette is not 
> > altered. Hence: our own).
> 
> David Edmundson wrote:
> oh, you're absolutely right...
> 
> I just had my valgrind traces and in my haste didn't see the difference 
> between _widget and widget.
> 
> 
> The crash was in QApplication trying to update the palette on _widget 
> after you change styles in the style KCM.
> https://paste.kde.org/pvhhfielh
> 
> According to valgrind, the widget it was trying to update was very much 
> the one deleted in the PaletteHelper destructor.
> 
> I'll try replacing just delete _widget with _widget->deleteLater() and 
> see if that crash still happens; it might be the more relevant part of the 
> fix. It's generally a bad idea to directly delete a QObject in anything that 
> might be called from a slot.
> 
> 
> Thanks.

Clear enough. I agree with the delete -> deleteLater change. Keep me posted !  
Does the crash you report above happen every time ? (and is there a bug report 
?), At least here i could not reproduce so far.


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122500/#review75715
---


On Feb. 9, 2015, 2:33 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122500/
> ---
> 
> (Updated Feb. 9, 2015, 2:33 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Don't delete widgets we don't own when changing styles
> 
> registerWidget may take an existing widget as a parameter. If so, we
> don't want to delete it when our paletteHelper is deleted for example if
> we change style.
> 
> 
> Diffs
> -
> 
>   kstyle/breezepalettehelper.cpp 31c32c3 
> 
> Diff: https://git.reviewboard.kde.org/r/122500/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Merging new PMC design into master

[Sinny Kumari]

On Tue, Feb 10, 2015 at 11:10 AM, Bhushan Shah  wrote:

> I am going to merge this branch to master (which is already KF5 based)
> today, this will allow users and VDG people to try out new user
> interface without any hassle, so if you have any objections please
> say.


+1 Good to merge it to master now
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Merging new PMC design into master

[Bhushan Shah]

Hello!

So, PMC team have developed whole new user interface based upon
feedback from VDG [1] it is being developed in bshah/pmc2 branch of
plasma-mediacenter repo.

I am going to merge this branch to master (which is already KF5 based)
today, this will allow users and VDG people to try out new user
interface without any hassle, so if you have any objections please
say.

Thanks!

PS: I want to have it packaged for kubuntu-ci unstable repo too..

[1] https://forum.kde.org/viewtopic.php?f=285&t=121705

--
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122506: Fix crash due to unsafe access to ShellCorona::m_screenConfiguration

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122506/#review75748
---



shell/shellcorona.cpp


This should never happen with your change, no?

Anyway, a backtrace to the case where it shows why it's a problem would be 
appreciated (or a pointer to a bug report).


- Aleix Pol Gonzalez


On Feb. 10, 2015, 12:16 a.m., Sandro Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122506/
> ---
> 
> (Updated Feb. 10, 2015, 12:16 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Fix crash due to unsafe access to ShellCorona::m_screenConfiguration
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp cf489b9f8f1abce864bcb3375d3be01bc2c3430d 
> 
> Diff: https://git.reviewboard.kde.org/r/122506/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sandro Mani
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122506: Fix crash due to unsafe access to ShellCorona::m_screenConfiguration

[Sandro Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122506/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Fix crash due to unsafe access to ShellCorona::m_screenConfiguration


Diffs
-

  shell/shellcorona.cpp cf489b9f8f1abce864bcb3375d3be01bc2c3430d 

Diff: https://git.reviewboard.kde.org/r/122506/diff/


Testing
---


Thanks,

Sandro Mani

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

[Armin K.]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121084/
---

(Updated Feb. 9, 2015, 10:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Runtime, KDE Frameworks and Plasma.


Repository: kio-extras


Description
---

KDE-Runtime already provides libmolletnetwork, so lets rename
this one to include 5 as a suffix since many apps outside of
KDE still depend on KDE-Runtime.


Diffs
-

  network/ioslave/CMakeLists.txt 06a964d 
  network/kded/CMakeLists.txt 3be676e 
  network/network/CMakeLists.txt c0fb43e 

Diff: https://git.reviewboard.kde.org/r/121084/diff/


Testing
---


Thanks,

Armin K.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=343962

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #11 from Kai Uwe Broulik  ---
The threads complaining about the OSD you have linked do not apply to the
Plasma 5 world. In Plasma 4.x the OSD would show up whenever the brightness
changed, for whatever reason, such as the system automatically dimming it. In
Plasma 5, however, the OSD only ever shows up when the user manually changed
the brightness. The former being the biggest annoyance which has been one of
the main goals in the 5.x OSD design. The other one, "lightum", is using DBus
interfaces that I do not intend to be used directly by third parties.
If, and only if, such an option is to become upstream, it has to be consistent
across all the components using it (volume controls, keyboard controls, etc)
and configurable in a central place, not every single one having an option to
turn it off.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[hipersayan_x]

https://bugs.kde.org/show_bug.cgi?id=343962

--- Comment #10 from hipersayan_x  ---
> It brings additional maintenance cost, it brings additional testing costs,
> it brings higher chance of things getting broken, leading to more bug
> reports etc etc.
Ok, then stop making programs just because you are afraid of computer crashing
in anytime. Seriously, this is just a flag to disable an unwanted feature,
there is no way it can crash nothing.

> It's not always "I need this feature, why not give it to me"; the
> maintainer/developer has a certain vision about the things he's creating and
> sometimes he just has to say no. 
I'm not the only person asking for this option, this come from long time ago:

https://forum.kde.org/viewtopic.php?f=67&t=102145
http://askubuntu.com/questions/293105/how-to-disable-kdes-brightness-osd

> And you should respect their opinion. It's
> impossible to always please everyone. That's just the way it is.
Of course I respect your opinions, what I don't respect is you design decision
on this very specific topic. And I believe that the way in which the the OSD is
designed is really bad.

> In my personal opinion, I would probably also reject that, I wouldn't want 3
> billion options to allow every single combination of options...
Ok, then remove systemsetting and all it's components, it will made KDE easy to
maintain it isn't? So you are basically arguing against one of the pillar of
KDE, and the the reason why most people chooses it. I'm very disappointed.

These are my final words, I don't want to make this thread a flame, I just want
to have my changes integrated to Powerdevil.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122505: Warn about brightness getting too low

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122505/
---

Review request for Plasma and KDE Usability.


Repository: plasma-workspace


Description
---

Some graphics drivers, notably Intel, turn off the backlight completely when 
brightness reached zero, which is also in the spec (0 = off, 1 = very dim) but 
imho that's unexpected. To prevent the user from accidentally turnign the 
screen off, especially when keyboard brightness controls don't work, which 
sadly still happens quite often, the slider breaks free from the user's drag 
(by becoming disable for two (perhaps 1 is enough?) seconds, so we also catch 
the mouse wheel case) and displays a warning (which stays there until screen 
brightness is dialed up again).


Diffs
-

  applets/batterymonitor/package/contents/ui/BrightnessItem.qml 546ab58 
  applets/batterymonitor/package/contents/ui/PopupDialog.qml a2acf31 

Diff: https://git.reviewboard.kde.org/r/122505/diff/


Testing
---

Works pretty well, I just realized I forgot the mousewheel-on-trayicon case. 
Also, I'm open to wording suggestions since it sounds more like "we suck, sorry 
about that". (Note in the screenshot I used the mouse wheel, hence the 
displayed 4% rather than 5)


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/8b585088-e33e-4862-9c46-207d06f566f1__dimwarning.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122473: Treat normal selected timezone as local if it matches the local

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122473/
---

(Updated Feb. 9, 2015, 9:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 343908
https://bugs.kde.org/show_bug.cgi?id=343908


Repository: plasma-workspace


Description
---

The real timezone that Local links to is also in the list of timezones for 
which teh time can be displayed. For whatever reason, it can happen that the 
real timezone is selected and not 'Local' and then it's not treated as local 
anymore, making the "Show local timezone" setting not work.

This fixes it.


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 0389f2a 

Diff: https://git.reviewboard.kde.org/r/122473/diff/


Testing
---

Selected Europe/Prague and deselected Local, "Show local timezone" setting 
still works.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122500: Don't delete widgets we don't own when changing styles

[David Edmundson]

> On Feb. 9, 2015, 5:34 p.m., Hugo Pereira Da Costa wrote:
> > Although I have no objection against the change, I must admit I don't 
> > understand what's wrong with the current code, nor the actual description 
> > of the patch. 
> > "registerWidget may take an existing widget as a parameter. If so, we
> > don't want to delete it"
> > if I understand my own code right, _widget is not the argument passed as 
> > the registerWidget method. It is an internal member, created parentless, at 
> > first accepted call to registerWidget. So as such it is not 'explicitly' 
> > owned by anyone, and implicitly owned by us. 
> > And then, what is wrong with deleting it in our destructor ? 
> > is it because, though parentless it might get deleted elsewhere ? 
> > or because of a thread issue ? 
> > What do I miss ? 
> > (PS: the reason behind this interal _widget member, is that you can not 
> > track palettechanged events on a widget, via event filter, once you set it 
> > your own 'altered' palette: it won't recive these events anymore. 
> > So: eventFilter must be installed on either qApp (which is then getting the 
> > event for _every_ widget, for which we did not alter the palette, which is 
> > quite a lot), or on a widget for which we are sure the pallette is not 
> > altered. Hence: our own).

oh, you're absolutely right...

I just had my valgrind traces and in my haste didn't see the difference between 
_widget and widget.


The crash was in QApplication trying to update the palette on _widget after you 
change styles in the style KCM.
https://paste.kde.org/pvhhfielh

According to valgrind, the widget it was trying to update was very much the one 
deleted in the PaletteHelper destructor.

I'll try replacing just delete _widget with _widget->deleteLater() and see if 
that crash still happens; it might be the more relevant part of the fix. It's 
generally a bad idea to directly delete a QObject in anything that might be 
called from a slot.


Thanks.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122500/#review75715
---


On Feb. 9, 2015, 2:33 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122500/
> ---
> 
> (Updated Feb. 9, 2015, 2:33 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Don't delete widgets we don't own when changing styles
> 
> registerWidget may take an existing widget as a parameter. If so, we
> don't want to delete it when our paletteHelper is deleted for example if
> we change style.
> 
> 
> Diffs
> -
> 
>   kstyle/breezepalettehelper.cpp 31c32c3 
> 
> Diff: https://git.reviewboard.kde.org/r/122500/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=343962

--- Comment #9 from Martin Klapetek  ---
> This patch adds just a few lines of code, without affecting in a negative way 
> to KDE, so why not including it?

It brings additional maintenance cost, it brings additional testing costs, it
brings higher chance of things getting broken, leading to more bug reports etc
etc.

It's not always "I need this feature, why not give it to me"; the
maintainer/developer has a certain vision about the things he's creating and
sometimes he just has to say no. And you should respect their opinion. It's
impossible to always please everyone. That's just the way it is.

In my personal opinion, I would probably also reject that, I wouldn't want 3
billion options to allow every single combination of options...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[hipersayan_x]

https://bugs.kde.org/show_bug.cgi?id=343962

hipersayan_x  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WONTFIX |---

--- Comment #8 from hipersayan_x  ---
>Why would you want power management while you watch a movie in the first place?
I need to control the light intensity while watching a movie, for not burning
(at all) my eyes. 
I don't want to disable power management, I just want to disable that specific
OSD. This patch just maintains the normal/current behaivor, by default, but
make it optional for people that don't want it. 
This patch adds just a few lines of code, without affecting in a negative way
to KDE, so why not including it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[Antonis G .]

https://bugs.kde.org/show_bug.cgi?id=343962

Antonis G.  changed:

   What|Removed |Added

 CC||gaanto...@civil.auth.gr

--- Comment #7 from Antonis G.  ---
This request makes no sense at all. Why would you want power management while
you watch a movie in the first place?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Get panel list and hidding them via C++ module

[Evgeniy Alekseev]

Hi Sebastian,

On Monday 09 February 2015 13:59:21 Sebastian Kügler wrote:
> Not possible, the QtQuick code's access to the C++ bits (Applet, Containment
> is now very limited by design).
> No, the separation between model (Plasma::Applet, Plasma::Containment, etc.)
> and the views (implemented in QtQuick) is deeper in Plasma 5, that's partly
> a conscious design decision, and partly mandated by moving everything to
> QtQuick.

Ok, thank you.

> That's not possible in Plasma 5, and it's a conscious design decision.
> Applets are not supposed to meddle with other applets, they're
> self-contained outbound, and managed by the surrounding containment.

I've expected something like this, thanks for explanation.

> Let's take a step back, though. What do you actually want to achieve? Maybe
> there is a way to make that possible within the design of Plasma.
> 
> Have you looked at desktop scripting to achieve what you are looking for?

There is an applet on which I'm working now (rather, on porting) which 
provides some concepts from minimalistic WMs (predominantly tiling ones) which 
besides the basic functions (simply control by desktops) was able to hide 
selected panels by hotkey pressing. I.e. atm this action should look like such 
applet [1].

As long as I don't bond to any prefered realization, it may be implemented by 
any reasonable way, e.g. Dbus calls, library functions (but calling external 
application/script is an undesirable way of course).

1. http://kde-look.org/content/show.php/Panel+Toggle?content=149654
-- 
Sincerely yours, 
Evgeniy Alekseev

e-mail: darkarca...@mail.ru
ICQ: 407-398-235
Jabber: arca...@jabber.ru

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122339: Add KWorkSpace::isShuttingDown()

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122339/
---

(Updated Feb. 9, 2015, 7:10 nachm.)


Review request for Plasma and Martin Gräßlin.


Changes
---

Remove X11 ifdef, we should perhaps guard against the availability of QtDBus, 
not that Plasma or any other workspace part would build without it though.


Bugs: 189456
https://bugs.kde.org/show_bug.cgi?id=189456


Repository: plasma-workspace


Description
---

Since KSMServer does the session teardown, we can't just rely on Logind's 
PreparingForShutdown property.

This patch will allow for instance PowerDevil to not suspend the session when 
it's currently shutting down, otherwise you'll have your system suspend and 
continue shutting down after resuming.


Diffs (updated)
-

  ksmserver/org.kde.KSMServerInterface.xml 9dad130 
  ksmserver/server.h 20b5faa 
  libkworkspace/kworkspace.h 816f8f1 
  libkworkspace/kworkspace.cpp ac979bd 

Diff: https://git.reviewboard.kde.org/r/122339/diff/


Testing
---

Works, adjusted PowerDevil and the system did not suspend during shutdown.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[hipersayan_x]

https://bugs.kde.org/show_bug.cgi?id=343962

--- Comment #6 from hipersayan_x  ---
Created attachment 90995
  --> https://bugs.kde.org/attachment.cgi?id=90995&action=edit
kcmshell5 powerdevilglobalconfig with the option added

This is how the patch looks like.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[hipersayan_x]

https://bugs.kde.org/show_bug.cgi?id=343962

hipersayan_x  changed:

   What|Removed |Added

 CC||hipersaya...@gmail.com

--- Comment #5 from hipersayan_x  ---
Created attachment 90994
  --> https://bugs.kde.org/attachment.cgi?id=90994&action=edit
Patch to enable/disable OSD in git master branch

This patch adds an option to enable or disable the OSD in **kcmshell5
powerdevilglobalconfig**, OSD is enabled by default.
This patch is for the git master repository.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122392: Fix Klipper Performance issues

[Filip Wieladek]

> On Feb. 3, 2015, 7:23 a.m., Martin Gräßlin wrote:
> > could you please split the review in a per-commit review? I find it hard to 
> > review as there are so many changes to different areas. Especially I think 
> > there are a few no-brainer which could go in quickly, while the threaded 
> > filtering is the part which needs most thought, so having that in a 
> > dedicated review would certainly help :-)
> 
> Filip Wieladek wrote:
> Yes, I can do that once I get home. If you really believe that the popup 
> is going away anyway, then I would however prefer to work on the new way, so 
> that the "legacy" way can be removed.
> 
> Martin Gräßlin wrote:
> we probably cannot completely remove the legacy way as we still want to 
> support the dedicated klipper mode without plasmoid. So improvements on that 
> are still fine.
> 
> Filip Wieladek wrote:
> I looked at splitting the change, but what hit me is that none of the 
> changes I have make much of a difference unless I have background filtering. 
> Unless background filtering is enabled, the UI still remains to be very 
> sluggish. I have attached a screencast with the current version vs the 
> version with my changes.
> 
> Note, that the UI is sluggish when there are a lot of entries (e.g. 2048) 
> which are also long. This happens quite frequently in my workflow where I 
> copy the contents of whole files

Hello Martin,

What do you think would be the best way to go forward with this review? I 
really think that background processing of the filter makes sense as it makes 
things a lot more responsive. Do you want another patch off the current git 
commit? Could you check out the code and play with it? You would see that the 
user experience is much better when dealing with large input sets.

I would also like to continue contributing to klipper, so I would like to get 
this out of the way ;)


- Filip


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122392/#review75260
---


On Feb. 8, 2015, 5:08 p.m., Filip Wieladek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122392/
> ---
> 
> (Updated Feb. 8, 2015, 5:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This patch fixes multiple klipper issues:
> 
> * Moves filtering logic into a background task. This makes Klipper responsive 
> while the clipboard is being filtered.
>   Previously, Klipper would "hang" while it was filtering the results. This 
> was worse when there were no matches as
>   Klipper had to go through the entire history. THe computation is immediate 
> on small history sets, but significant
>   on larger sets with larger strings in the clipboard
> * Provides a progress bar at the top to indicate the filtering process.
> * Simplifies the code significantly, by:
>* Moving filtering in a separate class file
>* Cleaning up Popup proxy to build the menu directly using a QList
>* Removing the "index" magic in KlipperPopup. Now we maintain a list of 
> history actions which can be easily cleared.
>* Removed explicit deletion of the "more" submenus, as these are owned by 
> the parent menus and should be removed
>  automatically
> * Avoids flickering of Klipper while removing and inserting actions by 
> forcing the height and width during the update.
> * Fixes a potential memory leak. The QActions for the KlipperPopup were only 
> removed, but never deleted. The API used
>   to add actions addAction(QAction*) was not taking ownership of the action. 
> This is fixed by deleting the actions
>   manually when clearing.
> * Fixes a performance issue during menu rendering when truncating large 
> strings. The method call elidedText() can be
>   slow on large pieces of text. This is worked around by creating a much 
> smaller string of the prefix and suffix of the
>   string. We use the average character width to compute the approximate 
> amount of characters which can be displayed
>   and use twice as much. (this is because in corner cases, such as  we 
> might end up with a string which is not
>   long enough).
>   
> This also fixes the bug https://bugs.kde.org/show_bug.cgi?id=238084
> 
> 
> Diffs
> -
> 
>   klipper/popupproxy.h f33f62c117a08ddbe6b761da4c2e28e51b985044 
>   klipper/popupproxy.cpp 12dd3dd637d0ff9d134fb71237d6f0d3bcc5bd77 
>   klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02 
>   klipper/filterresult.h PRE-CREATION 
>   klipper/filterresult.cpp PRE-CREATION 
>   klipper/history.h 1bfd0424714ff79d93206a74cb7e4214a6c8c652 
>   klipper/history.cpp 9640c23b0cf06dd0135ca573aea0819e2788b852 
>   klipper/historyfilter.h PRE-C

Re: Review Request 122371: Disable session management for kwrited

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122371/
---

(Updated Feb. 9, 2015, 5:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 343550
https://bugs.kde.org/show_bug.cgi?id=343550


Repository: kwrited


Description
---

kwrited has its autostart file IMHO doesn't need session management.


Diffs
-

  kwrited.cpp a4dac6b 

Diff: https://git.reviewboard.kde.org/r/122371/diff/


Testing
---

no kwrited started by session.


Thanks,

Xuetian Weng

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[kwrited] [Bug 343550] duplicated kwrited instances increasing with each system boot

[Weng Xuetian]

https://bugs.kde.org/show_bug.cgi?id=343550

Weng Xuetian  changed:

   What|Removed |Added

   Version Fixed In||5.2.1
  Latest Commit||http://commits.kde.org/kwri
   ||ted/863c648f88f6f69fa26ca72
   ||43c1b32b2efc57210
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Weng Xuetian  ---
Git commit 863c648f88f6f69fa26ca7243c1b32b2efc57210 by Weng Xuetian.
Committed on 09/02/2015 at 17:49.
Pushed by xuetianweng into branch 'Plasma/5.2'.

Disable session management for kwrited
REVIEW: 122371
FIXED-IN: 5.2.1

M  +9-1kwrited.cpp

http://commits.kde.org/kwrited/863c648f88f6f69fa26ca7243c1b32b2efc57210

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122500: Don't delete widgets we don't own when changing styles

[Hugo Pereira Da Costa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122500/#review75715
---


Although I have no objection against the change, I must admit I don't 
understand what's wrong with the current code, nor the actual description of 
the patch. 
"registerWidget may take an existing widget as a parameter. If so, we
don't want to delete it"
if I understand my own code right, _widget is not the argument passed as the 
registerWidget method. It is an internal member, created parentless, at first 
accepted call to registerWidget. So as such it is not 'explicitly' owned by 
anyone, and implicitly owned by us. 
And then, what is wrong with deleting it in our destructor ? 
is it because, though parentless it might get deleted elsewhere ? 
or because of a thread issue ? 
What do I miss ? 
(PS: the reason behind this interal _widget member, is that you can not track 
palettechanged events on a widget, via event filter, once you set it your own 
'altered' palette: it won't recive these events anymore. 
So: eventFilter must be installed on either qApp (which is then getting the 
event for _every_ widget, for which we did not alter the palette, which is 
quite a lot), or on a widget for which we are sure the pallette is not altered. 
Hence: our own).


kstyle/breezepalettehelper.cpp


Shouldn't this be "as this isn't a QWidget"
(since 'this' actually is a qobject)


- Hugo Pereira Da Costa


On Feb. 9, 2015, 2:33 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122500/
> ---
> 
> (Updated Feb. 9, 2015, 2:33 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Don't delete widgets we don't own when changing styles
> 
> registerWidget may take an existing widget as a parameter. If so, we
> don't want to delete it when our paletteHelper is deleted for example if
> we change style.
> 
> 
> Diffs
> -
> 
>   kstyle/breezepalettehelper.cpp 31c32c3 
> 
> Diff: https://git.reviewboard.kde.org/r/122500/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122502/#review75710
---


a bit on the fence about it, hmm..
I assume it would just not list them in krunner, but plasma-windowed would 
still load them from commandline
Anyways, I would call it X-Plasma-StandAloneApp or a formulation like that, 
then it mirrors nicely the similar current entry X-Plasma-NotificationArea used 
for the ones that go in the systray

- Marco Martin


On Feb. 9, 2015, 4:22 p.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122502/
> ---
> 
> (Updated Feb. 9, 2015, 4:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
>   We can use this option to figure out which applets should be exposed as
>   windows. It doesn't make sense to do that for all of them.
> 
> 
> Diffs
> -
> 
>   src/plasma/data/servicetypes/plasma-applet.desktop ff48afa 
> 
> Diff: https://git.reviewboard.kde.org/r/122502/diff/
> 
> 
> Testing
> ---
> 
> Tried by using this option to filter them in the windowed widgets runner.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122502/#review75709
---


+1 to the idea


src/plasma/data/servicetypes/plasma-applet.desktop


everything else is in the form X-Plasma-CamelCasedName


- David Edmundson


On Feb. 9, 2015, 4:22 p.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122502/
> ---
> 
> (Updated Feb. 9, 2015, 4:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
>   We can use this option to figure out which applets should be exposed as
>   windows. It doesn't make sense to do that for all of them.
> 
> 
> Diffs
> -
> 
>   src/plasma/data/servicetypes/plasma-applet.desktop ff48afa 
> 
> Diff: https://git.reviewboard.kde.org/r/122502/diff/
> 
> 
> Testing
> ---
> 
> Tried by using this option to filter them in the windowed widgets runner.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

[David Edmundson]

> On Feb. 9, 2015, 7:47 a.m., Martin Gräßlin wrote:
> > kcms/dateandtime/main.cpp, line 143
> > 
> >
> > why wait? If I understand correctly the next dbus calls do not depend 
> > on the outcome of the first one. So you could just fire all of them and 
> > only check in the end whether they failed.
> 
> David Edmundson wrote:
> Yeah, that's sensible.
> I want the method to block because otherwise having that and the old 
> kauth approach end up differing wildly; but only blocking once will be more 
> sensible.
> 
> It gives me a reason for removing the legacy system later :)

Whoa! Turns out, no, I can't change this.

If I do

pendingSetNtpReply = iface.setNTP(false);
pendingSetTimeReply = iface.setTime(time);

pendingSetNtpReply.waitForFinished();
pendingSetTimeReply.waitForFinished();

I get an error back from timedated
"org.freedesktop.timedate1.AutomaticTimeSyncEnabled" "Automatic time 
synchronization is enabled"

Which means timedated must be handling each new DBus requests in a new thread 
something you really can't do in Qt.
Somewhere between fascinating and mental.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122400/#review75660
---


On Feb. 8, 2015, 5:18 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122400/
> ---
> 
> (Updated Feb. 8, 2015, 5:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The current time setting helper is incredibly broken.
> 
> It manually tries to run a range of NTP utilities, all of which are
> deprecated.
> 
> We can just call timedated directly and cut out the middleman as it has
> uses polkit anyway.
> 
> This is currently an optional dependency, and the original helper still
> exists. It makes the code messy, but we have users to support for now.
> 
> Finding timedated is an cmake option rather than querying for systemd
> libs to make it easier for those deploying shims, such as BSD.
> 
> 
> (code is in two commits, first abstracting the saving from the dtime class; 
> then adding in the second save mechanism) 
> 
> 
> Diffs
> -
> 
>   kcms/dateandtime/timedated1.xml PRE-CREATION 
>   kcms/dateandtime/main.h c1e5234 
>   kcms/dateandtime/main.cpp 0041a9d 
>   kcms/dateandtime/dtime.h 1a90698 
>   kcms/dateandtime/dtime.cpp 482e483 
>   kcms/dateandtime/CMakeLists.txt 4a987ae 
>   kcms/dateandtime/dateandtime.ui c073b5e 
> 
> Diff: https://git.reviewboard.kde.org/r/122400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122502/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

  We can use this option to figure out which applets should be exposed as
  windows. It doesn't make sense to do that for all of them.


Diffs
-

  src/plasma/data/servicetypes/plasma-applet.desktop ff48afa 

Diff: https://git.reviewboard.kde.org/r/122502/diff/


Testing
---

Tried by using this option to filter them in the windowed widgets runner.


Thanks,

Vishesh Handa

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122502/#review75706
---


+1, I assume this defaults to false

- Bhushan Shah


On Feb. 9, 2015, 9:52 p.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122502/
> ---
> 
> (Updated Feb. 9, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
>   We can use this option to figure out which applets should be exposed as
>   windows. It doesn't make sense to do that for all of them.
> 
> 
> Diffs
> -
> 
>   src/plasma/data/servicetypes/plasma-applet.desktop ff48afa 
> 
> Diff: https://git.reviewboard.kde.org/r/122502/diff/
> 
> 
> Testing
> ---
> 
> Tried by using this option to filter them in the windowed widgets runner.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122382: [klipper] Sync history to disk after each change

[Filip Wieladek]

> On Feb. 3, 2015, 7:36 a.m., Martin Gräßlin wrote:
> > David E. just pointed out that this could become quite heavy for the system 
> > as the history size can be large (up to 2048 items).
> 
> Martin Gräßlin wrote:
> Unfortunately I couldn't find out why we support up to 2048 items. Commit 
> message is just:
> 
> commit da8394ce42a24726392265436c3808f1ac9389aa
> Author: Esben Mose Hansen 
> Date:   Fri Nov 19 22:28:55 2004 +
> 
> Introduced support for large clipboard histories up to 2048 items.
> 
> svn path=/trunk/kdebase/klipper/; revision=364353
> 
> Martin Klapetek wrote:
> I think 2048 is insane. Can we make it like 32 by default and have it 
> configurable with big fat warning when you choose more than say 100? 
> 
> Btw. does klipper store things encrypted or something? There's also a 
> security concern, especially if your klipper contains passwords, that saving 
> those to disk unecrypted after each copy is insecure (all you need is a 
> watcher on the history file).
> 
> Martin Gräßlin wrote:
> > I think 2048 is insane. Can we make it like 32 by default and have it 
> configurable with big fat warning when you choose more than say 100? 
> 
> The default is 7. Adding a warning is certainly possible.
> 
> > Btw. does klipper store things encrypted or something? There's also a 
> security concern, especially if your klipper contains passwords, that saving 
> those to disk unecrypted after each copy is insecure (all you need is a 
> watcher on the history file).
> 
> If you are able to watch the file you are also able to connect to the X11 
> Display and just do a passive keyboard grab. So caring about that probably 
> doesn't matter (on Wayland this might get more important - maybe we can skip 
> passwords). But setting the file to 600 is certainly a good idea.
> 
> Martin Gräßlin wrote:
> > But setting the file to 600 is certainly a good idea.
> 
> this seems already to be the case (though I don't find the code for it)

FYI: I happened to see cross this. I only use Klipper at 2048. With such a size 
of the data, it means that I usually have my most frequently used items always 
available.


- Filip


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122382/#review75264
---


On Feb. 2, 2015, 3:12 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122382/
> ---
> 
> (Updated Feb. 2, 2015, 3:12 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Bugs: 34
> https://bugs.kde.org/show_bug.cgi?id=34
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> By invoking saveHistory after each change we ensure that the clipboard
> doesn't lose data in case klipper (or in dataengine mode plasmashell)
> crashes.
> 
> To not cause stalls, the saving is performed in a thread using
> QtConcurrentRun. As klipper itself is not thread save a Mutex is
> used to lock changes in the HistoryModel.
> 
> BUG: 34
> FIXED-IN: 5.3.0
> 
> 
> Diffs
> -
> 
>   klipper/klipper.cpp d49c165759f8171931167687c3b36b3a9d7dee07 
>   klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02 
>   klipper/historymodel.h 78f955f0ec4b8f27dbca0573b68691be6a30e3be 
>   klipper/historymodel.cpp 51860f6c3aca1022a2b721c27c859fc721915353 
> 
> Diff: https://git.reviewboard.kde.org/r/122382/diff/
> 
> 
> Testing
> ---
> 
> looked at ~/.local/share/klipper/history2.lst in Okteta, changed clipboard 
> and pressed F5 in Okteta. Repeated these steps multiple times.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

[David Edmundson]

> On Feb. 9, 2015, 7:47 a.m., Martin Gräßlin wrote:
> > kcms/dateandtime/main.cpp, line 143
> > 
> >
> > why wait? If I understand correctly the next dbus calls do not depend 
> > on the outcome of the first one. So you could just fire all of them and 
> > only check in the end whether they failed.

Yeah, that's sensible.
I want the method to block because otherwise having that and the old kauth 
approach end up differing wildly; but only blocking once will be more sensible.

It gives me a reason for removing the legacy system later :)


> On Feb. 9, 2015, 7:47 a.m., Martin Gräßlin wrote:
> > kcms/dateandtime/main.cpp, lines 87-93
> > 
> >
> > suggestion: move it into the dbus reply check

If your system DBus daemon is slow replying your system is more than slightly 
screwed anyway.

I end up changing the main widget so it's not as trivial as just this line. 
I'll see.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122400/#review75660
---


On Feb. 8, 2015, 5:18 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122400/
> ---
> 
> (Updated Feb. 8, 2015, 5:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The current time setting helper is incredibly broken.
> 
> It manually tries to run a range of NTP utilities, all of which are
> deprecated.
> 
> We can just call timedated directly and cut out the middleman as it has
> uses polkit anyway.
> 
> This is currently an optional dependency, and the original helper still
> exists. It makes the code messy, but we have users to support for now.
> 
> Finding timedated is an cmake option rather than querying for systemd
> libs to make it easier for those deploying shims, such as BSD.
> 
> 
> (code is in two commits, first abstracting the saving from the dtime class; 
> then adding in the second save mechanism) 
> 
> 
> Diffs
> -
> 
>   kcms/dateandtime/timedated1.xml PRE-CREATION 
>   kcms/dateandtime/main.h c1e5234 
>   kcms/dateandtime/main.cpp 0041a9d 
>   kcms/dateandtime/dtime.h 1a90698 
>   kcms/dateandtime/dtime.cpp 482e483 
>   kcms/dateandtime/CMakeLists.txt 4a987ae 
>   kcms/dateandtime/dateandtime.ui c073b5e 
> 
> Diff: https://git.reviewboard.kde.org/r/122400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Sebastian Kügler]

> On Feb. 9, 2015, 3:20 a.m., Aleix Pol Gonzalez wrote:
> > +1 I like it.
> > 
> > Why is it even possible to select a day though? It doesn't do anything at 
> > the moment...
> > 
> > Maybe it would be food that when hovering a day, the weekday was 
> > highlighted, it's useful to know what day is it.
> 
> Martin Klapetek wrote:
> Can be quite useful as sort of temporary bookmarking (like line 
> highliting in kate). You're doing something on the webs like trip planning, 
> calendar open, you need to remember a date, click, it gets highlighted, then 
> checking other pages you don't need to remember dates or something. And 
> similar. I actually found myself using it quite often (even when planning 
> things with multiple people, that allows me to pin the date I want and 
> creates a viewing anchor for others).

I initially added it assuming we'd get calendaring integration one day. I agree 
that it's less useful right now, but as long as it doesn't really bother the 
user, I think it's OK to keep it (or of course make it more useful).


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75656
---


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Sebastian Kügler]

> On Feb. 9, 2015, 2:51 p.m., Sebastian Kügler wrote:
> > The one thing I'm missing is an indicator for the currently selected year 
> > and month, should be exactly the same tinting as the selected day.
> > 
> > Otherwise, very nice work. When I implemented the combo-like behaviour, it 
> > was really resorting to that solution, yours is much, much nicer indeed.

Aaaand ... ignore my remark about the current-indicator. I see it's already 
there. I'll have my visual brain checked out one of these days. ;)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75695
---


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75695
---

Ship it!


The one thing I'm missing is an indicator for the currently selected year and 
month, should be exactly the same tinting as the selected day.

Otherwise, very nice work. When I implemented the combo-like behaviour, it was 
really resorting to that solution, yours is much, much nicer indeed.

- Sebastian Kügler


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122500: Don't delete widgets we don't own when changing styles

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122500/
---

Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
---

Don't delete widgets we don't own when changing styles

registerWidget may take an existing widget as a parameter. If so, we
don't want to delete it when our paletteHelper is deleted for example if
we change style.


Diffs
-

  kstyle/breezepalettehelper.cpp 31c32c3 

Diff: https://git.reviewboard.kde.org/r/122500/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/
---

(Updated Feb. 9, 2015, 2:33 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

this refactors the net systemmonitor plasmoid (hopefully fixing some of the 
bugs people had with it)
and brings back some other modules:
* cpu usage
* disk i/o activity
* memory usage
All applets share most of their stuff having as little duplication as possible


Diffs (updated)
-

  applets/CMakeLists.txt 25d774e 
  applets/systemmonitor/CMakeLists.txt PRE-CREATION 
  applets/systemmonitor/Messages.sh 2382ed6 
  applets/systemmonitor/common/contents/config/main.xml PRE-CREATION 
  applets/systemmonitor/common/contents/ui/Applet.qml PRE-CREATION 
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml PRE-CREATION 
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml PRE-CREATION 
  applets/systemmonitor/contents/config/config.qml 11944e5 
  applets/systemmonitor/contents/config/main.xml 57a30cb 
  applets/systemmonitor/contents/ui/configGeneral.qml 164e890 
  applets/systemmonitor/contents/ui/net.qml 20e1d47 
  applets/systemmonitor/cpu/Messages.sh PRE-CREATION 
  applets/systemmonitor/cpu/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/cpu/contents/ui/cpu.qml PRE-CREATION 
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml PRE-CREATION 
  applets/systemmonitor/cpu/metadata.desktop PRE-CREATION 
  applets/systemmonitor/diskactivity/Messages.sh PRE-CREATION 
  applets/systemmonitor/diskactivity/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml PRE-CREATION 
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml 
PRE-CREATION 
  applets/systemmonitor/diskactivity/metadata.desktop PRE-CREATION 
  applets/systemmonitor/diskusage/Messages.sh PRE-CREATION 
  applets/systemmonitor/diskusage/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml PRE-CREATION 
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml PRE-CREATION 
  applets/systemmonitor/diskusage/metadata.desktop PRE-CREATION 
  applets/systemmonitor/memory/Messages.sh PRE-CREATION 
  applets/systemmonitor/memory/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/memory/contents/ui/memory.qml PRE-CREATION 
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml PRE-CREATION 
  applets/systemmonitor/memory/metadata.desktop PRE-CREATION 
  applets/systemmonitor/metadata.desktop 00965ab 
  applets/systemmonitor/net/Messages.sh PRE-CREATION 
  applets/systemmonitor/net/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/net/contents/ui/net.qml PRE-CREATION 
  applets/systemmonitor/net/contents/ui/netConfig.qml PRE-CREATION 
  applets/systemmonitor/net/metadata.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122420/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=343962

Kai Uwe Broulik  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX
 CC||k...@privat.broulik.de

--- Comment #4 from Kai Uwe Broulik  ---
I'm sorry but it was a conscious decision to show the OSD ontop of everything
and I went through a lot of trouble to make that happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/
---

(Updated Feb. 9, 2015, 2:19 p.m.)


Review request for Plasma.


Changes
---

configured sources should actually work now


Repository: plasma-workspace


Description
---

this refactors the net systemmonitor plasmoid (hopefully fixing some of the 
bugs people had with it)
and brings back some other modules:
* cpu usage
* disk i/o activity
* memory usage
All applets share most of their stuff having as little duplication as possible


Diffs (updated)
-

  applets/systemmonitor/diskactivity/Messages.sh PRE-CREATION 
  applets/systemmonitor/diskactivity/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml PRE-CREATION 
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml 
PRE-CREATION 
  applets/systemmonitor/diskactivity/metadata.desktop PRE-CREATION 
  applets/systemmonitor/diskusage/Messages.sh PRE-CREATION 
  applets/systemmonitor/diskusage/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml PRE-CREATION 
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml PRE-CREATION 
  applets/systemmonitor/diskusage/metadata.desktop PRE-CREATION 
  applets/systemmonitor/memory/Messages.sh PRE-CREATION 
  applets/systemmonitor/memory/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/memory/contents/ui/memory.qml PRE-CREATION 
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml PRE-CREATION 
  applets/systemmonitor/memory/metadata.desktop PRE-CREATION 
  applets/systemmonitor/metadata.desktop 00965ab 
  applets/systemmonitor/net/Messages.sh PRE-CREATION 
  applets/systemmonitor/net/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/net/contents/ui/net.qml PRE-CREATION 
  applets/systemmonitor/net/contents/ui/netConfig.qml PRE-CREATION 
  applets/systemmonitor/net/metadata.desktop PRE-CREATION 
  applets/systemmonitor/contents/ui/net.qml 20e1d47 
  applets/systemmonitor/cpu/Messages.sh PRE-CREATION 
  applets/systemmonitor/cpu/contents/config/config.qml PRE-CREATION 
  applets/systemmonitor/cpu/contents/ui/cpu.qml PRE-CREATION 
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml PRE-CREATION 
  applets/systemmonitor/cpu/metadata.desktop PRE-CREATION 
  applets/systemmonitor/contents/config/main.xml 57a30cb 
  applets/systemmonitor/contents/ui/configGeneral.qml 164e890 
  applets/systemmonitor/common/contents/config/main.xml PRE-CREATION 
  applets/systemmonitor/common/contents/ui/Applet.qml PRE-CREATION 
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml PRE-CREATION 
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml PRE-CREATION 
  applets/systemmonitor/contents/config/config.qml 11944e5 
  applets/CMakeLists.txt 25d774e 
  applets/systemmonitor/CMakeLists.txt PRE-CREATION 
  applets/systemmonitor/Messages.sh 2382ed6 

Diff: https://git.reviewboard.kde.org/r/122420/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: theme mixing

[Sebastian Kügler]

Hi Pedro,

On Sunday, February 08, 2015 12:10:12 Pedro Rosado wrote:
> I don't know if this is the right place, but I wanted to suggest something.
> 
> KDE is by far the most modern and efficient desktop I've came to know (not
> dissing all the others), but regarding customization it's falling a little
> behind. Compared to gnome-look org, KDE look feels abandoned and there
> aren't many themes available at all, most are not even online anymore (host
> site doesn't have the file anymore). Most themes work like a charm on
> plasma 5, it's not like gnome that breaks a theme everytime it's updated.
> 
> So, could the kde development theme  give end users a tool to combine or
> make their own themes with a user friendly interface? I've tried myself to
> make a kwin theme - only found despair and wasted time looking inside svg
> files (I'm an end user, not an IT guy :c  )
> Also, it would be nice to have all those themes shared if you want to, so
> that the whole community can use them. Instead of searching themes on the
> settings (that most times doesn't work because the files aren't hosted
> anymore at kde look.org), users could have this "customization" tool that
> allows users to search and create themes and share them into a repo or
> github so that anyone can find them and use them, independent of distro (as
> long as you are using kde)
> 
> Summary:
> - Easy tool to make kwin and desktop themes for kde
> - Able to share and download the themes from the desktop app
> - kde kicks ass

You can mix-and-match workspace themes in systemsettings, go to "Workspace 
Theme" -> "Desktop Theme" -> "Details". This allows you to combine elements 
from different themes convienently in the UI. If that doesn't allow you to do 
what you'd like to, it indeed comes down to managing SVG files and combining 
them into a new theme. You've already found that out, it's a bit fiddly, but 
so is anything advanced enough to satisfy the complex need for a complete 
theming system.

As to the quality of kde-look.org, we cannot do much about it, since it's a 
community-run site, which doesn't receive much love in terms of maintainance 
and content curation, unfortunately.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Get panel list and hidding them via C++ module

[Sebastian Kügler]

Hi Evgeniy,

On Monday, February 09, 2015 15:43:05 Evgeniy Alekseev wrote:
> Recently I have run into the following problem: how to get panel list (even 
> w\o additional filtering) and hidding them from an applet?
> 
> With KDE4 I have used the following method:
> 1. From plasmoid I have called containment()->corona() to get pointer to 
> corona object.
> 2. Then I have used iteration on containments in the current corona() with 
> filter by ContainmentType.
> 3. And set found containments hidding by calling Containment->view()-
> >setVisible(false).

That's a hack, even in a Plasma 4 world. :)

> With Plasma 5 I have found the following problems:
> 
> 1. Unfortunately in the default way (i.e. if C++ module inherits from
> Qobject)  I didn't find ability to get pointer to current corona. Is it
> possible to get it at the moment?

Not possible, the QtQuick code's access to the C++ bits (Applet, Containment 
is now very limited by design).

> 2. Current containments have not view() method and seems have not method to 
> set them hidding. Is there such ability in the current version?

No, the separation between model (Plasma::Applet, Plasma::Containment, etc.) 
and the views (implemented in QtQuick) is deeper in Plasma 5, that's partly a 
conscious design decision, and partly mandated by moving everything to 
QtQuick.

> Also I have looked at QML bindings, but didn't find any ability to
> implement  such functional too.

That's not possible in Plasma 5, and it's a conscious design decision. Applets 
are not supposed to meddle with other applets, they're self-contained 
outbound, and managed by the surrounding containment. If applets started 
screwing around with each other, the situation would quickly become 
unmanageable.

Let's take a step back, though. What do you actually want to achieve? Maybe 
there is a way to make that possible within the design of Plasma.

Have you looked at desktop scripting to achieve what you are looking for?

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=343962

--- Comment #3 from Martin Gräßlin  ---
(In reply to Martin Klapetek from comment #1)
> I was wondering this the other day - can the OSD know there's a fullscreen
> window above?

yes it could know it: get active window, check whether it's fullscreen. But
this wouldn't work if the video player is not active (e.g. multiple screens) or
if the video player sucks (using override redirect window).

Personally I think we should neither adjust the representation nor add a config
option for it. We had quite some discussions about it and decided that the
proper layer for the osd is to be on top of everything including playing
videos. We will never be able to please everyone. I think it's totally valid to
show the OSD on top of a playing video when changing the backlight.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122494: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122494/#review75687
---


Doesn't look like an improvement to me, especially the network management 
applet becomes more fiddly, it barely shows two available networks after 
patching, I'd much rather prevent having to scroll in there.

The bottom line is that with fixed spacing, some people will find it too large, 
others too small. With that in mind, the current size is a decent compromise. 
As long as it isn't clipped on a low-res screen such as the one you're using, I 
think that's fine, it can't ever be perfect, but showing less information there 
doesn't improve it, when opening this popup, the user actually wants to get at 
that information, forcing him/her to scroll in more cases is just going to make 
the user experience worse for everybody (not just the ones with low-res 
displays).

For the battery monitor, this patch looks like it would actually force a 
scrollbar there as well as soon as keyboard brightness controls come into 
place, or even inhibition notifications. We do really need the space that now 
looks empty there. For klipper, it's going to be more fiddly as well.

-2 from my side, sorry.

- Sebastian Kügler


On Feb. 8, 2015, 11:34 p.m., Blaga Florentin Gabriel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122494/
> ---
> 
> (Updated Feb. 8, 2015, 11:34 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KDE Plasma 5 system tray expanded applets resize for notebooks
> 
> 
> Diffs
> -
> 
>   .reviewboardrc 771837c982012f580f10923aa83d83b181afc881 
>   applets/systemtray/package/contents/ui/main.qml 
> 553ad7a23d8d18974a02f35dc64b3f7dd4816585 
> 
> Diff: https://git.reviewboard.kde.org/r/122494/diff/
> 
> 
> Testing
> ---
> 
> Hello I've modified the size of the expanded system tray applets using the 
> file main.qml located at: 
> /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I 
> have uploaded a copy of the modified file below), thus when expanded they 
> take less space on notebook screens with low resolution (15 inch 1376x768), I 
> also tested it with a high resolution monitor (19 inch) and it definitely 
> improves the space there too. Below there are some screenshots with the 
> "before" and "after" the edit.
> 
> Kind regards!
> 
> 
> File Attachments
> 
> 
> battery_unmod_laptop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/05de2078-6dce-4578-a6a4-06bb6811e7e1__battery_unmod_laptop.png
> battery_modif_laptop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2c497b47-5180-420e-93bb-09a0225acd3b__battery_modif_laptop.png
> networks_unmodif_laptop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/4752ba6f-329b-461b-bab9-b3cf6c6707ae__networks_unmodif_laptop.png
> networks_modif_laptop.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/b614adf0-9d88-4c64-a448-07c9f5d39fd5__networks_modif_laptop.png
> high_unmodif_bat.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1600dac7-9516-4ec9-b66e-ce595c82d10a__high_unmodif_bat.png
> high_modif_bat.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/7f00e424-1c76-490a-a698-ec25e148101c__high_modif_bat.png
> wireless_unmodif_hires.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/71a32e89-ffdd-49c4-9db2-8a0e02b1c777__wireless_unmodif_hires.png
> wireless_modif_hires.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/469148e3-9ac6-4e0e-aafc-91431e87a48d__wireless_modif_hires.png
> 
> 
> Thanks,
> 
> Blaga Florentin Gabriel
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Get panel list and hidding them via C++ module

[Evgeniy Alekseev]

Hello,

Recently I have run into the following problem: how to get panel list (even 
w\o additional filtering) and hidding them from an applet?

With KDE4 I have used the following method:
1. From plasmoid I have called containment()->corona() to get pointer to 
corona object.
2. Then I have used iteration on containments in the current corona() with 
filter by ContainmentType.
3. And set found containments hidding by calling Containment->view()-
>setVisible(false).

With Plasma 5 I have found the following problems:

1. Unfortunately in the default way (i.e. if C++ module inherits from Qobject) 
I didn't find ability to get pointer to current corona. Is it possible to get 
it at the moment?
2. Current containments have not view() method and seems have not method to 
set them hidding. Is there such ability in the current version?

Also I have looked at QML bindings, but didn't find any ability to implement 
such functional too.

Thanks in advance =)
-- 
Sincerely yours, 
Evgeniy Alekseev

e-mail: darkarca...@mail.ru
ICQ: 407-398-235
Jabber: arca...@jabber.ru

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[hipersayan_x]

https://bugs.kde.org/show_bug.cgi?id=343962

--- Comment #2 from hipersayan_x  ---
> (just btw, when filing a bug, being nice and leaving out snarky comments
> usually works better)
Ok, sorry for that, but this is a real a problem for people who watch movies on
a laptop.

> I was wondering this the other day - can the OSD know there's a fullscreen
> window above? We /could/ offer a smaller version of the OSD in that case? Or
> shorter timeout? Martin?
Offering a smaller version doesn't solves the problem, just reduces it. Kmix
used to have the same problem some time ago and the developers added that
option, and that solved the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=343962

Martin Klapetek  changed:

   What|Removed |Added

 CC||mklape...@kde.org

--- Comment #1 from Martin Klapetek  ---
Thanks for the report.

(just btw, when filing a bug, being nice and leaving out snarky comments
usually works better)

I was wondering this the other day - can the OSD know there's a fullscreen
window above? We /could/ offer a smaller version of the OSD in that case? Or
shorter timeout? Martin?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 343962] New: Add option to disable Backlight OSD

[hipersayan_x]

https://bugs.kde.org/show_bug.cgi?id=343962

Bug ID: 343962
   Summary: Add option to disable Backlight OSD
   Product: Powerdevil
   Version: 5.2.0
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: hipersaya...@gmail.com

Created attachment 90990
  --> https://bugs.kde.org/attachment.cgi?id=90990&action=edit
OSD covering a full screen video

Its freaking annoying when I watching a full screen video and I want to change
the backlight level, and the OSD covers the subtitles and the most important
part of a film scene.

KDE carried with this problem for many years since 4.x version releases, but
previous OSD at least was not so annoying, so please add an option to disable
this "feature".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122371: Disable session management for kwrited

[Vishesh Handa]

> On Feb. 8, 2015, 1:49 p.m., David Edmundson wrote:
> > kwrited.cpp, line 74
> > 
> >
> > why this?

It's fine. Since kwrited doesn't have any UI, we can safely get away with this. 
It will reduce loading the current style and decrease memory usage.

We do the same thing in Baloo.


- Vishesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122371/#review75601
---


On Feb. 1, 2015, 8:55 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122371/
> ---
> 
> (Updated Feb. 1, 2015, 8:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 343550
> https://bugs.kde.org/show_bug.cgi?id=343550
> 
> 
> Repository: kwrited
> 
> 
> Description
> ---
> 
> kwrited has its autostart file IMHO doesn't need session management.
> 
> 
> Diffs
> -
> 
>   kwrited.cpp a4dac6b 
> 
> Diff: https://git.reviewboard.kde.org/r/122371/diff/
> 
> 
> Testing
> ---
> 
> no kwrited started by session.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.2, breeze, which tab is active?

[Mark Gaiser]

On Mon, Feb 9, 2015 at 11:38 AM, David Edmundson  wrote:

> That inactive tab should only be blue on mouseover.
> ​
> Either there's a bug or that screenshot isn't very representative.
>

Inactive is always blue here, but i seem to be having some other weirdness
as well (like no cursor themes).
Testing the same thing under a virtualbox environment does show the tabs as
you described.

I'll report back as soon as i fixed my environment :)


> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

[Sebastian Kügler]

> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote:
> > where do you want to use it?
> > Iirc Bhushan is working o a global way to make series of kcms accessible 
> > from plasmoids
> 
> David Edmundson wrote:
> Generic is always better.
> KDeclarative is used from places outside Plasma. Applications in future 
> will need to open KCMs too.
> If we put it in Plasma in one year we'll end up with this anyway and we 
> end up maintaining a weird system used only by us.
> 
> Also from a discussion on IRC you'll end up guessing the name to put in 
> the UI. This will lead to blocking developers from being able to do the right 
> thing by trying to be too clever.
> 
> Bhushan Shah wrote:
> My suggestion is to have both this can be used by applets if they don't 
> like solution provided by plasma-framework OR optionally turn this into 
> simple processrunner, there are use cases for both methods
> 
> Marco Martin wrote:
> apart that reading an "always" makes me cringe :p
> what I really don't like is the ui inconsistencies that this will cause 
> (an encourages). They will happen anyways true, but at least a timid attempt 
> at fighting that could be done (this was always been a problem in KDE, wasn't 
> it..), creating a path of least resistence and trying to enforce it is an 
> approach.
> 
> in the end is mostly a technical problem, since the actual proper 
> solution (putting them in the configure dialog) is not possible anymore. if 
> some day this will be possible again (for instance kcms in qml) that should 
> be the preferred way again, so both approaches are in the end just 
> workarounds, so... whatever (/me shrugs)
> 
> Bhushan Shah wrote:
> Or another option is something like https://paste.kde.org/pirqonxvl 
> 
> so that you can just do plasmoid.openConfigurationModules()
> 
> Sebastian Kügler wrote:
> It would be possible if we made the applet's config dialog a QWidget (the 
> KCM container) and put a QML container into that to load the actual config 
> modules for the applet. The problem with this approach is that it's the exact 
> opposite direction we have been going to, but at least it's not hidden from 
> the API.
> 
> I'm not proposing this, just bringing it up since it came up in my head: 
> food for thought.
> 
> Kai Uwe Broulik wrote:
> That could also give us back the widget sidebar looking consistent with 
> the KCMs if we used a traditional window with a sidebar and then have pages 
> for each of the qml config pages and add additional KCMs there as needed. For 
> other formfactors the old all-QML view could be used again, given that 
> widget-based apps don't really fit into a touch environment anyway.
> On the other hand, isn't systemsettings destined to become QtQuick-based 
> eventually?
> 
> Marco Martin wrote:
> yeah, *can* be done, but i consider it really a step back at this point. 
> it's problem was mostly a "too soon" but still think was the right direction

I lean towards not going this step back as well. Not that I have an alternative 
solution to offer, though. :/


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122239/#review74750
---


On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122239/
> ---
> 
> (Updated Jan. 24, 2015, 11:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Since there are already like 10 copies of the ProcessRunner for all kinds of 
> plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and 
> KCMShell.open(["foo", "bar", "baz"]) singleton.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff 
>   src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed 
> 
> Diff: https://git.reviewboard.kde.org/r/122239/diff/
> 
> 
> Testing
> ---
> 
> Works. Dunno if the name causes clashes or this is the right place to put it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 343961] Smallest size icons look bad on dark themes

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=343961

Martin Klapetek  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|unassigned-b...@kde.org
  Component|general |Icons
 CC||mklape...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 343961] New: Smallest size icons look bad on dark themes

[hipersayan_x]

https://bugs.kde.org/show_bug.cgi?id=343961

Bug ID: 343961
   Summary: Smallest size icons look bad on dark themes
   Product: Breeze
   Version: unspecified
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: hipersaya...@gmail.com

Created attachment 90989
  --> https://bugs.kde.org/attachment.cgi?id=90989&action=edit
I can't see the Konsole and Show Desktop icons, also System Settings icon in
clueless

Package name: breeze
Version: 5.2.0

When configuring the desktop theme to a dark color, like Oxygen or Breeze Dark,
I can barely distinguish the Konsole or Show Desktop icons from the background
when using Breeze icon themes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Martin Klapetek]

> On Feb. 9, 2015, 4:20 a.m., Aleix Pol Gonzalez wrote:
> > +1 I like it.
> > 
> > Why is it even possible to select a day though? It doesn't do anything at 
> > the moment...
> > 
> > Maybe it would be food that when hovering a day, the weekday was 
> > highlighted, it's useful to know what day is it.

Can be quite useful as sort of temporary bookmarking (like line highliting in 
kate). You're doing something on the webs like trip planning, calendar open, 
you need to remember a date, click, it gets highlighted, then checking other 
pages you don't need to remember dates or something. And similar. I actually 
found myself using it quite often (even when planning things with multiple 
people, that allows me to pin the date I want and creates a viewing anchor for 
others).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75656
---


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma Hangout

[Sebastian Kügler]

Present: Kai Uwe, David, Jonathan, Marco, Harald,
Excused: Martin G.

9th February, 2015

PSA: No hangout next week, as we'll meet in person for the Plasma sprint

David:
* Bugfixing

Harald:
* Started doing ISOs again
* switching to 15.04 / 64bits
* improved the released scripts (releaseme) to be much faster

Jonathan:
* Released Plasma 5.2
* Next week scheduled for 5.2.1

Kai Uwe:
* Freed powerdevil from xlib
* Worked on a new calendar view ( https://git.reviewboard.kde.org/r/122488/ , 
video at https://www.youtube.com/watch?v=7SaBhRa32ds )

Marco:
* Bugfixing and performance
* Reimplemented various systemmonitor applets ( 
https://git.reviewboard.kde.org/r/122420/ )
* Pending review: https://codereview.qt-project.org/#/c/104061/
* Pending review: https://git.reviewboard.kde.org/r/122459/
* Pending review: https://git.reviewboard.kde.org/r/121922/
* Working on klipper interaction problem with Firefox

Martin G.:
* worked on integrating new prison
* worked on global shortcut support for lock screen
* worked on OSD support for lock screen
* worked on XLib porting in kwin_wayland

Sebastian:
* was ill, back to action now


-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Martin Klapetek]

> On Feb. 9, 2015, 2:40 a.m., Lukáš Tinkl wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, line 61
> > 
> >
> > I know this is not your code but still... we must absolutely not make 
> > any asumptions about how the strings should be rendered. In some languages 
> > it's just plain wrong to display month names capitalized.
> 
> Lukáš Tinkl wrote:
> For the rationale: 
> http://meta.wikimedia.org/wiki/Capitalization_of_Wiktionary_pages#Capitalization_of_month_names
> 
> Most languages DO NOT capitalize month names

This is used in as a title however. Most languages do capitalize titles. And 
this one should be too.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75650
---


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Martin Klapetek]

On Feb. 9, 2015, 2:21 a.m., Kai Uwe Broulik wrote:
> > I'd advice against the new C++ functions. You can use setDisplayDate (even 
> > in QML with the displayedDate property) to accomplish the exact same thing 
> > and it keeps the C++ API clean.
> > If you really want to have the "helper functions" on the C++ side then you 
> > should call setDisplayDate(...) within those helper functions.
> > 
> > But i like your change from a visual perspective :) I actually think John 
> > Layt had this on his wish lish for the calendar!
> > Also, did you notice your bottom border in the month view is missing? It's 
> > like that in plasma 5.2 as well.
> 
> Kai Uwe Broulik wrote:
> I added them because the others were there and I didn't figure out how to 
> work with displayedDate, given JS Date is super horrible to work with but 
> I'll take a look.

> Kai: ...that's been that way for some time for me, though.
> Mark: Also, did you notice your bottom border in the month view is missing? 
> It's like that in plasma 5.2 as well.

Guys, please do report these at bko, kinda sucks if we released it like this 
and nobody shouted about this kinda huge visual bug :S


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75649
---


On Feb. 8, 2015, 9:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.2, breeze, which tab is active?

[David Edmundson]

That inactive tab should only be blue on mouseover.
​
Either there's a bug or that screenshot isn't very representative.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

theme mixing

[Pedro Rosado]

Hi there,


I don't know if this is the right place, but I wanted to suggest something.

KDE is by far the most modern and efficient desktop I've came to know (not
dissing all the others), but regarding customization it's falling a little
behind. Compared to gnome-look org, KDE look feels abandoned and there
aren't many themes available at all, most are not even online anymore (host
site doesn't have the file anymore). Most themes work like a charm on
plasma 5, it's not like gnome that breaks a theme everytime it's updated.

So, could the kde development theme  give end users a tool to combine or
make their own themes with a user friendly interface? I've tried myself to
make a kwin theme - only found despair and wasted time looking inside svg
files (I'm an end user, not an IT guy :c  )
Also, it would be nice to have all those themes shared if you want to, so
that the whole community can use them. Instead of searching themes on the
settings (that most times doesn't work because the files aren't hosted
anymore at kde look.org), users could have this "customization" tool that
allows users to search and create themes and share them into a repo or
github so that anyone can find them and use them, independent of distro (as
long as you are using kde)

Summary:
- Easy tool to make kwin and desktop themes for kde
- Able to share and download the themes from the desktop app
- kde kicks ass

*Pedro Daniel Vieira Rosado*

Mobile: (+351) 913130898
E-mail: pdvros...@gmail.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [KDE Usability] Review Request 122488: Improved calendar navigation

[kainz.a]

would it be useful to see the events of the day (in an agenda) when you
select the day

2015-02-09 4:20 GMT+01:00 Aleix Pol Gonzalez :

>This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
>
> +1 I like it.
>
> Why is it even possible to select a day though? It doesn't do anything at the 
> moment...
>
> Maybe it would be food that when hovering a day, the weekday was highlighted, 
> it's useful to know what day is it.
>
>
> - Aleix Pol Gonzalez
>
> On February 8th, 2015, 9:52 p.m. CET, Kai Uwe Broulik wrote:
>   Review request for Plasma and KDE Usability.
> By Kai Uwe Broulik.
>
> *Updated Feb. 8, 2015, 9:52 p.m.*
>  *Repository: * plasma-framework
> Description
>
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
>
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
>
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
>
>   Testing
>
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
>
>   Diffs
>
>- src/declarativeimports/calendar/calendar.cpp (a766acb)
>- src/declarativeimports/calendar/daydata.h (39ac086)
>- src/declarativeimports/calendar/daysmodel.h (ec88837)
>- src/declarativeimports/calendar/daysmodel.cpp (1a6f454)
>- src/declarativeimports/calendar/qml/DayDelegate.qml (6a3747e)
>- src/declarativeimports/calendar/qml/DaysCalendar.qml (67b3a2e)
>- src/declarativeimports/calendar/qml/MonthView.qml (6eaa8db)
>- src/declarativeimports/calendar/calendar.h (ea20bf5)
>
> View Diff 
>
> ___
> kde-usability mailing list
> kde-usabil...@kde.org
> https://mail.kde.org/mailman/listinfo/kde-usability
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75677
---

Ship it!


I like it. It reminds me an old demo Aza Raskin did on a ZUI ui for 
calendars/organizers i seen in an old video of a talk, looks very natural.
one supercool thing would be to bind to it things traditionally used for zoom, 
so ctrl+mousewheel and pinch for touchscreen/mac touchpad

- Marco Martin


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Marco Martin]

> On Feb. 9, 2015, 1:40 a.m., Lukáš Tinkl wrote:
> > src/declarativeimports/calendar/qml/DaysCalendar.qml, line 125
> > 
> >
> > I know this is nitpicking but... how is an arrow pointing to the left 
> > implemented as previous() meant to work for RTL languages? :)

this was already there, so unrelate,.. it should use the "go-previous" icon 
tough


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75650
---


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Kai Uwe Broulik]

On Feb. 9, 2015, 1:21 vorm., Kai Uwe Broulik wrote:
> > I'd advice against the new C++ functions. You can use setDisplayDate (even 
> > in QML with the displayedDate property) to accomplish the exact same thing 
> > and it keeps the C++ API clean.
> > If you really want to have the "helper functions" on the C++ side then you 
> > should call setDisplayDate(...) within those helper functions.
> > 
> > But i like your change from a visual perspective :) I actually think John 
> > Layt had this on his wish lish for the calendar!
> > Also, did you notice your bottom border in the month view is missing? It's 
> > like that in plasma 5.2 as well.

I added them because the others were there and I didn't figure out how to work 
with displayedDate, given JS Date is super horrible to work with but I'll take 
a look.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75649
---


On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> ---
> 
> (Updated Feb. 8, 2015, 8:52 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This improves the calendar navigation by providing a "Year overview" showing 
> all 12 months in a grid, and a "Decade overview" showing the current decade 
> in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel 
> owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
> mouse click effect!)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> ---
> 
> I changed the selection to be persistent during navigation; other than that, 
> should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

[Marco Martin]

> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote:
> > where do you want to use it?
> > Iirc Bhushan is working o a global way to make series of kcms accessible 
> > from plasmoids
> 
> David Edmundson wrote:
> Generic is always better.
> KDeclarative is used from places outside Plasma. Applications in future 
> will need to open KCMs too.
> If we put it in Plasma in one year we'll end up with this anyway and we 
> end up maintaining a weird system used only by us.
> 
> Also from a discussion on IRC you'll end up guessing the name to put in 
> the UI. This will lead to blocking developers from being able to do the right 
> thing by trying to be too clever.
> 
> Bhushan Shah wrote:
> My suggestion is to have both this can be used by applets if they don't 
> like solution provided by plasma-framework OR optionally turn this into 
> simple processrunner, there are use cases for both methods
> 
> Marco Martin wrote:
> apart that reading an "always" makes me cringe :p
> what I really don't like is the ui inconsistencies that this will cause 
> (an encourages). They will happen anyways true, but at least a timid attempt 
> at fighting that could be done (this was always been a problem in KDE, wasn't 
> it..), creating a path of least resistence and trying to enforce it is an 
> approach.
> 
> in the end is mostly a technical problem, since the actual proper 
> solution (putting them in the configure dialog) is not possible anymore. if 
> some day this will be possible again (for instance kcms in qml) that should 
> be the preferred way again, so both approaches are in the end just 
> workarounds, so... whatever (/me shrugs)
> 
> Bhushan Shah wrote:
> Or another option is something like https://paste.kde.org/pirqonxvl 
> 
> so that you can just do plasmoid.openConfigurationModules()
> 
> Sebastian Kügler wrote:
> It would be possible if we made the applet's config dialog a QWidget (the 
> KCM container) and put a QML container into that to load the actual config 
> modules for the applet. The problem with this approach is that it's the exact 
> opposite direction we have been going to, but at least it's not hidden from 
> the API.
> 
> I'm not proposing this, just bringing it up since it came up in my head: 
> food for thought.
> 
> Kai Uwe Broulik wrote:
> That could also give us back the widget sidebar looking consistent with 
> the KCMs if we used a traditional window with a sidebar and then have pages 
> for each of the qml config pages and add additional KCMs there as needed. For 
> other formfactors the old all-QML view could be used again, given that 
> widget-based apps don't really fit into a touch environment anyway.
> On the other hand, isn't systemsettings destined to become QtQuick-based 
> eventually?

yeah, *can* be done, but i consider it really a step back at this point. it's 
problem was mostly a "too soon" but still think was the right direction


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122239/#review74750
---


On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122239/
> ---
> 
> (Updated Jan. 24, 2015, 11:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Since there are already like 10 copies of the ProcessRunner for all kinds of 
> plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and 
> KCMShell.open(["foo", "bar", "baz"]) singleton.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff 
>   src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed 
> 
> Diff: https://git.reviewboard.kde.org/r/122239/diff/
> 
> 
> Testing
> ---
> 
> Works. Dunno if the name causes clashes or this is the right place to put it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel