Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 176 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/176/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 14 Sep 2015 10:21:44 +
Build duration: 6 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 14/14 (100%)FILES 62/71 (87%)CLASSES 62/71 (87%)LINE 2498/4098 
(61%)CONDITIONAL 1475/2298 (64%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 302/422 (72%)CONDITIONAL 
436/495 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/149 (74%)CONDITIONAL 
40/70 (57%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
ksmserver.screenlocker
FILES 9/11 (82%)CLASSES 9/11 (82%)LINE 485/1035 
(47%)CONDITIONAL 147/229 (64%)
ksmserver.screenlocker.autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 165/169 (98%)CONDITIONAL 
65/124 (52%)
ksmserver.screenlocker.greeter
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 99/144 (69%)CONDITIONAL 
36/60 (60%)
ksmserver.screenlocker.greeter.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 45/45 (100%)CONDITIONAL 
34/68 (50%)
libkworkspace
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 28/610 (5%)CONDITIONAL 
23/39 (59%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/160 (54%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 96/100 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 176 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/176/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 14 Sep 2015 10:21:44 +
Build duration: 6 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 14/14 (100%)FILES 62/71 (87%)CLASSES 62/71 (87%)LINE 2498/4098 
(61%)CONDITIONAL 1475/2298 (64%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 302/422 (72%)CONDITIONAL 
436/495 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/149 (74%)CONDITIONAL 
40/70 (57%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
ksmserver.screenlocker
FILES 9/11 (82%)CLASSES 9/11 (82%)LINE 485/1035 
(47%)CONDITIONAL 147/229 (64%)
ksmserver.screenlocker.autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 165/169 (98%)CONDITIONAL 
65/124 (52%)
ksmserver.screenlocker.greeter
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 99/144 (69%)CONDITIONAL 
36/60 (60%)
ksmserver.screenlocker.greeter.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 45/45 (100%)CONDITIONAL 
34/68 (50%)
libkworkspace
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 28/610 (5%)CONDITIONAL 
23/39 (59%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/160 (54%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 96/100 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/
---

Review request for Plasma.


Repository: kdeplasma-addons


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


Diffs
-

  applets/CMakeLists.txt 2e29bbe 
  applets/quicklaunch/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/Messages.sh PRE-CREATION 
  applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/plugin/qmldir PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125222/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/
---

(Updated Sept. 14, 2015, 11:11 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


For the review purposes, I have generated diff with code in "quicklaunch-qml" 
directory, but it should go to the original "quicklaunch" dir.


Diffs
-

  applets/CMakeLists.txt 40c2e05 
  applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch-qml/Messages.sh PRE-CREATION 
  applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125174/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 178 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/178/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 14 Sep 2015 10:21:41 +
Build duration: 16 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/38 (95%)CLASSES 36/38 (95%)LINE 2370/3410 
(70%)CONDITIONAL 1783/3079 (58%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 
18/34 (53%)
kcms.keyboard
FILES 20/22 (91%)CLASSES 20/22 (91%)LINE 800/1526 
(52%)CONDITIONAL 770/1268 (61%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 
511/994 (51%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 
242/364 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 269/350 (77%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 178 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/178/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 14 Sep 2015 10:21:41 +
Build duration: 16 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/38 (95%)CLASSES 36/38 (95%)LINE 2370/3410 
(70%)CONDITIONAL 1783/3079 (58%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 
18/34 (53%)
kcms.keyboard
FILES 20/22 (91%)CLASSES 20/22 (91%)LINE 800/1526 
(52%)CONDITIONAL 770/1268 (61%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 
511/994 (51%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 
242/364 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 269/350 (77%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125187: Stop requiring Frameworks 5.15

[Sebastian Kügler]

> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote:
> > -2, a change for a month in the devel branch doesn't make much sense.
> 
> David Faure wrote:
> As you want. You're raising the bar for new contributors, who can't work 
> on your code using the latest KDE Frameworks release.
> 
> You and me might compile everything, but you'll get more contributors if 
> you let people work on workspace and apps using a released frameworks (for 
> which there are distro packages) than if you require them to compile 
> frameworks first. Just like we don't require Qt from git, we shouldn't 
> require KF5 from git, I thought this was the general agreement.
> 
> If you're worried about the ifdef, just use the two liner version of the 
> code forever, I was always a bit dubious about adding a method just for that 
> anyway.
> 
> Martin Gräßlin wrote:
> It's really not that uncommon to depend on latest frameworks in 
> workspace. It's common that I add things in KWindowSystem to make use of it 
> in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel 
> directly.
> 
> Yes it raises the entry level, but it's also rather unlikely that we are 
> able to a policy forbidding depending on frameworks master without CI checks.

Besides, these occasional devs can use the stable branch en then forward port?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85353
---


On Sept. 12, 2015, 9:38 a.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> ---
> 
> (Updated Sept. 12, 2015, 9:38 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing 
> plasma-workspace git master to depend on yet unreleased version of KDE 
> Frameworks to build. David Faure has suggested to use fix like this one until 
> at least Frameworks 5.15 have been released.
> 
> I don't have commit access, so someone needs to commit this for me.
> 
> 
> Diffs
> -
> 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
> 
> 
> Testing
> ---
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125187: Stop requiring Frameworks 5.15

[Marco Martin]

> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote:
> > -2, a change for a month in the devel branch doesn't make much sense.
> 
> David Faure wrote:
> As you want. You're raising the bar for new contributors, who can't work 
> on your code using the latest KDE Frameworks release.
> 
> You and me might compile everything, but you'll get more contributors if 
> you let people work on workspace and apps using a released frameworks (for 
> which there are distro packages) than if you require them to compile 
> frameworks first. Just like we don't require Qt from git, we shouldn't 
> require KF5 from git, I thought this was the general agreement.
> 
> If you're worried about the ifdef, just use the two liner version of the 
> code forever, I was always a bit dubious about adding a method just for that 
> anyway.
> 
> Martin Gräßlin wrote:
> It's really not that uncommon to depend on latest frameworks in 
> workspace. It's common that I add things in KWindowSystem to make use of it 
> in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel 
> directly.
> 
> Yes it raises the entry level, but it's also rather unlikely that we are 
> able to a policy forbidding depending on frameworks master without CI checks.
> 
> Sebastian Kügler wrote:
> Besides, these occasional devs can use the stable branch en then forward 
> port?

-2 from here as well for the same reasons


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85353
---


On Sept. 12, 2015, 9:38 a.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> ---
> 
> (Updated Sept. 12, 2015, 9:38 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing 
> plasma-workspace git master to depend on yet unreleased version of KDE 
> Frameworks to build. David Faure has suggested to use fix like this one until 
> at least Frameworks 5.15 have been released.
> 
> I don't have commit access, so someone needs to commit this for me.
> 
> 
> Diffs
> -
> 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
> 
> 
> Testing
> ---
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: support for the slide protocol

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/
---

(Updated Sept. 14, 2015, 1:19 p.m.)


Review request for kwin, Plasma and Eike Hein.


Repository: kwin


Description
---

take and apply thhe informations from the wayland slide protocol in the sliding 
popups effect


Diffs (updated)
-

  autotests/mock_effectshandler.h fba13cd 
  effects.h 97c2f87 
  effects.cpp f104410 
  effects/slidingpopups/slidingpopups.h ac3cf10 
  effects/slidingpopups/slidingpopups.cpp f6d9ec5 
  libkwineffects/kwineffects.h 20a0768 

Diff: https://git.reviewboard.kde.org/r/125120/diff/


Testing
---

slide to appear works, slide out to disappear doesn't.

the second time a popup is opened, kwin crashes and an assert is hit

kwin_wayland: 
/home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) 
const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= 
top() && y2 <= bottom()' failed.


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: [wip] support for the slide protocol

[Marco Martin]

> On Sept. 10, 2015, 6:33 a.m., Martin Gräßlin wrote:
> > effects/slidingpopups/slidingpopups.cpp, lines 433-434
> > 
> >
> > on X11 the time might also come from the property.
> 
> Marco Martin wrote:
> for Eike: is the custom animation time passed in the effect still needed? 
> (iirc it was used in yakuake)
> 
> Eike Hein wrote:
> Yakuake still exposes this as a GUI setting. Personally I wouldn't mind 
> removing it too much. I know some users do use it, but most of them predate 
> the redesign of the slide effect to include fading.
> 
> Marco Martin wrote:
> so, will give few days to think about.., then how you guys decide to 
> include them, I can add those properties in the kwayland protocol as well 
> (while would still be not exposed in kwindoweffect one could still use 
> kwayland by hand)

after discussion in the hangout, i'll not add them for now, but they can be 
added in a next release in a compatible way if needed for how the protocol is 
designed


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/#review85083
---


On Sept. 10, 2015, 11:03 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125120/
> ---
> 
> (Updated Sept. 10, 2015, 11:03 a.m.)
> 
> 
> Review request for kwin, Plasma and Eike Hein.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> take and apply thhe informations from the wayland slide protocol in the 
> sliding popups effect
> 
> 
> Diffs
> -
> 
>   effects/slidingpopups/slidingpopups.h ac3cf10 
>   effects/slidingpopups/slidingpopups.cpp f6d9ec5 
> 
> Diff: https://git.reviewboard.kde.org/r/125120/diff/
> 
> 
> Testing
> ---
> 
> slide to appear works, slide out to disappear doesn't.
> 
> the second time a popup is opened, kwin crashes and an assert is hit
> 
> kwin_wayland: 
> /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
> KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, 
> double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() 
> && y1 >= top() && y2 <= bottom()' failed.
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: support for the slide protocol

[Marco Martin]

> On Sept. 14, 2015, 12:43 p.m., Martin Gräßlin wrote:
> > effects/slidingpopups/slidingpopups.cpp, line 436
> > 
> >
> > are you going to do the un-duplications?

moved the identical part in a private function


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/#review85376
---


On Sept. 14, 2015, 1:19 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125120/
> ---
> 
> (Updated Sept. 14, 2015, 1:19 p.m.)
> 
> 
> Review request for kwin, Plasma and Eike Hein.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> take and apply thhe informations from the wayland slide protocol in the 
> sliding popups effect
> 
> 
> Diffs
> -
> 
>   autotests/mock_effectshandler.h fba13cd 
>   effects.h 97c2f87 
>   effects.cpp f104410 
>   effects/slidingpopups/slidingpopups.h ac3cf10 
>   effects/slidingpopups/slidingpopups.cpp f6d9ec5 
>   libkwineffects/kwineffects.h 20a0768 
> 
> Diff: https://git.reviewboard.kde.org/r/125120/diff/
> 
> 
> Testing
> ---
> 
> slide to appear works, slide out to disappear doesn't.
> 
> the second time a popup is opened, kwin crashes and an assert is hit
> 
> kwin_wayland: 
> /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
> KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, 
> double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() 
> && y1 >= top() && y2 <= bottom()' failed.
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

[Takahiro Hashimoto]

> On 9月 14, 2015, 8:12 p.m., Aleix Pol Gonzalez wrote:
> > Do you have a developer account? Otherwise I'll submit the patch for you.

Yes I got it a few days ago :) I'd like to submit this by myself. Thanks again.


- Takahiro


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124877/#review85371
---


On 9月 11, 2015, 10:01 p.m., Takahiro Hashimoto wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124877/
> ---
> 
> (Updated 9月 11, 2015, 10:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 351609
> https://bugs.kde.org/show_bug.cgi?id=351609
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 
> generates corrupted files.
> 
> $HOME/.config/startupconfigfiles
> $HOME/.config/startupconfig
> 
> 
> Diffs
> -
> 
>   startkde/kstartupconfig/kdostartupconfig.cpp 3944c06 
> 
> Diff: https://git.reviewboard.kde.org/r/124877/diff/
> 
> 
> Testing
> ---
> 
> works for me. 
> 
> 1. execute kstartupconfig5
> 2. check if both files are not corrupted.
> 
> 
> Updated: rebased with latest and tested with Revision 2 the same test. OK.
> 
> 
> Thanks,
> 
> Takahiro Hashimoto
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: support for the slide protocol

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/#review85376
---


The change for findWindow(Surface) looks good.


effects/slidingpopups/slidingpopups.cpp (line 274)


two small suggestions:
* reduce scope of variable by putting it into the if
* use auto



effects/slidingpopups/slidingpopups.cpp (line 408)


w might be null, given how effects->findWindow works. Please add a check 
for it.



effects/slidingpopups/slidingpopups.cpp (line 416)


nitpick :-)



effects/slidingpopups/slidingpopups.cpp (line 436)


are you going to do the un-duplications?


- Martin Gräßlin


On Sept. 14, 2015, 2:11 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125120/
> ---
> 
> (Updated Sept. 14, 2015, 2:11 p.m.)
> 
> 
> Review request for kwin, Plasma and Eike Hein.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> take and apply thhe informations from the wayland slide protocol in the 
> sliding popups effect
> 
> 
> Diffs
> -
> 
>   autotests/mock_effectshandler.h fba13cd 
>   effects.h 97c2f87 
>   effects.cpp f104410 
>   effects/slidingpopups/slidingpopups.h ac3cf10 
>   effects/slidingpopups/slidingpopups.cpp f6d9ec5 
>   libkwineffects/kwineffects.h 20a0768 
> 
> Diff: https://git.reviewboard.kde.org/r/125120/diff/
> 
> 
> Testing
> ---
> 
> slide to appear works, slide out to disappear doesn't.
> 
> the second time a popup is opened, kwin crashes and an assert is hit
> 
> kwin_wayland: 
> /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
> KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, 
> double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() 
> && y1 >= top() && y2 <= bottom()' failed.
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: [wip] support for the slide protocol

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/
---

(Updated Sept. 14, 2015, 12:11 p.m.)


Review request for kwin, Plasma and Eike Hein.


Repository: kwin


Description
---

take and apply thhe informations from the wayland slide protocol in the sliding 
popups effect


Diffs (updated)
-

  autotests/mock_effectshandler.h fba13cd 
  effects.h 97c2f87 
  effects.cpp f104410 
  effects/slidingpopups/slidingpopups.h ac3cf10 
  effects/slidingpopups/slidingpopups.cpp f6d9ec5 
  libkwineffects/kwineffects.h 20a0768 

Diff: https://git.reviewboard.kde.org/r/125120/diff/


Testing
---

slide to appear works, slide out to disappear doesn't.

the second time a popup is opened, kwin crashes and an assert is hit

kwin_wayland: 
/home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) 
const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= 
top() && y2 <= bottom()' failed.


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: support for the slide protocol

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/
---

(Updated Sept. 14, 2015, 12:11 p.m.)


Review request for kwin, Plasma and Eike Hein.


Summary (updated)
-

support for the slide protocol


Repository: kwin


Description
---

take and apply thhe informations from the wayland slide protocol in the sliding 
popups effect


Diffs
-

  autotests/mock_effectshandler.h fba13cd 
  effects.h 97c2f87 
  effects.cpp f104410 
  effects/slidingpopups/slidingpopups.h ac3cf10 
  effects/slidingpopups/slidingpopups.cpp f6d9ec5 
  libkwineffects/kwineffects.h 20a0768 

Diff: https://git.reviewboard.kde.org/r/125120/diff/


Testing
---

slide to appear works, slide out to disappear doesn't.

the second time a popup is opened, kwin crashes and an assert is hit

kwin_wayland: 
/home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) 
const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= 
top() && y2 <= bottom()' failed.


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

[Takahiro Hashimoto]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124877/
---

(Updated Sept. 14, 2015, 12:39 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit e92628aa42251cad211733d88affbf6a56277379 by Takahiro 
Hashimoto to branch master.


Bugs: 351609
https://bugs.kde.org/show_bug.cgi?id=351609


Repository: plasma-workspace


Description
---

Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 
generates corrupted files.

$HOME/.config/startupconfigfiles
$HOME/.config/startupconfig


Diffs
-

  startkde/kstartupconfig/kdostartupconfig.cpp 3944c06 

Diff: https://git.reviewboard.kde.org/r/124877/diff/


Testing
---

works for me. 

1. execute kstartupconfig5
2. check if both files are not corrupted.


Updated: rebased with latest and tested with Revision 2 the same test. OK.


Thanks,

Takahiro Hashimoto

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124877/#review85371
---

Ship it!


Do you have a developer account? Otherwise I'll submit the patch for you.

- Aleix Pol Gonzalez


On Sept. 11, 2015, 3:01 p.m., Takahiro Hashimoto wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124877/
> ---
> 
> (Updated Sept. 11, 2015, 3:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 351609
> https://bugs.kde.org/show_bug.cgi?id=351609
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 
> generates corrupted files.
> 
> $HOME/.config/startupconfigfiles
> $HOME/.config/startupconfig
> 
> 
> Diffs
> -
> 
>   startkde/kstartupconfig/kdostartupconfig.cpp 3944c06 
> 
> Diff: https://git.reviewboard.kde.org/r/124877/diff/
> 
> 
> Testing
> ---
> 
> works for me. 
> 
> 1. execute kstartupconfig5
> 2. check if both files are not corrupted.
> 
> 
> Updated: rebased with latest and tested with Revision 2 the same test. OK.
> 
> 
> Thanks,
> 
> Takahiro Hashimoto
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: State of Plasma with Qt 5.6

[Aleix Pol]

On Tue, Sep 1, 2015 at 6:35 PM, Aleix Pol  wrote:
> Hi,
> For reasons [1] I've had to change to Qt 5.6 today. I wanted to make
> sure everyone knows what's the status, hence this e-mail.
>
> I've been experiencing a small issue [2] on start, so we can't expect
> Plasma 5.4.0 to work with it, probably worth backporting the change so
> 5.4.1 can use Qt 5.6.
>
> On one of my users with a vanilla configuration it just works (yay),
> on the other one I'm getting a crash [3]. I'll follow up on the issue
> and report back.
>
> Regards,
> Aleix
>
>
> [1] https://codereview.qt-project.org/#/c/124783/
> [2] https://git.reviewboard.kde.org/r/125023/
> [3] https://bugreports.qt.io/browse/QTBUG-48056

Small update. I came up with a patch that /WORKAROUNDS/ the crash, in
case anybody is interested in trying.

https://codereview.qt-project.org/#/c/125681/

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: support for the slide protocol

[Marco Martin]

> On Sept. 14, 2015, 2:16 p.m., Martin Gräßlin wrote:
> > Ship It!

ah, to properly work will also need https://git.reviewboard.kde.org/r/125131/


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/#review85378
---


On Sept. 14, 2015, 2:40 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125120/
> ---
> 
> (Updated Sept. 14, 2015, 2:40 p.m.)
> 
> 
> Review request for kwin, Plasma and Eike Hein.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> take and apply thhe informations from the wayland slide protocol in the 
> sliding popups effect
> 
> 
> Diffs
> -
> 
>   autotests/mock_effectshandler.h fba13cd 
>   effects.h 97c2f87 
>   effects.cpp f104410 
>   effects/slidingpopups/slidingpopups.h ac3cf10 
>   effects/slidingpopups/slidingpopups.cpp f6d9ec5 
>   libkwineffects/kwineffects.h 20a0768 
> 
> Diff: https://git.reviewboard.kde.org/r/125120/diff/
> 
> 
> Testing
> ---
> 
> slide to appear works, slide out to disappear doesn't.
> 
> the second time a popup is opened, kwin crashes and an assert is hit
> 
> kwin_wayland: 
> /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
> KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, 
> double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() 
> && y1 >= top() && y2 <= bottom()' failed.
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

minutes monday plasma hangout

[Sebastian Kügler]

Present: Bhushan, David, Kai Uwe, Marco, Martin G., Ozark, Ovidiu, sebas

Date: 14 September, 2015

Bhushan:
- worked on packaging telepathy bits for Plasma aarch
- it have pkgbuilds but just needs creating packages in order
- https://notes.kde.org/p/plasma-bugs collects

David:
- https://git.reviewboard.kde.org/r/125187/ requests to only depend on a 
released framework in Plasma -- idea is generally not popular with Plasma devs

Kai Uwe:
- Super pretty new Color picker plasmoid for Plasma 5 has been merged
- Shortcut configuration in System Tray like we had in 4 is also back
- want to merge https://git.reviewboard.kde.org/r/125118/
- will also have to talk to Eike so we can use the KIO drop job thing also for 
folderview

Marco:
- wayland stuff: protocol for OSD
- wayland sliding popups to be reviewed
- will discuss with Martin later
- made gcompris and marble work on Plasma Mobile
- minor fixes in mobile widget explorer and taskswitcher
- HIG discussions (will be added to HIG by Thomas)

Ovidiu-Florin:
- baloo kcm patch pending review by Vishesh
- worked on Android cmake module with Aleix

Martin:
- kwayland: API docs for kwayland (api.kde.org doesn't pick it up yet -- wip)
- Docs for kde/workspace need sorting (David will help)
- kwayland changes for tooltips and menues are merged
- work in kwin on tooltip and menues next (more complicated)
- sidebar designs ( http://user-prompt.com/look-and-feel-of-plasma-sidebars/ ) 
: interaction changes are a no-go (breaks important user interaction), visual 
changes may be OK, depending

Ozark:
- nothing new

Sebastian:
- screen config: wayland portions to be reviewed
- libkscreen portions work in progress (most "read autotests are OK", write 
will be next)
- kwin/drm portions to be done



-- 
sebas

Sebastian Kügler|http://vizZzion.org| http://kde.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: support for the slide protocol

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/#review85378
---

Ship it!


Ship It!

- Martin Gräßlin


On Sept. 14, 2015, 3:19 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125120/
> ---
> 
> (Updated Sept. 14, 2015, 3:19 p.m.)
> 
> 
> Review request for kwin, Plasma and Eike Hein.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> take and apply thhe informations from the wayland slide protocol in the 
> sliding popups effect
> 
> 
> Diffs
> -
> 
>   autotests/mock_effectshandler.h fba13cd 
>   effects.h 97c2f87 
>   effects.cpp f104410 
>   effects/slidingpopups/slidingpopups.h ac3cf10 
>   effects/slidingpopups/slidingpopups.cpp f6d9ec5 
>   libkwineffects/kwineffects.h 20a0768 
> 
> Diff: https://git.reviewboard.kde.org/r/125120/diff/
> 
> 
> Testing
> ---
> 
> slide to appear works, slide out to disappear doesn't.
> 
> the second time a popup is opened, kwin crashes and an assert is hit
> 
> kwin_wayland: 
> /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
> KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, 
> double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() 
> && y1 >= top() && y2 <= bottom()' failed.
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125223: Add support for transient to ShellSurface(Interface)

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125223/
---

Review request for Plasma and Sebastian Kügler.


Repository: kwayland


Description
---

On client side a setTransient method is added which wraps the semantic
of wl_shell_surface_set_transient.

On server side both set_transient and set_popup are implemented, though
for popup only the transient part is implemented. In particular the grab
is not yet handled and also no popup done is provided.

For the transient on server side the flags are ignored. Main reason is
that Qt does not use the flag, so testing whether it works is tricky
(needs a test application).


Diffs
-

  autotests/client/test_wayland_shell.cpp 
89101f4443a1b412a922c99bfe59d06ef1401468 
  src/client/shell.h 0777c51da0c2c2568e664af5fe1db51fa5c028bb 
  src/client/shell.cpp 94eb4de497d3cfd813fb01aa2dc53591ba749f9c 
  src/server/shell_interface.h dfbc1f077696bdd73039731fd256de656caf9f38 
  src/server/shell_interface.cpp a2d241f5d9cdb03a0526c70f2af046c7ec4dc19f 

Diff: https://git.reviewboard.kde.org/r/125223/diff/


Testing
---

See extended autotest. Also KWin extended to make use of it: All kind of menus 
(QMenu, context menu, dropdown) are positioned correctly now.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125120: support for the slide protocol

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/
---

(Updated Sept. 14, 2015, 2:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for kwin, Plasma and Eike Hein.


Changes
---

Submitted with commit 5a557270565e22284c3e5fd284f0ba7ec27fb22c by Marco Martin 
to branch master.


Repository: kwin


Description
---

take and apply thhe informations from the wayland slide protocol in the sliding 
popups effect


Diffs
-

  autotests/mock_effectshandler.h fba13cd 
  effects.h 97c2f87 
  effects.cpp f104410 
  effects/slidingpopups/slidingpopups.h ac3cf10 
  effects/slidingpopups/slidingpopups.cpp f6d9ec5 
  libkwineffects/kwineffects.h 20a0768 

Diff: https://git.reviewboard.kde.org/r/125120/diff/


Testing
---

slide to appear works, slide out to disappear doesn't.

the second time a popup is opened, kwin crashes and an assert is hit

kwin_wayland: 
/home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: 
KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) 
const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= 
top() && y2 <= bottom()' failed.


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/
---

(Updated Sept. 14, 2015, 3:54 p.m.)


Review request for Plasma.


Changes
---

Force the launcher items to be square + move Model logic to UrlModel.qml


Repository: kdeplasma-addons


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


Diffs (updated)
-

  applets/CMakeLists.txt 2e29bbe 
  applets/quicklaunch/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/Messages.sh PRE-CREATION 
  applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/plugin/qmldir PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125222/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125195: Update the GTK icon cache when installing.

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125195/#review85383
---


>From packagers POV

Shouldn't this be handled by packages at post-install time? For example 
packages already update xdg icon resource cache in post install

I understand that on normal developers machine this post-install stuffs are not 
there. But then this needs to be optional

- Bhushan Shah


On Sept. 14, 2015, 9:40 p.m., Volker Krause wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125195/
> ---
> 
> (Updated Sept. 14, 2015, 9:40 p.m.)
> 
> 
> Review request for Plasma and Olivier Goffart.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Despite the name this is also used by Qt, and considerably speeds up
> icon lookup.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d7ef4044880deb0b753238bc7d7ee0138a216bce 
>   cmake/GtkUpdateIconCache.cmake PRE-CREATION 
>   icons-dark/CMakeLists.txt 9793950db02826c9f31818e30ac91ec9ad93d43f 
>   icons/CMakeLists.txt 814b5ade4e5d185120a47fb72f2d5f531a7e8d41 
> 
> Diff: https://git.reviewboard.kde.org/r/125195/diff/
> 
> 
> Testing
> ---
> 
> Installed with and without existing cache, cache is correctly updated and 
> ends up in the expected place.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/#review85380
---



applets/quicklaunch/package/contents/code/layout.js (line 39)


can you verify that if grid.count changes dinamically, this cols() gets 
re-evaluated immediately?


- Marco Martin


On Sept. 14, 2015, 3:54 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125222/
> ---
> 
> (Updated Sept. 14, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 2e29bbe 
>   applets/quicklaunch/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/Messages.sh PRE-CREATION 
>   applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125222/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125195: Update the GTK icon cache when installing.

[Volker Krause]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125195/
---

(Updated Sept. 14, 2015, 4:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Olivier Goffart.


Changes
---

Submitted with commit 92cd2b667c04e18fd66986e8a42a53c052f5b5a0 by Volker Krause 
to branch master.


Repository: breeze


Description
---

Despite the name this is also used by Qt, and considerably speeds up
icon lookup.


Diffs
-

  CMakeLists.txt d7ef4044880deb0b753238bc7d7ee0138a216bce 
  cmake/GtkUpdateIconCache.cmake PRE-CREATION 
  icons-dark/CMakeLists.txt 9793950db02826c9f31818e30ac91ec9ad93d43f 
  icons/CMakeLists.txt 814b5ade4e5d185120a47fb72f2d5f531a7e8d41 

Diff: https://git.reviewboard.kde.org/r/125195/diff/


Testing
---

Installed with and without existing cache, cache is correctly updated and ends 
up in the expected place.


Thanks,

Volker Krause

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125195: Update the GTK icon cache when installing.

[Bhushan Shah]

> On Sept. 14, 2015, 9:47 p.m., Bhushan Shah wrote:
> > From packagers POV
> > 
> > Shouldn't this be handled by packages at post-install time? For example 
> > packages already update xdg icon resource cache in post install
> > 
> > I understand that on normal developers machine this post-install stuffs are 
> > not there. But then this needs to be optional
> 
> Volker Krause wrote:
> Correct :)
> 
> That's exactly what this patch is doing (the DESTDIR check disables it 
> for packagers, so this is only for developer builds). The packages we checked 
> indeed do this correctly already with post install hooks.

Oops, sorry for not reading properly.. :\

Also that made me discover breeze package in Arch Linux doesn't do that(!)


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125195/#review85383
---


On Sept. 14, 2015, 9:40 p.m., Volker Krause wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125195/
> ---
> 
> (Updated Sept. 14, 2015, 9:40 p.m.)
> 
> 
> Review request for Plasma and Olivier Goffart.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Despite the name this is also used by Qt, and considerably speeds up
> icon lookup.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d7ef4044880deb0b753238bc7d7ee0138a216bce 
>   cmake/GtkUpdateIconCache.cmake PRE-CREATION 
>   icons-dark/CMakeLists.txt 9793950db02826c9f31818e30ac91ec9ad93d43f 
>   icons/CMakeLists.txt 814b5ade4e5d185120a47fb72f2d5f531a7e8d41 
> 
> Diff: https://git.reviewboard.kde.org/r/125195/diff/
> 
> 
> Testing
> ---
> 
> Installed with and without existing cache, cache is correctly updated and 
> ends up in the expected place.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

> On Sept. 14, 2015, 4:09 p.m., Marco Martin wrote:
> > applets/quicklaunch/package/contents/code/layout.js, line 39
> > 
> >
> > can you verify that if grid.count changes dinamically, this cols() gets 
> > re-evaluated immediately?

I'm not really sure how to test it, but I added debug output and got this right 
after adding item to model:

```
(qml) appendUrl: adding item to model
(qml) appendUrl: added item to model
(qml) onCountChanged: grid count changed
(qml) cols: cols called
(qml) cols: cols called
(qml) cols: cols called
(qml) cols: cols called
```


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/#review85380
---


On Sept. 14, 2015, 3:54 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125222/
> ---
> 
> (Updated Sept. 14, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 2e29bbe 
>   applets/quicklaunch/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/Messages.sh PRE-CREATION 
>   applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125222/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

Review request for KDE Frameworks, Plasma and Eike Hein.


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
  src/qmlcontrols/kquickcontrolsaddons/eventforge.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[Marco Martin]

> On Sept. 14, 2015, 4:09 p.m., Marco Martin wrote:
> > applets/quicklaunch/package/contents/code/layout.js, line 39
> > 
> >
> > can you verify that if grid.count changes dinamically, this cols() gets 
> > re-evaluated immediately?
> 
> David Rosca wrote:
> I'm not really sure how to test it, but I added debug output and got this 
> right after adding item to model:
> 
> ```
> (qml) appendUrl: adding item to model
> (qml) appendUrl: added item to model
> (qml) onCountChanged: grid count changed
> (qml) cols: cols called
> (qml) cols: cols called
> (qml) cols: cols called
> (qml) cols: cols called
> ```

yep, it works :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/#review85380
---


On Sept. 14, 2015, 3:54 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125222/
> ---
> 
> (Updated Sept. 14, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 2e29bbe 
>   applets/quicklaunch/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/Messages.sh PRE-CREATION 
>   applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125222/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/#review85391
---

Ship it!


Ship It!

- Marco Martin


On Sept. 14, 2015, 3:54 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125222/
> ---
> 
> (Updated Sept. 14, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 2e29bbe 
>   applets/quicklaunch/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/Messages.sh PRE-CREATION 
>   applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125222/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85410
---



src/qmlcontrols/kquickcontrolsaddons/eventforge.h (line 27)


api docs



src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 34)


x, y aren't always int in QtQuick

especially as you use QPointF later



src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 40)


we're getting win and not using it. Is that deliberate?



src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 51)


why do people need to do this?


This class feels like it's just working round Qt bugs?

Other than that if this is long-term useful, we should do sendPress(flags 
buttons, flags modifiers, x, y) not just whatever AppletAppearance happened to 
need (or make it part of makeGrab() if that's all it's for )

- David Edmundson


On Sept. 14, 2015, 5:17 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 14, 2015, 5:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.h PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125199/#review85342
---


+1 - that also needs to be reflected in ksmserver?

- Martin Gräßlin


On Sept. 12, 2015, 5:36 p.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125199/
> ---
> 
> (Updated Sept. 12, 2015, 5:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG.
> Rationale being that starting with an empty session all the time is
> substantially less aggressive than potentially starting a gazillion
> applications slowing down startup and greeting the user with a
> cluttered desktop.
> 
> 
> Diffs
> -
> 
>   kcms/ksmserver/kcmsmserver.cpp fd8af008281e3fef016000280d670bd3ca54e53f 
>   kcms/ksmserver/smserverconfigdlg.ui 
> 15a4d1cbb681e25f43f1d2cff438297c4412f81f 
> 
> Diff: https://git.reviewboard.kde.org/r/125199/diff/
> 
> 
> Testing
> ---
> 
> installed. wiped ksmserverrc. kcm shows empty session as default choice.
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/
---

(Updated Sept. 14, 2015, 5:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 8cad97ac615b9875a0b65f4b9c797074f65eaf70 by David Rosca 
to branch master.


Repository: kdeplasma-addons


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


Diffs
-

  applets/CMakeLists.txt 2e29bbe 
  applets/quicklaunch/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/Messages.sh PRE-CREATION 
  applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/plugin/qmldir PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125222/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125190: Daemonize the forked kwalletd process.

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125190/
---

(Updated Sept. 14, 2015, 6:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Àlex Fiestas and Martin Klapetek.


Changes
---

Submitted with commit 115ad562baf0cb0534876cbcb705fd9190e290b4 by Weng Xuetian 
to branch master.


Repository: kwallet-pam


Description
---

For example, if desktop is started by sddm,
- for kwalletd5, it will be a subprocess of sddm-helper.
- for kwalletd, there will be zombie subprocess of sddm-helper.

Here we make use of the old trick to fork twice and collect the status of 
intermediate process with waitpid to avoid zombie process. --nofork is used for 
kwalletd case to avoid it fork yet another process.


Diffs
-

  pam_kwallet.c a84585e 

Diff: https://git.reviewboard.kde.org/r/125190/diff/


Testing
---

No more zombie process, kwalletd and kwalletd5 become subprocess of pid 1.


Thanks,

Xuetian Weng

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125198: by default do not restore the previous session on next login

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125198/#review85343
---


+1 - as a note: in openSUSE users were quite angry that we had broken session 
management, they won't be glad about the choice. My personal opinion is (as 
many probably known) that I would drop all session management support as I 
consider it as a relict from pre-suspend times.

- Martin Gräßlin


On Sept. 12, 2015, 5:37 p.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125198/
> ---
> 
> (Updated Sept. 12, 2015, 5:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As requested by the VDG.
> Rationale being that starting with an empty session all the time is
> substantially less aggressive than potentially starting a gazillion
> applications slowing down startup and greeting the user with a
> cluttered desktop.
> 
> 
> Diffs
> -
> 
>   ksmserver/main.cpp 4808a80081c3f4322c0d1b3223fc65bcbfeb26c1 
>   ksmserver/shutdown.cpp 636ae66fcce1d5c39fd697925b9094abc44e4808 
> 
> Diff: https://git.reviewboard.kde.org/r/125198/diff/
> 
> 
> Testing
> ---
> 
> installed. wiped ksmserverrc. multiple logins always result in an empty 
> session.
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


Provided this gets maintained, I'm in favor of this (perhaps in 
kdeplasma-addons instead of a main workspace feature).
Since the behavior of a pure launcher is quite different from both a taskbar 
entry or a dock icon, so some people may prefer that behavior instead (I kindof 
do :p).

- Marco Martin


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125187: Stop requiring Frameworks 5.15

[Armin K.]

> On Sept. 12, 2015, 10:14 a.m., David Edmundson wrote:
> > We depend on git master of frameworks in Plasma master quite often, and our 
> > build instructions for Plasma include frameworks.
> > 
> > Is this causing a problem somewhere?

Well, I just upgraded to newly released frameworks 5.14, which is the required 
dependency for plasma-workspace and the build failed. At that time, frameworks 
weren't bumped to 5.15 and the dep couldn't be increased. I wanted to backport 
the method to my local kconfig build, but David Faure advised me against doing 
so and instead writing this patch since the class is one liner, so the dep 
doesn't need to be bumped again. The patch is trivial, and can be reverted once 
frameworks 5.15 have been released.


- Armin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85240
---


On Sept. 12, 2015, 9:38 a.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> ---
> 
> (Updated Sept. 12, 2015, 9:38 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing 
> plasma-workspace git master to depend on yet unreleased version of KDE 
> Frameworks to build. David Faure has suggested to use fix like this one until 
> at least Frameworks 5.15 have been released.
> 
> I don't have commit access, so someone needs to commit this for me.
> 
> 
> Diffs
> -
> 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
> 
> 
> Testing
> ---
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125187: Stop requiring Frameworks 5.15

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85353
---


-2, a change for a month in the devel branch doesn't make much sense.

- Martin Gräßlin


On Sept. 12, 2015, 11:38 a.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> ---
> 
> (Updated Sept. 12, 2015, 11:38 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing 
> plasma-workspace git master to depend on yet unreleased version of KDE 
> Frameworks to build. David Faure has suggested to use fix like this one until 
> at least Frameworks 5.15 have been released.
> 
> I don't have commit access, so someone needs to commit this for me.
> 
> 
> Diffs
> -
> 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
> 
> 
> Testing
> ---
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote:
> > Provided this gets maintained, I'm in favor of this (perhaps in 
> > kdeplasma-addons instead of a main workspace feature).
> > Since the behavior of a pure launcher is quite different from both a 
> > taskbar entry or a dock icon, so some people may prefer that behavior 
> > instead (I kindof do :p).

Sure, having this in kdeplasma-addons is fine. I made this review against 
plasma-workspace because it originally was there (and still is, not buildable).
I'm willing to maintain it, so should I open a new RR against kdeplasma-addons?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125187: Stop requiring Frameworks 5.15

[David Faure]

> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote:
> > -2, a change for a month in the devel branch doesn't make much sense.

As you want. You're raising the bar for new contributors, who can't work on 
your code using the latest KDE Frameworks release.

You and me might compile everything, but you'll get more contributors if you 
let people work on workspace and apps using a released frameworks (for which 
there are distro packages) than if you require them to compile frameworks 
first. Just like we don't require Qt from git, we shouldn't require KF5 from 
git, I thought this was the general agreement.

If you're worried about the ifdef, just use the two liner version of the code 
forever, I was always a bit dubious about adding a method just for that anyway.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85353
---


On Sept. 12, 2015, 9:38 a.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> ---
> 
> (Updated Sept. 12, 2015, 9:38 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing 
> plasma-workspace git master to depend on yet unreleased version of KDE 
> Frameworks to build. David Faure has suggested to use fix like this one until 
> at least Frameworks 5.15 have been released.
> 
> I don't have commit access, so someone needs to commit this for me.
> 
> 
> Diffs
> -
> 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
> 
> 
> Testing
> ---
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[Marco Martin]

> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote:
> > Provided this gets maintained, I'm in favor of this (perhaps in 
> > kdeplasma-addons instead of a main workspace feature).
> > Since the behavior of a pure launcher is quite different from both a 
> > taskbar entry or a dock icon, so some people may prefer that behavior 
> > instead (I kindof do :p).
> 
> David Rosca wrote:
> Sure, having this in kdeplasma-addons is fine. I made this review against 
> plasma-workspace because it originally was there (and still is, not 
> buildable).
> I'm willing to maintain it, so should I open a new RR against 
> kdeplasma-addons?

yep, that would be great :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85360
---



applets/quicklaunch-qml/package/contents/code/layout.js (line 23)


I guess the spacing here is half because it's used as margins for the items 
instead, so ends up being half+half..
Maybe should be called itemPadding()?

second, those being functions buried in a js file won't be updated in case 
one of the properties chnge..
should they be in  qml file exposed as properties instead?


- Marco Martin


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125178: Don't fade animate icon in plasma tooltips

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125178/#review85354
---

Ship it!


Ship It!

- Marco Martin


On Sept. 11, 2015, 9:06 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125178/
> ---
> 
> (Updated Sept. 11, 2015, 9:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> PlasmaCore.IconItem has a fade animation when changing source.
> This makes the plasma tooltip show old icon and then fade away to new icon 
> when changing tooltip contents. It may be desirable when the tooltip is 
> already visible and is changig its position and content to the new item (even 
> though it still looks weird - text is changed immediately and icon only after 
> a delay), but it is wrong when showing new tooltip.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/private/DefaultToolTip.qml 9c4a2cd 
> 
> Diff: https://git.reviewboard.kde.org/r/125178/diff/
> 
> 
> Testing
> ---
> 
> This weirdness is gone \o/
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125198: by default do not restore the previous session on next login

[Marco Martin]

> On Sept. 14, 2015, 6:05 a.m., Martin Gräßlin wrote:
> > +1 - as a note: in openSUSE users were quite angry that we had broken 
> > session management, they won't be glad about the choice. My personal 
> > opinion is (as many probably known) that I would drop all session 
> > management support as I consider it as a relict from pre-suspend times.

I still tend to prefer it to suspend, starts things kindof where i was but 
slightly more clean slate than suspend (maybe is also due that i still do find 
suspend unreliable and horribly slow with 8 or more GB of ram).
It's fine to disable it by default, but the thing I'm afraid is that it may 
break again without being noticed, and i definitely want to keep it and keep it 
working for the time being.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125198/#review85343
---


On Sept. 12, 2015, 3:37 p.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125198/
> ---
> 
> (Updated Sept. 12, 2015, 3:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As requested by the VDG.
> Rationale being that starting with an empty session all the time is
> substantially less aggressive than potentially starting a gazillion
> applications slowing down startup and greeting the user with a
> cluttered desktop.
> 
> 
> Diffs
> -
> 
>   ksmserver/main.cpp 4808a80081c3f4322c0d1b3223fc65bcbfeb26c1 
>   ksmserver/shutdown.cpp 636ae66fcce1d5c39fd697925b9094abc44e4808 
> 
> Diff: https://git.reviewboard.kde.org/r/125198/diff/
> 
> 
> Testing
> ---
> 
> installed. wiped ksmserverrc. multiple logins always result in an empty 
> session.
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125199/#review85357
---

Ship it!


Ship It!

- Marco Martin


On Sept. 12, 2015, 3:36 p.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125199/
> ---
> 
> (Updated Sept. 12, 2015, 3:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG.
> Rationale being that starting with an empty session all the time is
> substantially less aggressive than potentially starting a gazillion
> applications slowing down startup and greeting the user with a
> cluttered desktop.
> 
> 
> Diffs
> -
> 
>   kcms/ksmserver/kcmsmserver.cpp fd8af008281e3fef016000280d670bd3ca54e53f 
>   kcms/ksmserver/smserverconfigdlg.ui 
> 15a4d1cbb681e25f43f1d2cff438297c4412f81f 
> 
> Diff: https://git.reviewboard.kde.org/r/125199/diff/
> 
> 
> Testing
> ---
> 
> installed. wiped ksmserverrc. kcm shows empty session as default choice.
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125195: Update the GTK icon cache when installing.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125195/#review85358
---

Ship it!


Ship It!

- Marco Martin


On Sept. 12, 2015, 12:45 p.m., Volker Krause wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125195/
> ---
> 
> (Updated Sept. 12, 2015, 12:45 p.m.)
> 
> 
> Review request for Plasma and Olivier Goffart.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Despite the name this is also used by Qt, and considerably speeds up
> icon lookup.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d7ef4044880deb0b753238bc7d7ee0138a216bce 
>   cmake/GtkUpdateIconCache.cmake PRE-CREATION 
>   icons-dark/CMakeLists.txt 9793950db02826c9f31818e30ac91ec9ad93d43f 
>   icons/CMakeLists.txt 814b5ade4e5d185120a47fb72f2d5f531a7e8d41 
> 
> Diff: https://git.reviewboard.kde.org/r/125195/diff/
> 
> 
> Testing
> ---
> 
> Installed with and without existing cache, cache is correctly updated and 
> ends up in the expected place.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125178: Don't fade animate icon in plasma tooltips

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125178/
---

(Updated Sept. 14, 2015, 9:12 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 4b4461d76b7999ce309cd9b35c2e510d8a5aa038 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

PlasmaCore.IconItem has a fade animation when changing source.
This makes the plasma tooltip show old icon and then fade away to new icon when 
changing tooltip contents. It may be desirable when the tooltip is already 
visible and is changig its position and content to the new item (even though it 
still looks weird - text is changed immediately and icon only after a delay), 
but it is wrong when showing new tooltip.


Diffs
-

  src/declarativeimports/core/private/DefaultToolTip.qml 9c4a2cd 

Diff: https://git.reviewboard.kde.org/r/125178/diff/


Testing
---

This weirdness is gone \o/


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

> On Sept. 14, 2015, 9:35 a.m., Marco Martin wrote:
> > applets/quicklaunch-qml/package/contents/code/layout.js, line 23
> > 
> >
> > I guess the spacing here is half because it's used as margins for the 
> > items instead, so ends up being half+half..
> > Maybe should be called itemPadding()?
> > 
> > second, those being functions buried in a js file won't be updated in 
> > case one of the properties chnge..
> > should they be in  qml file exposed as properties instead?

The code seems to work fine though, it correctly resize the launchers when size 
of applet is changed.

I'll rename the spacing() function.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85360
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125187: Stop requiring Frameworks 5.15

[Martin Gräßlin]

> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote:
> > -2, a change for a month in the devel branch doesn't make much sense.
> 
> David Faure wrote:
> As you want. You're raising the bar for new contributors, who can't work 
> on your code using the latest KDE Frameworks release.
> 
> You and me might compile everything, but you'll get more contributors if 
> you let people work on workspace and apps using a released frameworks (for 
> which there are distro packages) than if you require them to compile 
> frameworks first. Just like we don't require Qt from git, we shouldn't 
> require KF5 from git, I thought this was the general agreement.
> 
> If you're worried about the ifdef, just use the two liner version of the 
> code forever, I was always a bit dubious about adding a method just for that 
> anyway.

It's really not that uncommon to depend on latest frameworks in workspace. It's 
common that I add things in KWindowSystem to make use of it in KWin directly. 
Or lately I used lots of new functionalty from KGlobalAccel directly.

Yes it raises the entry level, but it's also rather unlikely that we are able 
to a policy forbidding depending on frameworks master without CI checks.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125187/#review85353
---


On Sept. 12, 2015, 11:38 a.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125187/
> ---
> 
> (Updated Sept. 12, 2015, 11:38 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing 
> plasma-workspace git master to depend on yet unreleased version of KDE 
> Frameworks to build. David Faure has suggested to use fix like this one until 
> at least Frameworks 5.15 have been released.
> 
> I don't have commit access, so someone needs to commit this for me.
> 
> 
> Diffs
> -
> 
>   applets/icon/plugin/icon_p.cpp 97af67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125187/diff/
> 
> 
> Testing
> ---
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel