Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/#review87870
---

Ship it!


Ship It!

- David Edmundson


On Nov. 2, 2015, 7:44 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125892/
> ---
> 
> (Updated Nov. 2, 2015, 7:44 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> To split libksld it is required that it no longer depends upon ksmserver 
> being parent dir.
> 
> I am just unsure about removal of,
> 
> set(ksmserver_xml  
> ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
> and
> qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)
> 
> 
> Diffs
> -
> 
>   ksmserver/config-ksmserver.h.cmake f24e62d 
>   ksmserver/screenlocker/CMakeLists.txt 4213713 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
>   ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
>   ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
>   ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
>   ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 
>   ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
>   ksmserver/screenlocker/kcm/kcm.cpp 0533449 
>   ksmserver/screenlocker/ksldapp.cpp d4c4c83 
>   ksmserver/screenlocker/waylandserver.cpp f8ef665 
> 
> Diff: https://git.reviewboard.kde.org/r/125892/diff/
> 
> 
> Testing
> ---
> 
> builds, installs, tests pass
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

[David Rosca]

> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote:
> > I don't like this change, as it introduces a magic constant for a value 
> > that we completely control our own. (Well, to the degree that we say "a 
> > gridUnit is roughly the height of a line of text". The 1.6 constant looks 
> > weird here, and I'm against adding font specific hacks in, especially since 
> > at that point in the code, we don't even know what the font is.
> > 
> > This is not a structural solution, so -1.
> 
> David Rosca wrote:
> I understand, but what is a structural solution?
> The font metric is clearly wrong for Noto, Oxygen (and certainly some 
> other fonts) and this change is backwards compatible with current code.
> 
> And this is not a font specific hack, this just scales the actual height 
> of M to the expected gridUnit value because gridUnit never was a height of M 
> character (it is like 1.6 * height of M = thus the magic number).
> 
> Sebastian Kügler wrote:
> Well, problems arise as soon as you change the font -- the computation is 
> not based on the default font, but on the currently selected font. The funny 
> thing here is that the Oxygen font is actually the wrong one, as that 
> includes more height than the rendered character, but also some spacing above.
> 
> What is the exact issue you see? I'm still not quite clear on that.
> 
> The bug you're referring to should be fixed by not computing the font 
> manually, but use units.iconSizes.* instead. (I haven't tried, but that's the 
> semantically correct solution.)

> Well, problems arise as soon as you change the font

In the current implementation, yes. Because QFontMetrics::boundingRect(QString 
= "M").height() returns more than just height of M character, and this extra 
size is different for various fonts - it will return different value for 2 
fonts even when the font size (eg. actual height of M character) is the same in 
both.

> The funny thing here is that the Oxygen font is actually the wrong one, as 
> that includes more height than the rendered character, but also some spacing 
> above.

Yes, but that spacing is there for every font, but different and that's exactly 
the whole problem. For DejaVu Sans font it returns value that plays well with 
what we use as gridUnit (roughly M height * 1.6), but for Noto and Oxygen it 
returns just too much (~ * 2). Only QFontMetrics::boundingRect(QChar = 
'M').height() returns the actual M height without any spacing.

> What is the exact issue you see? I'm still not quite clear on that.

My issue is that units.gridUnit and theme.mSize is too big and that leads to 
too big spacing relative to font size. You can see it on screenshots, it shows 
the minimum size of system tray popup (it is calculated as x multiple of 
units.gridUnit). You can see on the first screenshot that it is just too big, 
and the same story is for every other plasma widget.

Maybe I should have posted the whole screen, not just a snip. It looks much 
worse when you see the whole screen and can compare the size to the rest of 
screen (1920x1080).

> The bug you're referring to should be fixed by not computing the font 
> manually, but use units.iconSizes.* instead.

Yes, that would fix the linked bug - size of systemtray icons. But it won't fix 
the general issue mentioned above.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125773/#review87864
---


On Oct. 29, 2015, 6:16 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125773/
> ---
> 
> (Updated Oct. 29, 2015, 6:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 343349
> http://bugs.kde.org/show_bug.cgi?id=343349
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> For some fonts, QFontMetrics::boundingRect(QString) returns too high rect 
> which makes the gridSize too big.
> It now returns correctly the actual height of M character. For backwards 
> compatibility, the value is multiplied with 1.6.
> 
> This affects eg. Noto Sans font that is now default for Plasma 5.5.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/units.h fa2256e 
>   src/declarativeimports/core/units.cpp 4e2adae 
>   src/plasma/theme.cpp c49ad4c 
> 
> Diff: https://git.reviewboard.kde.org/r/125773/diff/
> 
> 
> Testing
> ---
> 
> When switching to Noto Sans font, I noticed that icons in system tray grow to 
> big size so it switched to 1 column in vertical panel. Basically everything 
> in Plasma grow too much (even though the font is visually the same or even 
> smaller than DejaVu Sans that I was using before - same font size 9 was used) 
> - too big spacing in task 

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/
---

(Updated Nov. 2, 2015, 2:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Edmundson and Martin Gräßlin.


Changes
---

Submitted with commit c336055efd3f6648a6e4b9a6c064103f68ad3fa6 by Bhushan Shah 
to branch master.


Repository: plasma-workspace


Description
---

To split libksld it is required that it no longer depends upon ksmserver being 
parent dir.

I am just unsure about removal of,

set(ksmserver_xml  
${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
and
qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)


Diffs
-

  ksmserver/config-ksmserver.h.cmake f24e62d 
  ksmserver/screenlocker/CMakeLists.txt 4213713 
  ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
  ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
  ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
  ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
  ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
  ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 
  ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
  ksmserver/screenlocker/kcm/kcm.cpp 0533449 
  ksmserver/screenlocker/ksldapp.cpp d4c4c83 
  ksmserver/screenlocker/waylandserver.cpp f8ef665 

Diff: https://git.reviewboard.kde.org/r/125892/diff/


Testing
---

builds, installs, tests pass


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Still Unstable!

[Marco Martin]

On Monday 02 November 2015, David Faure wrote:
> On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote:
> > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFOR
> > M=Linux,compiler=gcc/31/ Name: (root) Failed: 1 test(s), Passed: 10
> > test(s), Skipped: 0 test(s), Total: 11 test(s)Failed:
> > TestSuite.dialognativetest
> 
> Is anyone looking into fixing that, before making more commits to
> plasma-framework?

hmm, is the oxygen icon theme not installed anymore in kci?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/#review87872
---

Ship it!


Ship It!

- Marco Martin


On Nov. 2, 2015, 11:49 a.m., Kåre Särs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125006/
> ---
> 
> (Updated Nov. 2, 2015, 11:49 a.m.)
> 
> 
> Review request for Plasma, David Edmundson, Dominik Haumann, and Martin 
> Yrjölä.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
> When activated every cpu gets it's own monitor. The individual monitors try 
> to fit in the space of two bars but when the number of cpus are too high the 
> widht of the cpu monitors grow proportionally.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 3a805b5 
> 
> Diff: https://git.reviewboard.kde.org/r/125006/diff/
> 
> 
> Testing
> ---
> 
> Running it on my own computer ;)
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125887/
---

(Updated Nov. 2, 2015, 1:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 0d2cbb1390c2efcbc68b7d640d98f12cf5399cd1 by David Rosca 
to branch master.


Repository: libksysguard


Description
---

When building without QtWebKitWidgets, the Detailed Memory Information dialog 
is not working (will not be opened at all).
This makes plasma-workspace build without QtWebKitWidgets as it requires 
KSysGuardProcessList from ProcessUI.


Diffs
-

  CMakeLists.txt 14d32d9 
  config-ksysguard.h.cmake d95e1f5 
  processui/CMakeLists.txt 7f87b85 
  processui/scripting.h e8b1e3b 
  processui/scripting.cpp adcb354 

Diff: https://git.reviewboard.kde.org/r/125887/diff/


Testing
---

Builds, clicking on Detailed Memory Information from context menu just does 
nothing.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

[Sebastian Kügler]

> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote:
> > I don't like this change, as it introduces a magic constant for a value 
> > that we completely control our own. (Well, to the degree that we say "a 
> > gridUnit is roughly the height of a line of text". The 1.6 constant looks 
> > weird here, and I'm against adding font specific hacks in, especially since 
> > at that point in the code, we don't even know what the font is.
> > 
> > This is not a structural solution, so -1.
> 
> David Rosca wrote:
> I understand, but what is a structural solution?
> The font metric is clearly wrong for Noto, Oxygen (and certainly some 
> other fonts) and this change is backwards compatible with current code.
> 
> And this is not a font specific hack, this just scales the actual height 
> of M to the expected gridUnit value because gridUnit never was a height of M 
> character (it is like 1.6 * height of M = thus the magic number).

Well, problems arise as soon as you change the font -- the computation is not 
based on the default font, but on the currently selected font. The funny thing 
here is that the Oxygen font is actually the wrong one, as that includes more 
height than the rendered character, but also some spacing above.

What is the exact issue you see? I'm still not quite clear on that.

The bug you're referring to should be fixed by not computing the font manually, 
but use units.iconSizes.* instead. (I haven't tried, but that's the 
semantically correct solution.)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125773/#review87864
---


On Oct. 29, 2015, 6:16 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125773/
> ---
> 
> (Updated Oct. 29, 2015, 6:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 343349
> http://bugs.kde.org/show_bug.cgi?id=343349
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> For some fonts, QFontMetrics::boundingRect(QString) returns too high rect 
> which makes the gridSize too big.
> It now returns correctly the actual height of M character. For backwards 
> compatibility, the value is multiplied with 1.6.
> 
> This affects eg. Noto Sans font that is now default for Plasma 5.5.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/units.h fa2256e 
>   src/declarativeimports/core/units.cpp 4e2adae 
>   src/plasma/theme.cpp c49ad4c 
> 
> Diff: https://git.reviewboard.kde.org/r/125773/diff/
> 
> 
> Testing
> ---
> 
> When switching to Noto Sans font, I noticed that icons in system tray grow to 
> big size so it switched to 1 column in vertical panel. Basically everything 
> in Plasma grow too much (even though the font is visually the same or even 
> smaller than DejaVu Sans that I was using before - same font size 9 was used) 
> - too big spacing in task manager, too big popups (application menu, system 
> tray popups), etc ...
> 
> This fixes the issue. This may also fix BUG 343349
> 
> 
> File Attachments
> 
> 
> systray + popup before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d409b391-e35e-451f-bb5b-aa42e7eb2bf3__before.png
> after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/445009bc-a4a8-4998-8e82-996a0a4e33fb__after.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125921: Don't rely graphic objects in panel script engine

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125921/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

The basic design of Plasma is that scripts and and the shell (in theory)
manipulate a tree of basic applet geometry and configs.

Plasmashell then reacts to those changes and displays them visually with
a distinct separation between the layout and UI.

Panel's scriptengine seemed to do away with all, and try and manipulate the 
graphic object directly..which might not exist and that leads to complex code.

This changes it to read/write from the same config object as
PanelView will use. More akin to how the script engine for applet and 
contiainment work.

If there's a view for this panel, we update immediately, otherwise it'll just 
get loaded when it's needed. PanelView::reload() has the error checking/bounds 
management so no point duplicating that.

Idea is to fix the same bug as https://git.reviewboard.kde.org/r/125920/ but 
also clean up a lot of the code which I thought had grown a bit complex. 

Bit too big to backport though. Might be Plasma 5.6 material at this point.


Diffs
-

  shell/panelview.cpp 2a80a65a9bbcaaad82a52e28525c73e816046a3d 
  shell/scripting/panel.h f7279100a7c79f2f15917b88d8199573a379cb7d 
  shell/scripting/panel.cpp bd78fc9b9dd9577012600b2d41e3822e95ae 

Diff: https://git.reviewboard.kde.org/r/125921/diff/


Testing
---

Modified my layout.js to set min, max sizes as well as alignment and offset 
which were previously broken.

Once loaded opened the interactive editor and run stuff like:
panel = panelById(1);
panel.alignment = "center"
panel.height = 40

Seems to work as before


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D409: new mobile components

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
mart marked 4 inline comments as done.
Closed by commit rPLASMAMOBILEd3b28119a79f: new mobile components (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D409?vs=1110=1141#toc

REPOSITORY
  rPLASMAMOBILE plasma-mobile

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D409?vs=1110=1141

REVISION DETAIL
  https://phabricator.kde.org/D409

AFFECTED FILES
  components/mobilecomponents/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, Plasma: Mobile
Cc: davidedmundson, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[kio-extras] [Bug 349795] nfs kio produces "Internal error in server RPC error 3"

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349795

quentin.de...@gmail.com changed:

   What|Removed |Added

   Severity|normal  |crash
Version|5.3.1   |5.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

[Kåre Särs]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/
---

(Updated Nov. 3, 2015, 6:50 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Edmundson, Dominik Haumann, and Martin Yrjölä.


Changes
---

Submitted with commit 1c0cf92208b8a7589e1d6103f3fd5640840509c8 by Kåre Särs to 
branch master.


Repository: kdeplasma-addons


Description
---

When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
When activated every cpu gets it's own monitor. The individual monitors try to 
fit in the space of two bars but when the number of cpus are too high the widht 
of the cpu monitors grow proportionally.


Diffs
-

  applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 3a805b5 

Diff: https://git.reviewboard.kde.org/r/125006/diff/


Testing
---

Running it on my own computer ;)


Thanks,

Kåre Särs

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/#review87848
---


looks good to me. Not giving a ship it as I want to have at least one more 
person to review it.


ksmserver/screenlocker/CMakeLists.txt (line 7)


you dropped the debug area? That's fine but should also go into the cleanup 
commit.


- Martin Gräßlin


On Nov. 2, 2015, 8:44 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125892/
> ---
> 
> (Updated Nov. 2, 2015, 8:44 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> To split libksld it is required that it no longer depends upon ksmserver 
> being parent dir.
> 
> I am just unsure about removal of,
> 
> set(ksmserver_xml  
> ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
> and
> qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)
> 
> 
> Diffs
> -
> 
>   ksmserver/config-ksmserver.h.cmake f24e62d 
>   ksmserver/screenlocker/CMakeLists.txt 4213713 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
>   ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
>   ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
>   ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
>   ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 
>   ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
>   ksmserver/screenlocker/kcm/kcm.cpp 0533449 
>   ksmserver/screenlocker/ksldapp.cpp d4c4c83 
>   ksmserver/screenlocker/waylandserver.cpp f8ef665 
> 
> Diff: https://git.reviewboard.kde.org/r/125892/diff/
> 
> 
> Testing
> ---
> 
> builds, installs, tests pass
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125898/#review87850
---


Thanks for looking into it! I'm not experienced enough to do an actual review, 
though ;-)

- Martin Gräßlin


On Nov. 1, 2015, 2:35 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125898/
> ---
> 
> (Updated Nov. 1, 2015, 2:35 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 354602
> https://bugs.kde.org/show_bug.cgi?id=354602
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This avoids the buttons from blending in with the text making it look ugly.
> 
> This could allow us to use flat ToolButtons again since four round things in 
> a row look strange imho.
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 
> 
> Diff: https://git.reviewboard.kde.org/r/125898/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> Hovered item
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D409: new mobile components

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAMOBILE plasma-mobile

REVISION DETAIL
  https://phabricator.kde.org/D409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, Plasma: Mobile
Cc: davidedmundson, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125817: Add plugin system for Calendar events

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125817/
---

(Updated Nov. 2, 2015, 6:35 p.m.)


Review request for KDE Frameworks, Plasma and Daniel Vrátil.


Changes
---

* Fixed David's issues
* Sorted the events by their starttime


Repository: plasma-framework


Description
---

This adds a simple plugin interface that can be subclassed
and provide events integration with Plasma Calendar applet.

It's asynchronous and I've kept it deliberately simple.
For now the Calendar tells the plugins which date range
is being displayed, the plugins load the data and then
emit the dataReady() signal containing the events.

The events are stored in a multihash for quick access
by the Calendar's agenda part but also for overall
easy-to-use (eg. in teh model data()).

The event data is stored in EventData class, which has
a pretty self-explanatory members, except perhaps the
"isMinor" one. The intention with this is to support
namedays, where in some countries the calendars have
different name every day. This is just a minor holiday
and as such should not mark the calendar grid, otherwise
the whole grid would be in a different color.

Putting the interface here might raise the question of
depending on plasma-framework, but plugins provided by
KDE can go to plasma-workspace and other 3rd party ones
would just have to live with it. I don't think it will
be a problem but if it turns out it is, we can rethink
the placement.


Diffs (updated)
-

  src/declarativeimports/calendar/CMakeLists.txt 40ead91 
  src/declarativeimports/calendar/calendarplugin.cpp bafe80c 
  src/declarativeimports/calendar/daysmodel.h a5bdac9 
  src/declarativeimports/calendar/daysmodel.cpp 2d059a8 
  src/declarativeimports/calendar/eventdatadecorator.h PRE-CREATION 
  src/declarativeimports/calendar/eventdatadecorator.cpp PRE-CREATION 
  src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt 
PRE-CREATION 
  
src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in
 PRE-CREATION 
  
src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h
 PRE-CREATION 
  
src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp
 PRE-CREATION 
  src/declarativeimports/calendar/plasmacalendarintegration/eventdata_p.cpp 
PRE-CREATION 
  
src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h
 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125817/diff/


Testing
---

I have a simple KHolidays based plugin written (patch should be up later today)
and patches in the Calendar applet.

Everything works as expected:
* the days are marked as containing an event
* the agenda part displays details of that event (name)


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125817: Add plugin system for Calendar events

[Martin Klapetek]

> On Oct. 31, 2015, 2:08 a.m., David Edmundson wrote:
> > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h,
> >  line 202
> > 
> >
> > rather than this much docs, would it make sense to have a protected 
> > method that takes a list, then in this class you turn that into the hash?
> 
> Martin Klapetek wrote:
> Well if the only reason to do that is because "there's too much to read", 
> then no :P

Also, " I think the current way is more effective, because it allows 
the plugin to populate the hash with all recurring events. Otherwise the plugin 
would have to keep the recurrences in a temp hash and then the plugin system 
would do the math again"


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125817/#review87768
---


On Oct. 28, 2015, 6:18 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125817/
> ---
> 
> (Updated Oct. 28, 2015, 6:18 p.m.)
> 
> 
> Review request for Plasma and Daniel Vrátil.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This adds a simple plugin interface that can be subclassed
> and provide events integration with Plasma Calendar applet.
> 
> It's asynchronous and I've kept it deliberately simple.
> For now the Calendar tells the plugins which date range
> is being displayed, the plugins load the data and then
> emit the dataReady() signal containing the events.
> 
> The events are stored in a multihash for quick access
> by the Calendar's agenda part but also for overall
> easy-to-use (eg. in teh model data()).
> 
> The event data is stored in EventData class, which has
> a pretty self-explanatory members, except perhaps the
> "isMinor" one. The intention with this is to support
> namedays, where in some countries the calendars have
> different name every day. This is just a minor holiday
> and as such should not mark the calendar grid, otherwise
> the whole grid would be in a different color.
> 
> Putting the interface here might raise the question of
> depending on plasma-framework, but plugins provided by
> KDE can go to plasma-workspace and other 3rd party ones
> would just have to live with it. I don't think it will
> be a problem but if it turns out it is, we can rethink
> the placement.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/CMakeLists.txt 40ead91 
>   src/declarativeimports/calendar/calendarplugin.cpp bafe80c 
>   src/declarativeimports/calendar/daysmodel.h a5bdac9 
>   src/declarativeimports/calendar/daysmodel.cpp 2d059a8 
>   src/declarativeimports/calendar/eventdatadecorator.h PRE-CREATION 
>   src/declarativeimports/calendar/eventdatadecorator.cpp PRE-CREATION 
>   src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt 
> PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in
>  PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h
>  PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp
>  PRE-CREATION 
>   src/declarativeimports/calendar/plasmacalendarintegration/eventdata_p.cpp 
> PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h
>  PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125817/diff/
> 
> 
> Testing
> ---
> 
> I have a simple KHolidays based plugin written (patch should be up later 
> today)
> and patches in the Calendar applet.
> 
> Everything works as expected:
> * the days are marked as containing an event
> * the agenda part displays details of that event (name)
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125920: Fix setting alignment for panel scriptengine even if PanelView is not created yet

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125920/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Uses the same approach as in 11483d2985c9b3c8314f2c6d8c8d7ed30a4ad0be
caching the value in a property


Diffs
-

  shell/panelview.cpp 2a80a65a9bbcaaad82a52e28525c73e816046a3d 
  shell/scripting/panel.cpp bd78fc9b9dd9577012600b2d41e3822e95ae 

Diff: https://git.reviewboard.kde.org/r/125920/diff/


Testing
---

edited my layout.js file

wiped config, restarted plasma

Gazed with awe as my panel was aligned in the middle


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125921: Don't rely graphic objects in panel script engine

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125921/#review87882
---


good direction, just a little point below


shell/scripting/panel.cpp (line 124)


I think i would feel better if this was shared with panelview, to save 
possible very weird bugs (i wonder if it could be made static from panelview)


- Marco Martin


On Nov. 2, 2015, 4:26 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125921/
> ---
> 
> (Updated Nov. 2, 2015, 4:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The basic design of Plasma is that scripts and and the shell (in theory)
> manipulate a tree of basic applet geometry and configs.
> 
> Plasmashell then reacts to those changes and displays them visually with
> a distinct separation between the layout and UI.
> 
> Panel's scriptengine seemed to do away with all, and try and manipulate the 
> graphic object directly..which might not exist and that leads to complex code.
> 
> This changes it to read/write from the same config object as
> PanelView will use. More akin to how the script engine for applet and 
> contiainment work.
> 
> If there's a view for this panel, we update immediately, otherwise it'll just 
> get loaded when it's needed. PanelView::reload() has the error 
> checking/bounds management so no point duplicating that.
> 
> Idea is to fix the same bug as https://git.reviewboard.kde.org/r/125920/ but 
> also clean up a lot of the code which I thought had grown a bit complex. 
> 
> Bit too big to backport though. Might be Plasma 5.6 material at this point.
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 2a80a65a9bbcaaad82a52e28525c73e816046a3d 
>   shell/scripting/panel.h f7279100a7c79f2f15917b88d8199573a379cb7d 
>   shell/scripting/panel.cpp bd78fc9b9dd9577012600b2d41e3822e95ae 
> 
> Diff: https://git.reviewboard.kde.org/r/125921/diff/
> 
> 
> Testing
> ---
> 
> Modified my layout.js to set min, max sizes as well as alignment and offset 
> which were previously broken.
> 
> Once loaded opened the interactive editor and run stuff like:
> panel = panelById(1);
> panel.alignment = "center"
> panel.height = 40
> 
> Seems to work as before
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125817: Add plugin system for Calendar events

[Martin Klapetek]

> On Oct. 31, 2015, 2:08 a.m., David Edmundson wrote:
> > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h,
> >  line 180
> > 
> >
> > I'd add a dpointer here, even though you don't use it yet.

This should be just the interface declaration though, this shouldn't contain 
any implementation itself, so imo no need for a dpointer as it should never 
need to do anything.


> On Oct. 31, 2015, 2:08 a.m., David Edmundson wrote:
> > src/declarativeimports/calendar/daysmodel.h, line 44
> > 
> >
> > I think we need some sort of
> > 
> > QStringList availablePlugins()
> > 
> > setPlugins( QStringList plugins);
> 
> Martin Klapetek wrote:
> What for?
> 
> David Edmundson wrote:
> Plasma 4 had an option to "show events". mostly people complaining about 
> akonadi starting up when they didn't actually use korganiser

Ah you are right, I think I'll make it part of the patch that adds the 
configuration though, if that's ok.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125817/#review87768
---


On Oct. 28, 2015, 6:18 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125817/
> ---
> 
> (Updated Oct. 28, 2015, 6:18 p.m.)
> 
> 
> Review request for Plasma and Daniel Vrátil.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This adds a simple plugin interface that can be subclassed
> and provide events integration with Plasma Calendar applet.
> 
> It's asynchronous and I've kept it deliberately simple.
> For now the Calendar tells the plugins which date range
> is being displayed, the plugins load the data and then
> emit the dataReady() signal containing the events.
> 
> The events are stored in a multihash for quick access
> by the Calendar's agenda part but also for overall
> easy-to-use (eg. in teh model data()).
> 
> The event data is stored in EventData class, which has
> a pretty self-explanatory members, except perhaps the
> "isMinor" one. The intention with this is to support
> namedays, where in some countries the calendars have
> different name every day. This is just a minor holiday
> and as such should not mark the calendar grid, otherwise
> the whole grid would be in a different color.
> 
> Putting the interface here might raise the question of
> depending on plasma-framework, but plugins provided by
> KDE can go to plasma-workspace and other 3rd party ones
> would just have to live with it. I don't think it will
> be a problem but if it turns out it is, we can rethink
> the placement.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/CMakeLists.txt 40ead91 
>   src/declarativeimports/calendar/calendarplugin.cpp bafe80c 
>   src/declarativeimports/calendar/daysmodel.h a5bdac9 
>   src/declarativeimports/calendar/daysmodel.cpp 2d059a8 
>   src/declarativeimports/calendar/eventdatadecorator.h PRE-CREATION 
>   src/declarativeimports/calendar/eventdatadecorator.cpp PRE-CREATION 
>   src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt 
> PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in
>  PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h
>  PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp
>  PRE-CREATION 
>   src/declarativeimports/calendar/plasmacalendarintegration/eventdata_p.cpp 
> PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h
>  PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125817/diff/
> 
> 
> Testing
> ---
> 
> I have a simple KHolidays based plugin written (patch should be up later 
> today)
> and patches in the Calendar applet.
> 
> Everything works as expected:
> * the days are marked as containing an event
> * the agenda part displays details of that event (name)
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125920: Fix setting alignment for panel scriptengine even if PanelView is not created yet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125920/#review87881
---

Ship it!


Ship It!

- Marco Martin


On Nov. 2, 2015, 4:13 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125920/
> ---
> 
> (Updated Nov. 2, 2015, 4:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Uses the same approach as in 11483d2985c9b3c8314f2c6d8c8d7ed30a4ad0be
> caching the value in a property
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 2a80a65a9bbcaaad82a52e28525c73e816046a3d 
>   shell/scripting/panel.cpp bd78fc9b9dd9577012600b2d41e3822e95ae 
> 
> Diff: https://git.reviewboard.kde.org/r/125920/diff/
> 
> 
> Testing
> ---
> 
> edited my layout.js file
> 
> wiped config, restarted plasma
> 
> Gazed with awe as my panel was aligned in the middle
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125920: Fix setting alignment for panel scriptengine even if PanelView is not created yet

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125920/
---

(Updated Nov. 2, 2015, 4:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 331a0e79036a44581eab78140593e18a6de6bba1 by David 
Edmundson to branch Plasma/5.4.


Repository: plasma-workspace


Description
---

Uses the same approach as in 11483d2985c9b3c8314f2c6d8c8d7ed30a4ad0be
caching the value in a property


Diffs
-

  shell/panelview.cpp 2a80a65a9bbcaaad82a52e28525c73e816046a3d 
  shell/scripting/panel.cpp bd78fc9b9dd9577012600b2d41e3822e95ae 

Diff: https://git.reviewboard.kde.org/r/125920/diff/


Testing
---

edited my layout.js file

wiped config, restarted plasma

Gazed with awe as my panel was aligned in the middle


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125926: [Image Wallpaper] Take into account orientation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125926/#review87889
---


Damn, of course, it should take the non-fitting orientation as a last resort if 
it actually is a vertical photograph...

- Kai Uwe Broulik


On Nov. 2, 2015, 9:27 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125926/
> ---
> 
> (Updated Nov. 2, 2015, 9:27 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 352555
> https://bugs.kde.org/show_bug.cgi?id=352555
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The distance method only cares for a match in terms of pixel numbers, not the 
> actual orientation.
> 
> 
> Diffs
> -
> 
>   wallpapers/image/image.cpp 1b8d2dd 
> 
> Diff: https://git.reviewboard.kde.org/r/125926/diff/
> 
> 
> Testing
> ---
> 
> Placed a 1440x2560 picture in my image package, it used to get picked and 
> stretched, not it properly takes the 2560x1440 image consistently, or if not 
> present, fall back to a different resolution image.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125926: [Image Wallpaper] Take into account orientation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125926/
---

Review request for Plasma.


Bugs: 352555
https://bugs.kde.org/show_bug.cgi?id=352555


Repository: plasma-workspace


Description
---

The distance method only cares for a match in terms of pixel numbers, not the 
actual orientation.


Diffs
-

  wallpapers/image/image.cpp 1b8d2dd 

Diff: https://git.reviewboard.kde.org/r/125926/diff/


Testing
---

Placed a 1440x2560 picture in my image package, it used to get picked and 
stretched, not it properly takes the 2560x1440 image consistently, or if not 
present, fall back to a different resolution image.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125898/#review87859
---



applets/clipboard/contents/ui/ClipboardItemDelegate.qml (line 67)


Can't you use a LinearGradient that can be rotated?


- Marco Martin


On Nov. 1, 2015, 1:35 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125898/
> ---
> 
> (Updated Nov. 1, 2015, 1:35 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 354602
> https://bugs.kde.org/show_bug.cgi?id=354602
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This avoids the buttons from blending in with the text making it look ugly.
> 
> This could allow us to use flat ToolButtons again since four round things in 
> a row look strange imho.
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 
> 
> Diff: https://git.reviewboard.kde.org/r/125898/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> Hovered item
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125887/
---

(Updated Nov. 2, 2015, 10:11 a.m.)


Review request for Plasma.


Changes
---

Changed to #cmakedefine01 + added No QtWebKitWidgets dialog


Repository: libksysguard


Description
---

When building without QtWebKitWidgets, the Detailed Memory Information dialog 
is not working (will not be opened at all).
This makes plasma-workspace build without QtWebKitWidgets as it requires 
KSysGuardProcessList from ProcessUI.


Diffs (updated)
-

  CMakeLists.txt 14d32d9 
  config-ksysguard.h.cmake d95e1f5 
  processui/CMakeLists.txt 7f87b85 
  processui/scripting.h e8b1e3b 
  processui/scripting.cpp adcb354 

Diff: https://git.reviewboard.kde.org/r/125887/diff/


Testing
---

Builds, clicking on Detailed Memory Information from context menu just does 
nothing.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125886: drkonqi: Drop KF5::WebKit dependency

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125886/
---

(Updated Nov. 2, 2015, 9:42 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 6aedc9534f76f9fb0d5d9560f81a704bda1e8df7 by David Rosca 
to branch master.


Repository: plasma-workspace


Description
---

Replace KWebView with QTextBrowser in unhandled bugzilla error dialog.
KWebView is not used to load a page here, it is just used to display HTML with 
setHtml (without baseUrl) so any external URLs (stylesheets, images, ...) are 
not resolved.
Replacing it with QTextBrowser should provide similar rendering.


Diffs
-

  CMakeLists.txt 50091ea 
  drkonqi/CMakeLists.txt 339b475 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp b6beea3 

Diff: https://git.reviewboard.kde.org/r/125886/diff/


Testing
---

Made sure it builds, no idea how to trigger the dialog.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux, All, gcc - Build # 116 - Still Unstable!

[Albert Astals Cid]

El Monday 02 November 2015, a les 14:56:15, Marco Martin va escriure:
> On Monday 02 November 2015, David Faure wrote:
> > On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote:
> > > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFO
> > > R
> > > M=Linux,compiler=gcc/31/ Name: (root) Failed: 1 test(s), Passed: 10
> > > test(s), Skipped: 0 test(s), Total: 11 test(s)Failed:
> > > TestSuite.dialognativetest
> > 
> > Is anyone looking into fixing that, before making more commits to
> > plasma-framework?
> 
> hmm, is the oxygen icon theme not installed anymore in kci?

oxygen is not a dependency of frameworksintegration so i guess no.

How does oxygen being installed influence the wheelScrollLines though?

Cheers,
  Albert
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125887/#review87862
---

Ship it!


Ship It!

- Martin Gräßlin


On Nov. 2, 2015, 11:11 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125887/
> ---
> 
> (Updated Nov. 2, 2015, 11:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> ---
> 
> When building without QtWebKitWidgets, the Detailed Memory Information dialog 
> is not working (will not be opened at all).
> This makes plasma-workspace build without QtWebKitWidgets as it requires 
> KSysGuardProcessList from ProcessUI.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 14d32d9 
>   config-ksysguard.h.cmake d95e1f5 
>   processui/CMakeLists.txt 7f87b85 
>   processui/scripting.h e8b1e3b 
>   processui/scripting.cpp adcb354 
> 
> Diff: https://git.reviewboard.kde.org/r/125887/diff/
> 
> 
> Testing
> ---
> 
> Builds, clicking on Detailed Memory Information from context menu just does 
> nothing.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

minutes monday plasma hangout

[Sebastian Kügler]

Present: sebas, bhushan, david, jens, marco, martin g, ovidiu

Date: 2 Nov, 2015

Bhushan:
* working on splitting screenlocker
* https://git.reviewboard.kde.org/r/125892/
* https://quickgit.kde.org/?p=scratch%2Fbshah%2Fscreenlocker.git
* will result in libksld, which can be linked from kwin_wayland
* mobile image generation blocked by not yet having Qt 5.5
* doing wily and amd64 based plasma mobile iso

d_ed:
* Fixed a bug in kauth blocking
* Fixed a bug in autohide
* Fixed a bug in drkonqui
* Updated SNI proxy RR
* Tried fixing locale in Qt (where we have translated month names if LC_TIME   
  is set). https://codereview.qt-project.org/#/c/139295/

notmart:
* little bugfix on highdpi widget explorer
* monday merged the new plasma theme there are still some problems will fix 
  today
* adressed some comments in the mobile components https://phabricator.kde.org/ 
  D409
* api minimize effect in kwayland

Martin (G):
* Munich organises a hackfest in November, invites Plasma team
* Proposed release cycle thoughts to release-team list, interesting discussion 
ongoing
* Discussed issues with Intel drivers with Martin Peres (from Intel)
* Fixed odroid / mali issue: https://git.reviewboard.kde.org/r/125865/

Ovidiu:
* integrated more translations

sebas:
* working on hopefully final implementation bits of screen management protocol

-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

[Kåre Särs]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/
---

(Updated Nov. 2, 2015, 11:49 a.m.)


Review request for Plasma, David Edmundson, Dominik Haumann, and Martin Yrjölä.


Changes
---

Add Layout.minimumWidth to prevent overlapping, remove a hardcoded pixelWidth, 
rebase on master and minor code cleanup


Repository: kdeplasma-addons


Description
---

When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
When activated every cpu gets it's own monitor. The individual monitors try to 
fit in the space of two bars but when the number of cpus are too high the widht 
of the cpu monitors grow proportionally.


Diffs (updated)
-

  applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 3a805b5 

Diff: https://git.reviewboard.kde.org/r/125006/diff/


Testing
---

Running it on my own computer ;)


Thanks,

Kåre Särs

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: minutes monday plasma hangout

[Kai Uwe Broulik]

Hi,

- merged new session model and user switcher plasmoid, migrated lock screen to 
it (thanks Bhushan for merging)
- not sure if new user switcher makes it for 5 Nov
- various bug fixes (back mouse button support in Kickoff, changing applet 
visibility in systray)

I also fixed notification popup continuously expanding with 
QT_DEVICE_PIXEL_RATIO > 1, so I was wondering what's still missing to enable it 
for plasmashell again. From what I can tell panelcontroller more menu still 
expands and some blur / contrast regions are off but font rendering looks fine 
here (Qt 5.4.2 and 5.5.1) as well as panel struts are correct.

Gesendet von meinem BlackBerry 10-Smartphone.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 351875] Some drop-down menus don't inherit the correct color value from Breeze-Dark theme.

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=351875

k...@binarycharly.com changed:

   What|Removed |Added

 CC||k...@binarycharly.com

--- Comment #7 from k...@binarycharly.com ---
I can confirm that this bug is still present in plasma 5.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125927: Unbox QJSValue in config property map

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125927/
---

Review request for Plasma.


Repository: kdeclarative


Description
---

Currently if one saves a QJSValue into the property map we save the
correct real value, but the propertymap still holds the data as a
QJSValue when retrieved.

This causes an error if a property map is moved between engines as a
QJSValue can only be in one. This can be seen in the system tray where
you can't configure entries on the first load.

By using the updateValue we can intercept updates QML and the property
map making sure only real datatypes are stored in our map.


Diffs
-

  src/kdeclarative/configpropertymap.h 21a10fcb56c2929fcb43a3387566c101aa16e90f 
  src/kdeclarative/configpropertymap.cpp 
93c49a3b1f5929a85754e30704821a36717d4f5d 

Diff: https://git.reviewboard.kde.org/r/125927/diff/


Testing
---

plasmoidviewer -a org.kde.plasma.systemtray - can conifgure entries \o/


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125927: Unbox QJSValue in config property map

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125927/#review87896
---

Ship it!


Makes sense to me.

- Aleix Pol Gonzalez


On Nov. 3, 2015, 2:14 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125927/
> ---
> 
> (Updated Nov. 3, 2015, 2:14 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Currently if one saves a QJSValue into the property map we save the
> correct real value, but the propertymap still holds the data as a
> QJSValue when retrieved.
> 
> This causes an error if a property map is moved between engines as a
> QJSValue can only be in one. This can be seen in the system tray where
> you can't configure entries on the first load.
> 
> By using the updateValue we can intercept updates QML and the property
> map making sure only real datatypes are stored in our map.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/configpropertymap.h 
> 21a10fcb56c2929fcb43a3387566c101aa16e90f 
>   src/kdeclarative/configpropertymap.cpp 
> 93c49a3b1f5929a85754e30704821a36717d4f5d 
> 
> Diff: https://git.reviewboard.kde.org/r/125927/diff/
> 
> 
> Testing
> ---
> 
> plasmoidviewer -a org.kde.plasma.systemtray - can conifgure entries \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124536: Expose immutable config options in ConfigPropertyMap

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124536/#review87895
---



src/kdeclarative/configpropertymap.cpp (line 45)


I know how to make the q_invokable work.

see the second constructor for derived classe

https://doc.qt.io/archives/qt-5.3/qqmlpropertymap.html#QQmlPropertyMap-2

it means when QQmlPropertyMap overrides the moc system it will link in our 
properties and slots and such


- David Edmundson


On July 30, 2015, 8:10 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124536/
> ---
> 
> (Updated July 30, 2015, 8:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This exposes a hash of immutable config options through the "immutables" 
> property. I tried adding a Q_INVOKABLE which would be much nicer but me and 
> Dan tried everything but couldn't make it work.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/configpropertymap.cpp 93c49a3 
> 
> Diff: https://git.reviewboard.kde.org/r/124536/diff/
> 
> 
> Testing
> ---
> 
> Works, I can not grey out immutable config options in Plasma
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux, All, gcc - Build # 116 - Still Unstable!

[David Faure]

On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote:
> https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
> Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), 
> Total: 11 test(s)Failed: TestSuite.dialognativetest

Is anyone looking into fixing that, before making more commits to 
plasma-framework?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: minutes monday plasma hangout

[Martin Graesslin]

On Monday, November 2, 2015 12:54:17 PM CET Kai Uwe Broulik wrote:
> Hi,
> 
> - merged new session model and user switcher plasmoid, migrated lock screen
> to it (thanks Bhushan for merging) - not sure if new user switcher makes it
> for 5 Nov

please note that Nov 5 is not the feature freeze, but repo freeze. As long as 
you want to put code into existing repos you have time till 19th.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125773/#review87864
---


I don't like this change, as it introduces a magic constant for a value that we 
completely control our own. (Well, to the degree that we say "a gridUnit is 
roughly the height of a line of text". The 1.6 constant looks weird here, and 
I'm against adding font specific hacks in, especially since at that point in 
the code, we don't even know what the font is.

This is not a structural solution, so -1.

- Sebastian Kügler


On Oct. 29, 2015, 6:16 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125773/
> ---
> 
> (Updated Oct. 29, 2015, 6:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 343349
> http://bugs.kde.org/show_bug.cgi?id=343349
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> For some fonts, QFontMetrics::boundingRect(QString) returns too high rect 
> which makes the gridSize too big.
> It now returns correctly the actual height of M character. For backwards 
> compatibility, the value is multiplied with 1.6.
> 
> This affects eg. Noto Sans font that is now default for Plasma 5.5.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/units.h fa2256e 
>   src/declarativeimports/core/units.cpp 4e2adae 
>   src/plasma/theme.cpp c49ad4c 
> 
> Diff: https://git.reviewboard.kde.org/r/125773/diff/
> 
> 
> Testing
> ---
> 
> When switching to Noto Sans font, I noticed that icons in system tray grow to 
> big size so it switched to 1 column in vertical panel. Basically everything 
> in Plasma grow too much (even though the font is visually the same or even 
> smaller than DejaVu Sans that I was using before - same font size 9 was used) 
> - too big spacing in task manager, too big popups (application menu, system 
> tray popups), etc ...
> 
> This fixes the issue. This may also fix BUG 343349
> 
> 
> File Attachments
> 
> 
> systray + popup before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d409b391-e35e-451f-bb5b-aa42e7eb2bf3__before.png
> after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/445009bc-a4a8-4998-8e82-996a0a4e33fb__after.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

[David Rosca]

> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote:
> > I don't like this change, as it introduces a magic constant for a value 
> > that we completely control our own. (Well, to the degree that we say "a 
> > gridUnit is roughly the height of a line of text". The 1.6 constant looks 
> > weird here, and I'm against adding font specific hacks in, especially since 
> > at that point in the code, we don't even know what the font is.
> > 
> > This is not a structural solution, so -1.

I understand, but what is a structural solution?
The font metric is clearly wrong for Noto, Oxygen (and certainly some other 
fonts) and this change is backwards compatible with current code.

And this is not a font specific hack, this just scales the actual height of M 
to the expected gridUnit value because gridUnit never was a height of M 
character (it is like 1.6 * height of M = thus the magic number).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125773/#review87864
---


On Oct. 29, 2015, 6:16 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125773/
> ---
> 
> (Updated Oct. 29, 2015, 6:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 343349
> http://bugs.kde.org/show_bug.cgi?id=343349
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> For some fonts, QFontMetrics::boundingRect(QString) returns too high rect 
> which makes the gridSize too big.
> It now returns correctly the actual height of M character. For backwards 
> compatibility, the value is multiplied with 1.6.
> 
> This affects eg. Noto Sans font that is now default for Plasma 5.5.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/units.h fa2256e 
>   src/declarativeimports/core/units.cpp 4e2adae 
>   src/plasma/theme.cpp c49ad4c 
> 
> Diff: https://git.reviewboard.kde.org/r/125773/diff/
> 
> 
> Testing
> ---
> 
> When switching to Noto Sans font, I noticed that icons in system tray grow to 
> big size so it switched to 1 column in vertical panel. Basically everything 
> in Plasma grow too much (even though the font is visually the same or even 
> smaller than DejaVu Sans that I was using before - same font size 9 was used) 
> - too big spacing in task manager, too big popups (application menu, system 
> tray popups), etc ...
> 
> This fixes the issue. This may also fix BUG 343349
> 
> 
> File Attachments
> 
> 
> systray + popup before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d409b391-e35e-451f-bb5b-aa42e7eb2bf3__before.png
> after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/445009bc-a4a8-4998-8e82-996a0a4e33fb__after.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel