date:20151228


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/352/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 29 Dec 2015 00:22:34 +
Build duration: 5 min 13 sec

CHANGE SET
Revision 8fd4459a49d3e4ff4b6985a503f1649c5e0dd8c9 by kde: ([Media Controller] 
Drop album art placeholder)
  change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
Revision bba0910933dd9f56f09810ebb3642b4f2f6f9e0a by kde: ([Media Controller] 
Load album art asynchronously)
  change: edit applets/mediacontroller/contents/ui/ExpandedRepresentation.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 
test(s)Failed: TestSuite.testdesktop

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1673/2105 
(79%)CONDITIONAL 1208/1810 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 104/152 (68%)CONDITIONAL 
37/62 (60%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 64/66 (97%)CONDITIONAL 
25/46 (54%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

2015-12-28 Thread Raman Gupta via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=357288

--- Comment #1 from Raman Gupta  ---
Created attachment 96345
  --> https://bugs.kde.org/attachment.cgi?id=96345&action=edit
Configuration for power management

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 357288] New: Setting "Screen Energy Saving" in "Energy Saving" config has no effect

2015-12-28 Thread Raman Gupta via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=357288

Bug ID: 357288
   Summary: Setting "Screen Energy Saving" in "Energy Saving"
config has no effect
   Product: Powerdevil
   Version: 5.5.0
  Platform: Fedora RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: rocketra...@gmail.com

Setting the "Screen Energy Saving" value to switch off monitors (under "On AC
Power") in "Energy Saving" config has no effect. The monitors do not turn off,
and "xset q" shows:

DPMS (Energy Star):
  Standby: 0Suspend: 0Off: 0
  DPMS is Enabled
  Monitor is On

Using "xset dpms force off" works fine, as does "xset dpms 600 600 600". After
running that command the monitors correctly go to power saving mode.

However, as soon as any changes are made in the KDE configuration, the dpms
settings go back to 0/0/0.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

(Updated Dez. 28, 2015, 11:34 nachm.)


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
---

* Fix KIdleTime resumingFromIdle

I also removed the default "Quit" option and replaced it with a custom "Hide" 
option, or else you get a "Do you really want to quit drkonqi?" message


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs (updated)
-

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
---

(Updated Dez. 28, 2015, 11:14 nachm.)


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
---

* Drop dedicated "passive" option and instead use the "restarted" parameter 
passed in by KCrash
* Use KIdleTime to ensure the user doesn't miss the SNI if the app crashed 
while he was away: think of an hour-long video encoding process, you will have 
no idea why it's not there anymore when it crashed over night, suggested on my 
blog

Works fine for applications but Plasma crashes aren't as good anymore with 
KCrash auto restart. When Plasma crashes a second time I don't get a SNI 
anymore, sometimes it doesn't even restart. Looks like KCrash doing strange 
things or giving up prematurely.


Repository: plasma-workspace


Description
---

This adds a new "--passive" option to DrKonqi where it will only show a 
StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, 
krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just 
dump the user on the home screen than telling him something went wrong, so he 
can just quickly start the app again instead of being annoyed by an error 
message". On iOS you also just get dropped on the home screen. Windows desktop 
shows a "Searching for a solution" dialog which was *the* major annoyance when 
something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs (updated)
-

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
---

I crashed plasmashell, it restarted so fast that you didn't even have a black 
screen inbetween, just the panel restarting. Afterwards I got a SNI which 
opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it 
by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126551: [Service Runner] WIP: Add support for Jump List Actions


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126551/
---

Review request for Plasma and Vishesh Handa.


Repository: plasma-workspace


Description
---

This adds support for Jump List Actions to the Services runner

I wanted to make the Jump Lists themselves searchable, so you can also enter 
"Big Picture" and it finds the associated service with it but I couldn't figure 
out how I can search Desktop Actions through KServiceTypeTrader. Commented in 
the code is a crude approach.

Also, I can't figure out how I could stick those entries toegether, it should 
always be "Main App - action - action - action - Some other App", sometimes it 
shuffles them again although I tried hard to have them stick together.

I need a better way to distinguish app results and jump list results, I used 
the match type but that obviously doesn't work now. I don't want QString 
matching the data, though.

Finally, I want those results not to show up in Kickoff, is this possible?

I removed the context.isValid() check in the loops as it's done once before all 
of them.


Diffs
-

  runners/services/servicerunner.h a4171bc 
  runners/services/servicerunner.cpp 27df5ab 

Diff: https://git.reviewboard.kde.org/r/126551/diff/


Testing
---

Searched for "steam", got Steam as well as its associated actions
Searched for "spectacle", got its associated capture modes


File Attachments


Steam in KRunner
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/9f3046f1-6acb-460d-a515-6abab6522dfe__krunnerjumplists.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-28 Thread Alex Merry


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review90260
---

Ship it!


OK, just one line break in the docs, then it can go in.


kde-modules/KDEPackageAppTemplates.cmake (line 19)


New paragraph, please.


- Alex Merry


On Dec. 28, 2015, 9:37 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 28, 2015, 9:37 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   docs/kde-module/KDEPackageAppTemplates.rst PRE-CREATION 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
>   kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
>   tests/CMakeLists.txt 1a66f56 
>   tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/check.cmake.in PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
>   
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
>  PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126544: [Kickoff] Hide history tab if empty



> On Dez. 28, 2015, 2:02 nachm., Aleix Pol Gonzalez wrote:
> > Maybe show it as disabled at least? It's weird that UI structure change 
> > every now and then.
> 
> Heiko Tietze wrote:
> I agree with the idea to avoid changing UI structure. However, to disable 
> isn't good for tabs.
> 
> Here is what we wrote in the tabcontrol HIG:
> * Do not disable a tab when it doesn't apply to the current context; 
> disable the controls on the page. 
> * Make tabs closable if their pages contain documents, but not if their 
> pages contain application's user interface.
> 
> -> I recommend to neither hide nor deaktivate the tab.
> 
> Eike Hein wrote:
> I generally agree with Heiko here: Major UI elements 
> appearing/disappearing conditionally is usually bad because it's jarring and 
> missing an opportunity to teach the user what functionality they can expect 
> to become available if they do certain things.
> 
> It's a bit different here because the pitch is that the user can disable 
> history tracking and then gets stuck with a guaranteed-to-be-empty tab they 
> might want to get rid of. But I suggest this relationship then needs to be 
> explicit: Disabling history tracking hides the tab. Not to make it magic 
> based on the count in the model.

makes sense. perhaps we should add a text saying that there are currently no 
recent documents / apps, perhaps with a button to open activity (tracking) 
settings, even. I guess we can query whether tracking is disabled and only then 
hide the tab.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/#review90210
---


On Dez. 28, 2015, 8:56 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126544/
> ---
> 
> (Updated Dez. 28, 2015, 8:56 nachm.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 347633
> https://bugs.kde.org/show_bug.cgi?id=347633
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This hides the "History" tab if it is empty.
> 
> This can permanently happen if you use disable tracking in activity settings 
> or administrative means.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
>   applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 
> 
> Diff: https://git.reviewboard.kde.org/r/126544/diff/
> 
> 
> Testing
> ---
> 
> Button comes and goes as I add and remove history entries.
> 
> When I clear the history, it switches to the Favorites view so you don't end 
> up with a broken view.
> 
> It doesn't seem to track application launches through Kickoff but I think 
> this is unrelated.
> 
> 
> File Attachments
> 
> 
> No history tab
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126544: [Kickoff] Hide history tab if empty


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/
---

(Updated Dez. 28, 2015, 8:56 nachm.)


Status
--

This change has been discarded.


Review request for Plasma, KDE Usability and Eike Hein.


Bugs: 347633
https://bugs.kde.org/show_bug.cgi?id=347633


Repository: plasma-desktop


Description
---

This hides the "History" tab if it is empty.

This can permanently happen if you use disable tracking in activity settings or 
administrative means.


Diffs
-

  applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
  applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
  applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 

Diff: https://git.reviewboard.kde.org/r/126544/diff/


Testing
---

Button comes and goes as I add and remove history entries.

When I clear the history, it switches to the Favorites view so you don't end up 
with a broken view.

It doesn't seem to track application launches through Kickoff but I think this 
is unrelated.


File Attachments


No history tab
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Splitting KActivities, 2nd attempt...

2015-12-28 Thread David Faure

Sounds good overall, but one question:

On Sunday 08 November 2015 12:04:54 Ivan Čukić wrote:
> Hi everybody,
> 
> We have a few problems at the moment because all the activities
> components are in a single repository. Sometimes dependencies of the
> service creep up into the library, builds break because components
> that are meant only for Plasma start requiring Qt versions that Plasma
> require, while KF5 requirement is lower, and similar.
> 
> The way I want to split the repository is as follows:
> 
> - KActivities framework (essentially a Tier 1, integration or solution, all 
> OSs)
> - kactivitymanagerd (service, kcm settings module, dolphin plugin;
> officially linux-only)

Shouldn't the service be part of the framework?
How usable is the framework without the service?
Compiling is good, but running is even better :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Eike Hein



> On Dec. 28, 2015, 2:02 p.m., Aleix Pol Gonzalez wrote:
> > Maybe show it as disabled at least? It's weird that UI structure change 
> > every now and then.
> 
> Heiko Tietze wrote:
> I agree with the idea to avoid changing UI structure. However, to disable 
> isn't good for tabs.
> 
> Here is what we wrote in the tabcontrol HIG:
> * Do not disable a tab when it doesn't apply to the current context; 
> disable the controls on the page. 
> * Make tabs closable if their pages contain documents, but not if their 
> pages contain application's user interface.
> 
> -> I recommend to neither hide nor deaktivate the tab.

I generally agree with Heiko here: Major UI elements appearing/disappearing 
conditionally is usually bad because it's jarring and missing an opportunity to 
teach the user what functionality they can expect to become available if they 
do certain things.

It's a bit different here because the pitch is that the user can disable 
history tracking and then gets stuck with a guaranteed-to-be-empty tab they 
might want to get rid of. But I suggest this relationship then needs to be 
explicit: Disabling history tracking hides the tab. Not to make it magic based 
on the count in the model.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/#review90210
---


On Dec. 28, 2015, 2:01 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126544/
> ---
> 
> (Updated Dec. 28, 2015, 2:01 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 347633
> https://bugs.kde.org/show_bug.cgi?id=347633
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This hides the "History" tab if it is empty.
> 
> This can permanently happen if you use disable tracking in activity settings 
> or administrative means.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
>   applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 
> 
> Diff: https://git.reviewboard.kde.org/r/126544/diff/
> 
> 
> Testing
> ---
> 
> Button comes and goes as I add and remove history entries.
> 
> When I clear the history, it switches to the Favorites view so you don't end 
> up with a broken view.
> 
> It doesn't seem to track application launches through Kickoff but I think 
> this is unrelated.
> 
> 
> File Attachments
> 
> 
> No history tab
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Heiko Tietze



> On Dec. 28, 2015, 2:02 p.m., Aleix Pol Gonzalez wrote:
> > Maybe show it as disabled at least? It's weird that UI structure change 
> > every now and then.

I agree with the idea to avoid changing UI structure. However, to disable isn't 
good for tabs.

Here is what we wrote in the tabcontrol HIG:
* Do not disable a tab when it doesn't apply to the current context; disable 
the controls on the page. 
* Make tabs closable if their pages contain documents, but not if their pages 
contain application's user interface.

-> I recommend to neither hide nor deaktivate the tab.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/#review90210
---


On Dec. 28, 2015, 2:01 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126544/
> ---
> 
> (Updated Dec. 28, 2015, 2:01 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 347633
> https://bugs.kde.org/show_bug.cgi?id=347633
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This hides the "History" tab if it is empty.
> 
> This can permanently happen if you use disable tracking in activity settings 
> or administrative means.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
>   applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 
> 
> Diff: https://git.reviewboard.kde.org/r/126544/diff/
> 
> 
> Testing
> ---
> 
> Button comes and goes as I add and remove history entries.
> 
> When I clear the history, it switches to the Favorites view so you don't end 
> up with a broken view.
> 
> It doesn't seem to track application launches through Kickoff but I think 
> this is unrelated.
> 
> 
> File Attachments
> 
> 
> No history tab
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

2015-12-28 Thread Lydia Pintscher

On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley  wrote:
>> Is there some place where search engines can easily index our source
>> code or are we shooting ourselves in the foot here?
>
> We could probably make it available by publishing the source trees
> used by LXR / EBN.
> This would only have the main branches obviously rather than everything 
> though.
>
> I haven't checked, but LXR may already make it's copy of the code 
> accessible...

I think making our sourcecode available to search engines is pretty
important for the reasons already mentioned by others. Do you need
help for it? If you write down what's needed I can help find someone
to do it.


Cheers
Lydia

-- 
Lydia Pintscher - http://about.me/lydia.pintscher
KDE e.V. Board of Directors / KDE Community Working Group
http://kde.org - http://open-advice.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-28 Thread Ken Vermette



> On Dec. 28, 2015, 9:16 a.m., Marco Martin wrote:
> > so, let's go with the last one? for me +1, any complaints?

I went ahead and shipped; complaints were mostly focused on the 
intel-glitch-strip, outside of that I think we eliminated the glaring objective 
issues. I don't think there's anything meaningful to change which wouldn't 
result in an entirely different wallpaper and a new wave of issues.

On a side note I just wanted to thank everyone with their patience while I 
stumbled through my first formal review process. I'm very glad it was done 
properly this time, and that I got the additional input. If anyone would like 
to double-check to make sure I didn't botch the actual commit, I would 
appreciate that as well. Also, should I just push the blurred version of the 
wallpaper for the lock/login and splash screens, or create a new review request?

Again, thank you everyone. I appreciate the feedback and the patience while I 
figured this out.


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review90192
---


On Dec. 28, 2015, 5:47 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dec. 28, 2015, 5:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
> 
> 
> Testing
> ---
> 
> Dogfooded on several machines and my phone for a couple weeks now, doesn't 
> burn eyes out. Corner isn't as distracting as one might assume, especially 
> once a window is on screen. Got early feedback, adjustments made from 
> origional in order:
>  - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. 
> Adjusted it so details are still seen on lower-res wallpapers.
>  - Lightened purple to avoid the "dark void" feeling people have mentioned 
> feeling from 5.5 wallpaper.
>  - Fixed minor pixel issues for triangles near edge
>  - Adjusted noise, shadows.
> 
> 
> File Attachments
> 
> 
> 1024x768.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
> 1280x800.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/41e11bb9-eaef-4eb1-bb4b-c7137becaca0__1280x800.png
> screenshot.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee643bd5-8162-4a9b-ae09-df090d4f0b43__screenshot.png
> 1280x1024.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/054536c9-8160-418a-a1c9-c319e1e2b533__1280x1024.png
> 1440x900.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/c4c61ba4-10ea-4d87-9437-7b7e1701eaf7__1440x900.png
> 1600x1200.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee746ed5-428d-4423-8e20-d9786b25190f__1600x1200.png
> 1638x1024.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/233a9950-24bd-47b6-8c7a-8f3e6fe707df__1638x1024.png
> 1680x1050.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/4c86e45c-eb10-47fa-b1ff-736bd65918cc__1680x1050.png
> 1920x1080.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/93cc544a-a8a8-4291-91ff-58140ec5ed64__1920x1080.png
> 2560x1440.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/73ad5caf-5156-495b-939c-387ce4970140__2560x1

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.



> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote:
> > sddmauthhelper.cpp, line 74
> > 
> >
> > Ideally we should check the *calling* user can read this file, as you 
> > technically have a security bug.
> > 
> > Otherwise I could just select /etc/shadow as my background and suddenly 
> > it's available world readable.
> > 
> > A distro/admin could theoretically set polkit up to allow any users to 
> > change the SDDM wallpaper. though TBH it'd never happen.
> > 
> > Polkit-Qt has that information available. KAuth does not seem to 
> > publicly.
> 
> Joshua Noack wrote:
> Not sure if I understand you correctly... 
> In addition to the KAuth dialog where the user needs to authenticate, a 
> check if the user can read the file should be added?
> Shouldn't the file chooser restrict the user here in the first place?
> 
> David Edmundson wrote:
> it needs to happen inside the helper, not on the client side.
> 
> From a terminal I can manually start the sddm helper saying I want to set 
> /etc/shadow as the background.
> 
> The helper will then check if the user is permitted to set the SDDM 
> wallpaper in policykit, which is up to the sysadmin's policy
> If that returns true, the helper will procede to copy the file as root.
> 
> That's a security hole as it would potentially allow me to read any file.
> 
> Joshua Noack wrote:
> Okay, I looked up policykit and don't see any rule in 
> /usr/share/polkit-1/ for it. 
> So... should I create a new rule (like org.kde.sddm.policy) ? But judging 
> from your words, it seems to be already possible?
> 
> If you could tell me where the sysadmin sets his policies I would be 
> grateful. :p

We already have a policy.

See org.kde.kcontrol.kcmsddm.policy

our defaults are:
  
 no
 auth_admin_keep
  


which is good.

However, we can't predict that every setup and every distro will have the same 
setup.
They could change it to be 
 yes
 
and then we have a problem.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126524/#review90132
---


On Dec. 28, 2015, 3:44 p.m., Joshua Noack wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126524/
> ---
> 
> (Updated Dec. 28, 2015, 3:44 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> ---
> 
> For some reason sddm cannot handle absolute file paths to wallpapers
> and also needs the wallpaper to be readable by others.
> 
> This is fixed by copying the wallpaper to the root directory of the
> selected theme.
> 
> On save the sddmauthhelper copies the background from the absolute path
> into the theme directory and sets the "background" key of the
> theme.user.conf to the copied file. If previously a different background was
> set it is removed beforehand.
> 
> 
> Diffs
> -
> 
>   sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 
>   src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c 
> 
> Diff: https://git.reviewboard.kde.org/r/126524/diff/
> 
> 
> Testing
> ---
> 
> Copies and removes backgrounds as intended.
> The wallpaper is shown in sddm.
> 
> 
> Thanks,
> 
> Joshua Noack
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner



> On Dez. 28, 2015, 5:46 nachm., Xuetian Weng wrote:
> > I can see that it provides suspend, sleep, hibernate feature which is still 
> > useful (Though for some reason I can't trigger it here). Maybe merge that 
> > part into sessions runner and drop others?
> 
> Aleix Pol Gonzalez wrote:
> I often suspend from KRunner.
> 
> Kai Uwe Broulik wrote:
> What's wrong about:
> * Using Kickoff
> * Using the Lock Logout applet
> * Pressing a shortcut on your keyboard
> * Closing the lid
> * Pressing the power button if configured to suspend
> 
> Kai Uwe Broulik wrote:
> Crap, that should have become a list.
> 
> Aleix Pol Gonzalez wrote:
> Maybe I could fit one of those solutions, I just don't see why it needs 
> to be removed.
> 
> I mostly use KRunner when I have 2 monitors, so closing the lid would 
> just leave it to the other monitor. I don't think I have such a shortcut and 
> I removed kickoff longtime ago because I only used it to suspend my system :D.

:D Fair enough.

I'll clean it up, though, remove all the brightness and profile cruft.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
---


On Dez. 28, 2015, 5:22 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> ---
> 
> (Updated Dez. 28, 2015, 5:22 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt 48cc379 
>   runners/powerdevil/CMakeLists.txt 7c03e29 
>   runners/powerdevil/Messages.sh 99ae5dc 
>   runners/powerdevil/PowerDevilRunner.h 7995621 
>   runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
>   runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 
> 
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/
---

(Updated Dez. 28, 2015, 6:28 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

* I have no idea how to use it
* I have never used it
* It allows switching profiles which were removed half a decade ago
* Its brightness handling is most likely broken
* There's global keyboard shorcuts and battery monitor
* I'm not willing to maintain it and/or ensure it keeps working


Diffs
-

  runners/CMakeLists.txt 48cc379 
  runners/powerdevil/CMakeLists.txt 7c03e29 
  runners/powerdevil/Messages.sh 99ae5dc 
  runners/powerdevil/PowerDevilRunner.h 7995621 
  runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
  runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 

Diff: https://git.reviewboard.kde.org/r/126548/diff/


Testing
---


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner

2015-12-28 Thread Aleix Pol Gonzalez



> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote:
> > I can see that it provides suspend, sleep, hibernate feature which is still 
> > useful (Though for some reason I can't trigger it here). Maybe merge that 
> > part into sessions runner and drop others?
> 
> Aleix Pol Gonzalez wrote:
> I often suspend from KRunner.
> 
> Kai Uwe Broulik wrote:
> What's wrong about:
> * Using Kickoff
> * Using the Lock Logout applet
> * Pressing a shortcut on your keyboard
> * Closing the lid
> * Pressing the power button if configured to suspend
> 
> Kai Uwe Broulik wrote:
> Crap, that should have become a list.

Maybe I could fit one of those solutions, I just don't see why it needs to be 
removed.

I mostly use KRunner when I have 2 monitors, so closing the lid would just 
leave it to the other monitor. I don't think I have such a shortcut and I 
removed kickoff longtime ago because I only used it to suspend my system :D.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
---


On Dec. 28, 2015, 6:22 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> ---
> 
> (Updated Dec. 28, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt 48cc379 
>   runners/powerdevil/CMakeLists.txt 7c03e29 
>   runners/powerdevil/Messages.sh 99ae5dc 
>   runners/powerdevil/PowerDevilRunner.h 7995621 
>   runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
>   runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 
> 
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner



> On Dez. 28, 2015, 5:46 nachm., Xuetian Weng wrote:
> > I can see that it provides suspend, sleep, hibernate feature which is still 
> > useful (Though for some reason I can't trigger it here). Maybe merge that 
> > part into sessions runner and drop others?
> 
> Aleix Pol Gonzalez wrote:
> I often suspend from KRunner.

What's wrong about:
* Using Kickoff
* Using the Lock Logout applet
* Pressing a shortcut on your keyboard
* Closing the lid
* Pressing the power button if configured to suspend


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
---


On Dez. 28, 2015, 5:22 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> ---
> 
> (Updated Dez. 28, 2015, 5:22 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt 48cc379 
>   runners/powerdevil/CMakeLists.txt 7c03e29 
>   runners/powerdevil/Messages.sh 99ae5dc 
>   runners/powerdevil/PowerDevilRunner.h 7995621 
>   runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
>   runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 
> 
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner



> On Dez. 28, 2015, 5:46 nachm., Xuetian Weng wrote:
> > I can see that it provides suspend, sleep, hibernate feature which is still 
> > useful (Though for some reason I can't trigger it here). Maybe merge that 
> > part into sessions runner and drop others?
> 
> Aleix Pol Gonzalez wrote:
> I often suspend from KRunner.
> 
> Kai Uwe Broulik wrote:
> What's wrong about:
> * Using Kickoff
> * Using the Lock Logout applet
> * Pressing a shortcut on your keyboard
> * Closing the lid
> * Pressing the power button if configured to suspend

Crap, that should have become a list.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
---


On Dez. 28, 2015, 5:22 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> ---
> 
> (Updated Dez. 28, 2015, 5:22 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt 48cc379 
>   runners/powerdevil/CMakeLists.txt 7c03e29 
>   runners/powerdevil/Messages.sh 99ae5dc 
>   runners/powerdevil/PowerDevilRunner.h 7995621 
>   runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
>   runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 
> 
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner

2015-12-28 Thread Aleix Pol Gonzalez



> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote:
> > I can see that it provides suspend, sleep, hibernate feature which is still 
> > useful (Though for some reason I can't trigger it here). Maybe merge that 
> > part into sessions runner and drop others?

I often suspend from KRunner.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
---


On Dec. 28, 2015, 6:22 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> ---
> 
> (Updated Dec. 28, 2015, 6:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt 48cc379 
>   runners/powerdevil/CMakeLists.txt 7c03e29 
>   runners/powerdevil/Messages.sh 99ae5dc 
>   runners/powerdevil/PowerDevilRunner.h 7995621 
>   runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
>   runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 
> 
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.



> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote:
> > sddmauthhelper.cpp, line 74
> > 
> >
> > Ideally we should check the *calling* user can read this file, as you 
> > technically have a security bug.
> > 
> > Otherwise I could just select /etc/shadow as my background and suddenly 
> > it's available world readable.
> > 
> > A distro/admin could theoretically set polkit up to allow any users to 
> > change the SDDM wallpaper. though TBH it'd never happen.
> > 
> > Polkit-Qt has that information available. KAuth does not seem to 
> > publicly.
> 
> Joshua Noack wrote:
> Not sure if I understand you correctly... 
> In addition to the KAuth dialog where the user needs to authenticate, a 
> check if the user can read the file should be added?
> Shouldn't the file chooser restrict the user here in the first place?
> 
> David Edmundson wrote:
> it needs to happen inside the helper, not on the client side.
> 
> From a terminal I can manually start the sddm helper saying I want to set 
> /etc/shadow as the background.
> 
> The helper will then check if the user is permitted to set the SDDM 
> wallpaper in policykit, which is up to the sysadmin's policy
> If that returns true, the helper will procede to copy the file as root.
> 
> That's a security hole as it would potentially allow me to read any file.

Okay, I looked up policykit and don't see any rule in /usr/share/polkit-1/ for 
it. 
So... should I create a new rule (like org.kde.sddm.policy) ? But judging from 
your words, it seems to be already possible?

If you could tell me where the sysadmin sets his policies I would be grateful. 
:p


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126524/#review90132
---


On Dec. 28, 2015, 3:44 p.m., Joshua Noack wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126524/
> ---
> 
> (Updated Dec. 28, 2015, 3:44 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> ---
> 
> For some reason sddm cannot handle absolute file paths to wallpapers
> and also needs the wallpaper to be readable by others.
> 
> This is fixed by copying the wallpaper to the root directory of the
> selected theme.
> 
> On save the sddmauthhelper copies the background from the absolute path
> into the theme directory and sets the "background" key of the
> theme.user.conf to the copied file. If previously a different background was
> set it is removed beforehand.
> 
> 
> Diffs
> -
> 
>   sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 
>   src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c 
> 
> Diff: https://git.reviewboard.kde.org/r/126524/diff/
> 
> 
> Testing
> ---
> 
> Copies and removes backgrounds as intended.
> The wallpaper is shown in sddm.
> 
> 
> Thanks,
> 
> Joshua Noack
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-28 Thread Ken Vermette


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/
---

(Updated Dec. 28, 2015, 5:47 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 68c839ab937e96680b45df5b8f9e1cc5e547bc50 by Ken Vermette 
to branch master.


Repository: breeze


Description
---

Attached images directly to request; if this is not the preferred way of 
attaching large files, please let me know and I'll change methods, perhaps 
using the VDG share if that's preferred.

For reference I would like to shift to more "professional" default wallpapers 
and away from the more organic style of 5.4 and 5.5. Feedback on both general 
direction or this wallpaper is welcome.

Note: I will submit splash files later in case of changes to this wallpaper.


Diffs
-

  wallpapers/Next/contents/images/1024x768.png 60e1205 
  wallpapers/Next/contents/images/1280x1024.png 36a9130 
  wallpapers/Next/contents/images/1280x800.png c33e594 
  wallpapers/Next/contents/images/1440x900.png 2c75b54 
  wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
  wallpapers/Next/contents/images/1638x1024.png a3c7492 
  wallpapers/Next/contents/images/1680x1050.png eddc47e 
  wallpapers/Next/contents/images/1920x1080.png ab6d950 
  wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
  wallpapers/Next/contents/images/2560x1600.png eeb08a1 
  wallpapers/Next/contents/images/3200x1800.png 7340567 
  wallpapers/Next/contents/images/3200x2000.png fd1a62c 
  wallpapers/Next/contents/screenshot.png a6d2b7b 

Diff: https://git.reviewboard.kde.org/r/126319/diff/


Testing
---

Dogfooded on several machines and my phone for a couple weeks now, doesn't burn 
eyes out. Corner isn't as distracting as one might assume, especially once a 
window is on screen. Got early feedback, adjustments made from origional in 
order:
 - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. 
Adjusted it so details are still seen on lower-res wallpapers.
 - Lightened purple to avoid the "dark void" feeling people have mentioned 
feeling from 5.5 wallpaper.
 - Fixed minor pixel issues for triangles near edge
 - Adjusted noise, shadows.


File Attachments


1024x768.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
1280x800.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/41e11bb9-eaef-4eb1-bb4b-c7137becaca0__1280x800.png
screenshot.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee643bd5-8162-4a9b-ae09-df090d4f0b43__screenshot.png
1280x1024.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/054536c9-8160-418a-a1c9-c319e1e2b533__1280x1024.png
1440x900.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/c4c61ba4-10ea-4d87-9437-7b7e1701eaf7__1440x900.png
1600x1200.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee746ed5-428d-4423-8e20-d9786b25190f__1600x1200.png
1638x1024.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/233a9950-24bd-47b6-8c7a-8f3e6fe707df__1638x1024.png
1680x1050.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/4c86e45c-eb10-47fa-b1ff-736bd65918cc__1680x1050.png
1920x1080.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/93cc544a-a8a8-4291-91ff-58140ec5ed64__1920x1080.png
2560x1440.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/73ad5caf-5156-495b-939c-387ce4970140__2560x1440.png
2560x1600.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/1ff471aa-2e26-41d9-8921-2c62544d3415__2560x1600.png
3200x1800.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/7590da34-e5c5-4f55-9ac9-0a22c13a9c0d__3200x1800.png
3200x2000.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/229a429e-9633-4988-ad78-dfb039583fc4__3200x2000.png
desktopWallpaper-graphite-3.3-kvermette.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/27/bc1de0b2-a753-4772-b5a7-8d5c27c0138b__desktopWallpaper-graphite-3.3-kvermette.png


Thanks,

Ken Vermette

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126548: Kill PowerDevil runner

2015-12-28 Thread Xuetian Weng


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
---


I can see that it provides suspend, sleep, hibernate feature which is still 
useful (Though for some reason I can't trigger it here). Maybe merge that part 
into sessions runner and drop others?

- Xuetian Weng


On Dec. 28, 2015, 5:22 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> ---
> 
> (Updated Dec. 28, 2015, 5:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
> 
> 
> Diffs
> -
> 
>   runners/CMakeLists.txt 48cc379 
>   runners/powerdevil/CMakeLists.txt 7c03e29 
>   runners/powerdevil/Messages.sh 99ae5dc 
>   runners/powerdevil/PowerDevilRunner.h 7995621 
>   runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
>   runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 
> 
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126548: Kill PowerDevil runner


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

* I have no idea how to use it
* I have never used it
* It allows switching profiles which were removed half a decade ago
* Its brightness handling is most likely broken
* There's global keyboard shorcuts and battery monitor
* I'm not willing to maintain it and/or ensure it keeps working


Diffs
-

  runners/CMakeLists.txt 48cc379 
  runners/powerdevil/CMakeLists.txt 7c03e29 
  runners/powerdevil/Messages.sh 99ae5dc 
  runners/powerdevil/PowerDevilRunner.h 7995621 
  runners/powerdevil/PowerDevilRunner.cpp 527a2c2 
  runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e 

Diff: https://git.reviewboard.kde.org/r/126548/diff/


Testing
---


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.



> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote:
> > sddmauthhelper.cpp, line 74
> > 
> >
> > Ideally we should check the *calling* user can read this file, as you 
> > technically have a security bug.
> > 
> > Otherwise I could just select /etc/shadow as my background and suddenly 
> > it's available world readable.
> > 
> > A distro/admin could theoretically set polkit up to allow any users to 
> > change the SDDM wallpaper. though TBH it'd never happen.
> > 
> > Polkit-Qt has that information available. KAuth does not seem to 
> > publicly.
> 
> Joshua Noack wrote:
> Not sure if I understand you correctly... 
> In addition to the KAuth dialog where the user needs to authenticate, a 
> check if the user can read the file should be added?
> Shouldn't the file chooser restrict the user here in the first place?

it needs to happen inside the helper, not on the client side.

>From a terminal I can manually start the sddm helper saying I want to set 
>/etc/shadow as the background.

The helper will then check if the user is permitted to set the SDDM wallpaper 
in policykit, which is up to the sysadmin's policy
If that returns true, the helper will procede to copy the file as root.

That's a security hole as it would potentially allow me to read any file.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126524/#review90132
---


On Dec. 28, 2015, 3:44 p.m., Joshua Noack wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126524/
> ---
> 
> (Updated Dec. 28, 2015, 3:44 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> ---
> 
> For some reason sddm cannot handle absolute file paths to wallpapers
> and also needs the wallpaper to be readable by others.
> 
> This is fixed by copying the wallpaper to the root directory of the
> selected theme.
> 
> On save the sddmauthhelper copies the background from the absolute path
> into the theme directory and sets the "background" key of the
> theme.user.conf to the copied file. If previously a different background was
> set it is removed beforehand.
> 
> 
> Diffs
> -
> 
>   sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 
>   src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c 
> 
> Diff: https://git.reviewboard.kde.org/r/126524/diff/
> 
> 
> Testing
> ---
> 
> Copies and removes backgrounds as intended.
> The wallpaper is shown in sddm.
> 
> 
> Thanks,
> 
> Joshua Noack
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 351 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/351/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Dec 2015 16:24:32 +
Build duration: 13 min

CHANGE SET
Revision 0dc7f6c3e5d62f6d8211e5d024ee3080b2baae37 by David Edmundson: 
(Don't rely graphic objects in panel script engine)
  change: edit shell/panelview.h
  change: edit shell/scripting/panel.cpp
  change: edit shell/scripting/panel.h
  change: edit shell/panelview.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 
test(s)Failed: TestSuite.testdesktop

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1673/2105 
(79%)CONDITIONAL 1208/1810 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 104/152 (68%)CONDITIONAL 
37/62 (60%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 64/66 (97%)CONDITIONAL 
25/46 (54%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/
---

(Updated Dec. 28, 2015, 4:35 p.m.)

Status
--

This change has been marked as submitted.

Review request for Plasma, KDE Usability and Vishesh Handa.

Changes
---

Submitted with commit f94c18a67aa6dc1c3732e08110e554faad491fa5 by Kai Uwe
Broulik to branch master.

Repository: milou

Description
---

This brings back support for additional runner actions. A runner can specify
supplemental actions to a search result.

It is deliberately no ToolButton as that would look weird, the Highlight blends
in much better, although I'm not too happy with the huge Plasma tooltip. I'm
not sure how keyboard interaction should work as both Tab and arrow keys would
conflict with navigation.

Diffs
-

lib/CMakeLists.txt 1123b60
lib/qml/ResultDelegate.qml 6d60bf2
lib/qml/ResultsView.qml b36cc19
lib/sourcesmodel.h 6c2d205
lib/sourcesmodel.cpp 65c69b3

Diff: https://git.reviewboard.kde.org/r/126514/diff/

Testing
---

Hardly any runner makes use of this, though.
I got the kill runner to send sigterm and sigkill, and also some mysterious ktp
runer I couldn't find where it is offers "Start Chat" and "Open Chat Log"
actions. The Solid runner supposedly also adds actions but I couldn't get that
to work.

Unfortunately I had to add QtWidgets for QAction :(

File Attachments

Runner action

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png

Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90233
---

Ship it!


Ship It!

- Marco Martin


On Dec. 28, 2015, 3:49 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dec. 28, 2015, 3:49 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions



> On Dec. 28, 2015, 2:19 p.m., Marco Martin wrote:
> > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand 
> > QIcons as it uses IconItem internally
> 
> Kai Uwe Broulik wrote:
> Yes, but iconSource property of QQC Button is of "url" type.
> 
> Kai Uwe Broulik wrote:
> And Plasma Button iconSource is alised to iconName, which is of "string" 
> type.
> 
> Kai Uwe Broulik wrote:
> If we turned iconSource into a property var we could make this work, 
> given we just pass whatever's in there to our IconItem. I don't know what 
> implications this has, though, since it says "override this property for 
> compatibility".
> 
> Marco Martin wrote:
> "override this property for compatibility" means that controls used to 
> have only the iconSource property, then we adopetd it, then they changed it 
> to iconName for freedesktop icon names under our feet... just the same old 
> story.
> if it becomes a variant, it could then try so set iconName iff is a 
> string in the propertychanged signal, and the theme try to interpret it as 
> variant.
> 
> Kai Uwe Broulik wrote:
> But if I forward all strings to iconName absolute URLs will break, no?

perhaps.. bah, let's keep it with an internal iconitem for now (/me sighs at 
QQC again)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90212
---


On Dec. 28, 2015, 3:49 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dec. 28, 2015, 3:49 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125921: Don't rely graphic objects in panel script engine


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125921/
---

(Updated Dec. 28, 2015, 4:24 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 0dc7f6c3e5d62f6d8211e5d024ee3080b2baae37 by David 
Edmundson to branch master.


Bugs: 355918
https://bugs.kde.org/show_bug.cgi?id=355918


Repository: plasma-workspace


Description
---

The basic design of Plasma is that scripts and and the shell (in theory)
manipulate a tree of basic applet geometry and configs.

Plasmashell then reacts to those changes and displays them visually with
a distinct separation between the layout and UI.

Panel's scriptengine seemed to do away with all, and try and manipulate the 
graphic object directly..which might not exist and that leads to complex code.

This changes it to read/write from the same config object as
PanelView will use. More akin to how the script engine for applet and 
contiainment work.

If there's a view for this panel, we update immediately, otherwise it'll just 
get loaded when it's needed. PanelView::reload() has the error checking/bounds 
management so no point duplicating that.

Idea is to fix the same bug as https://git.reviewboard.kde.org/r/125920/ but 
also clean up a lot of the code which I thought had grown a bit complex. 

Bit too big to backport though. Might be Plasma 5.6 material at this point.


Diffs
-

  shell/panelview.h 9f8d4ce9c92e86d81aa8076ca8eb01c0eb8a18c9 
  shell/panelview.cpp 4dec906b63bd535b3add732f2f5e3971c0a5f37a 
  shell/scripting/panel.h f7279100a7c79f2f15917b88d8199573a379cb7d 
  shell/scripting/panel.cpp fb0ff2119850823c4fb76f223ed04f0e9c0d0010 

Diff: https://git.reviewboard.kde.org/r/125921/diff/


Testing
---

Modified my layout.js to set min, max sizes as well as alignment and offset 
which were previously broken.

Once loaded opened the interactive editor and run stuff like:
panel = panelById(1);
panel.alignment = "center"
panel.height = 40

Seems to work as before


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions



> On Dez. 28, 2015, 2:19 nachm., Marco Martin wrote:
> > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand 
> > QIcons as it uses IconItem internally
> 
> Kai Uwe Broulik wrote:
> Yes, but iconSource property of QQC Button is of "url" type.
> 
> Kai Uwe Broulik wrote:
> And Plasma Button iconSource is alised to iconName, which is of "string" 
> type.
> 
> Kai Uwe Broulik wrote:
> If we turned iconSource into a property var we could make this work, 
> given we just pass whatever's in there to our IconItem. I don't know what 
> implications this has, though, since it says "override this property for 
> compatibility".
> 
> Marco Martin wrote:
> "override this property for compatibility" means that controls used to 
> have only the iconSource property, then we adopetd it, then they changed it 
> to iconName for freedesktop icon names under our feet... just the same old 
> story.
> if it becomes a variant, it could then try so set iconName iff is a 
> string in the propertychanged signal, and the theme try to interpret it as 
> variant.

But if I forward all strings to iconName absolute URLs will break, no?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90212
---


On Dez. 28, 2015, 3:49 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dez. 28, 2015, 3:49 nachm.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.



> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote:
> > sddmauthhelper.cpp, line 74
> > 
> >
> > Ideally we should check the *calling* user can read this file, as you 
> > technically have a security bug.
> > 
> > Otherwise I could just select /etc/shadow as my background and suddenly 
> > it's available world readable.
> > 
> > A distro/admin could theoretically set polkit up to allow any users to 
> > change the SDDM wallpaper. though TBH it'd never happen.
> > 
> > Polkit-Qt has that information available. KAuth does not seem to 
> > publicly.

Not sure if I understand you correctly... 
In addition to the KAuth dialog where the user needs to authenticate, a check 
if the user can read the file should be added?
Shouldn't the file chooser restrict the user here in the first place?


> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote:
> > sddmauthhelper.cpp, line 77
> > 
> >
> > the file could have changed regardless of whether the name has, like if 
> > I edit it in krita or something.
> > 
> > Unless you want to compare mtimes, you may as well just copy it 
> > everytime.

Makes sense.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126524/#review90132
---


On Dec. 28, 2015, 3:44 p.m., Joshua Noack wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126524/
> ---
> 
> (Updated Dec. 28, 2015, 3:44 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> ---
> 
> For some reason sddm cannot handle absolute file paths to wallpapers
> and also needs the wallpaper to be readable by others.
> 
> This is fixed by copying the wallpaper to the root directory of the
> selected theme.
> 
> On save the sddmauthhelper copies the background from the absolute path
> into the theme directory and sets the "background" key of the
> theme.user.conf to the copied file. If previously a different background was
> set it is removed beforehand.
> 
> 
> Diffs
> -
> 
>   sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 
>   src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c 
> 
> Diff: https://git.reviewboard.kde.org/r/126524/diff/
> 
> 
> Testing
> ---
> 
> Copies and removes backgrounds as intended.
> The wallpaper is shown in sddm.
> 
> 
> Thanks,
> 
> Joshua Noack
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions



> On Dec. 28, 2015, 2:19 p.m., Marco Martin wrote:
> > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand 
> > QIcons as it uses IconItem internally
> 
> Kai Uwe Broulik wrote:
> Yes, but iconSource property of QQC Button is of "url" type.
> 
> Kai Uwe Broulik wrote:
> And Plasma Button iconSource is alised to iconName, which is of "string" 
> type.
> 
> Kai Uwe Broulik wrote:
> If we turned iconSource into a property var we could make this work, 
> given we just pass whatever's in there to our IconItem. I don't know what 
> implications this has, though, since it says "override this property for 
> compatibility".

"override this property for compatibility" means that controls used to have 
only the iconSource property, then we adopetd it, then they changed it to 
iconName for freedesktop icon names under our feet... just the same old story.
if it becomes a variant, it could then try so set iconName iff is a string in 
the propertychanged signal, and the theme try to interpret it as variant.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90212
---


On Dec. 28, 2015, 3:49 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dec. 28, 2015, 3:49 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125921: Don't rely graphic objects in panel script engine


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125921/#review90228
---

Ship it!


Ship It!

- Marco Martin


On Dec. 28, 2015, 3:44 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125921/
> ---
> 
> (Updated Dec. 28, 2015, 3:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355918
> https://bugs.kde.org/show_bug.cgi?id=355918
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The basic design of Plasma is that scripts and and the shell (in theory)
> manipulate a tree of basic applet geometry and configs.
> 
> Plasmashell then reacts to those changes and displays them visually with
> a distinct separation between the layout and UI.
> 
> Panel's scriptengine seemed to do away with all, and try and manipulate the 
> graphic object directly..which might not exist and that leads to complex code.
> 
> This changes it to read/write from the same config object as
> PanelView will use. More akin to how the script engine for applet and 
> contiainment work.
> 
> If there's a view for this panel, we update immediately, otherwise it'll just 
> get loaded when it's needed. PanelView::reload() has the error 
> checking/bounds management so no point duplicating that.
> 
> Idea is to fix the same bug as https://git.reviewboard.kde.org/r/125920/ but 
> also clean up a lot of the code which I thought had grown a bit complex. 
> 
> Bit too big to backport though. Might be Plasma 5.6 material at this point.
> 
> 
> Diffs
> -
> 
>   shell/panelview.h 9f8d4ce9c92e86d81aa8076ca8eb01c0eb8a18c9 
>   shell/panelview.cpp 4dec906b63bd535b3add732f2f5e3971c0a5f37a 
>   shell/scripting/panel.h f7279100a7c79f2f15917b88d8199573a379cb7d 
>   shell/scripting/panel.cpp fb0ff2119850823c4fb76f223ed04f0e9c0d0010 
> 
> Diff: https://git.reviewboard.kde.org/r/125921/diff/
> 
> 
> Testing
> ---
> 
> Modified my layout.js to set min, max sizes as well as alignment and offset 
> which were previously broken.
> 
> Once loaded opened the interactive editor and run stuff like:
> panel = panelById(1);
> panel.alignment = "center"
> panel.height = 40
> 
> Seems to work as before
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/
---

(Updated Dez. 28, 2015, 3:49 nachm.)

Review request for Plasma, KDE Usability and Vishesh Handa.

Changes
---

* Implement keyboard navigation

Using Tab you can now reach the actions as well, ie, you tab this way:
"David" - "Start chat" - "Open log viewer" - (next entry) "Another guy" -
"Start chat" - "Open log viewer" - (next result and so on

vice-versa when back-tabbing. Return invokes the highlighted action. I had to
abuse the checked state for this as we cannot programmatically pretend to be
hovered. Arrow keys move between search results as usual.

Repository: milou

Description
---

This brings back support for additional runner actions. A runner can specify
supplemental actions to a search result.

Diffs (updated)
-

lib/CMakeLists.txt 1123b60
lib/qml/ResultDelegate.qml 6d60bf2
lib/qml/ResultsView.qml b36cc19
lib/sourcesmodel.h 6c2d205
lib/sourcesmodel.cpp 65c69b3

Diff: https://git.reviewboard.kde.org/r/126514/diff/

Testing
---

Unfortunately I had to add QtWidgets for QAction :(

File Attachments

Runner action

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png

Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125921: Don't rely graphic objects in panel script engine


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125921/
---

(Updated Dec. 28, 2015, 3:44 p.m.)


Review request for Plasma.


Bugs: 355918
https://bugs.kde.org/show_bug.cgi?id=355918


Repository: plasma-workspace


Description
---

The basic design of Plasma is that scripts and and the shell (in theory)
manipulate a tree of basic applet geometry and configs.

Plasmashell then reacts to those changes and displays them visually with
a distinct separation between the layout and UI.

Panel's scriptengine seemed to do away with all, and try and manipulate the 
graphic object directly..which might not exist and that leads to complex code.

This changes it to read/write from the same config object as
PanelView will use. More akin to how the script engine for applet and 
contiainment work.

If there's a view for this panel, we update immediately, otherwise it'll just 
get loaded when it's needed. PanelView::reload() has the error checking/bounds 
management so no point duplicating that.

Idea is to fix the same bug as https://git.reviewboard.kde.org/r/125920/ but 
also clean up a lot of the code which I thought had grown a bit complex. 

Bit too big to backport though. Might be Plasma 5.6 material at this point.


Diffs
-

  shell/panelview.h 9f8d4ce9c92e86d81aa8076ca8eb01c0eb8a18c9 
  shell/panelview.cpp 4dec906b63bd535b3add732f2f5e3971c0a5f37a 
  shell/scripting/panel.h f7279100a7c79f2f15917b88d8199573a379cb7d 
  shell/scripting/panel.cpp fb0ff2119850823c4fb76f223ed04f0e9c0d0010 

Diff: https://git.reviewboard.kde.org/r/125921/diff/


Testing
---

Modified my layout.js to set min, max sizes as well as alignment and offset 
which were previously broken.

Once loaded opened the interactive editor and run stuff like:
panel = panelById(1);
panel.alignment = "center"
panel.height = 40

Seems to work as before


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126524/
---

(Updated Dec. 28, 2015, 3:44 p.m.)


Review request for Plasma and David Edmundson.


Repository: sddm-kcm


Description
---

For some reason sddm cannot handle absolute file paths to wallpapers
and also needs the wallpaper to be readable by others.

This is fixed by copying the wallpaper to the root directory of the
selected theme.

On save the sddmauthhelper copies the background from the absolute path
into the theme directory and sets the "background" key of the
theme.user.conf to the copied file. If previously a different background was
set it is removed beforehand.


Diffs
-

  sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 
  src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c 

Diff: https://git.reviewboard.kde.org/r/126524/diff/


Testing
---

Copies and removes backgrounds as intended.
The wallpaper is shown in sddm.


Thanks,

Joshua Noack

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126524/
---

(Updated Dec. 28, 2015, 3:43 p.m.)


Review request for Plasma and David Edmundson.


Bugs: 355918
https://bugs.kde.org/show_bug.cgi?id=355918


Repository: sddm-kcm


Description
---

For some reason sddm cannot handle absolute file paths to wallpapers
and also needs the wallpaper to be readable by others.

This is fixed by copying the wallpaper to the root directory of the
selected theme.

On save the sddmauthhelper copies the background from the absolute path
into the theme directory and sets the "background" key of the
theme.user.conf to the copied file. If previously a different background was
set it is removed beforehand.


Diffs
-

  sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 
  src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c 

Diff: https://git.reviewboard.kde.org/r/126524/diff/


Testing
---

Copies and removes backgrounds as intended.
The wallpaper is shown in sddm.


Thanks,

Joshua Noack

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125921: Don't rely graphic objects in panel script engine


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125921/
---

(Updated Dec. 28, 2015, 3:43 p.m.)


Review request for Plasma.


Changes
---

Use a shared function to get the right config


Repository: plasma-workspace


Description
---

The basic design of Plasma is that scripts and and the shell (in theory)
manipulate a tree of basic applet geometry and configs.

Plasmashell then reacts to those changes and displays them visually with
a distinct separation between the layout and UI.

Panel's scriptengine seemed to do away with all, and try and manipulate the 
graphic object directly..which might not exist and that leads to complex code.

This changes it to read/write from the same config object as
PanelView will use. More akin to how the script engine for applet and 
contiainment work.

If there's a view for this panel, we update immediately, otherwise it'll just 
get loaded when it's needed. PanelView::reload() has the error checking/bounds 
management so no point duplicating that.

Idea is to fix the same bug as https://git.reviewboard.kde.org/r/125920/ but 
also clean up a lot of the code which I thought had grown a bit complex. 

Bit too big to backport though. Might be Plasma 5.6 material at this point.


Diffs (updated)
-

  shell/panelview.h 9f8d4ce9c92e86d81aa8076ca8eb01c0eb8a18c9 
  shell/panelview.cpp 4dec906b63bd535b3add732f2f5e3971c0a5f37a 
  shell/scripting/panel.h f7279100a7c79f2f15917b88d8199573a379cb7d 
  shell/scripting/panel.cpp fb0ff2119850823c4fb76f223ed04f0e9c0d0010 

Diff: https://git.reviewboard.kde.org/r/125921/diff/


Testing
---

Modified my layout.js to set min, max sizes as well as alignment and offset 
which were previously broken.

Once loaded opened the interactive editor and run stuff like:
panel = panelById(1);
panel.alignment = "center"
panel.height = 40

Seems to work as before


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions



> On Dez. 28, 2015, 2:19 nachm., Marco Martin wrote:
> > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand 
> > QIcons as it uses IconItem internally
> 
> Kai Uwe Broulik wrote:
> Yes, but iconSource property of QQC Button is of "url" type.
> 
> Kai Uwe Broulik wrote:
> And Plasma Button iconSource is alised to iconName, which is of "string" 
> type.

If we turned iconSource into a property var we could make this work, given we 
just pass whatever's in there to our IconItem. I don't know what implications 
this has, though, since it says "override this property for compatibility".


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90212
---


On Dez. 28, 2015, 12:33 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dez. 28, 2015, 12:33 nachm.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions



> On Dez. 28, 2015, 2:19 nachm., Marco Martin wrote:
> > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand 
> > QIcons as it uses IconItem internally
> 
> Kai Uwe Broulik wrote:
> Yes, but iconSource property of QQC Button is of "url" type.

And Plasma Button iconSource is alised to iconName, which is of "string" type.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90212
---


On Dez. 28, 2015, 12:33 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dez. 28, 2015, 12:33 nachm.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions



> On Dez. 28, 2015, 2:19 nachm., Marco Martin wrote:
> > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand 
> > QIcons as it uses IconItem internally

Yes, but iconSource property of QQC Button is of "url" type.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90212
---


On Dez. 28, 2015, 12:33 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dez. 28, 2015, 12:33 nachm.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90212
---


hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand QIcons as 
it uses IconItem internally

- Marco Martin


On Dec. 28, 2015, 12:33 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dec. 28, 2015, 12:33 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-12-28 Thread Aditya Dev Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Dec. 28, 2015, 2:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Submitted with commit cf570eb71014e517c91f718c02a48b7afaa96418 by Aditya Dev 
Sharma to branch master.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal imageFetched (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs
-

  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/CMakeLists.txt 5a13449 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/CMakeLists.txt a7171b7 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
Works as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126544: [Kickoff] Hide history tab if empty



> On Dec. 28, 2015, 2:04 p.m., David Edmundson wrote:
> > applets/kickoff/package/contents/ui/FullRepresentation.qml, line 65
> > 
> >
> > why?
> > 
> > if were we to do this it should only do it if that tab is currently 
> > open.
> > 
> > and given it won't work this is just wasted code.

Edit. Didn't read the bug properly, I just assumed this was 
https://bugs.kde.org/show_bug.cgi?id=355636

carry on.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/#review90209
---


On Dec. 28, 2015, 2:01 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126544/
> ---
> 
> (Updated Dec. 28, 2015, 2:01 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 347633
> https://bugs.kde.org/show_bug.cgi?id=347633
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This hides the "History" tab if it is empty.
> 
> This can permanently happen if you use disable tracking in activity settings 
> or administrative means.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
>   applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 
> 
> Diff: https://git.reviewboard.kde.org/r/126544/diff/
> 
> 
> Testing
> ---
> 
> Button comes and goes as I add and remove history entries.
> 
> When I clear the history, it switches to the Favorites view so you don't end 
> up with a broken view.
> 
> It doesn't seem to track application launches through Kickoff but I think 
> this is unrelated.
> 
> 
> File Attachments
> 
> 
> No history tab
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126544: [Kickoff] Hide history tab if empty


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/#review90209
---


I don't really like how this is going to decreaes the load time for an 
incredibly niche feature, but in general it's fine.


applets/kickoff/package/contents/ui/FullRepresentation.qml (line 65)


why?

if were we to do this it should only do it if that tab is currently open.

and given it won't work this is just wasted code.


- David Edmundson


On Dec. 28, 2015, 2:01 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126544/
> ---
> 
> (Updated Dec. 28, 2015, 2:01 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 347633
> https://bugs.kde.org/show_bug.cgi?id=347633
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This hides the "History" tab if it is empty.
> 
> This can permanently happen if you use disable tracking in activity settings 
> or administrative means.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
>   applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 
> 
> Diff: https://git.reviewboard.kde.org/r/126544/diff/
> 
> 
> Testing
> ---
> 
> Button comes and goes as I add and remove history entries.
> 
> When I clear the history, it switches to the Favorites view so you don't end 
> up with a broken view.
> 
> It doesn't seem to track application launches through Kickoff but I think 
> this is unrelated.
> 
> 
> File Attachments
> 
> 
> No history tab
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126544: [Kickoff] Hide history tab if empty

2015-12-28 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/#review90210
---


Maybe show it as disabled at least? It's weird that UI structure change every 
now and then.

- Aleix Pol Gonzalez


On Dec. 28, 2015, 3:01 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126544/
> ---
> 
> (Updated Dec. 28, 2015, 3:01 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 347633
> https://bugs.kde.org/show_bug.cgi?id=347633
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This hides the "History" tab if it is empty.
> 
> This can permanently happen if you use disable tracking in activity settings 
> or administrative means.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
>   applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 
> 
> Diff: https://git.reviewboard.kde.org/r/126544/diff/
> 
> 
> Testing
> ---
> 
> Button comes and goes as I add and remove history entries.
> 
> When I clear the history, it switches to the Favorites view so you don't end 
> up with a broken view.
> 
> It doesn't seem to track application launches through Kickoff but I think 
> this is unrelated.
> 
> 
> File Attachments
> 
> 
> No history tab
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126544: [Kickoff] Hide history tab if empty


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/
---

(Updated Dez. 28, 2015, 2:01 nachm.)


Review request for Plasma, KDE Usability and Eike Hein.


Changes
---

The same could also easily be done for the Leave tab, see Bug 355636


Bugs: 347633
https://bugs.kde.org/show_bug.cgi?id=347633


Repository: plasma-desktop


Description
---

This hides the "History" tab if it is empty.

This can permanently happen if you use disable tracking in activity settings or 
administrative means.


Diffs
-

  applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
  applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
  applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 

Diff: https://git.reviewboard.kde.org/r/126544/diff/


Testing
---

Button comes and goes as I add and remove history entries.

When I clear the history, it switches to the Favorites view so you don't end up 
with a broken view.

It doesn't seem to track application launches through Kickoff but I think this 
is unrelated.


File Attachments


No history tab
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126544: [Kickoff] Hide history tab if empty


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/
---

Review request for Plasma, KDE Usability and Eike Hein.


Repository: plasma-desktop


Description
---

This hides the "History" tab if it is empty.

This can permanently happen if you use disable tracking in activity settings or 
administrative means.


Diffs
-

  applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
  applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
  applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 

Diff: https://git.reviewboard.kde.org/r/126544/diff/


Testing
---

Button comes and goes as I add and remove history entries.

When I clear the history, it switches to the Favorites view so you don't end up 
with a broken view.

It doesn't seem to track application launches through Kickoff but I think this 
is unrelated.


File Attachments


No history tab
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: oxygen Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/oxygen%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Dec 2015 12:31:07 +
Build duration: 2 min 18 sec

CHANGE SET
Revision 6afe7689a030c00351fb80cffacbf8c63691fee8 by hugo.pereira: (Call 
updateButtonGeometry after decorationButtonsLeftChanged and)
  change: edit kdecoration/oxygendecoration.h
  change: edit kdecoration/oxygendecoration.cpp
Revision 1dcaee368040692bf6de840465d40fe00a76f899 by hugo.pereira: (For 
standard configuration, rely on KCoreConfigSkeleton::load and ::save)
  change: edit kdecoration/oxygenexceptionlist.cpp
  change: edit kdecoration/oxygenexceptionlist.h
  change: edit kdecoration/config/oxygenconfigwidget.cpp
Revision 8793c22d3e658f2102f94d14a5d6504aaaebc7c6 by hugo.pereira: (removed 
useless oxygenutil simplified load/save api for shadow)
  change: delete liboxygen/oxygenutil.h
  change: delete liboxygen/oxygenutil.cpp
  change: edit liboxygen/oxygenshadowconfigwidget.h
  change: edit liboxygen/oxygenshadowconfigwidget.cpp
  change: edit liboxygen/CMakeLists.txt
  change: edit kdecoration/config/oxygenconfigwidget.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: oxygen Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/oxygen%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Dec 2015 12:31:07 +
Build duration: 2 min 18 sec

CHANGE SET
Revision 6afe7689a030c00351fb80cffacbf8c63691fee8 by hugo.pereira: (Call 
updateButtonGeometry after decorationButtonsLeftChanged and)
  change: edit kdecoration/oxygendecoration.h
  change: edit kdecoration/oxygendecoration.cpp
Revision 1dcaee368040692bf6de840465d40fe00a76f899 by hugo.pereira: (For 
standard configuration, rely on KCoreConfigSkeleton::load and ::save)
  change: edit kdecoration/oxygenexceptionlist.cpp
  change: edit kdecoration/oxygenexceptionlist.h
  change: edit kdecoration/config/oxygenconfigwidget.cpp
Revision 8793c22d3e658f2102f94d14a5d6504aaaebc7c6 by hugo.pereira: (removed 
useless oxygenutil simplified load/save api for shadow)
  change: delete liboxygen/oxygenutil.h
  change: delete liboxygen/oxygenutil.cpp
  change: edit liboxygen/oxygenshadowconfigwidget.h
  change: edit liboxygen/oxygenshadowconfigwidget.cpp
  change: edit liboxygen/CMakeLists.txt
  change: edit kdecoration/config/oxygenconfigwidget.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away



> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > 
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available
> 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it 
> properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> ---||---
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?
> 
> Kai Uwe Broulik wrote:
> The "passive" is still opt in but I shifted the meaning a bit.
> 
> Passive now means "don't bother the user" or "don't draw attention", ie. 
> don't show a notification or dialog whatsoever, only SNI. Sorry, I only wrote 
> into the change summary.
> 
> passive | notifications running | action
> Yes | Yes.. | Show SNI
> Yes | No... | Show SNI
> No. | Yes.. | Show SNI and Notification
> No. | No... | Show DrKonqi dialog directly
> 
> David Edmundson wrote:
> If we go with this, we can effectively just swap the drop the passive 
> flag addition in frameworks and re-use the AutoRestart flag?
> and assume !AutoRestart == Passive
> 
> It's how you're describing the usage in your blog post.
> 
> (would involve Plasma using the existing autorestart rather than doing 
> it's own thing, but I like the idea of that)
> 
> Kai Uwe Broulik wrote:
> +1 to that
> 
> Marco Martin wrote:
> hmm, shouldn't be passive when autorestart is enabled AutoRestart == 
> Passive? when nothing is coming back you want the dialog, when the 
> application/shell comes back is when you can ignore it no?

Yes, AutoRestart == Passive
One thing I found is KCrash doesn't bother bringing up DrKonqi on the last 
restart attempt so you end up with a black screen, if we use KCrash's auto 
restart functionality.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/
---

(Updated Dez. 28, 2015, 12:33 nachm.)

Review request for Plasma, KDE Usability and Vishesh Handa.

Changes
---

Use a ToolButton; when I give it a proper size it works nicely visually

I still had to use an IconItem because the iconName/iconSource in
QtQuick.Controls Button don't work with the QIcon the QAction holds

Repository: milou

Description
---

This brings back support for additional runner actions. A runner can specify
supplemental actions to a search result.

Diffs (updated)
-

lib/CMakeLists.txt 1123b60
lib/qml/ResultDelegate.qml 6d60bf2
lib/qml/ResultsView.qml b36cc19
lib/sourcesmodel.h 6c2d205
lib/sourcesmodel.cpp 65c69b3

Diff: https://git.reviewboard.kde.org/r/126514/diff/

Testing
---

Unfortunately I had to add QtWidgets for QAction :(

File Attachments

Runner action

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png

Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 44 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Dec 2015 12:28:52 +
Build duration: 1 min 50 sec

CHANGE SET
Revision a425b7baa3e44b281d3d5784069d8687f20e7105 by hugo.pereira: (nothing)
  change: edit kstyle/oxygenstyle.cpp
Revision 4280d9b484af5315d9522c682d73462b4b98de7a by hugo.pereira: (Call 
updateButtonGeometry after decorationButtonsLeftChanged and)
  change: edit kdecoration/oxygendecoration.h
  change: edit kdecoration/oxygendecoration.cpp
Revision af5f5feeb61f72acee206835d39f6bf7c5fe9475 by hugo.pereira: (For 
standard configuration, rely on KCoreConfigSkeleton::load and ::save)
  change: edit kdecoration/oxygenexceptionlist.cpp
  change: edit kdecoration/config/oxygenconfigwidget.cpp
  change: edit kdecoration/oxygenexceptionlist.h
Revision 61272549dc0f02839bf2882a6230cd928f162954 by hugo.pereira: (removed 
useless oxygenutil simplified load/save api for shadow)
  change: edit kdecoration/config/oxygenconfigwidget.cpp
  change: edit liboxygen/oxygenshadowconfigwidget.h
  change: delete liboxygen/oxygenutil.h
  change: edit liboxygen/oxygenshadowconfigwidget.cpp
  change: delete liboxygen/oxygenutil.cpp
  change: edit liboxygen/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 44 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Dec 2015 12:28:52 +
Build duration: 1 min 50 sec

CHANGE SET
Revision a425b7baa3e44b281d3d5784069d8687f20e7105 by hugo.pereira: (nothing)
  change: edit kstyle/oxygenstyle.cpp
Revision 4280d9b484af5315d9522c682d73462b4b98de7a by hugo.pereira: (Call 
updateButtonGeometry after decorationButtonsLeftChanged and)
  change: edit kdecoration/oxygendecoration.h
  change: edit kdecoration/oxygendecoration.cpp
Revision af5f5feeb61f72acee206835d39f6bf7c5fe9475 by hugo.pereira: (For 
standard configuration, rely on KCoreConfigSkeleton::load and ::save)
  change: edit kdecoration/oxygenexceptionlist.cpp
  change: edit kdecoration/config/oxygenconfigwidget.cpp
  change: edit kdecoration/oxygenexceptionlist.h
Revision 61272549dc0f02839bf2882a6230cd928f162954 by hugo.pereira: (removed 
useless oxygenutil simplified load/save api for shadow)
  change: edit kdecoration/config/oxygenconfigwidget.cpp
  change: edit liboxygen/oxygenshadowconfigwidget.h
  change: delete liboxygen/oxygenutil.h
  change: edit liboxygen/oxygenshadowconfigwidget.cpp
  change: delete liboxygen/oxygenutil.cpp
  change: edit liboxygen/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 350 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/350/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Dec 2015 11:37:46 +
Build duration: 5 min 5 sec

CHANGE SET
Revision 60c84bd7cdb07cd46b294ff4e03034a151fe109f by David Edmundson: (destroy 
the container window we create)
  change: edit xembed-sni-proxy/sniproxy.cpp
Revision 3ff5cdd3cf75c7d9d7edd72d88dd1c440fb1995d by David Edmundson: 
(Don't duplicate a tonne of KCrash)
  change: edit shell/shellmanager.cpp
  change: edit shell/shellmanager.h
  change: edit shell/main.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 
test(s)Failed: TestSuite.testdesktop

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1673/2105 
(79%)CONDITIONAL 1208/1810 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 104/152 (68%)CONDITIONAL 
37/62 (60%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 64/66 (97%)CONDITIONAL 
25/46 (54%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126538: Don't duplicate a tonne of KCrash code


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/
---

(Updated Dec. 28, 2015, 11:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 3ff5cdd3cf75c7d9d7edd72d88dd1c440fb1995d by David 
Edmundson to branch master.


Repository: plasma-workspace


Description
---

KCrash already has auto restart which copies the args and only respawns
n times, resetting if we last longer than m seconds.

Timeouts are sligthly different, but if changes are genuinely needed we can add 
options to KCrash.


Diffs
-

  shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
  shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
  shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 

Diff: https://git.reviewboard.kde.org/r/126538/diff/


Testing
---

Ran with -w

killed -s SIGSEGV

windowed version restarted


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126499/
---

(Updated Dec. 28, 2015, 11:31 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 1ff63c257ec57dcc5c13507981ea8ec1fc79544e by David 
Edmundson to branch master.


Repository: plasma-desktop


Description
---

BUG: 356874


Diffs
-

  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 
9d04d0aa8b53f219e937228f91abee5ff439d02a 

Diff: https://git.reviewboard.kde.org/r/126499/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126538: Don't duplicate a tonne of KCrash code


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/#review90204
---

Ship it!


Ship It!

- Marco Martin


On Dec. 28, 2015, 9:59 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126538/
> ---
> 
> (Updated Dec. 28, 2015, 9:59 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KCrash already has auto restart which copies the args and only respawns
> n times, resetting if we last longer than m seconds.
> 
> Timeouts are sligthly different, but if changes are genuinely needed we can 
> add options to KCrash.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
>   shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
>   shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 
> 
> Diff: https://git.reviewboard.kde.org/r/126538/diff/
> 
> 
> Testing
> ---
> 
> Ran with -w
> 
> killed -s SIGSEGV
> 
> windowed version restarted
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126538: Don't duplicate a tonne of KCrash code


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/
---

(Updated Dec. 28, 2015, 9:59 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

KCrash already has auto restart which copies the args and only respawns
n times, resetting if we last longer than m seconds.

Timeouts are sligthly different, but if changes are genuinely needed we can add 
options to KCrash.


Diffs
-

  shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
  shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
  shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 

Diff: https://git.reviewboard.kde.org/r/126538/diff/


Testing (updated)
---

Ran with -w

killed -s SIGSEGV

windowed version restarted


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126538: Don't duplicate a tonne of KCrash code


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/
---

(Updated Dec. 28, 2015, 9:58 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

KCrash already has auto restart which copies the args and only respawns
n times, resetting if we last longer than m seconds.

Timeouts are sligthly different, but if changes are genuinely needed we can add 
options to KCrash.


Diffs (updated)
-

  shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
  shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
  shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 

Diff: https://git.reviewboard.kde.org/r/126538/diff/


Testing
---

None.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-28 Thread Ivan Čukić



> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote:
> > I have mixed feelings about this one. (to oppose those that are against it, 
> > and those that are for it)
> > 
> > I like the picture. It would be awesome as a background for some 
> > kde-plasma-related brochures, videos etc.
> > 
> > I'm not convinced that it is suitable as a (especially the default) 
> > wallpaper. It mixes too many styles in one place (dots, irregular 
> > triangles, regular dark triangles, regular colourful triangles, and the 
> > intel-glitch-bar).
> > 
> > But I'm afraid that removing any of them just might make the wallpaper 
> > ordinary, even boring. (I think that even removing the intel-glitch-bar 
> > might be problematic)
> 
> Ken Vermette wrote:
> I agree looking at the changes that dropping the glitch bar has definitly 
> eroded some of the personality of the image, but from a functional 
> perspective removing the intel-glitch-bar is making a huge difference in 
> pulling the styles together. Probably because the bar was so different 
> compared to anything else in the image.
> 
> Plus it's not really the wallpapers job to stand out that much, so I'm 
> coming around to simplifying things a bit. Compared to some other wallpapers 
> out there I wouldn't say we're boring in comparison, but I think it did need 
> to be reeled in a bit from the increasing craziness. If we do want to use 
> elements of this style in other materials, I definitly wouldn't want it 
> overpowering the more meaningful content as well.
> 
> Anyway, without the glitch bar, what are your thoughts? Roughly the same 
> or has it helped?
> 
> Ivan Čukić wrote:
> For some reason, I can't open it. Keep getting '403 forbidden' for all 
> the new ones - like this:
> 
> You don't have permission to access 
> /media/uploaded/files/2015/12/27/bc1de0b2-a753-4772-b5a7-8d5c27c0138b__desktopWallpaper-graphite-3.3-kvermette.png
>  on this server.
> 
> Ken Vermette wrote:
> That's weird. Probably because I copied/pasted a bad link. It's listed in 
> the files area of this review as 
> "desktopWallpaper-graphite-3.3-kvermette.png".
> 
> Ivan Čukić wrote:
> Still forbidden...
> 
> Ken Vermette wrote:
> :/
> It's not showing up for me now either... Which is especially odd since it 
> looks like a couple others can see it.
> 
> Alrighty, since reviewboard seems to have an issue with the attachment, 
> here's a link to the image in the VDG share:
> https://share.kde.org/index.php/s/isKQ6WHNxkQp64F

Thanks for posting to share.kde.org!

The green bar is less appealing than the previous version, but I agree with 
Marco - 'Ship it!'


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review90131
---


On Dec. 27, 2015, 12:22 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dec. 27, 2015, 12:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
> 
> 
> Testing
> ---
> 
> Dogfooded on several machines and my phone for a couple weeks now, doesn't 
> burn eyes out. Corner isn't as distracting as one might assume, especially 
> once a window is on screen. Got early feedback, adjustments made from 
> origional in order:
>  - Re-drew the "circuit/chip" pattern to be less

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-28 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review90201
---


What about just adding a property to disable animation (as Eike suggested) and 
disable it for icon in tooltips?

Currently, only the icon is animated when the tooltip contents change, text 
(tooltip title, subtitle) is changed immediately. I think it would look better 
if either both were animated, or neither.

Also right now, the tooltips from systray (all tooltips without custom 
contents) don't have the crossfade animation at all, so I can no longer 
reproduce this bug.

- David Rosca


On Dec. 28, 2015, 12:17 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> ---
> 
> (Updated Dec. 28, 2015, 12:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We have a lot of reusable singletons that are just hidden when unneeded 
> (tooltip, osd). IconItem, however, will always fade from the previous state, 
> even if the previous action happened minutes ago.
> 
> This patch makes it track its visibility and skip the fade-and-wait dance 
> when it just became visible. It also removes a visible false call in the 
> tooltip which I didn't know what it was for. (With it in place, the IconItem 
> always becomes visible when moving between tooltip areas, breaking the 
> animation altogether).
> 
> @Eike: Could you check whether this makes it more viable for Kicker?
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 528f57c 
>   src/declarativeimports/core/iconitem.cpp 1e8260e 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
> 
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
> 
> 
> Testing
> ---
> 
> Moving between tray icons - icon fades, moving relly rapidly causes it 
> not to load any icon until you halt (dunno if that happened before but 
> doesn't seem too bad)
> Hovering tray icon, leaving, waiting, hovering another one - icon does not 
> fade, is there right away
> Notifications also don't fade from the previously issued notification icon
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126538: Don't duplicate a tonne of KCrash code



> On Dec. 28, 2015, 9:20 a.m., Marco Martin wrote:
> > Did you try if particular options are used, like a different shell, 
> > plasmashell gets restarted with the same ones, same shell plugin?

It does.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/#review90193
---


On Dec. 27, 2015, 9:10 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126538/
> ---
> 
> (Updated Dec. 27, 2015, 9:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KCrash already has auto restart which copies the args and only respawns
> n times, resetting if we last longer than m seconds.
> 
> Timeouts are sligthly different, but if changes are genuinely needed we can 
> add options to KCrash.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
>   shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
>   shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 
> 
> Diff: https://git.reviewboard.kde.org/r/126538/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126514: [Milou/KRunner] Support runner actions


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90199
---


+1 from me


lib/qml/ResultDelegate.qml (line 142)


hmm, I think i would prefer it as a ToolButton


- Marco Martin


On Dec. 25, 2015, 4:02 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> ---
> 
> (Updated Dec. 25, 2015, 4:02 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> ---
> 
> This brings back support for additional runner actions. A runner can specify 
> supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight 
> blends in much better, although I'm not too happy with the huge Plasma 
> tooltip. I'm not sure how keyboard interaction should work as both Tab and 
> arrow keys would conflict with navigation.
> 
> 
> Diffs
> -
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> ---
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious 
> ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" 
> actions. The Solid runner supposedly also adds actions but I couldn't get 
> that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> 
> 
> Runner action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/
---

(Updated Dec. 28, 2015, 9:37 a.m.)


Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
and Simon Wächter.


Repository: extra-cmake-modules


Description
---

templates are very useful as teaching tool in order to make
a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks


Diffs (updated)
-

  docs/kde-module/KDEPackageAppTemplates.rst PRE-CREATION 
  kde-modules/KDEInstallDirs.cmake b7cd34d 
  kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
  tests/CMakeLists.txt 1a66f56 
  tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/check.cmake.in PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
  
tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
 PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
PRE-CREATION 
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126185/diff/


Testing
---

done some templates installed by plasma-framework


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked



> On Dec. 27, 2015, 4:54 p.m., Kai Uwe Broulik wrote:
> > desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml,
> >  line 106
> > 
> >
> > You didn't specify a width, ie. there'll be no wrapping

yeah, there should be no Row, the label should have left/right anchors and 
wrapping explicitly enabled


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126499/#review90157
---


On Dec. 24, 2015, 1:43 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126499/
> ---
> 
> (Updated Dec. 24, 2015, 1:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> BUG: 356874
> 
> 
> Diffs
> -
> 
>   
> desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 
> 9d04d0aa8b53f219e937228f91abee5ff439d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/126499/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126499/#review90197
---

Ship it!


I prefer having the message inline under the combobox rather something that 
looks like a kmessagewidget in this case btw,
so +1 from me

- Marco Martin


On Dec. 24, 2015, 1:43 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126499/
> ---
> 
> (Updated Dec. 24, 2015, 1:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> BUG: 356874
> 
> 
> Diffs
> -
> 
>   
> desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 
> 9d04d0aa8b53f219e937228f91abee5ff439d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/126499/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away



> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > 
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available
> 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it 
> properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> ---||---
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?
> 
> Kai Uwe Broulik wrote:
> The "passive" is still opt in but I shifted the meaning a bit.
> 
> Passive now means "don't bother the user" or "don't draw attention", ie. 
> don't show a notification or dialog whatsoever, only SNI. Sorry, I only wrote 
> into the change summary.
> 
> passive | notifications running | action
> Yes | Yes.. | Show SNI
> Yes | No... | Show SNI
> No. | Yes.. | Show SNI and Notification
> No. | No... | Show DrKonqi dialog directly
> 
> David Edmundson wrote:
> If we go with this, we can effectively just swap the drop the passive 
> flag addition in frameworks and re-use the AutoRestart flag?
> and assume !AutoRestart == Passive
> 
> It's how you're describing the usage in your blog post.
> 
> (would involve Plasma using the existing autorestart rather than doing 
> it's own thing, but I like the idea of that)
> 
> Kai Uwe Broulik wrote:
> +1 to that

hmm, shouldn't be passive when autorestart is enabled AutoRestart == Passive? 
when nothing is coming back you want the dialog, when the application/shell 
comes back is when you can ignore it no?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dec. 27, 2015, 4:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dec. 27, 2015, 4:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-28 Thread Bhushan Shah



> On Dec. 28, 2015, 2:42 a.m., David Edmundson wrote:
> > shell/main.cpp, line 97
> > 
> >
> > oh, I probably want to keep this and set the flag as appropriate.

Yep it is useful.


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/#review90184
---


On Dec. 28, 2015, 2:40 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126538/
> ---
> 
> (Updated Dec. 28, 2015, 2:40 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KCrash already has auto restart which copies the args and only respawns
> n times, resetting if we last longer than m seconds.
> 
> Timeouts are sligthly different, but if changes are genuinely needed we can 
> add options to KCrash.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
>   shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
>   shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 
> 
> Diff: https://git.reviewboard.kde.org/r/126538/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126538: Don't duplicate a tonne of KCrash code


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/#review90193
---


Did you try if particular options are used, like a different shell, plasmashell 
gets restarted with the same ones, same shell plugin?

- Marco Martin


On Dec. 27, 2015, 9:10 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126538/
> ---
> 
> (Updated Dec. 27, 2015, 9:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KCrash already has auto restart which copies the args and only respawns
> n times, resetting if we last longer than m seconds.
> 
> Timeouts are sligthly different, but if changes are genuinely needed we can 
> add options to KCrash.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
>   shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
>   shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 
> 
> Diff: https://git.reviewboard.kde.org/r/126538/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper