[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

[Martin Gräßlin]

graesslin added a comment.


  On X11 I agree, there is no point in this change. On Wayland there is, 
because on Wayland attacking the lock screen is the best way to gain user's 
password.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, davidedmundson, colomar
Cc: ahartmetz, mak, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D858: [server] Expose executable path in ClientConnection

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDaefcc51d0727: [server] Expose executable path in 
ClientConnection (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D858?vs=2089=2095

REVISION DETAIL
  https://phabricator.kde.org/D858

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_display.cpp
  src/server/clientconnection.cpp
  src/server/clientconnection.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, mart, davidedmundson
Cc: bshah, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126848: Remove unused dependency in kgamma

[Michael Palimaka]

> On Jan. 25, 2016, 2:41 p.m., Aleix Pol Gonzalez wrote:
> > Such patches could go in automatically, no need to get them in a RR.

Suits me fine, but some people did ask for RR in the past.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126848/#review91578
---


On Jan. 22, 2016, 6:08 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126848/
> ---
> 
> (Updated Jan. 22, 2016, 6:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kgamma5
> 
> 
> Description
> ---
> 
> I can't find any usage of Qt5X11Extras, so remove it.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 264a457b3903158be4a90dbc01b0f6e63b5448ed 
> 
> Diff: https://git.reviewboard.kde.org/r/126848/diff/
> 
> 
> Testing
> ---
> 
> Inspected source, builds.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 15 lines] D861: Port away from kdelibs4support

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: bshah.
graesslin added a subscriber: plasma-devel.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-kdelibs4support

REVISION DETAIL
  https://phabricator.kde.org/D861

AFFECTED FILES
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126883/
---

Review request for KDE Frameworks, Plasma and Marco Martin.


Repository: kpackage


Description
---

This method is intended to replace contentsHash which operates only
on Sha1. In order to support more secure hashing algorithmns and also
to support future developments the new implementation does not hard
code the algorithm but allows to specify it. By that the existing
implementation can just delegate to the new one.

Another change in the implementation is that the new cryptographicHash
method returns a QByteArray instead of a QString. As only a hex
representation of the hash is returned the conversion to QString is
not necessary.

Package::contentsHash() is marked as deprecated.


Diffs
-

  autotests/plasmoidpackagetest.cpp 69f45f57bbec5c0f6d2268869249606c50338765 
  src/kpackage/package.h b97b70be42df7d9fd09e3fb4e7b82b00ef970be3 
  src/kpackage/package.cpp 4c0f671965d9ed33b9f52b06205bf6ffcda94c8a 

Diff: https://git.reviewboard.kde.org/r/126883/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126848: Remove unused dependency in kgamma

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126848/#review91578
---


Ship it!




Such patches could go in automatically, no need to get them in a RR.

- Aleix Pol Gonzalez


On Jan. 22, 2016, 7:08 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126848/
> ---
> 
> (Updated Jan. 22, 2016, 7:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kgamma5
> 
> 
> Description
> ---
> 
> I can't find any usage of Qt5X11Extras, so remove it.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 264a457b3903158be4a90dbc01b0f6e63b5448ed 
> 
> Diff: https://git.reviewboard.kde.org/r/126848/diff/
> 
> 
> Testing
> ---
> 
> Inspected source, builds.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126848: Remove unused dependency in kgamma

[Aleix Pol Gonzalez]

> On gen. 25, 2016, 3:41 p.m., Aleix Pol Gonzalez wrote:
> > Such patches could go in automatically, no need to get them in a RR.
> 
> Michael Palimaka wrote:
> Suits me fine, but some people did ask for RR in the past.

Ok, then keep them coming :)


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126848/#review91578
---


On gen. 22, 2016, 7:08 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126848/
> ---
> 
> (Updated gen. 22, 2016, 7:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kgamma5
> 
> 
> Description
> ---
> 
> I can't find any usage of Qt5X11Extras, so remove it.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 264a457b3903158be4a90dbc01b0f6e63b5448ed 
> 
> Diff: https://git.reviewboard.kde.org/r/126848/diff/
> 
> 
> Testing
> ---
> 
> Inspected source, builds.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma Hangout

[Sebastian Kügler]

Minutes Plasma 'hangout', 25-1-2016, 12:00 CET

Present: notmart, kbroulik, mgraesslin, bshah, sebas, jens


kbroulik:
* Unity Launcher and Application Job support for Task Manager has landed, you 
now get download progress in eg. Chrome/ium in task manager, as well as eg. 
when copying files in KDE applications, please test/provide feedback
* Media Controller now supports multiple players (if there's more than one 
running you get a combobox); in addition to that media controls (play/pause/
previous/next) including album art are now provided on window tooltips of 
media players
* Applets can now completely hide on the Panel (HiddenStatus), used for the 
pager now, could be used for quick chat applet and others. They'll re-appear 
when entering panelcontroller so they can still be configured, advantage over 
the previous size hacks we used.
* Device Notifier now provides inline feedback, ie. mount errors and unmount 
notification are now shown next to the device; the status bar is gone now, 
please test/provide feedback, QtQuick Layouts glitch a lot there 

notmart:
- worked on simplified systemtray
- added battery percentage to phone homescreen
- removing fake lock screen

bshah:
- I am currently looking into better way for mobile IMG generation. that is 
using livebuild
- Also looking into upgrading base to xenial from vivid
- Willl look into integrating lockscreen on mobile as Marco reported today

jens:
- finished icons for Martin
- did a banner for FOSDEM
- worked on neon web page (Ken is back!)

sebas:
- worked on a protocol with Martin and Marco to do window preview (see plasma-
devel list)
- discussed with Martin the strategy for implementing screen management in 
Kwin's DRM backend

mgraesslin:
- had a technical problems, so didn't report or listen

-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D861: Port away from kdelibs4support

[apol (Aleix Pol Gonzalez)]

apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-kdelibs4support

REVISION DETAIL
  https://phabricator.kde.org/D861

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, apol
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358531] New: Dual-Screen only wake up external Screen after system sleep

[Samuel Suther via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358531

Bug ID: 358531
   Summary: Dual-Screen only wake up external Screen after system
sleep
   Product: Powerdevil
   Version: 5.5.3
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: s.sut...@gmx.de

After Laptop (ASUS N76 VZ) wake up from sleep, Laptop-Screen keeps black.

Reproducible: Always




I have checkd the Syslogs and find out, powerdevil set Backlight to 0 for
sleep.
Then I've tryed to push FN+Brightness up, and the screen gets visible again...

So may be a bug, that powerdevil not set the Backlight back to value which was
set before Laptop go to sleep.


Logs:


Jan 25 12:53:42 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen: Primary output changed from
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to KScreen::Output(Id: 68 ,
Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen: Primary output changed from
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to KScreen::Output(Id: 68 ,
Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen.kded: Change detected
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen.kded: Saving current config
to file
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen.kded: Calculating config ID
for KScreen::Config(0x236ab70)
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen.kded: Part of the Id:
 "2dee63839e69fd3edf5be04e5b814d99"
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen.kded: Part of the Id:
 "7cac412b49e984aeb4a3d63cfd462266"
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen.kded: Config ID:
"cff3ea5ac1299cfd8d80bd5de3944ad8"
Jan 25 12:53:42 secondone kdeinit5[1263]: kscreen.kded: Config saved on: 
"/home/suther/.local/share/kscreen/cff3ea5ac1299cfd8d80bd5de3944ad8"
Jan 25 12:53:44 secondone ksmserver[1291]: UnmapNotify: 60817582
Jan 25 12:53:44 secondone ksmserver[1291]: UnmapNotify: 60817582
Jan 25 12:53:55 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:55 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:55 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:55 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:55 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:55 secondone kscreen_backend_launcher[1309]: kscreen: Primary
output changed from KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" ) to
KScreen::Output(Id: 68 , Name: "VGA1" ) ( "VGA1" )
Jan 25 12:53:55 secondone kscreen_backend_launcher[1309]: kscreen: Primary

[Differential] [Updated] D861: Port away from kdelibs4support

[Martin Gräßlin]

graesslin added a project: Plasma.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D861

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91586
---


Ship it!




Looks good, thanks!

- Martin Klapetek


On Jan. 24, 2016, 10:58 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Jan. 24, 2016, 10:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Kai Uwe Broulik]

> On Jan. 15, 2016, 4:04 nachm., Lamarque Souza wrote:
> > kded/notification.cpp, line 56
> > 
> >
> > It would be safer to add an inhibit to guarantee onPrepareForSleep() 
> > has finished before letting NetworkManager to continue to sleep. On the 
> > other hand, onPrepareForSleep() is simple code and can finish very fast, 
> > maybe an inhibit is a bit overkill, who knows?

I think it's a bit of an overkill to have this. Also I don't want to 
unneccessarily delay suspending just because of a convenience feature like this.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91153
---


On Jan. 15, 2016, 3:03 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 15, 2016, 3:03 nachm.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126848: Remove unused dependency in kgamma

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126848/
---

(Updated Jan. 25, 2016, 3:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit b9173ba3c4d610b42bc174a1621cb9eb3f14dd78 by Michael 
Palimaka to branch master.


Repository: kgamma5


Description
---

I can't find any usage of Qt5X11Extras, so remove it.


Diffs
-

  CMakeLists.txt 264a457b3903158be4a90dbc01b0f6e63b5448ed 

Diff: https://git.reviewboard.kde.org/r/126848/diff/


Testing
---

Inspected source, builds.


Thanks,

Michael Palimaka

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

[ahartmetz (Andreas Hartmetz)]

ahartmetz added a comment.


  A good rule is that if you want to protect against a security issue, you must 
first explain why the user is not already screwed.
  If a malicious app is running and can disable the screen locker (or not), the 
security state transition is from "the user is completely screwed" to "the user 
is completely screwed". If you have a rogue process running, it has almost 
infinite ways to grab the user's information and whatnot. Disabling the screen 
locker is not the problem at that point.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, davidedmundson, colomar
Cc: ahartmetz, mak, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126843/#review91599
---


Ship it!




Looks good to me, thanks!

- Martin Klapetek


On Jan. 25, 2016, 8:48 p.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126843/
> ---
> 
> (Updated Jan. 25, 2016, 8:48 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> ---
> 
> Currently, kwallet-pam is only usable when used in combination with plasma5, 
> becaue the code that connects PAM created socket to kwalletd is in startkde 
> script.
> 
> Move that code into kwallet-pam itself and add an autostart desktop file so 
> it can be used in plasma and outside of plasma (ie, gnome). Also add a check 
> for socat executable, which is required to connect to the socket.
> 
> v2: Incorporate changes mentioned by Martin, remove CMake version requirement 
> increase.
> 
> I tried using feature summary, but it wouldn't fail when I remove the 
> executable.
> 
> v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for 
> extra-cmake-modules, which is now being used by this package.
> 
> v4: Removed OnlyShownIn line from the desktop file as suggested by Xuetian 
> and Martin.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8bd526e 
>   pam_kwallet_init PRE-CREATION 
>   pam_kwallet_init.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126843/diff/
> 
> 
> Testing
> ---
> 
> Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, 
> I was still asked for password in GNOME.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Lamarque Souza]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91598
---


Ship it!




Ship It!

- Lamarque Souza


On Jan. 15, 2016, 3:03 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 15, 2016, 3:03 p.m.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Lamarque Souza]

> On Jan. 15, 2016, 4:04 p.m., Lamarque Souza wrote:
> > kded/notification.cpp, line 56
> > 
> >
> > It would be safer to add an inhibit to guarantee onPrepareForSleep() 
> > has finished before letting NetworkManager to continue to sleep. On the 
> > other hand, onPrepareForSleep() is simple code and can finish very fast, 
> > maybe an inhibit is a bit overkill, who knows?
> 
> Kai Uwe Broulik wrote:
> I think it's a bit of an overkill to have this. Also I don't want to 
> unneccessarily delay suspending just because of a convenience feature like 
> this.

Ok then. Ship it.


- Lamarque


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91153
---


On Jan. 15, 2016, 3:03 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> ---
> 
> (Updated Jan. 15, 2016, 3:03 p.m.)
> 
> 
> Review request for Plasma, Jan Grulich and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> It's quite natural that the connection goes away when we're about to suspend 
> :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -
> 
>   kded/networkmanagement.notifyrc 7ce437c 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> ---
> 
> While I still think Plasma-NM is waay too verbose about everything, at 
> least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after 
> resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

[Armin K.]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126843/
---

(Updated Jan. 25, 2016, 7:48 p.m.)


Review request for Plasma and Martin Klapetek.


Repository: kwallet-pam


Description (updated)
---

Currently, kwallet-pam is only usable when used in combination with plasma5, 
becaue the code that connects PAM created socket to kwalletd is in startkde 
script.

Move that code into kwallet-pam itself and add an autostart desktop file so it 
can be used in plasma and outside of plasma (ie, gnome). Also add a check for 
socat executable, which is required to connect to the socket.

v2: Incorporate changes mentioned by Martin, remove CMake version requirement 
increase.

I tried using feature summary, but it wouldn't fail when I remove the 
executable.

v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for 
extra-cmake-modules, which is now being used by this package.

v4: Removed OnlyShownIn line from the desktop file as suggested by Xuetian and 
Martin.


Diffs (updated)
-

  CMakeLists.txt 8bd526e 
  pam_kwallet_init PRE-CREATION 
  pam_kwallet_init.desktop.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126843/diff/


Testing
---

Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I 
was still asked for password in GNOME.


Thanks,

Armin K.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/#review91561
---



Pointing out the obvious: though shall not animate window positions! This needs 
to be moved to KWin (I'm disappointed that such code still exists in 
frameworks). Which would kind of solve the problems automatically.

Of course that comment is orthogonal to this review request: improvement is 
always good.


src/declarativeimports/core/tooltip.cpp (line 160)


why bind it to compositingActive?


- Martin Gräßlin


On Jan. 24, 2016, 4:20 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126870/
> ---
> 
> (Updated Jan. 24, 2016, 4:20 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Bugs: 354353
> http://bugs.kde.org/show_bug.cgi?id=354353
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip 
> animation transition between item to decrease it permormance and looks quite 
> ugly. If add new panel animation is *cool* as is. The perfermonce decrease 
> can be cause due to swap use, or QPropertyAnimation issue, however we (you 
> KDE defs and i *like a user*) wants plasmashell and it's components (like 
> panel) to works *forever*
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.h 2ea8af9 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
> 
> Diff: https://git.reviewboard.kde.org/r/126870/diff/
> 
> 
> Testing
> ---
> 
> Workaround is quite simple:
> Animation is refreshed as is, pointer hasn't same lifetime as panel
> + Animation is disabled if compositing is not active
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D827: Suspend/Hibernate through daemon instead of greeter

[Martin Gräßlin]

graesslin marked 3 inline comments as done.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D827

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, Plasma, broulik
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 461 lines] D827: Suspend/Hibernate through daemon instead of greeter

[Martin Gräßlin]

graesslin updated this revision to Diff 2085.
graesslin added a comment.


  Fixed issues outlined by Kai.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D827?vs=1980=2085

BRANCH
  powermanagement-daemon

REVISION DETAIL
  https://phabricator.kde.org/D827

AFFECTED FILES
  CMakeLists.txt
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  powermanagement.cpp
  powermanagement.h
  protocols/ksld.xml
  tests/CMakeLists.txt
  tests/powermanagement.qml
  tests/powermanagementtest.cpp
  waylandserver.cpp
  waylandserver.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, Plasma, broulik
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D827: Suspend/Hibernate through daemon instead of greeter

[bshah (Bhushan Shah)]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  powermanagement-daemon

REVISION DETAIL
  https://phabricator.kde.org/D827

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, broulik, Plasma, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

[Martin Gräßlin]

> On Jan. 22, 2016, 10:33 p.m., Xuetian Weng wrote:
> > pam_kwallet_init.desktop.cmake, line 7
> > 
> >
> > Why limit to these desktop anyway? I don't see why this is necessary. 
> > (e.g. why not lxqt?)
> 
> Armin K. wrote:
> Hmm, I copied that line from baloo_file.desktop. I suppose it should be 
> safe to remove it entirely, no?

yes, please remove. It makes sense in the case of baloo, but not so much in 
this case (especially as it's going to autostart anyway).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126843/#review91457
---


On Jan. 22, 2016, 8:08 p.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126843/
> ---
> 
> (Updated Jan. 22, 2016, 8:08 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> ---
> 
> Currently, kwallet-pam is only usable when used in combination with plasma5, 
> becaue the code that connects PAM created socket to kwalletd is in startkde 
> script.
> 
> Move that code into kwallet-pam itself and add an autostart desktop file so 
> it can be used in plasma and outside of plasma (ie, gnome). Also add a check 
> for socat executable, which is required to connect to the socket.
> 
> v2: Incorporate changes mentioned by Martin, remove CMake version requirement 
> increase.
> 
> I tried using feature summary, but it wouldn't fail when I remove the 
> executable.
> 
> v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for 
> extra-cmake-modules, which is now being used by this package.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8bd526e 
>   pam_kwallet_init PRE-CREATION 
>   pam_kwallet_init.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126843/diff/
> 
> 
> Testing
> ---
> 
> Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, 
> I was still asked for password in GNOME.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

[Marco Martin]

> On Jan. 21, 2016, 11:06 a.m., Marco Martin wrote:
> > I'm in general in favor of that, mostly for the scenario we find some 
> > actual rendering bug in the svg rendering code, that then gets cached
> 
> Kai Uwe Broulik wrote:
> Is there a better way to store the version? I recall in KCache or so you 
> can store custom properties? I don't want to end up with 16 MiB of unused 
> cache after every upgrade.

well, a kimagecache/kshareddatacache stores key/qbytearray, so you could also 
put a string in there...
anyways, you shouldn't generate a new file, but rather just delete the existing 
cache when the version changes


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126642/#review91402
---


On Jan. 5, 2016, 6:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126642/
> ---
> 
> (Updated Jan. 5, 2016, 6:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We have the version number of the theme and some mtime heuristic yet still we 
> often end up with a broken theme after upgrades when it is changed, when 
> downstreams forget to adjust the version in their theme and so on.
> 
> (I just noticed I never delete the old theme caches...)
> 
> 
> Diffs
> -
> 
>   src/plasma/private/theme_p.cpp 18419bb 
> 
> Diff: https://git.reviewboard.kde.org/r/126642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 23 lines] D858: [server] Expose executable path in ClientConnection

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: sebas, mart.
graesslin added a subscriber: plasma-devel.

REVISION SUMMARY
  Convenient API to get the absolute executable path for the pid.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  executable-path

REVISION DETAIL
  https://phabricator.kde.org/D858

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_display.cpp
  src/server/clientconnection.cpp
  src/server/clientconnection.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126851/#review91568
---


Ship it!




on the fence about this.
it's a rename of a semi public thing that may cause problems, but if it breaks 
the qml model uhm, ok

- Marco Martin


On Jan. 23, 2016, 2 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126851/
> ---
> 
> (Updated Jan. 23, 2016, 2 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I wrote a qml applet using the places data engine and noticed that I can't 
> access the index variable of ListView items because it gets overwritten by 
> the places model.
> This patch renames the "index" role name to "id" in order to avoid this 
> naming conflict.
> 
> 
> Diffs
> -
> 
>   dataengines/places/org.kde.places.operations 98a951d 
>   dataengines/places/placeservice.cpp e0c93c5 
>   dataengines/places/placesproxymodel.h 467fe83 
>   dataengines/places/placesproxymodel.cpp 5ea807b 
> 
> Diff: https://git.reviewboard.kde.org/r/126851/diff/
> 
> 
> Testing
> ---
> 
> I couldn't find any other model that is using the places data engine so I 
> hope renaming the model role is fine.
> The provided model still works and I tested the "Setup Device" and "Teardown 
> Device" operations of the service.
> The operations "Show" and "Hide" don't seem to work anyway and the others 
> were not tested.
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D787: Properly set modality on AuthDialog

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPOLKITKDEAGENT2abe1fe105d0: Properly set modality on 
AuthDialog (authored by graesslin).

REPOSITORY
  rPOLKITKDEAGENT Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D787?vs=1875=2087

REVISION DETAIL
  https://phabricator.kde.org/D787

AFFECTED FILES
  AuthDialog.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, davidedmundson
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

[David Edmundson]

> On Jan. 21, 2016, 11:06 a.m., Marco Martin wrote:
> > I'm in general in favor of that, mostly for the scenario we find some 
> > actual rendering bug in the svg rendering code, that then gets cached
> 
> Kai Uwe Broulik wrote:
> Is there a better way to store the version? I recall in KCache or so you 
> can store custom properties? I don't want to end up with 16 MiB of unused 
> cache after every upgrade.
> 
> Marco Martin wrote:
> well, a kimagecache/kshareddatacache stores key/qbytearray, so you could 
> also put a string in there...
> anyways, you shouldn't generate a new file, but rather just delete the 
> existing cache when the version changes

we need to be careful there, we potentially have n programs all sharing the 
same cache.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126642/#review91402
---


On Jan. 5, 2016, 6:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126642/
> ---
> 
> (Updated Jan. 5, 2016, 6:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We have the version number of the theme and some mtime heuristic yet still we 
> often end up with a broken theme after upgrades when it is changed, when 
> downstreams forget to adjust the version in their theme and so on.
> 
> (I just noticed I never delete the old theme caches...)
> 
> 
> Diffs
> -
> 
>   src/plasma/private/theme_p.cpp 18419bb 
> 
> Diff: https://git.reviewboard.kde.org/r/126642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D858: [server] Expose executable path in ClientConnection

[bshah (Bhushan Shah)]

bshah added a comment.


  +1, Looks good to me.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D858

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, mart
Cc: bshah, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D859: [processui] Safety checks for platform != x11

[Martin Gräßlin]

graesslin added a project: Plasma.

REPOSITORY
  rLIBKSYSGUARD KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D859

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, sebas
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 31 lines] D859: [processui] Safety checks for platform != x11

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: mart, sebas.
graesslin added a subscriber: plasma-devel.

REVISION SUMMARY
  Starting Ksysguard on Wayland resulted in a crash as it unconditionally
  calls into X11. This change performs some sanity checks and hides the
  X11 specific columns from the view.

TEST PLAN
  Run on Wayland, started and worked

REPOSITORY
  rLIBKSYSGUARD KSysguard Library

BRANCH
  fix-on-wayland

REVISION DETAIL
  https://phabricator.kde.org/D859

AFFECTED FILES
  processui/ProcessModel.cpp
  processui/ProcessModel_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, sebas
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D859: [processui] Safety checks for platform != x11

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.

REPOSITORY
  rLIBKSYSGUARD KSysguard Library

BRANCH
  fix-on-wayland

REVISION DETAIL
  https://phabricator.kde.org/D859

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, sebas, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D827: Suspend/Hibernate through daemon instead of greeter

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  powermanagement-daemon

REVISION DETAIL
  https://phabricator.kde.org/D827

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, bshah, broulik
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D827: Suspend/Hibernate through daemon instead of greeter

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENLOCKERa04768901ac1: Suspend/Hibernate through daemon 
instead of greeter (authored by graesslin).

REPOSITORY
  rKSCREENLOCKER KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D827?vs=2085=2092

REVISION DETAIL
  https://phabricator.kde.org/D827

AFFECTED FILES
  CMakeLists.txt
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  powermanagement.cpp
  powermanagement.h
  protocols/ksld.xml
  tests/CMakeLists.txt
  tests/powermanagement.qml
  tests/powermanagementtest.cpp
  waylandserver.cpp
  waylandserver.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, bshah, broulik
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D859: [processui] Safety checks for platform != x11

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLIBKSYSGUARDb57c7ca54609: [processui] Safety checks for 
platform != x11 (authored by graesslin).

REPOSITORY
  rLIBKSYSGUARD KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D859?vs=2090=2093

REVISION DETAIL
  https://phabricator.kde.org/D859

AFFECTED FILES
  processui/ProcessModel.cpp
  processui/ProcessModel_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, mart, sebas, bshah
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D858: [server] Expose executable path in ClientConnection

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  executable-path

REVISION DETAIL
  https://phabricator.kde.org/D858

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, mart, davidedmundson
Cc: bshah, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel