Re: Review Request 127341: Change the way SUID bits are managed

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127341/#review93465
---


Ship it!




>The `kcheckpass` binary only needs the SUID bit set when building
without PAM. If PAM is available, then there's no point in having a SUID
bit set in the first place. This is also how, e.g., Gentoo builds this
code anyway.

That reasoning isn't entirely true. 

Now pam_unix includes a suid binary /usr/bin/unix_chkpwd which is doing what 
this is doing. Older versions (10 years ago) didn't, so at the time we needed 
this for PAM.

However, you're right we don't now.

- David Edmundson


On March 11, 2016, 2:46 p.m., Jan Kundrát wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127341/
> ---
> 
> (Updated March 11, 2016, 2:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kscreenlocker
> 
> 
> Description
> ---
> 
> The `kcheckpass` binary only needs the SUID bit set when building
> without PAM. If PAM is available, then there's no point in having a SUID
> bit set in the first place. This is also how, e.g., Gentoo builds this
> code anyway.
> 
> Also change the way how the SUID bits are managed. Turnes out that cmake
> has a feature for this, and I think that using this feature is better
> than attempting to call chown & chmod manually.
> 
> I don't see a potential for regressions here. The `chown` was previously
> attempted as a poor man's UID detection, so if the build was running as
> non-root, it wasn't possible to add a proper SUID bit, anyway.
> 
> 
> Diffs
> -
> 
>   kcheckpass/CMakeLists.txt c7803c96f62c38edf2016c9160b66213dad89949 
> 
> Diff: https://git.reviewboard.kde.org/r/127341/diff/
> 
> 
> Testing
> ---
> 
> Builds both ways, and the results are as expected. With PAM, everything also 
> works even without the suid bit -- and that's how Gentoo at least has been 
> building this "for ages", AFAIK.
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127320: Inform applet to update menus before using them

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127320/
---

(Updated March 13, 2016, 1:35 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit aa832b7c2b47a69b9ea5c7be3448ad86f57849f0 by David 
Edmundson to branch master.


Repository: plasma-workspace


Description
---

Inform applet to update menus before using them


Diffs
-

  applets/systemtray/systemtray.cpp a16c5d957fd8309513206c27e27ddbe448c0047f 

Diff: https://git.reviewboard.kde.org/r/127320/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127322: remove unused file

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127322/
---

(Updated March 13, 2016, 1:35 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 4263018d5bf61deb16918bb80fc017ee6bbaf246 by David 
Edmundson to branch master.


Repository: plasma-workspace


Description
---

remove unused file


Diffs
-

  applets/systemtray/rootitem.h 748b9c8ae5982815627cecca76af12fc991bb174 
  applets/systemtray/rootitem.cpp 17cd5142dd94244c45f6addaf5dc573177e97893 

Diff: https://git.reviewboard.kde.org/r/127322/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1070: Make panel scripting setLength set min and max length

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  This will be used by any custom layout.js files.
  We don't use it ourselves. All our layouts are maximised panels.
  
  It's other distros layouts that might use it to make a dock style layout and 
the current code basically does nothing.
  
  I'd be happy replacing it with a qWarning() << "This method is deprecated, 
please use setMin..." instead?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1070

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma
Cc: mart, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126970: gtk.css points to nonexistent files (bad filename)

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126970/#review93463
---



Sorry for ignoring this. Seems fine to me. 


But can you also look at https://git.reviewboard.kde.org/r/127323/ and see 
which approach is more correct.

- David Edmundson


On Feb. 2, 2016, 4:24 p.m., Gustavo Alvarez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126970/
> ---
> 
> (Updated Feb. 2, 2016, 4:24 p.m.)
> 
> 
> Review request for Plasma and Andreas Sturmlechner.
> 
> 
> Bugs: 356395
> https://bugs.kde.org/show_bug.cgi?id=356395
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> breeze-dark and breeze GTK3 theme have a assets files with wrong names, this 
> patch rename these files according with the gtk.css file
> 
> renamig these files fix this message:
> 
> Gtk-WARNING **: Error loading image 
> 'file:///usr/share/themes/Breeze-Dark/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png':
>  Error opening file: No such file or directory
> 
> 
> Diffs
> -
> 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark.png 
> 6d21caf 
>   
> Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-d...@2.png 
> 09ed07f 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay.png 
> b260f91 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-over...@2.png 
> 5884f60 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png 
> PRE-CREATION 
>   
> Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-d...@2.png 
> PRE-CREATION 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal.png 
> PRE-CREATION 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizon...@2.png 
> PRE-CREATION 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark.png 
> 6d21caf 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-d...@2.png 
> 09ed07f 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay.png b260f91 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-over...@2.png 5884f60 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png 
> PRE-CREATION 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-d...@2.png 
> PRE-CREATION 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal.png 
> PRE-CREATION 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizon...@2.png 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gustavo Alvarez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126970: gtk.css points to nonexistent files (bad filename)

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126970/#review93461
---


Ship it!




Ship It!

- David Edmundson


On Feb. 2, 2016, 4:24 p.m., Gustavo Alvarez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126970/
> ---
> 
> (Updated Feb. 2, 2016, 4:24 p.m.)
> 
> 
> Review request for Plasma and Andreas Sturmlechner.
> 
> 
> Bugs: 356395
> https://bugs.kde.org/show_bug.cgi?id=356395
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> breeze-dark and breeze GTK3 theme have a assets files with wrong names, this 
> patch rename these files according with the gtk.css file
> 
> renamig these files fix this message:
> 
> Gtk-WARNING **: Error loading image 
> 'file:///usr/share/themes/Breeze-Dark/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png':
>  Error opening file: No such file or directory
> 
> 
> Diffs
> -
> 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark.png 
> 6d21caf 
>   
> Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-d...@2.png 
> 09ed07f 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay.png 
> b260f91 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-over...@2.png 
> 5884f60 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png 
> PRE-CREATION 
>   
> Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-d...@2.png 
> PRE-CREATION 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal.png 
> PRE-CREATION 
>   Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizon...@2.png 
> PRE-CREATION 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark.png 
> 6d21caf 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-d...@2.png 
> 09ed07f 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay.png b260f91 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-over...@2.png 5884f60 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png 
> PRE-CREATION 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-d...@2.png 
> PRE-CREATION 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal.png 
> PRE-CREATION 
>   Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizon...@2.png 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126970/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gustavo Alvarez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review93459
---




shell/panelview.cpp (line 682)


This is wrong as you connect to the same signal multiple times.

this connect should be in the constructor, and we should lose 
integrateScreen() from showEvent()



shell/shellcorona.cpp (line 817)


you also need this if any one screen size changes not just adding/removing. 
Which I said in my last review.


- David Edmundson


On March 12, 2016, 5:40 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> ---
> 
> (Updated March 12, 2016, 5:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Now that everything's in place in Qt, we can do that.
> 
> It basically removes all the translation layer between KScreen and QScreen.
> 
> NOTE: This can't be merged until Qt 5.6 is a dependency.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d407aed 
>   shell/CMakeLists.txt 7be2cfd 
>   shell/panelview.h c671f14 
>   shell/panelview.cpp c8c3c71 
>   shell/shellcorona.h b803239 
>   shell/shellcorona.cpp 54667da 
> 
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
> 
> 
> Testing
> ---
> 
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. 
> (There could be crashes, I just didn't find them :D)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 473 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/473/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 12 Mar 2016 21:54:09 +
Build duration: 7.4 sec

CHANGE SET
No changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/#review93457
---


Fix it, then Ship it!





shell/CMakeLists.txt (line 42)


different commit



shell/shellmanager.h (line 48)


s_testModeLayout



shell/testcorona.h (line 25)


in the other case FooCorona is used as a convention for subclasses, 
CoronaTest would make it more obvious this is not a corona subclass


- Marco Martin


On March 12, 2016, 3:59 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127346/
> ---
> 
> (Updated March 12, 2016, 3:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Makes it possible to test how/if a plasmoid behaves correctly on the most 
> similar environment possible to what the user would find on a production 
> system.
> 
> * Loads a plasmoid on a panel and the desktop.
> * Lets it test his own stuff
> * Notifies, when done, if failed.
> 
> There's still more to look into:
> 
> * what objects need to be passed, besides the `Plasma::AppletQuickItem`.
> * good things to test
> * how to test other shells than the desktop shell
> 
> Nevertheless, it looks to me that it's a step forward. Comments welcome.
> 
> 
> Diffs
> -
> 
>   applets/analog-clock/contents/tests/test.qml PRE-CREATION 
>   shell/CMakeLists.txt e553133 
>   shell/main.cpp d6e3640 
>   shell/shellcorona.cpp 54667da 
>   shell/shellmanager.h 17acbc6 
>   shell/shellmanager.cpp 3c3638f 
>   shell/testcorona.h PRE-CREATION 
>   shell/testcorona.cpp PRE-CREATION 
>   shell/tests/CMakeLists.txt PRE-CREATION 
>   shell/tests/testLayout.js.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127346/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1113: New Desktop Theme KCM

[drosca (David Rosca)]

drosca added inline comments.

INLINE COMMENTS
  kcms/desktoptheme-qml/kcm.h:41 It is actually needed to cast to int in 
model::roleNames()
  kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml:31 Because air's 
background svg has huge margins.
  This special case could be removed when we can get transparent margins size 
from FrameSvg.
  kcms/desktoptheme-qml/package/contents/ui/main.qml:192 Good idea, I think it 
would make sense to have it in kdeclarative.
  kcms/desktoptheme-qml/package/metadata.desktop:7 Actually, this is metadata 
for kpackage and not used from KCM. So I think this line can just be removed.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, sebas, Plasma
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 818 lines] D1113: New Desktop Theme KCM

[drosca (David Rosca)]

drosca updated this revision to Diff 2751.
drosca added a comment.


  Fix issues
  Remove shadow from clock hands + add center screw
  Always show vertical scrollbar to fix binding loop on width

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1113?vs=2721=2751

BRANCH
  desktoptheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1113

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/desktoptheme-qml/CMakeLists.txt
  kcms/desktoptheme-qml/Messages.sh
  kcms/desktoptheme-qml/kcm.cpp
  kcms/desktoptheme-qml/kcm.h
  kcms/desktoptheme-qml/kcm_desktoptheme.desktop
  kcms/desktoptheme-qml/package/contents/ui/Hand.qml
  kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme-qml/package/contents/ui/main.qml
  kcms/desktoptheme-qml/package/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, sebas, Plasma
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1134: Alternatives: Add new applet only after the old one was removed

[mart (Marco Martin)]

mart added a comment.


  good that makes it look more uniform.
  tough at some point there was the idea of the possibility of running a script 
between the addition of the new one and the destruction of the old one, making 
possible for a script to try to convert some of the config between the two.
  that was probaably not an awesome idea as it has a lot of obvious problems, 
so in general the patch is good for me, just to consider the possibility

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1134

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: mart, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/
---

Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.


Repository: kdeplasma-addons


Description
---

1. Correct highlighted tabs visablity
2. Scale content on update comic
3. Open/close fullview widget
4. Added icon
5. Resize content


Diffs
-

  applets/comic/comic.h 302f7b8 
  applets/comic/comic.cpp 97ec6a1 
  applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
  applets/comic/package/contents/ui/main.qml 4cf1cae 

Diff: https://git.reviewboard.kde.org/r/127356/diff/


Testing
---

Resize cannot get to work as i want :)
Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
60% of current image, i don't understaind how this must be written to start 
working :P


File Attachments


Screenshot_20160312_214006.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

[Aleix Pol Gonzalez]

> On March 12, 2016, 8:26 p.m., Marco Martin wrote:
> > src/plasmaquick/appletquickitem.h, line 31
> > 
> >
> > appletquickitem.h is now installed as a public header, <> include 
> > should be fixed somehow

Eh, I'll drop this change from the patch, it wasn't supposed to be part of this.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93455
---


On March 12, 2016, 4 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 4 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 5d17550 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93455
---




src/plasmaquick/appletquickitem.h (line 31)


appletquickitem.h is now installed as a public header, <> include should be 
fixed somehow


- Marco Martin


On March 12, 2016, 3 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 3 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 5d17550 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: is there a website / home page for Kirigami that I could point to in my announcement?

[Sebastian Kügler]

On Saturday, March 12, 2016 10:06:43 Dirk Hohndel wrote:
> On Mar 12, 2016, at 9:48 AM, Sebastian Kügler  wrote:
> 
> Sore point, really. Our web-presence currently utterly sucks (there's some
> work going on in that area), but no sensible page to link to, other than,
> perhaps. ... http://plasma-mobile.org/ or
> https://projects.kde.org/projects/playground/libs/kirigami
> (the latter being void of useful information and the link to the repo even
> is broken).
> 
> We *may* have to work on the PR side of Kirigami ... to put it mildly.
> 
> Umm. Yeah. And I thought our web presence was sub-optimal. That's pretty
> sad.
> 
> I'll go with the plasma-mobile.org link because the rest is rather...
> dreary.

We go pretty far to make you feel better. ;-)
-- 
sebas

Sebastian Kügler|http://vizZzion.org| http://kde.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 23 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 12 Mar 2016 18:44:59 +
Build duration: 2 min 35 sec

CHANGE SET
No changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: is there a website / home page for Kirigami that I could point to in my announcement?

[Dirk Hohndel]

> On Mar 12, 2016, at 9:48 AM, Sebastian Kügler  wrote:
> 
> Sore point, really. Our web-presence currently utterly sucks (there's some
> work going on in that area), but no sensible page to link to, other than,
> perhaps. ... http://plasma-mobile.org/ or
> https://projects.kde.org/projects/playground/libs/kirigami
> (the latter being void of useful information and the link to the repo even is
> broken).
> 
> We *may* have to work on the PR side of Kirigami ... to put it mildly.

Umm. Yeah. And I thought our web presence was sub-optimal. That's pretty sad.

I'll go with the plasma-mobile.org  link because the 
rest is rather... dreary.

/D___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: is there a website / home page for Kirigami that I could point to in my announcement?

[Sebastian Kügler]

On Saturday, March 12, 2016 09:31:14 Dirk Hohndel wrote:
> Or what should I link to? The text I have right now is (based on what Thomas
> suggested)
> 
> This release is the result of years of work on Subsurface and a year long
> development effort towards a mobile user interface that would shine on
> phones and tablets. We got tremendous help from the KDE community to get us
> to this first release. Subsurface-mobile implements the Kirigami UI using
> the Kirigami Controls by KDE
> 
> Does this work for you? How should this link to KDE/Plasma/Kirigami
> websites?

Sore point, really. Our web-presence currently utterly sucks (there's some 
work going on in that area), but no sensible page to link to, other than, 
perhaps. ... http://plasma-mobile.org/ or 
https://projects.kde.org/projects/playground/libs/kirigami
 (the latter being void of useful information and the link to the repo even is 
broken).

We *may* have to work on the PR side of Kirigami ... to put it mildly.
-- 
sebas

Sebastian Kügler|http://vizZzion.org| http://kde.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/
---

(Updated March 12, 2016, 6:40 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

Now that everything's in place in Qt, we can do that.

It basically removes all the translation layer between KScreen and QScreen.

NOTE: This can't be merged until Qt 5.6 is a dependency.


Diffs
-

  CMakeLists.txt d407aed 
  shell/CMakeLists.txt 7be2cfd 
  shell/panelview.h c671f14 
  shell/panelview.cpp c8c3c71 
  shell/shellcorona.h b803239 
  shell/shellcorona.cpp 54667da 

Diff: https://git.reviewboard.kde.org/r/125451/diff/


Testing
---

Hands-on testing, it's been working quite fluid and I couldn't find a crash. 
(There could be crashes, I just didn't find them :D)


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

is there a website / home page for Kirigami that I could point to in my announcement?

[Dirk Hohndel]

Or what should I link to? The text I have right now is (based on what Thomas 
suggested)

This release is the result of years of work on Subsurface and a year long 
development effort towards a mobile user interface that would shine on phones 
and tablets. We got tremendous help from the KDE community to get us to this 
first release. Subsurface-mobile implements the Kirigami UI using the Kirigami 
Controls by KDE

Does this work for you? How should this link to KDE/Plasma/Kirigami websites?

/D___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D1113: New Desktop Theme KCM

[Sebastian Kügler]

sebas requested changes to this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision now requires changes to proceed.


  Looks really nice already! Good job!
  
  Some comments inline.

INLINE COMMENTS
  kcms/desktoptheme-qml/kcm.cpp:62 QStringLiteral / QLatin1String (I still have 
trouble deciding which to use when); also on the following lines
  kcms/desktoptheme-qml/kcm.cpp:70 items in m_theme are parented to this, so 
this line shouldn't be needed
  kcms/desktoptheme-qml/kcm.cpp:97 popup() or show() instead of exec() as to 
not block?
  kcms/desktoptheme-qml/kcm.cpp:124 Showing the exit code reminds me a lot of 
windows 98, can we show a meaningful error message instead?
  kcms/desktoptheme-qml/kcm.cpp:173 whitespace, space after Q_FOREACH (same on 
a couple of other lines)
  kcms/desktoptheme-qml/kcm.cpp:178 Can be simplified by adding 
QDir::NoDotAndDotDot to the entryList flags
  kcms/desktoptheme-qml/kcm.cpp:188 const 
  kcms/desktoptheme-qml/kcm.cpp:190 const
  kcms/desktoptheme-qml/kcm.cpp:204 remove
  kcms/desktoptheme-qml/kcm.cpp:240 perhaps on one line? (Not really critical, 
if you prefer it like this, ignore this comment)
  kcms/desktoptheme-qml/kcm.cpp:245 const
  kcms/desktoptheme-qml/kcm.cpp:248 merge this and the following line, make it 
const
  kcms/desktoptheme-qml/kcm.cpp:260 exit code should be user-readable (see also 
above)
  kcms/desktoptheme-qml/kcm.h:40 I understand that enum class makes this 
type-safe (i.e. will forbid casting to/from int)
  kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml:30 Why's that?
  kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml:103 
units.smallSpacing?
  kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml:116 use 
units.smallSpacing
  kcms/desktoptheme-qml/package/contents/ui/main.qml:150 i18n()
  kcms/desktoptheme-qml/package/contents/ui/main.qml:156 i18n()
  kcms/desktoptheme-qml/package/contents/ui/main.qml:162 i18n()
  kcms/desktoptheme-qml/package/contents/ui/main.qml:191 we have a couple of 
those, would be good to at least define this interval somewhere centrally, so 
we get less hardcoded values all over the code
  kcms/desktoptheme-qml/package/metadata.desktop:5 Encoding key is deprecated, 
defaults to UTF-8 anyway
  kcms/desktoptheme-qml/package/metadata.desktop:6 should not be empty (it's 
used for search in systemsettings)
  kcms/desktoptheme-qml/package/metadata.desktop:19 can be removed

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, sebas
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1117: Fix assigning undefined to double warning on startup

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  desktop-preferred-size-warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1117

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, sebas
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/
---

(Updated March 12, 2016, 4:59 p.m.)


Review request for Plasma.


Changes
---

Address some of Marco's concerns.


Summary (updated)
-

Infrastructure for Plasmoid integration testing


Repository: plasma-workspace


Description
---

Makes it possible to test how/if a plasmoid behaves correctly on the most 
similar environment possible to what the user would find on a production system.

* Loads a plasmoid on a panel and the desktop.
* Lets it test his own stuff
* Notifies, when done, if failed.

There's still more to look into:

* what objects need to be passed, besides the `Plasma::AppletQuickItem`.
* good things to test
* how to test other shells than the desktop shell

Nevertheless, it looks to me that it's a step forward. Comments welcome.


Diffs (updated)
-

  applets/analog-clock/contents/tests/test.qml PRE-CREATION 
  shell/CMakeLists.txt e553133 
  shell/main.cpp d6e3640 
  shell/shellcorona.cpp 54667da 
  shell/shellmanager.h 17acbc6 
  shell/shellmanager.cpp 3c3638f 
  shell/testcorona.h PRE-CREATION 
  shell/testcorona.cpp PRE-CREATION 
  shell/tests/CMakeLists.txt PRE-CREATION 
  shell/tests/testLayout.js.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127346/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

[Aleix Pol Gonzalez]

> On March 12, 2016, 4:12 p.m., Marco Martin wrote:
> > shell/main.cpp, line 128
> > 
> >
> > check if it's in standalone mode and not enable the test in that case, 
> > as it would not be a shellcorona

We don't track shellcorona specifically anymore because of other changes.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/#review93450
---


On March 12, 2016, 2:13 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127346/
> ---
> 
> (Updated March 12, 2016, 2:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Makes it possible to test how/if a plasmoid behaves correctly on the most 
> similar environment possible to what the user would find on a production 
> system.
> 
> * Loads a plasmoid on a panel and the desktop.
> * Lets it test his own stuff
> * Notifies, when done, if failed.
> 
> There's still more to look into:
> 
> * what objects need to be passed, besides the `Plasma::AppletQuickItem`.
> * good things to test
> * how to test other shells than the desktop shell
> 
> Nevertheless, it looks to me that it's a step forward. Comments welcome.
> 
> 
> Diffs
> -
> 
>   applets/analog-clock/contents/tests/test.qml PRE-CREATION 
>   shell/CMakeLists.txt e553133 
>   shell/main.cpp d6e3640 
>   shell/shellcorona.h 271d7bf 
>   shell/shellcorona.cpp 54667da 
>   shell/shellmanager.h 17acbc6 
>   shell/shellmanager.cpp 3c3638f 
>   shell/testcorona.h PRE-CREATION 
>   shell/testcorona.cpp PRE-CREATION 
>   shell/tests/CMakeLists.txt PRE-CREATION 
>   shell/tests/testLayout.js.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127346/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/#review93450
---




shell/main.cpp (line 99)


specifies the javscript file used to construct an autotest environment



shell/main.cpp (line 128)


check if it's in standalone mode and not enable the test in that case, as 
it would not be a shellcorona


- Marco Martin


On March 12, 2016, 1:13 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127346/
> ---
> 
> (Updated March 12, 2016, 1:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Makes it possible to test how/if a plasmoid behaves correctly on the most 
> similar environment possible to what the user would find on a production 
> system.
> 
> * Loads a plasmoid on a panel and the desktop.
> * Lets it test his own stuff
> * Notifies, when done, if failed.
> 
> There's still more to look into:
> 
> * what objects need to be passed, besides the `Plasma::AppletQuickItem`.
> * good things to test
> * how to test other shells than the desktop shell
> 
> Nevertheless, it looks to me that it's a step forward. Comments welcome.
> 
> 
> Diffs
> -
> 
>   applets/analog-clock/contents/tests/test.qml PRE-CREATION 
>   shell/CMakeLists.txt e553133 
>   shell/main.cpp d6e3640 
>   shell/shellcorona.h 271d7bf 
>   shell/shellcorona.cpp 54667da 
>   shell/shellmanager.h 17acbc6 
>   shell/shellmanager.cpp 3c3638f 
>   shell/testcorona.h PRE-CREATION 
>   shell/testcorona.cpp PRE-CREATION 
>   shell/tests/CMakeLists.txt PRE-CREATION 
>   shell/tests/testLayout.js.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127346/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/
---

(Updated March 12, 2016, 4 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Properly check if the config is empty.


Repository: plasma-framework


Description
---

In an attempt to make it possible for plasmoid to test themselves in the 
different shells, provide API to exatract the object that will test the 
plasmoid instance.


Diffs (updated)
-

  src/plasma/corona.cpp 5d17550 
  src/plasma/private/packages.cpp a5ba81a 
  src/plasmaquick/appletquickitem.h 4f25f5d 
  src/plasmaquick/appletquickitem.cpp 9242e9e 
  src/plasmaquick/private/appletquickitem_p.h 9c24734 

Diff: https://git.reviewboard.kde.org/r/127345/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 17 lines] D1134: Alternatives: Add new applet only after the old one was removed

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  New applet is now added at the same position as the old one.
  
  CCBUG: 358827

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  alternatives-helper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1134

AFFECTED FILES
  shell/alternativeshelper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93447
---


Ship it!




Ship It!

- Sebastian Kügler


On March 12, 2016, 1:13 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 1:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 5d17550 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/
---

(Updated March 12, 2016, 2:13 p.m.)


Review request for Plasma.


Changes
---

Adopt marco's approach. Slightly more complex but more powerful.


Repository: plasma-workspace


Description (updated)
---

Makes it possible to test how/if a plasmoid behaves correctly on the most 
similar environment possible to what the user would find on a production system.

* Loads a plasmoid on a panel and the desktop.
* Lets it test his own stuff
* Notifies, when done, if failed.

There's still more to look into:

* what objects need to be passed, besides the `Plasma::AppletQuickItem`.
* good things to test
* how to test other shells than the desktop shell

Nevertheless, it looks to me that it's a step forward. Comments welcome.


Diffs (updated)
-

  applets/analog-clock/contents/tests/test.qml PRE-CREATION 
  shell/CMakeLists.txt e553133 
  shell/main.cpp d6e3640 
  shell/shellcorona.h 271d7bf 
  shell/shellcorona.cpp 54667da 
  shell/shellmanager.h 17acbc6 
  shell/shellmanager.cpp 3c3638f 
  shell/testcorona.h PRE-CREATION 
  shell/testcorona.cpp PRE-CREATION 
  shell/tests/CMakeLists.txt PRE-CREATION 
  shell/tests/testLayout.js.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127346/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/
---

(Updated March 12, 2016, 2:13 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

* Change the test file name to test.qml
* Don't load a layout if it doesn't exist. Otherwise it reports that 
`::startupCompleted()` despite not having any containments.


Repository: plasma-framework


Description
---

In an attempt to make it possible for plasmoid to test themselves in the 
different shells, provide API to exatract the object that will test the 
plasmoid instance.


Diffs (updated)
-

  src/plasma/corona.cpp 5d17550 
  src/plasma/private/packages.cpp a5ba81a 
  src/plasmaquick/appletquickitem.h 4f25f5d 
  src/plasmaquick/appletquickitem.cpp 9242e9e 
  src/plasmaquick/private/appletquickitem_p.h 9c24734 

Diff: https://git.reviewboard.kde.org/r/127345/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1130: Set the decoration mode if it doesn't match the server's default mode

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAINTEGRATIONad2a2bcff266: Set the decoration mode if it 
doesn't match the server's default mode (authored by graesslin).

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1130?vs=2734=2738

REVISION DETAIL
  https://phabricator.kde.org/D1130

AFFECTED FILES
  src/platformtheme/kwaylandintegration.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127355: Replace QMenu::exec with QMenu::popup

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127355/
---

(Updated March 12, 2016, 12:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 8f6d1f17e455334fe64b879bcb90bdc238b22696 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

^^


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.cpp 2337652 
  src/scriptengines/qml/plasmoid/containmentinterface.h fe6e6db 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp f44bd07 

Diff: https://git.reviewboard.kde.org/r/127355/diff/


Testing
---

Works as before. There are still two places where QMenu::exec is used 
(containmentinterface.cpp: processMimeData and mimeTypeRetrieved) but the code 
is much more complex to replace.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127344: FrameSvg: Fix dangling pointers in sharedFrames when theme changes

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127344/
---

(Updated March 12, 2016, 12:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 974a2b5071b4f0c12a97525d18c8cf7c5c93f548 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

Store theme pointer in FrameData and set it when adding to sharedFrames.


Diffs
-

  autotests/framesvgtest.h 4d31e10 
  autotests/framesvgtest.cpp e3c1f33 
  src/plasma/framesvg.cpp 96b3156 
  src/plasma/private/framesvg_p.h beee956 

Diff: https://git.reviewboard.kde.org/r/127344/diff/


Testing
---

Test not crashing


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127342: IconItem: Schedule pixmap update when window changes

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127342/
---

(Updated March 12, 2016, 12:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit fd4632230006a81c37a9ca2678b36fd49bd6c714 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

QQuickItem::polish is not called when window changes.

Regression from 344d04e2306ca2fdaf17269bc218f4fad065cbbf


Diffs
-

  autotests/iconitemtest.h 99ecc6c 
  autotests/iconitemtest.cpp 026dda4 
  src/declarativeimports/core/iconitem.cpp e199561 

Diff: https://git.reviewboard.kde.org/r/127342/diff/


Testing
---

Add show activity manager applet -> remove -> undo -> icon is now correctly 
rendered.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127355: Replace QMenu::exec with QMenu::popup

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127355/#review93446
---


Ship it!




- Marco Martin


On March 12, 2016, 11:58 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127355/
> ---
> 
> (Updated March 12, 2016, 11:58 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 2337652 
>   src/scriptengines/qml/plasmoid/containmentinterface.h fe6e6db 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp f44bd07 
> 
> Diff: https://git.reviewboard.kde.org/r/127355/diff/
> 
> 
> Testing
> ---
> 
> Works as before. There are still two places where QMenu::exec is used 
> (containmentinterface.cpp: processMimeData and mimeTypeRetrieved) but the 
> code is much more complex to replace.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127355: Replace QMenu::exec with QMenu::popup

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127355/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

^^


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.cpp 2337652 
  src/scriptengines/qml/plasmoid/containmentinterface.h fe6e6db 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp f44bd07 

Diff: https://git.reviewboard.kde.org/r/127355/diff/


Testing
---

Works as before. There are still two places where QMenu::exec is used 
(containmentinterface.cpp: processMimeData and mimeTypeRetrieved) but the code 
is much more complex to replace.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1129: Add a default mode event to ServerSideDecorationManager

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
graesslin marked an inline comment as done.
Closed by commit rKWAYLANDba479e3ee250: Add a default mode event to 
ServerSideDecorationManager (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D1129?vs=2732=2735#toc

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1129?vs=2732=2735

REVISION DETAIL
  https://phabricator.kde.org/D1129

AFFECTED FILES
  src/client/protocols/server-decoration.xml
  src/client/server_decoration.cpp
  src/client/server_decoration.h
  src/server/server_decoration_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1129: Add a default mode event to ServerSideDecorationManager

[Martin Gräßlin]

graesslin marked 2 inline comments as done.

INLINE COMMENTS
  src/client/protocols/server-decoration.xml:54 This is a protocol and not a 
C-based programming language ;-)
  
  I changed it to "request_mode is requested"

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  server-deco-default-mode-5.6

REVISION DETAIL
  https://phabricator.kde.org/D1129

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1129: Add a default mode event to ServerSideDecorationManager

[Sebastian Kügler]

sebas accepted this revision.
This revision is now accepted and ready to land.

INLINE COMMENTS
  src/client/protocols/server-decoration.xml:53 till -> until
  src/client/protocols/server-decoration.xml:54 requestMode() makes more sense 
here

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  server-deco-default-mode-5.6

REVISION DETAIL
  https://phabricator.kde.org/D1129

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1130: Set the decoration mode if it doesn't match the server's default mode

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.


  If autotests pass, go for it. :-)

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  decoration-set-mode-on-bind-5.6

REVISION DETAIL
  https://phabricator.kde.org/D1130

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: sebas, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Abandoned] D1128: Trigger a roundtrip after creating the ServerSideDecoration

[Martin Gräßlin]

graesslin abandoned this revision.
graesslin added a comment.


  better approach with https://phabricator.kde.org/D1129 and 
https://phabricator.kde.org/D1130

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1128

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1130: Set the decoration mode if it doesn't match the server's default mode

[Martin Gräßlin]

graesslin added a dependency: D1129: Add a default mode event to 
ServerSideDecorationManager.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1130

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1129: Add a default mode event to ServerSideDecorationManager

[Martin Gräßlin]

graesslin added a dependent revision: D1130: Set the decoration mode if it 
doesn't match the server's default mode.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1129

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 5 lines] D1130: Set the decoration mode if it doesn't match the server's default mode

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  KWayland now provides the default decoration mode of the server allowing
  us to set the required decoration mode without having to wait till the
  server sent us the mode it wants.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  decoration-set-mode-on-bind-5.6

REVISION DETAIL
  https://phabricator.kde.org/D1130

AFFECTED FILES
  src/platformtheme/kwaylandintegration.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 174 lines] D1129: Add a default mode event to ServerSideDecorationManager

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: Plasma, sebas.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  The ServerSideDecorationManager gains a new event which gets sent
  to the client when it binds the manager. The event indicates the
  default server decoration mode used by the server. This allows the
  client to know the decoration mode when it creates a decoration and
  thus does not need to roundtrip to the server to get the mode.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  server-deco-default-mode-5.6

REVISION DETAIL
  https://phabricator.kde.org/D1129

AFFECTED FILES
  src/client/protocols/server-decoration.xml
  src/client/server_decoration.cpp
  src/client/server_decoration.h
  src/server/server_decoration_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KWayland as framework

[Ivan Čukić]

> Opinions? comments?

+1 from me. I guess it needs to be reviewed before it is moved to
frameworks, but that should not take much time (I'd say, it will take
exactly two weeks ;) )

Cheers
Ivan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 22 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 12 Mar 2016 10:32:51 +
Build duration: 1 min 56 sec

CHANGE SET
No changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93444
---


Ship it!




for me is a ship it, modulo just calling it just "test.qml" as sebas already 
pointed out

- Marco Martin


On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

[Marco Martin]

> On March 12, 2016, 10:26 a.m., Sebastian Kügler wrote:
> > src/plasma/private/packages.cpp, line 46
> > 
> >
> > I'd just go for test.qml or perhaps even autotest.qml

test.qml would be good if the abstract name is just "test" (don't want weird 
inconsistencies as in the past happened with "code" vs "scritps")


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93442
---


On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93442
---


Fix it, then Ship it!




Like my other review: if we want this approach, the code is fine and good to go.


src/plasma/private/packages.cpp (line 46)


I'd just go for test.qml or perhaps even autotest.qml


- Sebastian Kügler


On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127346/#review93441
---


Fix it, then Ship it!




I'm fine with the approach, but let's first discuss if we the other approach we 
talked about is feasible, if not, this one should go in. Thanks!


shell/main.cpp (line 99)


Hm, I think this could use a reference to more documentation



shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml (line 8)


minor, whitespace



shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml (line 10)


minor; whitespace



shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop (line 2)


This is how we ROLL!


- Sebastian Kügler


On March 12, 2016, 12:43 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127346/
> ---
> 
> (Updated March 12, 2016, 12:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Makes it possible to test how/if a plasmoid behaves correctly on the most 
> similar environment possible to what the user would find on a production 
> system.
> 
> * Loads a plasmoid on a panel and the desktop.
> * Lets it test his own stuff
> * Notifies, when done, if failed.
> 
> There's still more to look into:
> * what objects need to be passed, besides the `Plasma::AppletQuickItem`.
> * good things to test
> * how to test other shells than the desktop shell
> 
> Nevertheless, it looks to me that it's a step forward. Comments welcome.
> 
> 
> Diffs
> -
> 
>   applets/analog-clock/contents/tests/testmain.qml PRE-CREATION 
>   shell/CMakeLists.txt e553133 
>   shell/main.cpp d6e3640 
>   shell/shellmanager.h 17acbc6 
>   shell/shellmanager.cpp 3c3638f 
>   shell/testcorona.h PRE-CREATION 
>   shell/testcorona.cpp PRE-CREATION 
>   shell/tests/CMakeLists.txt PRE-CREATION 
>   shell/tests/plasma/shells/org.kde.plasmashelltest/contents/layout.js.in 
> PRE-CREATION 
>   shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml 
> PRE-CREATION 
>   shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127346/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

KWayland as framework

[Marco Martin]

Hi all,
As you know in this moment a central effort of the Plasma team is to
port the essential bits and pieces of the workspace (such as KWin,
plasmashell and various helper bits) to Wayland in order to provide a
good usable desktop experience on Wayland before the end of the year.

A central part for integrating the shell (and potentially some other
applications as soon they need anything "special" from the compositor)
with wayland is the KWayland library, that implements with a
Qt-friendly api some central wayland protocols plus some of our
extended ones.

now, for some things, I would need to use it from plasma-framework, as
some plasma components that are toplevel window (Dialog) needs to
integrate with some wayland protocols (extended window type, shadows)
and probaly other things (such as the window thumbnail component)

The library only depends from Qt and wayland libraries, and it's a
while we have a policy of abi stability for it.

I think the library now is mature enough to be a framework (tier 1 as
doesn't depend on other frameworks) there won't be abi incompatible
changes for the foreseeable future, just additions.

Opinions? comments?

--
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127349: Fix wrong usage of KDE brand in kcmshell

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127349/
---

(Updated March 12, 2016, 10:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit dcf3ae31cda52df80e91f580e9437beb6a127083 by Sebastian 
Kügler to branch master.


Repository: kde-cli-tools


Description
---

Window title refers to system settings now instead of KDE control


Diffs
-

  kcmshell/Mainpage.dox 0e1abeb 
  kcmshell/main.cpp 5f6bf1b 

Diff: https://git.reviewboard.kde.org/r/127349/diff/


Testing
---

Opened Energy Saving settings from battery applet's conext menu, shows System 
Settings Module in the Window title as expected


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 12 Mar 2016 09:21:21 +
Build duration: 2 min 53 sec

CHANGE SET
Revision 7a08f4178912a7f91c972808c1a6e21933505d29 by Marco Martin: (dont 
try to scale the pager to Infinity)
  change: edit applets/pager/package/contents/ui/main.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1128: Trigger a roundtrip after creating the ServerSideDecoration

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS
  src/platformtheme/kwaylandintegration.cpp:93 I'm not really happy with the 
solution. It works, but it introduces a roundtrip. Maybe it's better to adjust 
the protocol to send out the default on binding the interface.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  kwayland-roundtrip-server

REVISION DETAIL
  https://phabricator.kde.org/D1128

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127352: [kstyle] Implement window shadows on Wayland

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127352/#review93432
---



+1

- Marco Martin


On March 12, 2016, 8:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127352/
> ---
> 
> (Updated March 12, 2016, 8:28 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Integrate with Wayland and create a ShadowManager if available.
> With the ShadowManager it's possible to create a Shadow for a Surface.
> 
> The Wayland shadow is very similar to the X11 based one, so a lot of
> code can be shared. The code is slightly refactored to share the common
> code paths to create and destroy the shadow.
> 
> 
> Diffs
> -
> 
>   kstyle/CMakeLists.txt b2c6dc847fef1c7876a0ac1af9e28f47422b620b 
>   kstyle/breezeshadowhelper.h 0c868d3686eec67e630ce08c36df6b4cf34d7f1c 
>   kstyle/breezeshadowhelper.cpp 1eb1ddc6a154d8865b39936718f6a5d5ef8f7fdd 
>   kstyle/config-breeze.h.cmake ba2b5f64c1ca855c541fd7eb0e919b8f897f481f 
> 
> Diff: https://git.reviewboard.kde.org/r/127352/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1128: Trigger a roundtrip after creating the ServerSideDecoration

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  kwayland-roundtrip-server

REVISION DETAIL
  https://phabricator.kde.org/D1128

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127352: [kstyle] Implement window shadows on Wayland

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127352/
---

Review request for Plasma and Hugo Pereira Da Costa.


Repository: breeze


Description
---

Integrate with Wayland and create a ShadowManager if available.
With the ShadowManager it's possible to create a Shadow for a Surface.

The Wayland shadow is very similar to the X11 based one, so a lot of
code can be shared. The code is slightly refactored to share the common
code paths to create and destroy the shadow.


Diffs
-

  kstyle/CMakeLists.txt b2c6dc847fef1c7876a0ac1af9e28f47422b620b 
  kstyle/breezeshadowhelper.h 0c868d3686eec67e630ce08c36df6b4cf34d7f1c 
  kstyle/breezeshadowhelper.cpp 1eb1ddc6a154d8865b39936718f6a5d5ef8f7fdd 
  kstyle/config-breeze.h.cmake ba2b5f64c1ca855c541fd7eb0e919b8f897f481f 

Diff: https://git.reviewboard.kde.org/r/127352/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 5 lines] D1128: Trigger a roundtrip after creating the ServerSideDecoration

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  The server sends out the desired mode directly after creating the
  ServerSideDecoration. By triggering a roundtrip we make sure that
  we now how the server wants us to render the window before we start
  to render the window.
  
  Also it prevents the server to create and directly destroy a server
  decoration if it defaults to server decoration and the window is going
  to be client side decorated.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  kwayland-roundtrip-server

REVISION DETAIL
  https://phabricator.kde.org/D1128

AFFECTED FILES
  src/platformtheme/kwaylandintegration.cpp
  src/platformtheme/kwaylandintegration.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel